GNU bug report logs - #39138
28.0.50; Add variables for shell command output buffer names

Previous Next

Full log

View this message in rfc822 format

From: Robert Pluim <rpluim <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 39138 <at> debbugs.gnu.org, Tino Calancha <tino.calancha <at> gmail.com>
Subject: bug#39138: 28.0.50; Add variables for shell command output buffer names
Date: Wed, 15 Jan 2020 09:03:05 +0100

>>>>> On Tue, 14 Jan 2020 23:43:00 +0100, Michael Albinus <michael.albinus <at> gmx.de> said:

    Michael> Tino Calancha <tino.calancha <at> gmail.com> writes:
    >> --- a/lisp/net/tramp.el
    >> +++ b/lisp/net/tramp.el
    >> @@ -3658,8 +3658,8 @@ tramp-handle-shell-command
    >> (current-buffer))
    >> (t (get-buffer-create
    >> (if asynchronous
    >> -		   "*Async Shell Command*"
    >> -		 "*Shell Command Output*")))))
    >> +		   shell-command-buffer-name-async
    >> +		 shell-command-buffer-name)))))
    >> (error-buffer
    >> (cond
    >> ((bufferp error-buffer) error-buffer)

    Michael> OK for me. However, I will tweak this a little bit once committed, in
    Michael> order to keep Tramp's backward compatibility. Likely like this:

    Michael> (or (bound-and-true-p shell-command-buffer-name-async) "*Async Shell Command*")

    Michael> etc. Plus a comment, which Emacs version has introduced the variables,
    Michael> in order to know when this compatibility hack can be removed.

Tino, would it be possible to add text back in the manual saying what
the default values of these new variables are? People reading it
inside Emacs can obviously just inspect their values, but not everyone
reads inside Emacs.

Robert

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.