GNU bug report logs - #39121
27.0.60; occur: Add bindings for next-error-no-select

Previous Next

Full log

Message #54 received at 39121 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: mattiase <at> acm.org, tino.calancha <at> gmail.com, 39121 <at> debbugs.gnu.org,
 juri <at> linkov.net
Subject: Re: bug#39121: 27.0.60; occur: Add bindings for  next-error-no-select
Date: Sun, 25 Jul 2021 12:16:42 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Sun, 25 Jul 2021 08:41:14 +0200
> Cc: Juri Linkov <juri <at> linkov.net>, 39121 <at> debbugs.gnu.org,
>  Tino Calancha <tino.calancha <at> gmail.com>
> 
> Mattias Engdegård <mattiase <at> acm.org> writes:
> 
> > All right, this might work. Patch!
> 
> Skimming the patch, it makes sense to me.  (But I didn't try it.)
> 
> > The immediate visible benefit is that all matches on the same line are
> > highlighted, not just the first one. It also fixes the compatibility
> > problems mentioned above by removing occur-highlight-regexp entirely.
> >
> > External packages that populate occur-mode buffers themselves should
> > still work, since the old `occur-target` property format is still
> > recognised. In those cases we just highlight from the first match to
> > the end of the line.
> 
> Great; go ahead and push.
> 
> (And I see that `occur-highlight-regexp' was introduced after emacs-27,
> so it's indeed OK to just remove it like your patch does.)

Should we say something about these changes in NEWS?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.