From unknown Wed Jun 18 23:05:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#39121 <39121@debbugs.gnu.org> To: bug#39121 <39121@debbugs.gnu.org> Subject: Status: 27.0.60; occur: Add bindings for next-error-no-select Reply-To: bug#39121 <39121@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:05:03 +0000 retitle 39121 27.0.60; occur: Add bindings for next-error-no-select reassign 39121 emacs submitter 39121 Tino Calancha severity 39121 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 13 15:51:12 2020 Received: (at submit) by debbugs.gnu.org; 13 Jan 2020 20:51:12 +0000 Received: from localhost ([127.0.0.1]:60180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ir6g4-0001Ds-Af for submit@debbugs.gnu.org; Mon, 13 Jan 2020 15:51:12 -0500 Received: from lists.gnu.org ([209.51.188.17]:41241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ir6g2-0001Dk-0V for submit@debbugs.gnu.org; Mon, 13 Jan 2020 15:51:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53633) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir6g0-00051Z-GL for bug-gnu-emacs@gnu.org; Mon, 13 Jan 2020 15:51:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ir6fz-0004LT-61 for bug-gnu-emacs@gnu.org; Mon, 13 Jan 2020 15:51:08 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:42129) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ir6fy-0004KJ-Uf for bug-gnu-emacs@gnu.org; Mon, 13 Jan 2020 15:51:07 -0500 Received: by mail-wr1-x433.google.com with SMTP id q6so10025440wro.9 for ; Mon, 13 Jan 2020 12:51:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=AsY+KLl4u7j+3eamPVAx6Tpfig1M0ByEr0vlSuFfzWA=; b=ur26rx2RV/t3WS4xiSvuYuxHu+IPF8a1zsR1CYDrS2+88NwBd/bh58Pqgyc1p3Lhjy hZ0Ul0JbDkf49ly4oqv37le+EbzqohUIGVD3ztVsnRZkq0/6DNetPHSxBSfAcB+ev5PW yFuUA9BQdn850dXBV+LxRTBAFcQ8+T/nRl3hkpQqW7nAHWfK1iOu3AqmD8ql+Tat3gyO VCYegPtp4RXXC9LYE5jghbnYv3wFzVUhcTMr/oYkkUE6m6dHgMA/db7dOs2QQEl3osJB EZh/3xp2CRs96qLZxOvNmmCke83juvZubrWfmQfMuJKW8PrV8yJF9K3nZhmw8Cf0M5// DyAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=AsY+KLl4u7j+3eamPVAx6Tpfig1M0ByEr0vlSuFfzWA=; b=L/ZVi5JcBuJthhwuhezWjtBVaYejsJuidYYpyfcVKFgdoRDlPnS6puGO8yK10pShdN JTbynEJ/Jo2hrdKf7Mv+RX4zdrAzV9+G25K7MkpwfF3FsqJh9WKal7xglwuYhmQZ3r0o H3Eh6xQkvv36OSrUTkXZTaLzORhgCEZVvmyAWRLoDQFzpoiFiB4zhKY6Dsqlp4wvWDZw G6fQ3URQbd6DZgiB4/KbChknE3JTXQsk8su4ZNVhqrVemFLIlr6MyDAaSmk7pfy0p5Ym 1nDqidc4pe5lIV0YANfUQL+gBB5fML50j8LZi2/qjt7uwMjb82I7soHEeMzxZONBnkTY miag== X-Gm-Message-State: APjAAAVopjn5+BtGnXdwL5akcyXLWUOK5FOzWiEZ1AQT+lI67BRYzyWR sA1zgGh6NLx7gq/p2SqeLAC7rRxe X-Google-Smtp-Source: APXvYqy42UYXtjGgsc0ZNAlsFzUKO/KxPjuDnwwzKNHq/30TES1EtgCkrv/w5xkS/i2YPWFpK8JDDQ== X-Received: by 2002:adf:f1c6:: with SMTP id z6mr21687011wro.279.1578948665485; Mon, 13 Jan 2020 12:51:05 -0800 (PST) Received: from calancha-pc.dy.bbexcite.jp ([31.7.242.222]) by smtp.gmail.com with ESMTPSA id d8sm16836368wre.13.2020.01.13.12.51.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2020 12:51:04 -0800 (PST) From: Tino Calancha To: bug-gnu-emacs@gnu.org Subject: 27.0.60; occur: Add bindings for next-error-no-select Date: Mon, 13 Jan 2020 21:51:03 +0100 Message-ID: <87blr7t70o.fsf@calancha-pc.dy.bbexcite.jp> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::433 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Severity: wishlist X-Debbugs-Cc: Juri Linkov I wish having `next-error-no-select', `previous-error-no-select' bound to `n' and `p' in the occur mode, as we have in *grep* buffer. AFAICS, we have all the infrastructure and it's just a matter of define the bindings at `occur-mode-map'. --8<-----------------------------cut here---------------start------------->8--- commit 72617bd49b151772d3c709bfa489d0a8f14bf408 Author: Tino Calancha Date: Mon Jan 13 21:37:39 2020 +0100 occur: Add bindings for next-error-no-select Add bindings to navigate the matches without select their buffers. * lisp/replace.el (occur-mode-map): Bind n to next-error-no-select and p to previous-error-no-select. * etc/NEWS (Changes in Specialized Modes and Packages in Emacs 27.1): Annonce this change. diff --git a/etc/NEWS b/etc/NEWS index 031ddf5800..572dfbbcf0 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -688,6 +688,8 @@ same as the 'C-x C-+' and 'C-x C--' commands. * Changes in Specialized Modes and Packages in Emacs 27.1 +** New bindings in occur-mode, 'next-error-no-select' bound to 'n' and +'previous-error-no-select' bound to 'p'. --- ** New HTML mode skeleton 'html-id-anchor'. This new command (which inserts an _ skeleton) is diff --git a/lisp/replace.el b/lisp/replace.el index a0b050637e..3c1918a257 100644 --- a/lisp/replace.el +++ b/lisp/replace.el @@ -1106,6 +1106,8 @@ occur-mode-map (define-key map "\C-m" 'occur-mode-goto-occurrence) (define-key map "o" 'occur-mode-goto-occurrence-other-window) (define-key map "\C-o" 'occur-mode-display-occurrence) + (define-key map "n" 'next-error-no-select) + (define-key map "p" 'previous-error-no-select) (define-key map "\M-n" 'occur-next) (define-key map "\M-p" 'occur-prev) (define-key map "r" 'occur-rename-buffer) --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 27.0.60 (build 48, x86_64-pc-linux-gnu, GTK+ Version 3.24.5) of 2020-01-13 built on calancha-pc.dy.bbexcite.jp Repository revision: d645628e3cf6ebe5eaea3b40100bd77b9c823f8b Repository branch: emacs-27 Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 13 18:48:13 2020 Received: (at control) by debbugs.gnu.org; 13 Jan 2020 23:48:13 +0000 Received: from localhost ([127.0.0.1]:60398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ir9RM-000699-OV for submit@debbugs.gnu.org; Mon, 13 Jan 2020 18:48:13 -0500 Received: from dog.birch.relay.mailchannels.net ([23.83.209.48]:56798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ir9RK-00068r-6t; Mon, 13 Jan 2020 18:48:11 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 3756BE08DF; Mon, 13 Jan 2020 23:48:08 +0000 (UTC) Received: from pdx1-sub0-mail-a36.g.dreamhost.com (100-96-87-46.trex.outbound.svc.cluster.local [100.96.87.46]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 88698E0AF6; Mon, 13 Jan 2020 23:48:07 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a36.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Mon, 13 Jan 2020 23:48:08 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Macabre-Language: 2e0d93c500dd25f5_1578959287786_1068062446 X-MC-Loop-Signature: 1578959287786:1315386257 X-MC-Ingress-Time: 1578959287786 Received: from pdx1-sub0-mail-a36.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a36.g.dreamhost.com (Postfix) with ESMTP id 1EAA2950C7; Mon, 13 Jan 2020 15:48:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=linkov.net; bh=mKKjHUiesGMf2Vdd0uxYfIz4ZpU=; b=mNhSovsSkjZxJp EpvJYSlO0E3Hp4+bV//WQ0cAZa6PSmViRnXakytgBxVIYGwX9IvNLYNa2ZidCPGm Lv2n8d3auK7jdOUJ0EjnVYt0BqZzHCkqIkjTjCRPLFYu+qf1aXPuLn6+3Us728oA EvkZtyBZZfsDNq130hV2CcqYNZp5A= Received: from mail.jurta.org (m91-129-103-172.cust.tele2.ee [91.129.103.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a36.g.dreamhost.com (Postfix) with ESMTPSA id 3BA28952DE; Mon, 13 Jan 2020 15:47:59 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a36 From: Juri Linkov To: Tino Calancha Subject: Re: bug#39122: 27.0.60; occur: Add bindings for next-error-no-select Organization: LINKOV.NET References: <87a76rt70b.fsf@calancha-pc.dy.bbexcite.jp> Date: Tue, 14 Jan 2020 01:14:08 +0200 Message-ID: <87d0bndk5b.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.60 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 39122@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 39121 39122 thanks > I wish having `next-error-no-select', `previous-error-no-select' bound to `n' > and `p' in the occur mode, as we have in *grep* buffer. > > AFAICS, we have all the infrastructure and it's just a matter of define > the bindings at `occur-mode-map'. It's a good idea to make occur more consistent with grep/compile, thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu May 21 17:05:43 2020 Received: (at 39121) by debbugs.gnu.org; 21 May 2020 21:05:43 +0000 Received: from localhost ([127.0.0.1]:57416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbsNp-0007D4-QZ for submit@debbugs.gnu.org; Thu, 21 May 2020 17:05:42 -0400 Received: from mail-ed1-f49.google.com ([209.85.208.49]:43446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbsNg-0007Cc-0F; Thu, 21 May 2020 17:05:32 -0400 Received: by mail-ed1-f49.google.com with SMTP id g9so7699653edw.10; Thu, 21 May 2020 14:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Gh0In0Sw3/DFIHanx9EMO6T9hwLiLi7ZJlvMMAjaJOc=; b=HLoUNiQOfu1RD+ExrtKotUna+sEQAc9qYgGGHrIbZyR6+iyfhxu1eIQbbU5/Bmfotk KE2S+AiUZpCmgBlo3mIJ1hEz1Hf2jdeIsIrBHYf/UIXMajwqmo0MYOsbte/8dbOEkXxj jX88MWeXxOmaIPPBfjuN5gd+AVVxAg5xjqrkYStIqjRISw9J0ZRGi/WY1HpIOoavse1Q i8yW4LU8ptvyxl5JUmhemxouplqC9rG+6Kf/qaVOwlr0UKAA7fsMdpmJPmCnmagO7k0h B37NwPAqT4BjvuFH6vUErUTy6jxZo8sr9zdqcG5pekSH9qYQcz6CMGEXVUWbKkZO9jKJ 7YyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Gh0In0Sw3/DFIHanx9EMO6T9hwLiLi7ZJlvMMAjaJOc=; b=JF1xodbsdwswN3gR/F2RG0bLWdszvF6QY32mjmeBCrVS92S+rfgUbRMdKfqlu7KHVg 5pyv5dfBoJV7trIS0hzKcA3UJIX2jZ4Cacj2SY1ax8mmoOgskDwUsOJPkMaksAPWzM5C hQB8DpEths/EbS5pqY8Jxkj6Q7e0A+Jd1OPEPZ+OQwRvYZd11CM32CqXlj6jxNIhJYW7 tW+KF3mpESA+6YNoTQbHdkUVoITptd4tJEhZ1cRqisWFF4irJ4jwfU8I8mECsjQkEU66 4ZDkD/dpHG5LQpMElUOq5BWHcL+4uSw962LeulCerB6DhWnnavljquXI2Fw6IRJYSwXz nN4w== X-Gm-Message-State: AOAM532bpVBPZXhl5FRV3SpNIRjKr/2CNdrIA65F3LmucmuxY6QCYtCq DvqMjozCYusJ3eG1YLWdB58VpjOHkYA= X-Google-Smtp-Source: ABdhPJz56WPlM1t7Es9igJb0B4wt+Ogi24vacV75ZqwSBTxoUDSPPQeW0gGWkLGJYQf1GQjDH6obSA== X-Received: by 2002:aa7:d2d0:: with SMTP id k16mr548244edr.272.1590095125314; Thu, 21 May 2020 14:05:25 -0700 (PDT) Received: from calancha-pc.dy.bbexcite.jp ([31.7.242.222]) by smtp.gmail.com with ESMTPSA id z23sm5837573ejx.72.2020.05.21.14.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 14:05:24 -0700 (PDT) From: Tino Calancha To: Juri Linkov Subject: Re: bug#39122: 27.0.60; occur: Add bindings for next-error-no-select References: <87a76rt70b.fsf@calancha-pc.dy.bbexcite.jp> <87d0bndk5b.fsf@mail.linkov.net> Date: Thu, 21 May 2020 23:05:15 +0200 In-Reply-To: <87d0bndk5b.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 14 Jan 2020 01:14:08 +0200") Message-ID: <878shlov78.fsf@calancha-pc.dy.bbexcite.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39121 Cc: 39121@debbugs.gnu.org, 39122@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > merge 39121 39122 > thanks > >> I wish having `next-error-no-select', `previous-error-no-select' bound to `n' >> and `p' in the occur mode, as we have in *grep* buffer. > It's a good idea to make occur more consistent with grep/compile, thanks. Hi Juri, I have refined the patch so that we have visual feedback during the navigation (i.e. highligh) as `grep' does. --8<-----------------------------cut here---------------start------------->8--- commit 7d5917d0a2eda1782b9461951e40bfb837bc75ab Author: Tino Calancha Date: Thu May 21 22:36:00 2020 +0200 occur: Add bindings for next-error-no-select Make the navigation in the occur buffer closer to the navigation in the compilation buffer. Add bindings to navigate the occur matches (Bug#39121). Honor `next-error-highlight' and `next-error-highlight-no-select' when navigating the occurrences. * lisp/replace.el (occur-highlight-regexp, occur-highlight-overlay): New variables. (occur-1): Set `occur-highlight-regexp' to the searched regexp. (occur-goto-locus-delete-o, occur--highlight-occurrence): New defuns. (occur-mode-display-occurrence, occur-mode-goto-occurrence): Use `occur--highlight-occurrence'. (occur-mode-map): Bind n to `next-error-no-select' and p to `previous-error-no-select' * etc/NEWS (Changes in Sppecialized Modes and Packages in Emacs 28.1): Announce this change. * test/lisp/replace-tests.el (replace-tests-with-highlighted-occurrence): Add helper macro. (occur-highlight-occurrence): Add test. diff --git a/etc/NEWS b/etc/NEWS index 1bf1403cab..a273a06ef7 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -101,6 +101,9 @@ horizontal movements now stop at the edge of the board. * Changes in Specialized Modes and Packages in Emacs 28.1 +** New bindings in occur-mode, 'next-error-no-select' bound to 'n' and +'previous-error-no-select' bound to 'p'. + ** EIEIO: 'oset' and 'oset-default' are declared obsolete. ** New minor mode 'cl-font-lock-built-in-mode' for `lisp-mode'. diff --git a/lisp/replace.el b/lisp/replace.el index f3a71f87fe..69092c16f9 100644 --- a/lisp/replace.el +++ b/lisp/replace.el @@ -757,6 +757,13 @@ regexp-history Maximum length of the history list is determined by the value of `history-length', which see.") +(defvar occur-highlight-regexp t + "Regexp matching part of visited source lines to highlight temporarily. +Highlight entire line if t; don't highlight source lines if nil.") + +(defvar occur-highlight-overlay nil + "Overlay used to temporarily highlight occur matches.") + (defvar occur-collect-regexp-history '("\\1") "History of regexp for occur's collect operation") @@ -1113,6 +1120,8 @@ occur-mode-map (define-key map "\C-m" 'occur-mode-goto-occurrence) (define-key map "o" 'occur-mode-goto-occurrence-other-window) (define-key map "\C-o" 'occur-mode-display-occurrence) + (define-key map "n" 'next-error-no-select) + (define-key map "p" 'previous-error-no-select) (define-key map "\M-n" 'occur-next) (define-key map "\M-p" 'occur-prev) (define-key map "r" 'occur-rename-buffer) @@ -1261,9 +1270,12 @@ occur-mode-goto-occurrence (with-current-buffer (window-buffer (posn-window (event-end event))) (save-excursion (goto-char (posn-point (event-end event))) - (occur-mode-find-occurrence)))))) + (occur-mode-find-occurrence))))) + (regexp occur-highlight-regexp)) (pop-to-buffer (marker-buffer pos)) (goto-char pos) + (let ((end-mk (save-excursion (re-search-forward regexp nil t)))) + (occur--highlight-occurrence pos end-mk)) (when buffer (next-error-found buffer (current-buffer))) (run-hooks 'occur-mode-find-occurrence-hook))) @@ -1277,17 +1289,74 @@ occur-mode-goto-occurrence-other-window (next-error-found buffer (current-buffer)) (run-hooks 'occur-mode-find-occurrence-hook))) +;; Stolen from compile.el +(defun occur-goto-locus-delete-o () + (delete-overlay occur-highlight-overlay) + ;; Get rid of timer and hook that would try to do this again. + (if (timerp next-error-highlight-timer) + (cancel-timer next-error-highlight-timer)) + (remove-hook 'pre-command-hook + #'occur-goto-locus-delete-o)) + +;; Highlight the current visited occurrence. +;; Adapted from `compilation-goto-locus'. +(defun occur--highlight-occurrence (mk end-mk) + (let ((highlight-regexp occur-highlight-regexp)) + (if (timerp next-error-highlight-timer) + (cancel-timer next-error-highlight-timer)) + (unless occur-highlight-overlay + (setq occur-highlight-overlay + (make-overlay (point-min) (point-min))) + (overlay-put occur-highlight-overlay 'face 'next-error)) + (with-current-buffer (marker-buffer mk) + (save-excursion + (if end-mk (goto-char end-mk) (end-of-line)) + (let ((end (point))) + (if mk (goto-char mk) (beginning-of-line)) + (if (and (stringp highlight-regexp) + (re-search-forward highlight-regexp end t)) + (progn + (goto-char (match-beginning 0)) + (move-overlay occur-highlight-overlay + (match-beginning 0) (match-end 0) + (current-buffer))) + (move-overlay occur-highlight-overlay + (point) end (current-buffer))) + (if (or (eq next-error-highlight t) + (numberp next-error-highlight)) + ;; We want highlighting: delete overlay on next input. + (add-hook 'pre-command-hook + #'occur-goto-locus-delete-o) + ;; We don't want highlighting: delete overlay now. + (delete-overlay occur-highlight-overlay)) + ;; We want highlighting for a limited time: + ;; set up a timer to delete it. + (when (numberp next-error-highlight) + (setq next-error-highlight-timer + (run-at-time next-error-highlight nil + 'occur-goto-locus-delete-o)))))) + (when (eq next-error-highlight 'fringe-arrow) + ;; We want a fringe arrow (instead of highlighting). + (setq next-error-overlay-arrow-position + (copy-marker (line-beginning-position)))))) + (defun occur-mode-display-occurrence () "Display in another window the occurrence the current line describes." (interactive) (let ((buffer (current-buffer)) (pos (occur-mode-find-occurrence)) + (regexp occur-highlight-regexp) + (next-error-highlight next-error-highlight-no-select) + (display-buffer-overriding-action + '(nil (inhibit-same-window . t))) window) (setq window (display-buffer (marker-buffer pos) t)) ;; This is the way to set point in the proper window. (save-selected-window (select-window window) (goto-char pos) + (let ((end-mk (save-excursion (re-search-forward regexp nil t)))) + (occur--highlight-occurrence pos end-mk)) (next-error-found buffer (current-buffer)) (run-hooks 'occur-mode-find-occurrence-hook)))) @@ -1612,6 +1681,7 @@ occur-1 (buffer-undo-list t) (occur--final-pos nil)) (erase-buffer) + (set (make-local-variable 'occur-highlight-regexp) regexp) (let ((count (if (stringp nlines) ;; Treat nlines as a regexp to collect. diff --git a/test/lisp/replace-tests.el b/test/lisp/replace-tests.el index f5cff92d54..aed14c3357 100644 --- a/test/lisp/replace-tests.el +++ b/test/lisp/replace-tests.el @@ -546,4 +546,46 @@ replace-tests--query-replace-undo ?q (string= expected (buffer-string)))))) +(defmacro replace-tests-with-highlighted-occurrence (highlight-locus &rest body) + "Helper macro to test the highlight of matches when navigating occur buffer. + +Eval BODY with `next-error-highlight' and `next-error-highlight-no-select' +bound to HIGHLIGHT-LOCUS." + (declare (indent 1) (debug (form body))) + `(let ((regexp "foo") + (next-error-highlight ,highlight-locus) + (next-error-highlight-no-select ,highlight-locus) + (buffer (generate-new-buffer "test")) + (inhibit-message t)) + (unwind-protect + ;; Local bind to disable the deletion of `occur-highlight-overlay' + (cl-letf (((symbol-function 'occur-goto-locus-delete-o) (lambda ()))) + (with-current-buffer buffer (dotimes (_ 3) (insert regexp ?\n))) + (pop-to-buffer buffer) + (occur regexp) + (pop-to-buffer "*Occur*") + (occur-next) + ,@body) + (kill-buffer buffer) + (kill-buffer "*Occur*")))) + +(ert-deftest occur-highlight-occurrence () + "Test for https://debbugs.gnu.org/39121 ." + (let ((alist '((nil . nil) (0.5 . t) (t . t) (fringe-arrow . nil))) + (check-overlays + (lambda (has-ov) + (eq has-ov (not (null (overlays-in (point-min) (point-max)))))))) + (pcase-dolist (`(,highlight-locus . ,has-overlay) alist) + ;; Visiting occurrences + (replace-tests-with-highlighted-occurrence highlight-locus + (occur-mode-goto-occurrence) + (should (funcall check-overlays has-overlay))) + ;; Displaying occurrences + (replace-tests-with-highlighted-occurrence highlight-locus + (occur-mode-display-occurrence) + (with-current-buffer (marker-buffer + (get-text-property (point) 'occur-target)) + (should (funcall check-overlays has-overlay))))))) + + ;;; replace-tests.el ends here --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 28.0.50 (build 12, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2020-05-21 built on calancha-pc.dy.bbexcite.jp Repository revision: d714aa753b744c903d149a1f6c69262d958c313e Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) From debbugs-submit-bounces@debbugs.gnu.org Thu May 21 19:01:27 2020 Received: (at 39121) by debbugs.gnu.org; 21 May 2020 23:01:27 +0000 Received: from localhost ([127.0.0.1]:57548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbuBr-0001Wh-Lb for submit@debbugs.gnu.org; Thu, 21 May 2020 19:01:27 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:41267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbuBp-0001WN-EM; Thu, 21 May 2020 19:01:26 -0400 X-Originating-IP: 91.129.97.200 Received: from mail.gandi.net (m91-129-97-200.cust.tele2.ee [91.129.97.200]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id E098D40004; Thu, 21 May 2020 23:01:17 +0000 (UTC) From: Juri Linkov To: Tino Calancha Subject: Re: bug#39122: 27.0.60; occur: Add bindings for next-error-no-select Organization: LINKOV.NET References: <87a76rt70b.fsf@calancha-pc.dy.bbexcite.jp> <87d0bndk5b.fsf@mail.linkov.net> <878shlov78.fsf@calancha-pc.dy.bbexcite.jp> Date: Fri, 22 May 2020 01:33:53 +0300 In-Reply-To: <878shlov78.fsf@calancha-pc.dy.bbexcite.jp> (Tino Calancha's message of "Thu, 21 May 2020 23:05:15 +0200") Message-ID: <87k114aohq.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39121 Cc: 39121@debbugs.gnu.org, 39122@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I have refined the patch so that we have visual feedback during the > navigation (i.e. highligh) as `grep' does. Using highlighting like in grep is a nice addition that makes occur consistent with grep, thanks for this long-awaited feature. From debbugs-submit-bounces@debbugs.gnu.org Sun May 31 06:43:22 2020 Received: (at 39121-done) by debbugs.gnu.org; 31 May 2020 10:43:22 +0000 Received: from localhost ([127.0.0.1]:59839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfLR4-0005Gy-6g for submit@debbugs.gnu.org; Sun, 31 May 2020 06:43:22 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:43826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfLR2-0005Gk-Do for 39121-done@debbugs.gnu.org; Sun, 31 May 2020 06:43:20 -0400 Received: by mail-wr1-f51.google.com with SMTP id l10so8508163wrr.10 for <39121-done@debbugs.gnu.org>; Sun, 31 May 2020 03:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=h2AiU8PkVI4q/2QYjaYPvwcXq6mCf4FWIENlIP95xoc=; b=Y1n2wqlXgagyL6ortEwjbRHE4j+k4dL138EHLKq5UrWkrrwlJtbtac3LMpTiJADsSK lmkrkPJuLA7Atbrqc5GqCMpjLgvgv+vACGyXr0VzjS/Rb3W4tLqsNLFuinU1Ltbr1g19 0Perb18NFNzabOsYPq+WVuDM9tlmWWys8ZUth9afXPeTz2nhyoDKrMbedD6P57A6F3ef joeDXi+k+qcls39MYa48DOKnY2st6KXujme9vXIGjixPPlUXyGaQpFiYVn3bZkprWamI UXildVage7In891PzyL47BNNn2ScEnBTE3/jVWEuwEj3M4iHntd4NVaJFDw3mrDC9bLM ax0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=h2AiU8PkVI4q/2QYjaYPvwcXq6mCf4FWIENlIP95xoc=; b=binW9YJPwZHwxClrdeK9oJ3hqNDElX18akt3pjTlaoaPy37643hXcRZpcCiWGmwCG0 11jprU8jx8i74ncFiRhi/FpARO6WWPXuCYNGbcICmoyQUJ/xrtX0W9qS0sMehMSVSg77 rycFPWeJqdoH8LAlQfNeVHmTPc7RJ6B6J271u26wdJFAW+EWdm6IdP3vIDLatHGZ4NP3 YEYGiqlRLsAVeNKdFH7PIcWtN14OpQkEKUIooKug9CWUyaGhpHx4SGN2sqUGQbyNSjeD kylk271IH3agya4UZuITP5cgwz8+8EW6APNMXDgqXSfEbB5xOhejvHbrCdJjSX9imP3H BP2g== X-Gm-Message-State: AOAM5310u1IzTAOEbf4CXdjnvoCQzLvpFdSTguocPjrWbNCeWt0IA/IY aEONB3rZv/K1fIykIp0uKInb3j0KngY= X-Google-Smtp-Source: ABdhPJwY1CLUgbdrzdWlAjQSk5UFJQLVnMXQ6BWqLRCXUtkn0fY5A/fHHRnG8D2PD7NcKefqxJNr2g== X-Received: by 2002:adf:e883:: with SMTP id d3mr16624830wrm.274.1590921794178; Sun, 31 May 2020 03:43:14 -0700 (PDT) Received: from calancha-pc.dy.bbexcite.jp ([31.7.242.222]) by smtp.gmail.com with ESMTPSA id y80sm8694485wmc.34.2020.05.31.03.43.13 for <39121-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2020 03:43:13 -0700 (PDT) From: Tino Calancha To: 39121-done@debbugs.gnu.org Subject: Re: bug#39121: bug#39122: 27.0.60; occur: Add bindings for next-error-no-select References: <87a76rt70b.fsf@calancha-pc.dy.bbexcite.jp> <87d0bndk5b.fsf@mail.linkov.net> <878shlov78.fsf@calancha-pc.dy.bbexcite.jp> <87k114aohq.fsf@mail.linkov.net> Date: Sun, 31 May 2020 12:43:04 +0200 In-Reply-To: <87k114aohq.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 22 May 2020 01:33:53 +0300") Message-ID: <871rn0e66f.fsf@calancha-pc.dy.bbexcite.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39121-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >> I have refined the patch so that we have visual feedback during the >> navigation (i.e. highligh) as `grep' does. > > Using highlighting like in grep is a nice addition that makes > occur consistent with grep, thanks for this long-awaited feature. Pushed into master branch as commit 'occur: Add bindings for next-error-no-select' (abe7c22da96694ced1bc80ec7eb9eb8a662a568b) From unknown Wed Jun 18 23:05:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 28 Jun 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 15 05:14:03 2021 Received: (at control) by debbugs.gnu.org; 15 Jul 2021 09:14:03 +0000 Received: from localhost ([127.0.0.1]:46808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3xRT-0005R2-H5 for submit@debbugs.gnu.org; Thu, 15 Jul 2021 05:14:03 -0400 Received: from mail1463c50.megamailservers.eu ([91.136.14.63]:42632 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3xRQ-0005QN-7w for control@debbugs.gnu.org; Thu, 15 Jul 2021 05:14:01 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1626340433; bh=gxI0fH3DpVlrVI/yyqd5k7zR/andIDQmJFBI8C/fViM=; h=From:Subject:Date:To:From; b=qS/FpPnKqd/piyirhOHKIKjcOzK7NHy1zl/+jZ0kkhq/khx8ALDhQ1vq6qO0ZYLMa IbSm56/KKTlBPvT22/9Vcr8qoJ/KUn0of9eNLnR+94+4I0VlkpO0E2iP6/ZAKUCTH3 Nt2P7oKaiq00OA/ho/fawdJeJ0iacMdlfvTy8teE= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16F9DoCX019712 for ; Thu, 15 Jul 2021 09:13:52 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Message-Id: Date: Thu, 15 Jul 2021 11:13:49 +0200 To: control@debbugs.gnu.org X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F23.60EFFC50.003C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=OogxNB3t c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=5j5StdYQXcmdOctsKcAA:9 a=CjuIK1q_8ugA:10 a=xo5jKAKm-U-Zyk2_beg_:22 X-Origin-Country: SE X-Spam-Score: 3.4 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unarchive 39121 Content analysis details: (3.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 2.0 BLANK_SUBJECT Subject is present but empty 0.0 TVD_SPACE_RATIO No description available. 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unarchive 39121 Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 2.0 BLANK_SUBJECT Subject is present but empty 0.0 TVD_SPACE_RATIO No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager unarchive 39121 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 15 18:36:20 2021 Received: (at 39121) by debbugs.gnu.org; 15 Jul 2021 22:36:20 +0000 Received: from localhost ([127.0.0.1]:49965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m49xs-0001TB-C5 for submit@debbugs.gnu.org; Thu, 15 Jul 2021 18:36:20 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:36517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m49xb-0001SG-Kb for 39121@debbugs.gnu.org; Thu, 15 Jul 2021 18:36:18 -0400 Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 10F7B240003; Thu, 15 Jul 2021 22:35:55 +0000 (UTC) From: Juri Linkov To: Mattias =?iso-8859-1?Q?Engdeg=E5rd?= Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select Organization: LINKOV.NET References: Date: Fri, 16 Jul 2021 01:10:44 +0300 In-Reply-To: ("Mattias =?iso-8859-1?Q?Engdeg=E5rd=22's?= message of "Thu, 15 Jul 2021 18:31:20 +0200") Message-ID: <87r1fzi7c3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39121 Cc: 39121@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Sorry about stirring in this pile again, but it looks like there is > unfinished business with respect to `occur-highlight-regexp` > introduced by this patch: > > +(defvar occur-highlight-regexp t > + "Regexp matching part of visited source lines to highlight temporarily. > +Highlight entire line if t; don't highlight source lines if nil.") > > Are the t and nil cases really handled? As far as I can tell: > > - `occur-mode-goto-occurrence` and `occur-mode-display-occurrence` > both crash if `occur-highlight-regexp` isn't a string > - `occur--highlight-occurrence` does not distinguish t from nil > - `occur--highlight-occurrence` is only called from the two other (crashing) functions > > This was discovered when using an external package that uses > occur-mode for their own purposes and don't actually have a regexp to > match (only start and end markers). > > Since `occur-highlight-regexp` appears to serve an internal purpose only, > perhaps we can use some other method to get at the text to highlight? It seems `compilation-highlight-regexp` was supposed to duplicate the logic of the existing variable `compilation-highlight-regexp` that is t by default. But I see such conditions `(stringp highlight-regexp)` in `compilation-goto-locus`, so maybe 'occur' needs to do the same. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 16 09:21:03 2021 Received: (at 39121) by debbugs.gnu.org; 16 Jul 2021 13:21:03 +0000 Received: from localhost ([127.0.0.1]:50904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4Nm3-00031X-0U for submit@debbugs.gnu.org; Fri, 16 Jul 2021 09:21:03 -0400 Received: from mail1472c50.megamailservers.eu ([91.136.14.72]:41646 helo=mail102c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4Nlz-00030i-BS for 39121@debbugs.gnu.org; Fri, 16 Jul 2021 09:21:02 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1626441652; bh=f9Yl3MiWtqv6IxYQv3rxNjKMpx+dWp2yMXPmSv9Vs1w=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=DXjZ9otN5eyhU8rLFkbybOuRVtIjJMzIsUQxLgGeWaqqGoW1sctYYke+lSwS1I1AH DjD3JCqZTSOizzWmzat/TEr8Qj72q2HIku4KM+5g0YW1fXEpFWJgSRoHsubhcONlxe UBPm6j5Ly6sYtA78LOHcDucq1d+RA73hjjShEBp4= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail102c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16GDKnSS028768; Fri, 16 Jul 2021 13:20:51 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87r1fzi7c3.fsf@mail.linkov.net> Date: Fri, 16 Jul 2021 15:20:49 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <3B9A92C1-F93C-46C4-8F8D-9059D61EBF98@acm.org> References: <87r1fzi7c3.fsf@mail.linkov.net> To: Juri Linkov X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F18.60F187B4.0015, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Z/WS40ZA c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=ucMQw-l_AAAA:8 a=FOiPFIaXmml8R-XfEtgA:9 a=CjuIK1q_8ugA:10 a=xkTruGkd22MpkFU079mG:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 16 juli 2021 kl. 00.10 skrev Juri Linkov : > It seems `compilation-highlight-regexp` was supposed to duplicate the logic > of the existing variable `compilation-highlight-regexp` that is t by default. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 39121 Cc: 39121@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 16 juli 2021 kl. 00.10 skrev Juri Linkov : > It seems `compilation-highlight-regexp` was supposed to duplicate the = logic > of the existing variable `compilation-highlight-regexp` that is t by = default. Yes, you are probably right. It's not obvious that using the same code = is a good fit for Occur. Specifically, compilation-mode can, in the best case, use the parsed = location interval (starting and ending columns). When only a line number = is available, it's not possible to do much better than highlighting the = entire line. (The grep command uses what appears to be smelly hacks for = more precise locations.) In contrast, for Occur the exact position should always be available = since Emacs made the search. Wouldn't it make sense to use it, instead = of matching regexps again? From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 23 09:32:51 2021 Received: (at 39121) by debbugs.gnu.org; 23 Jul 2021 13:32:51 +0000 Received: from localhost ([127.0.0.1]:42624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6vIJ-0007KB-Hr for submit@debbugs.gnu.org; Fri, 23 Jul 2021 09:32:51 -0400 Received: from mail158c50.megamailservers.eu ([91.136.10.168]:50000 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6vIG-0007Jz-Kt for 39121@debbugs.gnu.org; Fri, 23 Jul 2021 09:32:49 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1627047166; bh=ks9IJnRr+OaPHQTznGSmUwukUl27cJDxjaBFeLHVDfg=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=ETFum4jtTHMuBWuWp8UNFmExZCPboVuFGozuvy3oNkTkapSNqzpTp5zfyOauOdQ6r aXFt38UVo628/jq5a5q0oGpnI3/FXQSxOTYnw4HRra3HT1T0NtwiuCxTm4Nj+jJkvo fx9maMIVJjJ8JHClE1nQg42zGngbK0DhbGTrcK4A= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16NDWiYK031317; Fri, 23 Jul 2021 13:32:45 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_0FAC9DB9-EC7C-4225-AA93-CA76A3C60964" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select Date: Fri, 23 Jul 2021 15:32:43 +0200 In-Reply-To: <87r1fzi7c3.fsf@mail.linkov.net> To: Juri Linkov References: <87r1fzi7c3.fsf@mail.linkov.net> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F1C.60FAC4FE.0025, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=WOsBoUkR c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=M51BFTxLslgA:10 a=1KwMS72DUbnJ8CmukG0A:9 a=CjuIK1q_8ugA:10 a=U0tnTJfVmRB5EyVBDQoA:9 a=De_Ol2h6w80A:10 X-Origin-Country: SE X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 39121 Cc: 39121@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_0FAC9DB9-EC7C-4225-AA93-CA76A3C60964 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii As a cheapo fix to prevent the (possibly misguided) external package = from crashing in Emacs 28, what about this? --Apple-Mail=_0FAC9DB9-EC7C-4225-AA93-CA76A3C60964 Content-Disposition: attachment; filename=occur.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="occur.diff" Content-Transfer-Encoding: 7bit diff --git a/lisp/replace.el b/lisp/replace.el index ed81097e14..d39ebeca15 100644 --- a/lisp/replace.el +++ b/lisp/replace.el @@ -1305,8 +1305,11 @@ occur-mode-goto-occurrence (regexp occur-highlight-regexp)) (pop-to-buffer (marker-buffer pos)) (goto-char pos) - (let ((end-mk (save-excursion (re-search-forward regexp nil t)))) - (occur--highlight-occurrence pos end-mk)) + (when regexp + (let ((end-mk (if (stringp regexp) + (save-excursion (re-search-forward regexp nil t)) + (line-end-position)))) + (occur--highlight-occurrence pos end-mk))) (when buffer (next-error-found buffer (current-buffer))) (run-hooks 'occur-mode-find-occurrence-hook))) @@ -1386,8 +1389,11 @@ occur-mode-display-occurrence (save-selected-window (select-window window) (goto-char pos) - (let ((end-mk (save-excursion (re-search-forward regexp nil t)))) - (occur--highlight-occurrence pos end-mk)) + (when regexp + (let ((end-mk (if (stringp regexp) + (save-excursion (re-search-forward regexp nil t)) + (line-end-position)))) + (occur--highlight-occurrence pos end-mk))) (next-error-found buffer (current-buffer)) (run-hooks 'occur-mode-find-occurrence-hook)))) --Apple-Mail=_0FAC9DB9-EC7C-4225-AA93-CA76A3C60964-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 23 10:05:49 2021 Received: (at 39121) by debbugs.gnu.org; 23 Jul 2021 14:05:49 +0000 Received: from localhost ([127.0.0.1]:44206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6vo9-00005o-JJ for submit@debbugs.gnu.org; Fri, 23 Jul 2021 10:05:49 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6vo4-00005V-6e for 39121@debbugs.gnu.org; Fri, 23 Jul 2021 10:05:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CbbU3faudBTpJ56woZZd2LflmyE3zES5y0dBIDck3Mg=; b=St0gCrYpvaTVhD+YbnXOa+KlnL 4taSAvJu+6beCr1BEZQPTFAly346wndTXX6vRDIhR6rFwj7Jx62ggihvYN1S0fh/uNPj2iLiXBXXK oUNJSrBZp2iETYn3cBKH5n+kNnpI4l16wVnTBRCOqWRoIpKaxzaHFsIMGKVZdEpZZSkY=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6vnu-0001D1-Vc; Fri, 23 Jul 2021 16:05:33 +0200 From: Lars Ingebrigtsen To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select References: <87r1fzi7c3.fsf@mail.linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEVYU1GGZmZGOTgj ICHBurb////OZSHWAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UHFw4CLYjEgFoAAAGWSURBVDjLbZNh koMwCIUx8QBmJgegsAfowgXaae5/pn0k6ta0/FCHL/AgINFkSwmjRExfLZF884pkEiHhdMHJ1RVA BjtzkLuxkstuxMIiyKIABGAHGK8k7i4BDjIAM/zOkQpcB0INDGU3hSuAi/ezFP7IpGBkO3GzKDqF djB0jpdF+NAafgAqKT4MQSYK2N0SYBtn1oysZqZ7uVTKiF5yj+zAEgD9Jz7MiEa5Lm9OhRBJVJWm 42oMSvfWsk92F5T72x40AxSvdHumT4By6KfRY/Zz9LG01nQGXFBVqeWqbs61ATzbXG+ATGt9pDkT 0mdobFMfFrKZ7ludANcSwGWZtLG08JHEiC9NY/xxu/OVn1dCH6DvsdI2AR77C/DRBQ2N0p6HS3WM daRCM6+LbCzdDtrbHGLefEScIfBqdHFGHJPC2mMTsPOyg0O+iwsGyDtoZwSGgafRDCjxPYnhdQVp aY/ltdYtNrEtJzBaamvb2kqA5Ou5i1kc15S4R+D5fOt9/1Gxu7eSS/0Hfdml/2prvtWPXXT9A5DC qSi81lqZAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA3LTIzVDE0OjAyOjQ1KzAwOjAwI0/XzAAA ACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNy0yM1QxNDowMjo0NSswMDowMFISb3AAAAAASUVORK5C YII= X-Now-Playing: Sleaford Mods's _Key Markets_: "Live Tonight" Date: Fri, 23 Jul 2021 16:05:30 +0200 In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Fri, 23 Jul 2021 15:32:43 +0200") Message-ID: <871r7pazx1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mattias Engdegård writes: > As a cheapo fix to prevent the (possibly misguided) external package > from crashing in Emacs 28, what about this? Hm. Well, the variable is defined to allow both nil/t in addition to a string? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39121 Cc: Tino Calancha , 39121@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mattias Engdeg=C3=A5rd writes: > As a cheapo fix to prevent the (possibly misguided) external package > from crashing in Emacs 28, what about this? Hm. Well, the variable is defined to allow both nil/t in addition to a string? (defvar occur-highlight-regexp t "Regexp matching part of visited source lines to highlight temporarily. Highlight entire line if t; don't highlight source lines if nil.") So I think your patch looks correct. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 23 13:16:16 2021 Received: (at 39121) by debbugs.gnu.org; 23 Jul 2021 17:16:16 +0000 Received: from localhost ([127.0.0.1]:44506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6ymW-0000gr-58 for submit@debbugs.gnu.org; Fri, 23 Jul 2021 13:16:16 -0400 Received: from mail1475c50.megamailservers.eu ([91.136.14.75]:56854 helo=mail118c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6ymS-0000gb-QX for 39121@debbugs.gnu.org; Fri, 23 Jul 2021 13:16:15 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1627060565; bh=K50NbWq7BMtRGMRBjXs30YQ8oymWLdOy5pQDpcHj1ZQ=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=PdBxIqGnmas5WOytJn9bqzNN/vuvSiLVWG401ifL7NPPzD3MOqHadRqTktlFNvHr4 MXe8Jysb7kN1k4Cb/g+01GUsqXhavDWSjQlHFas/rx9HZMjfxRlK7FpjGSd0BW2o5+ yMiN52uDCIAQPlWjvkRjP1SNbmTMzZyUhuvOkPG0= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16NHG2uP018396; Fri, 23 Jul 2021 17:16:04 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <871r7pazx1.fsf@gnus.org> Date: Fri, 23 Jul 2021 19:16:02 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> To: Lars Ingebrigtsen X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F18.60FAF955.0022, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Ro+70xuK c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=TuURfhSrCEVh8Uy_U5kA:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 39121 Cc: Tino Calancha , 39121@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 23 juli 2021 kl. 16.05 skrev Lars Ingebrigtsen : > (defvar occur-highlight-regexp t > "Regexp matching part of visited source lines to highlight = temporarily. > Highlight entire line if t; don't highlight source lines if nil.") >=20 > So I think your patch looks correct. Well yes, but that variable itself isn't really useful -- it is really = just something transplanted from compilation-mode in order to achieve = the same highlighting effect in Occur, but Occur shouldn't need it at = all. So my patch is a bit rubbish; we could do better. Currently, Occur buffers use `occur-target` properties to direct each = line to the start of the first match on that line. We could use the = property to indicating the exact extents (intervals) of matches, = instead. For example, a buffer containing VENI VIDI VICI with the Occur search regexp "VI.I", currently results in a line in = *Occur* having the property `occur-target` with a marker to the start of = 'VIDI' as value. Instead, we could make the value be ((m1 . m2) (m3 . = m4)) where m1..m4 mark the beginning and end of 'VIDI' and 'VICI' = respectively. Then occur-highlight-regexp could be done away entirely. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 24 07:46:52 2021 Received: (at 39121) by debbugs.gnu.org; 24 Jul 2021 11:46:52 +0000 Received: from localhost ([127.0.0.1]:45303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7G7H-0004K4-Su for submit@debbugs.gnu.org; Sat, 24 Jul 2021 07:46:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7G7G-0004Eo-6E for 39121@debbugs.gnu.org; Sat, 24 Jul 2021 07:46:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UOGplh/AKKusUzpbBXmVIaU6nSd+uqZt4lIibpIM5PE=; b=Fu78BYFx5QAkwideEHhqx3DnGY +bpf3UoSF+sowRzjdWY5VmwtLIPCaO6oPvajhoBWp+f3OIb1ixoTzhZ0gTNs/BBSz0IoasX1Rf2MI azHeVfKG4guF2b1hUbMA0hvObok558GiBrCU3Ed1D47wwdstkjA+wLLAMf0qu9mlHSvU=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7G77-0004qm-69; Sat, 24 Jul 2021 13:46:43 +0200 From: Lars Ingebrigtsen To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUsVXEwZ49Hd5qK a1QLEBJBUVpSha7///93llwQAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UHGAsuHcmECeUAAAG5SURB VDjLbZPNbqQwDMcdBD3HiN6Jd8W51WrvU9W5pyvyAEVq3v8R1k4IYYbxJcK//P0ZAMTQwjMzOCLi U/ALnxERkIJLPERyGRSNsY+CHaBetVMQUP05lpEjhhgFjA4PA7A+rp8x9gFyrY1MPpiYtXhv6w2R v+ACLDNi/34FrytLkqChtjvQs9qXgrRJI1TxxBw95JYobZToqJn5809paaSURFW7nDz/LQDHRYjG yiJbQB6MguRavW87GNMZSJJbmRulR+CLYimATp2UqT0C6UR2NfABaqxX5g+BFWyHQoA5gZZcgNbM l6oU9BnQIsNqyQcBOmGZFS15WnWFzGsGOnRN7hrgApSQBbwA9ZO1+SAk2e0O9Nt1zlCxnj/6mpxo BgPZ7cb+5n4fob4BnO12xY36A8iThfkRiN/J5pvCl7ogZwBCO79sCqZarjRuRYbjHBbxL+W+VyCp LVoDgwb74UMxWjA6jw6CgPUA+m8ZfWAmQLdUQVylgfzrORtjR6XSXQE0i2+GIZh7MBIML5tciN0y rw1QmmVTcwQI36b5GXSveh+Gf9vAJ9DRRlDAT38GwVEBEGOL5P1/7KuiJdq5fh8AAAAldEVYdGRh dGU6Y3JlYXRlADIwMjEtMDctMjRUMTE6NDY6MjkrMDA6MDB7ZCyhAAAAJXRFWHRkYXRlOm1vZGlm eQAyMDIxLTA3LTI0VDExOjQ2OjI5KzAwOjAwCjmUHQAAAABJRU5ErkJggg== X-Now-Playing: Depeche Mode's _Construction Time Again_: "Two Minute Warning" Date: Sat, 24 Jul 2021 13:46:40 +0200 In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Fri, 23 Jul 2021 19:16:02 +0200") Message-ID: <87wnpg2au7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mattias Engdegård writes: > Currently, Occur buffers use `occur-target` properties to direct each > line to the start of the first match on that line. We could use the > property to indicating the exact extents (intervals) of [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39121 Cc: Tino Calancha , 39121@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mattias Engdeg=C3=A5rd writes: > Currently, Occur buffers use `occur-target` properties to direct each > line to the start of the first match on that line. We could use the > property to indicating the exact extents (intervals) of matches, > instead. For example, a buffer containing > > VENI VIDI VICI > > with the Occur search regexp "VI.I", currently results in a line in > *Occur* having the property `occur-target` with a marker to the start > of 'VIDI' as value. Instead, we could make the value be ((m1 . m2) (m3 > . m4)) where m1..m4 mark the beginning and end of 'VIDI' and 'VICI' > respectively. Then occur-highlight-regexp could be done away entirely. That does indeed sound like a better solution. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 24 13:30:07 2021 Received: (at 39121) by debbugs.gnu.org; 24 Jul 2021 17:30:07 +0000 Received: from localhost ([127.0.0.1]:46878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7LTS-0001MN-Nj for submit@debbugs.gnu.org; Sat, 24 Jul 2021 13:30:07 -0400 Received: from mail72c50.megamailservers.eu ([91.136.10.82]:55532 helo=mail92c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7LTP-0001LE-C5 for 39121@debbugs.gnu.org; Sat, 24 Jul 2021 13:30:04 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1627147801; bh=DWvoNH+o6AVa2nNb/yoDw9C8g07wBifB9KiFYAsz5kE=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=W/8BvQTmCIB9LI/H+JLI/qZaUcceRqK1SsDGzEnKvDs2nLsQ0EIvXJb8REwixOpit Ts9ImDn2XNeta88uTzCKbiNus5+4r8bxIkh4Y5BHFnZUjcKBYX+0XPJelEdhRs29VH V0aHuk7EnzkU7vtZui8BdJ+CemgC04wVsX2yJN1s= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16OHTw8W018071; Sat, 24 Jul 2021 17:30:00 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_75554E38-7061-4293-AB83-C7796877E55E" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select Date: Sat, 24 Jul 2021 19:29:57 +0200 In-Reply-To: <87wnpg2au7.fsf@gnus.org> To: Lars Ingebrigtsen References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F28.60FC4E19.000F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=UJ+j4xXy c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=irfnjWxm5M9kWPbGQF0A:9 a=CjuIK1q_8ugA:10 a=M3k1PryANISby0uPEgsA:9 a=B2y7HmGcmWMA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 24 juli 2021 kl. 13.46 skrev Lars Ingebrigtsen : > That does indeed sound like a better solution. All right, this might work. Patch! Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 39121 Cc: Tino Calancha , 39121@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_75554E38-7061-4293-AB83-C7796877E55E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 24 juli 2021 kl. 13.46 skrev Lars Ingebrigtsen : > That does indeed sound like a better solution. All right, this might work. Patch! The immediate visible benefit is that all matches on the same line are = highlighted, not just the first one. It also fixes the compatibility = problems mentioned above by removing occur-highlight-regexp entirely. External packages that populate occur-mode buffers themselves should = still work, since the old `occur-target` property format is still = recognised. In those cases we just highlight from the first match to the = end of the line. --Apple-Mail=_75554E38-7061-4293-AB83-C7796877E55E Content-Disposition: attachment; filename=0001-Keep-track-of-match-extents-in-occur-mode-bug-39121.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Keep-track-of-match-extents-in-occur-mode-bug-39121.patch" Content-Transfer-Encoding: quoted-printable =46rom=209035a88e1b62980f38362c938eba6b042d500686=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sat,=2024=20Jul=202021=2016:32:11=20+0200=0A= Subject:=20[PATCH]=20Keep=20track=20of=20match=20extents=20in=20= occur-mode=20(bug#39121)=0A=0AUse=20the=20`occur-target`=20text=20= property=20to=20keep=20track=20of=20the=20extents=20of=0Aall=20matches=20= on=20each=20line=20instead=20of=20just=20the=20start=20of=20the=20first=20= match.=0ADoing=20so=20allows=20us=20to=20highlight=20all=20matches=20= when=20jumping=20to=20a=20matching=0Aline=20instead=20of=20just=20the=20= first=20one,=20and=20it=20works=20in=20a=20more=20principled=0Away.=20=20= It=20also=20removes=20compatibility=20problems=20that=20were=20= introduced=20with=0Aoccur-highlight-regexp.=0A=0AFor=20compatibility=20= with=20code=20that=20populate=20their=20own=20occur-mode=0Abuffers,=20we=20= still=20accept=20`occur-target`=20properties=20with=20a=20single=0A= marker=20as=20value.=0A=0A*=20lisp/replace.el=20(occur-highlight-regexp,=20= occur-highlight-overlay):=0ARemove.=0A(occur-highlight-overlays):=20New.=0A= (occur--targets-start):=20New.=0A*=20lisp/replace.el=20= (occur-after-change-function):=0A(occur-mode-find-occurrence):=20Replace=20= with...=0A(occur-mode--find-occurrences):=20...this=20function=20that=20= returns=20the=0Awhole=20`occur-target`=20property=20value.=0A= (occur-mode-goto-occurrence,=20occur-mode-goto-occurrence-other-window)=0A= (occur-goto-locus-delete-o,=20occur-mode-display-occurrence)=0A= (occur-engine):=20Adjust=20to=20new=20property=20format.=0A= (occur--highlight-occurrence):=20Replace=20with...=0A= (occur--highlight-occurrences):=20...this=20function=20that=20takes=0A= the=20`occur-target`=20property=20value=20as=20argument.=0A(occur-1):=20= Don't=20use=20`occur-highlight-regexp`.=0A*=20test/lisp/replace-tests.el=20= (occur-highlight-occurrence):=0AAdapt=20to=20new=20property=20format.=0A= ---=0A=20lisp/replace.el=20=20=20=20=20=20=20=20=20=20=20=20|=20177=20= +++++++++++++++++++------------------=0A=20test/lisp/replace-tests.el=20= |=20=20=202=20+-=0A=202=20files=20changed,=2091=20insertions(+),=2088=20= deletions(-)=0A=0Adiff=20--git=20a/lisp/replace.el=20b/lisp/replace.el=0A= index=207e30f1fc55..24befed241=20100644=0A---=20a/lisp/replace.el=0A+++=20= b/lisp/replace.el=0A@@=20-792,12=20+792,8=20@@=20regexp-history=0A=20= Maximum=20length=20of=20the=20history=20list=20is=20determined=20by=20= the=20value=0A=20of=20`history-length',=20which=20see.")=0A=20=0A= -(defvar=20occur-highlight-regexp=20t=0A-=20=20"Regexp=20matching=20part=20= of=20visited=20source=20lines=20to=20highlight=20temporarily.=0A= -Highlight=20entire=20line=20if=20t;=20don't=20highlight=20source=20= lines=20if=20nil.")=0A-=0A-(defvar=20occur-highlight-overlay=20nil=0A-=20= =20"Overlay=20used=20to=20temporarily=20highlight=20occur=20matches.")=0A= +(defvar=20occur-highlight-overlays=20nil=0A+=20=20"Overlays=20used=20to=20= temporarily=20highlight=20occur=20matches.")=0A=20=0A=20(defvar=20= occur-collect-regexp-history=20'("\\1")=0A=20=20=20"History=20of=20= regexp=20for=20occur's=20collect=20operation")=0A@@=20-1357,18=20= +1353,27=20@@=20occur-cease-edit=0A=20=20=20=20=20(occur-mode)=0A=20=20=20= =20=20(message=20"Switching=20to=20Occur=20mode.")))=0A=20=0A+(defun=20= occur--targets-start=20(targets)=0A+=20=20"First=20marker=20of=20the=20= `occur-target'=20property=20value=20TARGETS."=0A+=20=20(if=20(consp=20= targets)=0A+=20=20=20=20=20=20(caar=20targets)=0A+=20=20=20=20;;=20= Tolerate=20an=20`occur-target'=20value=20that=20is=20a=20single=20marker=20= for=0A+=20=20=20=20;;=20compatibility.=0A+=20=20=20=20targets))=0A+=0A=20= (defun=20occur-after-change-function=20(beg=20end=20length)=0A=20=20=20= (save-excursion=0A=20=20=20=20=20(goto-char=20beg)=0A=20=20=20=20=20= (let*=20((line-beg=20(line-beginning-position))=0A-=09=20=20=20(m=20= (get-text-property=20line-beg=20'occur-target))=0A+=09=20=20=20(targets=20= (get-text-property=20line-beg=20'occur-target))=0A+=20=20=20=20=20=20=20=20= =20=20=20(m=20(occur--targets-start=20targets))=0A=20=09=20=20=20(buf=20= (marker-buffer=20m))=0A=20=09=20=20=20col)=0A=20=20=20=20=20=20=20(when=20= (and=20(get-text-property=20line-beg=20'occur-prefix)=0A=20=09=09=20(not=20= (get-text-property=20end=20'occur-prefix)))=0A=20=09(when=20(=3D=20= length=200)=0A=20=09=20=20;;=20Apply=20occur-target=20property=20to=20= inserted=20(e.g.=20yanked)=20text.=0A-=09=20=20(put-text-property=20beg=20= end=20'occur-target=20m)=0A+=09=20=20(put-text-property=20beg=20end=20= 'occur-target=20targets)=0A=20=09=20=20;;=20Did=20we=20insert=20a=20= newline?=20=20Occur=20Edit=20mode=20can't=20create=20new=0A=20=09=20=20= ;;=20Occur=20entries;=20just=20discard=20everything=20after=20the=20= newline.=0A=20=09=20=20(save-excursion=0A@@=20-1402,35=20+1407,38=20@@=20= occur-revert-function=0A=20=20=20"Handle=20`revert-buffer'=20for=20Occur=20= mode=20buffers."=0A=20=20=20(apply=20#'occur-1=20(append=20= occur-revert-arguments=20(list=20(buffer-name)))))=0A=20=0A-(defun=20= occur-mode-find-occurrence=20()=0A-=20=20(let=20((pos=20= (get-text-property=20(point)=20'occur-target)))=0A-=20=20=20=20(unless=20= pos=0A+(defun=20occur-mode--find-occurrences=20()=0A+=20=20;;=20The=20= `occur-target'=20property=20value=20is=20a=20list=20of=20(BEG=20.=20END)=20= for=20each=0A+=20=20;;=20match=20on=20the=20line,=20or=20(for=20= compatibility)=20a=20single=20marker=20to=20the=20start=0A+=20=20;;=20of=20= the=20first=20match.=0A+=20=20(let*=20((targets=20(get-text-property=20= (point)=20'occur-target))=0A+=20=20=20=20=20=20=20=20=20(start=20= (occur--targets-start=20targets)))=0A+=20=20=20=20(unless=20targets=0A=20= =20=20=20=20=20=20(error=20"No=20occurrence=20on=20this=20line"))=0A-=20=20= =20=20(unless=20(buffer-live-p=20(marker-buffer=20pos))=0A+=20=20=20=20= (unless=20(buffer-live-p=20(marker-buffer=20start))=0A=20=20=20=20=20=20=20= (error=20"Buffer=20for=20this=20occurrence=20was=20killed"))=0A-=20=20=20= =20pos))=0A+=20=20=20=20targets))=0A=20=0A=20(defalias=20= 'occur-mode-mouse-goto=20'occur-mode-goto-occurrence)=0A=20(defun=20= occur-mode-goto-occurrence=20(&optional=20event)=0A=20=20=20"Go=20to=20= the=20occurrence=20specified=20by=20EVENT,=20a=20mouse=20click.=0A=20If=20= not=20invoked=20by=20a=20mouse=20click,=20go=20to=20occurrence=20on=20= the=20current=20line."=0A=20=20=20(interactive=20(list=20= last-nonmenu-event))=0A-=20=20(let=20((buffer=20(when=20event=20= (current-buffer)))=0A-=20=20=20=20=20=20=20=20(pos=0A-=20=20=20=20=20=20=20= =20=20(if=20(null=20event)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20= Actually=20`event-end'=20works=20correctly=20with=20a=20nil=20argument=20= as=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20well,=20so=20we=20= could=20dispense=20with=20this=20test,=20but=20let's=20not=0A-=20=20=20=20= =20=20=20=20=20=20=20=20=20;;=20rely=20on=20this=20undocumented=20= behavior.=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20= (occur-mode-find-occurrence)=0A-=20=20=20=20=20=20=20=20=20=20=20= (with-current-buffer=20(window-buffer=20(posn-window=20(event-end=20= event)))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20(save-excursion=0A-=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(goto-char=20(posn-point=20= (event-end=20event)))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (occur-mode-find-occurrence)))))=0A-=20=20=20=20=20=20=20=20(regexp=20= occur-highlight-regexp))=0A+=20=20(let*=20((buffer=20(when=20event=20= (current-buffer)))=0A+=20=20=20=20=20=20=20=20=20(targets=0A+=20=20=20=20= =20=20=20=20=20=20(if=20(null=20event)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20;;=20Actually=20`event-end'=20works=20correctly=20with=20a=20= nil=20argument=20as=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20= well,=20so=20we=20could=20dispense=20with=20this=20test,=20but=20let's=20= not=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20rely=20on=20this=20= undocumented=20behavior.=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (occur-mode--find-occurrences)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= (with-current-buffer=20(window-buffer=20(posn-window=20(event-end=20= event)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20(save-excursion=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(goto-char=20= (posn-point=20(event-end=20event)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(occur-mode--find-occurrences)))))=0A+=20=20=20=20=20=20=20=20= =20(pos=20(occur--targets-start=20targets)))=0A=20=20=20=20=20= (pop-to-buffer=20(marker-buffer=20pos))=0A=20=20=20=20=20(goto-char=20= pos)=0A-=20=20=20=20(let=20((end-mk=20(save-excursion=20= (re-search-forward=20regexp=20nil=20t))))=0A-=20=20=20=20=20=20= (occur--highlight-occurrence=20pos=20end-mk))=0A+=20=20=20=20= (occur--highlight-occurrences=20targets)=0A=20=20=20=20=20(when=20buffer=20= (next-error-found=20buffer=20(current-buffer)))=0A=20=20=20=20=20= (run-hooks=20'occur-mode-find-occurrence-hook)))=0A=20=0A@@=20-1438,15=20= +1446,15=20@@=20occur-mode-goto-occurrence-other-window=0A=20=20=20"Go=20= to=20the=20occurrence=20the=20current=20line=20describes,=20in=20another=20= window."=0A=20=20=20(interactive)=0A=20=20=20(let=20((buffer=20= (current-buffer))=0A-=20=20=20=20=20=20=20=20(pos=20= (occur-mode-find-occurrence)))=0A+=20=20=20=20=20=20=20=20(pos=20= (occur--targets-start=20(occur-mode--find-occurrences))))=0A=20=20=20=20=20= (switch-to-buffer-other-window=20(marker-buffer=20pos))=0A=20=20=20=20=20= (goto-char=20pos)=0A=20=20=20=20=20(next-error-found=20buffer=20= (current-buffer))=0A=20=20=20=20=20(run-hooks=20= 'occur-mode-find-occurrence-hook)))=0A=20=0A-;;=20Stolen=20from=20= compile.el=0A=20(defun=20occur-goto-locus-delete-o=20()=0A-=20=20= (delete-overlay=20occur-highlight-overlay)=0A+=20=20(mapc=20= #'delete-overlay=20occur-highlight-overlays)=0A+=20=20(setq=20= occur-highlight-overlays=20nil)=0A=20=20=20;;=20Get=20rid=20of=20timer=20= and=20hook=20that=20would=20try=20to=20do=20this=20again.=0A=20=20=20(if=20= (timerp=20next-error-highlight-timer)=0A=20=20=20=20=20=20=20= (cancel-timer=20next-error-highlight-timer))=0A@@=20-1454,64=20+1462,55=20= @@=20occur-goto-locus-delete-o=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20#'occur-goto-locus-delete-o))=0A=20=0A=20;;=20Highlight=20the=20= current=20visited=20occurrence.=0A-;;=20Adapted=20from=20= `compilation-goto-locus'.=0A-(defun=20occur--highlight-occurrence=20(mk=20= end-mk)=0A-=20=20(let=20((highlight-regexp=20occur-highlight-regexp))=0A= -=20=20=20=20(if=20(timerp=20next-error-highlight-timer)=0A-=20=20=20=20=20= =20=20=20(cancel-timer=20next-error-highlight-timer))=0A-=20=20=20=20= (unless=20occur-highlight-overlay=0A-=20=20=20=20=20=20(setq=20= occur-highlight-overlay=0A-=09=20=20=20=20(make-overlay=20(point-min)=20= (point-min)))=0A-=20=20=20=20=20=20(overlay-put=20= occur-highlight-overlay=20'face=20'next-error))=0A-=20=20=20=20= (with-current-buffer=20(marker-buffer=20mk)=0A-=20=20=20=20=20=20= (save-excursion=0A-=20=20=20=20=20=20=20=20(if=20end-mk=20(goto-char=20= end-mk)=20(end-of-line))=0A-=20=20=20=20=20=20=20=20(let=20((end=20= (point)))=0A-=09=20=20(if=20mk=20(goto-char=20mk)=20(beginning-of-line))=0A= -=09=20=20(if=20(and=20(stringp=20highlight-regexp)=0A-=09=09=20=20=20= (re-search-forward=20highlight-regexp=20end=20t))=0A-=09=20=20=20=20=20=20= (progn=0A-=09=20=20=20=20=20=20=20=20(goto-char=20(match-beginning=200))=0A= -=09=20=20=20=20=20=20=20=20(move-overlay=20occur-highlight-overlay=0A-=09= =09=09=20=20=20=20=20=20(match-beginning=200)=20(match-end=200)=0A-=09=09= =09=20=20=20=20=20=20(current-buffer)))=0A-=09=20=20=20=20(move-overlay=20= occur-highlight-overlay=0A-=09=09=09=20=20(point)=20end=20= (current-buffer)))=0A-=09=20=20(if=20(or=20(eq=20next-error-highlight=20= t)=0A-=09=09=20=20(numberp=20next-error-highlight))=0A-=09=20=20=20=20=20= =20;;=20We=20want=20highlighting:=20delete=20overlay=20on=20next=20= input.=0A-=09=20=20=20=20=20=20(add-hook=20'pre-command-hook=0A-=09=09=20= =20=20=20=20=20=20=20#'occur-goto-locus-delete-o)=0A-=09=20=20=20=20;;=20= We=20don't=20want=20highlighting:=20delete=20overlay=20now.=0A-=09=20=20=20= =20(delete-overlay=20occur-highlight-overlay))=0A-=09=20=20;;=20We=20= want=20highlighting=20for=20a=20limited=20time:=0A-=09=20=20;;=20set=20= up=20a=20timer=20to=20delete=20it.=0A-=09=20=20(when=20(numberp=20= next-error-highlight)=0A-=09=20=20=20=20(setq=20= next-error-highlight-timer=0A-=09=09=20=20(run-at-time=20= next-error-highlight=20nil=0A-=09=09=09=20=20=20=20=20=20=20= 'occur-goto-locus-delete-o))))))=0A-=20=20=20=20(when=20(eq=20= next-error-highlight=20'fringe-arrow)=0A-=20=20=20=20=20=20;;=20We=20= want=20a=20fringe=20arrow=20(instead=20of=20highlighting).=0A-=20=20=20=20= =20=20(setq=20next-error-overlay-arrow-position=0A-=09=20=20=20=20= (copy-marker=20(line-beginning-position))))))=0A+(defun=20= occur--highlight-occurrences=20(targets)=0A+=20=20(let=20((start-marker=20= (occur--targets-start=20targets)))=0A+=20=20=20=20= (occur-goto-locus-delete-o)=0A+=20=20=20=20(with-current-buffer=20= (marker-buffer=20start-marker)=0A+=20=20=20=20=20=20(when=20(or=20(eq=20= next-error-highlight=20t)=0A+=09=20=20=20=20=20=20=20=20(numberp=20= next-error-highlight))=0A+=20=20=20=20=20=20=20=20(setq=20= occur-highlight-overlays=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (mapcar=20(lambda=20(target)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20(let=20((o=20(make-overlay=20(car=20= target)=20(cdr=20target))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(overlay-put=20o=20'face=20= 'next-error)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20o))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(if=20(listp=20targets)=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20targets=0A+=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20= `occur-target'=20compatibility:=20when=20we=20only=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20have=20a=20= single=20starting=20point,=20highlight=20the=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20rest=20of=20the=20= line.=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(let=20((end-pos=20(save-excursion=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(goto-char=20start-marker)=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(line-end-position))))=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(list=20(cons=20= start-marker=20end-pos))))))=0A+=20=20=20=20=20=20=20=20(add-hook=20= 'pre-command-hook=20#'occur-goto-locus-delete-o)=0A+=20=20=20=20=20=20=20= =20(when=20(numberp=20next-error-highlight)=0A+=20=20=20=20=20=20=20=20=20= =20;;=20We=20want=20highlighting=20for=20a=20limited=20time:=0A+=20=20=20= =20=20=20=20=20=20=20;;=20set=20up=20a=20timer=20to=20delete=20it.=0A+=09= =20=20(setq=20next-error-highlight-timer=0A+=09=20=20=20=20=20=20=20=20= (run-at-time=20next-error-highlight=20nil=0A+=09=09=09=20=20=20=20=20= 'occur-goto-locus-delete-o))))=0A+=0A+=20=20=20=20=20=20(when=20(eq=20= next-error-highlight=20'fringe-arrow)=0A+=20=20=20=20=20=20=20=20;;=20We=20= want=20a=20fringe=20arrow=20(instead=20of=20highlighting).=0A+=20=20=20=20= =20=20=20=20(setq=20next-error-overlay-arrow-position=0A+=09=20=20=20=20=20= =20(copy-marker=20(line-beginning-position)))))))=0A=20=0A=20(defun=20= occur-mode-display-occurrence=20()=0A=20=20=20"Display=20in=20another=20= window=20the=20occurrence=20the=20current=20line=20describes."=0A=20=20=20= (interactive)=0A-=20=20(let=20((buffer=20(current-buffer))=0A-=20=20=20=20= =20=20=20=20(pos=20(occur-mode-find-occurrence))=0A-=20=20=20=20=20=20=20= =20(regexp=20occur-highlight-regexp)=0A-=20=20=20=20=20=20=20=20= (next-error-highlight=20next-error-highlight-no-select)=0A-=20=20=20=20=20= =20=20=20(display-buffer-overriding-action=0A-=20=20=20=20=20=20=20=20=20= '(nil=20(inhibit-same-window=20.=20t)))=0A-=09window)=0A+=20=20(let*=20= ((buffer=20(current-buffer))=0A+=20=20=20=20=20=20=20=20=20(targets=20= (occur-mode--find-occurrences))=0A+=20=20=20=20=20=20=20=20=20(pos=20= (occur--targets-start=20targets))=0A+=20=20=20=20=20=20=20=20=20= (next-error-highlight=20next-error-highlight-no-select)=0A+=20=20=20=20=20= =20=20=20=20(display-buffer-overriding-action=0A+=20=20=20=20=20=20=20=20= =20=20'(nil=20(inhibit-same-window=20.=20t)))=0A+=09=20window)=0A=20=20=20= =20=20(setq=20window=20(display-buffer=20(marker-buffer=20pos)=20t))=0A=20= =20=20=20=20;;=20This=20is=20the=20way=20to=20set=20point=20in=20the=20= proper=20window.=0A=20=20=20=20=20(save-selected-window=0A=20=20=20=20=20= =20=20(select-window=20window)=0A=20=20=20=20=20=20=20(goto-char=20pos)=0A= -=20=20=20=20=20=20(let=20((end-mk=20(save-excursion=20= (re-search-forward=20regexp=20nil=20t))))=0A-=20=20=20=20=20=20=20=20= (occur--highlight-occurrence=20pos=20end-mk))=0A+=20=20=20=20=20=20= (occur--highlight-occurrences=20targets)=0A=20=20=20=20=20=20=20= (next-error-found=20buffer=20(current-buffer))=0A=20=20=20=20=20=20=20= (run-hooks=20'occur-mode-find-occurrence-hook))))=0A=20=0A@@=20-1868,7=20= +1867,6=20@@=20occur-1=0A=20=09=20=20=20=20(buffer-undo-list=20t)=0A=20=09= =20=20=20=20(occur--final-pos=20nil))=0A=20=09(erase-buffer)=0A-=20=20=20= =20=20=20=20=20(setq-local=20occur-highlight-regexp=20regexp)=0A=20=09= (let=20((count=0A=20=09=20=20=20=20=20=20=20(if=20(stringp=20nlines)=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20Treat=20= nlines=20as=20a=20regexp=20to=20collect.=0A@@=20-1968,7=20+1966,7=20@@=20= occur-engine=0A=20=09=09=20=20=20=20=20=20=20(origpt=20nil)=0A=20=09=09=20= =20=20=20=20=20=20(begpt=20nil)=0A=20=09=09=20=20=20=20=20=20=20(endpt=20= nil)=0A-=09=09=20=20=20=20=20=20=20(marker=20nil)=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20markers=20=20=20=20=20=20= =20=20=20=20=20=20;=20list=20of=20(BEG-MARKER=20.=20END-MARKER)=0A=20=09=09= =20=20=20=20=20=20=20(curstring=20"")=0A=20=09=09=20=20=20=20=20=20=20= (ret=20nil)=0A=20=09=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20= The=20following=20binding=20is=20for=20when=20case-fold-search=0A@@=20= -1994,8=20+1992,7=20@@=20occur-engine=0A=20=09=09=20=20=20=20=20=20=20=20= (setq=20endpt=20(line-end-position)))=0A=20=09=09=20=20=20=20=20=20;;=20= Sum=20line=20numbers=20up=20to=20the=20first=20match=20line.=0A=20=09=09=20= =20=20=20=20=20(setq=20curr-line=20(+=20curr-line=20(count-lines=20= origpt=20begpt)))=0A-=09=09=20=20=20=20=20=20(setq=20marker=20= (make-marker))=0A-=09=09=20=20=20=20=20=20(set-marker=20marker=20= matchbeg)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(setq=20markers=20nil)=0A=20=09=09=20=20=20=20=20=20(setq=20= curstring=20(occur-engine-line=20begpt=20endpt=20keep-props))=0A=20=09=09= =20=20=20=20=20=20;;=20Highlight=20the=20matches=0A=20=09=09=20=20=20=20=20= =20(let=20((len=20(length=20curstring))=0A@@=20-2017,6=20+2014,11=20@@=20= occur-engine=0A=20=09=09=09=20=20=20=20(setq=20orig-line-shown-p=20t)))=0A= =20=09=09=20=20=20=20=20=20=20=20(while=20(and=20(<=20start=20len)=0A=20=09= =09=09=09=20=20=20=20(string-match=20regexp=20curstring=20start))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (push=20(cons=20(set-marker=20(make-marker)=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(+=20begpt=20= (match-beginning=200)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (set-marker=20(make-marker)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(+=20begpt=20(match-end=200))))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20markers)=0A=20=09=09=09=20=20(setq=20matches=20(1+=20= matches))=0A=20=09=09=09=20=20(add-text-properties=0A=20=09=09=09=20=20=20= (match-beginning=200)=20(match-end=200)=0A@@=20-2029,6=20+2031,7=20@@=20= occur-engine=0A=20=09=09=09=20=20;;=20Avoid=20infloop=20(Bug#7593).=0A=20= =09=09=09=20=20(let=20((end=20(match-end=200)))=0A=20=09=09=09=20=20=20=20= (setq=20start=20(if=20(=3D=20start=20end)=20(1+=20start)=20end)))))=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(setq=20= markers=20(nreverse=20markers))=0A=20=09=09=20=20=20=20=20=20;;=20= Generate=20the=20string=20to=20insert=20for=20this=20match=0A=20=09=09=20= =20=20=20=20=20(let*=20((match-prefix=0A=20=09=09=09=20=20=20=20=20=20;;=20= Using=207=20digits=20aligns=20tabs=20properly.=0A@@=20-2042,7=20+2045,7=20= @@=20occur-engine=0A=20=09=09=09=09=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20;;=20(for=20Occur=20Edit=20mode).=0A=20=09=09=09=09= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= front-sticky=20t=0A=20=09=09=09=09=09=09=20=20=20=20=20rear-nonsticky=20= t=0A-=09=09=09=09=09=09=20=20=20=20=20occur-target=20,marker=0A+=09=09=09= =09=09=09=20=20=20=20=20occur-target=20,markers=0A=20=09=09=09=09=09=09=20= =20=20=20=20follow-link=20t=0A=20=09=09=09=09=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20help-echo=20"mouse-2:=20go=20to=20this=20= occurrence"))))=0A=20=09=09=09=20=20=20=20=20(match-str=0A@@=20-2050,7=20= +2053,7=20@@=20occur-engine=0A=20=09=09=09=20=20=20=20=20=20;;=20because=20= that=20loses.=20=20And=20don't=20put=20it=0A=20=09=09=09=20=20=20=20=20=20= ;;=20on=20context=20lines=20to=20reduce=20flicker.=0A=20=09=09=09=20=20=20= =20=20=20(propertize=20curstring=0A-=09=09=09=09=09=20=20'occur-target=20= marker=0A+=09=09=09=09=09=20=20'occur-target=20markers=0A=20=09=09=09=09=09= =20=20'follow-link=20t=0A=20=09=09=09=09=09=20=20'help-echo=0A=20=09=09=09= =09=09=20=20"mouse-2:=20go=20to=20this=20occurrence"))=0A@@=20-2069,8=20= +2072,8=20@@=20occur-engine=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20;;=20get=20a=20= contiguous=20highlight.=0A=20=09=09=09=20=20=20=20=20=20=20=20= (propertize=20(concat=20match-prefix=20match-str)=0A=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20'mouse-face=20'highlight))=0A-=09=09= =09=20=20=20=20=20=20=20;;=20Add=20marker=20at=20eol,=20but=20no=20mouse=20= props.=0A-=09=09=09=20=20=20=20=20=20=20(propertize=20"\n"=20= 'occur-target=20marker)))=0A+=09=09=09=20=20=20=20=20=20=20;;=20Add=20= markers=20at=20eol,=20but=20no=20mouse=20props.=0A+=09=09=09=20=20=20=20=20= =20=20(propertize=20"\n"=20'occur-target=20markers)))=0A=20=09=09=09=20=20= =20=20=20(data=0A=20=09=09=09=20=20=20=20=20=20(if=20(=3D=20nlines=200)=0A= =20=09=09=09=09=20=20;;=20The=20simple=20display=20style=0Adiff=20--git=20= a/test/lisp/replace-tests.el=20b/test/lisp/replace-tests.el=0Aindex=20= 417946c35f..7f62a417a0=20100644=0A---=20a/test/lisp/replace-tests.el=0A= +++=20b/test/lisp/replace-tests.el=0A@@=20-589,7=20+589,7=20@@=20= occur-highlight-occurrence=0A=20=20=20=20=20=20=20= (replace-tests-with-highlighted-occurrence=20highlight-locus=0A=20=20=20=20= =20=20=20=20=20(occur-mode-display-occurrence)=0A=20=20=20=20=20=20=20=20= =20(with-current-buffer=20(marker-buffer=0A-=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (get-text-property=20(point)=20'occur-target))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(caar=20= (get-text-property=20(point)=20'occur-target)))=0A=20=20=20=20=20=20=20=20= =20=20=20(should=20(funcall=20check-overlays=20has-overlay)))))))=0A=20=0A= =20(ert-deftest=20replace-regexp-bug45973=20()=0A--=20=0A2.21.1=20(Apple=20= Git-122.3)=0A=0A= --Apple-Mail=_75554E38-7061-4293-AB83-C7796877E55E-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 02:41:27 2021 Received: (at 39121) by debbugs.gnu.org; 25 Jul 2021 06:41:27 +0000 Received: from localhost ([127.0.0.1]:47409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7XpG-0008GB-PA for submit@debbugs.gnu.org; Sun, 25 Jul 2021 02:41:26 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7XpE-0008Fx-7x for 39121@debbugs.gnu.org; Sun, 25 Jul 2021 02:41:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YJj063Zeqc1IAXNcyidNmLQYOMAtQ7HTAtZmYVmZ5BQ=; b=tEeyM9Un6K8Kk7tYzuYyDaIgG7 aWXlNm5xawGFKWV/AYjbjHXZNelbwTshTX5uXYXP4M11FSx/qfP70dzWk3E0aMnowtFsABtbh0osh mzZB7drw0kQzQIsmw1AZ4I/A7jqAMT2Nn9ZqpXi6TGsbhP4Xkjz+OyRMovdODIR2S4P0=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7Xp4-0006D4-Jr; Sun, 25 Jul 2021 08:41:17 +0200 From: Lars Ingebrigtsen To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEWpYhtZLB7pohnu 0aH///80edrZAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UHGQYaHcLKDiQAAAGVSURBVDjLVVOBkcMw CAN+AfwT8M4Gzf67vQQ2tX29pkWRABlE6ujAEZk8eIjKqCNis04gHgB4EJ+z4/mtQAMydsT5OxmU tx3GD+MT2jEaqDwqBhExda3csfIjCBUK4eOdhMDAu6hI9awKefl/rD4kmmIqTu0CXL6cBEYSL6mp JkvKbwAyXl6xhiu5/CagN8PwWjKUzZwmoiCfDkDY4bwQj18qjsPdQozeKqo642Vmmu4ScgEBH7Jc i5uCu0hLPC/nRhLA9ZJ/SMEvISEmtNTim4N+7ZLwTisRkMzEptL5FC2AHg7ebwGBEIZhVlnrezti 4cHb0hW3LlUScBrs3tOb9iaD+kOOsY5hkSKunFXfhiHYgJ/e0/fY+1GWNdIAOZ0jb36Pj+49Y+u5 IQkIut8eRt1O7pmWI6tBkJ7P3DnYUiE27ZkHIH/LEyi9JNJbmMKWZHb6txiSyyY7O4Sedw31SIZJ ZSclh4EgWvUCsKbTXuEgYnH9u+3ZxlszSrT3CsCDHD+i69ZHlcu7TUaNg/aCcint+fwD5Chalzzb s+IAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDctMjVUMDY6MjY6MjkrMDA6MDDdxZBdAAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIxLTA3LTI1VDA2OjI2OjI5KzAwOjAwrJgo4QAAAABJRU5ErkJggg== X-Now-Playing: Prince's _Sign 'O' the Times (2)_: "It's Gonna Be A Beautiful Night" Date: Sun, 25 Jul 2021 08:41:14 +0200 In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sat, 24 Jul 2021 19:29:57 +0200") Message-ID: <87czr6zyid.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mattias Engdegård writes: > All right, this might work. Patch! Skimming the patch, it makes sense to me. (But I didn't try it.) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39121 Cc: Tino Calancha , 39121@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mattias Engdeg=C3=A5rd writes: > All right, this might work. Patch! Skimming the patch, it makes sense to me. (But I didn't try it.) > The immediate visible benefit is that all matches on the same line are > highlighted, not just the first one. It also fixes the compatibility > problems mentioned above by removing occur-highlight-regexp entirely. > > External packages that populate occur-mode buffers themselves should > still work, since the old `occur-target` property format is still > recognised. In those cases we just highlight from the first match to > the end of the line. Great; go ahead and push. (And I see that `occur-highlight-regexp' was introduced after emacs-27, so it's indeed OK to just remove it like your patch does.) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 05:17:00 2021 Received: (at 39121) by debbugs.gnu.org; 25 Jul 2021 09:17:01 +0000 Received: from localhost ([127.0.0.1]:47601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7aFo-0003pD-HY for submit@debbugs.gnu.org; Sun, 25 Jul 2021 05:17:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7aFn-0003p0-0K for 39121@debbugs.gnu.org; Sun, 25 Jul 2021 05:16:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34404) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7aFg-00068p-NJ; Sun, 25 Jul 2021 05:16:52 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2686 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7aFg-00006t-9D; Sun, 25 Jul 2021 05:16:52 -0400 Date: Sun, 25 Jul 2021 12:16:42 +0300 Message-Id: <83y29uwy6d.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87czr6zyid.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 25 Jul 2021 08:41:14 +0200) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> <87czr6zyid.fsf@gnus.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39121 Cc: mattiase@acm.org, tino.calancha@gmail.com, 39121@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Sun, 25 Jul 2021 08:41:14 +0200 > Cc: Juri Linkov , 39121@debbugs.gnu.org, > Tino Calancha > > Mattias Engdegård writes: > > > All right, this might work. Patch! > > Skimming the patch, it makes sense to me. (But I didn't try it.) > > > The immediate visible benefit is that all matches on the same line are > > highlighted, not just the first one. It also fixes the compatibility > > problems mentioned above by removing occur-highlight-regexp entirely. > > > > External packages that populate occur-mode buffers themselves should > > still work, since the old `occur-target` property format is still > > recognised. In those cases we just highlight from the first match to > > the end of the line. > > Great; go ahead and push. > > (And I see that `occur-highlight-regexp' was introduced after emacs-27, > so it's indeed OK to just remove it like your patch does.) Should we say something about these changes in NEWS? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 06:07:37 2021 Received: (at 39121) by debbugs.gnu.org; 25 Jul 2021 10:07:37 +0000 Received: from localhost ([127.0.0.1]:47635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7b2n-00052c-Am for submit@debbugs.gnu.org; Sun, 25 Jul 2021 06:07:37 -0400 Received: from mail33c50.megamailservers.eu ([91.136.10.43]:44526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7b2k-00052M-LT for 39121@debbugs.gnu.org; Sun, 25 Jul 2021 06:07:36 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1627207652; bh=27MnJcSHQNeL4K2QuIijKRVglgbg0NvQ0Kt9UuG0krw=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=NaiMu5zjAgECbpelSVS7Bnqigu8549nOjGJXO85GvvQycLJuqtgueTowuLEe4ot/f xsUAXhEC4S9yn2AmqdGkurzLXp21fMKN5hKKBKzt2vPYjdEkYYG5eMCnXhrXWxRHVi 9lN5wRhddadvCUONRuDBgWRFyDgaJCA351VJuCR0= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16PA7Tmg010041; Sun, 25 Jul 2021 10:07:31 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87czr6zyid.fsf@gnus.org> Date: Sun, 25 Jul 2021 12:06:32 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <86CEBED8-2521-4316-B91A-281F2CD8148C@acm.org> References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> <87czr6zyid.fsf@gnus.org> To: Lars Ingebrigtsen X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F24.60FD37E4.0011, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Rbbu9Glv c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=AVljOmqZDH_lo8IwlrEA:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 39121 Cc: Tino Calancha , 39121@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 25 juli 2021 kl. 08.41 skrev Lars Ingebrigtsen : > Great; go ahead and push. Thank you, done. I also noticed that occur-edit-mode manhandled markers on the edited = line so that even changing a single character outside a match would = destroy all occur-target highlighting on that line. I pushed a fix for = that, too. That bug has apparently been with us from the beginning of = occur-edit-mode but not noticed until now. > (And I see that `occur-highlight-regexp' was introduced after = emacs-27, > so it's indeed OK to just remove it like your patch does.) Yes, and I have tested the code against an external package that creates = its own occur-mode buffers and it works as expected. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 06:55:58 2021 Received: (at 39121) by debbugs.gnu.org; 25 Jul 2021 10:55:58 +0000 Received: from localhost ([127.0.0.1]:47664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7bnZ-0006Nn-81 for submit@debbugs.gnu.org; Sun, 25 Jul 2021 06:55:58 -0400 Received: from mail18c50.megamailservers.eu ([91.136.10.28]:37764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7bnU-0006Nb-F3 for 39121@debbugs.gnu.org; Sun, 25 Jul 2021 06:55:56 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1627210550; bh=9zQdW+XdYdUyv0vSKmHOPAztyoK5EF4znSTpczNqXHg=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=gCid4/zzuWOInR+bJ75CdHmkxmCtkMRuK5WID0GyeNbqqesutWnKfwaOSkEpM4gi/ DrZVNvHbt4T+ayuSzVAwX7YfbQWsJOLUwyW+vLG4jy+vXLQvuFan7Q5BOGLz17y8i8 UyZ40vni2IeZ73JaRcGMrEpfR39Hqr12S2cgAATQ= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16PAtlwt000508; Sun, 25 Jul 2021 10:55:49 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83y29uwy6d.fsf@gnu.org> Date: Sun, 25 Jul 2021 12:55:47 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <1E39DC01-B819-4D0C-AA21-CC43BDF7D5E6@acm.org> References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> <87czr6zyid.fsf@gnus.org> <83y29uwy6d.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F23.60FD4336.000E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Vt9d/N+n c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=HNyvvmfnPAF1pY85SCkA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 39121 Cc: Lars Ingebrigtsen , tino.calancha@gmail.com, 39121@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 25 juli 2021 kl. 11.16 skrev Eli Zaretskii : > Should we say something about these changes in NEWS? That's a good question. No incompatible changes were made, nor were any = new facilities introduced that a user needs to know about. Did you have = anything particular in mind? Packages that attempt to piggy-back onto occur-mode do depend on = undocumented implementation aspects, but after this change, they now = work again as before. If we think that it is a good idea to use = occur-mode in that way, we should provide a programming interface. The previous change (abe7c22da966) made `next-error-highlight` and = `next-error-highlight-no-select` effective in occur-mode. Perhaps that = should make it to NEWS. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 07:39:27 2021 Received: (at 39121) by debbugs.gnu.org; 25 Jul 2021 11:39:27 +0000 Received: from localhost ([127.0.0.1]:47695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7cTf-0001Ap-7Y for submit@debbugs.gnu.org; Sun, 25 Jul 2021 07:39:27 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:53791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7cTc-0001Ab-Mo for 39121@debbugs.gnu.org; Sun, 25 Jul 2021 07:39:25 -0400 Received: by mail-wm1-f41.google.com with SMTP id k4so3511028wms.3 for <39121@debbugs.gnu.org>; Sun, 25 Jul 2021 04:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=zsp9Y5VcV71M+/UPIJrc6Gb4Xna/Q8rT1O6oufPeetM=; b=BDoyT9drt11fX/IJxlhuE1yoWDeMppTMJGhRz4iWbl9zryIXz2s4sf8jeVjbeZp2fI RT8/TRsmbJPU+9KzBqEtbR0VHNP0huXeDQT13FgR5v2gDmPeCsoSSlD54+QRCzuTGegi T847Zk23wk75ag3aJVfF0C+rRfeIY/94gk1B6uWR8sfIQX1aOk3Sq/G6D33jmLEyDKBC h35PtD7J109sV747Mzru+FNMP4sf5wqV2RG+ZBcII5ft8OntY3c+Chu6vKTv5YmZ4kZq yQ4OwyL4lqlbyN4sJSvLqIRZgJ6jHuPOhMCGoeovhCJYuBaPznM9rtnyK9vPnm+4YVEe brFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=zsp9Y5VcV71M+/UPIJrc6Gb4Xna/Q8rT1O6oufPeetM=; b=HIupVEfbQUTM01ZesMNSpopUlBaGYa6Fz2sSsoFnhkODlT7+JAOPKc98DS526BbLA3 KhzTnAY3zi2ovm8aqaARYzpkDhAC4b8SxTK4wWHuYRBEU/fko8byFYCV7zBtlWa/AfCO redH7D9OvAqkToQVP+2GMj0oIYzbR5uBGzeEw9fkJloeEx6cIByDd6IL8Yo6pK5z9R5u vgPGs2FFz5wbRMyxy2usTTk0OM6wmgf/tLLYxXSQcXYGtYlNn8Du6RfZUHB6PHvQdDoD kTgAVUMpU3rxtXHW2WtAt0/yGtm7aRB+O6DEvvQS38CYp5ezPROdkywPv0nNXk3YW2iI iYbQ== X-Gm-Message-State: AOAM532W8dnOsqhyxcs8FPD2RkmP+N0EVZcKcJQTYam1VngtuBwwHH+3 F4YI+ID2tmigbL9kLFyOPBZXWw== X-Google-Smtp-Source: ABdhPJyue17ngVMv1M8mjuc5ViDWMNDIsBPlAjZ+foNm/6UbdicTxjpa1mJFdyM9aAI6syXzl7UFvw== X-Received: by 2002:a7b:c8d2:: with SMTP id f18mr12506380wml.135.1627213158817; Sun, 25 Jul 2021 04:39:18 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id e8sm18398166wrc.6.2021.07.25.04.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jul 2021 04:39:18 -0700 (PDT) From: "Basil L. Contovounesios" To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> <87czr6zyid.fsf@gnus.org> <83y29uwy6d.fsf@gnu.org> <1E39DC01-B819-4D0C-AA21-CC43BDF7D5E6@acm.org> Date: Sun, 25 Jul 2021 12:39:16 +0100 In-Reply-To: <1E39DC01-B819-4D0C-AA21-CC43BDF7D5E6@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sun, 25 Jul 2021 12:55:47 +0200") Message-ID: <87pmv6vd0b.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 39121 Cc: 39121@debbugs.gnu.org, Eli Zaretskii , tino.calancha@gmail.com, Lars Ingebrigtsen , juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd writes: > 25 juli 2021 kl. 11.16 skrev Eli Zaretskii : > >> Should we say something about these changes in NEWS? > > That's a good question. No incompatible changes were made, nor were any n= ew > facilities introduced that a user needs to know about. Did you have anyth= ing > particular in mind? Just one minor incompatibility: the function occur-mode-find-occurrence is still used in lisp/eshell/em-unix.el. Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 07:49:30 2021 Received: (at 39121) by debbugs.gnu.org; 25 Jul 2021 11:49:31 +0000 Received: from localhost ([127.0.0.1]:47703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7cdO-0001PQ-Hy for submit@debbugs.gnu.org; Sun, 25 Jul 2021 07:49:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7cdL-0001PC-Fn for 39121@debbugs.gnu.org; Sun, 25 Jul 2021 07:49:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35928) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7cdF-00017r-Ax; Sun, 25 Jul 2021 07:49:21 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3999 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7cdE-0001fh-Ui; Sun, 25 Jul 2021 07:49:21 -0400 Date: Sun, 25 Jul 2021 14:49:07 +0300 Message-Id: <83wnpewr4c.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <1E39DC01-B819-4D0C-AA21-CC43BDF7D5E6@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Sun, 25 Jul 2021 12:55:47 +0200) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> <87czr6zyid.fsf@gnus.org> <83y29uwy6d.fsf@gnu.org> <1E39DC01-B819-4D0C-AA21-CC43BDF7D5E6@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39121 Cc: larsi@gnus.org, tino.calancha@gmail.com, 39121@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Sun, 25 Jul 2021 12:55:47 +0200 > Cc: Lars Ingebrigtsen , juri@linkov.net, 39121@debbugs.gnu.org, > tino.calancha@gmail.com > > 25 juli 2021 kl. 11.16 skrev Eli Zaretskii : > > > Should we say something about these changes in NEWS? > > That's a good question. No incompatible changes were made, nor were any new facilities introduced that a user needs to know about. Did you have anything particular in mind? That the occur-target text property's value can now be something new, and that this new value form is actually the preferred one? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 10:45:21 2021 Received: (at 39121) by debbugs.gnu.org; 25 Jul 2021 14:45:21 +0000 Received: from localhost ([127.0.0.1]:49123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7fNY-0006NH-QA for submit@debbugs.gnu.org; Sun, 25 Jul 2021 10:45:21 -0400 Received: from mail176c50.megamailservers.eu ([91.136.10.186]:56216 helo=mail37c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7fNV-0006N6-MI for 39121@debbugs.gnu.org; Sun, 25 Jul 2021 10:45:18 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1627224315; bh=CqMFAs8LIbNrKf8XApUNwdcsCgmMKV8jeEXNfmquH54=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=KEIn0x3PyeOLm0M90retvtWXeuO7coArmcs0TnsGB9zC6QxgWlhZxgP9GuKNB5NHW iQbh5KriSiHJgDHJy4YGDYqEQVoEATIkTuW/cEFCPN/MLehPlfitnr3Zz9AQrQFDKS ss7Qr7yjo05suK03d2Gvk1Bnhgdc3TGlQxwLfG+Y= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16PEjBiC024415; Sun, 25 Jul 2021 14:45:13 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87pmv6vd0b.fsf@tcd.ie> Date: Sun, 25 Jul 2021 16:45:11 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> <87czr6zyid.fsf@gnus.org> <83y29uwy6d.fsf@gnu.org> <1E39DC01-B819-4D0C-AA21-CC43BDF7D5E6@acm.org> <87pmv6vd0b.fsf@tcd.ie> To: "Basil L. Contovounesios" X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F28.60FD78FB.0011, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Grk8BX9C c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=ltRlMzTeDtmTjzUT3YgA:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 39121 Cc: 39121@debbugs.gnu.org, Eli Zaretskii , tino.calancha@gmail.com, Lars Ingebrigtsen , juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 25 juli 2021 kl. 13.39 skrev Basil L. Contovounesios : > Just one minor incompatibility: the function = occur-mode-find-occurrence > is still used in lisp/eshell/em-unix.el. Right, and searching some more reveals that it's used by a few external = packages as well (like fstar-mode). I've put it back and things seem to = work again. Thank you for finding this! From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 11:09:50 2021 Received: (at 39121) by debbugs.gnu.org; 25 Jul 2021 15:09:51 +0000 Received: from localhost ([127.0.0.1]:49142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7flG-0006zi-K8 for submit@debbugs.gnu.org; Sun, 25 Jul 2021 11:09:50 -0400 Received: from mail1464c50.megamailservers.eu ([91.136.14.64]:42070 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7flE-0006zR-3D for 39121@debbugs.gnu.org; Sun, 25 Jul 2021 11:09:49 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1627225780; bh=kpqfmpZH+hy9Q+r5nDD2GzMhRC89wgaYdG4KD677Xm4=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=BWaU3N0KrendghaC/p4nLq8ioUw4pWFu98q29wwq1ti94OzinaMrHE3cHwyMSmv2K nyr72id/Tz1QtJI5kmQO7PJnod/MsoAHEJejMitixHQtWoC003d0EZgPT2hgWqEyYa Gg9T8LWRIdwBJriWF2J9kD9wcx4xES3Ib/LIxUmU= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16PF9cES018634; Sun, 25 Jul 2021 15:09:39 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83wnpewr4c.fsf@gnu.org> Date: Sun, 25 Jul 2021 17:09:37 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> <87czr6zyid.fsf@gnus.org> <83y29uwy6d.fsf@gnu.org> <1E39DC01-B819-4D0C-AA21-CC43BDF7D5E6@acm.org> <83wnpewr4c.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F28.60FD7EB4.0035, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=OogxNB3t c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=ccacyByAP-FSeBbLb_wA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 25 juli 2021 kl. 13.49 skrev Eli Zaretskii : > That the occur-target text property's value can now be something new, > and that this new value form is actually the preferred one? Maybe, but we never said anything about occur-target to begin with. It's like telling school-children that from now on they should use a different place for smoking weed. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 39121 Cc: larsi@gnus.org, tino.calancha@gmail.com, 39121@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 25 juli 2021 kl. 13.49 skrev Eli Zaretskii : > That the occur-target text property's value can now be something new, > and that this new value form is actually the preferred one? Maybe, but we never said anything about occur-target to begin with. It's = like telling school-children that from now on they should use a = different place for smoking weed. I'm not necessarily against it either. There may be a slight advantage = for some code that can make good use of the new format. However, we can = keep supporting existing code more or less indefinitely. It is also really not a good programming interface. I just fixed several = bit-rot bugs in tex-mode.el (none related to my changes) and it turns = out that the exact details of populating an occur-mode buffer are fiddly = and easy to get wrong. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 12:27:30 2021 Received: (at 39121) by debbugs.gnu.org; 25 Jul 2021 16:27:30 +0000 Received: from localhost ([127.0.0.1]:49258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7gyQ-0000VX-8t for submit@debbugs.gnu.org; Sun, 25 Jul 2021 12:27:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7gyL-0000VI-EM for 39121@debbugs.gnu.org; Sun, 25 Jul 2021 12:27:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41538) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7gyF-0005zr-3l; Sun, 25 Jul 2021 12:27:19 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1385 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7gyE-0006Yq-Np; Sun, 25 Jul 2021 12:27:19 -0400 Date: Sun, 25 Jul 2021 19:27:08 +0300 Message-Id: <83czr6we8z.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Sun, 25 Jul 2021 17:09:37 +0200) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> <87czr6zyid.fsf@gnus.org> <83y29uwy6d.fsf@gnu.org> <1E39DC01-B819-4D0C-AA21-CC43BDF7D5E6@acm.org> <83wnpewr4c.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39121 Cc: larsi@gnus.org, tino.calancha@gmail.com, 39121@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Sun, 25 Jul 2021 17:09:37 +0200 > Cc: larsi@gnus.org, juri@linkov.net, 39121@debbugs.gnu.org, > tino.calancha@gmail.com > > 25 juli 2021 kl. 13.49 skrev Eli Zaretskii : > > > That the occur-target text property's value can now be something new, > > and that this new value form is actually the preferred one? > > Maybe, but we never said anything about occur-target to begin with. The NEWS file doesn't necessarily describe only stuff documented somewhere, it also describes changes that aren't documented anywhere but the source code. Suppose someone read the source of replace.el, found out about this property, and uses it to do something, either privately or for some 3rd-part package. Put yourself in the shows of that person and ask yourself whether you'd like to know that this kind of change has been installed in Emacs. > I'm not necessarily against it either. There may be a slight advantage for some code that can make good use of the new format. However, we can keep supporting existing code more or less indefinitely. Since you introduced the new format, you probably thought it to be better than the existing one, right? Then telling others about that would be a good service, IMO. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 14:54:55 2021 Received: (at 39121) by debbugs.gnu.org; 25 Jul 2021 18:54:55 +0000 Received: from localhost ([127.0.0.1]:49386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7jH5-00042M-Ex for submit@debbugs.gnu.org; Sun, 25 Jul 2021 14:54:55 -0400 Received: from mail234c50.megamailservers.eu ([91.136.10.244]:59964 helo=mail37c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7jH3-00042B-2O for 39121@debbugs.gnu.org; Sun, 25 Jul 2021 14:54:54 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1627239290; bh=or2dxH5rh1oEBA2IcwhxK0vF4Nw/GvTO2ilT/Fb57L0=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Qghl1VJTmcenB28STj6dNnkLLh+kUu2QjI2PubZe5vPbCzmeJIunJjKGkfnNnQtpb sxzDfGLlBzpHhjn03csKaQJXNyxCQhphDTGRUXOVRX0x9bawJeR5wuiZFW9wlnC6ML 5t3z94l2SgYW6qQBfpIp2wMfDszAsfKs7Qf4D8Uo= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16PIsmpn019538; Sun, 25 Jul 2021 18:54:49 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83czr6we8z.fsf@gnu.org> Date: Sun, 25 Jul 2021 20:54:47 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <408C22B8-4A9D-409F-8610-1AE86294FC20@acm.org> References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> <87czr6zyid.fsf@gnus.org> <83y29uwy6d.fsf@gnu.org> <1E39DC01-B819-4D0C-AA21-CC43BDF7D5E6@acm.org> <83wnpewr4c.fsf@gnu.org> <83czr6we8z.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F23.60FDB37A.0015, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Grk8BX9C c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=UL2DRF47B9PyA4fQrygA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 25 juli 2021 kl. 18.27 skrev Eli Zaretskii : > The NEWS file doesn't necessarily describe only stuff documented > somewhere, it also describes changes that aren't documented anywhere > but the source code. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 39121 Cc: larsi@gnus.org, tino.calancha@gmail.com, 39121@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 25 juli 2021 kl. 18.27 skrev Eli Zaretskii : > The NEWS file doesn't necessarily describe only stuff documented > somewhere, it also describes changes that aren't documented anywhere > but the source code. Yes, but then it's always something that affects the user in some way, = isn't it? Mentioning changed internals doesn't seem to be standard = practice, but I could be wrong about that. Would you point out a few = examples of where we described changed aspects of undocumented = implementation details in NEWS? That would support your view and help me = understand it better. The question is also whether it should be documented at all. The fact = that it never was before, as well as the general ad-hoc nature of the = interface, are strong indicators that it probably shouldn't be. As a case in point: until Lars and I fixed it, the use of occur-mode in = tex-mode.el had been broken since at least Emacs 24, in equal parts for = reasons of bit-rot (implementation details changed) and incorrect = assumptions of interface invariants. And this is an Emacs core package. > Suppose someone read the source of replace.el, > found out about this property, and uses it to do something, either > privately or for some 3rd-part package. Put yourself in the shows of > that person and ask yourself whether you'd like to know that this kind > of change has been installed in Emacs. The `occur-target` property alone is far from sufficient for populating = occur-mode buffers; it is one implementation detail of many. A little = knowledge and all that. It would have been different if we had changed the implementation = incompatibly; in such case, I agree it would have been polite to issue a = notice about it. But nothing should break as a result of the change we = are talking about. > Since you introduced the new format, you probably thought it to be > better than the existing one, right? Then telling others about that > would be a good service, IMO. The change was made exclusively for improving Occur itself, and the = external packages that I have seen would generally draw little advantage = from doing anything differently. Of course, I haven't seen them all, but = having other people depending on implementation details of your software = is a maintenance burden which either impedes progress. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 15:23:45 2021 Received: (at 39121) by debbugs.gnu.org; 25 Jul 2021 19:23:45 +0000 Received: from localhost ([127.0.0.1]:49411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7jiz-0004kc-4Y for submit@debbugs.gnu.org; Sun, 25 Jul 2021 15:23:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7jiw-0004kO-Oa for 39121@debbugs.gnu.org; Sun, 25 Jul 2021 15:23:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43470) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7jiq-0005Gg-9B; Sun, 25 Jul 2021 15:23:36 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4228 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7jip-0007fi-TX; Sun, 25 Jul 2021 15:23:36 -0400 Date: Sun, 25 Jul 2021 22:23:26 +0300 Message-Id: <834kciw635.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <408C22B8-4A9D-409F-8610-1AE86294FC20@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Sun, 25 Jul 2021 20:54:47 +0200) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> <87czr6zyid.fsf@gnus.org> <83y29uwy6d.fsf@gnu.org> <1E39DC01-B819-4D0C-AA21-CC43BDF7D5E6@acm.org> <83wnpewr4c.fsf@gnu.org> <83czr6we8z.fsf@gnu.org> <408C22B8-4A9D-409F-8610-1AE86294FC20@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39121 Cc: larsi@gnus.org, tino.calancha@gmail.com, 39121@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Sun, 25 Jul 2021 20:54:47 +0200 > Cc: larsi@gnus.org, juri@linkov.net, 39121@debbugs.gnu.org, > tino.calancha@gmail.com > > 25 juli 2021 kl. 18.27 skrev Eli Zaretskii : > > > The NEWS file doesn't necessarily describe only stuff documented > > somewhere, it also describes changes that aren't documented anywhere > > but the source code. > > Yes, but then it's always something that affects the user in some way, isn't it? "User" in this case includes Lisp programmers; there's the "Lisp changes" section in NEWS for that reason. > Mentioning changed internals doesn't seem to be standard practice, but I could be wrong about that. Text properties are not internals, they are visible to any Lisp program and to the user. > Would you point out a few examples of where we described changed aspects of undocumented implementation details in NEWS? That would support your view and help me understand it better. Sorry, no, I won't. I think this aspect of the change should be in NEWS, and I'm asking you to document it there. I don't understand why I'm required to go to such lengths to justify a simple request. If you are still not convinced, I will do it myself, because this endless dispute about a couple of sentences in NEWS is more than I can afford. > The question is also whether it should be documented at all. I think it should, and have said so. > > Since you introduced the new format, you probably thought it to be > > better than the existing one, right? Then telling others about that > > would be a good service, IMO. > > The change was made exclusively for improving Occur itself, and the external packages that I have seen would generally draw little advantage from doing anything differently. Of course, I haven't seen them all, but having other people depending on implementation details of your software is a maintenance burden which either impedes progress. Please leave the final judgment about that to me. I understand your point and your doubts, but I still think we should document this aspect of the change in NEWS. I hope this is enough to convince you. TIA From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 15:30:30 2021 Received: (at 39121) by debbugs.gnu.org; 25 Jul 2021 19:30:30 +0000 Received: from localhost ([127.0.0.1]:49420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7jpV-0004w2-VV for submit@debbugs.gnu.org; Sun, 25 Jul 2021 15:30:30 -0400 Received: from mail213c50.megamailservers.eu ([91.136.10.223]:52156 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7jpQ-0004vg-OZ for 39121@debbugs.gnu.org; Sun, 25 Jul 2021 15:30:27 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1627241417; bh=NlmcEAxWcFbjDFRlQ088k7C7HLtVEMt8Zui1c8+PwdQ=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=iUCv8TRg/s6hJk3iSEpqAsodZgbGYZWGLjISqU0Z8v3C1DesOlJQObH27fX49Q6g8 sN5T0+K7rz8m6w3s/MzX+g3zAUiLIIxCFAFu8Y83uzk6O9phkTYTRpFi0Mtlf+mlES MtuCBriZ+ezE8eKzFhevf4pqALAcx6OJZRu5ZnBQ= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16PJUEdA005416; Sun, 25 Jul 2021 19:30:16 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <834kciw635.fsf@gnu.org> Date: Sun, 25 Jul 2021 21:30:14 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> <87czr6zyid.fsf@gnus.org> <83y29uwy6d.fsf@gnu.org> <1E39DC01-B819-4D0C-AA21-CC43BDF7D5E6@acm.org> <83wnpewr4c.fsf@gnu.org> <83czr6we8z.fsf@gnu.org> <408C22B8-4A9D-409F-8610-1AE86294FC20@acm.org> <834kciw635.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F15.60FDBBC9.0029, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=QJQWuTDL c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=MGiMBSkBuvhQxVcDV_wA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 39121 Cc: larsi@gnus.org, tino.calancha@gmail.com, 39121@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 25 juli 2021 kl. 21.23 skrev Eli Zaretskii : > Text properties are not internals, they are visible to any Lisp > program and to the user. No, that can be said for just about anything in Lisp. That doesn't mean = there are no internal implementation details. > I think this aspect of the change should be in > NEWS, and I'm asking you to document it there. Certainly, I'll do it right away. Given the apparent lack of precedence = it wasn't clear how best to describe it, but I suppose there is a first = time for anything. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 26 08:44:16 2021 Received: (at 39121) by debbugs.gnu.org; 26 Jul 2021 12:44:16 +0000 Received: from localhost ([127.0.0.1]:50120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7zxv-000278-DT for submit@debbugs.gnu.org; Mon, 26 Jul 2021 08:44:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7zxg-000267-6O for 39121@debbugs.gnu.org; Mon, 26 Jul 2021 08:44:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40204) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7zxa-0007oW-Dq; Mon, 26 Jul 2021 08:43:54 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3966 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7zxY-00064F-CP; Mon, 26 Jul 2021 08:43:54 -0400 Date: Mon, 26 Jul 2021 15:43:42 +0300 Message-Id: <8335s1w8ht.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Sun, 25 Jul 2021 21:30:14 +0200) Subject: Re: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select References: <87r1fzi7c3.fsf@mail.linkov.net> <871r7pazx1.fsf@gnus.org> <87wnpg2au7.fsf@gnus.org> <87czr6zyid.fsf@gnus.org> <83y29uwy6d.fsf@gnu.org> <1E39DC01-B819-4D0C-AA21-CC43BDF7D5E6@acm.org> <83wnpewr4c.fsf@gnu.org> <83czr6we8z.fsf@gnu.org> <408C22B8-4A9D-409F-8610-1AE86294FC20@acm.org> <834kciw635.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39121 Cc: larsi@gnus.org, tino.calancha@gmail.com, 39121@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Feedback-ID:mattiase@acm.or > From: Mattias Engdegård > Date: Sun, 25 Jul 2021 21:30:14 +0200 > Cc: larsi@gnus.org, juri@linkov.net, 39121@debbugs.gnu.org, > tino.calancha@gmail.com > > 25 juli 2021 kl. 21.23 skrev Eli Zaretskii : > > > I think this aspect of the change should be in > > NEWS, and I'm asking you to document it there. > > Certainly, I'll do it right away. Thank you. From unknown Wed Jun 18 23:05:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 24 Aug 2021 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator