Subject: Re: [bug#39108] [PATCH] gnu: Add gst-editing-services.

From: Marius Bakke <[email-masked]>
Date: Mon, 13 Jan 2020 23:48:18 +0100

Leo Prikler <[email-masked]> writes:

> * gnu/packages/gstreamer (gst-editing-services): New variable.

Thanks!

[...]
  
> +(define-public gst-editing-services
> +  (package
> +    (name "gst-editing-services")
> +    (version "1.16.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://gstreamer.freedesktop.org/src/" name "/"
> +                    "gstreamer-editing-services-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "05hcf3prna8ajjnqd53221gj9syarrrjbgvjcbhicv0c38csc1hf"))))
> +    (build-system gnu-build-system)

IIRC gstreamer will no longer support gnu-build-system starting with
1.18.  So let's just go straight for Meson here, WDYT?

If you're up for it, it would be good to change the other gstreamer
packages already as well, to make the transition easier.

> +    (arguments
> +     ;; TODO: 16/22 failing tests with meson, 21 with gnu
> +     `(#:tests? #f))

When so many tests are failing, it is typically a sign that a dependency
or file is missing, e.g. execve("/bin/sh" ...) somewhere.  Can you try
to figure out what is causing these failures?

Otherwise LGTM, thanks!