From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 12 07:25:30 2020 Received: (at submit) by debbugs.gnu.org; 12 Jan 2020 12:25:30 +0000 Received: from localhost ([127.0.0.1]:57091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqcJ7-000400-LO for submit@debbugs.gnu.org; Sun, 12 Jan 2020 07:25:30 -0500 Received: from lists.gnu.org ([209.51.188.17]:54424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqcJ6-0003zs-75 for submit@debbugs.gnu.org; Sun, 12 Jan 2020 07:25:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43905) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqcJ3-0007jm-1t for guix-patches@gnu.org; Sun, 12 Jan 2020 07:25:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iqcJ0-0001bq-BB for guix-patches@gnu.org; Sun, 12 Jan 2020 07:25:24 -0500 Received: from araneo.si ([90.157.193.204]:45476) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iqcIz-0001NW-NO for guix-patches@gnu.org; Sun, 12 Jan 2020 07:25:22 -0500 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id 8b43dd1a for ; Sun, 12 Jan 2020 12:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=20180623; bh=U0F5vdudJkMfgpxWKCQ72 MwuB/Y=; b=b6oTiq3571nC8cSr+sVY2Ir5fiz6oAOfs0pLPjLmd56s9/22rAbj/ BO7iVoGtPC10vGKx7r/cR4qbRo8V8f16MMjHzUu/xw87tyo38tqMDZW0jeum9mJ5 1fTRWSFRFJLE1rc4WdrOOKO4MwzAt4LvD/OPrIyo5iMyWZvvt2ZGkf7h+Pvgqn2M JD0LD71a5FyUwFKou2aIkFm0MVhWdPE2jCWslJ9jHzNedYkZ3b8YIKXAP7gGOcUu y2WSIK5NvGh9sPeU7DuNhuGZewjcMEzub+y79Hl8c2QV5kpfZXbgb02JzqtFszec j8OrZQa60tlNWyPx31NorJ7TBmBnDHSMw== Received: by araneo.si (OpenSMTPD) with ESMTPSA id 2efda734 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 12 Jan 2020 12:25:17 +0000 (UTC) From: Timotej Lazar To: guix-patches@gnu.org Subject: [PATCH] gnu: bitlbee: Update to 3.6. Date: Sun, 12 Jan 2020 13:24:58 +0100 Message-Id: <20200112122458.7287-1-timotej.lazar@araneo.si> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 90.157.193.204 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Timotej Lazar X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/messaging.scm (bitlbee): Update to 3.6. [source]: Add patch from master to fix test failures with libcheck≥0.13. * gnu/packages/patches/bitlbee-fix-tests.patch: New file. --- gnu/packages/messaging.scm | 5 +- gnu/packages/patches/bitlbee-fix-tests.patch | 665 +++++++++++++++++++ 2 files changed, 668 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/bitlbee-fix-tests.patch diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index b524388853..cdd63c9048 100644 --- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -173,13 +173,14 @@ end-to-end encryption.") (define-public bitlbee (package (name "bitlbee") - (version "3.5.1") + (version "3.6") (source (origin (method url-fetch) (uri (string-append "https://get.bitlbee.org/src/bitlbee-" version ".tar.gz")) (sha256 - (base32 "0sgsn0fv41rga46mih3fyv65cvfa6rvki8x92dn7bczbi7yxfdln")))) + (base32 "0zhhcbcr59sx9h4maf8zamzv2waya7sbsl7w74gbyilvy93dw5cz")) + (patches (search-patches "bitlbee-fix-tests.patch")))) (build-system gnu-build-system) (native-inputs `(("pkg-config" ,pkg-config) ("check" ,check))) diff --git a/gnu/packages/patches/bitlbee-fix-tests.patch b/gnu/packages/patches/bitlbee-fix-tests.patch new file mode 100644 index 0000000000..7bab4554e3 --- /dev/null +++ b/gnu/packages/patches/bitlbee-fix-tests.patch @@ -0,0 +1,665 @@ +From 6ff651b3ec93e5fd74f80766d5e9714d963137bc Mon Sep 17 00:00:00 2001 +From: Dima +Date: Tue, 19 Nov 2019 13:51:39 +0100 +Subject: [PATCH] Fixing tests for libcheck 0.13.0 + +Since libcheck 0.13 it's mandatory to wrap the unit-test code +in a block. This updates the tests to comply with this. + +This fix is backwards compatible with libcheck 0.12. +--- + tests/check_arc.c | 6 +- + tests/check_help.c | 24 +++--- + tests/check_irc.c | 60 +++++++------- + tests/check_jabber_sasl.c | 3 +- + tests/check_jabber_util.c | 9 ++- + tests/check_md5.c | 3 +- + tests/check_set.c | 136 +++++++++++++++++++------------- + tests/check_util.c | 159 +++++++++++++++++++++----------------- + 8 files changed, 229 insertions(+), 171 deletions(-) + +diff --git a/tests/check_arc.c b/tests/check_arc.c +index 9fcd4b25..c7e1dfef 100644 +--- a/tests/check_arc.c ++++ b/tests/check_arc.c +@@ -17,7 +17,7 @@ char *clear_tests[] = + NULL + }; + +-static void check_codec(int l) ++START_TEST(check_codec) + { + int i; + +@@ -37,6 +37,7 @@ static void check_codec(int l) + g_free(decrypted); + } + } ++END_TEST + + struct { + unsigned char crypted[30]; +@@ -72,7 +73,7 @@ struct { + { "", 0, NULL } + }; + +-static void check_decod(int l) ++START_TEST(check_decod) + { + int i; + +@@ -92,6 +93,7 @@ static void check_decod(int l) + g_free(decrypted); + } + } ++END_TEST + + Suite *arc_suite(void) + { +diff --git a/tests/check_help.c b/tests/check_help.c +index 92d7c28f..ccf136a4 100644 +--- a/tests/check_help.c ++++ b/tests/check_help.c +@@ -7,20 +7,24 @@ + #include "help.h" + + START_TEST(test_help_initfree) +-help_t * h, *r; +-r = help_init(&h, "/dev/null"); +-fail_if(r == NULL); +-fail_if(r != h); ++{ ++ help_t * h, *r; ++ r = help_init(&h, "/dev/null"); ++ fail_if(r == NULL); ++ fail_if(r != h); + +-help_free(&h); +-fail_if(h != NULL); ++ help_free(&h); ++ fail_if(h != NULL); ++} + END_TEST + + START_TEST(test_help_nonexistent) +-help_t * h, *r; +-r = help_init(&h, "/dev/null"); +-fail_unless(help_get(&h, "nonexistent") == NULL); +-fail_if(r == NULL); ++{ ++ help_t * h, *r; ++ r = help_init(&h, "/dev/null"); ++ fail_unless(help_get(&h, "nonexistent") == NULL); ++ fail_if(r == NULL); ++} + END_TEST + + Suite *help_suite(void) +diff --git a/tests/check_irc.c b/tests/check_irc.c +index 5c940729..e2054106 100644 +--- a/tests/check_irc.c ++++ b/tests/check_irc.c +@@ -8,49 +8,53 @@ + #include "testsuite.h" + + START_TEST(test_connect) +-GIOChannel * ch1, *ch2; +-irc_t *irc; +-char *raw; +-fail_unless(g_io_channel_pair(&ch1, &ch2)); ++{ ++ GIOChannel * ch1, *ch2; ++ irc_t *irc; ++ char *raw; ++ fail_unless(g_io_channel_pair(&ch1, &ch2)); + +-irc = irc_new(g_io_channel_unix_get_fd(ch1)); ++ irc = irc_new(g_io_channel_unix_get_fd(ch1)); + +-irc_free(irc); ++ irc_free(irc); + +-fail_unless(g_io_channel_read_to_end(ch2, &raw, NULL, NULL) == G_IO_STATUS_NORMAL); ++ fail_unless(g_io_channel_read_to_end(ch2, &raw, NULL, NULL) == G_IO_STATUS_NORMAL); + +-fail_if(strcmp(raw, "") != 0); ++ fail_if(strcmp(raw, "") != 0); + +-g_free(raw); ++ g_free(raw); ++} + END_TEST + + START_TEST(test_login) +-GIOChannel * ch1, *ch2; +-irc_t *irc; +-char *raw; +-fail_unless(g_io_channel_pair(&ch1, &ch2)); ++{ ++ GIOChannel * ch1, *ch2; ++ irc_t *irc; ++ char *raw; ++ fail_unless(g_io_channel_pair(&ch1, &ch2)); + +-g_io_channel_set_flags(ch1, G_IO_FLAG_NONBLOCK, NULL); +-g_io_channel_set_flags(ch2, G_IO_FLAG_NONBLOCK, NULL); ++ g_io_channel_set_flags(ch1, G_IO_FLAG_NONBLOCK, NULL); ++ g_io_channel_set_flags(ch2, G_IO_FLAG_NONBLOCK, NULL); + +-irc = irc_new(g_io_channel_unix_get_fd(ch1)); ++ irc = irc_new(g_io_channel_unix_get_fd(ch1)); + +-fail_unless(g_io_channel_write_chars(ch2, "NICK bla\r\r\n" +- "USER a a a a\n", -1, NULL, NULL) == G_IO_STATUS_NORMAL); +-fail_unless(g_io_channel_flush(ch2, NULL) == G_IO_STATUS_NORMAL); ++ fail_unless(g_io_channel_write_chars(ch2, "NICK bla\r\r\n" ++ "USER a a a a\n", -1, NULL, NULL) == G_IO_STATUS_NORMAL); ++ fail_unless(g_io_channel_flush(ch2, NULL) == G_IO_STATUS_NORMAL); + +-g_main_iteration(FALSE); +-irc_free(irc); ++ g_main_iteration(FALSE); ++ irc_free(irc); + +-fail_unless(g_io_channel_read_to_end(ch2, &raw, NULL, NULL) == G_IO_STATUS_NORMAL); ++ fail_unless(g_io_channel_read_to_end(ch2, &raw, NULL, NULL) == G_IO_STATUS_NORMAL); + +-fail_unless(strstr(raw, "001") != NULL); +-fail_unless(strstr(raw, "002") != NULL); +-fail_unless(strstr(raw, "003") != NULL); +-fail_unless(strstr(raw, "004") != NULL); +-fail_unless(strstr(raw, "005") != NULL); ++ fail_unless(strstr(raw, "001") != NULL); ++ fail_unless(strstr(raw, "002") != NULL); ++ fail_unless(strstr(raw, "003") != NULL); ++ fail_unless(strstr(raw, "004") != NULL); ++ fail_unless(strstr(raw, "005") != NULL); + +-g_free(raw); ++ g_free(raw); ++} + END_TEST + + Suite *irc_suite(void) +diff --git a/tests/check_jabber_sasl.c b/tests/check_jabber_sasl.c +index e7ea8a75..b6c34bb8 100644 +--- a/tests/check_jabber_sasl.c ++++ b/tests/check_jabber_sasl.c +@@ -77,7 +77,7 @@ struct { + { NULL, NULL, NULL } + }; + +-static void check_get_part(int l) ++START_TEST(check_get_part) + { + int i; + +@@ -103,6 +103,7 @@ static void check_get_part(int l) + g_free(res); + } + } ++END_TEST + + Suite *jabber_sasl_suite(void) + { +diff --git a/tests/check_jabber_util.c b/tests/check_jabber_util.c +index e4d4533a..411f58b1 100644 +--- a/tests/check_jabber_util.c ++++ b/tests/check_jabber_util.c +@@ -8,7 +8,7 @@ + + static struct im_connection *ic; + +-static void check_buddy_add(int l) ++START_TEST(check_buddy_add) + { + struct jabber_buddy *budw1, *budw2, *budw3, *budn, *bud; + +@@ -93,8 +93,9 @@ static void check_buddy_add(int l) + fail_unless(jabber_buddy_remove(ic, "bugtest@google.com/B")); + fail_unless(jabber_buddy_remove(ic, "bugtest@google.com/C")); + } ++END_TEST + +-static void check_compareJID(int l) ++START_TEST(check_compareJID) + { + fail_unless(jabber_compare_jid("bugtest@google.com/B", "bugtest@google.com/A")); + fail_if(jabber_compare_jid("bugtest1@google.com/B", "bugtest@google.com/A")); +@@ -105,8 +106,9 @@ static void check_compareJID(int l) + fail_if(jabber_compare_jid(NULL, "")); + fail_if(jabber_compare_jid("", NULL)); + } ++END_TEST + +-static void check_hipchat_slug(int l) ++START_TEST(check_hipchat_slug) + { + int i; + +@@ -124,6 +126,7 @@ static void check_hipchat_slug(int l) + g_free(new); + } + } ++END_TEST + + Suite *jabber_util_suite(void) + { +diff --git a/tests/check_md5.c b/tests/check_md5.c +index a68df687..5ca52a5b 100644 +--- a/tests/check_md5.c ++++ b/tests/check_md5.c +@@ -29,7 +29,7 @@ struct md5_test { + { NULL }, + }; + +-static void check_sums(int l) ++START_TEST(check_sums) + { + int i; + +@@ -45,6 +45,7 @@ static void check_sums(int l) + fail_if(memcmp(tests[i].expected, sum, 16) != 0, "%s failed", tests[i].str); + } + } ++END_TEST + + Suite *md5_suite(void) + { +diff --git a/tests/check_set.c b/tests/check_set.c +index 6f8b39b5..cf9429e6 100644 +--- a/tests/check_set.c ++++ b/tests/check_set.c +@@ -7,97 +7,123 @@ + #include "testsuite.h" + + START_TEST(test_set_add) +-void *data = "data"; +-set_t *s = NULL, *t; +-t = set_add(&s, "name", "default", NULL, data); +-fail_unless(s == t); +-fail_unless(t->data == data); +-fail_unless(strcmp(t->def, "default") == 0); ++{ ++ void *data = "data"; ++ set_t *s = NULL, *t; ++ t = set_add(&s, "name", "default", NULL, data); ++ fail_unless(s == t); ++ fail_unless(t->data == data); ++ fail_unless(strcmp(t->def, "default") == 0); ++} + END_TEST + + START_TEST(test_set_add_existing) +-void *data = "data"; +-set_t *s = NULL, *t; +-t = set_add(&s, "name", "default", NULL, data); +-t = set_add(&s, "name", "newdefault", NULL, data); +-fail_unless(s == t); +-fail_unless(strcmp(t->def, "newdefault") == 0); ++{ ++ void *data = "data"; ++ set_t *s = NULL, *t; ++ t = set_add(&s, "name", "default", NULL, data); ++ t = set_add(&s, "name", "newdefault", NULL, data); ++ fail_unless(s == t); ++ fail_unless(strcmp(t->def, "newdefault") == 0); ++} + END_TEST + + START_TEST(test_set_find_unknown) +-set_t * s = NULL; +-fail_unless(set_find(&s, "foo") == NULL); ++{ ++ set_t * s = NULL; ++ fail_unless(set_find(&s, "foo") == NULL); ++} + END_TEST + + START_TEST(test_set_find) +-void *data = "data"; +-set_t *s = NULL, *t; +-t = set_add(&s, "name", "default", NULL, data); +-fail_unless(s == t); +-fail_unless(set_find(&s, "name") == t); ++{ ++ void *data = "data"; ++ set_t *s = NULL, *t; ++ t = set_add(&s, "name", "default", NULL, data); ++ fail_unless(s == t); ++ fail_unless(set_find(&s, "name") == t); ++} + END_TEST + + START_TEST(test_set_get_str_default) +-void *data = "data"; +-set_t *s = NULL, *t; +-t = set_add(&s, "name", "default", NULL, data); +-fail_unless(s == t); +-fail_unless(strcmp(set_getstr(&s, "name"), "default") == 0); ++{ ++ void *data = "data"; ++ set_t *s = NULL, *t; ++ t = set_add(&s, "name", "default", NULL, data); ++ fail_unless(s == t); ++ fail_unless(strcmp(set_getstr(&s, "name"), "default") == 0); ++} + END_TEST + + START_TEST(test_set_get_bool_default) +-void *data = "data"; +-set_t *s = NULL, *t; +-t = set_add(&s, "name", "true", NULL, data); +-fail_unless(s == t); +-fail_unless(set_getbool(&s, "name")); ++{ ++ void *data = "data"; ++ set_t *s = NULL, *t; ++ t = set_add(&s, "name", "true", NULL, data); ++ fail_unless(s == t); ++ fail_unless(set_getbool(&s, "name")); ++} + END_TEST + + START_TEST(test_set_get_bool_integer) +-void *data = "data"; +-set_t *s = NULL, *t; +-t = set_add(&s, "name", "3", NULL, data); +-fail_unless(s == t); +-fail_unless(set_getbool(&s, "name") == 3); ++{ ++ void *data = "data"; ++ set_t *s = NULL, *t; ++ t = set_add(&s, "name", "3", NULL, data); ++ fail_unless(s == t); ++ fail_unless(set_getbool(&s, "name") == 3); ++} + END_TEST + + START_TEST(test_set_get_bool_unknown) +-set_t * s = NULL; +-fail_unless(set_getbool(&s, "name") == 0); ++{ ++ set_t * s = NULL; ++ fail_unless(set_getbool(&s, "name") == 0); ++} + END_TEST + + START_TEST(test_set_get_str_value) +-void *data = "data"; +-set_t *s = NULL; +-set_add(&s, "name", "default", NULL, data); +-set_setstr(&s, "name", "foo"); +-fail_unless(strcmp(set_getstr(&s, "name"), "foo") == 0); ++{ ++ void *data = "data"; ++ set_t *s = NULL; ++ set_add(&s, "name", "default", NULL, data); ++ set_setstr(&s, "name", "foo"); ++ fail_unless(strcmp(set_getstr(&s, "name"), "foo") == 0); ++} + END_TEST + + START_TEST(test_set_get_str_unknown) +-set_t * s = NULL; +-fail_unless(set_getstr(&s, "name") == NULL); ++{ ++ set_t * s = NULL; ++ fail_unless(set_getstr(&s, "name") == NULL); ++} + END_TEST + + START_TEST(test_setint) +-void *data = "data"; +-set_t *s = NULL; +-set_add(&s, "name", "10", NULL, data); +-set_setint(&s, "name", 3); +-fail_unless(set_getint(&s, "name") == 3); ++{ ++ void *data = "data"; ++ set_t *s = NULL; ++ set_add(&s, "name", "10", NULL, data); ++ set_setint(&s, "name", 3); ++ fail_unless(set_getint(&s, "name") == 3); ++} + END_TEST + + START_TEST(test_setstr) +-void *data = "data"; +-set_t *s = NULL; +-set_add(&s, "name", "foo", NULL, data); +-set_setstr(&s, "name", "bloe"); +-fail_unless(strcmp(set_getstr(&s, "name"), "bloe") == 0); ++{ ++ void *data = "data"; ++ set_t *s = NULL; ++ set_add(&s, "name", "foo", NULL, data); ++ set_setstr(&s, "name", "bloe"); ++ fail_unless(strcmp(set_getstr(&s, "name"), "bloe") == 0); ++} + END_TEST + + START_TEST(test_set_get_int_unknown) +-set_t * s = NULL; +-fail_unless(set_getint(&s, "foo") == 0); ++{ ++ set_t * s = NULL; ++ fail_unless(set_getint(&s, "foo") == 0); ++} + END_TEST + + Suite *set_suite(void) +diff --git a/tests/check_util.c b/tests/check_util.c +index 44a223ae..2d79417e 100644 +--- a/tests/check_util.c ++++ b/tests/check_util.c +@@ -8,7 +8,8 @@ + #include "misc.h" + #include "url.h" + +-START_TEST(test_strip_linefeed){ ++START_TEST(test_strip_linefeed) ++{ + int i; + const char *get[] = { "Test", "Test\r", "Test\rX\r", NULL }; + const char *expected[] = { "Test", "Test", "TestX", NULL }; +@@ -43,63 +44,73 @@ START_TEST(test_strip_newlines) + END_TEST + + START_TEST(test_set_url_http) +-url_t url; +- +-fail_if(0 == url_set(&url, "http://host/")); +-fail_unless(!strcmp(url.host, "host")); +-fail_unless(!strcmp(url.file, "/")); +-fail_unless(!strcmp(url.user, "")); +-fail_unless(!strcmp(url.pass, "")); +-fail_unless(url.proto == PROTO_HTTP); +-fail_unless(url.port == 80); ++{ ++ url_t url; ++ ++ fail_if(0 == url_set(&url, "http://host/")); ++ fail_unless(!strcmp(url.host, "host")); ++ fail_unless(!strcmp(url.file, "/")); ++ fail_unless(!strcmp(url.user, "")); ++ fail_unless(!strcmp(url.pass, "")); ++ fail_unless(url.proto == PROTO_HTTP); ++ fail_unless(url.port == 80); ++} + END_TEST + + START_TEST(test_set_url_https) +-url_t url; +- +-fail_if(0 == url_set(&url, "https://ahost/AimeeMann")); +-fail_unless(!strcmp(url.host, "ahost")); +-fail_unless(!strcmp(url.file, "/AimeeMann")); +-fail_unless(!strcmp(url.user, "")); +-fail_unless(!strcmp(url.pass, "")); +-fail_unless(url.proto == PROTO_HTTPS); +-fail_unless(url.port == 443); ++{ ++ url_t url; ++ ++ fail_if(0 == url_set(&url, "https://ahost/AimeeMann")); ++ fail_unless(!strcmp(url.host, "ahost")); ++ fail_unless(!strcmp(url.file, "/AimeeMann")); ++ fail_unless(!strcmp(url.user, "")); ++ fail_unless(!strcmp(url.pass, "")); ++ fail_unless(url.proto == PROTO_HTTPS); ++ fail_unless(url.port == 443); ++} + END_TEST + + START_TEST(test_set_url_port) +-url_t url; +- +-fail_if(0 == url_set(&url, "https://ahost:200/Lost/In/Space")); +-fail_unless(!strcmp(url.host, "ahost")); +-fail_unless(!strcmp(url.file, "/Lost/In/Space")); +-fail_unless(!strcmp(url.user, "")); +-fail_unless(!strcmp(url.pass, "")); +-fail_unless(url.proto == PROTO_HTTPS); +-fail_unless(url.port == 200); ++{ ++ url_t url; ++ ++ fail_if(0 == url_set(&url, "https://ahost:200/Lost/In/Space")); ++ fail_unless(!strcmp(url.host, "ahost")); ++ fail_unless(!strcmp(url.file, "/Lost/In/Space")); ++ fail_unless(!strcmp(url.user, "")); ++ fail_unless(!strcmp(url.pass, "")); ++ fail_unless(url.proto == PROTO_HTTPS); ++ fail_unless(url.port == 200); ++} + END_TEST + + START_TEST(test_set_url_username) +-url_t url; +- +-fail_if(0 == url_set(&url, "socks4://user@ahost/Space")); +-fail_unless(!strcmp(url.host, "ahost")); +-fail_unless(!strcmp(url.file, "/Space")); +-fail_unless(!strcmp(url.user, "user")); +-fail_unless(!strcmp(url.pass, "")); +-fail_unless(url.proto == PROTO_SOCKS4); +-fail_unless(url.port == 1080); ++{ ++ url_t url; ++ ++ fail_if(0 == url_set(&url, "socks4://user@ahost/Space")); ++ fail_unless(!strcmp(url.host, "ahost")); ++ fail_unless(!strcmp(url.file, "/Space")); ++ fail_unless(!strcmp(url.user, "user")); ++ fail_unless(!strcmp(url.pass, "")); ++ fail_unless(url.proto == PROTO_SOCKS4); ++ fail_unless(url.port == 1080); ++} + END_TEST + + START_TEST(test_set_url_username_pwd) +-url_t url; +- +-fail_if(0 == url_set(&url, "socks5://user:pass@ahost/")); +-fail_unless(!strcmp(url.host, "ahost")); +-fail_unless(!strcmp(url.file, "/")); +-fail_unless(!strcmp(url.user, "user")); +-fail_unless(!strcmp(url.pass, "pass")); +-fail_unless(url.proto == PROTO_SOCKS5); +-fail_unless(url.port == 1080); ++{ ++ url_t url; ++ ++ fail_if(0 == url_set(&url, "socks5://user:pass@ahost/")); ++ fail_unless(!strcmp(url.host, "ahost")); ++ fail_unless(!strcmp(url.file, "/")); ++ fail_unless(!strcmp(url.user, "user")); ++ fail_unless(!strcmp(url.pass, "pass")); ++ fail_unless(url.proto == PROTO_SOCKS5); ++ fail_unless(url.port == 1080); ++} + END_TEST + + struct { +@@ -148,26 +159,30 @@ struct { + }; + + START_TEST(test_word_wrap) +-int i; ++{ ++ int i; + +-for (i = 0; word_wrap_tests[i].orig && *word_wrap_tests[i].orig; i++) { +- char *wrapped = word_wrap(word_wrap_tests[i].orig, word_wrap_tests[i].line_len); ++ for (i = 0; word_wrap_tests[i].orig && *word_wrap_tests[i].orig; i++) { ++ char *wrapped = word_wrap(word_wrap_tests[i].orig, word_wrap_tests[i].line_len); + +- fail_unless(strcmp(word_wrap_tests[i].wrapped, wrapped) == 0, +- "%s (line_len = %d) should wrap to `%s', not to `%s'", +- word_wrap_tests[i].orig, word_wrap_tests[i].line_len, +- word_wrap_tests[i].wrapped, wrapped); ++ fail_unless(strcmp(word_wrap_tests[i].wrapped, wrapped) == 0, ++ "%s (line_len = %d) should wrap to `%s', not to `%s'", ++ word_wrap_tests[i].orig, word_wrap_tests[i].line_len, ++ word_wrap_tests[i].wrapped, wrapped); + +- g_free(wrapped); ++ g_free(wrapped); ++ } + } + END_TEST + + START_TEST(test_http_encode) +-char s[80]; ++{ ++ char s[80]; + +-strcpy(s, "ee\xc3" "\xab" "ee!!..."); +-http_encode(s); +-fail_unless(strcmp(s, "ee%C3%ABee%21%21...") == 0); ++ strcpy(s, "ee\xc3" "\xab" "ee!!..."); ++ http_encode(s); ++ fail_unless(strcmp(s, "ee%C3%ABee%21%21...") == 0); ++} + END_TEST + + struct { +@@ -198,19 +213,21 @@ struct { + }; + + START_TEST(test_split_command_parts) +-int i; +-for (i = 0; split_tests[i].command; i++) { +- char *cmd = g_strdup(split_tests[i].command); +- char **split = split_command_parts(cmd, split_tests[i].limit); +- char **expected = split_tests[i].expected; +- +- int j; +- for (j = 0; split[j] && expected[j]; j++) { +- fail_unless(strcmp(split[j], expected[j]) == 0, +- "(%d) split_command_parts broken: split(\"%s\")[%d] -> %s (expected: %s)", +- i, split_tests[i].command, j, split[j], expected[j]); +- } +- g_free(cmd); ++{ ++ int i; ++ for (i = 0; split_tests[i].command; i++) { ++ char *cmd = g_strdup(split_tests[i].command); ++ char **split = split_command_parts(cmd, split_tests[i].limit); ++ char **expected = split_tests[i].expected; ++ ++ int j; ++ for (j = 0; split[j] && expected[j]; j++) { ++ fail_unless(strcmp(split[j], expected[j]) == 0, ++ "(%d) split_command_parts broken: split(\"%s\")[%d] -> %s (expected: %s)", ++ i, split_tests[i].command, j, split[j], expected[j]); ++ } ++ g_free(cmd); ++ } + } + END_TEST + +-- +2.24.1 + -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 12 15:27:22 2020 Received: (at 39096-done) by debbugs.gnu.org; 12 Jan 2020 20:27:22 +0000 Received: from localhost ([127.0.0.1]:58073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqjpS-00072o-Id for submit@debbugs.gnu.org; Sun, 12 Jan 2020 15:27:22 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:36543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqjpQ-00072V-Tu for 39096-done@debbugs.gnu.org; Sun, 12 Jan 2020 15:27:21 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 809D3220C3; Sun, 12 Jan 2020 15:27:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 12 Jan 2020 15:27:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=uWZOmBcZU3wY5OEjfdDJbBT94H p+SuUcY4YIpfXgjDQ=; b=mjLFSdlAxF4cRe4L+mB1ESJsYWT6YPGnRToJkn7IGQ tHLchL84Rap40kzSZnzl0KawWWpanAnoFpWy4LjXpX2BTxbFF+SDeXhTfDEmFvE+ l1OMlwKjT2s9VhGMW3C4EDUtkNGaG9IO2Z98YG44rrZZ/JSdAjHy4irYTT9qHFmZ s2KXRuhg9d4TLTkRWvhWk2XOJEWXNh4cHTmljctYx7be5TMHuDGeeN/8bpwGO/4o V2egwbGd9SNd8NiK7u1p3DGngrDIGTDy8rKX0C4A4wybMrRdXlV1+szrC8gkbOOW ha6JntoSwZ+hy9fF5M1QxFD5u/SH7xY5riQCDba9AlTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=uWZOmB cZU3wY5OEjfdDJbBT94Hp+SuUcY4YIpfXgjDQ=; b=LeqfYW5tARbJywIMY7c9WE ocAcEtU55YYdciAKPsk8yqGnZm4p674kSikCNmojHa4NtDT/aAAstC4ed6yGnIil 4huh9WKqB/l4jAxVlArMyd3ZMRPW/Bmu1Faj2z9nqJFZgHP+dPBZPzGkcM5Ua7Xl nzGaL96bSH6ysv2Fj26gQg8/69plDdc/D1Gp1jxuJr5Dsgob/b8Ufkty/C2m9NDT 5astKhoRF7x+Gx3fAF8qTaT6YjdXHvKbY2LPYLOo0Dkt3Dd4sW4SuOcln2B7pdTV QvFasMX6T5JIVpemJWw+WRC9AVJvT+cDVgL5jSU4Kd9rr+A8ElojYc+B1yaPcblA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdeikedgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffgffkfggtgesghdtreertderjeenucfhrhhomhepofgrrhhi uhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilhdrtghomheqnecuffhomh grihhnpehgnhhurdhorhhgnecukfhppeekgedrhedvrddvvdeirddutddvnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhmnecuvehluh hsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (84-52-226.102.3p.ntebredband.no [84.52.226.102]) by mail.messagingengine.com (Postfix) with ESMTPA id CF59E30607B0; Sun, 12 Jan 2020 15:27:14 -0500 (EST) From: Marius Bakke To: Timotej Lazar , 39096-done@debbugs.gnu.org Subject: Re: [bug#39096] [PATCH] gnu: bitlbee: Update to 3.6. In-Reply-To: <20200112122458.7287-1-timotej.lazar@araneo.si> References: <20200112122458.7287-1-timotej.lazar@araneo.si> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sun, 12 Jan 2020 21:27:12 +0100 Message-ID: <87d0boxvxb.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39096-done Cc: Timotej Lazar X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Timotej Lazar writes: > * gnu/packages/messaging.scm (bitlbee): Update to 3.6. > [source]: Add patch from master to fix test failures with libcheck=E2=89= =A50.13. > * gnu/packages/patches/bitlbee-fix-tests.patch: New file. > --- > gnu/packages/messaging.scm | 5 +- > gnu/packages/patches/bitlbee-fix-tests.patch | 665 +++++++++++++++++++ > 2 files changed, 668 insertions(+), 2 deletions(-) > create mode 100644 gnu/packages/patches/bitlbee-fix-tests.patch To avoid having to carry the 600+ line patch, I added a separate commit that builds bitlbee against check 0.12 for the time being: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D2a84b550410f4e12eec= 5fc38039ab0b8823535a6 https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3Df9ea47a978882541063= dd0d77c138be881ce0688 Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl4bgSAACgkQoqBt8qM6 VPovDQgAh1C09dQPqp9tUQDYaZcCJw9j8DfNZINZomnGvI5lfhtHlE4g2IBmwjOZ aLnlK1WS/8wQoETMqffJFxNH39yQOt4jmNqEmGRNzxrjwftE+K0VwGZTyJVoBBYL WWICq59JdpMoOuKdTRJr8s5zwPDkUzOUXsmcdR9tiiQEDzUrN4hsPiHl32ZNp3Ol imPqeIMh3ZjBud8/vk4qQd1JhT+/pa3cAwcT5N/qpq4If82hEvFUYdEtESVvVIsL ZjOx5Yeo3deBMFrVemgt6k/Qk9NfjvzCuojvKEuUmmzC44R3JTf0Y8uvXQJdmXki 7j/cVWLOjYP5MDOEMIH1xpy38tuovw== =xWRm -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Jun 13 06:15:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 10 Feb 2020 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator