From unknown Fri Jun 13 11:16:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39094: 27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Jan 2020 08:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39094 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 39094@debbugs.gnu.org, eliz@gnu.org X-Debbugs-Original-To: , "'Eli Zaretskii'" Received: via spool by submit@debbugs.gnu.org id=B.157881641423830 (code B ref -1); Sun, 12 Jan 2020 08:07:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 Jan 2020 08:06:54 +0000 Received: from localhost ([127.0.0.1]:56994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqYGr-0006CH-EW for submit@debbugs.gnu.org; Sun, 12 Jan 2020 03:06:54 -0500 Received: from lists.gnu.org ([209.51.188.17]:50540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqYGp-0006CA-Ut for submit@debbugs.gnu.org; Sun, 12 Jan 2020 03:06:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38195) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqYGo-0005sR-Uo for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2020 03:06:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iqYGn-0008Rw-IK for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2020 03:06:50 -0500 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:35503) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iqYGn-0008O3-92 for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2020 03:06:49 -0500 Received: by mail-pf1-x436.google.com with SMTP id i23so3336115pfo.2 for ; Sun, 12 Jan 2020 00:06:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zoom.us; s=google; h=from:to:references:in-reply-to:subject:date:message-id:mime-version :thread-index:content-language; bh=I7i96YX6wtYWteQznrjEmQwqAVwHdVQZy7fpT8gM48w=; b=EEBxpA4ARU9N0ZQZUmFQp6i6ggq/tpsGbk1bTcioD9dnVlwSQ8oZ4CK9ePChfzK5dH w4l6HJNDD1yqCoAZWYAvNTooeuKJIJ4WMQCNGIDUwbD801dkRnfgeiJle58xK/59IxOc vYyyJyiQar9riLZEU5RYSTIffP0XgzUWjeec4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:references:in-reply-to:subject:date :message-id:mime-version:thread-index:content-language; bh=I7i96YX6wtYWteQznrjEmQwqAVwHdVQZy7fpT8gM48w=; b=m68IesNA5Krqf2FhOmrm4tP7JSrWsTHvkbFZzUBpoFvhFwTFKSFY2OMYv+5SW1VpL3 tdcUY40WHHo3Wr70RnpvjcRQ3r2iebrUJ/61kT2nsbeveOhC5QlhfRf4KXbs01Kaz60o vUMxyqk7u0w8GU+BPg2vE1otU46LfoU71KWk3nfsnD9gVa2reeAr0rCXjfpJQtI7/UE2 v64IKww6fHhxAgT9T0CHWAu2zuL6lRqSN+2c0CNeJ7VwnrhPEfyOd4gSOh8jNPdcnEI5 b8k/eOiFETIFn6GtSxbWJqc4XoJ1+mU8bnk50Mv9wL5DVb2meCDnQT4gOwPITznB3SwP ADbA== X-Gm-Message-State: APjAAAUzSwy0IeD02mBOqAEpxE6FbhXDh85UgiF22NCPAk4a8D2du2mq 9RwyJYt7TNcstF5aZ9kPCu8A7qw5IiRsXul8T/a7cOZ/oZYFzP931rYHTifmGIdMge2bR2U1wmG /uWfRrMdtPyFnpn1QxNYMH6igo2oPMNrwCE7xb5MlcJT+KAZnR/eUw9FtKXrA X-Google-Smtp-Source: APXvYqzncRNVfmgh+rvGAvaQMvczEaJBbolxzaq7GaapG/pqj771/dpv0tU8ptq2+uYx5pCfYtRWUw== X-Received: by 2002:a63:a53:: with SMTP id z19mr14895570pgk.267.1578816407274; Sun, 12 Jan 2020 00:06:47 -0800 (PST) Received: from DESKTOP71C1N5K ([38.99.100.2]) by smtp.gmail.com with ESMTPSA id p35sm8971901pgl.47.2020.01.12.00.06.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Jan 2020 00:06:46 -0800 (PST) From: References: <5ddfcabc.1c69fb81.626d0.c7a5@mx.google.com> In-Reply-To: <5ddfcabc.1c69fb81.626d0.c7a5@mx.google.com> Date: Sun, 12 Jan 2020 16:06:43 +0800 Message-ID: <000201d5c91f$3bac3b90$b304b2b0$@zoom.us> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0003_01D5C962.49D03EE0" X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJLQUOmqDIbovY9wIUTc2SKtL4kWKb7uLeQ Content-Language: en-us X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::436 X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multipart message in MIME format. ------=_NextPart_000_0003_01D5C962.49D03EE0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Eli, The attachment is a patch to fix the complaint message from = `makefile-move-to-macro' for the param for re-search-forward isn't = escaped. To reproduce the issue, just run follow commands in your shell, $ echo 'AM_LIBTMP_LIBS:=3D$(shell X \--libs)' > /tmp/Makefile.am $ emacs -Q --eval '(progn (global-ede-mode t)(semantic-mode t)(find-file = "/tmp/Makefile.am"))' Could you please review and apply the patch?=20 Thank you. B.R. Lin Sun ------=_NextPart_000_0003_01D5C962.49D03EE0 Content-Type: application/octet-stream; name="0001-Fix-the-error-message-from-makefile-move-to-macro.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Fix-the-error-message-from-makefile-move-to-macro.patch" >From 9dfa710fd57095cceb025f665e71772f93e6bbe4 Mon Sep 17 00:00:00 2001=0A= From: "lin.sun" =0A= Date: Fri, 1 Nov 2019 10:25:17 +0800=0A= Subject: [PATCH] Fix the error message from `makefile-move-to-macro'=0A= =0A= * makefile-edit.el: regexp-quote the param in makefile-move-to-macro.=0A= With `(global-ede-mode t)' and `(semantic-mode t)' enabled, error=0A= happened when open a Makefile.am which has '$' or '\\' in its macro=0A= list. Simply create a Makefile.am include the line=0A= 'AM_LIBTMP_LIBS:=3D$(shell X \--libs)', open the file with ede and=0A= semantic mode enabled will trigger this issue. Escape the param for=0A= re-search-forward in `makefile-move-to-macro' can fix this.=0A= ---=0A= lisp/cedet/ede/makefile-edit.el | 2 +-=0A= 1 file changed, 1 insertion(+), 1 deletion(-)=0A= =0A= diff --git a/lisp/cedet/ede/makefile-edit.el = b/lisp/cedet/ede/makefile-edit.el=0A= index 7d8a44b..add1675 100644=0A= --- a/lisp/cedet/ede/makefile-edit.el=0A= +++ b/lisp/cedet/ede/makefile-edit.el=0A= @@ -78,7 +78,7 @@ makefile-move-to-macro=0A= If NEXT is non-nil, move to the next occurrence of MACRO."=0A= (let ((oldpt (point)))=0A= (when (not next) (goto-char (point-min)))=0A= - (if (re-search-forward (concat "^\\s-*" macro "\\s-*[+:?]?=3D") nil = t)=0A= + (if (re-search-forward (concat "^\\s-*" (regexp-quote macro) = "\\s-*[+:?]?=3D") nil t)=0A= t=0A= (goto-char oldpt)=0A= nil)))=0A= -- =0A= 2.2.0=0A= =0A= ------=_NextPart_000_0003_01D5C962.49D03EE0-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 12 08:58:54 2020 Received: (at control) by debbugs.gnu.org; 12 Jan 2020 13:58:54 +0000 Received: from localhost ([127.0.0.1]:57163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqdlW-0008CS-5e for submit@debbugs.gnu.org; Sun, 12 Jan 2020 08:58:54 -0500 Received: from mail-qt1-f171.google.com ([209.85.160.171]:43199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqdlV-0008CG-6a for control@debbugs.gnu.org; Sun, 12 Jan 2020 08:58:53 -0500 Received: by mail-qt1-f171.google.com with SMTP id d18so6757150qtj.10 for ; Sun, 12 Jan 2020 05:58:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=uFVHozhvp9wkD7D3ZFV5KIN+7wfv0OyjnxWvapo9JU4=; b=cNLyW3F3wEdMcu5gDPBUP4rqJZvNH3usgiXJ0aOU9xQ2TyaGuAXr/2XFCNWmr4fkJ8 PB1j4e5ZoKDuAgxYzCVxs7OXqWw0ZQRciM5ZuEogB7VdANvhJGx2NcToU6mnopKw+F11 GFHm2FXF5tr/gLtDYP/26AuFC7NA5xKZNqfVsyx4zUE4iGVYe+AiUj1qA49RT21End1Y 6q9Kup+AKi/CkXOGxlJOYBetDnZZe6lOVoHJiAoq/1TPKY1hSm9oAImLIQXs7j3kLGUw 5GSYkD1tMXeekFzMET0DsnTfr2qvrUyW4akESAQeqC69iIrnoaU23LXdRajBjyyiSFpx BhGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=uFVHozhvp9wkD7D3ZFV5KIN+7wfv0OyjnxWvapo9JU4=; b=S/kcXzEkA+11dVt+arb/CLmzluVcg8A024JMGiLU1cPzblI6vspCXbTmuzkCiRPml2 Eg0Ald5R2w2osK4aMb02u04nYDMAs8I68wXS8+XhgEWt+gy3Ovt069l2+XLE5369jTTQ dEoSmu9zOGO2I8Zfj8qoEosIRMnwe4MsOMv29PjQHiI9lnZVGcRo45QAW0cQVlL/ozec sXWjSFBceWQq15RO00MqRYIOtSI8mK6gj1POHkh0WFtzL/l93iDPnHPPKcBQH/w79xKU rj9bMloCOzq49GPpQk/d8Qy/E7XOppLsyXZjywa8FxkjSGaDH8kItQFr/MspCjMAyPET bPgQ== X-Gm-Message-State: APjAAAWoivIOeuPbRx1cx3UDwSlhcrecehZFaN/WYy5WPAE4cLgBCo1s Obfd01u80PqGTrfppveiyzFyWlSf X-Google-Smtp-Source: APXvYqyRN600Z6GpCV4zBXZbVU+bzV7m6DgVemS7eXx4nhsqguHd9hFE3UGBE5PHuj/zokBZLw5T5w== X-Received: by 2002:ac8:30f7:: with SMTP id w52mr6536202qta.380.1578837527526; Sun, 12 Jan 2020 05:58:47 -0800 (PST) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id c6sm3590576qka.111.2020.01.12.05.58.46 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 Jan 2020 05:58:47 -0800 (PST) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #38014 Date: Sun, 12 Jan 2020 08:58:46 -0500 Message-ID: <87zhesbwtl.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) # dups merge 38014 38416 39094 quit From unknown Fri Jun 13 11:16:22 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Subject: bug#39094: closed (regexp-quote the param in makefile-move-to-macro to avoid error message) Message-ID: References: <25c4e204-0465-5e7a-4183-8e5a23989b85@cs.ucla.edu> <000201d5c91f$3bac3b90$b304b2b0$@zoom.us> X-Gnu-PR-Message: they-closed 39094 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 39094@debbugs.gnu.org Date: Fri, 17 Jan 2020 00:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1579219982-7149-1" This is a multi-part message in MIME format... ------------=_1579219982-7149-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #39094: 27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in ma= kefile-move-to-macro to avoid error message which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 39094@debbugs.gnu.org. --=20 39094: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39094 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1579219982-7149-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 39094-done) by debbugs.gnu.org; 17 Jan 2020 00:12:12 +0000 Received: from localhost ([127.0.0.1]:38615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isFFE-0001qI-7W for submit@debbugs.gnu.org; Thu, 16 Jan 2020 19:12:12 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isFFC-0001q3-Ou for 39094-done@debbugs.gnu.org; Thu, 16 Jan 2020 19:12:11 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0E0B0160058; Thu, 16 Jan 2020 16:12:03 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id vL8anI8uSncY; Thu, 16 Jan 2020 16:12:02 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 13DBF160086; Thu, 16 Jan 2020 16:12:02 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id pv8Ng4obvUWR; Thu, 16 Jan 2020 16:12:01 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id ECD58160087; Thu, 16 Jan 2020 16:12:01 -0800 (PST) To: Lin Sun From: Paul Eggert Subject: regexp-quote the param in makefile-move-to-macro to avoid error message Organization: UCLA Computer Science Department Message-ID: <25c4e204-0465-5e7a-4183-8e5a23989b85@cs.ucla.edu> Date: Thu, 16 Jan 2020 16:12:01 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39094-done Cc: 39094-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thanks for reporting that bug. I installed your patch into the master branch. ------------=_1579219982-7149-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Jan 2020 08:06:54 +0000 Received: from localhost ([127.0.0.1]:56994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqYGr-0006CH-EW for submit@debbugs.gnu.org; Sun, 12 Jan 2020 03:06:54 -0500 Received: from lists.gnu.org ([209.51.188.17]:50540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqYGp-0006CA-Ut for submit@debbugs.gnu.org; Sun, 12 Jan 2020 03:06:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38195) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqYGo-0005sR-Uo for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2020 03:06:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iqYGn-0008Rw-IK for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2020 03:06:50 -0500 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:35503) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iqYGn-0008O3-92 for bug-gnu-emacs@gnu.org; Sun, 12 Jan 2020 03:06:49 -0500 Received: by mail-pf1-x436.google.com with SMTP id i23so3336115pfo.2 for ; Sun, 12 Jan 2020 00:06:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zoom.us; s=google; h=from:to:references:in-reply-to:subject:date:message-id:mime-version :thread-index:content-language; bh=I7i96YX6wtYWteQznrjEmQwqAVwHdVQZy7fpT8gM48w=; b=EEBxpA4ARU9N0ZQZUmFQp6i6ggq/tpsGbk1bTcioD9dnVlwSQ8oZ4CK9ePChfzK5dH w4l6HJNDD1yqCoAZWYAvNTooeuKJIJ4WMQCNGIDUwbD801dkRnfgeiJle58xK/59IxOc vYyyJyiQar9riLZEU5RYSTIffP0XgzUWjeec4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:references:in-reply-to:subject:date :message-id:mime-version:thread-index:content-language; bh=I7i96YX6wtYWteQznrjEmQwqAVwHdVQZy7fpT8gM48w=; b=m68IesNA5Krqf2FhOmrm4tP7JSrWsTHvkbFZzUBpoFvhFwTFKSFY2OMYv+5SW1VpL3 tdcUY40WHHo3Wr70RnpvjcRQ3r2iebrUJ/61kT2nsbeveOhC5QlhfRf4KXbs01Kaz60o vUMxyqk7u0w8GU+BPg2vE1otU46LfoU71KWk3nfsnD9gVa2reeAr0rCXjfpJQtI7/UE2 v64IKww6fHhxAgT9T0CHWAu2zuL6lRqSN+2c0CNeJ7VwnrhPEfyOd4gSOh8jNPdcnEI5 b8k/eOiFETIFn6GtSxbWJqc4XoJ1+mU8bnk50Mv9wL5DVb2meCDnQT4gOwPITznB3SwP ADbA== X-Gm-Message-State: APjAAAUzSwy0IeD02mBOqAEpxE6FbhXDh85UgiF22NCPAk4a8D2du2mq 9RwyJYt7TNcstF5aZ9kPCu8A7qw5IiRsXul8T/a7cOZ/oZYFzP931rYHTifmGIdMge2bR2U1wmG /uWfRrMdtPyFnpn1QxNYMH6igo2oPMNrwCE7xb5MlcJT+KAZnR/eUw9FtKXrA X-Google-Smtp-Source: APXvYqzncRNVfmgh+rvGAvaQMvczEaJBbolxzaq7GaapG/pqj771/dpv0tU8ptq2+uYx5pCfYtRWUw== X-Received: by 2002:a63:a53:: with SMTP id z19mr14895570pgk.267.1578816407274; Sun, 12 Jan 2020 00:06:47 -0800 (PST) Received: from DESKTOP71C1N5K ([38.99.100.2]) by smtp.gmail.com with ESMTPSA id p35sm8971901pgl.47.2020.01.12.00.06.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Jan 2020 00:06:46 -0800 (PST) From: To: , "'Eli Zaretskii'" References: <5ddfcabc.1c69fb81.626d0.c7a5@mx.google.com> In-Reply-To: <5ddfcabc.1c69fb81.626d0.c7a5@mx.google.com> Subject: 27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message Date: Sun, 12 Jan 2020 16:06:43 +0800 Message-ID: <000201d5c91f$3bac3b90$b304b2b0$@zoom.us> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0003_01D5C962.49D03EE0" X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJLQUOmqDIbovY9wIUTc2SKtL4kWKb7uLeQ Content-Language: en-us X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::436 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multipart message in MIME format. ------=_NextPart_000_0003_01D5C962.49D03EE0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Eli, The attachment is a patch to fix the complaint message from = `makefile-move-to-macro' for the param for re-search-forward isn't = escaped. To reproduce the issue, just run follow commands in your shell, $ echo 'AM_LIBTMP_LIBS:=3D$(shell X \--libs)' > /tmp/Makefile.am $ emacs -Q --eval '(progn (global-ede-mode t)(semantic-mode t)(find-file = "/tmp/Makefile.am"))' Could you please review and apply the patch?=20 Thank you. B.R. Lin Sun ------=_NextPart_000_0003_01D5C962.49D03EE0 Content-Type: application/octet-stream; name="0001-Fix-the-error-message-from-makefile-move-to-macro.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Fix-the-error-message-from-makefile-move-to-macro.patch" >From 9dfa710fd57095cceb025f665e71772f93e6bbe4 Mon Sep 17 00:00:00 2001=0A= From: "lin.sun" =0A= Date: Fri, 1 Nov 2019 10:25:17 +0800=0A= Subject: [PATCH] Fix the error message from `makefile-move-to-macro'=0A= =0A= * makefile-edit.el: regexp-quote the param in makefile-move-to-macro.=0A= With `(global-ede-mode t)' and `(semantic-mode t)' enabled, error=0A= happened when open a Makefile.am which has '$' or '\\' in its macro=0A= list. Simply create a Makefile.am include the line=0A= 'AM_LIBTMP_LIBS:=3D$(shell X \--libs)', open the file with ede and=0A= semantic mode enabled will trigger this issue. Escape the param for=0A= re-search-forward in `makefile-move-to-macro' can fix this.=0A= ---=0A= lisp/cedet/ede/makefile-edit.el | 2 +-=0A= 1 file changed, 1 insertion(+), 1 deletion(-)=0A= =0A= diff --git a/lisp/cedet/ede/makefile-edit.el = b/lisp/cedet/ede/makefile-edit.el=0A= index 7d8a44b..add1675 100644=0A= --- a/lisp/cedet/ede/makefile-edit.el=0A= +++ b/lisp/cedet/ede/makefile-edit.el=0A= @@ -78,7 +78,7 @@ makefile-move-to-macro=0A= If NEXT is non-nil, move to the next occurrence of MACRO."=0A= (let ((oldpt (point)))=0A= (when (not next) (goto-char (point-min)))=0A= - (if (re-search-forward (concat "^\\s-*" macro "\\s-*[+:?]?=3D") nil = t)=0A= + (if (re-search-forward (concat "^\\s-*" (regexp-quote macro) = "\\s-*[+:?]?=3D") nil t)=0A= t=0A= (goto-char oldpt)=0A= nil)))=0A= -- =0A= 2.2.0=0A= =0A= ------=_NextPart_000_0003_01D5C962.49D03EE0-- ------------=_1579219982-7149-1-- From unknown Fri Jun 13 11:16:22 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Subject: bug#38014: closed (regexp-quote the param in makefile-move-to-macro to avoid error message) Message-ID: References: <25c4e204-0465-5e7a-4183-8e5a23989b85@cs.ucla.edu> <001001d59060$6b8f6f00$42ae4d00$@zoom.us> X-Gnu-PR-Message: they-closed 38014 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 38014@debbugs.gnu.org Date: Fri, 17 Jan 2020 00:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1579219982-7149-3" This is a multi-part message in MIME format... ------------=_1579219982-7149-3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #39094: 26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in make= file-move-to-macro to avoid error message which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 38014@debbugs.gnu.org. --=20 39094: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39094 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1579219982-7149-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 39094-done) by debbugs.gnu.org; 17 Jan 2020 00:12:12 +0000 Received: from localhost ([127.0.0.1]:38615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isFFE-0001qI-7W for submit@debbugs.gnu.org; Thu, 16 Jan 2020 19:12:12 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isFFC-0001q3-Ou for 39094-done@debbugs.gnu.org; Thu, 16 Jan 2020 19:12:11 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0E0B0160058; Thu, 16 Jan 2020 16:12:03 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id vL8anI8uSncY; Thu, 16 Jan 2020 16:12:02 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 13DBF160086; Thu, 16 Jan 2020 16:12:02 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id pv8Ng4obvUWR; Thu, 16 Jan 2020 16:12:01 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id ECD58160087; Thu, 16 Jan 2020 16:12:01 -0800 (PST) To: Lin Sun From: Paul Eggert Subject: regexp-quote the param in makefile-move-to-macro to avoid error message Organization: UCLA Computer Science Department Message-ID: <25c4e204-0465-5e7a-4183-8e5a23989b85@cs.ucla.edu> Date: Thu, 16 Jan 2020 16:12:01 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39094-done Cc: 39094-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thanks for reporting that bug. I installed your patch into the master branch. ------------=_1579219982-7149-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Nov 2019 03:13:05 +0000 Received: from localhost ([127.0.0.1]:54882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQNN2-0005u5-E6 for submit@debbugs.gnu.org; Thu, 31 Oct 2019 23:13:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:38429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQNAJ-0005ZQ-U4 for submit@debbugs.gnu.org; Thu, 31 Oct 2019 22:59:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58850) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQNAI-0000sf-OV for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 22:59:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQNAH-0006Ns-D5 for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 22:59:54 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:45463) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQNAH-0006Dg-4Z for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 22:59:53 -0400 Received: by mail-pf1-x42d.google.com with SMTP id c7so5971316pfo.12 for ; Thu, 31 Oct 2019 19:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zoom.us; s=google; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding:thread-index:content-language; bh=ioi+3JPiSxE7D149Z9M2d4LF3uT4HeKV1e4DkH14q+s=; b=K+EtidbLjLa2apKKL5LS90MLe2ewrtzc+9YMA7YARJeUckFWLRVfQo5zkJJ+q7Rrwj gNzJvF5EPPdduIzPdZmXQCNKoBT93edLt9hgD+Ye+c1mVh8FoHbbrKaR4viD5B1+0ovy 7GSe15sDOFcB95Sy0XgnBWOgIFJEsXiV71SNM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding:thread-index:content-language; bh=ioi+3JPiSxE7D149Z9M2d4LF3uT4HeKV1e4DkH14q+s=; b=C6YtAdDrus5nJ4KCxZ6Zg308aLXUZqVzHIHt3PMjsXoFM6O2D6tCqu7YxzSdLtlD/5 aRTWb/1159dW+77p0XW1CVU62fIiGhocRVWlmAkwyVahfzZUAzFKzS62EJv0ykJAj4yt 41L4YRW0RmsQTP4NWhhWPHGgOJOiU3i5Y/xbxBIgldEHkkSiNlRygK7YR2PN69iNoP7m frYX4eewDQ6EYSoJysfbVXov4pXKfZCXHqA9OhgJtskFnRlAJ7jYzedBzQRrgJb36X+b hS3qmlwhIVLbNcedjhuIIofXzOZqu4J8GMXI+mcbVhQeeX7fqze++qeS9eCQP/c0O9S6 vH9g== X-Gm-Message-State: APjAAAWSzbJAytpSzRgtOVZynR0yEAWTGPJadPMTCl70IoTjXWPZuJP9 ppUVW3AI8e/7xqig2Lakry/eZNjdTjO6KYsyCoWE7X5ACj/exD5/OMPvdiKQq1roJwd1jB0cPMF wupBcwbJ/RW5anhlhk99W2m1Ez8jPRH/7HHiBIKi2MtdqD1J3hUFL+/AeYJGW X-Google-Smtp-Source: APXvYqxyPsxqGDOsVy6Pa67F1oDTSfmuvUwA90qm6lLhBRpEb2wEh4byd5MCNU7oS7FfRVdRiJ7GMA== X-Received: by 2002:a65:6085:: with SMTP id t5mr10710318pgu.450.1572577188532; Thu, 31 Oct 2019 19:59:48 -0700 (PDT) Received: from DESKTOP71C1N5K ([38.99.100.2]) by smtp.gmail.com with ESMTPSA id b3sm4165117pfd.125.2019.10.31.19.59.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Oct 2019 19:59:47 -0700 (PDT) From: To: Subject: 26.3.50; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message Date: Fri, 1 Nov 2019 10:59:44 +0800 Message-ID: <001001d59060$6b8f6f00$42ae4d00$@zoom.us> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AdWQYGfPPA5S9ipETzWH8oLyghe9sw== Content-Language: en-us X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::42d X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 31 Oct 2019 23:13:03 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro. Fix the error message from `makefile-move-to-macro' when there is '$' or '\\' in param for re-search-forward, with `(global-ede-mode t)' and `(semantic-mode t)'. Enable ede and semantic mode, then open a Makefile.am in which has line 'AM_LIBTMP_LIBS:=$(shell X \--libs)' will trigger this issue. --- lisp/cedet/ede/makefile-edit.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/cedet/ede/makefile-edit.el b/lisp/cedet/ede/makefile-edit.el index 7d8a44b..add1675 100644 --- a/lisp/cedet/ede/makefile-edit.el +++ b/lisp/cedet/ede/makefile-edit.el @@ -78,7 +78,7 @@ makefile-move-to-macro If NEXT is non-nil, move to the next occurrence of MACRO." (let ((oldpt (point))) (when (not next) (goto-char (point-min))) - (if (re-search-forward (concat "^\\s-*" macro "\\s-*[+:?]?=") nil t) + (if (re-search-forward (concat "^\\s-*" (regexp-quote macro) "\\s-*[+:?]?=") nil t) t (goto-char oldpt) nil))) -- 2.2.0 ------------=_1579219982-7149-3-- From unknown Fri Jun 13 11:16:22 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: LinSun Subject: bug#38416: closed (regexp-quote the param in makefile-move-to-macro to avoid error message) Message-ID: References: <25c4e204-0465-5e7a-4183-8e5a23989b85@cs.ucla.edu> <5ddfcabc.1c69fb81.626d0.c7a5@mx.google.com> X-Gnu-PR-Message: they-closed 38416 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 38416@debbugs.gnu.org Date: Fri, 17 Jan 2020 00:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1579219982-7149-5" This is a multi-part message in MIME format... ------------=_1579219982-7149-5 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #39094: 27.0.50;; [PATCH] * makefile-edit.el: regexp-quote the param in mak= efile-move-to-macro to avoid error message which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 38416@debbugs.gnu.org. --=20 39094: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39094 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1579219982-7149-5 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 39094-done) by debbugs.gnu.org; 17 Jan 2020 00:12:12 +0000 Received: from localhost ([127.0.0.1]:38615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isFFE-0001qI-7W for submit@debbugs.gnu.org; Thu, 16 Jan 2020 19:12:12 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isFFC-0001q3-Ou for 39094-done@debbugs.gnu.org; Thu, 16 Jan 2020 19:12:11 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0E0B0160058; Thu, 16 Jan 2020 16:12:03 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id vL8anI8uSncY; Thu, 16 Jan 2020 16:12:02 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 13DBF160086; Thu, 16 Jan 2020 16:12:02 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id pv8Ng4obvUWR; Thu, 16 Jan 2020 16:12:01 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id ECD58160087; Thu, 16 Jan 2020 16:12:01 -0800 (PST) To: Lin Sun From: Paul Eggert Subject: regexp-quote the param in makefile-move-to-macro to avoid error message Organization: UCLA Computer Science Department Message-ID: <25c4e204-0465-5e7a-4183-8e5a23989b85@cs.ucla.edu> Date: Thu, 16 Jan 2020 16:12:01 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39094-done Cc: 39094-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thanks for reporting that bug. I installed your patch into the master branch. ------------=_1579219982-7149-5 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Nov 2019 16:36:45 +0000 Received: from localhost ([127.0.0.1]:59054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaMmb-0005sm-8M for submit@debbugs.gnu.org; Thu, 28 Nov 2019 11:36:45 -0500 Received: from lists.gnu.org ([209.51.188.17]:53277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaJxK-00010b-IQ for submit@debbugs.gnu.org; Thu, 28 Nov 2019 08:35:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59564) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaJxG-0006R8-EO for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 08:35:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.9 required=5.0 tests=BAYES_50,HTML_MESSAGE, MIME_HTML_ONLY,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iaJnP-0003sP-5X for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 08:25:26 -0500 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]:38683) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iaJnO-0003WF-S1 for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 08:25:23 -0500 Received: by mail-pg1-x531.google.com with SMTP id t3so12480251pgl.5 for ; Thu, 28 Nov 2019 05:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zoom.us; s=google; h=message-id:mime-version:date:from:subject:thread-topic:to :content-transfer-encoding; bh=2P5fyAi6Es7xc6b6D5hBZjYabxDlFInZfirP94Dxnl0=; b=chj/A85MQZTJPBx2v1VKO1yYqnY+AGg6ZLWqM0wj+MWzUMaoL7Zk821vPrIRUyk2jg +FqahCvOwvuq/QHyI46nQGmpn87nf/d7Sm8ylHmUnMmiMdtMHehoPGJscmw30HT/SMPh T9CPgq3bqylOIYpb1bjj8OBnu5/s/4rdAHy8M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version:date:from:subject :thread-topic:to:content-transfer-encoding; bh=2P5fyAi6Es7xc6b6D5hBZjYabxDlFInZfirP94Dxnl0=; b=hz9ntN7GB9OchXfGM8foKUPJSddxwTmEeCkzpEXtuzAUp7iGL8uSIrzIfJFrt3QRla j28JGxh5mTt8rwwnlK1VKhF8slzrn5SDmVhaj2bUKjZWiZVGVPPKi6CdwvCPQyEZx6Wk kS6dmyOz6H/H8vHXrSEJmIuQpClvlTfbYsnOzCvQrK3hqV6Urbm4tLlPlevahBf51SiO Rbdpj1/T1gh0X2T0LsuCU7XDbstacwNwTWVLuoQGb8iTG4VIsv2UFSfcFlG7/Rk2+YfY em6frwxnrGVfmumu3a4QXYR48j0WP40INyarkdfMiTs3BAYVccAyWTtIYkubGcemkcrf YYaQ== X-Gm-Message-State: APjAAAW2770iZj3R9In9fhbmvSEvKLLH4zdvGXU28HYa/e8Xtw4747L+ PZ+A5HbSWQpoDxkyRWBvbSIr7HoNQWH/vP4bSMwuKjGOdrNmFqH0fMINie8zkg/XUWSXsf2aXEP 6bchcJ3cOE9dmQmYD48ov+JkkHLBoW/DsuMp3E3JvpP7EqIR3YeuhMFzFGWZ9 X-Google-Smtp-Source: APXvYqwRfav3WDUklvFF+dSYh7C9+y68W18pixjaLiFSRhYAsXZSdB+KxOeA6SKEr07IF5nOAMYcXQ== X-Received: by 2002:a63:4547:: with SMTP id u7mr11446638pgk.423.1574947516802; Thu, 28 Nov 2019 05:25:16 -0800 (PST) Received: from smtp.gmail.com ([38.99.100.2]) by smtp.gmail.com with ESMTPSA id k66sm20126308pgk.16.2019.11.28.05.25.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Nov 2019 05:25:16 -0800 (PST) Message-ID: <5ddfcabc.1c69fb81.626d0.c7a5@mx.google.com> MIME-Version: 1.0 Date: Thu, 28 Nov 2019 21:25:10 +0800 From: LinSun Subject: 27.0.50;; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message Thread-Topic: 27.0.50;; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message To: "bug-gnu-emacs@gnu.org" , "ericludlam@gmail.com" Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="utf-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::531 X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 28 Nov 2019 11:36:44 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--)

[PATCH] * makefile-edit.el: regexp-q= uote the param in

makefile-move-to-macro.

 

Fix the error mess= age from `makefile-move-to-macro' when there is '$'

or '\\' in param for re-search-forward, with `(global-ede-mode t)' and

=

`(semantic-mode t)' enabled. Enable ede and semantic m= ode, then open a

Makefile.am in which has line 'AM_= LIBTMP_LIBS:=3D$(shell X \--libs)'

will trigger the= error message, and this patch fix that.

---

lisp/cedet/ede/makefile-edit.el | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

 

diff --git a/lisp/cedet/ede/ma= kefile-edit.el

b/lisp/cedet/ede/makefile-edit.el

index 7d8a44b..add1675 100644

--- a/lisp/cedet/ede/makefile-edit.el

+++ b/lisp/c= edet/ede/makefile-edit.el

@@ -78,7 +78,7 @@ makefil= e-move-to-macro

If NEXT is non-nil, move to the ne= xt occurrence of MACRO."

=C2=A0=C2=A0 (let ((o= ldpt (point)))

=C2=A0=C2=A0=C2=A0=C2=A0 (when (not = next) (goto-char (point-min)))

-=C2=A0=C2=A0=C2=A0 = (if (re-search-forward (concat "^\\s-*" macro "\\s-*[+:?]?= =3D") nil t)

+=C2=A0=C2=A0=C2=A0 (if (re-searc= h-forward (concat "^\\s-*" (regexp-quote macro)

"\\s-*[+:?]?=3D") nil t)

=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 t

=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 (goto-char oldpt)

=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 nil)))

--

2.2.0

 

 

 

= ------------=_1579219982-7149-5-- From unknown Fri Jun 13 11:16:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39094: regexp-quote the param in makefile-move-to-macro to avoid error message Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2020 01:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39094 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: "'Paul Eggert'" Cc: 39094-done@debbugs.gnu.org Received: via spool by 39094-done@debbugs.gnu.org id=D39094.157922624316911 (code D ref 39094); Fri, 17 Jan 2020 01:58:02 +0000 Received: (at 39094-done) by debbugs.gnu.org; 17 Jan 2020 01:57:23 +0000 Received: from localhost ([127.0.0.1]:38690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isGt1-0004Oh-8Y for submit@debbugs.gnu.org; Thu, 16 Jan 2020 20:57:23 -0500 Received: from mail-pl1-f169.google.com ([209.85.214.169]:43820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isGsy-0004OR-IT for 39094-done@debbugs.gnu.org; Thu, 16 Jan 2020 20:57:21 -0500 Received: by mail-pl1-f169.google.com with SMTP id p27so9165875pli.10 for <39094-done@debbugs.gnu.org>; Thu, 16 Jan 2020 17:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zoom.us; s=google; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:thread-index :content-language; bh=iCG3656kIywrciBy4GgzGfx0cG31/RJXDOVkJSmrzHM=; b=dzMJrx+Iaaa5Me6feCelAIQD/Od2En9hpRxFB9vdWeQlPUMIufCvFqJ5xe+60f5yEm g0kzIVBQ01NKJa5rlB8Usnxk509EJGxNc1/lr+RizU+CH31KLGXeQIBN08rQnRIcK2AR SxcIx/xHHdiKO5rJS5w26WEM4o/+eB03W7Dmg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-transfer-encoding:thread-index :content-language; bh=iCG3656kIywrciBy4GgzGfx0cG31/RJXDOVkJSmrzHM=; b=YuTwfTmODHCDwLaZ3n/OpMWS8n8ZFI68UEsO3xsFmFZU9iXmrP06OtSCxkaHG88soC 0qNCTlYyQBZOlzEMueU2oCvkiEuzH+FDvHoUFW7rgVYAwAplC+8WGr2neyFu29P3Etn9 1ADat9oWs+jm+xY2L6bjiYfWmPnoS2Ha1JD3q/vOU5cvz0fJSYcW9sHbkxzi2rOyI9nh +/gS8c9hkm7gPy1DaQ/fmVJMdDQJuVGJK79rfyu91STo2Qb33cOGwhyA/umD5lwH/vm+ evq/19D6pbkxx+6l2gUx8zK3AfDyIcZa0AireU5FlSKMOUGQ0zBcXZL54BNXKElT7Nq9 k93A== X-Gm-Message-State: APjAAAUrXQQEn3V5+1fkM1PI2p1re/+u8QgzTNUn9h/kU3hY3XEOKDXg ZfMnCXlIZjM29mEfmyoKB8rLlDw9grfWEog8iBVvHawWfBIjJIufbqcG59RULEMHLNzOBTcFQiW y7+/2GBhxFFGJZItTLpJ2ooY2BtLZPuyvsb6+DatUZNeah21lz3hTUu/2orm2BwP93xM= X-Google-Smtp-Source: APXvYqxh+qi+QPioehnldICQjNDwwQDaDG3MZinutPKskotqMmZea0pA+oLhQEBBtAxE3baQ37hbbw== X-Received: by 2002:a17:90b:8b:: with SMTP id bb11mr2886603pjb.27.1579226234365; Thu, 16 Jan 2020 17:57:14 -0800 (PST) Received: from DESKTOP71C1N5K ([38.99.100.2]) by smtp.gmail.com with ESMTPSA id i8sm27671874pfa.109.2020.01.16.17.57.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jan 2020 17:57:13 -0800 (PST) From: References: <25c4e204-0465-5e7a-4183-8e5a23989b85@cs.ucla.edu> In-Reply-To: <25c4e204-0465-5e7a-4183-8e5a23989b85@cs.ucla.edu> Date: Fri, 17 Jan 2020 09:57:09 +0800 Message-ID: <01e101d5ccd9$6f2fc9b0$4d8f5d10$@zoom.us> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEkgNqrJTlCeCh9UdiQr1BzJsAeOqlQsNhQ Content-Language: en-us X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >Thanks for reporting that bug. I installed your patch into the master branch. Thank you Paul. From unknown Fri Jun 13 11:16:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39094: regexp-quote the param in makefile-move-to-macro to avoid error message Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2020 08:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39094 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 39094@debbugs.gnu.org, lin.sun@zoom.us Received: via spool by 39094-submit@debbugs.gnu.org id=B39094.15792490563961 (code B ref 39094); Fri, 17 Jan 2020 08:18:02 +0000 Received: (at 39094) by debbugs.gnu.org; 17 Jan 2020 08:17:36 +0000 Received: from localhost ([127.0.0.1]:38820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isMox-00011p-Mq for submit@debbugs.gnu.org; Fri, 17 Jan 2020 03:17:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isMou-00011a-33 for 39094@debbugs.gnu.org; Fri, 17 Jan 2020 03:17:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1isMoo-0003el-Eo; Fri, 17 Jan 2020 03:17:26 -0500 Received: from [176.228.60.248] (port=2133 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1isMon-0005up-F7; Fri, 17 Jan 2020 03:17:26 -0500 Date: Fri, 17 Jan 2020 10:17:23 +0200 Message-Id: <838sm633ak.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <25c4e204-0465-5e7a-4183-8e5a23989b85@cs.ucla.edu> (message from Paul Eggert on Thu, 16 Jan 2020 16:12:01 -0800) References: <000201d5c91f$3bac3b90$b304b2b0$@zoom.us> <25c4e204-0465-5e7a-4183-8e5a23989b85@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Paul Eggert > Date: Thu, 16 Jan 2020 16:12:01 -0800 > Cc: 39094-done@debbugs.gnu.org > > Thanks for reporting that bug. I installed your patch into the master > branch. Thanks, but such safe bugfixes should go to the release branch. I've cherry-picked it now.