GNU bug report logs - #3904
23.1.50; [PATCH] keyboard translating with timer doesn't work well

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3904 in the body.
You can then email your comments to 3904 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Naohiro Aota <naota <at> elisp.net>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.1.50; [PATCH] keyboard translating with timer doesn't work well
Date: Thu, 23 Jul 2009 03:02:51 +0900

I found evaluating the following code outputs "abbbbb ...", and
M-x view-lossage after that shows "b b b b b ...".

(progn
  (keyboard-translate ?a ?b)
  (push ?a unread-command-events)
  (setq my-timer
  	(run-with-idle-timer 1 t (lambda () (push ?a unread-command-events)))))

This result suggests three problems.

1. If a timer handler function uses `sit-for' (or any function push a
   key to `unread-command-events'), the key would be translated once
   more.

2. idle-timer function should run "only once for each time Emacs
   becomes idle", but it seems the above function is called so many times.

3. `view-lossage' shouldn't show such stroke: "b b b b b ...".

I don't know this is the right way, but it seems the patch below solves
all the problem above.

--8<---------------cut here---------------start------------->8---
Index: src/keyboard.c
===================================================================
RCS file: /sources/emacs/emacs/src/keyboard.c,v
retrieving revision 1.1008
diff -c -r1.1008 keyboard.c
*** src/keyboard.c	3 Jul 2009 11:07:11 -0000	1.1008
--- src/keyboard.c	22 Jul 2009 17:20:11 -0000
***************
*** 2988,2993 ****
--- 2988,2994 ----
      {
        c = XCAR (Vunread_command_events);
        Vunread_command_events = XCDR (Vunread_command_events);
+       goto reread_for_input_method;
      }
  
    /* Read something from current KBOARD's side queue, if possible.  */
--8<---------------cut here---------------end--------------->8---


2009-07-22  Naohiro Aota  <naota <at> elisp.net>

	* keyboard.c (read_char): When event set by a timer, sentinel or
	filter, skip keyboard translating and key recording.

Regards,

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Naohiro Aota <naota <at> elisp.net>, 3904 <at> debbugs.gnu.org
Cc: emacs-pretest-bug <at> gnu.org
Subject: Re: bug#3904: 23.1.50;	[PATCH] keyboard translating with timer doesn't
 work well
Date: Thu, 23 Jul 2009 11:23:45 +0200

> 1. If a timer handler function uses `sit-for' (or any function push a
>    key to `unread-command-events'), the key would be translated once
>    more.

From the Elisp manual:

   Timer functions should also avoid calling functions that cause Emacs
to wait, such as `sit-for' ...

martin

Message #24 received at 3904 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Naohiro Aota <naota <at> elisp.net>, 3904 <at> debbugs.gnu.org
Subject: Re: bug#3904: 23.1.50;
	[PATCH] keyboard translating with timer doesn't work well
Date: Tue, 12 Jul 2011 21:57:42 +0200

martin rudalics <rudalics <at> gmx.at> writes:

>> 1. If a timer handler function uses `sit-for' (or any function push a
>>    key to `unread-command-events'), the key would be translated once
>>    more.
>
> From the Elisp manual:
>
>    Timer functions should also avoid calling functions that cause Emacs
> to wait, such as `sit-for' ...

Yes, I don't think this is supported, so I'm closing the report.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.