GNU bug report logs - #39013
[PATCH] gnu: Add abseil-cpp.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39013 in the body.
You can then email your comments to 39013 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add abseil-cpp.
Date: Tue, 07 Jan 2020 16:07:21 +0100

[Message part 1 (text/plain, inline)]

Dear Guix,

The following patch adds abseil-cpp.  I want to add it because it seems
to be a dependency of tensorflow-1.15.0 (which I am trying to update
to).

There are two not-so-perfect things with the patch:
1. I had to use the latest Git commit because it adds bits to build
shared libraries.
2. I disabled the tests because it attempts to download "googletest". 
I tried modifying the build system to use "googletest" from Guix but
that wasn't succesful.

Nevertheless, I hope this patch is acceptable.

Kind regards,
Roel Janssen

[0001-gnu-Add-abseil-cpp.patch (text/x-patch, attachment)]

Message #8 received at 39013 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Roel Janssen <roel <at> gnu.org>
Cc: 39013 <at> debbugs.gnu.org
Subject: Re: [bug#39013] [PATCH] gnu: Add abseil-cpp.
Date: Thu, 09 Jan 2020 22:53:11 +0100

Hi Roel,

Roel Janssen <roel <at> gnu.org> skribis:

> There are two not-so-perfect things with the patch:
> 1. I had to use the latest Git commit because it adds bits to build
> shared libraries.

Sounds good to me.

> 2. I disabled the tests because it attempts to download "googletest". 
> I tried modifying the build system to use "googletest" from Guix but
> that wasn't succesful.

There are packages such as ‘encfs’ where we simply unpack the source of
our ‘googletest’ package in the right place.  Would what work here?

> From 06ed0284561463c087ec0f16f9c35fc7926f22df Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel <at> gnu.org>
> Date: Tue, 7 Jan 2020 16:02:28 +0100
> Subject: [PATCH] gnu: Add abseil-cpp.
>
> * gnu/packages/machine-learning.scm (abseil-cpp): New variable.

[...]

> +      (description "Abseil is an open-source collection of C++ library code

s/an open-source/a/

> +designed to augment the C++ standard library.  The Abseil library code is
> +collected from Google's own C++ code base, has been extensively tested and
> +used in production, and is the same code we depend on in our daily coding
> +lives.")

Who’s “we”?  :-)  Would be great if you could make that more factual.

Apart from that it LGTM.

Thanks,
Ludo’.

Message #11 received at 39013 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 39013 <at> debbugs.gnu.org
Subject: Re: [bug#39013] [PATCH] gnu: Add abseil-cpp.
Date: Fri, 10 Jan 2020 20:23:37 +0100

On Thu, 2020-01-09 at 22:53 +0100, Ludovic Courtès wrote:
> Hi Roel,
> 
> Roel Janssen <roel <at> gnu.org> skribis:
> 
> > There are two not-so-perfect things with the patch:
> > 1. I had to use the latest Git commit because it adds bits to build
> > shared libraries.
> 
> Sounds good to me.
> 
> > 2. I disabled the tests because it attempts to download "googletest". 
> > I tried modifying the build system to use "googletest" from Guix but
> > that wasn't succesful.
> 
> There are packages such as ‘encfs’ where we simply unpack the source of
> our ‘googletest’ package in the right place.  Would what work here?


No.  Here's an inline version of the package, because I've had enough trouble
with Guix this week.


(define-public abseil-cpp
  ;; We use this commit because it contains changes to the build system to
  ;; allow building shared libraries.
  (let ((commit "a048203a881f11f4b7b8df5fb563aec85522f8db"))
    (package
      (name "abseil-cpp")
      (version (string-append "20190808-" (string-take commit 7)))
      (source (origin
                (method git-fetch)
                (uri (git-reference
                      (url "https://github.com/abseil/abseil-cpp.git")
                      (commit commit)))
                (file-name (git-file-name name version))
                (sha256
                 (base32
                  "13v3bkfyhrcl9am0jcz4cfbfc5rn3acm9z4wm01pn36vcgvw2l4s"))))
      (build-system cmake-build-system)
      (arguments
       `(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON" "-DABSL_RUN_TESTS=ON")
         #:phases
         (modify-phases %standard-phases
           (add-before 'configure 'unpack-googletest
             (lambda* (#:key inputs #:allow-other-keys)
               ;; So, the CMake 'configure' phase expects the googletest-src
               ;; and googletest-build directories to be in the ../build
               ;; directory, but the Guix 'configure' phase creates the
               ;; directory using (mkdir "../build"), which errors out when
               ;; we have already created the build directory.
               ;;
               ;; The code below errors out, so if you have a solution for
               ;; this, that would be great.  Until that time I will simply
               ;; postpone working on upgrading the TensorFlow package in
               ;; the upstream repository of Guix.
               (mkdir-p "../build")
               (with-directory-excursion "../build"
                 (format #t "We're in ~s~%" (getcwd))
                 (mkdir-p "googletest-src")
                 (mkdir-p "googletest-build")
                 (copy-recursively
                  (assoc-ref inputs "googletest-source")
                  "googletest-src")
                 (copy-recursively
                  (assoc-ref inputs "googletest")
                  "googletest-build"))
                 #t))
           (replace 'check
           (lambda _
             (invoke "ctest"))))))
      (native-inputs
       `(("googletest-source" ,(package-source googletest))
         ("googletest" ,googletest)))
      (home-page "https://abseil.io")
      (synopsis "Augmented C++ standard library")
      (description "Abseil is a collection of C++ library code designed to
augment the C++ standard library.  The Abseil library code is collected from
Google's C++ code base.")
      (license license:asl2.0))))


Thanks,
Roel

Message #14 received at 39013 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Roel Janssen <roel <at> gnu.org>
Cc: 39013 <at> debbugs.gnu.org
Subject: Re: [bug#39013] [PATCH] gnu: Add abseil-cpp.
Date: Wed, 15 Jan 2020 21:53:13 +0100

Hi Roel,

Roel Janssen <roel <at> gnu.org> skribis:

> On Thu, 2020-01-09 at 22:53 +0100, Ludovic Courtès wrote:

[...]

>> There are packages such as ‘encfs’ where we simply unpack the source of
>> our ‘googletest’ package in the right place.  Would what work here?
>
>
> No.  Here's an inline version of the package, because I've had enough trouble
> with Guix this week.

Oh, I understand the frustration.  I gather we’ll put this on hold for now.

Thanks for your help,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.