GNU bug report logs - #39006
[PATCH] gnu: timidity++: Add libvorbis as input

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#39006: closed ([PATCH] gnu: timidity++: Add libvorbis as input)
Date: Sat, 11 Jan 2020 21:46:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 11 Jan 2020 22:45:33 +0100
with message-id <87ftglu0oy.fsf <at> gnu.org>
and subject line Re: [bug#39006] [PATCH] gnu: timidity++: Add libvorbis as input
has caused the debbugs.gnu.org bug report #39006,
regarding [PATCH] gnu: timidity++: Add libvorbis as input
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
39006: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39006
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: EuAndreh <eu <at> euandre.org>
To: guix-patches <at> gnu.org
Cc: EuAndreh <eu <at> euandre.org>
Subject: [PATCH] gnu: timidity++: Add libvorbis as input
Date: Tue,  7 Jan 2020 08:08:30 -0300

* gnu/packages/audio.scm (timidity++)[inputs] Add libvorbis as input
---
Hi Guix!

The current definition of TiMidity++ does include the configure flag for
Ogg Vorbis (--enable-audio=vorbis), but the package definition does not
provide all the required inputs for actually enabling it:

--8<---------------cut here---------------start------------->8---
$ guix environment --ad-hoc -- timidity -Ov
Playmode `v' is not compiled in.
Try timidity -h for help
--8<---------------cut here---------------end--------------->8---

From the build log (http://ci.guix.gnu.org/log/qynf65197fp921vz8k03qblz7djaarb0-timidity++-2.14.0):

--8<---------------cut here---------------start------------->8---
...
checking for Ogg... yes
checking for Vorbis... no
*** Could not run Vorbis test program, checking why...
*** The test program failed to compile or link. See the file config.log for the
*** exact error that occured. This usually means Vorbis was incorrectly installed
*** or that you have moved Vorbis since it was installed.
...
--8<---------------cut here---------------end--------------->8---

This happens because 'libogg' in provided as input, but 'libvorbis'
isn't.

After applying this patch, Ogg Vorbis becomes available like other formats.
--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix environment --ad-hoc -- timidity -Ov
Try timidity -h for help
--8<---------------cut here---------------end--------------->8---
 gnu/packages/audio.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 55a34460b1..f37ebc886e 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2574,6 +2574,7 @@ Suil currently supports every combination of Gtk, Qt, and X11.")
        ("flac" ,flac)
        ("jack" ,jack-1)
        ("libogg" ,libogg)
+       ("libvorbis" ,libvorbis)
        ("speex" ,speex)
        ("ncurses" ,ncurses)
        ("freepats" ,freepats)))
--
2.24.1

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: EuAndreh <eu <at> euandre.org>
Cc: 39006-done <at> debbugs.gnu.org
Subject: Re: [bug#39006] [PATCH] gnu: timidity++: Add libvorbis as input
Date: Sat, 11 Jan 2020 22:45:33 +0100

Hello,

EuAndreh <eu <at> euandre.org> skribis:

> * gnu/packages/audio.scm (timidity++)[inputs] Add libvorbis as input
> ---
> Hi Guix!
>
> The current definition of TiMidity++ does include the configure flag for
> Ogg Vorbis (--enable-audio=vorbis), but the package definition does not
> provide all the required inputs for actually enabling it:
>
> $ guix environment --ad-hoc -- timidity -Ov
> Playmode `v' is not compiled in.
> Try timidity -h for help

Indeed.  Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.