From unknown Sat Sep 06 00:11:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#39000 <39000@debbugs.gnu.org> To: bug#39000 <39000@debbugs.gnu.org> Subject: Status: Light frame after desktop-read on MacOS Reply-To: bug#39000 <39000@debbugs.gnu.org> Date: Sat, 06 Sep 2025 07:11:21 +0000 retitle 39000 Light frame after desktop-read on MacOS reassign 39000 emacs submitter 39000 Tak Kunihiro severity 39000 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 22:18:24 2020 Received: (at submit) by debbugs.gnu.org; 7 Jan 2020 03:18:24 +0000 Received: from localhost ([127.0.0.1]:47113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iofNw-0003L6-Lt for submit@debbugs.gnu.org; Mon, 06 Jan 2020 22:18:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:44871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iofNv-0003Kz-0l for submit@debbugs.gnu.org; Mon, 06 Jan 2020 22:18:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35221) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iofNt-0008MR-Sb for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 22:18:22 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iofNs-0007wi-NW for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 22:18:21 -0500 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:35636) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iofNs-0007vs-G8 for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 22:18:20 -0500 Received: by mail-pg1-x52c.google.com with SMTP id l24so27812890pgk.2 for ; Mon, 06 Jan 2020 19:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:to:cc:subject:from:mime-version :content-transfer-encoding; bh=h+bQJAb6PPjFExkeZI6Yo54pkxGib/AZnGCiEWXLwXc=; b=M4f3/OFWmc+fowiIwxT1s17dAPHhaEThXJtiIQqQJqdXIDFNkV8+pVjeXivbv05ogs yJsnSBOASgEIvPgVPeUnpJ2/8nKPB3vhieajh8JKCh9rw8oT2aAwZxYgfLZsgvbPlSXW P+EQdOBSJlLGnuVdxwZAV7hkg8QBZZNO6idhpZvqyP6a1k2IsYDANEW5hfEfxW6bGomK dVo/PxuYJIMEGJPH9fh72Xxq+rdRgmXK9QNuk/e4XfEnKkB5A5zq2mk1ExVTdl99WRrH pwaY8XAoTUhttmG5OavOSFngzHZtmW4WzRd0ad85CYTGKvTmJuKDeyXwk0DH3cut8Cdr ORQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:to:cc:subject:from:mime-version :content-transfer-encoding; bh=h+bQJAb6PPjFExkeZI6Yo54pkxGib/AZnGCiEWXLwXc=; b=SxzXlDsnAfhybyPQISRFtbF60tNRkfQ9NEq0BEhup8gBPGk34t0p9rBST8PJjEcQup GKMzLtQZhLuQP/z1ObyIs9sk9BdPxW8zygGbYLg25KXYypl0U0DknvxSBqW+JbgaVZkj OSSgGDbxXZ2tlUFPZohON2q4BzqN0/kE2PXK39SMU2qflvB6QsTijUQoqfgDF+/Y3FL7 vAP8fEd67oS0IUDZPhTOFg+T1xk//Z2gA9s7MB9VNEKSeNmYvuI8hB0L2CEU2vLYgdGX nv8BmHs6TLYlOHFJbf2NSP+YR9TsqHyVoLcBRfLMFmY5lBWbSeok66ILNALjxwqsMcaS Y3mQ== X-Gm-Message-State: APjAAAWCHdJBmzi4xHhFEab7/jenZ0eI/XjlNg24rhxcwMZDIvgGB6PX ma9+N3yn1KqORBgeU0n38nsqnopE X-Google-Smtp-Source: APXvYqzj+vhg6A6Sp1W4H8LLEg6G92teg1o4ByQFSTMt4XyeHCMS57VpKQ9bG7wWAswSs/RtoVUgWQ== X-Received: by 2002:a63:cb06:: with SMTP id p6mr113828942pgg.236.1578367098758; Mon, 06 Jan 2020 19:18:18 -0800 (PST) Received: from localhost (vesta.misasa.okayama-u.ac.jp. [150.46.48.154]) by smtp.gmail.com with ESMTPSA id z30sm81769400pff.131.2020.01.06.19.18.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jan 2020 19:18:18 -0800 (PST) Date: Tue, 07 Jan 2020 12:18:16 +0900 (JST) Message-Id: <20200107.121816.1973201462831337632.tak.kunihiro@gmail.com> To: bug-gnu-emacs@gnu.org Subject: Light frame after desktop-read on MacOS From: Tak Kunihiro X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52c X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit Cc: tak.kunihiro@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Emacs 26.3 offers dark frames on MacOS 10.14.6 with `Dark (Still)' mode. However after the following operations, $ emacs -Q M-x about-emacs GNU Emacs 26.3 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G87)) M-x desktop-save M-x desktop-read a dark frame turns into light frame. I think this is a bug. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 10:03:35 2020 Received: (at 39000) by debbugs.gnu.org; 7 Jan 2020 15:03:35 +0000 Received: from localhost ([127.0.0.1]:49023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioqOM-0000lU-Kt for submit@debbugs.gnu.org; Tue, 07 Jan 2020 10:03:35 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:38236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioqOH-0000lA-Je for 39000@debbugs.gnu.org; Tue, 07 Jan 2020 10:03:31 -0500 Received: by mail-wm1-f46.google.com with SMTP id u2so19751222wmc.3 for <39000@debbugs.gnu.org>; Tue, 07 Jan 2020 07:03:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+QUU8RvlKah85K15Ro/jw7olzcDXCadhdpDX1zKjfcA=; b=Jg6jiltlFcRWryAhg26dDp92s+T8cylEGoCFY7PUDR2jYJ2HE/DuQdKQTYCBHPpGWG a5UturaPXjmKxU2YHdsBiNn2Up1u1rbggYcWw2Kz0yp3JC2zzrjTg5zgf+W3R22ZmCmR ktx/fn3jHBL1u1b79A9Z9O+NWjJSuyhny96GIGUfS65x6zghHtDrNhuCBqhv2YtdOYZj YcP57E7Ryz8OKKOOGs/L3gRS98UFNjUOW7SQ9/CrI7dQhPsCA9n9N8lwm97OQGHzg00a ad1xSkfpyQHzJ953UZlg6cMAHiEYCYCrx43/eI+/UZLnFZBaLMTz34hH5dvr2l/YaykT 1pVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=+QUU8RvlKah85K15Ro/jw7olzcDXCadhdpDX1zKjfcA=; b=lnGM8WyQ7NmCFSdysU/+tI55yZ4cMgtFUE0DDCgI75JTvkiFTpPQu/FaMcQpXVmC0o ih5Z56wYjgPS8qzeAFJ/LhxBtKWXz8kZgXbfeijibB/yJ3iPjZh7SNrZKjnuPunkWVmC VVUAUAWini1OUyNQD0E5wwlSekYxksTNf0o8S0z7FEXpEnBAqN6RXES16qzWAe1oaUwz Duilr3/KXE1Ffj+ZyelHGjJ9YYNYtYTvjEBrHW9WfRJLAg9zNqKnE9q9mi+Utjja+ecs NVEB56B9I+kyWjSvHjYOk7Yh4/trPHMX1ZxcJHqiF0ndcbOCrlu7TeJy2nEXPVH208sG rfnw== X-Gm-Message-State: APjAAAVnpcLq5C75w4loUTiDBeGTqaSCleoWUyVIHNm/XWCD7FRB9pB6 Mu1PP6H1YjAaez7jUSGSlPc= X-Google-Smtp-Source: APXvYqwyqc2cAjWUn72aFQ1Xn5UgkykmKa281pfi2nU2/jyAnUmWmxKnOi75kNjUqw6xoJI9YxygIA== X-Received: by 2002:a7b:c4c3:: with SMTP id g3mr39014954wmk.131.1578409403716; Tue, 07 Jan 2020 07:03:23 -0800 (PST) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-c433-e1b7-7772-c490.holly.idiocy.org. [2001:8b0:3f8:8129:c433:e1b7:7772:c490]) by smtp.gmail.com with ESMTPSA id o15sm82366wra.83.2020.01.07.07.03.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 07:03:22 -0800 (PST) Date: Tue, 7 Jan 2020 15:03:20 +0000 From: Alan Third To: Tak Kunihiro Subject: Re: bug#39000: Light frame after desktop-read on MacOS Message-ID: <20200107150320.GA76575@breton.holly.idiocy.org> References: <20200107.121816.1973201462831337632.tak.kunihiro@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200107.121816.1973201462831337632.tak.kunihiro@gmail.com> X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 39000 Cc: 39000@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Jan 07, 2020 at 12:18:16PM +0900, Tak Kunihiro wrote: > Emacs 26.3 offers dark frames on MacOS 10.14.6 with `Dark (Still)' > mode. However after the following operations, > > $ emacs -Q > M-x about-emacs > GNU Emacs 26.3 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G87)) > M-x desktop-save > M-x desktop-read > > a dark frame turns into light frame. I think this is a bug. I’ve attached a patch. It also fixes a niggle I had in that you could force the frame to use a dark theme, or an aqua theme, but not the system default even though Emacs would launch with the system default. The documentation was also wrong in that it described the light theme as the system default, even though it may not have been. I’m not sure if this is too big a change for emacs 27 at this stage, as it’s not entirely fixing bugs, although I’d argue it’s completing a feature that is incomplete in Emacs 26. -- Alan Third --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Fix-NS-frame-parameters-bug-39000.patch" >From c36ab8ccced2b32425160d33777df7dccdb233e4 Mon Sep 17 00:00:00 2001 From: Alan Third Date: Tue, 7 Jan 2020 14:19:01 +0000 Subject: [PATCH] Fix NS frame parameters (bug#39000) * src/frame.c (make_frame): Use new system default setting. * src/frame.h (enum ns_appearance_type): Add new system default setting. * src/nsfns.m (Fx_create_frame): Correctly handle Qunbound and support system default appearance. (syms_of_nsfns): Add Qlight. * src/nsterm.h: New method definition. * src/nsterm.m (ns_set_appearance): Correctly handle Qlight and use new setAppearance method. ([EmacsView initFrameFromEmacs:]): Use new setAppearance method. ([EmacsWindow setAppearance]): New method. * doc/lispref/frames.texi (Management Parameters): Document 'light'. --- doc/lispref/frames.texi | 9 +++---- src/frame.c | 2 +- src/frame.h | 5 ++-- src/nsfns.m | 15 ++++++++---- src/nsterm.h | 2 ++ src/nsterm.m | 52 ++++++++++++++++++++++++++--------------- 6 files changed, 55 insertions(+), 30 deletions(-) diff --git a/doc/lispref/frames.texi b/doc/lispref/frames.texi index 05038c6f52..9bd8bedc66 100644 --- a/doc/lispref/frames.texi +++ b/doc/lispref/frames.texi @@ -2192,10 +2192,11 @@ Management Parameters @vindex ns-appearance@r{, a frame parameter} @item ns-appearance Only available on macOS, if set to @code{dark} draw this frame's -window-system window using the ``vibrant dark'' theme, otherwise use -the system default. The ``vibrant dark'' theme can be used to set the -toolbar and scrollbars to a dark appearance when using an Emacs theme -with a dark background. +window-system window using the ``vibrant dark'' theme, and if set to +@code{light} use the ``aqua'' theme, otherwise use the system default. +The ``vibrant dark'' theme can be used to set the toolbar and +scrollbars to a dark appearance when using an Emacs theme with a dark +background. @vindex ns-transparent-titlebar@r{, a frame parameter} @item ns-transparent-titlebar diff --git a/src/frame.c b/src/frame.c index 88d6f22fc0..51fc78ab70 100644 --- a/src/frame.c +++ b/src/frame.c @@ -904,7 +904,7 @@ make_frame (bool mini_p) f->last_tool_bar_item = -1; #endif #ifdef NS_IMPL_COCOA - f->ns_appearance = ns_appearance_aqua; + f->ns_appearance = ns_appearance_system_default; f->ns_transparent_titlebar = false; #endif #endif diff --git a/src/frame.h b/src/frame.h index 6ab690c0ff..68dc0ce364 100644 --- a/src/frame.h +++ b/src/frame.h @@ -69,8 +69,9 @@ #define EMACS_FRAME_H #ifdef NS_IMPL_COCOA enum ns_appearance_type { - ns_appearance_aqua, - ns_appearance_vibrant_dark + ns_appearance_system_default, + ns_appearance_aqua, + ns_appearance_vibrant_dark }; #endif #endif /* HAVE_WINDOW_SYSTEM */ diff --git a/src/nsfns.m b/src/nsfns.m index 13ff67df09..18488bd46f 100644 --- a/src/nsfns.m +++ b/src/nsfns.m @@ -1271,14 +1271,20 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side. #ifdef NS_IMPL_COCOA tem = gui_display_get_arg (dpyinfo, parms, Qns_appearance, NULL, NULL, RES_TYPE_SYMBOL); - FRAME_NS_APPEARANCE (f) = EQ (tem, Qdark) - ? ns_appearance_vibrant_dark : ns_appearance_aqua; - store_frame_param (f, Qns_appearance, tem); + if (EQ (tem, Qdark)) + FRAME_NS_APPEARANCE (f) = ns_appearance_vibrant_dark; + else if (EQ (tem, Qlight)) + FRAME_NS_APPEARANCE (f) = ns_appearance_aqua; + else + FRAME_NS_APPEARANCE (f) = ns_appearance_system_default; + store_frame_param (f, Qns_appearance, + (!NILP (tem) && !EQ (tem, Qunbound)) ? tem : Qnil); tem = gui_display_get_arg (dpyinfo, parms, Qns_transparent_titlebar, NULL, NULL, RES_TYPE_BOOLEAN); FRAME_NS_TRANSPARENT_TITLEBAR (f) = !NILP (tem) && !EQ (tem, Qunbound); - store_frame_param (f, Qns_transparent_titlebar, tem); + store_frame_param (f, Qns_transparent_titlebar, + FRAME_NS_TRANSPARENT_TITLEBAR (f) ? Qt : Qnil); #endif parent_frame = gui_display_get_arg (dpyinfo, parms, Qparent_frame, NULL, NULL, @@ -3135,6 +3141,7 @@ - (NSString *)panel: (id)sender userEnteredFilename: (NSString *)filename DEFSYM (Qframe_title_format, "frame-title-format"); DEFSYM (Qicon_title_format, "icon-title-format"); DEFSYM (Qdark, "dark"); + DEFSYM (Qlight, "light"); DEFVAR_LISP ("ns-icon-type-alist", Vns_icon_type_alist, doc: /* Alist of elements (REGEXP . IMAGE) for images of icons associated to frames. diff --git a/src/nsterm.h b/src/nsterm.h index fb9ac1b462..8baa65f578 100644 --- a/src/nsterm.h +++ b/src/nsterm.h @@ -471,6 +471,8 @@ #define NSTRACE_UNSILENCE() { NSPoint grabOffset; } + +- (void)setAppearance; @end diff --git a/src/nsterm.m b/src/nsterm.m index 03754e5ae5..d66a3d7495 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -2025,17 +2025,13 @@ so some key presses (TAB) are swallowed by the system. */ return; if (EQ (new_value, Qdark)) - { - window.appearance = [NSAppearance - appearanceNamed: NSAppearanceNameVibrantDark]; - FRAME_NS_APPEARANCE (f) = ns_appearance_vibrant_dark; - } + FRAME_NS_APPEARANCE (f) = ns_appearance_vibrant_dark; + else if (EQ (new_value, Qlight)) + FRAME_NS_APPEARANCE (f) = ns_appearance_aqua; else - { - window.appearance = [NSAppearance - appearanceNamed: NSAppearanceNameAqua]; - FRAME_NS_APPEARANCE (f) = ns_appearance_aqua; - } + FRAME_NS_APPEARANCE (f) = ns_appearance_system_default; + + [window setAppearance]; #endif /* MAC_OS_X_VERSION_MAX_ALLOWED >= 101000 */ } @@ -7465,16 +7461,8 @@ - (instancetype) initFrameFromEmacs: (struct frame *)f if (! FRAME_UNDECORATED (f)) [self createToolbar: f]; -#if defined (NS_IMPL_COCOA) && MAC_OS_X_VERSION_MAX_ALLOWED >= 101000 -#ifndef NSAppKitVersionNumber10_10 -#define NSAppKitVersionNumber10_10 1343 -#endif - if (NSAppKitVersionNumber >= NSAppKitVersionNumber10_10 - && FRAME_NS_APPEARANCE (f) != ns_appearance_aqua) - win.appearance = [NSAppearance - appearanceNamed: NSAppearanceNameVibrantDark]; -#endif + [win setAppearance]; #if defined (NS_IMPL_COCOA) && MAC_OS_X_VERSION_MAX_ALLOWED >= 101000 if ([win respondsToSelector: @selector(titlebarAppearsTransparent)]) @@ -8724,6 +8712,32 @@ - (void)zoom:(id)sender #endif } +- (void)setAppearance +{ +#if MAC_OS_X_VERSION_MAX_ALLOWED >= 101000 + struct frame *f = ((EmacsView *)[self delegate])->emacsframe; + NSAppearance *appearance = nil; + + NSTRACE ("[EmacsWindow setAppearance]"); + +#ifndef NSAppKitVersionNumber10_10 +#define NSAppKitVersionNumber10_10 1343 +#endif + + if (NSAppKitVersionNumber < NSAppKitVersionNumber10_10) + return; + + if (FRAME_NS_APPEARANCE (f) == ns_appearance_vibrant_dark) + appearance = + [NSAppearance appearanceNamed:NSAppearanceNameVibrantDark]; + else if (FRAME_NS_APPEARANCE (f) == ns_appearance_aqua) + appearance = + [NSAppearance appearanceNamed:NSAppearanceNameAqua]; + + [self setAppearance:appearance]; +#endif /* MAC_OS_X_VERSION_MAX_ALLOWED >= 101000 */ +} + - (void)setFrame:(NSRect)windowFrame display:(BOOL)displayViews { -- 2.24.0 --nFreZHaLTZJo0R7j-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 11:08:13 2020 Received: (at 39000) by debbugs.gnu.org; 7 Jan 2020 16:08:13 +0000 Received: from localhost ([127.0.0.1]:49083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iorOu-0002Pl-Rb for submit@debbugs.gnu.org; Tue, 07 Jan 2020 11:08:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iorOs-0002PY-N4 for 39000@debbugs.gnu.org; Tue, 07 Jan 2020 11:08:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iorOn-0001Jb-DU; Tue, 07 Jan 2020 11:08:05 -0500 Received: from [176.228.60.248] (port=1673 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iorOk-0007Ot-6e; Tue, 07 Jan 2020 11:08:03 -0500 Date: Tue, 07 Jan 2020 18:08:13 +0200 Message-Id: <83muazckr6.fsf@gnu.org> From: Eli Zaretskii To: Alan Third In-reply-to: <20200107150320.GA76575@breton.holly.idiocy.org> (message from Alan Third on Tue, 7 Jan 2020 15:03:20 +0000) Subject: Re: bug#39000: Light frame after desktop-read on MacOS References: <20200107.121816.1973201462831337632.tak.kunihiro@gmail.com> <20200107150320.GA76575@breton.holly.idiocy.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39000 Cc: tak.kunihiro@gmail.com, 39000@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 7 Jan 2020 15:03:20 +0000 > From: Alan Third > Cc: 39000@debbugs.gnu.org > > I’m not sure if this is too big a change for emacs 27 at this stage, > as it’s not entirely fixing bugs, although I’d argue it’s completing a > feature that is incomplete in Emacs 26. Please make these changes on master, it's too risky for the release branch at this stage. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 13:45:50 2020 Received: (at 39000-done) by debbugs.gnu.org; 7 Jan 2020 18:45:50 +0000 Received: from localhost ([127.0.0.1]:49294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iotrS-0002Am-K1 for submit@debbugs.gnu.org; Tue, 07 Jan 2020 13:45:50 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:39619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iotrQ-0002AZ-Q6 for 39000-done@debbugs.gnu.org; Tue, 07 Jan 2020 13:45:49 -0500 Received: by mail-wr1-f53.google.com with SMTP id y11so609542wrt.6 for <39000-done@debbugs.gnu.org>; Tue, 07 Jan 2020 10:45:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=XIiee0qZjcgpUTYXT9JwJFr4n3NqGNILf6OcGgOQusw=; b=mThQ7HdvqPlEz4AJjEJcYnex2SGSqIA4FxC6AHeMS4k5u5WXTJCC/mIQYq1cqJ9b9H EJJDMGx821D86QFH/8qzU3isSaoeI1l4vBGWQKa1XuekOBJ9PB19TLocy9WHmibG5+t+ bVVTR4PyWBawF0T/CE+Z6SY1d7/b7u9rDqG2jj2HBtnPnzXH0AcVvqna1CP5j7xE0xN9 /7E/mbuUbkDNqEUBoUVletzPk2lEpcOO3UwHKnEkUQGrA/BvqS+PzT7m234T7SYJFsye NjvA0Bcj5T9E8AdNa0r0yhg3u9xUOclWmzuE7fmWsHXwQtIZ9xFOU+SrGAgiIuJmNp4F 9qAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=XIiee0qZjcgpUTYXT9JwJFr4n3NqGNILf6OcGgOQusw=; b=KTa2FJUH1kUT9MROV490MtBfzDuiVMZpb7Znh/GgLx1X1H0+fOb5fbAo1HgmfPHZgU +M9IA18mxPXXPyAu7X2uaKgrIl7kXWIcvZKxHA6puzqW4nrTFfDPfUq0/FQT68hGVva4 9Aw3y8IqR6DYwGLPL+F9fZ94EvEy8ajtbMYVMQnchrenT8M6iJmO4iTW0DRLxRANL616 AChpuGfxGo0C8veZ5MYTh7ghpQgaKSbcLY7NEC8GfyBn61qNBCIedRv4gDD9JfzzGFn5 dbD7qAEq1AZGOWK4khscjAhgm27e/+cWiz1CvDS8M5Xn+742Ax0rujUzq6FvwYFs8hs5 M69A== X-Gm-Message-State: APjAAAV8tIVzQ3cx28dl0CreVXlZ5VQSPq562MzSwcDqv72kEkkdy+Ud pV7XWtkhmGLa9bZ7XUEmctY= X-Google-Smtp-Source: APXvYqwfDaC0sRenKNKdEwiyQVeMsMs6N3CGNTHkyCyUGfAaaN4bekvV0JlUhu+RlgH5XocrquM6Lw== X-Received: by 2002:a5d:404b:: with SMTP id w11mr487405wrp.171.1578422742927; Tue, 07 Jan 2020 10:45:42 -0800 (PST) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-f4ff-a438-b689-36a4.holly.idiocy.org. [2001:8b0:3f8:8129:f4ff:a438:b689:36a4]) by smtp.gmail.com with ESMTPSA id m7sm837436wrr.40.2020.01.07.10.45.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 10:45:42 -0800 (PST) Date: Tue, 7 Jan 2020 18:45:39 +0000 From: Alan Third To: Eli Zaretskii Subject: Re: bug#39000: Light frame after desktop-read on MacOS Message-ID: <20200107184539.GA98337@breton.holly.idiocy.org> References: <20200107.121816.1973201462831337632.tak.kunihiro@gmail.com> <20200107150320.GA76575@breton.holly.idiocy.org> <83muazckr6.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <83muazckr6.fsf@gnu.org> X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 39000-done Cc: 39000-done@debbugs.gnu.org, tak.kunihiro@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Tue, Jan 07, 2020 at 06:08:13PM +0200, Eli Zaretskii wrote: > > Date: Tue, 7 Jan 2020 15:03:20 +0000 > > From: Alan Third > > Cc: 39000@debbugs.gnu.org > > > > I’m not sure if this is too big a change for emacs 27 at this stage, > > as it’s not entirely fixing bugs, although I’d argue it’s completing a > > feature that is incomplete in Emacs 26. > > Please make these changes on master, it's too risky for the release > branch at this stage. Thanks! I’ve pushed to master. Tak, you may have to overwrite any existing desktop files before it starts working. I’m not sure why. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 19:12:51 2020 Received: (at 39000) by debbugs.gnu.org; 8 Jan 2020 00:12:51 +0000 Received: from localhost ([127.0.0.1]:49606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioyxv-0002rr-AU for submit@debbugs.gnu.org; Tue, 07 Jan 2020 19:12:51 -0500 Received: from mail-pl1-f176.google.com ([209.85.214.176]:35520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioyxt-0002rY-GU for 39000@debbugs.gnu.org; Tue, 07 Jan 2020 19:12:50 -0500 Received: by mail-pl1-f176.google.com with SMTP id g6so366939plt.2 for <39000@debbugs.gnu.org>; Tue, 07 Jan 2020 16:12:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LaCy4/RVn3WxES+e8IgKVWmmQCPLd+z//SLAMRSSizs=; b=TUGoVHRYBVuVYLHO04vfgzN+UB1cZJ4afCF1lJab8aWvx95b8+0aMaz8LQUldWir80 /WMAolzMQ7c4WgQCHNfMAPxuB1WrstxATonpASMgIftVI/IvGcfHbCrI3yX2tpmVijr+ FnQRL+Wph8pJIA3iudjgMIWIBox8i4mK9e9TJnbXu0kguoJAPrBLQspiqIqsGJaCPwD/ AcAeLEYS6AKhN9SrugCChfe8eIewN/bhnAXfE1wtKnFA93FyTrl2UDBeWie78wj7sRWL ilWr3kh/y/Shu6BsaDAMDXe4J25TzBi2l2HHjmReJUBpKB0L0E/hrOifoMdL9jJVSSKD suWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LaCy4/RVn3WxES+e8IgKVWmmQCPLd+z//SLAMRSSizs=; b=AEJXXq12ZRQM+O77bTQCjkpYvbGtWfRfkuJWc+Ox3lXDKe881NmipDz7zgURCY+uMW iNAmqHo6WMCC5w2mGZJ/ADKu8wwjQXz2xo+NKdBmVfaxg2j3ENWMaqm28yjuSDe5dcAy uvfKo51Whvh8DueCxqUfZ0ws1OcxRKtuCuFCtANz5rf4Eocufx5k/TRUy64JFDBrRdjA qkh9SJjcrkCNi5ILgCwzEskVpITq3sSHlE3ddzKy5N6i5eNd2c+LTTCFcbNR7zriAFJX 9bDMqtlpBkpOOsgm6vEQTXtGUi9481434HfSqpDKsPH5FoXKNDwNhMXYX3v9QgPasYJV pVuQ== X-Gm-Message-State: APjAAAX4oZdMhoTeRVh1++4bU8R8bXmYLbETgXWgcUBYE0HZByJNboMW YGSaEufoyQjT/6ppAT4jl40= X-Google-Smtp-Source: APXvYqyisiE1bW7DSaH3CpqQ028ximtRW/CEY7Z2D1E1jkI03AVGtmTSB3E/nVijUhcucbfQEsq8Bw== X-Received: by 2002:a17:902:b785:: with SMTP id e5mr2432552pls.327.1578442363360; Tue, 07 Jan 2020 16:12:43 -0800 (PST) Received: from [192.168.1.53] (vesta.misasa.okayama-u.ac.jp. [150.46.48.154]) by smtp.gmail.com with ESMTPSA id u127sm735698pfc.95.2020.01.07.16.12.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2020 16:12:43 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: bug#39000: Light frame after desktop-read on MacOS From: Tak Kunihiro In-Reply-To: <20200107184539.GA98337@breton.holly.idiocy.org> Date: Wed, 8 Jan 2020 09:12:39 +0900 Content-Transfer-Encoding: quoted-printable Message-Id: <4A1EB95A-DAF8-4E5B-858E-681832FED9F9@gmail.com> References: <20200107.121816.1973201462831337632.tak.kunihiro@gmail.com> <20200107150320.GA76575@breton.holly.idiocy.org> <83muazckr6.fsf@gnu.org> <20200107184539.GA98337@breton.holly.idiocy.org> To: Alan Third X-Mailer: Apple Mail (2.3445.104.11) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39000 Cc: Eli Zaretskii , =?utf-8?B?5Zu95bqD5Y2T5Lmf?= , 39000@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dear Alan, I confirmed that on MacOS 10.14.6 under `Dark (Still)=E2=80=99 mode, $ emacs -Q M-x about-emacs GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin18.7.0, NS = appkit-1671.60 Version 10.14.6 (Build 18G2022)) of 2020-01-08 M-x desktop-save M-x desktop-read a dark frame remains to be dark frame. =20 Thank you for the fix. Tak From unknown Sat Sep 06 00:11:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 05 Feb 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator