GNU bug report logs - #39000
Light frame after desktop-read on MacOS

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39000 in the body.
You can then email your comments to 39000 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tak Kunihiro <tak.kunihiro <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: tak.kunihiro <at> gmail.com
Subject: Light frame after desktop-read on MacOS
Date: Tue, 07 Jan 2020 12:18:16 +0900 (JST)

Emacs 26.3 offers dark frames on MacOS 10.14.6 with `Dark (Still)'
mode.  However after the following operations,

 $ emacs -Q
 M-x about-emacs
 GNU Emacs 26.3 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G87))
 M-x desktop-save
 M-x desktop-read

a dark frame turns into light frame.  I think this is a bug.

Message #8 received at 39000 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Tak Kunihiro <tak.kunihiro <at> gmail.com>
Cc: 39000 <at> debbugs.gnu.org
Subject: Re: bug#39000: Light frame after desktop-read on MacOS
Date: Tue, 7 Jan 2020 15:03:20 +0000

[Message part 1 (text/plain, inline)]

On Tue, Jan 07, 2020 at 12:18:16PM +0900, Tak Kunihiro wrote:
> Emacs 26.3 offers dark frames on MacOS 10.14.6 with `Dark (Still)'
> mode.  However after the following operations,
> 
>  $ emacs -Q
>  M-x about-emacs
>  GNU Emacs 26.3 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G87))
>  M-x desktop-save
>  M-x desktop-read
> 
> a dark frame turns into light frame.  I think this is a bug.

I’ve attached a patch.

It also fixes a niggle I had in that you could force the frame to use
a dark theme, or an aqua theme, but not the system default even though
Emacs would launch with the system default. The documentation was also
wrong in that it described the light theme as the system default, even
though it may not have been.

I’m not sure if this is too big a change for emacs 27 at this stage,
as it’s not entirely fixing bugs, although I’d argue it’s completing a
feature that is incomplete in Emacs 26.
-- 
Alan Third

[0001-Fix-NS-frame-parameters-bug-39000.patch (text/plain, attachment)]

Message #11 received at 39000 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: tak.kunihiro <at> gmail.com, 39000 <at> debbugs.gnu.org
Subject: Re: bug#39000: Light frame after desktop-read on MacOS
Date: Tue, 07 Jan 2020 18:08:13 +0200

> Date: Tue, 7 Jan 2020 15:03:20 +0000
> From: Alan Third <alan <at> idiocy.org>
> Cc: 39000 <at> debbugs.gnu.org
> 
> I’m not sure if this is too big a change for emacs 27 at this stage,
> as it’s not entirely fixing bugs, although I’d argue it’s completing a
> feature that is incomplete in Emacs 26.

Please make these changes on master, it's too risky for the release
branch at this stage.

Thanks.

Message #16 received at 39000-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 39000-done <at> debbugs.gnu.org, tak.kunihiro <at> gmail.com
Subject: Re: bug#39000: Light frame after desktop-read on MacOS
Date: Tue, 7 Jan 2020 18:45:39 +0000

On Tue, Jan 07, 2020 at 06:08:13PM +0200, Eli Zaretskii wrote:
> > Date: Tue, 7 Jan 2020 15:03:20 +0000
> > From: Alan Third <alan <at> idiocy.org>
> > Cc: 39000 <at> debbugs.gnu.org
> > 
> > I’m not sure if this is too big a change for emacs 27 at this stage,
> > as it’s not entirely fixing bugs, although I’d argue it’s completing a
> > feature that is incomplete in Emacs 26.
> 
> Please make these changes on master, it's too risky for the release
> branch at this stage.

Thanks! I’ve pushed to master.

Tak, you may have to overwrite any existing desktop files before it
starts working. I’m not sure why.
-- 
Alan Third

Message #19 received at 39000 <at> debbugs.gnu.org (full text, mbox):

From: Tak Kunihiro <tak.kunihiro <at> gmail.com>
To: Alan Third <alan <at> idiocy.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>,
 国広卓也 <tak.kunihiro <at> gmail.com>, 39000 <at> debbugs.gnu.org
Subject: Re: bug#39000: Light frame after desktop-read on MacOS
Date: Wed, 8 Jan 2020 09:12:39 +0900

Dear Alan,

I confirmed that on MacOS 10.14.6 under `Dark (Still)’ mode,

 $ emacs -Q
 M-x about-emacs
 GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6
 (Build 18G2022)) of 2020-01-08
 M-x desktop-save
 M-x desktop-read

a dark frame remains to be dark frame.  
Thank you for the fix.

Tak

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.