Subject: Re: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep

From: João Távora <[email-masked]>
Date: Thu, 9 Jan 2020 10:10:54 +0000

On Thu, Jan 9, 2020 at 9:54 AM João Távora <[email-masked]> wrote:
>
> On Thu, Jan 9, 2020 at 7:49 AM <[email-masked]> wrote:
> >
> > Hi,
> >
> > icomplete on its own seems fine.
>
> ... or so with would seem :-)  But if the user customizes
> `icomplete-show-matches-on-no-input` to t, the problem is
> there again.
>
> fido-mode's ido-opinionated semantics automatically turn
> on that variable during fido-completion and that's why you
> get the error unconditionally in fido-mode.
>
> The error was introduced by me, anyway, in both modes,
> and the fix is simple.  It'll be in emacs-27 in a moment.

I've pushed the fix.  The problem was the non-string minibuffer-default
used by M-x rgrep.  Please retest.

João