Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep

From: Dmitry Gutov <[email-masked]>
Date: Fri, 31 Jan 2020 04:48:16 +0300

On 30.01.2020 0:23, Stefan Monnier wrote:
> Maybe it used to be that `minibuffer-completion-confirm` used to be set
> to something like (not (memq require-match '(nil t)))?

Not exactly. It was set to (not require-match), basically.

The last place that changed was commit 695deb1857d, almost 18 years ago 
by your hand.

> In any case, I do know it used to be that
> `minibuffer-completion-confirm` was only boolean.

Speaking of, there's this condition in icomplete-exhibit that computes 
the require-match argument of icomplete-completions as

   (if (window-minibuffer-p)
     (not minibuffer-completion-confirm))

but it only affects cosmetics. It seems wrong (to me) now, but it makes 
sense looking at the code before the aforementioned commit.