From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: waah@yellowfrog.io Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2020 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 38992@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15783327834340 (code B ref -1); Mon, 06 Jan 2020 17:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Jan 2020 17:46:23 +0000 Received: from localhost ([127.0.0.1]:46654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioWSM-00017v-4P for submit@debbugs.gnu.org; Mon, 06 Jan 2020 12:46:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:42852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioVsc-00007L-26 for submit@debbugs.gnu.org; Mon, 06 Jan 2020 12:09:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46230) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioVsa-0002OJ-N6 for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 12:09:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ioVsZ-0003A6-9T for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 12:09:24 -0500 Received: from mout-p-101.mailbox.org ([2001:67c:2050::465:101]:31050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ioVsZ-000309-0j for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 12:09:23 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 47s26Z4M3DzKmYM for ; Mon, 6 Jan 2020 18:09:10 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id ItvgST3Y4AlX for ; Mon, 6 Jan 2020 18:09:07 +0100 (CET) Date: Mon, 6 Jan 2020 17:09:06 +0000 (GMT) From: waah@yellowfrog.io Message-ID: <288610218.111246.1578330546916@office.mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:67c:2050::465:101 X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Mon, 06 Jan 2020 12:46:20 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --text follows this line-- start emacs via 'emacs -Q', enable fido-mode (via M-x), open file in git re= pository and run command vc-git-grep (again via M-x) error message is: Error in post-command-hook (icomplete-post-command-hook): (wrong-type-argument stringp ("*.F90" "all" "el" "ch" "c" "cc" "cchh" "hh" "h" "l" "m" "tex" "texi" "asm")) without fido-mode everything works as expected. In GNU Emacs 27.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version 2.24.31) of 2020-01-06 built on cloten Repository revision: 088bfcc2d80eed44864147f3491eff69e4eb5cd8 Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.11803000 System Description: openSUSE Leap 42.3 Recent messages: You can run the command =E2=80=98vc-git-grep=E2=80=99 with M-x v-gr RET Grep finished with 7 matches found Fido mode enabled Error in post-command-hook (icomplete-post-command-hook): (wrong-type-argum= ent stringp ("*.F90" "all" "el" "ch" "c" "cc" "cchh" "hh" "h" "l" "m" "tex"= "texi" "asm")) backward-delete-char: Text is read-only Grep finished with no matches found Quit Configured using: 'configure --with-gif=3Difavailable CC=3Dgcc' Configured features: XPM JPEG TIFF PNG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY GNUTLS LIBXML2 FREETYPE HARFBUZZ XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 XDBE XIM MODULES THREADS PDUMPER LCMS2 Important settings: value of $LC_COLLATE: POSIX value of $LC_CTYPE: en_GB.UTF-8 value of $LANG: en_GB.utf8 value of $XMODIFIERS: @im=3Dlocal locale-coding-system: utf-8-unix Major mode: Messages Minor modes in effect: icomplete-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny format-spec rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils mule-util tango-dark-theme eieio-opt cl-extra speedbar sb-image ezimage dframe find-func vc-annotate vc-dir ewoc vc vc-dispatcher vc-filewise help-fns radix-tree help-mode ffap url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map seq byte-opt gv bytecomp byte-compile cconv url-vars thingatpt grep compile comint ansi-color ring vc-git diff-mode easy-mmode f90 cus-edit easymenu wid-edit cl-loaddefs cl-lib misearch multi-isearch cus-start cus-load icomplete dired dired-loaddefs tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 106359 11893) (symbols 48 11215 1) (strings 32 33745 1223) (string-bytes 1 1021750) (vectors 16 16353) (vector-slots 8 197937 15512) (floats 8 63 313) (intervals 56 869 95) (buffers 1000 18) (heap 1024 16363 1478)) From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2020 03:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157854033311626 (code B ref 38992); Thu, 09 Jan 2020 03:26:02 +0000 Received: (at 38992) by debbugs.gnu.org; 9 Jan 2020 03:25:33 +0000 Received: from localhost ([127.0.0.1]:51682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipORx-00031S-B9 for submit@debbugs.gnu.org; Wed, 08 Jan 2020 22:25:33 -0500 Received: from mail-lj1-f169.google.com ([209.85.208.169]:34773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipORv-00031E-W3 for 38992@debbugs.gnu.org; Wed, 08 Jan 2020 22:25:33 -0500 Received: by mail-lj1-f169.google.com with SMTP id z22so5615911ljg.1 for <38992@debbugs.gnu.org>; Wed, 08 Jan 2020 19:25:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HSG3E3wh6TdDHCDJeciEfY2zMhLhBtcP7wrTmCiWLTY=; b=a+wy2FvIoR3oT363fWfITlM9xrhcyXelvX27Rws8OZ8tnA7uEjkK0KsLwELN+yuAjD 2wJ+eTHaX0bbHCDN59OJi5cOMJO8CYASYaNFCPkDeLhPaAUl73fa+isWLUHLojBm2d67 OpRfkS7F+URgofXPmct8s/LBPHj/NYpoULP63zkWA1vN5bFw1gnafMC4yBhIe267JHkR yfYVo4hKjQLLHRe69FbAa8Cs8ByWK4ch9ADywHAw6cnU+x5KVTCRCQ3MbUYGC39Rt7uR U9Gbs5upBXClu9fbgVRGENRQzAuUyHEytz+NoYf36ROQ7/HtjyxAG9/8cj9l2hpc9qcc yJiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HSG3E3wh6TdDHCDJeciEfY2zMhLhBtcP7wrTmCiWLTY=; b=FsgwIeVcx5WtJVpVXqpX8x3qD33dzBWMQ19xCKzYRBitAqKentsEU0SbsjSLdaufTI oUllNuDTCo5P427ZgkPnB1ZC4vO3pDQA/5KvThYbcaQyl6sjYKMqDoYNnd8VfMT4rVr9 l86xdRhn+GEifGR5oa2vO3BIzlG3rJPLDbfFOVzovReL08UIVV4CKWIqM3AZTYbu0ER1 rp/WcXaz7af5wnBI6KnzkbbU9hbf8FTwHQ2RV9zXxNC1eN4z4TaUYSqrkoJsi0AvtoLO 8UUlYB2txx83+X9IIg5O48ouhMhaEEJRKeeijomkK8OkRUxwWZX1SJARRayNTmSWNuBD Uv1g== X-Gm-Message-State: APjAAAX1wrPiu2sgxbbYb37bqDotgzqLD7QtYXqRnJd94BfRAo9H5vtI RQjXBFCb9l5irGgyP99CyXS1AOufEkE= X-Google-Smtp-Source: APXvYqyesfnUu/QSpTZUH/YdtmQ/Rv68GkueDmk6HYnFGh6RZT9SUV1E0y3/vEjgYYNx7T06kxkeWw== X-Received: by 2002:a2e:3609:: with SMTP id d9mr4814439lja.188.1578540325650; Wed, 08 Jan 2020 19:25:25 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id s18sm2450241ljj.36.2020.01.08.19.25.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jan 2020 19:25:24 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> From: Dmitry Gutov Message-ID: <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> Date: Thu, 9 Jan 2020 06:25:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <288610218.111246.1578330546916@office.mailbox.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 06.01.2020 19:09, > start emacs via 'emacs -Q', enable fido-mode (via M-x), open file in git repository and run command > vc-git-grep (again via M-x) Or just 'M-x rgrep'. > error message is: > > Error in post-command-hook (icomplete-post-command-hook): > (wrong-type-argument stringp ("*.F90" "all" "el" "ch" "c" "cc" "cchh" > "hh" "h" "l" "m" "tex" "texi" "asm")) Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: yellowfrog.io] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.169 listed in list.dnswl.org] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 06.01.2020 19:09, waah@yellowfrog.io wrote: > start emacs via 'emacs -Q', enable fido-mode (via M-x), open file in git repository and run command > vc-git-grep (again via M-x) Or just 'M-x rgrep'. > error message is: > > Error in post-command-hook (icomplete-post-command-hook): > (wrong-type-argument stringp ("*.F90" "all" "el" "ch" "c" "cc" "cchh" > "hh" "h" "l" "m" "tex" "texi" "asm")) Joao, could you take a look? From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2020 07:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15785557493857 (code B ref 38992); Thu, 09 Jan 2020 07:43:01 +0000 Received: (at 38992) by debbugs.gnu.org; 9 Jan 2020 07:42:29 +0000 Received: from localhost ([127.0.0.1]:51770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipSSb-000109-GH for submit@debbugs.gnu.org; Thu, 09 Jan 2020 02:42:29 -0500 Received: from mail-io1-f53.google.com ([209.85.166.53]:46094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipSSZ-0000zw-TT for 38992@debbugs.gnu.org; Thu, 09 Jan 2020 02:42:28 -0500 Received: by mail-io1-f53.google.com with SMTP id t26so6034277ioi.13 for <38992@debbugs.gnu.org>; Wed, 08 Jan 2020 23:42:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d7f33HmooHUMllYrEZ8pyQkS05GBvEs1XRs/jw3c+QA=; b=app2NUhRYzUWPaAIKhkmA/J4g6/kPEeDqOLxF2zonuc171MrHTBVUV/jxOtK09Qn9b WbbM7e10iQ73FIBKKqowP+TkjBZ/haNbjIiJNRzo82YS8o4xBasFV1OtQvSmbr7WCOUU H14E0d3H3Xjzhy/mMXdBT41sg6UtB6j1jPz037JfAe4E+kQOBEyfknl/c0WJNdIgnrJq N7qe+xvZ9VN0vYR7UC8u3LGkd2UOAjZ+9va2PjBEpxPvCuoq5YRvrX0/z9M+ptRFSG5W Y+1b4VGloZaKl1JilM32dV0FMiYwLINoq4zM+oq5HhZQfTLhQJFywkAkqxM18Pe1zzCg +jgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d7f33HmooHUMllYrEZ8pyQkS05GBvEs1XRs/jw3c+QA=; b=Q59J2Bk43eZ8kJaF5PslJQeRrl6bKY/0kAiUnlMnzc6T9UNZIQ0oo3swWhqpHc37LF unuRJvuY5X3oCQ475h2uPu8rxFlLLzMf6JYjzZFKEt+lJxauIosBQgJFgb0pzs10xwND /Fjarj/kpLeauQvFv4QOYwNz4SRmDvz3dJZjZQ4QMfEV/cyck0cAGf3IUoFdH4675AtC G1fp22lunWYwWXBEbtxTZTd2augJ7vwuUQ6KwkGpmTI7HxuiKSKW4qD3Gga2d2pIxL/f ThSQ+LF9D0p0oFmakA+JjA0cJsdKi5/XwOe0S0TWOGAGSEeJXYxBI5eUdnnbdnNarq6l xW4A== X-Gm-Message-State: APjAAAVgu+zt0Mdaz2bfo6IIrocDevLXriEEIVSGuvJU7kB6thQR8HKc 1pVe/M7f/g47BMfn9QxYYRBK/3MuOVFUjVi09cY= X-Google-Smtp-Source: APXvYqxoTGFLcNGFeb+W3xZ8YPsE9trZL+4l3attfLy8Z+atgBOhBNDr66fSs+y9yDiQ2e8lk1uueCv4BTnniy8Evt0= X-Received: by 2002:a5d:9f05:: with SMTP id q5mr6607980iot.199.1578555742283; Wed, 08 Jan 2020 23:42:22 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> In-Reply-To: <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 9 Jan 2020 07:42:10 +0000 Message-ID: Content-Type: multipart/alternative; boundary="00000000000046ee8f059bb0265d" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000046ee8f059bb0265d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Dmitry, Very extremely busy at the moment, but I recognize the seriousness of this. Is this strictly fido-mode related? Or also incomplete-mode? Nevertheless, I will try to take a look. Jo=C3=A3o On Thu, Jan 9, 2020, 03:25 Dmitry Gutov wrote: > On 06.01.2020 19:09, waah@yellowfrog.io wrote: > > start emacs via 'emacs -Q', enable fido-mode (via M-x), open file in gi= t > repository and run command > > vc-git-grep (again via M-x) > > Or just 'M-x rgrep'. > > > error message is: > > > > Error in post-command-hook (icomplete-post-command-hook): > > (wrong-type-argument stringp ("*.F90" "all" "el" "ch" "c" "cc" "cchh" > > "hh" "h" "l" "m" "tex" "texi" "asm")) > > Joao, could you take a look? > --00000000000046ee8f059bb0265d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dmitry,

V= ery extremely busy at the moment, but I recognize the seriousness of this. = Is this strictly fido-mode related? Or also incomplete-mode?

Nevertheless, I will try to take a lo= ok.

Jo=C3=A3o

On Th= u, Jan 9, 2020, 03:25 Dmitry Gutov <dgutov@yandex.ru> wrote:
On 06.01.2020 19:09, waah@yell= owfrog.io wrote:
> start emacs via 'emacs -Q', enable fido-mode (via M-x), open f= ile in git repository and run command
> vc-git-grep (again via M-x)

Or just 'M-x rgrep'.

> error message is:
>
> Error in post-command-hook (icomplete-post-command-hook):
> (wrong-type-argument stringp ("*.F90" "all" "= el" "ch" "c" "cc" "cchh"
> "hh" "h" "l" "m" "tex&quo= t; "texi" "asm"))

Joao, could you take a look?
--00000000000046ee8f059bb0265d-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2020 09:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: waah@yellowfrog.io Cc: 38992@debbugs.gnu.org, Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157856367216907 (code B ref 38992); Thu, 09 Jan 2020 09:55:02 +0000 Received: (at 38992) by debbugs.gnu.org; 9 Jan 2020 09:54:32 +0000 Received: from localhost ([127.0.0.1]:51812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipUWO-0004Oc-EA for submit@debbugs.gnu.org; Thu, 09 Jan 2020 04:54:32 -0500 Received: from mail-il1-f181.google.com ([209.85.166.181]:46442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipUWM-0004OQ-KT for 38992@debbugs.gnu.org; Thu, 09 Jan 2020 04:54:31 -0500 Received: by mail-il1-f181.google.com with SMTP id t17so5170717ilm.13 for <38992@debbugs.gnu.org>; Thu, 09 Jan 2020 01:54:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qDG9z/Jx0UyQ5OjDmdQv1EV8UKSFD5ajy3O61Y0IMQQ=; b=fYcfcyuh/QupBj60q9MdqNh8Y3D3LT4BgdjfwTr/IkfexS+YyvCCVWIOGJOX3e9mmn l35SfC3264MBiJuyz6cgjzQ15K8+fyKD7TnvwsUkKTjQBGDRJgaX3R4xDYCyaOj7YqSL xF4Mf3MkubAH1OIljRsyJXJEmhMvoDrrtQZSE18H15wKxGfpgtqPLBojpcW5JHJwMGxC mcTZ8A4jj26KRMdJ+xuKnPUJJgI4AdiIZnvHH7MnA4emaiS6YfKDk26T2rhJQ4TPht5C lGRvlM/1iMWQaY3Gp9I/ad4Ah5I9b4cEEeHZJYekDonihvNLSTQkeFf/IQyNXPOOlzMu 8hVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qDG9z/Jx0UyQ5OjDmdQv1EV8UKSFD5ajy3O61Y0IMQQ=; b=OMMa65BBiuTFzKAWQJe3XFRF84+NVwG+v5Uihav9wUH+CxGx3J2NVNtcFd3mH+WcSj SRXZI6Fb50ITlL42KlDL8LEueHozm1j5BBvZPg/k028/Ij+a+eKNX3GO452XxqQsEAbS bc7RgYUqsSoKHiMhROQu8cz8eGYDdYhNR3WMj5+iwCdVIN9qQnMIhnSCYORuB1FDRGDe M/dPk7AiFlmpD+SlrtI/UxHU03R2eMCN+b7gnB9DTa9TD2gbSVIHz+C9X00aHb3mFMC9 gzPfbpA9mSznO8aCGsFc3tMVx7rgfmOcdtO+6l4o5USFc/8MRS14xNAfNeSOWqVUWvKF wWMg== X-Gm-Message-State: APjAAAXCs4vPj8ELA7OsNgw5QR8nRVCE+wAQfGYH7gJLE56bnrNlOsWA z7E3ZIfSyIewWvgPALSuCvslUUqUT1UJpWxUFM8= X-Google-Smtp-Source: APXvYqwWz6V8CPya7MfvdKRhl5l9ym7RsHdpiRw2RSUYnKglFm6vYYra6p/K3P3M9LPtVY0jEXu6MMhTTBeCMgXvbrs= X-Received: by 2002:a92:8f46:: with SMTP id j67mr7783118ild.125.1578563665059; Thu, 09 Jan 2020 01:54:25 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> In-Reply-To: <780526337.114357.1578556168662@office.mailbox.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 9 Jan 2020 09:54:13 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Jan 9, 2020 at 7:49 AM wrote: > > Hi, > > icomplete on its own seems fine. ... or so with would seem :-) But if the user customizes `icomplete-show-matches-on-no-input` to t, the problem is there again. fido-mode's ido-opinionated semantics automatically turn on that variable during fido-completion and that's why you get the error unconditionally in fido-mode. The error was introduced by me, anyway, in both modes, and the fix is simple. It'll be in emacs-27 in a moment. Jo=C3=A3o From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: waah@yellowfrog.io Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2020 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Dmitry Gutov Cc: 38992@debbugs.gnu.org Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157856379417111 (code B ref 38992); Thu, 09 Jan 2020 09:57:02 +0000 Received: (at 38992) by debbugs.gnu.org; 9 Jan 2020 09:56:34 +0000 Received: from localhost ([127.0.0.1]:51817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipUYM-0004Rp-4u for submit@debbugs.gnu.org; Thu, 09 Jan 2020 04:56:34 -0500 Received: from mout-p-202.mailbox.org ([80.241.56.172]:61876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipSZZ-0001B0-Vz for 38992@debbugs.gnu.org; Thu, 09 Jan 2020 02:49:42 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 47tdYW36KYzQlDR; Thu, 9 Jan 2020 08:49:35 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id gGoJj0pQBvDQ; Thu, 9 Jan 2020 08:49:29 +0100 (CET) Date: Thu, 9 Jan 2020 07:49:28 +0000 (GMT) From: waah@yellowfrog.io Message-ID: <780526337.114357.1578556168662@office.mailbox.org> In-Reply-To: References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Thu, 09 Jan 2020 04:56:33 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, icomplete on its own seems fine. Thanks! > On 09 January 2020 at 07:42 Jo=C3=A3o T=C3=A1vora = wrote: >=20 >=20 > Hi Dmitry, >=20 > Very extremely busy at the moment, but I recognize the seriousness of thi= s. > Is this strictly fido-mode related? Or also incomplete-mode? >=20 > Nevertheless, I will try to take a look. >=20 > Jo=C3=A3o >=20 > On Thu, Jan 9, 2020, 03:25 Dmitry Gutov wrote: >=20 > > On 06.01.2020 19:09, waah@yellowfrog.io wrote: > > > start emacs via 'emacs -Q', enable fido-mode (via M-x), open file in = git > > repository and run command > > > vc-git-grep (again via M-x) > > > > Or just 'M-x rgrep'. > > > > > error message is: > > > > > > Error in post-command-hook (icomplete-post-command-hook): > > > (wrong-type-argument stringp ("*.F90" "all" "el" "ch" "c" "cc" "cchh" > > > "hh" "h" "l" "m" "tex" "texi" "asm")) > > > > Joao, could you take a look? > > From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2020 10:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: waah@yellowfrog.io, 38992-done@debbugs.gnu.org Cc: 38992@debbugs.gnu.org, Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157856467418559 (code B ref 38992); Thu, 09 Jan 2020 10:12:01 +0000 Received: (at 38992) by debbugs.gnu.org; 9 Jan 2020 10:11:14 +0000 Received: from localhost ([127.0.0.1]:51839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipUmY-0004pB-61 for submit@debbugs.gnu.org; Thu, 09 Jan 2020 05:11:14 -0500 Received: from mail-io1-f41.google.com ([209.85.166.41]:39033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipUmV-0004ot-Ll; Thu, 09 Jan 2020 05:11:12 -0500 Received: by mail-io1-f41.google.com with SMTP id c16so6500834ioh.6; Thu, 09 Jan 2020 02:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kwjJrV2CkuyuKKE/S3SwMMisSM4fEYo2hCK8ycaF60Y=; b=smkrpSP0hta3oe3hGg6bajUXKXGVkvIqHiTqtNuLB/I5J4ZrLLNlHQSB4yyAFhqvdD s5iwkNRT2tRRM8zfN03A5L8dDplo0H/vwx87XgM8jFxxSE6ScJbw/7F/GYNoIjSKl095 FgTBfsOkFnL5ofePGyq0nsxda7k/3LFjJp+8chNUjj1o2U31CiW6FjqWJPHMfBi/VwoY I4vxIfhbf6cE0V/2FykUwb8xlgBReMaKsdP3VM3pj/HSBa8Ji+DTTLOSX0fexaayS196 PPQD5Dj9mp9z8TU2DEuMHFPzk/aNyp6fkp1c4N7hdbZ02ksatEdK93jNM8xSeYaa1PEb 6oxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kwjJrV2CkuyuKKE/S3SwMMisSM4fEYo2hCK8ycaF60Y=; b=uXmgOKK1c/OlLzozV5amQ8iA084AFl9njkdur8rmPSD/xqia+r90LEEYxp/XF+MFNB 8VeHqP/l6Azv7FgKKM0QHIk56oxkSNusLmZWi4lmKbrqA1MYpo0XHRmrd2dvSK5XXB7O Zhy0dGkQ/v/ZrMMFSfQr7Z39N99DYzEWV9EjpCvptnNYv19CZwQGpLsKj/+N+uBgw/Gj /GcPRXLF9USSEHLBLQ2a8XtiU5G9wWp2umY1sidE1/8cileV1azB/OwQEsqZeH3wq2kv 2AuySLH//k7cDenwCs1TpfYkflTma25s8Ouu59doiw/34dnUeIZ0FVMrC9PqwLLSymDF GleA== X-Gm-Message-State: APjAAAWqBtKWVU9GaCQ1Hm+gLEYRg0etDqSrJtN/owEPcMuux39lVo5q GGEzCEiaPa8bxXzPYwVc1AMUjajjCqRXurq08nc= X-Google-Smtp-Source: APXvYqy6DTiefkKz+hFLOmTOll5xMeIRbgr9jpL8VU+GWUbbdIGu7iXjpgYZrss8+ZudgWkfhfaqd1YGjmBks/eVol8= X-Received: by 2002:a6b:f214:: with SMTP id q20mr7385145ioh.137.1578564666108; Thu, 09 Jan 2020 02:11:06 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 9 Jan 2020 10:10:54 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Jan 9, 2020 at 9:54 AM Jo=C3=A3o T=C3=A1vora = wrote: > > On Thu, Jan 9, 2020 at 7:49 AM wrote: > > > > Hi, > > > > icomplete on its own seems fine. > > ... or so with would seem :-) But if the user customizes > `icomplete-show-matches-on-no-input` to t, the problem is > there again. > > fido-mode's ido-opinionated semantics automatically turn > on that variable during fido-completion and that's why you > get the error unconditionally in fido-mode. > > The error was introduced by me, anyway, in both modes, > and the fix is simple. It'll be in emacs-27 in a moment. I've pushed the fix. The problem was the non-string minibuffer-default used by M-x rgrep. Please retest. Jo=C3=A3o From unknown Sat Jun 21 10:44:21 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: waah@yellowfrog.io Subject: bug#38992: closed (Re: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep) Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> X-Gnu-PR-Message: they-closed 38992 X-Gnu-PR-Package: emacs Reply-To: 38992@debbugs.gnu.org Date: Thu, 09 Jan 2020 10:12:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1578564722-18633-1" This is a multi-part message in MIME format... ------------=_1578564722-18633-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 38992@debbugs.gnu.org. --=20 38992: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D38992 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1578564722-18633-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 38992-done) by debbugs.gnu.org; 9 Jan 2020 10:11:14 +0000 Received: from localhost ([127.0.0.1]:51837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipUmX-0004p9-Si for submit@debbugs.gnu.org; Thu, 09 Jan 2020 05:11:14 -0500 Received: from mail-io1-f41.google.com ([209.85.166.41]:39033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipUmV-0004ot-Ll; Thu, 09 Jan 2020 05:11:12 -0500 Received: by mail-io1-f41.google.com with SMTP id c16so6500834ioh.6; Thu, 09 Jan 2020 02:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kwjJrV2CkuyuKKE/S3SwMMisSM4fEYo2hCK8ycaF60Y=; b=smkrpSP0hta3oe3hGg6bajUXKXGVkvIqHiTqtNuLB/I5J4ZrLLNlHQSB4yyAFhqvdD s5iwkNRT2tRRM8zfN03A5L8dDplo0H/vwx87XgM8jFxxSE6ScJbw/7F/GYNoIjSKl095 FgTBfsOkFnL5ofePGyq0nsxda7k/3LFjJp+8chNUjj1o2U31CiW6FjqWJPHMfBi/VwoY I4vxIfhbf6cE0V/2FykUwb8xlgBReMaKsdP3VM3pj/HSBa8Ji+DTTLOSX0fexaayS196 PPQD5Dj9mp9z8TU2DEuMHFPzk/aNyp6fkp1c4N7hdbZ02ksatEdK93jNM8xSeYaa1PEb 6oxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kwjJrV2CkuyuKKE/S3SwMMisSM4fEYo2hCK8ycaF60Y=; b=uXmgOKK1c/OlLzozV5amQ8iA084AFl9njkdur8rmPSD/xqia+r90LEEYxp/XF+MFNB 8VeHqP/l6Azv7FgKKM0QHIk56oxkSNusLmZWi4lmKbrqA1MYpo0XHRmrd2dvSK5XXB7O Zhy0dGkQ/v/ZrMMFSfQr7Z39N99DYzEWV9EjpCvptnNYv19CZwQGpLsKj/+N+uBgw/Gj /GcPRXLF9USSEHLBLQ2a8XtiU5G9wWp2umY1sidE1/8cileV1azB/OwQEsqZeH3wq2kv 2AuySLH//k7cDenwCs1TpfYkflTma25s8Ouu59doiw/34dnUeIZ0FVMrC9PqwLLSymDF GleA== X-Gm-Message-State: APjAAAWqBtKWVU9GaCQ1Hm+gLEYRg0etDqSrJtN/owEPcMuux39lVo5q GGEzCEiaPa8bxXzPYwVc1AMUjajjCqRXurq08nc= X-Google-Smtp-Source: APXvYqy6DTiefkKz+hFLOmTOll5xMeIRbgr9jpL8VU+GWUbbdIGu7iXjpgYZrss8+ZudgWkfhfaqd1YGjmBks/eVol8= X-Received: by 2002:a6b:f214:: with SMTP id q20mr7385145ioh.137.1578564666108; Thu, 09 Jan 2020 02:11:06 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Thu, 9 Jan 2020 10:10:54 +0000 Message-ID: Subject: Re: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep To: waah@yellowfrog.io, 38992-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38992-done Cc: 38992@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Jan 9, 2020 at 9:54 AM Jo=C3=A3o T=C3=A1vora = wrote: > > On Thu, Jan 9, 2020 at 7:49 AM wrote: > > > > Hi, > > > > icomplete on its own seems fine. > > ... or so with would seem :-) But if the user customizes > `icomplete-show-matches-on-no-input` to t, the problem is > there again. > > fido-mode's ido-opinionated semantics automatically turn > on that variable during fido-completion and that's why you > get the error unconditionally in fido-mode. > > The error was introduced by me, anyway, in both modes, > and the fix is simple. It'll be in emacs-27 in a moment. I've pushed the fix. The problem was the non-string minibuffer-default used by M-x rgrep. Please retest. Jo=C3=A3o ------------=_1578564722-18633-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Jan 2020 17:46:23 +0000 Received: from localhost ([127.0.0.1]:46654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioWSM-00017v-4P for submit@debbugs.gnu.org; Mon, 06 Jan 2020 12:46:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:42852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioVsc-00007L-26 for submit@debbugs.gnu.org; Mon, 06 Jan 2020 12:09:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46230) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioVsa-0002OJ-N6 for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 12:09:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ioVsZ-0003A6-9T for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 12:09:24 -0500 Received: from mout-p-101.mailbox.org ([2001:67c:2050::465:101]:31050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ioVsZ-000309-0j for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2020 12:09:23 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 47s26Z4M3DzKmYM for ; Mon, 6 Jan 2020 18:09:10 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id ItvgST3Y4AlX for ; Mon, 6 Jan 2020 18:09:07 +0100 (CET) Date: Mon, 6 Jan 2020 17:09:06 +0000 (GMT) From: waah@yellowfrog.io To: bug-gnu-emacs@gnu.org Message-ID: <288610218.111246.1578330546916@office.mailbox.org> Subject: 27.0.60; when enabled, fido-mode seems to break vc-git-grep MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:67c:2050::465:101 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 06 Jan 2020 12:46:20 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --text follows this line-- start emacs via 'emacs -Q', enable fido-mode (via M-x), open file in git re= pository and run command vc-git-grep (again via M-x) error message is: Error in post-command-hook (icomplete-post-command-hook): (wrong-type-argument stringp ("*.F90" "all" "el" "ch" "c" "cc" "cchh" "hh" "h" "l" "m" "tex" "texi" "asm")) without fido-mode everything works as expected. In GNU Emacs 27.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version 2.24.31) of 2020-01-06 built on cloten Repository revision: 088bfcc2d80eed44864147f3491eff69e4eb5cd8 Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.11803000 System Description: openSUSE Leap 42.3 Recent messages: You can run the command =E2=80=98vc-git-grep=E2=80=99 with M-x v-gr RET Grep finished with 7 matches found Fido mode enabled Error in post-command-hook (icomplete-post-command-hook): (wrong-type-argum= ent stringp ("*.F90" "all" "el" "ch" "c" "cc" "cchh" "hh" "h" "l" "m" "tex"= "texi" "asm")) backward-delete-char: Text is read-only Grep finished with no matches found Quit Configured using: 'configure --with-gif=3Difavailable CC=3Dgcc' Configured features: XPM JPEG TIFF PNG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY GNUTLS LIBXML2 FREETYPE HARFBUZZ XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 XDBE XIM MODULES THREADS PDUMPER LCMS2 Important settings: value of $LC_COLLATE: POSIX value of $LC_CTYPE: en_GB.UTF-8 value of $LANG: en_GB.utf8 value of $XMODIFIERS: @im=3Dlocal locale-coding-system: utf-8-unix Major mode: Messages Minor modes in effect: icomplete-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny format-spec rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils mule-util tango-dark-theme eieio-opt cl-extra speedbar sb-image ezimage dframe find-func vc-annotate vc-dir ewoc vc vc-dispatcher vc-filewise help-fns radix-tree help-mode ffap url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map seq byte-opt gv bytecomp byte-compile cconv url-vars thingatpt grep compile comint ansi-color ring vc-git diff-mode easy-mmode f90 cus-edit easymenu wid-edit cl-loaddefs cl-lib misearch multi-isearch cus-start cus-load icomplete dired dired-loaddefs tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 106359 11893) (symbols 48 11215 1) (strings 32 33745 1223) (string-bytes 1 1021750) (vectors 16 16353) (vector-slots 8 197937 15512) (floats 8 63 313) (intervals 56 869 95) (buffers 1000 18) (heap 1024 16363 1478)) ------------=_1578564722-18633-1-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2020 22:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: waah@yellowfrog.io, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 38992@debbugs.gnu.org Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157860886625793 (code B ref 38992); Thu, 09 Jan 2020 22:28:01 +0000 Received: (at 38992) by debbugs.gnu.org; 9 Jan 2020 22:27:46 +0000 Received: from localhost ([127.0.0.1]:53254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipgHK-0006hx-Gl for submit@debbugs.gnu.org; Thu, 09 Jan 2020 17:27:46 -0500 Received: from mail-lf1-f45.google.com ([209.85.167.45]:34700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipgHI-0006hi-6U for 38992@debbugs.gnu.org; Thu, 09 Jan 2020 17:27:44 -0500 Received: by mail-lf1-f45.google.com with SMTP id l18so6454924lfc.1 for <38992@debbugs.gnu.org>; Thu, 09 Jan 2020 14:27:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hHK06pv3DeUYu8LdKsCNJ1by3fOBw6jzjSohO3pBPug=; b=nZJLxOrPYsq34p1EH3kuGJ7aBN/KZGklwAX00cKkR2U0MOpUckuj0u2VaNACWQx+d3 CXhHsuGkao4wHjdlZxryzT9T+hYGHl3EK1aO8RW0Y5cJ4sQUsjYczgDeyKmwrrDivnZk YCYm/c0267fqyglHz+B+cyL+6upJdOq0yKq1ffQPKW2J5yYTJFhlgJB1WYIW+SDZfZSw B+iGq8wELx+BKP3Qo3bzBem4TOB85eaXSJKhCp7TY3K5joC4QXLgg/4RoPDLzMMGemoX rtcdRxkjKZKLpZg7VGcxQHVThc20zaF4pUJL7BYUHjs254Tm3MlIwiYjZphyKD78/UJA uJdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hHK06pv3DeUYu8LdKsCNJ1by3fOBw6jzjSohO3pBPug=; b=p6L8FM+m3powzo7N8a7PoNgqhoOnFq7xhL8iBN5Ja1vGmJQVEs0KKAUAD1/tcn7NfK T4Kx9mbUC23JkKuAEQ88bnEKiTB8rH1/0hySL7o5QHxOxR3N+fuRuYY/OmjYr/csy2CO Nf/vMHeM1z7w9OwftAlv3ymZEPF2qSnAnXErsze+YJGbs7NEUpvG2dAVPHpvE5faLBbO itA3q5aKPJbMNnKs9jJpCjlMIZLpDve26caXEgtbYpQy7eMumPB6UzlQ7JaQnXbd61k3 eAk4u6Tl5xtpBsZJ/LfhN3MNoGz7DI6tQnTgk+EO3ITabCTbgOWdRoBSBLBt5uk8nrVF bWNQ== X-Gm-Message-State: APjAAAXzAeMl7WYPhUnjbFbhVC10z2lVwgbJQ0mk+m2sMtP/vUDvGvxV LUiHzy5WOKQR8BbejX2ma845Ga/cDzA= X-Google-Smtp-Source: APXvYqz4TO39uSsvl21D4zpgOLM0ds84KraeV/mE9Lzv0bPfywfe7M8uSwAkkFxfbTxaJwbvUZim5A== X-Received: by 2002:ac2:46c2:: with SMTP id p2mr17785lfo.139.1578608857831; Thu, 09 Jan 2020 14:27:37 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id z22sm8206ljm.24.2020.01.09.14.27.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Jan 2020 14:27:36 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> From: Dmitry Gutov Message-ID: <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> Date: Fri, 10 Jan 2020 01:27:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <944631362.128066.1578605073103@office.mailbox.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 09.01.2020 23:24, > Hi, sorry me again. Hi! Please keep the bug address in Cc. > Thanks for looking into this! I tried and the error message goes away. I still encounter a problem: once rgrep asks for the file extensions, icomplete accepts any input that is not in the completion [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.45 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: yellowfrog.io] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 09.01.2020 23:24, waah@yellowfrog.io wrote: > Hi, sorry me again. Hi! Please keep the bug address in Cc. > Thanks for looking into this! I tried and the error message goes away. I still encounter a problem: once rgrep asks for the file extensions, icomplete accepts any input that is not in the completion list (e.g. abcdf*.sdf or simply the default) but fido says "incomplete" and does not allow to proceed unless I select a directory / file from the completion list (which does not really make sense; C-f to change to the default prompt like with ido in find file does not work). This might be an error on my side though not knowing the right shortcut - I am still new to ido / fido (sorry!). To clarify (for Joao), we see "Incomplete" when trying to input a wildcard that's not in the suggested completions list. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jan 2020 10:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157865105430305 (code B ref 38992); Fri, 10 Jan 2020 10:11:01 +0000 Received: (at 38992) by debbugs.gnu.org; 10 Jan 2020 10:10:54 +0000 Received: from localhost ([127.0.0.1]:53677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iprFm-0007sj-7O for submit@debbugs.gnu.org; Fri, 10 Jan 2020 05:10:54 -0500 Received: from mail-io1-f50.google.com ([209.85.166.50]:37632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iprFk-0007sV-Q4 for 38992@debbugs.gnu.org; Fri, 10 Jan 2020 05:10:53 -0500 Received: by mail-io1-f50.google.com with SMTP id k24so1483004ioc.4 for <38992@debbugs.gnu.org>; Fri, 10 Jan 2020 02:10:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=HEwjHJgDT11YEJfsOD2t4W53eeco99skS8jLF7N1VP0=; b=nmMSGy/9wmtdcIFuqMrq2mu3k5uaDuNtl85HmD4M8xOuxdGs9xJAFvns092S5Tofpt AXZldY7w2Y37Y4Z5KKAFLWItg65r/43L9R1hYTn8Hd8AgvpLNR14pgOn+qjyKWWndqoM hD2jmODfg+A2eudU37llO3fHiGzzFXkPL9uoB/ob/eP48FibXTbELy3hknJ34GSXYIcE pv61JNWyMcvCDbsYfGeGIp5J934Lr2SKlwKJthBDJq0EVOxk4LlQLl/BsUL1mOuaTOIg 8lKTtCLPrZ/W1deHNOHptY4JZoI/Q5WEumhgBo0V8eozfs9/MRIZit7BCkBfff5xA6Vx bhlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HEwjHJgDT11YEJfsOD2t4W53eeco99skS8jLF7N1VP0=; b=gMAMkRtktFuLusxYF40mno6qHXP3sZRdBJwd18Kj8bnLOwXtbZlVC9Cxniu3dfl4U7 dCo6ojqrRJ6O8YJ50kubSXt37KFVzYbz6hnyplHweOcf0XB1Bg2w5Wt3kAX3HS1O/XoH SndK37RsziI3hwKYp5CvdmKJ9/DnXP88wWTwjvB8yv8xJrF2v0j+S7VwYLaZmEKKspQY aPeCa8Pas0vIjmLcA01eyuCRfluTqAOb6yE9SJ4Bz8mPPYeJuYzKvIb/FjPNdkPdEbYd 7zPzckBwiq2xpgMwlufKvm79UKreetlKwFPoTq5U7bjvl3UZKZRSG3ZjIpKo6SqBtpKT 4Djw== X-Gm-Message-State: APjAAAXEkEe5BstRwmqiFc/oSwgUPTBnqohE8gAu3J6jcdI0MTSAWlaA D1ejFJlzSbz3cCdQuwdJxz5u4QBTkda+RnPzaZU= X-Google-Smtp-Source: APXvYqwfArSsnhSXPb1P8LjG4Xg8w483MqWMc6JCyLz8cW3dqxVtZnRbaV4AuMbeN/SM1fxO03LMjfliDlKDfCzj6CE= X-Received: by 2002:a02:2446:: with SMTP id q6mr2121709jae.78.1578651046981; Fri, 10 Jan 2020 02:10:46 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> In-Reply-To: <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Fri, 10 Jan 2020 10:10:35 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Jan 9, 2020 at 10:27 PM Dmitry Gutov wrote: > > On 09.01.2020 23:24, waah@yellowfrog.io wrote: > > Hi, sorry me again. > > Hi! Please keep the bug address in Cc. > > > Thanks for looking into this! I tried and the error message goes away. = I still encounter a problem: once rgrep asks for the file extensions, icomp= lete accepts any input that is not in the completion list (e.g. abcdf*.sdf = or simply the default) but fido says "incomplete" and does not allo= w to proceed unless I select a directory / file from the completion list (w= hich does not really make sense; C-f to change to the default prompt like w= ith ido in find file does not work). This might be an error on my side thou= gh not knowing the right shortcut - I am still new to ido / fido (sorry!). > > To clarify (for Joao), we see "Incomplete" when trying to input a > wildcard that's not in the suggested completions list. I haven't checked, but that's when pressing RET, right? Well that's a tougher thing to address potentially, because the problem might lie in how we call completing-read. The meaning of RET in fido-mode is different than in icomplete-mode. And different from ido-mode. It's, well, fido-mode's meaning, which is somewhere in between icomplete and ido-mode. But fido-mode provides M-j (bound to exit-minibuffer) for these cases. ido-mode had problems in this regard to, which it dealt with by sometimes allowing to exit the main interface with C-f or sth like that. And sometimes it had some bad solutions, which is part of the reaoso it didn't work perfectly as an all-around completion system. Again, if the suppositions where I based this quick analysis are not mistaken, I think this is the matter of a discussion over at emacs-devel. That is _unless_ you found a regression in icomplete-mode. In that case it's a bog-standard bug to be fixed. Jo=C3=A3o From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: waah@yellowfrog.io Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jan 2020 11:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Dmitry Gutov Cc: 38992@debbugs.gnu.org Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15786553834461 (code B ref 38992); Fri, 10 Jan 2020 11:24:02 +0000 Received: (at 38992) by debbugs.gnu.org; 10 Jan 2020 11:23:03 +0000 Received: from localhost ([127.0.0.1]:53712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipsNa-00019t-SJ for submit@debbugs.gnu.org; Fri, 10 Jan 2020 06:23:03 -0500 Received: from mout-p-102.mailbox.org ([80.241.56.152]:9356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipsNY-00019B-MD for 38992@debbugs.gnu.org; Fri, 10 Jan 2020 06:23:01 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 47vLFB2qMDzKmbN; Fri, 10 Jan 2020 12:22:54 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter02.heinlein-hosting.de (spamfilter02.heinlein-hosting.de [80.241.56.116]) (amavisd-new, port 10030) with ESMTP id BgbYTAM4DX28; Fri, 10 Jan 2020 12:22:51 +0100 (CET) Date: Fri, 10 Jan 2020 11:22:50 +0000 (GMT) From: waah@yellowfrog.io Message-ID: <976084359.504737.1578655371112@office.mailbox.org> In-Reply-To: References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Joao yes, I missed M-j. Sorry about that. Thanks! > On 10 January 2020 at 10:10 Jo=C3=A3o T=C3=A1vora = wrote: >=20 >=20 > On Thu, Jan 9, 2020 at 10:27 PM Dmitry Gutov wrote: > > > > On 09.01.2020 23:24, waah@yellowfrog.io wrote: > > > Hi, sorry me again. > > > > Hi! Please keep the bug address in Cc. > > > > > Thanks for looking into this! I tried and the error message goes away= . I still encounter a problem: once rgrep asks for the file extensions, ico= mplete accepts any input that is not in the completion list (e.g. abcdf*.sd= f or simply the default) but fido says "incomplete" and does not al= low to proceed unless I select a directory / file from the completion list = (which does not really make sense; C-f to change to the default prompt like= with ido in find file does not work). This might be an error on my side th= ough not knowing the right shortcut - I am still new to ido / fido (sorry!)= . > > > > To clarify (for Joao), we see "Incomplete" when trying to input a > > wildcard that's not in the suggested completions list. >=20 > I haven't checked, but that's when pressing RET, right? Well that's a > tougher thing to address potentially, because the problem might lie > in how we call completing-read. The meaning of RET in fido-mode is > different than in icomplete-mode. And different from ido-mode. It's, > well, fido-mode's meaning, which is somewhere in between icomplete > and ido-mode. But fido-mode provides M-j (bound to exit-minibuffer) for > these cases. ido-mode had problems in this regard to, which it dealt > with by sometimes allowing to exit the main interface with C-f or > sth like that. And sometimes it had some bad solutions, which is > part of the reaoso it didn't work perfectly as an all-around completion > system. >=20 > Again, if the suppositions where I based this quick analysis are > not mistaken, I think this is the matter of a discussion over at > emacs-devel. >=20 > That is _unless_ you found a regression in icomplete-mode. In that case > it's a bog-standard bug to be fixed. >=20 > Jo=C3=A3o From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Jan 2020 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157876918130733 (code B ref 38992); Sat, 11 Jan 2020 19:00:02 +0000 Received: (at 38992) by debbugs.gnu.org; 11 Jan 2020 18:59:41 +0000 Received: from localhost ([127.0.0.1]:56689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqLz3-0007zc-12 for submit@debbugs.gnu.org; Sat, 11 Jan 2020 13:59:41 -0500 Received: from mail-io1-f49.google.com ([209.85.166.49]:46615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqLz1-0007zP-ER for 38992@debbugs.gnu.org; Sat, 11 Jan 2020 13:59:39 -0500 Received: by mail-io1-f49.google.com with SMTP id t26so5521949ioi.13 for <38992@debbugs.gnu.org>; Sat, 11 Jan 2020 10:59:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=H0bygdhvDP5Bl1Bp1GY3pJDJlixLRmhKMzIwEv9pKGk=; b=KMdps5RZ3rq0BgEJSMU7rNcN16yqEqqq2QjSM8NZWRzqOLeY26Mv3C7dTLc4YGQfDX In+oW+XEXAluwuWvX8HpMwG0VmEyFZaf6t2ce91AaxuaXVK3swKLSt9G6h7TCvWw7FUD 8KW/iACPTnMBC58Kg+hZDnQ07XBhx18L9TpV/b3+w9HEHncAvUyiN5quVU+Xlw38tqzn wDvMkTJKv4QsxcEGxt/GuTYPG4eVUYaZ9Y795idK1ce0/+ul/j2a/YhuCbREAi/bodZp 9kiujFG4UXeg3Ci7gkBG7st3gL4SUGKaXByIUGPghC/AWRqMRbxFyQc5uExO2Yza+4fv 8MXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=H0bygdhvDP5Bl1Bp1GY3pJDJlixLRmhKMzIwEv9pKGk=; b=GMTqxMw2XGo9oga32xch1kwo2qS8QGeIHo/4PHtZ15FUBXdaCH14yV2lm0o758/fCJ LlcmlsqCVh5FKtBXALYfLzi3oVSkqd7RInfTTAKM002F3Wk/WL2SXW6TIpHgmsmIDkxh WFqXTqOU9YWW758W9zBxgtx0mQ47HoV3Ro9l68VYpQ0EsVlDvwlgwA//tCmw38WMO0Yo FItdYsrcKSjcVCZogbpG/L5FcSRKBqchdJAvmKHKu3hqBKVSGZusEL3cxygVhwJIo58v 7YPKO0bFFGe3Z90iR+WKuJ7QeTS8GJ28WYLjs5z0drikrZndwHV3KYyCasUyECJb6b42 yChw== X-Gm-Message-State: APjAAAUxcNkusSsZFJau9rwec9cdP2hJFI6UM7pfZAXC6OruVYzD2stj ejoBP3CnRu6plMGoN1PUJGrQTPJuH/Y5SeP0Wyo= X-Google-Smtp-Source: APXvYqyikRilAN0AHqdyQKa6+uxYyhP1nOKoiDXkqDOalrU2+qLWzuiVJAnrGS/sky31IFXOu5Uu9ombSuX75FxFet4= X-Received: by 2002:a5d:9f05:: with SMTP id q5mr7466537iot.199.1578769173776; Sat, 11 Jan 2020 10:59:33 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sat, 11 Jan 2020 18:59:21 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Jan 11, 2020 at 1:52 AM Dmitry Gutov wrote: > I mean... there is something to be said about not having > icomplete-fido-ret try to do too many things, but I fear having RET > prohibit non-matching input entirely would make it too user-unfriendly. > > Could be wrong, though. And you could be right, who knows? :-) I arrived here with a lot of trial = and error. I wrote fido-mode (and gave up on vanilla icomplete) when I discove= red my fingers still missed that sweet sweet interface. I had to adapt some things due to implementation difficulties (but most of them are surpassed now) and others due to fundamental changes in the problem others due to opinion. It "feels" nice for me now, but if you can come up with a bett= er binding for RET, shoot it over, I'll tell you what I think about it. I thi= nk you'll find it will have advantages and disadvantages. But who knows :-) Jo=C3=A3o From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Jan 2020 01:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io, Stefan Monnier Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157931150018739 (code B ref 38992); Sat, 18 Jan 2020 01:39:02 +0000 Received: (at 38992) by debbugs.gnu.org; 18 Jan 2020 01:38:20 +0000 Received: from localhost ([127.0.0.1]:40350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isd47-0004sB-PV for submit@debbugs.gnu.org; Fri, 17 Jan 2020 20:38:20 -0500 Received: from mail-lf1-f48.google.com ([209.85.167.48]:43079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isd45-0004rx-Sv for 38992@debbugs.gnu.org; Fri, 17 Jan 2020 20:38:18 -0500 Received: by mail-lf1-f48.google.com with SMTP id 9so19766117lfq.10 for <38992@debbugs.gnu.org>; Fri, 17 Jan 2020 17:38:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UAiCW8rNWZR9YJkqcb355Wsi+W89tklqYVJdB/Z3nTw=; b=DxMkFtvUG2uGF2SIxNIkSv6/limM7bstNA8Ws/MRmL0PwdYrbiSLZYQaugtfsFjN1A APcxDLHX4IgY4M1bWF7CsKyPvWaFYoGgdg6bDXhXNd/D2h7c4H71jF/JOAwgO0Dpbblf 8ZdR2R/gPLi3tNjNPdBkhTBEDoZzqyCFSWWKRiZLO/Vt2sdp/trcgGTK7EMkD731o8+J XLYDqkr2J+4WSiGo1K6GlYtalbNqA2ofpiIrIXDKdQFQ2J6O0FZP3zePIc4dq2xCOO9M SRC4mrEx1XVYRhjQ1rU2PGX8YOWC0UIwgZFtPgymlg1/bcZtd08fhIt5Bs9iE7u8eaF9 THxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UAiCW8rNWZR9YJkqcb355Wsi+W89tklqYVJdB/Z3nTw=; b=aCT2uYuJbKzrNG3fxX5uhH+ndThuNBV35f6mM9xW+kcmGETPm4ik6IIe42bK9awe8s M1mNYcgb6JqCccEsWv5EVHSN+iKzowhHx5cWr+A3nlXh00GGXj2VK9jNvCtsxYEGl4r4 q2fTPs8zYXbHLyu9/RxzMDAzdLlOrIPV9UGa3ZwlJCTqPTWC3o05W+D3cfWvjiviC0BJ uZiJD2IPFfvSYl5qaqHoIEq3OqGKnUMrpxn779OSjO541HhR3182NvXWrVWM0mIcN4Qm ZCgT9NSkv+75NH2eWikKjskYMYeg1p3SyEnPPTp9msjBhM35jnILGwOZx7b/RzOb+EG3 lhMA== X-Gm-Message-State: APjAAAXd9LtUupoVZbEvhpiC9dfNu4eC0Nw34dxYjRjJdn8apo84wG5J Rehn5fJ3+7Gt9VBL9UHuyIA= X-Google-Smtp-Source: APXvYqzbSJvl7lQjFL985Zs68vnSqmIx6gaiYZUoSACOJQu1/4fI5H8QE7Wcy3QkX4awKoU8xyoygQ== X-Received: by 2002:ac2:53bb:: with SMTP id j27mr6648802lfh.39.1579311491850; Fri, 17 Jan 2020 17:38:11 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id l22sm13169721ljj.44.2020.01.17.17.38.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Jan 2020 17:38:10 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> From: Dmitry Gutov Message-ID: <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> Date: Sat, 18 Jan 2020 04:38:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 11.01.2020 21:59, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= wrote: > rs due to fundamental changes in the problem others due > to opinion. It "feels" nice for me now, but if you can come up with a better > binding for RET, sh [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.48 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.48 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 11.01.2020 21:59, João Távora wrote: > rs due to fundamental changes in the problem others due > to opinion. It "feels" nice for me now, but if you can come up with a better > binding for RET, shoot it over, I'll tell you what I think about it. I think > you'll find it will have advantages and disadvantages. But who knows:-) Without going far into changing its behavior, I think we have two options for this now. Since the only occurrence of "Incomplete" of minibuffer.el is in minibuffer-force-complete-and-exit, apparently one issue is that the glob input doesn't succeed the test-completion test in the read-file-name-internal completion table used by grep-read-files. So the options are: 1. Make sure that the table says globs are valid input (by adding a wrapper, probably). This should make RET silently accept the input in this case. This is a good way to proceed if we're reasonably confident we can deal with similar issues in the same way, and there won't be too many of them. 2. Make icomplete-force-complete-and-exit show a different message, so that the user knows what to do. Instead of just "Incomplete", add something like ", press \\[exit-minibuffer\\] to accept". Maybe do both. The second option can look like this: diff --git a/lisp/icomplete.el b/lisp/icomplete.el index a1a67e2330..d88ebca15d 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -185,7 +185,15 @@ icomplete-force-complete-and-exit ;; calculated, This causes the first cached completion to ;; be taken (i.e. the one that the user sees highlighted) completion-all-sorted-completions) - (minibuffer-force-complete-and-exit) + (progn + (unless completion-cycling + (minibuffer-force-complete nil nil 'dont-cycle)) + (completion--complete-and-exit + (minibuffer-prompt-end) (point-max) #'exit-minibuffer + ;; If the previous completion completed to an element which fails + ;; test-completion, then we shouldn't exit, but that should be rare. + (lambda () (minibuffer-message "Incomplete, press %s to accept" + (substitute-command-keys "\\[exit-minibuffer]"))))) ;; Otherwise take the faster route... (minibuffer-complete-and-exit))) (Or we can put the message into a global var which icomplete-force-complete-and-exit would bind to this message string). From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jan 2020 13:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io, Stefan Monnier Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15794388624162 (code B ref 38992); Sun, 19 Jan 2020 13:02:02 +0000 Received: (at 38992) by debbugs.gnu.org; 19 Jan 2020 13:01:02 +0000 Received: from localhost ([127.0.0.1]:42737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itACI-00014Z-KS for submit@debbugs.gnu.org; Sun, 19 Jan 2020 08:01:02 -0500 Received: from mail-il1-f193.google.com ([209.85.166.193]:37326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itACD-00014J-0e for 38992@debbugs.gnu.org; Sun, 19 Jan 2020 08:00:56 -0500 Received: by mail-il1-f193.google.com with SMTP id t8so25120168iln.4 for <38992@debbugs.gnu.org>; Sun, 19 Jan 2020 05:00:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=lSzfdcf5LYceGCOHu5kSZ6iaJObb3QZkznJpBQHR7Es=; b=um2hKUtIjBSEZZcuHH0nTWEVe771ftbzk6fLjnyKoFAHoHqL7XEiRkVMXLNeAB1T0C 2dkk7tL7Hi+ayRzeWWx2+zId06lSgHldnSuurbAsB2lqmbqar2cmxZDdhx1mjkm/B9Sq n2UsakCjxTr3lOKIcCAzH++IamiGcvbRox3syES3iOU8Rnz8lDJd+kkTmpFTNI62wcPS pP77Q0YVBiCq0jhhji8RN+/YkCthU0POpWNqBJR9Mc1XlaG7VpSm8zJu94s3/lU9NiKi /xLybVx3kyLzHk13gDa4cyJkUnFxMSd4CblNDU2iCyhIVul7SrVQviTmdRbGld3xnEM7 Lv8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lSzfdcf5LYceGCOHu5kSZ6iaJObb3QZkznJpBQHR7Es=; b=tN/EhdSUqUaG492hI05TC+97fTm+SsYBcxFc9tcLwYPPUZ5QjahUzUD0MwGtg5iCby GZQNtsD4tbB7/C45x893vOKn5TuhS6yerObbHRDXJCyIDg0ihw448WK57KMW5Ehj4HGd XLXp6sh9MAU0shfXny4jsdUwwE9oSWISg6rXwwRQoN1OLRHzBLat7Bha/zX/S2b8QEbR g0bkDcD+2Jq2AmtPAuQL0XL1rOMaeZYzL6Dr0R5KgwBDeOseJmsl8LUf2ZTK3bGlbbJX YXBNYlA6WZiZQC5i1FuuuM2FGyxpRhu0cazJsN/6Vw2Mw8ed39uPaAavRrzVc8vQ+qgB urZA== X-Gm-Message-State: APjAAAXZcXtrWMhntS8F7JqltbCQw6zLL3mzYfGAoOD6YPWicU69X0sm pYRwfGj22ZPBzl4K09tTRmGjCc7LeTu4WCTQbc4= X-Google-Smtp-Source: APXvYqxiKpjSb6afElXX7zEmCgq/BEoOWVzD8dM7gvjy46y58tvwLyoGzh6gry2ff+LRpGuw54dfUNiPUug67W7TP44= X-Received: by 2002:a92:88d0:: with SMTP id m77mr7038387ilh.9.1579438847380; Sun, 19 Jan 2020 05:00:47 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> In-Reply-To: <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sun, 19 Jan 2020 13:00:35 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dmitry, The second option looks pretty good, so you can just push that at will, if no other objections. Incidentally, I would also think it reasonable to provide the same help text if there is a single partial match. The first option I don't understand very well, but that's probably because I haven't looked very closely at it, so if you can post an implementation o= f your idea it would be ideal, because it doesn't sound absurd at all :-) Jo=C3=A3o On Sat, Jan 18, 2020 at 1:38 AM Dmitry Gutov wrote: > > On 11.01.2020 21:59, Jo=C3=A3o T=C3=A1vora wrote: > > rs due to fundamental changes in the problem others due > > to opinion. It "feels" nice for me now, but if you can come up with a = better > > binding for RET, shoot it over, I'll tell you what I think about it. I= think > > you'll find it will have advantages and disadvantages. But who knows:-= ) > > Without going far into changing its behavior, I think we have two > options for this now. Since the only occurrence of "Incomplete" of > minibuffer.el is in minibuffer-force-complete-and-exit, apparently one > issue is that the glob input doesn't succeed the test-completion test in > the read-file-name-internal completion table used by grep-read-files. > > So the options are: > > 1. Make sure that the table says globs are valid input (by adding a > wrapper, probably). This should make RET silently accept the input in > this case. This is a good way to proceed if we're reasonably confident > we can deal with similar issues in the same way, and there won't be too > many of them. > > 2. Make icomplete-force-complete-and-exit show a different message, so > that the user knows what to do. Instead of just "Incomplete", add > something like ", press \\[exit-minibuffer\\] to accept". > > Maybe do both. > > The second option can look like this: > > diff --git a/lisp/icomplete.el b/lisp/icomplete.el > index a1a67e2330..d88ebca15d 100644 > --- a/lisp/icomplete.el > +++ b/lisp/icomplete.el > @@ -185,7 +185,15 @@ icomplete-force-complete-and-exit > ;; calculated, This causes the first cached completion to > ;; be taken (i.e. the one that the user sees highlighted) > completion-all-sorted-completions) > - (minibuffer-force-complete-and-exit) > + (progn > + (unless completion-cycling > + (minibuffer-force-complete nil nil 'dont-cycle)) > + (completion--complete-and-exit > + (minibuffer-prompt-end) (point-max) #'exit-minibuffer > + ;; If the previous completion completed to an element which fai= ls > + ;; test-completion, then we shouldn't exit, but that should be > rare. > + (lambda () (minibuffer-message "Incomplete, press %s to accept" > + (substitute-command-keys > "\\[exit-minibuffer]"))))) > ;; Otherwise take the faster route... > (minibuffer-complete-and-exit))) > > > (Or we can put the message into a global var which > icomplete-force-complete-and-exit would bind to this message string). -- Jo=C3=A3o T=C3=A1vora From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jan 2020 14:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io, Stefan Monnier Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157953210524991 (code B ref 38992); Mon, 20 Jan 2020 14:56:01 +0000 Received: (at 38992) by debbugs.gnu.org; 20 Jan 2020 14:55:05 +0000 Received: from localhost ([127.0.0.1]:44585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itYSH-0006Uz-Il for submit@debbugs.gnu.org; Mon, 20 Jan 2020 09:55:05 -0500 Received: from mail-lf1-f48.google.com ([209.85.167.48]:39805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itYSD-0006UJ-Be for 38992@debbugs.gnu.org; Mon, 20 Jan 2020 09:55:04 -0500 Received: by mail-lf1-f48.google.com with SMTP id y1so24286826lfb.6 for <38992@debbugs.gnu.org>; Mon, 20 Jan 2020 06:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=o4l7WIvJ7AavCzSr38jsj6D+1OX7CNvv68sdY+btDhM=; b=kNoYjF6V6LguTwT1vAa6VZMTZde+sbFq3BVoLw5cCI70CS8sJ8BtPKkVqmUh1K2yiT +nUfaDm38ukLheL5E9LUDeq3dR+qj++jzjTAxO4PQswdanL3MZm2tzuKMtoflWOoN8/o 498nEnKAR5cB+wJunevkSRjng4+ZnA8/Az8uzDu9uUQojHJB4l1sitzDd9e/7Fhf8vgb D6fEDJodq9xkUdXyOtXVSL2GEP2H1FfYKWollv0DIkZ5jBkqEReZRRKaoxcLhFYV790U tBdaLcdzQQUc6G5di0H4Jbu2WZhjvHHcWdBl2+kJEYWJqCbqAWzMyFwAuzS9iyW55oQF dnCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o4l7WIvJ7AavCzSr38jsj6D+1OX7CNvv68sdY+btDhM=; b=ZjJ+UeQUDxqrsn0TBh2PQCeW5rnO7qkuGWwAiAg45lOjNVsiVT050+aUFDZVbfPqge x/2pp4O3i7m6BW2lGJL/GulL5YLNFWsuDjSRVxgexBQ9Q1/p3ZpkIz2PO0NrZRshqyvZ lx2Yqf+2tpigeQ++0RQnl2H6r2dTOj5xtGnpCwh2jwSn5C1y2s4vilC2r1qVdtRjw6V5 M9nnjoRLV2DuUC5n2SmfjNMow8ilWeZRmtW6ZMpOtR2CpjzwOYJVySurXzN2n3Oz1HxQ /Z/d3iAwd7rr0d9Wtx2mE+OA57vNMWXMAHnTFkokvKRZbNOFsKD0HqIQiTa4bQg20a9L o2Sw== X-Gm-Message-State: APjAAAXOaynRqJfnDfEUpiWmfJJz23MWbItT6r9R0Pak+XPx1bQ37Mto iD+9aW2QtpuOmSY4GCzyLmQ= X-Google-Smtp-Source: APXvYqz7WMHiedneNyfS+fD3VkmOxpj3tsaz3ug92l4af9QnWgPu5qavxDjulgTZxVD/e0RGe3lg0Q== X-Received: by 2002:ac2:5964:: with SMTP id h4mr4336055lfp.213.1579532095348; Mon, 20 Jan 2020 06:54:55 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id o19sm20370191lji.54.2020.01.20.06.54.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jan 2020 06:54:54 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> From: Dmitry Gutov Message-ID: <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> Date: Mon, 20 Jan 2020 17:54:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 19.01.2020 16:00, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= wrote: > The second option looks pretty good, so you can just push that at will, > if no other objections. I'm not very familiar with the code. Do we really need the minibuffer-force-complete call there? I commented it out and can't see the difference. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.48 listed in list.dnswl.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.48 listed in wl.mailspike.net] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 19.01.2020 16:00, João Távora wrote: > The second option looks pretty good, so you can just push that at will, > if no other objections. I'm not very familiar with the code. Do we really need the minibuffer-force-complete call there? I commented it out and can't see the difference. > Incidentally, I would also think it reasonable to > provide the same help text if there is a single partial match. Makes sense, but that sounds a bit more complicated. We don't show any message in this case now, do we? From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jan 2020 14:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io, Stefan Monnier Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157953231626452 (code B ref 38992); Mon, 20 Jan 2020 14:59:01 +0000 Received: (at 38992) by debbugs.gnu.org; 20 Jan 2020 14:58:36 +0000 Received: from localhost ([127.0.0.1]:45812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itYVb-0006sV-Vn for submit@debbugs.gnu.org; Mon, 20 Jan 2020 09:58:36 -0500 Received: from mail-io1-f52.google.com ([209.85.166.52]:39265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itYVW-0006sD-JE for 38992@debbugs.gnu.org; Mon, 20 Jan 2020 09:58:31 -0500 Received: by mail-io1-f52.google.com with SMTP id c16so33942245ioh.6 for <38992@debbugs.gnu.org>; Mon, 20 Jan 2020 06:58:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1c8/8Genzsfv8JFSCOdA13G7dpXpp0Uv7qOblP5Gi6I=; b=LTOPMW1hJbRSe25BMj69nuFy2RSlA5KCWil6eyRftbDcuqXKQIO2+IItBLLU6Jnz83 RWrKsJzSm8vSuum1S4pmo8cxxC0ysRToLhb2QurIDJBC7Ux8b2y1QmNZizWsERhAlBKM PNtWzQ2HwtcmAiqmTJRqTD0Ed7nBk3kQxpFMSzTwmxBpKdCS+Sz0H+UcNnWkbLY6Z3i1 qod5WM5jQH7gyAy6jxHM3ztkNMe+2InhI7S11p3qs2vXuVUR/roChVwBFNwCPJLPx+vw 8rVIIj75OSEBAfV2gLRzUu0ega+b0Y+Ioundl+yfV5IskofWtIsGjtpJoa+RzIMeFRrj 70tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1c8/8Genzsfv8JFSCOdA13G7dpXpp0Uv7qOblP5Gi6I=; b=mVHnaqbiHon0INHP+wafavuoxdExsxAT0NYpY4y33buWzb9nkiFgZmDpdhD8k1PHJQ 3YHBScvQg/lp9C50y0IcH8tjF83acbleuzOOz00S2wwmanAPfMHvyNcKbUOqyx/fq9aA wHOSF2wQiJqPNxp64ufvk9ha1M8heIYB6d76kQGNXKlSKmZDSjkWbcGlOHGFOfsIoghP cBQvS8djXf8PoOZ2J7N1IzsRk4QnvDOwYfp1K9AR4RTLlSnGxVcmOKeEQqkbp7RBEijT ddgwqv3rUGKD+xnQjCCEV9nzusVtgwmWjj+Cs44Ir5IoATOAFwtkzGSDNO43AthKQ/aN 1Xqg== X-Gm-Message-State: APjAAAWupPCQ9Sp9YEweTgzm6B/SmtwSrA0pfQMikZhRPFN3c8eZb8Mt FTQ/Ivg5IMuMtc4b7Ywwzv0c+WrqbrDq1aWbLhE= X-Google-Smtp-Source: APXvYqzBpgeaNTGyO9s9w1Fu1G+feWyHxN0vG34z+qUxoSVzH+76tCklsEX8yKIsae33n5XEX+w2sZacB6r2T8SurY4= X-Received: by 2002:a5d:9f05:: with SMTP id q5mr41961769iot.199.1579532300846; Mon, 20 Jan 2020 06:58:20 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> In-Reply-To: <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Mon, 20 Jan 2020 14:58:08 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Jan 20, 2020 at 2:54 PM Dmitry Gutov wrote: > > On 19.01.2020 16:00, Jo=C3=A3o T=C3=A1vora wrote: > > The second option looks pretty good, so you can just push that at will, > > if no other objections. > > I'm not very familiar with the code. Do we really need the > minibuffer-force-complete call there? I commented it out and can't see > the difference. I can't tell right now. But do you need to remove it to add the message or is this a refactoring that you are thinking about? Maybe do both changes separately so that either can be reverted individually? Or are they somehow connected? > > Incidentally, I would also think it reasonable to > > provide the same help text if there is a single partial match. > Makes sense, but that sounds a bit more complicated. We don't show any > message in this case now, do we? I *think* the "[Matched]" message is shown. Jo=C3=A3o From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jan 2020 21:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io, Stefan Monnier Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15795565461124 (code B ref 38992); Mon, 20 Jan 2020 21:43:01 +0000 Received: (at 38992) by debbugs.gnu.org; 20 Jan 2020 21:42:26 +0000 Received: from localhost ([127.0.0.1]:46187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iteoU-0000I4-C2 for submit@debbugs.gnu.org; Mon, 20 Jan 2020 16:42:26 -0500 Received: from mail-lj1-f177.google.com ([209.85.208.177]:40815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iteoS-0000Hr-2k for 38992@debbugs.gnu.org; Mon, 20 Jan 2020 16:42:24 -0500 Received: by mail-lj1-f177.google.com with SMTP id u1so584717ljk.7 for <38992@debbugs.gnu.org>; Mon, 20 Jan 2020 13:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ryWcxwmlZmql5U7Gk09hHwqb73Aee/GaRukm8SElLCw=; b=FAAWifI9+NYARr+jHqI3SPy0HEaJRux+KQyAHOU6+Iw9gBm9GWksHsMCEGr+ICI8uh B8FkQWeEtNw+N5hkCXM8yxvJ+KuGduXRCCe5O1HwN2kFjJaDg0iIze4PTwJpOI326K2s bRz8+KXMTCTO4CgR7+aBHj3fxFDssTyNkav+5Z5zvlRJT2arzpcVm7tVcWrFRhDevsZu dczJcAd+Xa6zcGhjmaSEYv4pAXk5sVIsvG1P/S+0rCnsyLdSXNRXc+DefXliK6psNMHu 6ljHPW0ZEqZblZAahFGhPEYK2NPUG5hVOu1MimE6vZFQtrlIGhsx7VJQTsu1jz3WHwsu PybA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ryWcxwmlZmql5U7Gk09hHwqb73Aee/GaRukm8SElLCw=; b=DYJ6lxQLoj+vQGTneArcezvtE5SmqfOs24g0HLIKRupbpe7w9XVvDwNKphuaKLtg6F wPPJQC2DpDuVl1HajnhSBFzFGrNxO1m5pSk2Wu6OHtPKcHvmwWc3YoFgwoKQNN4adWP7 3WjhwdXGlpnBCRIqVfa5qICsz9o4Z8xbimb8EM/iBEEKM2sEydBEznySzbwPclkXXWKi nxzzaThxe9UAPMcMUQ5kKchXB8hgFj0gQXoFWsMWugKtxVhUzETkBv+AtXhsrgoPHKLB LN5Adnw5QGiUVubx+bgWNiA9K0DosicgsAbYPuBLIE7fQejrSn1evpsBuE9B2gMHOOvP iepQ== X-Gm-Message-State: APjAAAVO8nQAgtuaWNkHIVO8GLBOgb7Fgob/c4VXjwNHyUbcuqNNuI9U HBwqmCOdbR9WNskYUnUCIiE= X-Google-Smtp-Source: APXvYqzcjyBITo/hTkY76kB2R10HdCkBueYll+TkoSRR/1gizsT1Bcy6D5xlztNco4pUALP6C8Jbow== X-Received: by 2002:a2e:9942:: with SMTP id r2mr14324952ljj.182.1579556538070; Mon, 20 Jan 2020 13:42:18 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id z205sm491853lfa.52.2020.01.20.13.42.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jan 2020 13:42:17 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> From: Dmitry Gutov Message-ID: <2ee975cb-1d9c-dd1c-b696-fb463b906e33@yandex.ru> Date: Tue, 21 Jan 2020 00:42:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 20.01.2020 17:58, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= wrote: > I can't tell right now. But do you need to remove it to add the message > or is this a refactoring that you are thinking about? Maybe do both > changes sepa [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.177 listed in list.dnswl.org] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 20.01.2020 17:58, João Távora wrote: > I can't tell right now. But do you need to remove it to add the message > or is this a refactoring that you are thinking about? Maybe do both > changes separately so that either can be reverted individually? Or > are they somehow connected? It's a "remove this call that exists for no reason I can think of" kind of thing. Also, if we don't use it, we won't need the progn. IIUC, what minibuffer-force-complete does here is expand the input wherever possible. But if that results in an input that has no matches (and that should be the only reason for completion--complete-and-exit, called subsequently, to fail), why even do that? And if completion--complete-and-exit succeeds, the minibuffer-force-complete shouldn't matter at all. So a second opinion would help. BTW, looks like this change will leave minibuffer-force-complete-and-exit entirely unused. > I *think* the "[Matched]" message is shown. Right. In that case, the change should be easy. OTOH, I'm not sure we should display this very prominent reminder whenever the user has a single match. Someone should try it on and experiment. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jan 2020 23:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io, Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157956148824234 (code B ref 38992); Mon, 20 Jan 2020 23:05:02 +0000 Received: (at 38992) by debbugs.gnu.org; 20 Jan 2020 23:04:48 +0000 Received: from localhost ([127.0.0.1]:46234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itg6C-0006Io-J6 for submit@debbugs.gnu.org; Mon, 20 Jan 2020 18:04:48 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itg68-0006IU-DL for 38992@debbugs.gnu.org; Mon, 20 Jan 2020 18:04:47 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D9B6944083C; Mon, 20 Jan 2020 18:04:38 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DA71F440816; Mon, 20 Jan 2020 18:04:37 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1579561477; bh=Wz9GDT/WupQY/Ic69FdsWSg1hnyhDr8QgQRSD0vdo3U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=U9RmHnJhAOqtRf1/WZC6jyZwPebkYrgxTol+aSq26hdfsJsjWBXRulFaoPF/50vuo EkP8v+FmYipqrkuDLZrn+a/8U4fF5/totdLEDRvbR+u12ibZehXL65Oev8ERgrF4Oy Tyzf5iEKI5gZH+6Hqwdt0pytuNyzFUMfnV/mEutwpx93WCZoYtCbFHiA5Epxmmy64K dUcLNf+2Qdat1ebRGT5ktdstKlZCDWdgT2pG28dkCoHzP8YjzN+zTN5kypafmxM4Z0 qLrj3OhKyCjYxF7wPhB5NdVmCC9AmDcrnEn84wzBEDOA4VPOjCcYITAZFBalKGF68A H9C2lNRXfm7UA== Received: from alfajor (unknown [45.72.156.100]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 795C512047F; Mon, 20 Jan 2020 18:04:37 -0500 (EST) From: Stefan Monnier Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> Date: Mon, 20 Jan 2020 18:04:35 -0500 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Mon, 20 Jan 2020 14:58:08 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I'm not very familiar with the code. Do we really need the >> minibuffer-force-complete call there? I commented it out and can't see >> the difference. The `minibuffer-force-complete` call is the one which actually selects the "first candidate" from the list of completions, so I do think it's necessary. IIUC the bug under discussion is related to the `required` argument of `completing-read` (and to `minibuffer-completion-confirm`). If `required` was nil (as is the case in `grep-read-files` which I believe is the relevant function here), then when `test-completion` fails, we should probably just call `exit-minibuffer` (rather than tell the user that they should do that). The problem here is probably caused by the fact that fido-mode arranges for `minibuffer-force-complete` to choose the *default* rather than to choose a candidate from the completion table. It's rare for a completion table to return candidates that don't pass `test-completion` (tho it's by not impossible nor incorrect), but it's much less rare for the default not to pass `test-completion`. Stefan From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jan 2020 23:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15795645834104 (code B ref 38992); Mon, 20 Jan 2020 23:57:01 +0000 Received: (at 38992) by debbugs.gnu.org; 20 Jan 2020 23:56:23 +0000 Received: from localhost ([127.0.0.1]:46283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itgu7-000148-6e for submit@debbugs.gnu.org; Mon, 20 Jan 2020 18:56:23 -0500 Received: from mail-lj1-f181.google.com ([209.85.208.181]:39617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itgu5-00013u-4j for 38992@debbugs.gnu.org; Mon, 20 Jan 2020 18:56:22 -0500 Received: by mail-lj1-f181.google.com with SMTP id o11so532775ljc.6 for <38992@debbugs.gnu.org>; Mon, 20 Jan 2020 15:56:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QfB0ry9P0+w45tOAp+K97c9pP2/8HAs+z1LGaF1dNkY=; b=NXGbF2s7FKX/BaI1yC6gg8+XzzMNDj5xeBNbYmVS0hWyo9MNQpKjKzjeD4bu84iC1k Dxd1jKUZUf8jyfGVxP6jEMCV7wRoIiObDjbPzsjHRTfDw/nCTwHqsxU1KOqFcMBuoypz T6MlUlEEU8cIod6L95g8R4jHo1Be7efpGLTgALtdV9Zb/ZJEIRsK0M5GtA0rD4k8bPW3 7HE3Ebb6b8SSrHClkG+ljyeImS7jknV//ttfggxgP0cleOxoFdvw9Ls11LgwU4ONbuLS mhKv5sp9btsxKOQjIfSSFAlNB14WdVqNBjlW6eIZVp5up4I7ztneCjcrOegta5JArO6i OQrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QfB0ry9P0+w45tOAp+K97c9pP2/8HAs+z1LGaF1dNkY=; b=TBYBdMAGGqkJoYfZp5VGZRpKU7xYldnqgdS+l7+a87/rnIadrtB1QKSdGnJJvZlPv8 R6rmjyo7OTPgTlTJPXIZUbSGKb9yr+/5Ms2ltP80wop4hFNCTJUyzr0npwnc/0g11U3K B1zk2dDngtNeu9iK6h2sO4G0djxkV5fnqdSXsTN86G0WFiRV7YXWTLzIrBFAwlvYQEXL D0zd5UZ9X3KqaB7VB+NLREo/EcxZkJOowkyvTokCVRDfRcM39CKmor2QJlj+GG40vJgA aUIQ306krqQo3EwQWoBkDTuxyb4r5ZZY5PWQ3xSzciqV9ZggcvkaPUMPYJ0vOqGhLpoO i1vQ== X-Gm-Message-State: APjAAAW1hNSawl+CFLPo5VxW1GkERT4bENeD76luGEezzo9g2BUBXzDg m/EMdBOGAeZ2YcOTBMKhAkA= X-Google-Smtp-Source: APXvYqyyz+q9uWggtDok7vfPwOhaeT48nsjKB2iKqxkeOsVQNmsYmKCh6Gg0yfDA0gMqvehCJ1BoWw== X-Received: by 2002:a2e:89ce:: with SMTP id c14mr13383941ljk.13.1579564574946; Mon, 20 Jan 2020 15:56:14 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id v7sm17783527lfa.10.2020.01.20.15.56.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jan 2020 15:56:14 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> From: Dmitry Gutov Message-ID: Date: Tue, 21 Jan 2020 02:56:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 21.01.2020 2:04, Stefan Monnier wrote: >>> I'm not very familiar with the code. Do we really need the >>> minibuffer-force-complete call there? I commented it out and can't see >>> the difference. [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.181 listed in list.dnswl.org] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.181 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 21.01.2020 2:04, Stefan Monnier wrote: >>> I'm not very familiar with the code. Do we really need the >>> minibuffer-force-complete call there? I commented it out and can't see >>> the difference. > > The `minibuffer-force-complete` call is the one which actually selects > the "first candidate" from the list of completions, so I do think it's necessary. Oh. Right. Somehow I hadn't tested a scenario where this would matter. > IIUC the bug under discussion is related to the `required` argument of > `completing-read` (and to `minibuffer-completion-confirm`). Right. > If `required` was nil (as is the case in `grep-read-files` which > I believe is the relevant function here), then when `test-completion` > fails, we should probably just call `exit-minibuffer` (rather than tell > the user that they should do that). Ido added an extra prompt in situations like this, I think. What you're saying was my first suggestion, but it would require a more invasive change. And icomplete-force-complete-and-exit, as implemented, calls minibuffer-force-complete-and-exit which doesn't seem to care (or know?) that REQUIRED was nil. If you have a particular change in mind, I'd happily try a patch. BTW, I now see that my patch changes a function belonging to icomplete, whileas the intention was only to fix fido-mode's behavior. Do you think the change fits icomplete-mode as well? > The problem here is probably caused by the fact that fido-mode arranges > for `minibuffer-force-complete` to choose the *default* rather than to > choose a candidate from the completion table. It's rare for > a completion table to return candidates that don't pass > `test-completion` (tho it's by not impossible nor incorrect), but it's > much less rare for the default not to pass `test-completion`. Um, not sure I understand. The problem here is that typing 'all' (unless it matches some of the local files names) or '*.el' and typing RET doesn't work. minibuffer-force-complete tries to choose a completion from the table, and when it can't, we get the "Incomplete" message. Though if it can (there's a matching filename), it ends up worse for the user, in this particular situation. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jan 2020 08:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15795943508651 (code B ref 38992); Tue, 21 Jan 2020 08:13:01 +0000 Received: (at 38992) by debbugs.gnu.org; 21 Jan 2020 08:12:30 +0000 Received: from localhost ([127.0.0.1]:46444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itoeD-0002FT-JN for submit@debbugs.gnu.org; Tue, 21 Jan 2020 03:12:29 -0500 Received: from mail-il1-f175.google.com ([209.85.166.175]:36033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itoeB-0002FD-1s for 38992@debbugs.gnu.org; Tue, 21 Jan 2020 03:12:28 -0500 Received: by mail-il1-f175.google.com with SMTP id b15so1686842iln.3 for <38992@debbugs.gnu.org>; Tue, 21 Jan 2020 00:12:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8eZO244/QVbTA1mbUcBIi/XCwVpjSbTwoH0iMQHgpUk=; b=alSPFSODSwGTpmVobWK8aXmlJVPR6O7TdI8P6QsGvXBPyC2kc1Su4OuEKIGskhLF/k XljIwLSSnh5UxxkPIg3uznDJU2Oce3s1BBgoYKzAxJ6tf66pOL5XcSPIzpb8QPSuktbk NDPODPqUdpoOrU0qQ5dAPuVJsRYm8BjmVOjcyt6gJDvG2V9PsuKCzyHFBvhgyBRyFEJE Eg0PeTBavnWbvIB2t72DxT23zGbql1MKUVrzY+19qCe6aMbAM0i9oOcal3H0gFmKn5zn kAsQ2bRu4pZZKZm698UQe5sS/CM2rhk/V3YVbkzRPAcEwLPztGY1TGskhZRiNDTRcu4G BwBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8eZO244/QVbTA1mbUcBIi/XCwVpjSbTwoH0iMQHgpUk=; b=MzDjHiO+NrkIXqRGQdvrna2HnHz0SqAbrxupsTMGkqVXxJYy/eMuvbfTkA0PYkQ4Fu VVAAq+7RPImSJZHKVLAiIh1t9HmnC3WSoDeLLz1lUNpoGO+TdaETmpX8161Ae1lk+Hpb D13nA/Uk4ysOGNhlnwi9Z/1c9jhtKNQFuFRcuhIC0HshKlC7ERnrIa2djKtLmDNCdxwh MUZaQ53rRI9Ipw/hQZ+yNS0zHNctWzZI65cIfLUX1Mm3UgWUpEwIOGS0oMcf9+uOgvC5 apiqPaY9Qgt4LwpR9PudgNiiGnRkjHJcSlIM9OArG9S00iaorG1OeUiW5GbGlGKPsodv R9XQ== X-Gm-Message-State: APjAAAUk9WvKJjgpGRCKmtS1mPG6zS/tXapjm9VtMPiAE8y3EXbVbA66 gqs9BGNddL/+MiF5b6JaCljlrsFCuPPD1uRU/48= X-Google-Smtp-Source: APXvYqzYx4qU2SV603CAK0scM/ImABj7MY3EuOJhCo8MG+oxP3kBAGgHeCzRTz3QDkKZcgM7iS7/P9Ib6kb9ukKyq4U= X-Received: by 2002:a92:884e:: with SMTP id h75mr2669351ild.199.1579594341266; Tue, 21 Jan 2020 00:12:21 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Tue, 21 Jan 2020 08:12:08 +0000 Message-ID: Content-Type: multipart/alternative; boundary="00000000000099b90e059ca1f72a" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000099b90e059ca1f72a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 20, 2020, 23:56 Dmitry Gutov wrote: > On 21.01.2020 2:04, Stefan Monnier wrote,: > > The `minibuffer-force-complete` call is the one which actually selects > > the "first candidate" from the list of completions, so I do think it's > necessary. > > Oh. Right. Somehow I hadn't tested a scenario where this would matter. > Phew! :) > > IIUC the bug under discussion is related to the `required` argument of > > `completing-read` (and to `minibuffer-completion-confirm`). > > Right. > > > If `required` was nil (as is the case in `grep-read-files` which > > I believe is the relevant function here), then when `test-completion` > > fails, we should probably just call `exit-minibuffer` (rather than tell > > the user that they should do that). > > Ido added an extra prompt in situations like this, I think. What you're > saying was my first suggestion, but it would require a more invasive > change. > As I said, you can try it out, maybe with a new binding for RET. Please don't add an extra prompt. And icomplete-force-complete-and-exit, as implemented, calls > minibuffer-force-complete-and-exit which doesn't seem to care (or know?) > that REQUIRED was nil. If you have a particular change in mind, I'd > happily try a patch. > > BTW, I now see that my patch changes a function belonging to icomplete, > whileas the intention was only to fix fido-mode's behavior. Do you think > the change fits icomplete-mode as well? > > > The problem here is probably caused by the fact that fido-mode arranges > > for `minibuffer-force-complete` to choose the *default* rather than to > > choose a candidate from the completion table. It's rare for > > a completion table to return candidates that don't pass > > `test-completion` (tho it's by not impossible nor incorrect), but it's > > much less rare for the default not to pass `test-completion`. > > Um, not sure I understand. The problem here is that typing 'all' (unless > it matches some of the local files names) or '*.el' and typing RET > doesn't work. minibuffer-force-complete tries to choose a completion > from the table, and when it can't, we get the "Incomplete" message. > Though if it can (there's a matching filename), it ends up worse for the > user, in this particular situation. > Dmitry, I wrestled a lot with the the "default" case among others. I wish I had written tests for it but it is quite hard. When experimenting with this at least try: - pressing ret quickly before the first completions appear, with a default, like in c-h f. There should be no wait. - same but slowly, the default should be on top. - m-x man on an word that doesn't perfectly match the candidates, like "read" (I think). Observe differences before and after. Also sorting matters, obviously. Fido mode does some sorting itself to move the default to the top position, I think. Jo=C3=A3o > --00000000000099b90e059ca1f72a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Mon, Jan 20, 2020, 23:56 Dmitry Gutov <dgutov@yandex.r= u> wrote:
On 21.01.2020 2:04= , Stefan Monnier wrote,:
> The `minibuffer-force-complete` call is the one which actually selects=
> the "first candidate" from the list of completions, so I do = think it's necessary.

Oh. Right. Somehow I hadn't tested a scenario where this would matter.<= br>

P= hew! :)


> IIUC the bug under discussion is related to the `required` argument of=
> `completing-read` (and to `minibuffer-completion-confirm`).

Right.

> If `required` was nil (as is the case in `grep-read-files` which
> I believe is the relevant function here), then when `test-completion`<= br> > fails, we should probably just call `exit-minibuffer` (rather than tel= l
> the user that they should do that).

Ido added an extra prompt in situations like this, I think. What you're=
saying was my first suggestion, but it would require a more invasive change= .

As I said, you can try it out, maybe with a new binding for RET. Please do= n't add an extra prompt.

And icomplete-force-complete-and-exit, as implemented, calls
minibuffer-force-complete-and-exit which doesn't seem to care (or know?= )
that REQUIRED was nil. If you have a particular change in mind, I'd happily try a patch.

BTW, I now see that my patch changes a function belonging to icomplete, whileas the intention was only to fix fido-mode's behavior. Do you thin= k
the change fits icomplete-mode as well?

> The problem here is probably caused by the fact that fido-mode arrange= s
> for `minibuffer-force-complete` to choose the *default* rather than to=
> choose a candidate from the completion table.=C2=A0 It's rare for<= br> > a completion table to return candidates that don't pass
> `test-completion` (tho it's by not impossible nor incorrect), but = it's
> much less rare for the default not to pass `test-completion`.

Um, not sure I understand. The problem here is that typing 'all' (u= nless
it matches some of the local files names) or '*.el' and typing RET =
doesn't work. minibuffer-force-complete tries to choose a completion from the table, and when it can't, we get the "Incomplete" me= ssage.
Though if it can (there's a matching filename), it ends up worse for th= e
user, in this particular situation.

Dmitry, I wrestled a lot with the the &q= uot;default" case among others. I wish I had written tests for it but = it is quite hard. When experimenting with this at least try:

- pressing ret quickly before the fir= st completions appear, with a default, like in c-h f. There should be no wa= it.
- same but slowly, the default should be on top.=
- m-x man on an word that doesn't perfectly mat= ch the candidates, like "read" (I think).
=
Observe differences before and after. Also sort= ing matters, obviously. Fido mode does some sorting itself to move the defa= ult to the top position, I think.

Jo=C3=A3o
--00000000000099b90e059ca1f72a-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jan 2020 16:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157962436623856 (code B ref 38992); Tue, 21 Jan 2020 16:33:01 +0000 Received: (at 38992) by debbugs.gnu.org; 21 Jan 2020 16:32:46 +0000 Received: from localhost ([127.0.0.1]:48310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itwSL-0006Ch-J4 for submit@debbugs.gnu.org; Tue, 21 Jan 2020 11:32:46 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itwSG-0006CQ-Mp for 38992@debbugs.gnu.org; Tue, 21 Jan 2020 11:32:44 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DF812100B5E; Tue, 21 Jan 2020 11:32:34 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1158C100865; Tue, 21 Jan 2020 11:32:33 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1579624353; bh=kLnhwlHVuEtH9pMzOVGi1Qfc+gHBcs7C3zw7mTNRb7Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=A1ju2qPv+eGosONfNPrFVKTwwUTFxK69wfPe7Na6XEsKpgjdZXekJAtF1zJQ1O336 C6b+acbeg6jLQayniMMJl2ygLzWpWQiNGPCt4jEydNelZt947AkPMWyUpPcVpIiMrH oesL4vY+Jj6G4/tR5w6k1/9g9WTRSICYAy5XhPPzNpvxjP6PD9QmEYC6l51XXBCojW hxnFWyDQo7wRICiZNT8fueSxlB0tJ5bijnjvQf+cY+B5sLruOakA3oRo9vbmg2sRWh cWz7I4nK3AvC2OXjHF3gjHei3p/PnKCcEMbgBGF2Ms95GF5Mrrdx+Umg+tJxtSxK0l Zg4z2j8X5PegQ== Received: from pastel (unknown [45.72.156.100]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9F49D1203B5; Tue, 21 Jan 2020 11:32:32 -0500 (EST) From: Stefan Monnier Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> Date: Tue, 21 Jan 2020 11:32:18 -0500 In-Reply-To: (Dmitry Gutov's message of "Tue, 21 Jan 2020 02:56:12 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> If `required` was nil (as is the case in `grep-read-files` which >> I believe is the relevant function here), then when `test-completion` >> fails, we should probably just call `exit-minibuffer` (rather than tell >> the user that they should do that). > > Ido added an extra prompt in situations like this, I think. What you're > saying was my first suggestion, but it would require a more invasive change. I haven't thought about what the code would look like, admittedly. Not sure why it would be particularly invasive, tho. > And icomplete-force-complete-and-exit, as implemented, calls > minibuffer-force-complete-and-exit which doesn't seem to care (or know?) > that REQUIRED was nil. Good point: `minibuffer-force-complete-and-exit` probably needs to be changed accordingly (i.e. to just `exit-minibuffer` when `required` was nil). > BTW, I now see that my patch changes a function belonging to icomplete, > whileas the intention was only to fix fido-mode's behavior. Do you think > the change fits icomplete-mode as well? I haven't kept track of icomplete-mode in enough detail to be sure, but I guess so. > Um, not sure I understand. The problem here is that typing 'all' > (unless it matches some of the local files names) or '*.el' and typing > RET doesn't work. I thought in the reported case, the user just selected the default (which happened to be a glob pattern). In any case I was just pointing out that adding the default to the head of the "completion candidates" increases the cases where the current problem shows up. Stefan From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jan 2020 16:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io, Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157962488924697 (code B ref 38992); Tue, 21 Jan 2020 16:42:01 +0000 Received: (at 38992) by debbugs.gnu.org; 21 Jan 2020 16:41:29 +0000 Received: from localhost ([127.0.0.1]:48328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itwaj-0006QD-4A for submit@debbugs.gnu.org; Tue, 21 Jan 2020 11:41:28 -0500 Received: from mail-qv1-f54.google.com ([209.85.219.54]:39603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itwae-0006Px-Ca for 38992@debbugs.gnu.org; Tue, 21 Jan 2020 11:41:24 -0500 Received: by mail-qv1-f54.google.com with SMTP id y8so1739027qvk.6 for <38992@debbugs.gnu.org>; Tue, 21 Jan 2020 08:41:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+A6+X1WzO+SZd2eB0I8hO+nUNknZkE79MjNM/oxGbYo=; b=Lm1A35PLc5grk1A38iSmjVTLrOJlr5B8gg9bxZzcVPavrqYhxJGLBmKjMJeYCDVlBT /zlhNwXOTRoB3ggU0ECE3/iFA04MSDpRvYLXTTgi2lzkQlBkJLANrT52bapNeyNdjXlU tB5vnmOokLpcdq3bmt8U80UUPoKGEGupKKREEsZCT2lij+tlTiJIYi8DHBbpBrpzp8Xr ykJqQ7DnU6lTrqsYBjhOw0/qBTquZPz5DrjTmBZMOEYJ8HDhCYpK4DM+lfmkjxGG4n3P 1i+/n+t9GQVUvtp8t8ZTBeBz33hQDgjo3NHIWlP5fHUnKYdIg+U4A7PYWj6CcCoGblNn eE4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+A6+X1WzO+SZd2eB0I8hO+nUNknZkE79MjNM/oxGbYo=; b=m2kjbivxpBXJtXxEPkQnxzWeT7ZX0sMUoa/5GnuCF+tF1Ykg7O14QCWn5D+oKB9plz glixk4r0tbvSDFgAh457qmd6+GgwNMhg86NcYUuDI8e7wwRTlaPqTcGLVbyIGFDKcbTT L5WtZRfEjZYbHm2e4MpoE8ONGFGgzhU7xYGF15L3R1CiQglPHaGNz2idS59OyAdb4m2I gvyVbYmB+7+MU7S5Nush2qD7muHCguysp24iTMyu7vuozFqa9Tsi3X3nAzCdzOvTMpm0 /W0IgFDmdnlBlWI48ly7rLrzewdiTUlokgVGPW77Pzbu00Oj5ww+2X7XXwAJreO5bTva X2+Q== X-Gm-Message-State: APjAAAW4IboS3b+li/ncT6z7vika/qn1i/F3D5sWGoiL5q1GVO/5n+Kk VB1Cuy0bMowpocZ7vYiJDDljNqwwhl9xBSFnKiw= X-Google-Smtp-Source: APXvYqwZShEbZ/yOiWhVZ+nWkanGp7OjlosRohJ7HDzyy+tFllZHbGRm7aoDbQqzfRSWdxpgc7rFvOH2ZRb3bG/SsPw= X-Received: by 2002:ad4:514d:: with SMTP id g13mr5514554qvq.190.1579624874860; Tue, 21 Jan 2020 08:41:14 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Tue, 21 Jan 2020 16:41:03 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Jan 21, 2020 at 4:32 PM Stefan Monnier w= rote: > In any case I was just pointing out that adding the default to the head > of the "completion candidates" increases the cases where the current > problem shows up. Can anyone comment, or restate, for my benefit, what exactly the "current problem" is? Is it statable in the form "currently I can't use RET to , as I do in "? I've been using `fido-mode` pretty stable for the last month or so and don'= t notice any "obvious" improvements _to its intented interface_. Obviously, I am _all_ for refactorings and cleanups, but am also against any _regressions_ ;-), so if there are no very clearly defined improvements to the interface (this is a new feature, after all) , I would suggest that this work is done on master, not on emacs-27. Jo=C3=A3o From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: waah@yellowfrog.io Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jan 2020 17:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Stefan Monnier Cc: 38992@debbugs.gnu.org, Dmitry Gutov Reply-To: waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157962619827064 (code B ref 38992); Tue, 21 Jan 2020 17:04:02 +0000 Received: (at 38992) by debbugs.gnu.org; 21 Jan 2020 17:03:18 +0000 Received: from localhost ([127.0.0.1]:48364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itwvq-00072N-Is for submit@debbugs.gnu.org; Tue, 21 Jan 2020 12:03:18 -0500 Received: from mout-p-102.mailbox.org ([80.241.56.152]:58890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itwvl-000727-IK for 38992@debbugs.gnu.org; Tue, 21 Jan 2020 12:03:13 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 482FGb2hN1zKmfn; Tue, 21 Jan 2020 18:03:03 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter04.heinlein-hosting.de (spamfilter04.heinlein-hosting.de [80.241.56.122]) (amavisd-new, port 10030) with ESMTP id QjKs4rvAJInc; Tue, 21 Jan 2020 18:03:00 +0100 (CET) Date: Tue, 21 Jan 2020 17:02:58 +0000 (GMT) From: waah@yellowfrog.io Message-ID: <212121530.60539.1579626178211@office.mailbox.org> In-Reply-To: References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, I think the original problem is fixed. Now it is a question of how the fido= should behave.=20 The only thing I would suggest for Emacs 27 is to update the documentation = of fido? This is what confused me because M-j is not mentioned by 'M-x desc= ribe-mode' and C-M-i is not the correct key for the situation where there a= re no matches. This confused me. Thanks! ---- When this global minor mode is enabled, typing in the minibuffer continuously displays a list of possible completions that match the string you have typed. See =E2=80=98icomplete-completions=E2=80=99 for= a description of how prospective completions are displayed. For more information, see Info node =E2=80=98(emacs)Icomplete=E2=80=99. For options you can set, =E2=80=98M-x customize-group icomplete=E2=80=99. You can use the following key bindings to navigate and select completions: key binding --- ------- C-j=09=09icomplete-force-complete-and-exit ESC=09=09Prefix Command C-,=09=09icomplete-backward-completions C-.=09=09icomplete-forward-completions C-M-i=09=09icomplete-force-complete =0C Line-Number minor mode (no indicator): Toggle line number display in the mode line (Line Number mode). ----- (defvar icomplete-fido-mode-map (let ((map (make-sparse-keymap))) (define-key map (kbd "C-k") 'icomplete-fido-kill) (define-key map (kbd "C-d") 'icomplete-fido-delete-char) (define-key map (kbd "RET") 'icomplete-fido-ret) (define-key map (kbd "C-m") 'icomplete-fido-ret) (define-key map (kbd "DEL") 'icomplete-fido-backward-updir) (define-key map (kbd "M-j") 'exit-minibuffer) (define-key map (kbd "C-s") 'icomplete-forward-completions) (define-key map (kbd "C-r") 'icomplete-backward-completions) (define-key map (kbd "") 'icomplete-forward-completions) (define-key map (kbd "") 'icomplete-backward-completions) (define-key map (kbd "C-.") 'icomplete-forward-completions) (define-key map (kbd "C-,") 'icomplete-backward-completions) map) > On 21 January 2020 16:41 Jo=C3=A3o T=C3=A1vora wro= te: >=20 > =20 > On Tue, Jan 21, 2020 at 4:32 PM Stefan Monnier = wrote: >=20 > > In any case I was just pointing out that adding the default to the head > > of the "completion candidates" increases the cases where the current > > problem shows up. >=20 > Can anyone comment, or restate, for my benefit, what exactly the > "current problem" is? >=20 > Is it statable in the form "currently I can't use > RET to particular thing>, as I do in "? >=20 > I've been using `fido-mode` pretty stable for the last month or so and do= n't > notice any "obvious" improvements _to its intented interface_. Obviously, > I am _all_ for refactorings and cleanups, but am also against any > _regressions_ ;-), so if there are no very clearly defined improvements > to the interface (this is a new feature, after all) , I would suggest tha= t > this work is done on master, not on emacs-27. >=20 > Jo=C3=A3o From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jan 2020 17:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: waah@yellowfrog.io Cc: 38992@debbugs.gnu.org, Stefan Monnier , Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157962750329178 (code B ref 38992); Tue, 21 Jan 2020 17:26:01 +0000 Received: (at 38992) by debbugs.gnu.org; 21 Jan 2020 17:25:03 +0000 Received: from localhost ([127.0.0.1]:48381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itxGr-0007a8-Hx for submit@debbugs.gnu.org; Tue, 21 Jan 2020 12:25:03 -0500 Received: from mail-qt1-f173.google.com ([209.85.160.173]:45746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itxGj-0007Zk-Ho for 38992@debbugs.gnu.org; Tue, 21 Jan 2020 12:24:55 -0500 Received: by mail-qt1-f173.google.com with SMTP id w30so3226936qtd.12 for <38992@debbugs.gnu.org>; Tue, 21 Jan 2020 09:24:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Vy94G7bo01o8YNBG2LM7Ncl6+KC9iqWj/16hyWUlPms=; b=vGvjNvR94zOe+XedxCt572+I95ZJF0V87synD6gXNZ3GRCs/GIHa1c0Izar4kO3vFF SYYEblhkGB9TdBfza26P0Vxmz3C7frizMNoLutpc4xZG5AK5C1HQws1AaLNKy75T07O5 HKYYilNQGNPk49v6Nl/aSIIBZ6ZN1hy4HYUuivIlebkpCxUlqynw6QukTfDTlKTiL9y0 GhIJFdtK8pHHUiRB3OjpZBjhQf07yINnTzqKUAr6Zx8fjEkCzwpSHj0mwJapMSmLUW+Q jTFAbYn2lmZWf4AgVV19+axW1Gf180sJ5QoXTJi+Dni3gYYUBJJ4UUIVSpU7tI+BS7O/ VuvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Vy94G7bo01o8YNBG2LM7Ncl6+KC9iqWj/16hyWUlPms=; b=mZUi/c7xeorOTy/JNxw52OvF7qzVS1xRY2IXHtpVZ4218gqFuRxOpXlDnBfaciAnKw Vb/7hGFWmEk+cBlWkzXOMuLYpE2y8INIuZ5VUNnxU/5w7LLswyVKhfj05kZkqXo8vVUG aE4XYET8k/ettv1qs7ZWe3qQz2B3kCoBtk570ciZtlv3yQeQbs58Mb9CPJlJBjsAMktS 9XC6o8GryEn3wwEqVoflG+J2hgkcb5BBhyA5daVGEbNCCiDFKUWbfZBO1gd964COGxz2 z6OsLXG7sp2+KWrCRjtqyBuvTrmYf6U/QEd1aPbQxfnbbD6LXrp6J2saB4KLNizbOk3i aV8g== X-Gm-Message-State: APjAAAWFqVRVSaN8C5ogQOq4wCwdOTD2NV7QHH0WJG+AatU3uuN48OL/ KKLxpkPYsa2EWnErEkHwLXmyddbEN03nd45+P6I= X-Google-Smtp-Source: APXvYqxPcpkC/jdmfsNYHgvjt1UEGgNYa3un+o/SJ6ngEoFYVnwP7Fn1z2p91oL9D6OWIT3v3jWbHa1/hJHqSZShy/w= X-Received: by 2002:ac8:7155:: with SMTP id h21mr5238588qtp.95.1579627484070; Tue, 21 Jan 2020 09:24:44 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <212121530.60539.1579626178211@office.mailbox.org> In-Reply-To: <212121530.60539.1579626178211@office.mailbox.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Tue, 21 Jan 2020 17:24:32 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > The only thing I would suggest for Emacs 27 is to update the documentatio= n of fido? That's a pretty reasonable thing to request for emacs-27. Unfortunately, I don't have time for this update right now, so if anyone could prepare a patch that I could quickly review, I would be much indebted. Thanks, Jo=C3=A3o From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jan 2020 18:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io, Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157963287413453 (code B ref 38992); Tue, 21 Jan 2020 18:55:01 +0000 Received: (at 38992) by debbugs.gnu.org; 21 Jan 2020 18:54:34 +0000 Received: from localhost ([127.0.0.1]:48478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ityfa-0003Uv-AK for submit@debbugs.gnu.org; Tue, 21 Jan 2020 13:54:34 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ityfW-0003Ub-8c for 38992@debbugs.gnu.org; Tue, 21 Jan 2020 13:54:32 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5130681056; Tue, 21 Jan 2020 13:54:24 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B3D5F80D80; Tue, 21 Jan 2020 13:54:22 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1579632862; bh=RKyRDPScGupEQztX88LyLw6cML7MOB/bl6PKzq15yrE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=iOGjPQZKdK4nE2EGHH1SHYiBjA3CHxlmbTO8pmD+oVfzffNNgCexwJ4MRQLXLFiOu FaE9xnG8VhZM7PzjpgqPoWL2zz3mmqhRyDHt/iM9wO704KrJqtd+1BYV51C1r4xxmD skEe3zInDiz++91GqnIkT7oM38QC3kDf9/qIFRgcSsctnZhdlaazh1oeca5D5ByB1E z5BbusaC+j3zvmXN/ZKxJYPwsTW7wlruFdXc5rQGR1BGbF/Jp3refpUFrY0as3b7p9 kvBlIzNgQJsyFkb7HC5jPFhsOwnKaHXstp+mDU/i8eGXr68BRo8EgqWSAjVNaPSi0M O8CxWqDTWI5BA== Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9D8401202A3; Tue, 21 Jan 2020 13:54:22 -0500 (EST) From: Stefan Monnier Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> Date: Tue, 21 Jan 2020 13:54:21 -0500 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Tue, 21 Jan 2020 16:41:03 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.007 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Can anyone comment, or restate, for my benefit, what exactly the > "current problem" is? AFAIK the problem is that in fido mode RET will reject `*.f90` passed to `M-x rgrep` (because it fails `test-completion`). Stefan From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jan 2020 22:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157964752619607 (code B ref 38992); Tue, 21 Jan 2020 22:59:02 +0000 Received: (at 38992) by debbugs.gnu.org; 21 Jan 2020 22:58:46 +0000 Received: from localhost ([127.0.0.1]:48661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iu2Tu-00056B-1P for submit@debbugs.gnu.org; Tue, 21 Jan 2020 17:58:46 -0500 Received: from mail-lf1-f51.google.com ([209.85.167.51]:40603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iu2Tp-00055w-RD for 38992@debbugs.gnu.org; Tue, 21 Jan 2020 17:58:44 -0500 Received: by mail-lf1-f51.google.com with SMTP id i23so3746490lfo.7 for <38992@debbugs.gnu.org>; Tue, 21 Jan 2020 14:58:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Qznjc1PZcyCdTOFjSResXO3e1bGUF6mdOLw2K9ACj9I=; b=S80F2gQUg569K3ROSIb4JCQZAmP/qwivZagGo11lBN1guOTHtPGGYAdSlSkmpRZdiE BUp7ZKIFV+WvPPX+xlX0gf/YW2IdJwZPeKE86uuoFJ9Xc2tx2mh0AocEjXybf/5qIQDJ LG9u2PtEr6bjSIGAr7JcfZ8weqP3f0IVlDEBkUoGlnIZnAvx0lNWtvTu6r1LBUivq0DQ PNYAWZ6yQnOVDIuyUTgOLtGlZJl08vEYHdbxlfsewnvSMkmeRx6dmrWfyowBGW9WU0Av QcvCx6Fj0xOzkQkqHBD0fAYUsieJg4qOklq5MUfy/JhD6fyeNdYJs23g9WFpbr1e1GKx LHJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Qznjc1PZcyCdTOFjSResXO3e1bGUF6mdOLw2K9ACj9I=; b=cx5dKMvj1NuixojDYgJOAfTnwSJ+aX/7YxxTQQpHKw78BRdtCOk/5HkRckX/+0bzEJ uFueE0R4mv2VmFCvEkQsuLF/LAXhhKDvVKcwWPWDObcA9hGZ2n+FzNFyqGO8SdH7U1JZ yKqWo9QkZJ09C0TzcHIFwcu/N3jIoEin39CmVfn0oX4+zDQ9PeH9jvfK6hCGQ8wtR3qL YSN2Q6XaZEP/V0yvvSe/dsNTZaJcdwqebvL2MKStEzrE2to4Uz9mMiJBTFPtVcULynek 5cWW49dzI6ZutqjFvYh1MN9s37L/dxye6VxUl2ybaBqGjp0aYj9+Zt7v55RaUIApFubn hjVg== X-Gm-Message-State: APjAAAX9+rHIpHl7ScmvE7GJclt+4lW5eUOORcy0WjlXHQAcd9LMIDQA kwdxdK4In0LMw8LPK5UaTPM= X-Google-Smtp-Source: APXvYqwAB+QsMEZZ+AieYZQX1UOj2uo8rD/myF5yhQQpco16emmelBiVUc8+1UFW72IzA5VT2XWvrA== X-Received: by 2002:a19:ca07:: with SMTP id a7mr51658lfg.103.1579647515717; Tue, 21 Jan 2020 14:58:35 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id f26sm19177781ljn.104.2020.01.21.14.58.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Jan 2020 14:58:35 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> From: Dmitry Gutov Message-ID: <2fd66b53-013f-1f16-2d8a-7e9cb98b57f2@yandex.ru> Date: Wed, 22 Jan 2020 01:58:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 21.01.2020 21:54, Stefan Monnier wrote: > AFAIK the problem is that in fido mode RET will reject `*.f90` passed to > `M-x rgrep` (because it fails `test-completion`) ...even though REQUIRED is nil. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.51 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.51 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 21.01.2020 21:54, Stefan Monnier wrote: > AFAIK the problem is that in fido mode RET will reject `*.f90` passed to > `M-x rgrep` (because it fails `test-completion`) ...even though REQUIRED is nil. (Rejecting input failing test-completion when REQUIRED is t is obviously okay). From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jan 2020 00:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157965296628024 (code B ref 38992); Wed, 22 Jan 2020 00:30:01 +0000 Received: (at 38992) by debbugs.gnu.org; 22 Jan 2020 00:29:26 +0000 Received: from localhost ([127.0.0.1]:48702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iu3td-0007Hw-MD for submit@debbugs.gnu.org; Tue, 21 Jan 2020 19:29:25 -0500 Received: from mail-qv1-f50.google.com ([209.85.219.50]:36573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iu3tb-0007Hk-HJ for 38992@debbugs.gnu.org; Tue, 21 Jan 2020 19:29:24 -0500 Received: by mail-qv1-f50.google.com with SMTP id m14so2441674qvl.3 for <38992@debbugs.gnu.org>; Tue, 21 Jan 2020 16:29:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wLQTcdrz5pceyR+bAB+qa3ZMvl8iMGrglRKZvAShG9s=; b=uuc8IvbHZ1XXAkedKgDiVftQizpmhEcFLsUxqh4Mqfhk9vVI1LllI7MFoOHx+czx9u Lp0HMPHWzsdHhEexrCtBTcxEzdwn0ZyFmtk9VK+HP1SP5kYLaFxI6o22gDAL3v80NYPC VbEllDg0i1Ol0pr4tZqBp5lLucRSTXwEePB2t3Ml5K07Do6qslnamOcXzdME4RjOlQzY aWrYPVeUXBrEZG2B1O2yU0rZ4Fpvn6kFOKyA9Dw/Uqq2X52TXI6/Cxfo2fovym2iWoEa tMfWwDUFEK5n4iVreMX2v/MPv0/tYF7m1rWqXYyz5ls3vwJ8MB0qH77Zsn+0lV26dM82 BA+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wLQTcdrz5pceyR+bAB+qa3ZMvl8iMGrglRKZvAShG9s=; b=s3YfPLDqWi+8YmO8ZU6/T270mjk9PTYjU6ZaLtmjg79Xrh7PTOg19rLMOKNQ49JCTE Xk93P53QtaXpr0OIKJjmw7KsdNKYeYt1buthDxW2oo7w9/k0L2nNTL1kgbkNOO0tl/DM FpqM6CE5dCGZ57LxpzFq197h8HrGaKLBcX+bKYugemIrdvT1ioYz3fpFuKXQTWvcKL8u suMEhPjbVQURS8wsKDUHa1fbmrHrc+ntbMRRVZQd/AzXejOr94cZjhE3ynOeASFL9R9F ym0iIz+DPQhlUOnD9B0sLoD5FQjdFesCk9A7ESv2loU6DSz6m7T5WiBzgWAu3h3EAyJj 5WeA== X-Gm-Message-State: APjAAAV7rCfA/IBULz9vPPULQWB8kcruZfROTySPsmr1lkgCxZCu40l8 n1+UTLYXn7ABkzW0vUlCDP8TJczsBEziO6L5xPA= X-Google-Smtp-Source: APXvYqwewPDgR7XpxPqJv/LXPHZd/JJwTtcDbu52kpW+eTbQN8gIFXk8MgnSQcAWnkKdOQL2xYgeWHy6Sr91LJL2LRY= X-Received: by 2002:ad4:514d:: with SMTP id g13mr7501471qvq.190.1579652958042; Tue, 21 Jan 2020 16:29:18 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <2fd66b53-013f-1f16-2d8a-7e9cb98b57f2@yandex.ru> In-Reply-To: <2fd66b53-013f-1f16-2d8a-7e9cb98b57f2@yandex.ru> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Wed, 22 Jan 2020 00:29:06 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Jan 21, 2020 at 10:58 PM Dmitry Gutov wrote: > > On 21.01.2020 21:54, Stefan Monnier wrote: > > AFAIK the problem is that in fido mode RET will reject `*.f90` passed t= o > > `M-x rgrep` (because it fails `test-completion`) > > ...even though REQUIRED is nil. > > (Rejecting input failing test-completion when REQUIRED is t is obviously > okay). I see. Isn't minibuffer-force-complete-and-exit the place to fix this? That= way it would also fix vanilla icomplete's C-j binding. Apologies if this was suggested already. Jo=C3=A3o From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jan 2020 00:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io, Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157965313728422 (code B ref 38992); Wed, 22 Jan 2020 00:33:01 +0000 Received: (at 38992) by debbugs.gnu.org; 22 Jan 2020 00:32:17 +0000 Received: from localhost ([127.0.0.1]:48718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iu3wP-0007OL-HS for submit@debbugs.gnu.org; Tue, 21 Jan 2020 19:32:17 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iu3wO-0007O9-4u for 38992@debbugs.gnu.org; Tue, 21 Jan 2020 19:32:16 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7916F4401D5; Tue, 21 Jan 2020 19:32:10 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 269BC4403D2; Tue, 21 Jan 2020 19:32:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1579653129; bh=ef5Rqrmu00SIKmu/kxH/5e83KM4sBQRsbBfG99iM584=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=G32ab8fqaRO5AWx03UHIWAavhoNU3x5tq530rOI+eCoCCysEo/I8uF1O6GNmSC0wr czRzpl36egcWaqk9WNXnR648D3K9H3XAuIXuXeqMxnrpUt28CfHRimo3hYcabylqa5 ZAW93xAmueKX4lS4bQnGIIvYihwUimD6HgfZxjh+mciiJOFd8pI7TcEfdDdjU5R6uy FrfPW6QrL0FUpmgGZpwHNhe1i1gVEqv6PyycI35IGNoo5IssC1apHnwt23ENax8x/P ChmSDqMRc7vesVxill+mcOBK3jv5mNsAhm6RySN5gu2ozBLUh6acqtRRLNfuH9VQwZ xht8V53perNcg== Received: from alfajor (unknown [45.72.156.100]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D1F7B120FAA; Tue, 21 Jan 2020 19:32:08 -0500 (EST) From: Stefan Monnier Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <2fd66b53-013f-1f16-2d8a-7e9cb98b57f2@yandex.ru> Date: Tue, 21 Jan 2020 19:32:07 -0500 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 22 Jan 2020 00:29:06 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I see. Isn't minibuffer-force-complete-and-exit the place to fix this? That way > it would also fix vanilla icomplete's C-j binding. That's my impression as well, yes. Stefan From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jan 2020 12:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15796964596513 (code B ref 38992); Wed, 22 Jan 2020 12:35:01 +0000 Received: (at 38992) by debbugs.gnu.org; 22 Jan 2020 12:34:19 +0000 Received: from localhost ([127.0.0.1]:49128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuFD9-0001gz-HR for submit@debbugs.gnu.org; Wed, 22 Jan 2020 07:34:19 -0500 Received: from mail-lj1-f175.google.com ([209.85.208.175]:43603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuFD8-0001gf-5t for 38992@debbugs.gnu.org; Wed, 22 Jan 2020 07:34:18 -0500 Received: by mail-lj1-f175.google.com with SMTP id a13so6575122ljm.10 for <38992@debbugs.gnu.org>; Wed, 22 Jan 2020 04:34:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TuKPqBkV14t+L/z20MiHytM+ZWnRcqbwG4KJzYEoevg=; b=oSmsj+2adedR2LBTtA5HHjI5fTmwUs++96VwTVB0NPLiOSbafaRQjCaWGM0xb+njhs G0OtJpjodY+M4pjminzVGB/zK93E/+Hu1qZ8KrbOnZ2q7smGoxvC1n3D/gUuB30hov49 nTPMXaAFSk8FPUVxFLJ2WlU9DSnADZD5bLAuluQvDQgZu5+5SuQ3vVPrtQ8CCRTEd52G BxOB9nKX7KPMad1a0TOr7V3HzGdl1qCm5jgLsviWGqPCAwxllPFoabNLa3yTOCfuXcf+ Uv3U9KmtFgNB37ITRx7zBEITsWUrl/hqtoRW537zvVeCD/KIVMpT96zOOHccnh35i6jK VpMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TuKPqBkV14t+L/z20MiHytM+ZWnRcqbwG4KJzYEoevg=; b=PqumFUHItFpwXW8FDEZYYf1dEyDRlM2tw+JlJpn8+iShSnLudZohgyXm9YJnCSo5Am Ify74pZ7aNWT20PeV0yluJFKi3GrbCnVkSQvKSd+S9CEg4ibIxUbZmcD+3OQ+UyL42le QhvTOffVKREeNCqvCKI62/uenIZg/3ZG27bu8Kfu5NeSra0TNSaNYzthMoJhFe6RTIDa 66flKMdVNILQdYcVT45HsdhEf9u31tGv4i2JvtI9xVaoUHAKDPc4/bmQr8Je+4DRRSz+ leyICRYUu5ImWwdvKs3EjkdIrRWgTXI0kI4TTVblxs7PvqkWx3Kl0yR/T6t9yRc89SsP dgUA== X-Gm-Message-State: APjAAAUUBPs0R3vTyFpwo/n0uaTHsxHfd7nO68s8qN/c6rM3Fyy61DDU +fgOSQhCDw3uvBvIcAnowQs= X-Google-Smtp-Source: APXvYqyhrXr/V4nzQ4NxvQaXGAv8q1+j3GIgoD5+t3V/iFswmkwshpFHr05r7fXzhLPXIQJWOZ96EA== X-Received: by 2002:a2e:3619:: with SMTP id d25mr19284949lja.231.1579696452083; Wed, 22 Jan 2020 04:34:12 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id r20sm20604871lfi.91.2020.01.22.04.34.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Jan 2020 04:34:11 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> From: Dmitry Gutov Message-ID: <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> Date: Wed, 22 Jan 2020 15:34:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 21.01.2020 19:32, Stefan Monnier wrote: > I thought in the reported case, the user just selected the default > (which happened to be a glob pattern). The default is 'all', which is an alias for a list of globs. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.175 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.175 listed in wl.mailspike.net] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 21.01.2020 19:32, Stefan Monnier wrote: > I thought in the reported case, the user just selected the default > (which happened to be a glob pattern). The default is 'all', which is an alias for a list of globs. > Good point: `minibuffer-force-complete-and-exit` probably needs to be > changed accordingly (i.e. to just `exit-minibuffer` when `required` > was nil). How will it determine that? minibuffer-completion-confirm seems to be the same whether require-match is t or not. Looking at completing-read-default, it only really affects the local keymap to be used. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jan 2020 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157979692518571 (code B ref 38992); Thu, 23 Jan 2020 16:29:02 +0000 Received: (at 38992) by debbugs.gnu.org; 23 Jan 2020 16:28:45 +0000 Received: from localhost ([127.0.0.1]:53100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iufLY-0004pT-VW for submit@debbugs.gnu.org; Thu, 23 Jan 2020 11:28:45 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iufLX-0004pH-F5 for 38992@debbugs.gnu.org; Thu, 23 Jan 2020 11:28:43 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 36003100DE9; Thu, 23 Jan 2020 11:28:38 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 60EFE10028B; Thu, 23 Jan 2020 11:28:36 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1579796916; bh=3K/scEkiEVLH1gvxvWJHhSHvHbwk7FntpEzrlHlgCdc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Ut28RrXs4B8G/E1aArUIzQZt9JIAeMIkoIoJ8b/ccLCZd2KMXSahesD+UwZZUVX2Z fOFBN8aQ6ROnMsW8dVVfK44ePkBOICKDg29Ry3HAQpVPDF0MrEb43eOLac9AT6iSvl p/YBqR22+7mSKV2bXey6/thJeqAwz79jJFSu9EW0u9wwo1NZA+Sk3EjdCzxVBJ4wTc LjbSOgSaMlAMOirib8mBNMrcXXzBHRwPmBNjDs4MH6Z+kghfI4OsmrGawIQ2Pmpsqj lfkQqmhhEejfIFXIByZvc7oArGaI/sy2C5uz7+DfSUU/bHlODuMeZXkueGxQIjZV2H rhXAheMkI/N4Q== Received: from pastel (69-196-141-61.dsl.teksavvy.com [69.196.141.61]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 06A8212100C; Thu, 23 Jan 2020 11:28:36 -0500 (EST) From: Stefan Monnier Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> Date: Thu, 23 Jan 2020 11:28:31 -0500 In-Reply-To: <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> (Dmitry Gutov's message of "Wed, 22 Jan 2020 15:34:10 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Good point: `minibuffer-force-complete-and-exit` probably needs to be >> changed accordingly (i.e. to just `exit-minibuffer` when `required` >> was nil). > How will it determine that? minibuffer-completion-confirm seems to be the > same whether require-match is t or not. We could introduce a new `minibuffer-require-match` variable (and mark `minibuffer-completion-confirm` obsolete). Stefan From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jan 2020 16:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io, Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157979831120593 (code B ref 38992); Thu, 23 Jan 2020 16:52:02 +0000 Received: (at 38992) by debbugs.gnu.org; 23 Jan 2020 16:51:51 +0000 Received: from localhost ([127.0.0.1]:53104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iufhv-0005M3-01 for submit@debbugs.gnu.org; Thu, 23 Jan 2020 11:51:51 -0500 Received: from mail-qv1-f51.google.com ([209.85.219.51]:42796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iufhs-0005Lq-Q1 for 38992@debbugs.gnu.org; Thu, 23 Jan 2020 11:51:49 -0500 Received: by mail-qv1-f51.google.com with SMTP id dc14so1781279qvb.9 for <38992@debbugs.gnu.org>; Thu, 23 Jan 2020 08:51:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HfMjjbwU88WzbhrRasEP8GFks5xuVSDB+xQXZeBypwg=; b=WEZB/HKwB+jI0zmPyolAoV70phe3NdiJm4cFGW9uyx6cdXIUth6Eq7wg1NXDElfhdw /sQd1x24ZULqs4yq54fIIgfa/iOmRNZx5HZrMqnZV5JYi4jDhgqx0EpW2eFYciQpG9JP FrqPTuxnbA6a6JmfMx3Kd67vZpB42s272Di3UFFXh95R+zTxuuiRXdHXxfm08nxQnvEU js2+XZnUEjFMMiLst4qNT67adg4W6Qvo5iXX1mXJpxGBIy+RwCrX3aHdvxYG0I0jROwG 4JN9YvoteUcq2F2bLNarBgxRXi4Gg5KL8YgkFnDu2bzJmtNyaIxy63ezH/aLwCAMzwq+ sENw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HfMjjbwU88WzbhrRasEP8GFks5xuVSDB+xQXZeBypwg=; b=rTl25XtxFhiBerQsva/QNve8KOLlQwXLMYdp8p27kPk7YniuP0gWhAOrXa7Lxr3i3D WFXbbn0YbGf7n+ByF0m5MR0mxMebCERsUzu0d0tlNcMwxaWM197cC2/4p+S3KYlR18sr k6b+aW/qUWEF7AfO0Si15HSPMfHmOQvleVEF0+lfhMKNaq2Y44RGcHoeB45E8r3XKpYn d7fCjT+mYtx0aGdrGfIQ3A6iaVt68ldEDvZyIvxf5KoZR3rvYugg2lnt3nbtqAhtVwEV eRC7SnfJNanurNr70krGQughLf/9OiImSJSVOJmVc8UzFfZuDE/8EWawOQFJrUA4I44m PS3g== X-Gm-Message-State: APjAAAXn6iHO8Z/uncH2r8KANA/Xls0a0O10PZzFz0YRrvYo+2k0XX9B TV0Ye9go7EPRFwapXkKknK9zkFBdWrt3DRAPVgg= X-Google-Smtp-Source: APXvYqwd/sgHhemJ3iy4UBxxmakO+x1BJuAad9rNud+S/gRxa9kfZ79xwJPESblbNgpk2eel+ypMeP1HvmX7KsQeI1A= X-Received: by 2002:a0c:f7c3:: with SMTP id f3mr17098147qvo.52.1579798303255; Thu, 23 Jan 2020 08:51:43 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 23 Jan 2020 16:51:31 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000aeba98059cd17412" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000aeba98059cd17412 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 23, 2020 at 4:28 PM Stefan Monnier wrote: > > >> Good point: `minibuffer-force-complete-and-exit` probably needs to be > >> changed accordingly (i.e. to just `exit-minibuffer` when `required` > >> was nil). > > How will it determine that? minibuffer-completion-confirm seems to be the > > same whether require-match is t or not. > > We could introduce a new `minibuffer-require-match` variable (and mark > `minibuffer-completion-confirm` obsolete). +1. Not particularly pretty, but it would you join the ranks of many other `minibuffer-*` special variables that hold these kinds of things. -- Jo=C3=A3o T=C3=A1vora --000000000000aeba98059cd17412 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Jan 23, 2020 at 4:28 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote= :
>
> >> Good point: `minibuffer-force-complete-and-exit`= probably needs to be
> >> changed accordingly (i.e. to just `e= xit-minibuffer` when `required`
> >> was nil).
> > How= will it determine that? minibuffer-completion-confirm seems to be the
&= gt; > same whether require-match is t or not.
>
> We could i= ntroduce a new `minibuffer-require-match` variable (and mark
> `= minibuffer-completion-confirm` obsolete).

+1. Not particularl= y pretty, but it would you join the ranks of many
other `min= ibuffer-*` special variables that hold these kinds of things.
--
Jo=C3=A3o T=C3=A1vora
--000000000000aeba98059cd17412-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jan 2020 22:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157981725624715 (code B ref 38992); Thu, 23 Jan 2020 22:08:02 +0000 Received: (at 38992) by debbugs.gnu.org; 23 Jan 2020 22:07:36 +0000 Received: from localhost ([127.0.0.1]:53285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iukdU-0006QZ-0P for submit@debbugs.gnu.org; Thu, 23 Jan 2020 17:07:36 -0500 Received: from mail-lj1-f176.google.com ([209.85.208.176]:46795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iukdP-0006QI-R5 for 38992@debbugs.gnu.org; Thu, 23 Jan 2020 17:07:34 -0500 Received: by mail-lj1-f176.google.com with SMTP id m26so19008ljc.13 for <38992@debbugs.gnu.org>; Thu, 23 Jan 2020 14:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=lpfNEl7tHSaU+UZKBqXAuCL5H19NO7tpCtTaWW1z7tA=; b=QyEMpTOCDA67MG7bRa4Nu5UdVddGaLG2txj20o2ESQ/qAk1YoYHkQ/AAOdw57ULz04 SIYCiosz48vlMSKVS/GGGMpZZxM7v9hgYx6X63++CZVjs31PHfNDUb4vFboaFYGfWjGi DYXxV6j5pgJmsLJNNRGvJQQ4SKf7AGnzhcqfQ1kFoSXD5fZYZ0fftUzN5oc7rquhNtug Wh2AIW9qqNBS5zJY7a96V3zKFd9WHRID+dCitzE4+SA2QjWdtH1TH7txC4AESk90H7PY exz0ZGMVWL73R4TLZLufkPF0f5mA/BrgnS2L+QnCmgbmI2ZG2ZIIalvuS4dcWbUX5pKo 07ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:subject:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=lpfNEl7tHSaU+UZKBqXAuCL5H19NO7tpCtTaWW1z7tA=; b=jaPYepTWxP0qd1xXOWYuC6B7nmdL1nfr+J38VG01WEQPTzTA65lREmDxNpDdpsFD8R SsW7j9cEMdWztCy0AUlGEN+FKV1MAvVyztCn6QgRpWOFQ8esn1Pf8Lqb/sk0CYJgqBy7 DLSMpG/9OypfJWG1VIpowaK49/FnfyZk1bXLafJHLuFHqo4BvV5syEl18f9A9SX3FA8E Li3Nk4n3mGFMIZelq/5hbGue81ugmhlgfWkjqHz6xTGX4X3KccWjTUS2FGWS1tgdMeH5 0EHTPRw8yJVJ1/mOHZwC45oXs95CoTr6I6nLXadbO6TaMgIgIDlFTa0D+07jlzciXH4c /rsA== X-Gm-Message-State: APjAAAWf/rQGPpHDSMSnyC57Sad9+raqrXt+Xwy4oCibHEQFIErpTCsj Dx/TJskLzsEfYpT9TaD3iR4= X-Google-Smtp-Source: APXvYqwOm8tbb3odycv3Hftg0d0jxtIMlrBiVGn7LnHmSSKl/aqCjRcXp5o95Lz37sQOuAZ43Fnotw== X-Received: by 2002:a2e:461a:: with SMTP id t26mr309405lja.204.1579817245729; Thu, 23 Jan 2020 14:07:25 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id g85sm1724393lfd.66.2020.01.23.14.07.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Jan 2020 14:07:24 -0800 (PST) From: Dmitry Gutov References: <288610218.111246.1578330546916@office.mailbox.org> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> Message-ID: <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> Date: Fri, 24 Jan 2020 01:07:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------806FA57C73A261A43ECC7595" Content-Language: en-US X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 23.01.2020 19:28, Stefan Monnier wrote: > We could introduce a new `minibuffer-require-match` variable (and mark > `minibuffer-completion-confirm` obsolete). Why don't we just co-opt the older variable. A rename can come later. See patch 1. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: yandex.ru] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.176 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.176 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) This is a multi-part message in MIME format. --------------806FA57C73A261A43ECC7595 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 23.01.2020 19:28, Stefan Monnier wrote: > We could introduce a new `minibuffer-require-match` variable (and mark > `minibuffer-completion-confirm` obsolete). Why don't we just co-opt the older variable. A rename can come later. See patch 1. Here's another issue related to the previous proposed fix: why *would* M-j exit minibuffer in all cases? It currently doesn't honor REQUIRE-MATCH=t (or the confirm- values, but I don't care about that). The default completing-read, as well as icomplete-mode, both honor it. The patch 2 fixes that. Please take a look, y'all. --------------806FA57C73A261A43ECC7595 Content-Type: text/x-patch; name="0001-Honor-require-match-nil-in-icomplete-fido-ret.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Honor-require-match-nil-in-icomplete-fido-ret.patch" >From 73728a7928568c883650cc403194c3b95348a08b Mon Sep 17 00:00:00 2001 From: Dmitry Gutov Date: Fri, 24 Jan 2020 00:51:06 +0300 Subject: [PATCH 1/2] Honor require-match=nil in icomplete-fido-ret --- doc/lispref/minibuf.texi | 8 +++++--- lisp/emacs-lisp/crm.el | 3 +-- lisp/icomplete.el | 2 +- lisp/minibuffer.el | 8 +++++--- src/minibuf.c | 3 ++- 5 files changed, 14 insertions(+), 10 deletions(-) diff --git a/doc/lispref/minibuf.texi b/doc/lispref/minibuf.texi index ab806a9055..c881deeaf4 100644 --- a/doc/lispref/minibuf.texi +++ b/doc/lispref/minibuf.texi @@ -1127,11 +1127,13 @@ Completion Commands @end defvar @defvar minibuffer-completion-confirm -This variable determines whether Emacs asks for confirmation before -exiting the minibuffer; @code{completing-read} binds this variable, +This variable determines whether Emacs requires matching input or asks +for confirmation before exiting the minibuffer; +@code{completing-read} binds this variable, and the function @code{minibuffer-complete-and-exit} checks the value before exiting. If the value is @code{nil}, confirmation is not -required. If the value is @code{confirm}, the user may exit with an +required. If the value is @code{t}, a match is required. +If the value is @code{confirm}, the user may exit with an input that is not a valid completion alternative, but Emacs asks for confirmation. If the value is @code{confirm-after-completion}, the user may exit with an input that is not a valid completion diff --git a/lisp/emacs-lisp/crm.el b/lisp/emacs-lisp/crm.el index 65483d0813..e8ab558a19 100644 --- a/lisp/emacs-lisp/crm.el +++ b/lisp/emacs-lisp/crm.el @@ -252,8 +252,7 @@ completing-read-multiple (let* ((minibuffer-completion-table #'crm--collection-fn) (minibuffer-completion-predicate predicate) ;; see completing_read in src/minibuf.c - (minibuffer-completion-confirm - (unless (eq require-match t) require-match)) + (minibuffer-completion-confirm require-match) (crm-completion-table table) (map (if require-match crm-local-must-match-map diff --git a/lisp/icomplete.el b/lisp/icomplete.el index a1a67e2330..52429fdf37 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -541,7 +541,7 @@ icomplete-exhibit (icomplete--completion-table) (icomplete--completion-predicate) (if (window-minibuffer-p) - (not minibuffer-completion-confirm))))) + (eq minibuffer-completion-confirm t))))) (buffer-undo-list t) deactivate-mark) ;; Do nothing if while-no-input was aborted. diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 0589211877..56d3b259b4 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -1386,7 +1386,10 @@ minibuffer-force-complete-and-exit (minibuffer-prompt-end) (point-max) #'exit-minibuffer ;; If the previous completion completed to an element which fails ;; test-completion, then we shouldn't exit, but that should be rare. - (lambda () (minibuffer-message "Incomplete")))) + (lambda () + (if minibuffer-completion-predicate + (minibuffer-message "Incomplete") + (exit-minibuffer))))) (defun minibuffer-force-complete (&optional start end dont-cycle) "Complete the minibuffer to an exact match. @@ -3734,8 +3737,7 @@ completing-read-default (let* ((minibuffer-completion-table collection) (minibuffer-completion-predicate predicate) - (minibuffer-completion-confirm (unless (eq require-match t) - require-match)) + (minibuffer-completion-confirm require-match) (base-keymap (if require-match minibuffer-local-must-match-map minibuffer-local-completion-map)) diff --git a/src/minibuf.c b/src/minibuf.c index c5f6145690..84e94c0627 100644 --- a/src/minibuf.c +++ b/src/minibuf.c @@ -2028,8 +2028,9 @@ syms_of_minibuf (void) Vminibuffer_completion_predicate = Qnil; DEFVAR_LISP ("minibuffer-completion-confirm", Vminibuffer_completion_confirm, - doc: /* Whether to demand confirmation of completion before exiting minibuffer. + doc: /* Whether matching completion or confirmation is required. If nil, confirmation is not required. +If t, match is strictly required, can't finish input otherwise. If the value is `confirm', the user may exit with an input that is not a valid completion alternative, but Emacs asks for confirmation. If the value is `confirm-after-completion', the user may exit with an -- 2.20.1 --------------806FA57C73A261A43ECC7595 Content-Type: text/x-patch; name="0002-Make-M-j-in-fido-mode-honor-REQUIRE-MATCH-t.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0002-Make-M-j-in-fido-mode-honor-REQUIRE-MATCH-t.patch" >From c4130a620f913422c520c2ccf648eb409035e1d9 Mon Sep 17 00:00:00 2001 From: Dmitry Gutov Date: Fri, 24 Jan 2020 01:06:17 +0300 Subject: [PATCH 2/2] Make M-j in fido-mode honor REQUIRE-MATCH=t --- lisp/icomplete.el | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lisp/icomplete.el b/lisp/icomplete.el index 52429fdf37..5e674b769d 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -284,6 +284,13 @@ icomplete-fido-ret (t (icomplete-force-complete-and-exit))))) +(defun icomplete-fido-exit () + "Exit minibuffer properly honoring `minibuffer-completion-confirm'." + (interactive) + (if minibuffer-completion-confirm + (minibuffer-complete-and-exit) + (exit-minibuffer))) + (defun icomplete-fido-backward-updir () "Delete char before or go up directory, like `ido-mode'." (interactive) @@ -299,7 +306,7 @@ icomplete-fido-mode-map (define-key map (kbd "RET") 'icomplete-fido-ret) (define-key map (kbd "C-m") 'icomplete-fido-ret) (define-key map (kbd "DEL") 'icomplete-fido-backward-updir) - (define-key map (kbd "M-j") 'exit-minibuffer) + (define-key map (kbd "M-j") 'icomplete-fido-exit) (define-key map (kbd "C-s") 'icomplete-forward-completions) (define-key map (kbd "C-r") 'icomplete-backward-completions) (define-key map (kbd "") 'icomplete-forward-completions) -- 2.20.1 --------------806FA57C73A261A43ECC7595-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jan 2020 22:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15798181561532 (code B ref 38992); Thu, 23 Jan 2020 22:23:02 +0000 Received: (at 38992) by debbugs.gnu.org; 23 Jan 2020 22:22:36 +0000 Received: from localhost ([127.0.0.1]:53302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuks0-0000Oe-BU for submit@debbugs.gnu.org; Thu, 23 Jan 2020 17:22:36 -0500 Received: from mail-lj1-f170.google.com ([209.85.208.170]:40475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iukry-0000OO-F3 for 38992@debbugs.gnu.org; Thu, 23 Jan 2020 17:22:34 -0500 Received: by mail-lj1-f170.google.com with SMTP id n18so103828ljo.7 for <38992@debbugs.gnu.org>; Thu, 23 Jan 2020 14:22:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=roo6VzZdNFWq8pzfLF2E78a+yatEbtpdrWc7Cn1uwXY=; b=Hs0AW/4DqCpmgUHeqRghJh0x39mHJ4ZXWLug7QgpmQ0v4SeHtNdmvAR0AmlN2JNe09 enGoauRBa4V4UHsX0IjhvIlysbEyKv+H9DI3tgxtbt0XbdTPCYAWiClgbLkX3FHdZAVm gUolLfDzlAFpcNtlBSih/5SIzTYprUBnuUXmxJ2O8/+RKDKkBe4QS9gOR6SQRdddTNwv 7rwI70BwKEwc9Dexmse68TNIllymLvhH6keeKMcp1MsTYFr7f04KdodWwH/RuIds2Z3i t5oTeVcmISdOw0MZySUuwsilGePZ/QskxEYa3SugUJr0Htw2jsveGCb/Ew8urh1ij8zn Z8FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=roo6VzZdNFWq8pzfLF2E78a+yatEbtpdrWc7Cn1uwXY=; b=FoXFoiBJyDPVWJmWQCxGig+aZtjIW6D93XMwSHtcbylq18vaanb3CaZZmznvvyRg1N RPIHZn0oNGtguigfTHq2+aHBfac5TMFpoTfXDj+Q/3pZKj+5NAmrUnacHb6Fa1kfovbO eX4iOVlzzTDDkkM3EZOlyLyYpb0Od8w89fL2kcsfeiNQt04va7/j2ePiqEm21Kr6iCtR 2QywEsSLBDhMmEGTJ9ZlS1j7hp+9xcYRQL8nPkzlJaMm8TqJKYEvUnXusPQtzK7g4tyy gwjp1UwSQdZXeOPtNrod9KGe0ltRiDuRinjzMf8vUZ9FJKcEzNplUAQIKwTphorA8Mwh UOdw== X-Gm-Message-State: APjAAAXUDD0xI4U4EQaBHQpVVvJ0emmMexnR/PHsINl97Bgz3MvsgXwF SKTMkqAHSqSdWkKR/a7fhyI= X-Google-Smtp-Source: APXvYqykoNsRJqLSjEhp+j37KF9Zfx7Mw5oSGInBI0UXVyGBkzcJ9EJw2qkkLqfphIzBWHRDinTo6A== X-Received: by 2002:a2e:9e4c:: with SMTP id g12mr333329ljk.15.1579818148493; Thu, 23 Jan 2020 14:22:28 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id z13sm1746979lfi.69.2020.01.23.14.22.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Jan 2020 14:22:27 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> From: Dmitry Gutov Message-ID: <23491eb3-d377-cf50-575d-c6580bacd8cf@yandex.ru> Date: Fri, 24 Jan 2020 01:22:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 21.01.2020 11:12, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= wrote: > - pressing ret quickly before the first completions appear, with a > default, like in c-h f. There should be no wait. > - same but slowly, the default shoul [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.170 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.170 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 21.01.2020 11:12, João Távora wrote: > - pressing ret quickly before the first completions appear, with a > default, like in c-h f. There should be no wait. > - same but slowly, the default should be on top. > - m-x man on an word that doesn't perfectly match the candidates, like > "read" (I think). I think none of these will be affected by my patches, but please see for yourself. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jan 2020 14:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15798751307715 (code B ref 38992); Fri, 24 Jan 2020 14:13:02 +0000 Received: (at 38992) by debbugs.gnu.org; 24 Jan 2020 14:12:10 +0000 Received: from localhost ([127.0.0.1]:53580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuzgw-00020N-0f for submit@debbugs.gnu.org; Fri, 24 Jan 2020 09:12:10 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuzgv-00020B-0y for 38992@debbugs.gnu.org; Fri, 24 Jan 2020 09:12:09 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5AB87100A9C; Fri, 24 Jan 2020 09:12:03 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8F8E71009B3; Fri, 24 Jan 2020 09:12:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1579875121; bh=9Ab6DPA4MkKPWCqYpSz/vmqg8+QF0pM267KWFwuTt60=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HpMR5EEAsTXkXE9PKpUje2Q996FiImZ0TeEeB3268uETADndJDFQo8mZ50MwLfaHX fr57pMqwTtsBJ4UgqY8WXWB2mTZsuIaDKUrv0PAqePH1Py6UbVfGvKWmfKqqYTrdng qMWs8uB0oCvVr/w4UGeJHLC1wFLAmlNqfY33Be51J9rSnhxwUGSNadqSGtOElePu6g Fa/q/6HPtfnvWCC+b4nq31Uw2svs4i7J9hPbJqBAeRHMxU9x7yf+TJ2N3bkPnONH4I AE0X6FUvIw65iM+iPaI5+YJxzyL6TUGfBLrHNXipF2y5p8Q7zplIgxNOjfLEe0oJUz DYjgA5USF00AA== Received: from pastel (69-196-141-61.dsl.teksavvy.com [69.196.141.61]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 43F1C120C73; Fri, 24 Jan 2020 09:12:01 -0500 (EST) From: Stefan Monnier Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> Date: Fri, 24 Jan 2020 09:11:55 -0500 In-Reply-To: <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> (Dmitry Gutov's message of "Fri, 24 Jan 2020 01:07:15 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> We could introduce a new `minibuffer-require-match` variable (and mark >> `minibuffer-completion-confirm` obsolete). > Why don't we just co-opt the older variable. It's arguably breaking compatibility. But you might be right that maybe it's a non issue. A quick `grep` shows that outside Emacs itself, at least Helm might be affected. > Here's another issue related to the previous proposed fix: why *would* M-j > exit minibuffer in all cases? It currently doesn't honor REQUIRE-MATCH=t (or > the confirm- values, but I don't care about that). The default > completing-read, as well as icomplete-mode, both honor it. The patch > 2 fixes that. Sounds like a plain bug fix, yes. > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -1386,7 +1386,10 @@ minibuffer-force-complete-and-exit > (minibuffer-prompt-end) (point-max) #'exit-minibuffer > ;; If the previous completion completed to an element which fails > ;; test-completion, then we shouldn't exit, but that should be rare. > - (lambda () (minibuffer-message "Incomplete")))) > + (lambda () > + (if minibuffer-completion-predicate > + (minibuffer-message "Incomplete") > + (exit-minibuffer))))) I think this is a typo for `minibuffer-completion-confirm`, right? Stefan From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jan 2020 14:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15798763339580 (code B ref 38992); Fri, 24 Jan 2020 14:33:01 +0000 Received: (at 38992) by debbugs.gnu.org; 24 Jan 2020 14:32:13 +0000 Received: from localhost ([127.0.0.1]:53600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iv00K-0002UR-L4 for submit@debbugs.gnu.org; Fri, 24 Jan 2020 09:32:12 -0500 Received: from mail-lj1-f173.google.com ([209.85.208.173]:38567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iv00I-0002UF-KE for 38992@debbugs.gnu.org; Fri, 24 Jan 2020 09:32:11 -0500 Received: by mail-lj1-f173.google.com with SMTP id w1so2732593ljh.5 for <38992@debbugs.gnu.org>; Fri, 24 Jan 2020 06:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YthWyxxQSP4U3lNoPKUpu1eMocJmwsvpC0157llSamU=; b=cbCx1njDIa5qyVqYVLySqbzvrFqnMYJArmoxaHjP5Kqlqnipj62BMLCMf3AHbwRXnZ 9xnIQNDm7ATaNpid6Um255Akq3Vjy++uFX4+PXdchqJyzRFVmNivvQuq0LlWgLEScjwY hDNnsrzrFXysOmyfNBmuaM5T+UqFEf0FAbemf0FhpztvVJQ4ZNXaCK//SsMI0wm9Zs71 EW/m17FxtVdS7aaNBUGXglDjSk2+FfFhla1B0ac1zrIPJ5Vpnho5LqHJ+s1Vmnqr6FyU OpTGoAsRvknTuTmw7IU0olhiurfvwlJGeZfxRdc5RAwK6sTo1BOjftNh9sPdFVWRU1dG aFkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YthWyxxQSP4U3lNoPKUpu1eMocJmwsvpC0157llSamU=; b=s1+tQNJFLevMin9N7q8hhUTX3j5PedJUunxBHVpoQIgpqMlcxA9/NiNrb6+akeevPc /dZl7vrzMVDJwmZw91sCBbStF5tlr9xROYxr45yq7JgGN32IQL+hxlNyu1mZhjZQv9CK /KAkjBdqO4AbwxYR0uweH5SQFkZueWpSeW2dLX3la83SN0WFZmhq0UtgzmQb630fStwS OjRwdcjDIcfB/eIRtkK5mf7DoTU1J6vBJA9l4d4fGLJU2SjiUL+Gz0KEz5f1TE5m3udu QYndcaXClKiFpl5z58huYU69vPoJJdm57gFzQr4Rs3bZ9ifXQBrfXKjj1QRHixWIABqw yS4g== X-Gm-Message-State: APjAAAUpqZO8/L2ggBLlG0ie7lv+5debFhhz9OVGnE+cdraGdk7s+FCm GKKi7/runnEIcGJRaoJzxTg= X-Google-Smtp-Source: APXvYqyTTBXCZORLaEOf7Q0dSeG3JtQb8RX38pA+/3eOeMQKKFJ+eq5i+NHKdToesxy3vhPC8gS5pg== X-Received: by 2002:a2e:800b:: with SMTP id j11mr2479357ljg.126.1579876324594; Fri, 24 Jan 2020 06:32:04 -0800 (PST) Received: from [172.30.19.30] (178-55-141-90.bb.dnainternet.fi. [178.55.141.90]) by smtp.googlemail.com with ESMTPSA id w6sm2812406lfq.95.2020.01.24.06.31.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jan 2020 06:32:03 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> From: Dmitry Gutov Message-ID: Date: Fri, 24 Jan 2020 17:31:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 24.01.2020 17:11, Stefan Monnier wrote: > It's arguably breaking compatibility. But you might be right that maybe > it's a non issue. A quick `grep` shows that outside Emacs itself, at > least Helm might be affected. I don't disagree. But I'm not sure how to keep the backward compatibility either. Unless the old variable is kept as-is (both assigned and referred to) and the new one is looked up solely in one place (minibuffer-force-complete-and-exit). This way, we can't mark the old one as obsolete, though. (BTW, at least one reference to minibuffer-completion-confirm in Emacs binds it to t already; not sure what's the intended effect: lisp/calc/calc-store.el:197). > I think this is a typo for `minibuffer-completion-confirm`, right? Ummm, yes. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jan 2020 14:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15798765449900 (code B ref 38992); Fri, 24 Jan 2020 14:36:01 +0000 Received: (at 38992) by debbugs.gnu.org; 24 Jan 2020 14:35:44 +0000 Received: from localhost ([127.0.0.1]:53604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iv03k-0002Zc-6Q for submit@debbugs.gnu.org; Fri, 24 Jan 2020 09:35:44 -0500 Received: from mail-qk1-f174.google.com ([209.85.222.174]:43036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iv03i-0002ZO-2G for 38992@debbugs.gnu.org; Fri, 24 Jan 2020 09:35:43 -0500 Received: by mail-qk1-f174.google.com with SMTP id j20so2176662qka.10 for <38992@debbugs.gnu.org>; Fri, 24 Jan 2020 06:35:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gm43aY0YnhsJ1zxNxWDc+Two0lVrO2NaF9I2RK1M1aA=; b=JiubGBvNiNu0vQQODH9sqhzGvOv+55D2MtZ9fwSDHKSA+wmylH7xDz4Su71b9XSMpJ /obpYIgwQYXahMR3vIa5dL8wwobpZxNwY8aycfNHRvEpqu+TbLkbAYRg7/IHSL6sgfMl a+k5/s7FHBZxA21ZgNNcz14KIVJYtK48SST/nk2/EEBZ+Tm44kXs5v2ahHXjhmEjCsB1 CneE+T5k3QxfzxpKdFjWU7VDpgfQZH2aDEc1drG0FEt1C1MnhRXygxLhbigQf+8yWn+p zLiaUrrhD/HkhNqOfG5LhW1R2Mwfnix5VG79rXKSaAIwFJ4IQc8mnmQU77boIUiJ81cK d5MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gm43aY0YnhsJ1zxNxWDc+Two0lVrO2NaF9I2RK1M1aA=; b=fanOQQwSOnUsprx7GiYZHCZRRN/cDQR5d9ck0wGehIctZ+kfg1mc4PP8KXZZEXUVeO Ovu36OEMTkbBzXOVD+fV3V/xWna0qLMyciAuI8Uk4gM6cVZsOhtBYIngPvShCX8B4SJ0 V/wPT+Nu2yACi9BBPht+wlqw2zRpPt/m1S9lYf/83wPVOQkMq/cn6hH+5QHHJcpzHOVb k7E5EJzJomDxofAR2fYOcWIBc9kFXWOw/BmBlGJWb7ib8UBEoXgORHfcrPwyS2q8J0ss 4GHkKqSgkwAE9hPZrValZPkjqEea+CmcQaqEN8TKFxAWv9oKFSSHR7M9GO5nDFEhJpM5 kksQ== X-Gm-Message-State: APjAAAUZxCrrz0h/EnYT1nw0Db46HqoV0FrjeDTDJlSBwqWEH78oBgBV p4cd4sIH+k5fFwAccttQxBAb3G1JA3UZs1xqYK0= X-Google-Smtp-Source: APXvYqx6n+Yw2CPtUjkZ9CjsOvIDk/V5YW6jEf8781RPgvC3I4dp/9Q/E6WyCTO61LiuXqbWEd5u7VGmGZ+Ew4WmTG8= X-Received: by 2002:a37:8ec7:: with SMTP id q190mr2794768qkd.412.1579876536566; Fri, 24 Jan 2020 06:35:36 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <23491eb3-d377-cf50-575d-c6580bacd8cf@yandex.ru> In-Reply-To: <23491eb3-d377-cf50-575d-c6580bacd8cf@yandex.ru> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Fri, 24 Jan 2020 14:35:25 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000c04694059ce3ab57" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000c04694059ce3ab57 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 23, 2020 at 10:22 PM Dmitry Gutov wrote: > On 21.01.2020 11:12, Jo=C3=A3o T=C3=A1vora wrote: > > - pressing ret quickly before the first completions appear, with a > > default, like in c-h f. There should be no wait. > > - same but slowly, the default should be on top. > > - m-x man on an word that doesn't perfectly match the candidates, like > > "read" (I think). > > I think none of these will be affected by my patches, but please see for > yourself. > Yes, you're probably right. I don't have time to check your patches right now, sorry. But none of what you said sounds bad, and Stefan also gives some confidence. So I think you can push to emacs-27. Jo=C3=A3o --000000000000c04694059ce3ab57 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Thu, Jan 23, 2020 at 10:22 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
=
On 21.01.2020 11:12= , Jo=C3=A3o T=C3=A1vora wrote:
> - pressing ret quickly before the first completions appear, with a > default, like in c-h f. There should be no wait.
> - same but slowly, the default should be on top.
> - m-x man on an word that doesn't perfectly match the candidates, = like
> "read" (I think).

I think none of these will be affected by my patches, but please see for yourself.

Yes, you're probably righ= t.=C2=A0=C2=A0 I don't have time to check your
patches r= ight now, sorry.=C2=A0 But none of what you said sounds
bad, and = Stefan also gives some confidence.

So I think you = can push to emacs-27.

Jo=C3=A3o
--000000000000c04694059ce3ab57-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Jan 2020 21:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15803330421493 (code B ref 38992); Wed, 29 Jan 2020 21:25:02 +0000 Received: (at 38992) by debbugs.gnu.org; 29 Jan 2020 21:24:02 +0000 Received: from localhost ([127.0.0.1]:34655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwuob-0000O0-KW for submit@debbugs.gnu.org; Wed, 29 Jan 2020 16:24:01 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwuoa-0000NY-7J for 38992@debbugs.gnu.org; Wed, 29 Jan 2020 16:24:00 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9CEEB10031F; Wed, 29 Jan 2020 16:23:54 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E43571000F2; Wed, 29 Jan 2020 16:23:52 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1580333032; bh=vEMi3E7rh0vk6jGB8Kisx3cjWhAG0jh15SHjyIifrs4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DYLx5Ntz0y/vSpzrCMVOH8m3yK9NOYisgFkXY2V2kPN36SwI+TvUj/e7FhcDuMFr7 mHKK5NtGjMFbF7ntYauEm31GQw82wsHiQXeR2S+neWOFUh6Rs9MMZNOH+Gy4YU5mrW iOHRWJd/Hby/W2ugBpMDIn5M+kjjRfzBFJY0qlDJLJfYlLVcnwkmRueOp1yc6pntue 6oIR1FpT/zkoWAU1nRtP5USGtCU8ltmUthd5//NNZ9gCTquYY6m6WqB8yJNAtUyz4m NB2n1+OGrzouY3RUg4hPKqMPPM2fMpNq1cf2C7J680FX6OJvwY1uPpoWfeCq3267My hpC1390x2kGNw== Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8CFE61203C7; Wed, 29 Jan 2020 16:23:52 -0500 (EST) From: Stefan Monnier Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> Date: Wed, 29 Jan 2020 16:23:51 -0500 In-Reply-To: (Dmitry Gutov's message of "Fri, 24 Jan 2020 17:31:20 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> It's arguably breaking compatibility. But you might be right that maybe >> it's a non issue. A quick `grep` shows that outside Emacs itself, at >> least Helm might be affected. > I don't disagree. But I'm not sure how to keep the backward > compatibility either. > > Unless the old variable is kept as-is (both assigned and referred to) and > the new one is looked up solely in one place > (minibuffer-force-complete-and-exit). This way, we can't mark the old > one as obsolete, though. Inded. > (BTW, at least one reference to minibuffer-completion-confirm in Emacs binds > it to t already; not sure what's the intended effect: > lisp/calc/calc-store.el:197). Maybe it used to be that `minibuffer-completion-confirm` used to be set to something like (not (memq require-match '(nil t)))? In any case, I do know it used to be that `minibuffer-completion-confirm` was only boolean. Stefan From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 01:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158043530627814 (code B ref 38992); Fri, 31 Jan 2020 01:49:01 +0000 Received: (at 38992) by debbugs.gnu.org; 31 Jan 2020 01:48:26 +0000 Received: from localhost ([127.0.0.1]:36424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixLQ2-0007EY-3e for submit@debbugs.gnu.org; Thu, 30 Jan 2020 20:48:26 -0500 Received: from mail-lj1-f172.google.com ([209.85.208.172]:36481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixLQ0-0007EL-FK for 38992@debbugs.gnu.org; Thu, 30 Jan 2020 20:48:25 -0500 Received: by mail-lj1-f172.google.com with SMTP id r19so5488992ljg.3 for <38992@debbugs.gnu.org>; Thu, 30 Jan 2020 17:48:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IhoVR01WOf4k06Jg5t083s7EFqIja8e8FSVqQbZMUyI=; b=G+xW+mBR/q9b4d0WmRkJVDY21eGDdpJCLgVOr9TtfBum/I1s87QQhZc/2IQNvvhBdE b+USo7N9QpPON6nXNTB5ZbPxhcBAA3pE5dJeZ2K0A9Sf7cQWqFAXplx1as2fEWLgS24+ TkTu9QLSrFxTE3QhASq9fd6wjBkWRcMKFYCsdlTutYonlEAL/4c47AOVJXUCCLfW2T5P YTr3/3ZDUFNr6Sefn2OyigHVmM1ugPp1i2x9r1fX7RXsiqLJ5eYd3wjBghTojqvnL0us Bb4y6Ig9guzxoX2feMrzD7/GToRqm2wkzuVwD1p77Ryh/gnZg55oSpxfzf6yFUHjrxQG CVOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IhoVR01WOf4k06Jg5t083s7EFqIja8e8FSVqQbZMUyI=; b=d9HT8V3k/7e2EDe+RBwz4ufF3PWuSYkmFQiXZuneu3/OlOqgSfVkKMDs+954UwpYJ4 kSq2FPzFYU9CCNbKbunmiQPkxMep2GxkHVT0+DDnos/gzBeGEyfwR/E0nLhgrr8KzAcN lAbC+1sX5FcWwHjc8Eccyd9myE8cQWmJEXoNaeE8gKZIie8DKUEoKXdMCuCb5aISYk5R 1sSAHOy3VA/N2qUvq7P0cEk9904fCxfIFtrUyNiY+gVwTIi2wTzyCKLrdH4KmbUuy1nH QeNLZmHY7g48yMUBFCKZ6x1lV4aloYWFx7TZUGhcBUZ6degv/70FwXF6itqP5HsbUVUT Wkqg== X-Gm-Message-State: APjAAAWxEJHQ6on2CHKysSTRs65ymvCDrZC4q6Nt3FombMPczVMcWJAh dMTTSwsuNe+NXsk4o+yGAXE= X-Google-Smtp-Source: APXvYqwJKz18JzACqpjy6ivp4P/vhxO0NJzcclbaXcX/L/Qka+iNb1+Fa4b54a4T2g0Tyc7QOwho4w== X-Received: by 2002:a2e:978c:: with SMTP id y12mr4415282lji.167.1580435298390; Thu, 30 Jan 2020 17:48:18 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id r21sm3846694ljn.64.2020.01.30.17.48.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jan 2020 17:48:17 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> From: Dmitry Gutov Message-ID: <2a56337b-50f6-38a1-a73f-8a4cbdda22f0@yandex.ru> Date: Fri, 31 Jan 2020 04:48:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 30.01.2020 0:23, Stefan Monnier wrote: > Maybe it used to be that `minibuffer-completion-confirm` used to be set > to something like (not (memq require-match '(nil t)))? Not exactly. It was set to (not require-match), basically. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.172 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.172 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 30.01.2020 0:23, Stefan Monnier wrote: > Maybe it used to be that `minibuffer-completion-confirm` used to be set > to something like (not (memq require-match '(nil t)))? Not exactly. It was set to (not require-match), basically. The last place that changed was commit 695deb1857d, almost 18 years ago by your hand. > In any case, I do know it used to be that > `minibuffer-completion-confirm` was only boolean. Speaking of, there's this condition in icomplete-exhibit that computes the require-match argument of icomplete-completions as (if (window-minibuffer-p) (not minibuffer-completion-confirm)) but it only affects cosmetics. It seems wrong (to me) now, but it makes sense looking at the code before the aforementioned commit. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15804766431344 (code B ref 38992); Fri, 31 Jan 2020 13:18:02 +0000 Received: (at 38992) by debbugs.gnu.org; 31 Jan 2020 13:17:23 +0000 Received: from localhost ([127.0.0.1]:36676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixWAl-0000Lb-Es for submit@debbugs.gnu.org; Fri, 31 Jan 2020 08:17:23 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixWAj-0000LO-K6 for 38992@debbugs.gnu.org; Fri, 31 Jan 2020 08:17:22 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A5978100A27; Fri, 31 Jan 2020 08:17:15 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D548C100943; Fri, 31 Jan 2020 08:17:13 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1580476633; bh=FJ/AFDfYqh0qKpS8/gMW9jERbYhB2/Jgc5RgORxFfJc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=hhM9QQwdPJnueHjMB9YVrcO3dKqaLcikzsGunLeSy8MAq4vcRsuRSIGE0dNYhwXhd i7r6bsSDmLCHza9O18cEoG8CJHVgh0RzwaCBMY7Ku+noMdlcw2ZrpsYgZNxuKIfaps AcMkjUVYL/3+tJo0knYaLmWSS3DrylVcazSVeEmz3eo6ZOoNplYXJkMCk38bDbqEp/ 7vtJT3LfL3YSte5gamYqva2gutmbkCkSkQkF04cDsK5CqGlkZXCr/OCq52K/oqvmMN JoYmNnt5rQ/BscaRA5XLrX+UST+71ZfARRgJzlQA2BhLUs4uKW4myoqiBnvD65gQb9 jbTxUciLq89kg== Received: from pastel (unknown [45.72.213.248]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 865FC121015; Fri, 31 Jan 2020 08:17:13 -0500 (EST) From: Stefan Monnier Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <2a56337b-50f6-38a1-a73f-8a4cbdda22f0@yandex.ru> Date: Fri, 31 Jan 2020 08:17:12 -0500 In-Reply-To: <2a56337b-50f6-38a1-a73f-8a4cbdda22f0@yandex.ru> (Dmitry Gutov's message of "Fri, 31 Jan 2020 04:48:16 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Maybe it used to be that `minibuffer-completion-confirm` used to be set >> to something like (not (memq require-match '(nil t)))? > Not exactly. It was set to (not require-match), basically. Ah, sounds right. > The last place that changed was commit 695deb1857d, almost 18 years ago by > your hand. Guilty as charged (IIRC this was done when I added the ability for `C-x C-f` and `C-x b` to ask for confirmation before opening a new file/buffer). > Speaking of, there's this condition in icomplete-exhibit that computes the > require-match argument of icomplete-completions as > > (if (window-minibuffer-p) > (not minibuffer-completion-confirm)) > > but it only affects cosmetics. It seems wrong (to me) now, but it makes > sense looking at the code before the aforementioned commit. I wouldn't be surprised that I missed some spots, back then, indeed. Stefan From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 23:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 38992@debbugs.gnu.org, Eli Zaretskii , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.1580512694874 (code B ref 38992); Fri, 31 Jan 2020 23:19:02 +0000 Received: (at 38992) by debbugs.gnu.org; 31 Jan 2020 23:18:14 +0000 Received: from localhost ([127.0.0.1]:38208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixfYE-0000E2-0b for submit@debbugs.gnu.org; Fri, 31 Jan 2020 18:18:14 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:40317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixfYC-0000Dq-Um for 38992@debbugs.gnu.org; Fri, 31 Jan 2020 18:18:13 -0500 Received: by mail-lj1-f195.google.com with SMTP id n18so8773448ljo.7 for <38992@debbugs.gnu.org>; Fri, 31 Jan 2020 15:18:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AkGFo/95YKtbHGeJ5M7ECBHv1mLfkCURPPDIDmYR0qk=; b=SlntUUvxk3lIz2dCpcaThWWobWl12Lkpro3kkBok0VDgBmuBmwJ+SoDN+gYWJa7M0A uVcPlHU+UV+gIgfogtetbg3lkSq/ofRUDqStGDrY0DdoofC8kNJnIadtYyKwS69ZjUqK 2mD1PB4dTvzGAmMGeFEPpl6whFUxH0HPFkUCybkz5iwavTvQsaFEy1KrIJpQL0GEw3aQ 2Ap702XKlfYd/1doS5TVcFeThrmVkEBBE76XD3Yj/vd9qRpGnc+nwtBwseH01Qw0bXGJ M5Gn/z6D2kuApcyeM2dwU0JlqceJk5rgSJ0HQGvmXcudZD01g9SnSSJId4jIp0mxwxGi ALmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AkGFo/95YKtbHGeJ5M7ECBHv1mLfkCURPPDIDmYR0qk=; b=Ky9Do/k6gb2Rt7r/oZHnh8g3qTXORPeuPPOaT8vifM0JItaOsaF2t6yF4fvcfMg6yK /jy9ZEcny4OPvPR0qIpfiBX2Fe1WQESkTnw7luIMBDyM0SlACXSYeHyTvK4JOuRh32WV XjH9lmu/sZAk8EfTR5Yk466i01BKhH2ksNymAQHWmBwGUj/7o8CVRTligp0Fmiry6QSr tLuebGoBOYMYVD+HzcV9c1JfBnrN0EKgn05fhf0i4i48TID7Skfw/Llm0UjBAdJpibVb rjNK8jRoAiJnobwSvTawBqjDfUpC4wox8WeZ2l0EnJLZwjSk2qJ6EkUrpnUMIQEcfIlj JqwQ== X-Gm-Message-State: APjAAAXExmcZfcUIfqy0KRaxkR0hgqeDPOtqmN0G3RXbN7MUlbCzrbpI 7xwuhGoI/bUmVrbG+FRwVmU= X-Google-Smtp-Source: APXvYqzI7s68sxeJc+DB/h/Xgg2VDkzQZorBU+b0BNZSgaW6bH5gzCsCqDanH9moIuD8UEvvAu+KYQ== X-Received: by 2002:a2e:9183:: with SMTP id f3mr7207551ljg.64.1580512686902; Fri, 31 Jan 2020 15:18:06 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id r10sm6266902ljk.9.2020.01.31.15.18.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Jan 2020 15:18:05 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> From: Dmitry Gutov Message-ID: Date: Sat, 1 Feb 2020 02:18:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 24.01.2020 17:11, Stefan Monnier wrote: > It's arguably breaking compatibility. But you might be right that maybe > it's a non issue. A quick `grep` shows that outside Emacs itself, at > least Helm [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.195 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.195 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 24.01.2020 17:11, Stefan Monnier wrote: > It's arguably breaking compatibility. But you might be right that maybe > it's a non issue. A quick `grep` shows that outside Emacs itself, at > least Helm might be affected Speaking of Helm, there are only a few matches: https://github.com/emacs-helm/helm/search?q=minibuffer-completion-confirm&unscoped_q=minibuffer-completion-confirm And AFAICT it also binds minibuffer-completion-confirm to either t straight away or to the value of the must-match argument (as opposed to its reverse as we might expect). And here's some documentation of that usage: https://github.com/emacs-helm/helm/blob/75563d35a6ae62c669aba4b7bf02ed23b13f6de4/helm.el#L5617-L5623 Overall, it seems like it uses its variable for its own purpose (later comparing the value to t in a different function, for example), and it could just as well created a global variable solely for use in Helm. So it shouldn't be affected by the proposed changes. With that said, Eli, what do you think about the two patches I've sent to this bug earlier? I'd like them in emacs-27. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Feb 2020 08:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, monnier@iro.umontreal.ca, waah@yellowfrog.io, joaotavora@gmail.com Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158054449218247 (code B ref 38992); Sat, 01 Feb 2020 08:09:02 +0000 Received: (at 38992) by debbugs.gnu.org; 1 Feb 2020 08:08:12 +0000 Received: from localhost ([127.0.0.1]:38320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixnp6-0004kE-1L for submit@debbugs.gnu.org; Sat, 01 Feb 2020 03:08:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixnp4-0004k3-Sr for 38992@debbugs.gnu.org; Sat, 01 Feb 2020 03:08:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixnoy-0005Yi-Lo; Sat, 01 Feb 2020 03:08:04 -0500 Received: from [176.228.60.248] (port=3012 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixnox-0006PX-V5; Sat, 01 Feb 2020 03:08:04 -0500 Date: Sat, 01 Feb 2020 10:07:44 +0200 Message-Id: <83blqik9wv.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Dmitry Gutov on Sat, 1 Feb 2020 02:18:05 +0300) References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Cc: 38992@debbugs.gnu.org, João Távora > , waah@yellowfrog.io, Eli Zaretskii > From: Dmitry Gutov > Date: Sat, 1 Feb 2020 02:18:05 +0300 > > With that said, Eli, what do you think about the two patches I've sent > to this bug earlier? I'd like them in emacs-27. The second one is fine with me, but why do we need the first one? It changes the semantics of a widely used variable. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Feb 2020 23:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, waah@yellowfrog.io, monnier@iro.umontreal.ca Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158086064730889 (code B ref 38992); Tue, 04 Feb 2020 23:58:02 +0000 Received: (at 38992) by debbugs.gnu.org; 4 Feb 2020 23:57:27 +0000 Received: from localhost ([127.0.0.1]:44941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz84N-000828-17 for submit@debbugs.gnu.org; Tue, 04 Feb 2020 18:57:27 -0500 Received: from mail-lj1-f182.google.com ([209.85.208.182]:33637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz84K-00081v-V4 for 38992@debbugs.gnu.org; Tue, 04 Feb 2020 18:57:25 -0500 Received: by mail-lj1-f182.google.com with SMTP id y6so501186lji.0 for <38992@debbugs.gnu.org>; Tue, 04 Feb 2020 15:57:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4lfpNOhlKh0wfPNdqVjPOlSr1rxNLmSg5ixATV+grYU=; b=MndaDX4KQgZ7KFCb8aBJaENGV//xCjBtpeUXaZp78rSh9ZUSTsQ1tAejKTIn33wscL 6oM9VHDDPQbGfNut5J9OUReuOvwgwmEwmwigz9fzIL0cC/okyw/xAQa3NZprVGKFq9lp dH4DbFpAVn/AXB1eXyE1Gj8urzliqMeX7GqGTIxEC9Fgj+TyGnetGxP9rjFxzLeEdnYj fJ/O76Yk+Ed6mkbrAFRdsi7cORlaQKz94VjQ0zXsXwuHdELwqmHGSOO9x3iaVB34rYNn jJdZUvq7W70Dd3Q7WDTS+l9SyTnW0lk9ajF3Gp1q2fNA+swFqToQB+PusevW/HqJ+b0V oSLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4lfpNOhlKh0wfPNdqVjPOlSr1rxNLmSg5ixATV+grYU=; b=ugRk2wlh0Cs9zsXZGyNzFQdnJF8N4RKKmjzQaLLw7eB1YrENPYvC0+2C19BJP8eBg6 4wuZaMH6652YLwaG9uflTo2eV6j3NTuuCgdHhoUK6vFjoMDrNAoGQ7BvEOhFDlHiZEJP otlxSEhnA451ek9lN72AmgmLRP08PR+R7Ahh2KaMWK1/833/ic85U/ytuCS9tbODORRZ 7DDqSFtwOINE2oWSsa3ELe3PYtQ8KUT7awY8PIk1w9UI4F/7k/IxqWIawHpYxZyMdVbZ SXZxWhriGBPZxmLzqOHpLn2DsMKpR+8IB5MuHD0lIBuOUbkcTyMyt4HzXk61HVdvs29E a/ag== X-Gm-Message-State: APjAAAVfOzRmlNv8yx6/uG4lWMEifcJhkAT3VKoZZ8hK/eAqwEXdy/n5 d4uXFfu5tJgGx5oZHjHcoNs= X-Google-Smtp-Source: APXvYqwXTJFUzuguKyqB3/7FP0kkZwAV9FsQ8cR2E2A1R+D/vt+5qjhLoF0ETomi1DSLi8u0WoxgBw== X-Received: by 2002:a2e:3609:: with SMTP id d9mr19089606lja.188.1580860639168; Tue, 04 Feb 2020 15:57:19 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id b13sm11064491lfi.77.2020.02.04.15.57.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Feb 2020 15:57:18 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Wed, 5 Feb 2020 02:57:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <83blqik9wv.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 01.02.2020 11:07, Eli Zaretskii wrote: > The second one is fine with me, but why do we need the first one? It > changes the semantics of a widely used variable. The short of it, the second wouldn't work without the first one. And the first one makes a lot of sense (no need to invent an extra variable if the way to store the necessary info is so obvious). Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.182 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.182 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) On 01.02.2020 11:07, Eli Zaretskii wrote: > The second one is fine with me, but why do we need the first one? It > changes the semantics of a widely used variable. The short of it, the second wouldn't work without the first one. And the first one makes a lot of sense (no need to invent an extra variable if the way to store the necessary info is so obvious). There is some possibility of this causing a regression, but the changes are relatively small. And no third-party code should be affected by this change. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 05 07:03:07 2020 Received: (at control) by debbugs.gnu.org; 5 Feb 2020 12:03:07 +0000 Received: from localhost ([127.0.0.1]:45185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izJOd-0001r2-Ji for submit@debbugs.gnu.org; Wed, 05 Feb 2020 07:03:07 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:42606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izJOc-0001qN-3I; Wed, 05 Feb 2020 07:03:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ior8/p0ruhf3WW6F6XCJmrHxQVYYX/Rq3ZYmVm3OKFQ=; b=SCIAJQn668Xaoa65ER8J4HU/my uPnxZaCsgEWJwe2Goouu9JeKflRbXv+LfnP/ZgMB7VE/D5q7dB8q7+OY93jBHP4nQmzon4ebNSIHb 8EmJk2I/g2L+d592y05PQt0kUdxxgUFW8Nr59lK6if2l2aLFP1/8n8bNlz0dqSYyRBC8qL5FP1Pbp 0T9YP2ab6tROcdr+LnQaEmT1zO9NYS6ED9MMroLfndrdQUU7sl804s9uBCqv95jW15PilHPr1Ks4h OtQaVztaSluWzSmcHCQbiHncI3z30LqekPzl9zmYsATv7oneQCaRPwiMS8QuwQ0BqTdaHUHC60ikn KgrZibWg==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:60514 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1izJOT-001HBH-PS; Wed, 05 Feb 2020 07:02:58 -0500 From: Stefan Kangas To: Dmitry Gutov Subject: Re: bug#39407: 28.0.50; fido-mode vs rgrep: wildcard completion In-Reply-To: (Dmitry Gutov's message of "Wed, 5 Feb 2020 03:01:48 +0300") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Wed, 05 Feb 2020 13:02:55 +0100 Message-ID: <87mu9x6y34.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: forcemerge 38992 39407 thanks Dmitry Gutov writes: > I think this is the same as bug#38992 (and they should be merged, note for our > Debbugs pros here). Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RCVD_IN_RP_RNBL RBL: Relay in RNBL, https://senderscore.org/blacklistlookup/ [67.225.143.91 listed in bl.score.senderscore.com] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: marxist.se] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Debbugs-Envelope-To: control Cc: 39407@debbugs.gnu.org, Raymond X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) forcemerge 38992 39407 thanks Dmitry Gutov writes: > I think this is the same as bug#38992 (and they should be merged, note for our > Debbugs pros here). Merged. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Feb 2020 14:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, waah@yellowfrog.io, monnier@iro.umontreal.ca Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158091247810250 (code B ref 38992); Wed, 05 Feb 2020 14:22:02 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Feb 2020 14:21:18 +0000 Received: from localhost ([127.0.0.1]:45241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izLYL-0002fF-MB for submit@debbugs.gnu.org; Wed, 05 Feb 2020 09:21:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izLYH-0002ey-B4 for 38992@debbugs.gnu.org; Wed, 05 Feb 2020 09:21:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1izLYA-0002B0-S2; Wed, 05 Feb 2020 09:21:06 -0500 Received: from [176.228.60.248] (port=4387 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1izLY1-000471-A1; Wed, 05 Feb 2020 09:21:06 -0500 Date: Wed, 05 Feb 2020 16:20:47 +0200 Message-Id: <838slhglog.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Dmitry Gutov on Wed, 5 Feb 2020 02:57:18 +0300) References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, monnier@iro.umontreal.ca, > waah@yellowfrog.io > From: Dmitry Gutov > Date: Wed, 5 Feb 2020 02:57:18 +0300 > > On 01.02.2020 11:07, Eli Zaretskii wrote: > > The second one is fine with me, but why do we need the first one? It > > changes the semantics of a widely used variable. > > The short of it, the second wouldn't work without the first one. Pity. > And the first one makes a lot of sense (no need to invent an extra > variable if the way to store the necessary info is so obvious). I didn't say it didn't make sense. The only issue that worries me is how safe it is for the release branch. I have no issues whatsoever with making these changes on master. > There is some possibility of this causing a regression, but the changes > are relatively small. And no third-party code should be affected by this > change. Are you sure about third-party code? I'm worried by exactly the same assumptions as those which required you to do, e.g., the likes of this: diff --git a/lisp/icomplete.el b/lisp/icomplete.el index a1a67e2330..52429fdf37 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -541,7 +541,7 @@ icomplete-exhibit (icomplete--completion-table) (icomplete--completion-predicate) (if (window-minibuffer-p) - (not minibuffer-completion-confirm))))) + (eq minibuffer-completion-confirm t))))) (buffer-undo-list t) deactivate-mark) ;; Do nothing if while-no-input was aborted. IOW, some code which just assumes that anything non-nil and non-confirm must be confirm-after-completion, or the other way around. It's an incompatible change. Is the problem this attempts to fix really serious? Or is it just a minor inconvenience? It isn't the original one that started the bug report, right? From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Feb 2020 14:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io, Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158091288710829 (code B ref 38992); Wed, 05 Feb 2020 14:29:02 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Feb 2020 14:28:07 +0000 Received: from localhost ([127.0.0.1]:45249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izLew-0002ob-Nb for submit@debbugs.gnu.org; Wed, 05 Feb 2020 09:28:07 -0500 Received: from mail-io1-f50.google.com ([209.85.166.50]:39019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izLeu-0002oH-Jl for 38992@debbugs.gnu.org; Wed, 05 Feb 2020 09:28:05 -0500 Received: by mail-io1-f50.google.com with SMTP id c16so2314772ioh.6 for <38992@debbugs.gnu.org>; Wed, 05 Feb 2020 06:28:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XS9M9WxgCsfoU5XV03zjkAoKTbrTOqr4PCoXrc2X/OY=; b=dpFSoORhqevMKFuKI75FOwoC3oAqyVu2bWwA3ZVIeTRJJqyx2oVrt4ri76pRIaBYO/ 12EdBZeH/bHGTkd44hlsntg00iYAgbDKDxrLkUMx4tRPNjmqV78EoHEMNyPjRkxDxnPF ShL1pVcKVF5NBOtRUcCy4XcYD+MgwQTVvMQNYrg+8wpTWsrL1aNvs/Yl5Xj4Rugs0VrZ GcqV1y7FTst+jEyLziky1GcTuFc/6qLY1rSu/aXNgNyOQ4r+YFwUCNztTBhmE5cN9poo l3vMDH0lIo1hw4VcG5tGE16ZbMjfULzpfLTXyWkmAe07CfTZwb+N+s4KzmIKQzZ5PLjU vjFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XS9M9WxgCsfoU5XV03zjkAoKTbrTOqr4PCoXrc2X/OY=; b=iUld8b1cwxNw7hPg9KZi/paUoavRYYtexPp2h8gWgSMA2PBAQKTMIcbFsHOWncrdpw VnWjTizMPDqtQgGDrMlzt5ClCtO40hHpry7ovrN6AdIfmYtfJmQZef1UYyEVF1jpch/O AQvknpoFG/dUmx9KbGnqwGQyfxachulAUvQsaRS45CvRC85UgUW824vW5gdayT9GLnld miEyYaQ5/3RhI9dBw+pG1+PPMU5b1xMvhoxBIs6WgIRDOi9BNsKP9ZHu2F4shEdaBMCc 8OwWCWXtHf7TZZ0Of3p+DbWZms7qSAb6p9f2gMro8kyH3lDH9AYJpO66YSH25NSCVLOc iRbQ== X-Gm-Message-State: APjAAAVIoDFMfnpd9+dZiyh/q+kmhzzzjtwYwQi+P8aTI/Iun6VxC1xl +d/Ms0EhjT5tsIqoLMfmkeSbI9z57BugbEpdAbg= X-Google-Smtp-Source: APXvYqyd1VdguMZD4EXXGgZt+/pHZBgBFJvnwlSNpKVM7duo+X9ebBMYo8xk+zKl7cHaDsFMn/ppujaSFj7xzYJTUHg= X-Received: by 2002:a05:6638:72c:: with SMTP id j12mr29768321jad.136.1580912878801; Wed, 05 Feb 2020 06:27:58 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> In-Reply-To: <838slhglog.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Wed, 5 Feb 2020 14:27:47 +0000 Message-ID: Content-Type: multipart/alternative; boundary="0000000000008fdafb059dd4f624" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000008fdafb059dd4f624 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 5, 2020 at 2:21 PM Eli Zaretskii wrote: > Is the problem this attempts to fix really serious? Or is it just a > minor inconvenience? It isn't the original one that started the bug > report, right? > If I can shed some light on this: you're right, it's not. With the original problem fixed, Dmitry came to what can be seen as a UI deficiency in fido-mode. After analysing this with Stefan, we arrived at the conclusion that it was actually a problem in some longstanding minibuffer.el workings. At some point, a new variable was proposed, but I think Dmitry and Stefan then agreed that co-opting an existing variable wouldn't have a great impact. Maybe, Dmitry, we could revert to the earlier proposal with the new variable and somehow deprecate/discourage use of the one you're trying to change? That should be safe and bring all the benefits of your change, right? Jo=C3=A3o --=20 Jo=C3=A3o T=C3=A1vora --0000000000008fdafb059dd4f624 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Feb 5, 2020 at 2:21 PM Eli Zaretskii <eliz@gnu.org> wrote:
Is the problem this attempts to fix really serious?=C2=A0 Or is it just a minor inconvenience?=C2=A0 It isn't the original one that started the b= ug
report, right?

If I can shed some light= on this: you're right, it's not.

With the= original problem fixed, Dmitry came to what can be seen as a
UI deficiency in fido-mode.=C2=A0 After analysing this with Stefan, we ar= rived
at the conclusion that it was actually a problem in some lo= ngstanding
minibuffer.el workings.=C2=A0 At some point, a new= variable was proposed,
but I think Dmitry and Stefan then agreed= that co-opting an existing
variable wouldn't have a gre= at impact.

Maybe, Dmitry, we could revert to the e= arlier proposal with the new
variable and somehow deprecate/disco= urage use of the one you're
trying to change?=C2=A0 That= should be safe and bring all the benefits of
your change, right?=

Jo=C3=A3o


=


--
Jo=C3=A3o T=C3=A1vora
--0000000000008fdafb059dd4f624-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Feb 2020 14:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, waah@yellowfrog.io, Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158091399317094 (code B ref 38992); Wed, 05 Feb 2020 14:47:02 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Feb 2020 14:46:33 +0000 Received: from localhost ([127.0.0.1]:45293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izLwm-0004RO-QK for submit@debbugs.gnu.org; Wed, 05 Feb 2020 09:46:33 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izLwl-0004MV-LA for 38992@debbugs.gnu.org; Wed, 05 Feb 2020 09:46:32 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2D01044B021; Wed, 5 Feb 2020 09:46:26 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9E22244B01D; Wed, 5 Feb 2020 09:46:24 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1580913984; bh=40BAzjoWVou+cyoCW9hobgTx3jU0ZYBQA9jkOe0/N98=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mKsT9oYYS2hoaMb82CPOQEOBwqUZkfutZXd3aKhXgE7OdLFmaADeKr4CKaJBw9yPZ DAMNwQN7Zlj8KmW55KC/j8lbK5lnOAdAQu/uuPQYeVq+iwvEMuwN2LPHTCfqW+Vebk pa2HRWmcU/WcExFDs6co7WBIFc9MDcl5Tih9IfHqNgEggGP9C/kHcoGt/stHaCAtdZ mXpropH4H2yjwEn93Wo4aF/HyYJ/75fyo7FT3jGiQKdJ143R7AVENJkuvdNXp+Rn0i +wi9WerzajNs9I8jAZjTQUrQXd7hLS/eXtGmZHjQX8ju7I6pEuKTKmTdk5jImCTT6Z ggaIix2OezxQg== Received: from pastel (unknown [216.154.34.88]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3163612037A; Wed, 5 Feb 2020 09:46:24 -0500 (EST) From: Stefan Monnier Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> Date: Wed, 05 Feb 2020 09:46:23 -0500 In-Reply-To: <838slhglog.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Feb 2020 16:20:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> And the first one makes a lot of sense (no need to invent an extra >> variable if the way to store the necessary info is so obvious). > I didn't say it didn't make sense. The only issue that worries me is > how safe it is for the release branch. Agreed. > I have no issues whatsoever with making these changes on master. Right: the change to `minibuffer-completion-confirm` is for `master`. For the release branch we should either find some workaround or just leave things as they are. Stefan From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Feb 2020 17:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Eli Zaretskii Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15809253496715 (code B ref 38992); Wed, 05 Feb 2020 17:56:02 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Feb 2020 17:55:49 +0000 Received: from localhost ([127.0.0.1]:46672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izOtx-0001kF-Hk for submit@debbugs.gnu.org; Wed, 05 Feb 2020 12:55:49 -0500 Received: from mail-lf1-f43.google.com ([209.85.167.43]:37946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izOtv-0001k3-Sg for 38992@debbugs.gnu.org; Wed, 05 Feb 2020 12:55:48 -0500 Received: by mail-lf1-f43.google.com with SMTP id r14so2135148lfm.5 for <38992@debbugs.gnu.org>; Wed, 05 Feb 2020 09:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=imQlq5EI/wMXWaPGfEo1fsqpL5E9HgEb4cEDtjX1GwQ=; b=kR5AlzvEI0LLjgPeu8iGBgALFXa5JFe7IXFuyVBArAJw5DhHNnwNFSy6G+6QAsyc+/ g488IlNCwJ905d8Q+pjJ03zOXL6h3wAIC+p9r3cpBg4t15b4TiBJqntrmNXaD/7zUCsB lKPyDnXDNAOjk+R164eexzWy+1hT1rYR86hlx0e6Tpo+Op/5yDovnndvYPuKE+dvqVJ+ Jtx2epBbwj7dCi5Bo82xpHjA5XlgAxtEKQtDW7dQTdHTag6CEEdWD7GAFEE9t9JJ2sxi L4lcn2IOzRRc3442fjH/0ygnSVgJp5RYmdfHvVtznh9sTFFV4BcJcbTnUv82OQKYWxfd CGtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=imQlq5EI/wMXWaPGfEo1fsqpL5E9HgEb4cEDtjX1GwQ=; b=cIgEvCf92hlTf2/hGeRFa1Xm/WqWwgIZpnm2lmVNjFBwnte9x0EIAnOvi+Y0YfeXLY SwXEwjAkYxzMEM3vs7yh21+wt4jqautJtmc3EihEaxGyvn8IDoabiVPuzAhxVNUFgAT1 Gv0q87Miqwx7tsWJwIUKvW7LVLbwuMQPZo/AYNROklYzqXROJGwgWtmBWBEdgrt1RNrT XHZCb3fjZNgOoPldcXmcN4+wQRkYpxKbcmvVBp/aOOTpVtPajbw9+4TEhleR28Z/heJD 4KI80MLvXj6cjFF6Q/3JETDe+iy3GzVHxNtY88qZpO8ZX7DMn2RcxplMfm0OCv7wJ9cY 0X2w== X-Gm-Message-State: APjAAAUqykzvGqLDmBML6YxsJxv1PuGeySfayBNlgxfR3+LClWBiBx92 r0XGYlpUnrWKNytkeVRSWnY= X-Google-Smtp-Source: APXvYqxK8m9zpTkjMC0yJprBkuqFUSKcCBxyhpWo6AAyaVzG1I0j6Mu4MmuoM0e/J/ifUad0c0UAjw== X-Received: by 2002:ac2:4c2b:: with SMTP id u11mr18516706lfq.46.1580925341769; Wed, 05 Feb 2020 09:55:41 -0800 (PST) Received: from [192.168.0.103] ([94.229.108.16]) by smtp.googlemail.com with ESMTPSA id t9sm93604lfl.51.2020.02.05.09.55.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Feb 2020 09:55:40 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> From: Dmitry Gutov Message-ID: <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> Date: Wed, 5 Feb 2020 20:55:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 05.02.2020 17:27, João Távora wrote: > With the original problem fixed, Dmitry came to what can be seen as a > UI deficiency in fido-mode. Not exactly. There have been several issues discussed in this report, and it's really a problem that the user can't easily input something that completing-read would allow. A new bug report has arrived since: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=39407 It is now erroneously marked as fixed because it has been merged with this one. We should undo that. The proposed workaround (using M-j) is itself problematic since it allows you to input whatever even when a match is required. So there are bug here. > After analysing this with Stefan, we arrived > at the conclusion that it was actually a problem in some longstanding > minibuffer.el workings. Not exactly. At least, icomplete-mode seems to work okay in both of these respects (please correct me if I'm wrong). > Maybe, Dmitry, we could revert to the earlier proposal with the new > variable and somehow deprecate/discourage use of the one you're > trying to change?  That should be safe and bring all the benefits of > your change, right? Yes, we can do that. I'll make the new variable private, so we can rid of it quickly on master. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Feb 2020 18:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15809263798385 (code B ref 38992); Wed, 05 Feb 2020 18:13:01 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Feb 2020 18:12:59 +0000 Received: from localhost ([127.0.0.1]:46696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izPAY-0002BB-Sr for submit@debbugs.gnu.org; Wed, 05 Feb 2020 13:12:59 -0500 Received: from mail-io1-f51.google.com ([209.85.166.51]:39057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izPAX-0002Ay-Qd for 38992@debbugs.gnu.org; Wed, 05 Feb 2020 13:12:58 -0500 Received: by mail-io1-f51.google.com with SMTP id c16so3187384ioh.6 for <38992@debbugs.gnu.org>; Wed, 05 Feb 2020 10:12:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yD1hli2PptLKjYqYmFrQCMMi6JlAPxVSyh9+QPvQpZA=; b=QICMlPotbfVX7x45bnLiQwXsBs2hLxPWBKaEXOcm73NYFg2CxtRiNHvCukyfL/ILjt uaLw93tBLle2nG2HAZDEObTYaACo5TqIvbS2emHNCCX+yHCyZ9dGAPthfD/io45WbMIu kI13Toig+6F24f7Sgb0knMoau06pxRNKHTcAmNrpbsRL9YNEPdvM9pvCHWwtyv8uFAVL QK4njm/4kaFnyywxcSvmX3dW4EPMff2WnB4icEn+vhrJLzCy0ZEhAdjsu6BKRvWJ3D6m UqEvAcSSkv+m7drnD6tRoLivuUpWkEfnIhdNa2GXstrkqd0/jVkP6DxIxijmKG1jmd/J 8eNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yD1hli2PptLKjYqYmFrQCMMi6JlAPxVSyh9+QPvQpZA=; b=ingpJNzXfZxigz+KVCe90LXUfkiYJSno+4Sk8owzf/2VLJ1AQ02lqyrqBn2fXS7d8J rMdGsfMfbnvDRx856Bv+Eze70jInjvSVbuQvp/8g/wwTBGHKOI1xod3QQfHsotYg7Mid FwZl+uPHkSbhHmxgTcxOw4hkEo56CwUhmF3f8joObE/MlhHfL8fHauOtrASaOhpRz3oQ wK9UZjP77dT2nL0mFSG3lDFmxTKwQwQV82GSThhwx4KcrX4/jVgHUNrUc0hEGz1DLprT /TbliYU9Ru7kvYs6pHYkH3eaZLdpX1pzE+07rGDt8cqIcoz7Hlaq1pMrShlAhgVvP1P1 8DUQ== X-Gm-Message-State: APjAAAW4rP0YebrFzKazReul07fgWWiG2rqOF2bkUXeffJ2ZShcEns/v MH3N7ZbwYYdQnJmqPWxXaChmor/Bl5RxCr0zgG0= X-Google-Smtp-Source: APXvYqxmnvXZsoFQKn9IrvgROAXr88tEOB7JWmmap+n7mKAm3i9vvaEETduP5NcG+I0DgsY5raH1ys4WoitdDEcNio0= X-Received: by 2002:a6b:f214:: with SMTP id q20mr30573139ioh.137.1580926372287; Wed, 05 Feb 2020 10:12:52 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> In-Reply-To: <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Wed, 5 Feb 2020 18:12:40 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000d619c2059dd81a8c" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000d619c2059dd81a8c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 5, 2020 at 5:55 PM Dmitry Gutov wrote: > On 05.02.2020 17:27, Jo=C3=A3o T=C3=A1vora wrote: > > With the original problem fixed, Dmitry came to what can be seen as a > > UI deficiency in fido-mode. > > Not exactly. There have been several issues discussed in this report, > and it's really a problem that the user can't easily input something > that completing-read would allow. > So isn't that a UI deficiency in fido-mode? Mind you I'm calling it a deficiency because it can't by definition be a bug. fido-mode is a new thing and I _made_ the spec for it. Of course, I like your suggestions for improvement (as I have showed here). > A new bug report has arrived since: > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39407 It is now > erroneously marked as fixed because it has been merged with this one. We > should undo that. > > The proposed workaround (using M-j) is itself problematic since it > allows you to input whatever even when a match is required. So there are > bug here. > Not sure that is a problem with fido-mode. I think it's reasonable for a completer to bind exit-minibuffer, or to have something that allows it to exit with whatever. exit-minibuffer doesn't honour require-match (maybe it shouldn't) but it is the only such thing that allows any kind of workaround, as far as I am aware. So this isn't a problem with fido-mode. When there is something else to fill this gap -- respect require-match and still allow to exit easily with arbitrary input when that is nil -- then fido-mode will use it. > > After analysing this with Stefan, we arrived > > at the conclusion that it was actually a problem in some longstanding > > minibuffer.el workings. > > Not exactly. At least, icomplete-mode seems to work okay in both of > these respects (please correct me if I'm wrong). > Doesn't icomplete-force-complete-and-exit have a problem, too? I was under the impression that it did, from reading the above thread. > > Maybe, Dmitry, we could revert to the earlier proposal with the new > > variable and somehow deprecate/discourage use of the one you're > > trying to change? That should be safe and bring all the benefits of > > your change, right? > > Yes, we can do that. I'll make the new variable private, so we can rid > of it quickly on master. > Great! Disregard the previous discussion if you want, just do this, and move on. Jo=C3=A3o --000000000000d619c2059dd81a8c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Feb 5, 2020 at 5:55 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
On 05.02.202= 0 17:27, Jo=C3=A3o T=C3=A1vora wrote:
> With the original problem fixed, Dmitry came to what can be seen as a<= br> > UI deficiency in fido-mode.

Not exactly. There have been several issues discussed in this report,
and it's really a problem that the user can't easily input somethin= g
that completing-read would allow.

So is= n't that a UI deficiency in fido-mode?=C2=A0 Mind you I'm calling i= t
a deficiency because it can't by definition be a bug.= =C2=A0 fido-mode is a new
thing and I _made_ the spec for it.=C2= =A0 Of course, I like your suggestions
for improvement (as I have= showed here).
=C2=A0
A new bug report has arrived since:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug= =3D39407 It is now
erroneously marked as fixed because it has been merged with this one. We should undo that.

The proposed workaround (using M-j) is itself problematic since it
allows you to input whatever even when a match is required. So there are bug here.

Not sure that is a problem wi= th fido-mode.=C2=A0 I think it's reasonable
for a comple= ter to bind exit-minibuffer, or to have something that
allow= s it to exit with whatever.=C2=A0 exit-minibuffer doesn't honour
require-match (maybe it shouldn't) but it is the only such thi= ng
that allows any kind of workaround, as far as I am aware.=
So this isn't a problem with fido-mode. When there is someth= ing
else to fill this gap -- respect require-match and still allo= w to exit
easily with arbitrary input when that is nil -- th= en fido-mode will use
it.
=C2=A0
> After analysing this with Stefan, we arrived
> at the conclusion that it was actually a problem in some longstanding<= br> > minibuffer.el workings.

Not exactly. At least, icomplete-mode seems to work okay in both of
these respects (please correct me if I'm wrong).
=

Doesn't= icomplete-force-complete-and-exit have a problem, too?=C2=A0 I
<= div class=3D"gmail_quote">was under the impression that it did, from readin= g the above thread.
=C2=A0
> Maybe, Dmitry, we coul= d revert to the earlier proposal with the new
> variable and somehow deprecate/discourage use of the one you're > trying to change?=C2=A0 That should be safe and bring all the benefits= of
> your change, right?

Yes, we can do that. I'll make the new variable private, so we can rid =
of it quickly on master.

Great!=C2=A0= =C2=A0 Disregard the previous discussion if you want, just do this,
and move on.

Jo=C3=A3o

=
--000000000000d619c2059dd81a8c-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Mar 2020 22:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15833596755060 (code B ref 38992); Wed, 04 Mar 2020 22:08:02 +0000 Received: (at 38992) by debbugs.gnu.org; 4 Mar 2020 22:07:55 +0000 Received: from localhost ([127.0.0.1]:41933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9cBH-0001JV-9v for submit@debbugs.gnu.org; Wed, 04 Mar 2020 17:07:55 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:55973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9cBF-0001I0-Bm for 38992@debbugs.gnu.org; Wed, 04 Mar 2020 17:07:54 -0500 Received: by mail-wm1-f44.google.com with SMTP id 6so3996325wmi.5 for <38992@debbugs.gnu.org>; Wed, 04 Mar 2020 14:07:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7C1oHNtoReIl2FfiP2lF/4KZzxQeh769wV7B+e5nmNs=; b=K6mPfGKq16AbNwqu/XqGdGk7mhO/jHFy4iRFn4IGR/UczbezcUfqPldXi57xgQpPNh snIWtr+v6293fPNT5fzgNkIgRuErvmJy/y1zyFKyKTR56y0GaYuJACgacULJtzMoqR3h SNHvC/Ddb1EBfb6AzunQ2UijWCo9z4o6FYveODlhb/63GIAcXbfKm9KT9gnBERNCSrBF l+od5xKcp3EgrgjnyZwsWUaynplmY4YPAWNxkD2TfAGTkY5efOZuO2C43HTUx7C6nOFv YjmTJPSIPMtRPun1JqSH1+99t8dvsFRPl9pEMdcNnLnbNGIp7zhk3R2QuFxgUmNUoapg qU8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7C1oHNtoReIl2FfiP2lF/4KZzxQeh769wV7B+e5nmNs=; b=GNkQZ7zWDzNDbBLx6XamVZRwWoJ9sBFMi0HEkoHtQ5eYghzZ3sNw2+/XccC0EzzN+Z wy4MMHx3tRJaubHLMMuRhx9miIr4Dpw4/iGwdsDGOU5fAm+kXMUPkgJHmcvqvdo9pCcn 0yuCh/JJobUOuF+TxZR/6ObnsyIROF0BtqM3y93/1ET64odhrZD2F0hOHmy6D7rQB1y/ gK94wzqYxHTZPv9ZUbypAm3xnLJ50wTzJoedE8ysK1t4vSqWLy/T3O4VTlZNqnWYAHTv CVO5hX8kU+6xAcKCNBEq3i0e68Yr5hwhqZKEFn0nqvT9iHoIUYpt1OYcHep/hky+6JJc wfFA== X-Gm-Message-State: ANhLgQ0+ekXBlo+OScMyYFm8LU+7NVinMTzifrTCYsV39prhXfIWSWtq Wh9lqWr8AJbp4eRaPbazThc= X-Google-Smtp-Source: ADFU+vsqv5gNnX7oe38iHi+xqCbEW7Kky+p+yqK2YlVk0tsWioDLdvK+vylBSBtHfVsUw8gozxCKjQ== X-Received: by 2002:a1c:4681:: with SMTP id t123mr5655001wma.86.1583359667560; Wed, 04 Mar 2020 14:07:47 -0800 (PST) Received: from [192.168.0.2] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id t187sm6517902wmt.25.2020.03.04.14.07.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2020 14:07:46 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> From: Dmitry Gutov Message-ID: Date: Thu, 5 Mar 2020 00:07:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) On 05.02.2020 20:12, João Távora wrote: > Not exactly. There have been several issues discussed in this report, > and it's really a problem that the user can't easily input something > that completing-read would allow. > > > So isn't that a UI deficiency in fido-mode?  Mind you I'm calling it > a deficiency because it can't by definition be a bug.  fido-mode is a new > thing and I _made_ the spec for it.  Of course, I like your suggestions > for improvement (as I have showed here). It's a bug because it changes icomplete-mode in a way that makes completing-read fail its contract (which is to demand matching input when require-match is non-nil) in certain situations. That, in turn, will create problems in code that calls completing-read and relies on it fulfilling its contract. > > Maybe, Dmitry, we could revert to the earlier proposal with the new > > variable and somehow deprecate/discourage use of the one you're > > trying to change?  That should be safe and bring all the benefits of > > your change, right? > > Yes, we can do that. I'll make the new variable private, so we can rid > of it quickly on master. > > > Great!   Disregard the previous discussion if you want, just do this, > and move on. Yup. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Mar 2020 22:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158336186812181 (code B ref 38992); Wed, 04 Mar 2020 22:45:02 +0000 Received: (at 38992) by debbugs.gnu.org; 4 Mar 2020 22:44:28 +0000 Received: from localhost ([127.0.0.1]:41939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9cke-0003AP-7a for submit@debbugs.gnu.org; Wed, 04 Mar 2020 17:44:28 -0500 Received: from mail-io1-f54.google.com ([209.85.166.54]:38254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9ckb-0003AB-Ny for 38992@debbugs.gnu.org; Wed, 04 Mar 2020 17:44:26 -0500 Received: by mail-io1-f54.google.com with SMTP id s24so4289568iog.5 for <38992@debbugs.gnu.org>; Wed, 04 Mar 2020 14:44:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R3DfrIJSOfDUSjbFBxlkgeOM+Lo7/EFG5oYJqY/+Y+M=; b=pspXLXhYJd/DxF54B5nr/PVpMA5naA5tASec29A1PmySci2BecCbQV/GqtnOjV05Hq uuyGZLIL1QOAEuYyixld3A7Gg3Lu+U1q6sBqn7+HQG9bKtNl7FS/RLREbtGHDySZJ/Yi 9gxpmzZGXllcGamV945MaREeEqVzu9kjAjdyOzE5w8GrNpQksHIIOioUfrQKLzOarET2 4s6tIG8ONSZDhIyb0LhJsGSrw6tJlf0wamhsisz9vvACbeQPD7gfJlquIbdhmFL2CroO YipHGkQeF6y566IuUjD2ElU1f3+w7FMc3YF3j69xWd6r5avO5zpRUxJ0TTygaWba7jJF H+BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R3DfrIJSOfDUSjbFBxlkgeOM+Lo7/EFG5oYJqY/+Y+M=; b=X+JraHqVIx9RIMNqTd5RF8ayneYlNKywwsXreMdTlaY9u7HAssvj0OmVhi3FcGJkgz NWAMpCfiYqgErNXXfEp2a5mdnQSjvrv6yPnd5pMufXBjyagJD+QEhhcodPkRtAgIBGay I9nIUpp277BPhj27NLg8/F5+4/jB9L0Ca7g1ZRixHKKh3Ds1/aYw1tXB6VP/3jSfl/ch Q6qvxkKnlzKKFGocEizxN+wqSh9Wa7F2rugrSFTGAVJjiyKqbH8+cypr14W6gnjSpHsn YhvjwmGvwUI1N0FycwQAOFFEW6+8n7hrRCCwvh4QTbmHlAoHnafdNL2uOJ1eydT5Ynwv nqBA== X-Gm-Message-State: ANhLgQ06iikTbnZdhLyJvcu841EWeDSVc9IIL/MTTYmHjVknpVjXNhMV hI9r3vROgRVy/JSrKK5em0eD58rjkNQoTex7PW4= X-Google-Smtp-Source: ADFU+vs60iZ+SzMV2vHbryf3W0h/r/2eyMzBndjOll2pXmLcwCvjuLoKF8B9tF5gYpduQm7CfcReMJPKt3EQFdU/FTk= X-Received: by 2002:a02:70cc:: with SMTP id f195mr1549528jac.78.1583361860069; Wed, 04 Mar 2020 14:44:20 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Wed, 4 Mar 2020 22:44:08 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000386da905a00f2991" X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) --000000000000386da905a00f2991 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 4, 2020 at 10:07 PM Dmitry Gutov wrote: > It's a bug because it changes icomplete-mode in a way that makes > completing-read fail its contract (which is to demand matching input > when require-match is non-nil) in certain situations. fido-mode doesn't change icomplete-mode. It shouldn't, at least. It just uses it as a library. And surely if it's a bug in fido-mode, surely it needs fixing _there_ and not elsewhere. But it seems not be the case (at least with your latest proposal), so you have me confused. > > Great! Disregard the previous discussion if you want, just do this, > > and move on. > > Yup. So much time has passed that I don't remember what the fix was anymore. Have you pushed it? I don't see it in emacs-27 Jo=C3=A3o --000000000000386da905a00f2991 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Mar 4, 2020 at 10:07 PM Dmitry Gutov <dgutov@yandex.ru> wro= te:
> It's a bug because it changes icomplete-mode in a way that = makes
> completing-read fail its contract (which is to demand matchin= g input
> when require-match is non-nil) in certain situations.<= /div>

fido-mode doesn't change icomplete-mode. It sh= ouldn't, at least.
It just uses it as a library.=C2=A0 And su= rely if it's a bug in fido-mode,
surely it needs fixing = _there_=C2=A0 and not elsewhere.=C2=A0 But it seems
not be t= he case (at least with your latest proposal), so you have
me= confused.

> > Great! =C2=A0 Disregard the previo= us discussion if you want, just do this,
> > and move on.
><= br>> Yup.

So much time has passed that I don'= t remember what the fix was anymore.
Have you pushed it?=C2=A0 I = don't see it in emacs-27

Jo=C3=A3o
--000000000000386da905a00f2991-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 00:02:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158336650019200 (code B ref 38992); Thu, 05 Mar 2020 00:02:03 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 00:01:40 +0000 Received: from localhost ([127.0.0.1]:41984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9dxM-0004zc-5J for submit@debbugs.gnu.org; Wed, 04 Mar 2020 19:01:40 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:36596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9dxK-0004zH-As for 38992@debbugs.gnu.org; Wed, 04 Mar 2020 19:01:38 -0500 Received: by mail-wr1-f48.google.com with SMTP id j16so4828687wrt.3 for <38992@debbugs.gnu.org>; Wed, 04 Mar 2020 16:01:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/JzFmAhaeEj7ig36m02YEjt82f+rJIjAXE6b8ylpt5Y=; b=WcdH4pvSwvQkCXYL2id8nZRKdWNIJzU/7NmPRZw6U8J4w4hbDwrHJErLryOGkd9Q3y +XwHF9ftaNvKHHInDR9a0Mn0H2BfyqxjoNRBgnuF1rujTJmicAi+Onq2Q1o+fRs7m/0O EjtyfDgwqUmU0gsPr6VPHXIy46M8yKoYE8OFZaM8uWV2DDHnPTlDPk1L6mDLmeK/oeq6 3EXA95YrJjC5+P+uS16Mnb1Zz6TwkvU+S7yPohcE1aEBNTq2Ik/cRewn2PrEqkEUaD/s 2Dxx/iM9Dit0Owa0avZBLYbykT7pBWANpcEPv3pS7cQbBlG1pLKINU/nP7Inw3NrSNsk blXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/JzFmAhaeEj7ig36m02YEjt82f+rJIjAXE6b8ylpt5Y=; b=rqYnW4tckEe/rzoZd4+pEPIP6JUZ+JoZewAZaj43jn7BQd3akGQ7c2BjT5hnFDyM3M Q43341ujjX8QSB1gHRrLpycxwOQ9VbkQNdQyT54QZpj/kUUdYUqvNFFJMCvDv9M79OME 84uoSydoDzNJWVCLl8cj2kgmbIzFRZODf/yScRgd3UJBGiWCIayp0ahQvU8IuxWgqbUe przDgX8jHWaFz1k1KTUhV//Aj0rFTiQ//XjUSMW8v/V+/Jxzdh51TE4Czak24Xwmit8d ECBYd317Q8KoJazxQ2Pc5RHCNJ/NvRaQxU792RbyfNKMNrg9aPQG1Sw1VnmfBTpu2uPR VvcA== X-Gm-Message-State: ANhLgQ2+tzZwosOt7uOmkmpjsP9Gohy4lqpDjO+NXhrRiWWMDr6gVU1O YRb+/aW29vSTenTCbLFuWfw= X-Google-Smtp-Source: ADFU+vuVCUcElE4mkqn1yk0YU9tn4oVEv+T0B1RlWqKLN/oDMmR6QhqtaT0qXoTB9qCqZM1LfiHY2A== X-Received: by 2002:a5d:698f:: with SMTP id g15mr6335817wru.3.1583366492355; Wed, 04 Mar 2020 16:01:32 -0800 (PST) Received: from [192.168.0.2] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id 25sm6595812wmg.30.2020.03.04.16.01.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2020 16:01:31 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> From: Dmitry Gutov Message-ID: Date: Thu, 5 Mar 2020 02:01:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) On 05.03.2020 0:44, João Távora wrote: > fido-mode doesn't change icomplete-mode. It shouldn't, at least. > It just uses it as a library.  And surely if it's a bug in fido-mode, > surely it needs fixing _there_  and not elsewhere.  But it seems > not be the case (at least with your latest proposal), so you have > me confused. Since the problem isn't triggered by icomplete-mode, but is triggered by fido-mode, it seems the latter binds some commands that are not a great fit for it. Hence the second patch which added a new command specifically for fido-mode. The first one changes icomplete-force-complete-and-exit to honor require-match=nil, failure to do which wasn't a problem for icomplete-mode because one uses C-j in incomplete-mode only to pick among one of the suggested matches. ido-mode users, however, like to use RET for arbitrary inputs as well. If I were to classify, the first one fixes a "UI deficiency", but the second one fixes a bug. > So much time has passed that I don't remember what the fix was anymore. The previous patches are attached to the older message. Not too hard to find on the debbugs bug page. > Have you pushed it?  I don't see it in emacs-27 Just got back to this discussion. I've pushed the updated (more limited) patches to the 'fido-mode-fix' branch. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 00:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, waah@yellowfrog.io, monnier@iro.umontreal.ca Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158336733120439 (code B ref 38992); Thu, 05 Mar 2020 00:16:01 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 00:15:31 +0000 Received: from localhost ([127.0.0.1]:41992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9eAl-0005Jb-EK for submit@debbugs.gnu.org; Wed, 04 Mar 2020 19:15:31 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:50260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9eAk-0005JO-2o for 38992@debbugs.gnu.org; Wed, 04 Mar 2020 19:15:30 -0500 Received: by mail-wm1-f49.google.com with SMTP id a5so4304448wmb.0 for <38992@debbugs.gnu.org>; Wed, 04 Mar 2020 16:15:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Pw6LSjZwzxWvKOKYeXOJ4AfwXUV92ZwCA465AzI56UM=; b=aqdvXeKFrFR5K18bAFgkWH6TOVtvgNI3CX+oJYWtB0VsGQuXDLTM5dJ1l0HyLzzxOx EFRIPsRlXScb1LWVctR23hBN2dAlTwnXnjFEFtOq4Oj5Ogz81EFdFzyVBRP7Ef7hjDX+ ngvb1+78x3zQUTKCKeM8en/wwnzg3SaZ8OPT7nV0XKOWuvCwfIyMpr4QdO1bRuSAAGVo TjIst1o4FQYPTenxgKgP5TfNhicobcAn3CJKq2AXe2DRekSbyxcQ+4VZmuqZYSvqZ34d EZhgCsZk8Hs/ocw3KQg4FKTxhv2siKxhCfS5zWc4SivO2+z6LQGlNvm4eFyS5bvqwGCn GK4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Pw6LSjZwzxWvKOKYeXOJ4AfwXUV92ZwCA465AzI56UM=; b=BMOsvKmobO0+hY1UonmV1BKk7E55cgwdj4ai97rNx8OUuiabcwgRsKrShBlml9tO/H MCpC6DAc56D1KqcVsbm2HOJC4s01+UYQglCfhMG3hANUmGgmphTzl1hVxUgzF0Ubcs80 dTBREIDd6UPWzdJ3Q1eC91QEZnVLECJ9quAQ2LhksvSuG3bhmp4KiwCrtrfUWJBq9/8g /11NVr+oEXhujgiIxTH2wL2HBLA1kNUGo4jJIJX6yHIOrsHCLoOok0QtU2TDaevyamtv +hTMU+5/dL6EewaQWs+/fG9XN258DUUaoa3/+LH4YMHDks0d4X9f0R9WSciH1fOYM9Un c6SA== X-Gm-Message-State: ANhLgQ3Bj6NZ/U79suvz+kKY4xVOGjKPRVR+AZaEqpgVoGy7nH+5YqF5 8qJSbI/Pqqjx7UiYwDlUQ/c= X-Google-Smtp-Source: ADFU+vuX3GZSEROks9ZGXPqKJvEEXrrIhgLN89TRBai91Na5XLzI/zJ0n1xcIk76DUZE161wBoRzVw== X-Received: by 2002:a1c:35c6:: with SMTP id c189mr5665074wma.108.1583367324286; Wed, 04 Mar 2020 16:15:24 -0800 (PST) Received: from [192.168.0.2] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id n13sm6646052wmd.21.2020.03.04.16.15.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2020 16:15:23 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Thu, 5 Mar 2020 02:15:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <838slhglog.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) On 05.02.2020 16:20, Eli Zaretskii wrote: >> And the first one makes a lot of sense (no need to invent an extra >> variable if the way to store the necessary info is so obvious). > > I didn't say it didn't make sense. The only issue that worries me is > how safe it is for the release branch. I have no issues whatsoever > with making these changes on master. I wouldn't say it's absolutely safe, but it would make me happier to root out logical problems with the existing variable before the release. >> There is some possibility of this causing a regression, but the changes >> are relatively small. And no third-party code should be affected by this >> change. > > Are you sure about third-party code? I'm worried by exactly the same > assumptions as those which required you to do, e.g., the likes of > this: > > diff --git a/lisp/icomplete.el b/lisp/icomplete.el > index a1a67e2330..52429fdf37 100644 > --- a/lisp/icomplete.el > +++ b/lisp/icomplete.el > @@ -541,7 +541,7 @@ icomplete-exhibit > (icomplete--completion-table) > (icomplete--completion-predicate) > (if (window-minibuffer-p) > - (not minibuffer-completion-confirm))))) > + (eq minibuffer-completion-confirm t))))) > (buffer-undo-list t) > deactivate-mark) > ;; Do nothing if while-no-input was aborted. The above is a simple bugfix of "why the hell not" variety: I don't think that code worked well before that patch, i.e. it treated the values of nil and t of REQUIRE-MATCH the same. Good thing that only affected the choice of parens to print in the minibuffer. > IOW, some code which just assumes that anything non-nil and > non-confirm must be confirm-after-completion, or the other way > around. It's an incompatible change. I'm not arguing that is isn't. But looking at the actual uses out there, the chief popular alternatives to completing-read-default don't seem to be affected. And this variable is bound inside completing-read-default, so only particular kind of code could really use it. Breakage is possible, of course, but I'm fairly sure the affected audience would be minimal. Anyway, see the alternative patches in the branch 'fido-mode-fix' I just pushed. > Is the problem this attempts to fix really serious? Or is it just a > minor inconvenience? It isn't the original one that started the bug > report, right? The patches fix both an inconvenience (one that started this bug report, I'd say it is serious enough to make users stumped) and a bug. See my previous message in this bug report for details. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 06:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov , Stefan Monnier Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158338855128173 (code B ref 38992); Thu, 05 Mar 2020 06:10:01 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 06:09:11 +0000 Received: from localhost ([127.0.0.1]:42106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9jh0-0007KL-Ta for submit@debbugs.gnu.org; Thu, 05 Mar 2020 01:09:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9jgy-0007K7-BM for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 01:09:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j9jgs-0003eh-5G; Thu, 05 Mar 2020 01:09:02 -0500 Received: from [176.228.60.248] (port=2930 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j9jgr-0006eb-DM; Thu, 05 Mar 2020 01:09:01 -0500 Date: Thu, 05 Mar 2020 08:08:42 +0200 Message-Id: <834kv3wcyd.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Dmitry Gutov on Thu, 5 Mar 2020 02:15:21 +0200) References: <288610218.111246.1578330546916@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, monnier@iro.umontreal.ca, > waah@yellowfrog.io > From: Dmitry Gutov > Date: Thu, 5 Mar 2020 02:15:21 +0200 > > > diff --git a/lisp/icomplete.el b/lisp/icomplete.el > > index a1a67e2330..52429fdf37 100644 > > --- a/lisp/icomplete.el > > +++ b/lisp/icomplete.el > > @@ -541,7 +541,7 @@ icomplete-exhibit > > (icomplete--completion-table) > > (icomplete--completion-predicate) > > (if (window-minibuffer-p) > > - (not minibuffer-completion-confirm))))) > > + (eq minibuffer-completion-confirm t))))) > > (buffer-undo-list t) > > deactivate-mark) > > ;; Do nothing if while-no-input was aborted. > > The above is a simple bugfix of "why the hell not" variety: I don't > think that code worked well before that patch, i.e. it treated the > values of nil and t of REQUIRE-MATCH the same. Good thing that only > affected the choice of parens to print in the minibuffer. > > > IOW, some code which just assumes that anything non-nil and > > non-confirm must be confirm-after-completion, or the other way > > around. It's an incompatible change. > > I'm not arguing that is isn't. But looking at the actual uses out there, > the chief popular alternatives to completing-read-default don't seem to > be affected. And this variable is bound inside completing-read-default, > so only particular kind of code could really use it. Breakage is > possible, of course, but I'm fairly sure the affected audience would be > minimal. > > Anyway, see the alternative patches in the branch 'fido-mode-fix' I just > pushed. > > > Is the problem this attempts to fix really serious? Or is it just a > > minor inconvenience? It isn't the original one that started the bug > > report, right? > > The patches fix both an inconvenience (one that started this bug report, > I'd say it is serious enough to make users stumped) and a bug. See my > previous message in this bug report for details. Thanks for the explanations. Stefan, any thoughts on whether this is safe for emacs-27? From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 08:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15833953195882 (code B ref 38992); Thu, 05 Mar 2020 08:02:01 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 08:01:59 +0000 Received: from localhost ([127.0.0.1]:42126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9lSA-0001Wn-GJ for submit@debbugs.gnu.org; Thu, 05 Mar 2020 03:01:58 -0500 Received: from mail-il1-f179.google.com ([209.85.166.179]:33597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9lS9-0001WZ-Er for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 03:01:57 -0500 Received: by mail-il1-f179.google.com with SMTP id r4so4261395iln.0 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 00:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9fgShIBi+Mt+QXYFRQLL+kt+YhcXyhIMkeQL4AYoR8A=; b=dQ9xy8hV5PTtbOMCUs5KH2xEoC9oxUyiQ3yzba6XxYEztVR6xlh81LEVnPAkhd6tj/ XM++rVq75sjnWZLm7p9666/XBeEvwMAKobJHLK7j44cY5ZEuGj2Ab5JBdDsomj238goF Yh5+ZvBItR2psPZhMQeH26kZxhXu1tNCstOfsUpeECT4Kp6wJ1k2prqJElD5brgi37t5 RzTHwsAxRxhiAgCup6YRmi/VG1y7gpsKi6d/iYfNW75XccgWc4hBnWTwB3fIHMU4xQzW GPmV9JRqfIH10jTqleLlYRnlTAsskpOAtKxFjjjBilp5Q0qXWtA3L6wpGJy7tr33+2S5 OyWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9fgShIBi+Mt+QXYFRQLL+kt+YhcXyhIMkeQL4AYoR8A=; b=nv6PX4djJJpJoR7+4YXD20MB0vhEt1QXgeEEcXx7ryA08pCAgVliuLNGW2jNUy8HVs Z6SAs6HtGEJaaDcQj85qf8zj+Y4BosDddoVIYLFb1Zl0ZIf1hzJiqLNWjh8D/lUUtszS YxS3Z74v6DmbBiN5AiISkXg7K/E8encfZqmOJa7gyc1SD05fMGXtLm132OaU0hE0nLCe db1pkxJTDK9LVBP4BLNTEsu16MgvJ6kcITiv0FIEDVGFVcvEQ0zVadjZ8e0HqUkvMz4n T3PbDnWdbgQ9RrqjelTxUURYsv6LIEHaeCENt/ecbP9HQgg31i61Yy7W4kYiGRS6yTUC P8yg== X-Gm-Message-State: ANhLgQ0suIqA2UR/buwwK85r4cMtPYaEsN0xZ5eWiH966WzOTCablIDC e68EMg51oHCDWohTzBTeEl+8IdF6Vor6AvJvG5Y= X-Google-Smtp-Source: ADFU+vuQMB4I1EQbc5w+E+kUR1RcerlJczj7AbH2X5vlwWsFn31BpVve5tUwrRERjhLfYGz5OZxw3ZzAyTr4VtfK8jM= X-Received: by 2002:a92:884e:: with SMTP id h75mr6857829ild.199.1583395311761; Thu, 05 Mar 2020 00:01:51 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 5 Mar 2020 08:01:40 +0000 Message-ID: Content-Type: multipart/alternative; boundary="00000000000018bf1105a016f3d2" X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) --00000000000018bf1105a016f3d2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 5, 2020 at 12:01 AM Dmitry Gutov wrote: > > On 05.03.2020 0:44, Jo=C3=A3o T=C3=A1vora wrote: > > fido-mode doesn't change icomplete-mode. It shouldn't, at least. > > It just uses it as a library. And surely if it's a bug in fido-mode, > > surely it needs fixing _there_ and not elsewhere. But it seems > > not be the case (at least with your latest proposal), so you have > > me confused. > > Since the problem isn't triggered by icomplete-mode, but is triggered by > fido-mode, it seems the latter binds some commands that are not a great > fit for it. Sure fido-mode binds commands that it needs to bind for it to be useful, the choice for M-j was the closest thing available at the time. If you've made a better one since, that's great. > ido-mode users, however, like to use RET for arbitrary inputs as well. Let's first _not_ change the current fido-mode UI ok? At least for now. Later (even before Emacs 27) could be fine. > The previous patches are attached to the older message. Not too hard to > find on the debbugs bug page. I'm just looking for the patch to minibuffer.el that I remember you saying you were preparing. (I'm sorry, but I don't have time right now to find it in this very poor Gmail UI). I've pulled from your branch in Git and yours patches look fine, but really I don't understand the minibuffer one anymore at this kind of distance. But it it's the one we talked about when I did understand it, I'm all for it. > If I were to classify, the first one fixes a "UI deficiency", but the > second one fixes a bug. Don't know which is which, but classifiers will classify :-) > I've pushed the updated (more limited) patches to the 'fido-mode-fix' > branch. Yes, thanks! Jo=C3=A3o --00000000000018bf1105a016f3d2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Mar 5, 2020 at 12:01 AM Dmitry Gutov <dgutov@yandex.ru> wrote:
>
>= ; On 05.03.2020 0:44, Jo=C3=A3o T=C3=A1vora wrote:
> > fido-mode d= oesn't change icomplete-mode. It shouldn't, at least.
> > = It just uses it as a library.=C2=A0 And surely if it's a bug in fido-mo= de,
> > surely it needs fixing _there_ =C2=A0and not elsewhere.=C2= =A0 But it seems
> > not be the case (at least with your latest pr= oposal), so you have
> > me confused.
>
> Since the pr= oblem isn't triggered by icomplete-mode, but is triggered by
> fi= do-mode, it seems the latter binds some commands that are not a great
> fit for it.

Sure fido-mode binds commands that = it needs to bind for it
to be useful, the choice for M-j was = the closest thing available at
the time. If you've made a bet= ter one since, that's great.

>=C2=A0 ido-mod= e users, however, like to use RET for arbitrary inputs as well.

Let's first _not_ change the current fido-mode UI ok? At least<= /div>
for now.=C2=A0 Later (even before Emacs 27) could be fine.
<= div>
> The previous patches are attached to the older mess= age. Not too hard to
> find on the debbugs bug page.

I'm just looking for the patch to minibuffer.el that I remembe= r you
saying you were preparing. (I'm sorry, but I don't= have time right now to
find it in this very poor Gmail UI).=C2= =A0 I've pulled from your branch in Git
and yours patches loo= k fine, but really I don't understand the minibuffer
one anym= ore at this kind of distance.=C2=A0 But it it's the one we talked about=
when I did understand it, I'm all for it.

> = If I were to classify, the first one fixes a "UI deficiency", but= the
> second one fixes a bug.

Don'= t know which is which, but classifiers will classify :-)

> = I've pushed the updated (more limited) patches to the 'fido-mode-fi= x'
> branch.

Yes, thanks!
=

Jo=C3=A3o
--00000000000018bf1105a016f3d2-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 08:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15833974068937 (code B ref 38992); Thu, 05 Mar 2020 08:37:02 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 08:36:46 +0000 Received: from localhost ([127.0.0.1]:42146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9lzq-0002K4-Ad for submit@debbugs.gnu.org; Thu, 05 Mar 2020 03:36:46 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:46339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9lzo-0002Jr-R9 for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 03:36:45 -0500 Received: by mail-wr1-f50.google.com with SMTP id n15so544702wrw.13 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 00:36:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eBkqPDtmD3Dgsb5hKr+Lw7bB6vjgB49qHv6uzAlHXDY=; b=BTaE2WbivGrMO4Rh6omhNlHAM9vqaOt5PvCARzAyDUexg+yU/PmcGUYpySiuvPEH5+ +ramY0Nhe482fMJzxsNR9WytpfjkPs/S9sY8qNmzgpRcCZVa785c0a37bwd92Z9AiBBW 7xqkAKjqW6fXOaVlUMtaYTJKiIvLq6tEkAVD3dl+72XOH/etJtXczFT+Ejor/1KhwFIw nlSswBI1xqJ0uLF7sGNaDR14PlwHPhkrgdRqulzEjzp+ltKe9BR+BJGvfn+L83ZTq67w fuIGvoMq1FFDyS03xttrQCPCBuStm1lz0PnFmyRGuQ+h6rdu6af/cA9aiBa59E/QFNpQ pxuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eBkqPDtmD3Dgsb5hKr+Lw7bB6vjgB49qHv6uzAlHXDY=; b=Ve+p4nNZH21LxVWp5+yNZMVo5iehd2nequDt7g/EeXpigRKkTDjLmlwIOW1heneEY5 wYxY98ZeBZRxJ/XmbSdvOkzNWXO/SmjMxKQ6yIqncUz+PMPZWTufKiDMWJ+6zeOe0aHr GO0hiCUIlnTsNdhliDXmyh8ainZxDs+lNfo3cpib2UORBQ1HxfNidrJRNr2Nu2N/EQE7 ewRyMQPmEimyYn3bnicK5ePoN5byTmca1RJnNGObaT7WjJcvLYrIza80utGx4eMNZzfW 6ZAg+3axqeK60qVp5qtFKSVsWOrulIY2rKOmrp8qXKzdhlUUSuLFV2StvmUxDT2GNLFA tqRQ== X-Gm-Message-State: ANhLgQ0GcImKMPJo3v0eAzKzE7OM78AnhezAC5/NwwanLwbaFtme+IEZ x/1VAYErtTOqC1zahzMeRRA= X-Google-Smtp-Source: ADFU+vuiH8i/0HPh0watX+vdXryw19IUip2CxgS7oay4cpc3Fl1QalZwsavuTbbOyeREOsWn6PB+rw== X-Received: by 2002:a5d:5188:: with SMTP id k8mr8823855wrv.265.1583397398919; Thu, 05 Mar 2020 00:36:38 -0800 (PST) Received: from [192.168.0.2] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id f207sm10118527wme.9.2020.03.05.00.36.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2020 00:36:37 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> From: Dmitry Gutov Message-ID: Date: Thu, 5 Mar 2020 10:36:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) On 05.03.2020 10:01, João Távora wrote: > >  ido-mode users, however, like to use RET for arbitrary inputs as well. > > Let's first _not_ change the current fido-mode UI ok? At least > for now.  Later (even before Emacs 27) could be fine. It only changed according to our previous discussion. E.g. RET can now accept '*.c' as pattern to search for in 'M-x grep'. Of course, if there were any matches in the completion table for that input, RET would choose the first match. Let me know if you see a problem there. > > The previous patches are attached to the older message. Not too hard to > > find on the debbugs bug page. > > I'm just looking for the patch to minibuffer.el that I remember you > saying you were preparing. (I'm sorry, but I don't have time right now to > find it in this very poor Gmail UI).  I've pulled from your branch in Git > and yours patches look fine, but really I don't understand the minibuffer > one anymore at this kind of distance.  But it it's the one we talked about > when I did understand it, I'm all for it. I think so. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 08:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15833980169849 (code B ref 38992); Thu, 05 Mar 2020 08:47:01 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 08:46:56 +0000 Received: from localhost ([127.0.0.1]:42151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9m9g-0002Ym-BQ for submit@debbugs.gnu.org; Thu, 05 Mar 2020 03:46:56 -0500 Received: from mail-io1-f49.google.com ([209.85.166.49]:36927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9m9e-0002YY-DA for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 03:46:54 -0500 Received: by mail-io1-f49.google.com with SMTP id k4so60921ior.4 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 00:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VOfAY1UqKKW/sryf6nvYJ1WCyKB2vsiUZCDI/HCbbbA=; b=SGTl08hIbNxkKpHuqaYOu8Tlxb5Gw94swH4A0+fTHTZxZ9iTIfRZoDW4PZ9WDACKAE atAuUkqPJyeMoNDpuFakP6tJA4ihJs6Riq9GyouHy3iVMyqdsbExYgLwomA/RWcIrjvR p1O/myNzf+oI+Qq2W+k771Og1hHnRy/QT+a4NtrNKlEh26Jitocf3ltKoC7rM2malg92 kdCxO24tHwyDljZ8yOeSU5518Dop6Aah1NQTs/hu6OpGWsoORHuw7BlpldjXbjxfQLkB mQ9vym2/ibIGzOv/M09Fhf1IuFHF0AiQ7GkWtzOU+FR/R//ZOFBLfLJjIJhgdjeGZ1ub K8oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VOfAY1UqKKW/sryf6nvYJ1WCyKB2vsiUZCDI/HCbbbA=; b=K7QrjmnIS2fwk6UXNumFStezkevcnZTq0+t8KhdBPworJpkNuOQJRNBXEcd0dmMEBP 0PhQux0D8TSiykTLIJDcwCvuqmN9xESOt5anqlshM5KISNCDRaVmbMZO0Ab9sruLfQyW N8zp6ONmRz9wLGfLWbRCxI2uGTZdhplU1ab0C5JcDG/X3V+P/DhwF670ssm0+afct248 xxjwFW6OYYjmHqsxhLhQoy2MIhn4htTlUjHOsYKMeJvg50xO1ot4JnrooNeVRwbGx7b6 wCOQC5KHGWqG/fyXNlJCDAd/ybhVt+IEBweQibPjCo5uvhgrzLgeipXx8et2xtjjREoA 8x2Q== X-Gm-Message-State: ANhLgQ2NmNtmGrgbpGZgE++8iL/lSYB4P9dd97yCUr11Najruta0qbla BuLZgGr/GLbXMjRIcXnL44/IJmegOO8qMdf9R6g= X-Google-Smtp-Source: ADFU+vsOzd+7aIKq7PHajYTkGawtp43XKcTfZ9FdKtj1mVY3RyRd1u1sZn3LNQktvyCQ5d6CAm7TCI0jrRnIxVlVbBU= X-Received: by 2002:a02:c9cf:: with SMTP id c15mr6499267jap.71.1583398008680; Thu, 05 Mar 2020 00:46:48 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 5 Mar 2020 08:46:37 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000d8760405a0179360" X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) --000000000000d8760405a0179360 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 5, 2020 at 8:36 AM Dmitry Gutov wrote: > > On 05.03.2020 10:01, Jo=C3=A3o T=C3=A1vora wrote: > > > > ido-mode users, however, like to use RET for arbitrary inputs as well. > > > > Let's first _not_ change the current fido-mode UI ok? At least > > for now. Later (even before Emacs 27) could be fine. > > It only changed according to our previous discussion. E.g. RET can now > accept '*.c' as pattern to search for in 'M-x grep'. Yes, that fine. I meant, let's not change it _further_ (if that was indeed what you were proposing). Also, I think, for safety, that we still should have in the fido-mode-keymap sth bound to the "atomic" give-me-whatever-is-in-minibuffer command, maybe C-M-j or something like that. Even if it _does_ break the required-match semantics somewhere else, it just seems like a good idea. > Of course, if there were any matches in the completion table for that > input, RET would choose the first match. > > Let me know if you see a problem there. Hmmm, isn't that how ido-mode behaves already, and how fido-mode behaves, at least to a large extent? If so it seems fine. Jo=C3=A3o T=C3=A1vora --000000000000d8760405a0179360 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Mar 5, 2020 at 8:36 AM Dmitry Gutov <dgutov@yandex.ru> wrote:
>
> O= n 05.03.2020 10:01, Jo=C3=A3o T=C3=A1vora wrote:
>
> > =C2= =A0> =C2=A0ido-mode users, however, like to use RET for arbitrary inputs= as well.
> >
> > Let's first _not_ change the curren= t fido-mode UI ok? At least
> > for now.=C2=A0 Later (even before = Emacs 27) could be fine.
>
> It only changed according to our p= revious discussion. E.g. RET can now
> accept '*.c' as patter= n to search for in 'M-x grep'.

Yes, that fin= e.=C2=A0 I meant, let's not change it _further_ (if that was indeed
what you were proposing).

Also, I think, fo= r safety, that we still should have in the fido-mode-keymap
= sth bound to the "atomic" give-me-whatever-is-in-minibuffer
<= /div>
command, maybe C-M-j or something like that.=C2=A0 Even if it
_does_ break the required-match semantics somewhere else,
= it just seems like a good idea.

> Of course, if there = were any matches in the completion table for that
> input, RET woul= d choose the first match.
>
> Let me know if you see a pro= blem there.

Hmmm, isn't that how ido-mode beha= ves already, and how fido-mode
behaves, at least to a large = extent? If so it seems fine.

Jo=C3=A3o T=C3=A1vora<= /div> --000000000000d8760405a0179360-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 10:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158340240416540 (code B ref 38992); Thu, 05 Mar 2020 10:01:02 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 10:00:04 +0000 Received: from localhost ([127.0.0.1]:42184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9nIS-0004Ii-BU for submit@debbugs.gnu.org; Thu, 05 Mar 2020 05:00:04 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:40473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9nIQ-0004Hi-42 for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 05:00:03 -0500 Received: by mail-wr1-f54.google.com with SMTP id r17so6196018wrj.7 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 02:00:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nn6hxJko5oBKau39XEk2ZgwvbbdN6u2feVvJSZ9LmJw=; b=CIMWL8Tlg1EitvcKg55v78tTYXY3VFZm7KHdH6uJUGvIKmtYagLBrIdFc14rBCCy5S dH4g16n1NSuOA4+lSYP8KF/KTvDiuoY2hOKzKLt2wikIbR77bZIZ165ERIoLwSof4AP5 xMfSIJJaxTeNxeQBsEJ4l8Ml3xrUyaXADVejErcoFsVcKub3TqOlgDAcygR/ND8ViOiN TYSoJ/LoVRKABxs4RrUK8fVUymh10X13tkuUxHVk3dj3j6GC8MvV3tZtem/V04hxtZBz Ng0CsjhX650kl9SGwmRxageCXXULZ0Id2nYEBLRucLAkDZ1X6iC+8Rp7bZy1Q9EptsDS MStQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nn6hxJko5oBKau39XEk2ZgwvbbdN6u2feVvJSZ9LmJw=; b=ISjNP+wGzXxg9O4ejdSdvnu3Z5NGy45zZsiQsinwninSalqNoF8hCnG0VkkLqihped XqchmiN4iQFErT2+Cp3QKs8hWD0vaXDSdP6hC5XiM2JucGFgjucInCXXxqhGbu4RaHky VsAnhFP5tCVsBl1cOzaXhurRm49V6svyuqzMYU1QDDy7XdmktGk5hxqjx/hgiAWJvwWm DPymgh5LwKUyeRODIhidvCTovFtDLsKpG3/5ru1nbbJNIHTvw32AMWbWqtGFg1w5iA1Q GwSDyWWElTpHkTjbcu3tK011F3sGL2swUASLBNdVf+FMlSnWqoELYhkeBgPy0X3HAZK2 O2Tg== X-Gm-Message-State: ANhLgQ2DTxHXt6kRCV9seNd6HHacc7z50CDbX76nHeXSJHoUT/kvNFWs sC4Fbe++RR9CSYPLwWgvcT0= X-Google-Smtp-Source: ADFU+vu9ebKnCk8Vi1ToiqPzbxtf8RZyhNJvWfG2Gg8p/+HWgboyFDhTg+TbkhnnaiGaiT6a/I/fxA== X-Received: by 2002:a5d:608e:: with SMTP id w14mr9845240wrt.201.1583402396189; Thu, 05 Mar 2020 01:59:56 -0800 (PST) Received: from [192.168.0.2] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id l3sm43516734wrq.62.2020.03.05.01.59.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2020 01:59:54 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> From: Dmitry Gutov Message-ID: <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> Date: Thu, 5 Mar 2020 11:59:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) On 05.03.2020 10:46, João Távora wrote: > On Thu, Mar 5, 2020 at 8:36 AM Dmitry Gutov > wrote: > > > > On 05.03.2020 10:01, João Távora wrote: > > > > >  >  ido-mode users, however, like to use RET for arbitrary inputs > as well. > > > > > > Let's first _not_ change the current fido-mode UI ok? At least > > > for now.  Later (even before Emacs 27) could be fine. > > > > It only changed according to our previous discussion. E.g. RET can now > > accept '*.c' as pattern to search for in 'M-x grep'. > > Yes, that fine.  I meant, let's not change it _further_ (if that was indeed > what you were proposing). Nope, just this. > Also, I think, for safety, that we still should have in the > fido-mode-keymap > sth bound to the "atomic" give-me-whatever-is-in-minibuffer > command, maybe C-M-j or something like that.  Even if it > _does_ break the required-match semantics somewhere else, > it just seems like a good idea. But why? REQUIRE-MATCH is there for a reason. The caller does not expect non-matching inputs, and is unlikely to handle them well. If non-matching input can make sense, then the caller needs to be changed. > > Of course, if there were any matches in the completion table for that > > input, RET would choose the first match. > > > > Let me know if you see a problem there. > > Hmmm, isn't that how ido-mode behaves already, and how fido-mode > behaves, at least to a large extent? If so it seems fine. No, I meant a problem in overall behavior. But it seems fine to me as well. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 11:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158340911527437 (code B ref 38992); Thu, 05 Mar 2020 11:52:02 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 11:51:55 +0000 Received: from localhost ([127.0.0.1]:42278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9p2h-00078T-4D for submit@debbugs.gnu.org; Thu, 05 Mar 2020 06:51:55 -0500 Received: from mail-il1-f171.google.com ([209.85.166.171]:34845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9p2f-00078G-Lu for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 06:51:54 -0500 Received: by mail-il1-f171.google.com with SMTP id g126so4771171ilh.2 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 03:51:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WM2wu4RsvPWBVaP9ToGBA/tvcqVFu9iTGXxP2W5wiJE=; b=CR1IDlhWwSi7OmcU3Bfl1E2COd71QRzggkSu/I2vk3VaHESiDCAODNGjNiU0CAnvS5 QIHChRjcS7+uHAIfu+IsaiURnfMhyClw7ZH1olqJucNbb1RzG2wjx5GbjicR0idtUGrO 6vQWlh+MbmCIoiSVFuoFdNHEGMJB7jsY9TvBw492c92ObZBRhFS5OgfLDCqJssB8OkFe lgTgQlnL8zAx1BvwJlkro2pxOCv/xAxbMEbfIEl1eooyKHRZ6Jv4RhjT/jr6YjdXve41 Vkp7Wqm8Xd5DzHhL+e5o+DyaYaArHMOYpEAOXhxc64N2kjuTP6gDYOdI6RFqkOZ93F0g 4LJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WM2wu4RsvPWBVaP9ToGBA/tvcqVFu9iTGXxP2W5wiJE=; b=MzF3qkL2b8Q08tmRsyBdcFA0RkaFS3oM0IMhBtFTMwm7UaHI9pwJXen3vLrqzFrzqj 9QGv4TT+88pngJeakHplbwDLSQXCZIT75gEWvmDRxfHTlJkwAr9O+SB0j+7tpHkoKuvL Gx05x4jcq7SBUFvu0yLHFy1Nz9ZlDoxdH6rKEpNZyCBRbJ64nhYA7LZhB2BzsR0YIoio z8rR96n2bATaRDdsxSygc17n8Gtl3aYtxvCvHUS7fvyde78pUTQZpg0LZ/femAN9G2zE +jt36OJhDr7pxFeHrKpAJyRSTApMJVpcGP8FSdILsM2/JdesrSIhgA34jY7eNJjhCmnZ YvcA== X-Gm-Message-State: ANhLgQ3xZ/K0vGVgjv1MUo8BkMhmj2ELnVBGKQc54s82bXPXBO3/qtTV HrB21P3wJh9MOjTMMMmVifvCo+zVVyms5HbbIuQ= X-Google-Smtp-Source: ADFU+vuUJGQq6uaiRcTg0yl+xzPI3kp0bsmjiVD5B0QiYa61JQZOH/LvkFYIPmHE9FLqhKsNunJDtPkIFjK3prTuJz0= X-Received: by 2002:a92:8f91:: with SMTP id r17mr7111649ilk.97.1583409107018; Thu, 05 Mar 2020 03:51:47 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> In-Reply-To: <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 5 Mar 2020 11:51:35 +0000 Message-ID: Content-Type: multipart/alternative; boundary="0000000000005ba85905a01a29d3" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005ba85905a01a29d3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 5, 2020 at 9:59 AM Dmitry Gutov wrote: > But why? REQUIRE-MATCH is there for a reason. The caller does not expect > non-matching inputs, and is unlikely to handle them well. > > If non-matching input can make sense, then the caller needs to be changed= . > Sure, but before that happens, users get annoyed :-) so let's provide an "out" for them. No, I meant a problem in overall behavior. But it seems fine to me as well. > OK, at this point I think you should push this to Emacs 27, and I'll work with it for a while and flag if I see some bad stuff. We mostly need testing for this new mode (I wonder how many people are testing it, besides the original poster). --=20 Jo=C3=A3o T=C3=A1vora --0000000000005ba85905a01a29d3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Mar 5, 2020 at 9:59 AM Dmitry Gutov <dgutov@yandex.ru> wrote:
But why? REQUIRE-MATCH is there for a reason. The caller does not expect non-matching inputs, and is unlikely to handle them well.

If non-matching input can make sense, then the caller needs to be changed.<= br>

Sure, but before that happens, users ge= t annoyed :-) so let's provide
an "out" for them.

No, I meant a problem in overall behavior. But it seems fine to me as well.=

OK, at this point I think you should= push this to Emacs 27, and I'll work with
it for a while and= flag if I see some bad stuff.=C2=A0 We mostly need testing for this
new mode (I wonder how many people are testing it, besides the ori= ginal
poster).

--
Jo=C3=A3o T=C3=A1vora
--0000000000005ba85905a01a29d3-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 12:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158341050729755 (code B ref 38992); Thu, 05 Mar 2020 12:16:01 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 12:15:07 +0000 Received: from localhost ([127.0.0.1]:42298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9pP8-0007jr-KW for submit@debbugs.gnu.org; Thu, 05 Mar 2020 07:15:06 -0500 Received: from mail-wm1-f41.google.com ([209.85.128.41]:39465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9pP6-0007j6-UR for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 07:15:05 -0500 Received: by mail-wm1-f41.google.com with SMTP id j1so5476142wmi.4 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 04:15:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cCnxT52O0XZAFSIzOtea9tRnbphlwhg1p5Eu4hlwzRI=; b=l8rj9+o/JudHbRQeVPOR9sbNlx+nm4FxTrJNajF9I06IDYy7jXrYaqzJCA/EiFV85c IU2mXa80oGksfPT60HlNm6o5H8YXI+BLbQTU9KNw7LEG2BBJxPIfClg1dfcZ72QwqoCl f9YrKvU5y3+2KeuQhfRRK8dKdl+GuJnmgeGk0qbuTYzm8TRbkAslUnTnz2/Ac54GXc5i 8wnUgEaVqSgZKgpJK9qg7zWmO9w9LG+ROJ/RTJKJ7LHkjlHiPSDZ7ktfyBo2rTQGCrO7 9NuNzRhKDgNQlp1kvrGcAhaJQ/RLxgXoFL+pNIqW6FsthgZZBBq1R9ktddOibqpYgF+B rfvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cCnxT52O0XZAFSIzOtea9tRnbphlwhg1p5Eu4hlwzRI=; b=dDF3SHCtjyaTE4fFEUSm6+qcfS7pUEb1bU3K/vXJDsJKBiydN5maRDI6b0I+0LU3CK 1mZo5flmbiOaISPeTt53BphPYYgFcaimzQjReZzE3o0h227ln9ldumeh1ufjpmBhQi/2 XAIRdwQut3kkZyswsdYuwxfmcwCSK69ZJPYT0AAwOVgsR/BTf/ed2YTRxx4SCgLAUAw0 KODyNl2rujtCFJRWiYJ28ElWEW+eAYL/vbpQxbwNOGSVGdcI8FqupfeDxNOGRWjI69u/ oBQ5+YnizH0khnE+oIiLIC9yVsRDfB11ACRlRjWo5WNIdvRMyUeiYIUP1cs7l+0vfm1V UdgA== X-Gm-Message-State: ANhLgQ2MAUx9MtAJ8J8A3biJ+VwYPo/TR2p1COZeNCxdUGK8XOnrvK6r hk4OxB5hCthnieqiWRf6JQo= X-Google-Smtp-Source: ADFU+vtN6rk9Y3StpT02ciaDWuYzyTETlE+wCcbK0P9FnggCoU0zrpkepd1vr1t0wwaYklugMU1f6w== X-Received: by 2002:a1c:8041:: with SMTP id b62mr9096073wmd.76.1583410498048; Thu, 05 Mar 2020 04:14:58 -0800 (PST) Received: from [192.168.0.2] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id l3sm43992707wrq.62.2020.03.05.04.14.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2020 04:14:56 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> From: Dmitry Gutov Message-ID: <2c5f6c44-7ca3-f1c9-d18d-3bf0d65548b9@yandex.ru> Date: Thu, 5 Mar 2020 14:14:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 05.03.2020 13:51, João Távora wrote: > Sure, but before that happens, users get annoyed :-) so let's provide > an "out" for them. And when they use that "out", and the program behaves randomly, they'll get annoyed, file confusing bug reports, etc. Why would we want that? Do you have a specific scenario in mind where it would help? > OK, at this point I think you should push this to Emacs 27, and I'll > work with > it for a while and flag if I see some bad stuff.  We mostly need testing > for this > new mode (I wonder how many people are testing it, besides the original > poster). I've seen it mentioned on Reddit, and mentioned it myself on at least one occasion. So there definitely are people using it. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 12:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15834114531671 (code B ref 38992); Thu, 05 Mar 2020 12:31:02 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 12:30:53 +0000 Received: from localhost ([127.0.0.1]:42314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9peO-0000QR-N5 for submit@debbugs.gnu.org; Thu, 05 Mar 2020 07:30:53 -0500 Received: from mail-io1-f48.google.com ([209.85.166.48]:35518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9peM-0000Jz-NY for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 07:30:51 -0500 Received: by mail-io1-f48.google.com with SMTP id h8so6271515iob.2 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 04:30:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y5i5SMd3dB9/xKVhL0yHsWxkVcGam6Nz7D+XsiknZYI=; b=P+XslnokQ9lX162yQAqqkJnj71tvNe1ml0rOM0ptSVhGVjyZi8MVNkz6YFBlxxsnph f4zVzvH0+1UNBa1I6nVptJIVRaTviMPzO6RDUiI/W0fHDL1oYiqMs3D4xHf+Tujbk2cx m/7SykLxGdu5ERKwb4C1D7A07mzlAVVBgHwh4jV+w+sKpLUsPozNf9mmQ6z9HagwgMgr PuByQyF9MwTw53Oulz27O7gf2oJF4haZMvGNv+5NBYggVSPqGKk/zTvnOMjHqmwvUsqO AMHed3oCgTDzl3BLyHDupLtaNdrtW0h2zSa9u0H5GzwMKjmO143ChqQB7BvxAsp8eyLq 09LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y5i5SMd3dB9/xKVhL0yHsWxkVcGam6Nz7D+XsiknZYI=; b=Agc6AVtSrorPPjRwca3qjYRWqVLbV3vHBjB2fqopF+nS51LIJIxq0nLB8YQ+XB39ZR QB/HoY7hkzrbG+w0ApbiuYxfHfLfsDhnAwmbeptixPB33/1SA2V0UP2YcJNeZXfPzVxO YMghfA1XIVhW9id7n+2xdV6Nvq/Pp6HMcGwysR/wBKqpMONned+kCEsg/qZped4u20oF tSqLEPDqid96cDDklp+ATHtPjrsW2fIaIswKqrP4qINERFdKjFOZzhvKZsmD2jEtATMh IUGd2BWtwfJJ1evMJFid43wSDes70kIIyNARy32GLFZdHUrZqTOFvol4tEiPRlA+qbRh ob0w== X-Gm-Message-State: ANhLgQ0/952eWLb3HacIrNgH4AvSaO9zQBH+XW1GDsn+THxjEgbVfP+L bhcAE7993C+xgeMy5iWgH982LzAnrUGvlLdsJnU= X-Google-Smtp-Source: ADFU+vudoQvQEHRKjQFtzUQTocjVcnq1PmNE068vUyKEnUcep9xfAp7vHl50IQ4B/AEk/ugtGnu7h6MIUYphXnvF4Fk= X-Received: by 2002:a6b:e517:: with SMTP id y23mr4413007ioc.97.1583411445134; Thu, 05 Mar 2020 04:30:45 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> <2c5f6c44-7ca3-f1c9-d18d-3bf0d65548b9@yandex.ru> In-Reply-To: <2c5f6c44-7ca3-f1c9-d18d-3bf0d65548b9@yandex.ru> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 5 Mar 2020 12:30:33 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000b8793205a01ab43e" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b8793205a01ab43e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 5, 2020 at 12:14 PM Dmitry Gutov wrote: > On 05.03.2020 13:51, Jo=C3=A3o T=C3=A1vora wrote: > > Sure, but before that happens, users get annoyed :-) so let's provide > > an "out" for them. > > And when they use that "out", and the program behaves randomly, they'll > get annoyed, file confusing bug reports, etc. Why would we want that? > Any of those things are better than the feeling of being trapped in a UI. And anyway, they're really unlikely, who would use the finger-contorting atomic option without knowing exactly what they're doing? We can even add a warning message, or even a prompt, if you feel so strongly. If still object, at least I would mention in the keymap's docstring how to add such a thing. Do you have a specific scenario in mind where it would help? > Well, as I said I do remember binding M-j to it for this specific circumstance, but that's before your fix (which I am still to try out). Jo=C3=A3o --000000000000b8793205a01ab43e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Mar 5, 2020 at 12:14 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
On 05.03.2020 13:51, Jo= =C3=A3o T=C3=A1vora wrote:
> Sure, but before that happens, users get annoyed :-) so let's prov= ide
> an "out" for them.

And when they use that "out", and the program behaves randomly, t= hey'll
get annoyed, file confusing bug reports, etc. Why would we want that?

Any of those things are better than the feel= ing of being trapped in a
UI.

A= nd anyway, they're really unlikely, who would use the
fi= nger-contorting atomic option without knowing exactly what they're
doing?=C2=A0 We can even add a warning message, or even a prompt, if=
you feel so strongly. If still object, at least I would men= tion in the
keymap's docstring how to add such a thing.<= /div>

Do you have a specific scenario in mind where it would hel= p?

Well, as I said I do remember bindin= g M-j to it for this specific
circumstance, but that's b= efore your fix (which I am still to try out).

Jo= =C3=A3o
--000000000000b8793205a01ab43e-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 13:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158341561913510 (code B ref 38992); Thu, 05 Mar 2020 13:41:01 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 13:40:19 +0000 Received: from localhost ([127.0.0.1]:42344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9qja-0003Vp-Pv for submit@debbugs.gnu.org; Thu, 05 Mar 2020 08:40:19 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:34455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9qjY-0003Vb-Tj for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 08:40:17 -0500 Received: by mail-wr1-f52.google.com with SMTP id z15so7099453wrl.1 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 05:40:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=z8cfrMHMqEWvBUqb2/cLRP/WjEuixlNurq2ja+p5QY4=; b=IeFgByQa1+u6q9DNsxRNEpNxDGjEyaRyc/rFXzOnFvOCn+C1hns1+h8e6+E2nUp/XL x0o8ChVg6/wFUfDxXIchUOw8AoPvFOn7XG+BxP9vNVr4p8lZH3OYL166zKFAreFzxsL5 OsxY4zT6tyKjBWIIHY45Tk73YOWEbAIn2Bux4beSNYvmfKb8DI8u8EE39BuvRTWbw9+h Zay3FyjbhVe/YXDu9cP6xVvn8D59oqrrZK+bFdBgixBL8GdD/2hHmONVAplkAz9H7Ew1 /Wbux3haCI40HKaiDaEH4Qpe5gQTd1a45uHEMQMt2A+GKm2v44J8l6Ud1IPrc8zx8n0T kktw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=z8cfrMHMqEWvBUqb2/cLRP/WjEuixlNurq2ja+p5QY4=; b=dbpEndG0DPw6/0W2DMO/tjsQx2EqpUALbR9h4w8yhgVmadQk96+dp7zzl6feGeLnyQ +X7KyRCh0/kh27mKgP3eJKfj9dsQxm71cTbTxdl0fFSvVh4prSNP8SCm/jRPRrC45RvE 3QSt25qWfKf41oJDiyFmRIKOyw5gnQ2YVpEhMl5/QRlhz4rR3yQc2VDUd0kzZkOY9ULL sk0yOWHL/T91ZG9sj8VpI+XKIeh7Nm+cda8eLE4geE7alJtQ7S7HrlA/Pz8W0mNmN2oq Lv+xNckklG7pvcbTcEb0AwJ/1PbIsWOxNTTvcI3A5PsWf2eJWjj+k5dxMECbOi5cOQZz 3lQA== X-Gm-Message-State: ANhLgQ0zGGEUYrBSJbauI6cvxeCvhQa/qXolngVrA3z7u7lZ1OzGjcNQ oWezTOUwrZhUd8tbjm9Q1WI= X-Google-Smtp-Source: ADFU+vtNZOJ2Lnochzu1W680eBUrkWgMkG/Ec5xaH9KW08eWGJjFkqy5gaGrIigiI5U3CyCjTEniIw== X-Received: by 2002:a5d:68ce:: with SMTP id p14mr10136466wrw.315.1583415610857; Thu, 05 Mar 2020 05:40:10 -0800 (PST) Received: from [192.168.0.155] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id t124sm10000555wmg.13.2020.03.05.05.40.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2020 05:40:09 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> <2c5f6c44-7ca3-f1c9-d18d-3bf0d65548b9@yandex.ru> From: Dmitry Gutov Message-ID: Date: Thu, 5 Mar 2020 15:40:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) On 05.03.2020 14:30, João Távora wrote: > And when they use that "out", and the program behaves randomly, they'll > get annoyed, file confusing bug reports, etc. Why would we want that? > > > Any of those things are better than the feeling of being trapped in a > UI. First: I disagree with that assessment. Second: trapped by the UI or not, we are still limited by what values the program that called completing-read is prepared to handle. > And anyway, they're really unlikely, who would use the > finger-contorting atomic option without knowing exactly what they're > doing?  We can even add a warning message, or even a prompt, if > you feel so strongly. If still object, at least I would mention in the > keymap's docstring how to add such a thing. I mean... if your idea of an "out" is to give it a "finger-contorting" binding and a secret password, of course that's unlikely to cause many problems. I don't know how (or why) to add instructions to the docstring for something that we advise against doing, though. What phrasing to use, etc. But the "how to do it" is very easy: add an 'exit-minibuffer' binding to icomplete-fido-mode-map. > Do you have a specific scenario in mind where it would help? > > > Well, as I said I do remember binding M-j to it for this specific > circumstance, but that's before your fix (which I am still to try out). Please do when you have the time. And also, here's a thought: anytime you feel like using 'exit-minibuffer' to counter the REQUIRE-MATCH=t argument, that should probably be accompanied by a patch to the caller function to change that argument to nil. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 13:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158341646714772 (code B ref 38992); Thu, 05 Mar 2020 13:55:02 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 13:54:27 +0000 Received: from localhost ([127.0.0.1]:42358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9qxH-0003qB-6D for submit@debbugs.gnu.org; Thu, 05 Mar 2020 08:54:27 -0500 Received: from mail-il1-f175.google.com ([209.85.166.175]:43548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9qxF-0003pz-Qc for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 08:54:26 -0500 Received: by mail-il1-f175.google.com with SMTP id o18so5057520ilg.10 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 05:54:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GzBuRZNalhxRnmk61kNrQRJ75BxEdXFes2BONRPNS6k=; b=W8Hvwy3Wl767GtHMkVzG8QZ/R+1eCGLddV1d3/F2Ze8YG/gOBJdHSoZec+GVN2U2dV E7wQ3iX+j4oC8p3/z9IGT3bl3u6TRFEZoO50oc+8vZ3+af5+cAx/ljSKyOYWQQJgDIVB A6HTjoD6s6PUqu+eZjAcYQjXsVj/FMFVCn2iEN50cb90TiDiS/JFfyq9qkLbvu+nSK5p hcOnEwd2HQg0dViwtBYkVfKh0hiODFetRmZA2w/PvXI45FXxd5uD/1VykOpErgN/ZcUo v6Dl78QVDnN+t/4MwEOdWzv0X7MYwZnuji2m/AzGFBzbB/bUBXvVvU1KQHIhg9JrmbLD s0tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GzBuRZNalhxRnmk61kNrQRJ75BxEdXFes2BONRPNS6k=; b=KVWYcoTA+MoBUzulsN58DpppOorlJTiKfF6I+gyJxHW24BNBFpgw9ygEkouoAb+f43 6UOg45AXYF/SgJX0nxZB76zAdVpt4nrgmBQWsOckdFEmKcpsEO24bkO1DR41sDdEAX1f JaAbgxxwgpvdQyBE6apPSkmGmkPZwTuxAAq3oVf4SBFkHu1iRxdwZz/w+9vH+sozj+aX EVQGs6HBE1KLJh5hu65EN03oUd1ShvHm/hii4kJ7D5FM9l6Gj1nYu1ENcUbh8gKuGFGE jNj+MHBo7vPiEtBTR7LxtOS4BBfIVcUsRq3BI+IjhnkojUFNlr0Q4LJgDLZRUfBJuo0j L90g== X-Gm-Message-State: ANhLgQ0AtJJExerFD7VvFYbv2guU56wOIivhsBgi/RV1obTkuDAqv4Q1 YVACg7fRMRLf64jmbwaMi/GNz2BPOxfEGaEgub4= X-Google-Smtp-Source: ADFU+vuvuDASZZ25fuorGbJpGuGTGnnaCIFo7ATKZOqDOE6dYO3VTEhmCAoKEcB2dooCGuXQ7Lnu7vUICtMkWaOuX+U= X-Received: by 2002:a92:8f91:: with SMTP id r17mr7572466ilk.97.1583416460040; Thu, 05 Mar 2020 05:54:20 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> <2c5f6c44-7ca3-f1c9-d18d-3bf0d65548b9@yandex.ru> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 5 Mar 2020 13:54:08 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000a1e05b05a01bdf69" X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) --000000000000a1e05b05a01bdf69 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 5, 2020 at 1:40 PM Dmitry Gutov wrote: > On 05.03.2020 14:30, Jo=C3=A3o T=C3=A1vora wrote: > > And when they use that "out", and the program behaves randomly, > they'll > > get annoyed, file confusing bug reports, etc. Why would we want tha= t? > > > > > > Any of those things are better than the feeling of being trapped in a > > UI. > > First: I disagree with that assessment. > > Second: trapped by the UI or not, we are still limited by what values > the program that called completing-read is prepared to handle. > Of course. What I'm saying it that there may be completing-read that may benefit from an informed exit with something not in the completion list. Calculating a completion list is fickle and often it fails by scarceness. I mean... if your idea of an "out" is to give it a "finger-contorting" > binding and a secret password, of course that's unlikely to cause many > problems. > Yep, that's my idea. Or a C-u to your icomplete-fido-exit would do just fine, too. Assume "secret password" is you being funny. > I don't know how (or why) to add instructions to the docstring for > something that we advise against doing, though. What phrasing to use, etc= . > Well, I don't advise against it, you do. I just want to give users a better library. But if you're fine with C-u. > > Well, as I said I do remember binding M-j to it for this specific > > circumstance, but that's before your fix (which I am still to try out). > > Please do when you have the time. > Sure. > And also, here's a thought: anytime you feel like using > 'exit-minibuffer' to counter the REQUIRE-MATCH=3Dt argument, that should > probably be accompanied by a patch to the caller function to change that > argument to nil. > Sure, time-permitting, of course. But again, not that the changing of the argument might _not_ be the fix. I expect the real fix in those situations to be about the computation of the allowed completions. Those are probably more complex fixes. --=20 Jo=C3=A3o T=C3=A1vora --000000000000a1e05b05a01bdf69 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Mar 5, 2020 at 1:40 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
On 05.03.202= 0 14:30, Jo=C3=A3o T=C3=A1vora wrote:
>=C2=A0 =C2=A0 =C2=A0And when they use that "out", and the pro= gram behaves randomly, they'll
>=C2=A0 =C2=A0 =C2=A0get annoyed, file confusing bug reports, etc. Why w= ould we want that?
>
>
> Any of those things are better than the feeling of being trapped in a<= br> > UI.

First: I disagree with that assessment.

Second: trapped by the UI or not, we are still limited by what values
the program that called completing-read is prepared to handle.

Of course.=C2=A0 What I'm saying it that there = may be completing-read
that may benefit from an informed exi= t with something not in the
completion list. Calculating a comple= tion list is fickle and often
it fails by scarceness.

I mean... if your idea of an "out" is to give it a "finger-c= ontorting"
binding and a secret password, of course that's unlikely to cause many =
problems.

Yep, that's my idea. Or a= C-u to your icomplete-fido-exit would do just fine,
too.=C2= =A0 Assume "secret password" is you being funny.
= =C2=A0
I don't know how (or why) to add instructions to the docstring for
something that we advise against doing, though. What phrasing to use, etc. =

Well, I don't advise against it, y= ou do. I just want to give users
a better library. But if yo= u're fine with C-u.
=C2=A0
> Well, as I said I do remember binding M-j to it for this specific
> circumstance, but that's before your fix (which I am still to try = out).

Please do when you have the time.

Sure.=
=C2=A0
--
Jo=C3=A3o T=C3=A1vora
--000000000000a1e05b05a01bdf69-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 14:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158341703715714 (code B ref 38992); Thu, 05 Mar 2020 14:04:01 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 14:03:57 +0000 Received: from localhost ([127.0.0.1]:42378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9r6S-00045O-TA for submit@debbugs.gnu.org; Thu, 05 Mar 2020 09:03:57 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:51940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9r6Q-00045B-Ok for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 09:03:55 -0500 Received: by mail-wm1-f45.google.com with SMTP id a132so6453687wme.1 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 06:03:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6UEnx2JzXfGy7OlrU/5R98Dze3jagNLwpJ+1PUy5mts=; b=cTI5LHGqYoRcE2TFehgvZGNRO6iw4w0vh5m6VO1vLsTG1DFoFdyxQWUngvfirxhHWj xF0daeidq69r00bG5FDK6yvp3vCHtKjgDJs2HuAstBXDIdXP1b1jmnErpK0l4EwDdJ37 jL/ki/of1WZFaiXOniGV61qRh3Qe0wwpz6AANcFhkHwYXZeuGD8l0rPgqdVfIDBCkkD5 /6CGkeCphkzxix+vHB3jJTlmG3oXiqc2oRcELMQiqfHJxWe89r/x6dOOW8gbZLrHWvaK WSHcwO876Ro6qTHE17JsAylzRxxGE6cafvKoUyYZ90BOq3jdvjokDRQUAM6mNgKRfUww YMzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6UEnx2JzXfGy7OlrU/5R98Dze3jagNLwpJ+1PUy5mts=; b=E+x6AB7zqZ1/eFSryofDt2zadpWdipuw7YeHk7CAbcsojVOkNJkPfGpomFa1hqBICU J5cD2IzjJcJQRzrcEDNJwgFlt3NfeYk0IG1v0dmFlNkDXIp+hF6P85eghYHn7Pw9PDqp wsbTe/c1HduuwnLp1GZ9lb/5oHFGN6dAoaURRLfg1O+VnctWNBVnkCpel75aZsr8ymOl mr0Tvor/b9fh5evwtSxbVityoztmZqCSO+k0x8yXxS3kJxSeLb+eAPyfD8Oo7ZtrCQYO WSWDjbQ03zmPJy7FuHh3k7Pg5EUB5V4ltI1LmRutr1FGT+hqtwsJMUcEEKNsGhAmqhJf QDFg== X-Gm-Message-State: ANhLgQ32r4c2+DRJd3YZ8zqV2sDbid6LpH2T3tfBrGRJ1N3Gr+YLkmK/ QMfJo9cCcu3u87x03ScZqK0= X-Google-Smtp-Source: ADFU+vt5DJ81VLCK2uQdQrbsCpxqibIe2zcvpvENUDlZSGuyyHmIYGaFKCeg/sM3eGqFXx5uBA2M7A== X-Received: by 2002:a1c:1d8d:: with SMTP id d135mr9915625wmd.107.1583417028849; Thu, 05 Mar 2020 06:03:48 -0800 (PST) Received: from [192.168.0.155] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id o26sm8926821wmc.33.2020.03.05.06.03.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2020 06:03:47 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> <2c5f6c44-7ca3-f1c9-d18d-3bf0d65548b9@yandex.ru> From: Dmitry Gutov Message-ID: <62da5d4c-2db8-864e-0d08-ed751ff82c0b@yandex.ru> Date: Thu, 5 Mar 2020 16:03:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 05.03.2020 15:54, João Távora wrote: > Second: trapped by the UI or not, we are still limited by what values > the program that called completing-read is prepared to handle. > > > Of course.  What I'm saying it that there may be completing-read > that may benefit from an informed exit with something not in the > completion list. Calculating a completion list is fickle and often > it fails by scarceness. OK, fair enough. > I mean... if your idea of an "out" is to give it a "finger-contorting" > binding and a secret password, of course that's unlikely to cause many > problems. > > > Yep, that's my idea. Or a C-u to your icomplete-fido-exit would do just > fine, > too.  Assume "secret password" is you being funny. How about 'M-x exit-minibuffer RET'? :-) If it's indeed a rare situation. > I don't know how (or why) to add instructions to the docstring for > something that we advise against doing, though. What phrasing to > use, etc. > > > Well, I don't advise against it, you do. I just want to give users > a better library. But if you're fine with C-u. I will recuse myself by saying I have no opinion on C-u. > And also, here's a thought: anytime you feel like using > 'exit-minibuffer' to counter the REQUIRE-MATCH=t argument, that should > probably be accompanied by a patch to the caller function to change > that > argument to nil. > > > Sure, time-permitting, of course.  But again, not that the changing of > the argument might _not_ be the fix.  I expect the real fix in those > situations to be about the computation of the allowed completions. > Those are probably more complex fixes. That makes sense, but in general, when the caller fails to enumerate all possibilities, it should set require-match to nil. But it's not so black-or-white, OK. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 14:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158341785517007 (code B ref 38992); Thu, 05 Mar 2020 14:18:01 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 14:17:35 +0000 Received: from localhost ([127.0.0.1]:42397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9rJe-0004QF-Vj for submit@debbugs.gnu.org; Thu, 05 Mar 2020 09:17:35 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:42137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9rJd-0004Q4-0v for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 09:17:33 -0500 Received: by mail-wr1-f53.google.com with SMTP id v11so5269081wrm.9 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 06:17:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=k7lO9EcC9fuqOGj+GjYEVc+OWQwm6+ubmrfHNFWIQFE=; b=pumRgSTOeJ4UzlA3r9Mm0fWHtK/Fi393RnF0dP4THoxw6oUHi2CagG9Yii+970fZnu Y2SnB3aVgWm1uxG04WPDGA8OsphIhFSCrP2vl3a/nFvoOzoSsQnUPrEUAtUtMBbbWLDb 2oO/jSOP1gNcHuoSxQ6EyhuKIQ6/db7aSOTOIvtOJJQDJ7ld179zEtjUkT57ECjH4Rpa dcxrhdBHyVZ1nYd0JpFDkAcohMCRqkqs604ncPjTdaObNwKEL8LLMqzyWd9O51KOVUl2 GwG+7pleY6sni5mtscrV9xkIaWo/q0RRHLu863vI2iwzgOxCdtvNS5i63m/VmDyraikt 5QOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k7lO9EcC9fuqOGj+GjYEVc+OWQwm6+ubmrfHNFWIQFE=; b=k42pKEBtPh5Fw4/2jkqtPk+wou1mZM9bHzR7Rfna+OIMqHKJTT5fHtUAiDFc6aiPHR Em3MQcRl1DWaAcwQybCT3h46MqGaHF/+qoUbo9Cnjx1P27k0u1ba2C7/4R7dlUdCfSgk JfAyaRoRkOlqZ3fPV6sQP5Tq2txO+8MoLO0xCqEI6Nx7x7HHKyzDLk3PPF43v612RzS8 ADVTyUii+T8dBgfj2G4BhNecu6zMKcU6Ee1dei/haUTzOLZ0nE3t5/9aDz/UhUqGRImB EUT5g2jUC3WYW/rVUACA47eDVO6uqWOxSFrqRYZLeUi6KsIu2uOM5Mj3iLMgfBfZLXUp qdFA== X-Gm-Message-State: ANhLgQ3hxaP4Lkyq7jOWcKUQ8EFyr5uMadKIQBBcbt4QsDvH008TDutu HtR5CUXxNyawxJRL+W7wND3EgY8h X-Google-Smtp-Source: ADFU+vtlZSFpDgMt1G0tlSvKaZtVDgz5rKZlwzoFOqPhyt1N+xfo0AnAuT9eNp2fMb8kbG2LGzWE6g== X-Received: by 2002:a05:6000:1246:: with SMTP id j6mr8642476wrx.253.1583417846621; Thu, 05 Mar 2020 06:17:26 -0800 (PST) Received: from [192.168.0.155] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id u25sm9452595wml.17.2020.03.05.06.17.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2020 06:17:20 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> <2c5f6c44-7ca3-f1c9-d18d-3bf0d65548b9@yandex.ru> <62da5d4c-2db8-864e-0d08-ed751ff82c0b@yandex.ru> From: Dmitry Gutov Message-ID: <658de140-d00b-2a4f-baa5-f261a135410e@yandex.ru> Date: Thu, 5 Mar 2020 16:17:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) On 05.03.2020 16:10, João Távora wrote: > Thu, Mar 5, 2020 at 2:03 PM Dmitry Gutov wrote: > >> How about 'M-x exit-minibuffer RET'? :-) If it's indeed a rare situation. > > M-x doesn't work within an active minibuffer, does it? Seems to work fine in this situation. Starting with 'emacs -Q', no extra config on my part except 'M-x fido-mode'. > Anyway, it should > be rare among all the possible UIs and situations out there, > but once you hit one, it's likely to hurt you repeatedly. So let's not > be needlessly strict. I don't want to be too strict, but I also don't want users shooting themselves in the foot. Or to feel that I can't rely on REQUIRE-MATCH when calling completing-read in a program. >> I will recuse myself by saying I have no opinion on C-u. > > Then I will take over this investigation ;-) Thank you. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 14:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158341841317994 (code B ref 38992); Thu, 05 Mar 2020 14:27:01 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 14:26:53 +0000 Received: from localhost ([127.0.0.1]:42414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9rSf-0004gA-I9 for submit@debbugs.gnu.org; Thu, 05 Mar 2020 09:26:53 -0500 Received: from mail-io1-f54.google.com ([209.85.166.54]:35535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9rSd-0004fw-ST for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 09:26:52 -0500 Received: by mail-io1-f54.google.com with SMTP id h8so6673169iob.2 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 06:26:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=27DcWBlQRHLDjL1bw/SxohFRlq13ZBBpvdqViwI38m8=; b=Q1G5TKl34+Ks2oxcHOPJn5bOy4+i2vzemf3uS2kPixHQ5z/6l0UhJse6tbcArzxHUN jdXjODLqbbxY0p8gE3VJ2Ux2kisSmZY3nlu7biy+xJ36fkpl8vmcNoCW2uu628tIA1Dd N8h+pTCxYGaNilV05204i792ThVAsi7d6nyjiDzvXkhav4yu7qFTIFv+9xg4kFdzoNDa FLnadYN/gxaIENNYujpLW6iumnDKEfbCPCuGpqhrYW8nQpfxFASq7F9TJidiykfXJSWn mFZqXhqVaTG1WRfiWDPftHmmsk5OoftAI+chpGgiAiv4blcsdgdPHgHklZXwdYOjUJV9 FCVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=27DcWBlQRHLDjL1bw/SxohFRlq13ZBBpvdqViwI38m8=; b=FFwlmESMfx8CQaIfdt5fTqTrhB2drYLQLsdvPxL/9d4ishDZJdMO1ZJtY8RYLlwG+N 42wVZBdx24ihuH/abmk1kb0W/TEYEVhkMQIyKlD9NVrH4zbPXEDSqlwPosqcY31w/d03 8zmfe3Tc3SOP3NfpKbCU7nga4vgD4Rd3k7cJSQpZcyXdU3/ZCq3kHqm5U6QeL235S/rJ RTlK6+NsRoJJzQOBnCmQHdAdHwntam+LNOTQCw0G6B1g5NO+TOtQNH1IvvcbKznoQ5Ig pBlothrFKO0kWbs+kt+Ajz3057WC2CGANbgfHi2SPYK4SdWbGesmUVhEIs6WWTPdAzsb bJ7Q== X-Gm-Message-State: ANhLgQ13vba5xtrcBJy0carvu/Qj+ObYRSCHwdeIU8UrKx5dp6Rh8vhy l8VJkNC1m6cnYeXvc8qeX3mBUa/76aOBjO5wpUM= X-Google-Smtp-Source: ADFU+vuRjsGv97g8iUenbO4m7u/fNjk4FmDkghD17nzEiLwkG6qvoMqzqGw4q56owU3lWrG3HeSPzy9c6OIWEG6F034= X-Received: by 2002:a5e:a903:: with SMTP id c3mr6370301iod.125.1583418406266; Thu, 05 Mar 2020 06:26:46 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> <2c5f6c44-7ca3-f1c9-d18d-3bf0d65548b9@yandex.ru> <62da5d4c-2db8-864e-0d08-ed751ff82c0b@yandex.ru> <658de140-d00b-2a4f-baa5-f261a135410e@yandex.ru> In-Reply-To: <658de140-d00b-2a4f-baa5-f261a135410e@yandex.ru> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 5 Mar 2020 14:26:34 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) On Thu, Mar 5, 2020 at 2:17 PM Dmitry Gutov wrote: > Seems to work fine in this situation. Starting with 'emacs -Q', no extra > config on my part except 'M-x fido-mode'. This must have changed recently because I emacs -Q M-x fido-mode C-x C-f M-x ---> error message On GNU Emacs 27.0.60 (build 2, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2020-02-01 > Or to feel that I can't rely on REQUIRE-MATCH when calling > completing-read in a program. Well, a sufficient level of paranoia will always give you that feeling :-) , given that you yourself reported that that M-x thing works. My advice is: move along, it's OK, Emacs's users aren't (all) doofuses. :-) And thanks for the patches. I expect to be using much more RET now (which is a good thing), fallback to M-j if it doesn't work and fallback to C-u M-j if I'm reaaally in a tight spot. --=20 Jo=C3=A3o T=C3=A1vora From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158341927419374 (code B ref 38992); Thu, 05 Mar 2020 14:42:02 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 14:41:14 +0000 Received: from localhost ([127.0.0.1]:42431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9rgY-00052P-Kz for submit@debbugs.gnu.org; Thu, 05 Mar 2020 09:41:14 -0500 Received: from mail-il1-f175.google.com ([209.85.166.175]:46532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9rgX-00052D-UF for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 09:41:14 -0500 Received: by mail-il1-f175.google.com with SMTP id e8so5191506ilc.13 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 06:41:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=QUqxCH8wpO5zfMlWdi2au4YB9DPbppj3oHtxaoZFYAY=; b=P6uBkZtkAIFo/TKfVjJ1kO12NMHfjsq6Y2jexKT6tqXmFIlas95IpJGdYxPoVjqsw4 L7Tz/HKYhDXi3Wi+Ehpy3NvVV7B8pONe0/+H2SyJIoVM+35tRpGcoUZVHMjr+4l7VceQ zuh6suiX5gsIMhcIIZE8fjP2upBfhNspg7qk+oaBGgGd0QZ2XLgJMv2Z2WPIuh/AWfTK 3mCHoJXQlAnqiWi7MGZf74HuYmOygfm+ZA7IJQ1LR1kxwgm2XSf1EVq6iaJQKQeG4e6C znT5G5BCrmOI+Iz/Hr3ty6q47eIgTfGIXtbp0WYUdhUarCxLWbcjHRPTvmoC/KvBdsKz TohA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=QUqxCH8wpO5zfMlWdi2au4YB9DPbppj3oHtxaoZFYAY=; b=jcvoNfeKbvfcyo6S0ugGYReUP2BycUlWhDjVWiHBGegFAmGLIO+VKNskgR+W5aN49A PdPHmJKzAPC5GtiW2OfKAV6sqAOPlAK3nrbhL8vq4mvTbsJnkRa7pRlngIxsIsM740dc OAUX0XpAEKLSSJAH+NXjdBBMYf9YjzIjJK3w5aMtbc1PgAFCl0mzCiksGgs0b1wIylMu 76WABdcGF5UR8lQKpxuR21SWS2VK0zGzAuwtj1yP5aRfDFNNP6ikxmeobV0Qb4DnpmUn XsiUdlb6Ghz4nJFd1oChIdWLlRQBjv8sxKnngE4d6yev0rKL7vXkf6JkcaoWcUYQ/a9j OegA== X-Gm-Message-State: ANhLgQ26J9PiNbSWO/2ZVXWAXLR5B/27W/lohecf8f6S8SoTQKsxdbtW EBmcigC3n6VX5atpBMvPlLthDof5dcMykl1e7l0= X-Google-Smtp-Source: ADFU+vstQ4K66uZkG7qymB1RkcC0KaNPqGL5aqiC1smaJ570696tj4JiE1D7AyoktC8xEfzt4USaTTusShwbpZFjZpA= X-Received: by 2002:a92:d685:: with SMTP id p5mr8613142iln.9.1583419268198; Thu, 05 Mar 2020 06:41:08 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> <2c5f6c44-7ca3-f1c9-d18d-3bf0d65548b9@yandex.ru> <62da5d4c-2db8-864e-0d08-ed751ff82c0b@yandex.ru> <658de140-d00b-2a4f-baa5-f261a135410e@yandex.ru> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 5 Mar 2020 14:40:56 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) > [...apropos M-x inside completing minibuffers...] > This must have changed recently because I > > emacs -Q > M-x fido-mode > C-x C-f > M-x ---> error message > > On GNU Emacs 27.0.60 (build 2, x86_64-pc-linux-gnu, X toolkit, Xaw3d > scroll bars) of 2020-02-01 And now I tried in a fresh build of emacs-27 and same behaviour. I think it's sane behaviour, by the way. Jo=C3=A3o From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 14:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158342004720574 (code B ref 38992); Thu, 05 Mar 2020 14:55:01 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 14:54:07 +0000 Received: from localhost ([127.0.0.1]:42441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9rt1-0005Lm-2H for submit@debbugs.gnu.org; Thu, 05 Mar 2020 09:54:07 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:44054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9rsz-0005LI-M5 for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 09:54:06 -0500 Received: by mail-wr1-f68.google.com with SMTP id n7so7353903wrt.11 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 06:54:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ify5kvQRNINk0gVKBymwk4C1mBZQgvzxDf+g7nqkqFE=; b=qEg1APCDNMXi2BIwC2hgFiPjJPC9XrdQqveY47kPes6z9ybiYxJS83hV9orUQPpn5f yb9BY1l63e+rM7a9f2Fo7SfWS6k2ch7odpZnkxl9Oy0ef//84sjKULnWyJT8zfQixKtO CgF4sEYH3WtXltxbaop27GqAgipHZgmNQ9yweVimld5U62VTY50vAKenYAr4tJ/ByKGK lDIIadwWUNXYPmPMB511Rvc2Kpq01a2Cu3T2vrNq5KGpWx3sOwVCRZxfEVSIF3jLtRco lPe0PxjtwWod1sTP+abyCdpSJSnVTMRwbmbv9aCbcN71gwlkyNdVZu7RfA8DVIfbDl7A 0NAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ify5kvQRNINk0gVKBymwk4C1mBZQgvzxDf+g7nqkqFE=; b=sungsIbOA60TypBfGJzupm3lcFxD61lUbWKs9u22jjv8INhea5Fkrs8tPnmPWnSzay ERU9mapGobb6fFamXXLZiUyy8YqBdfesvm1GzTSBu4TRQeOZkJ7iGnTMQFzVHtQoMAUq PCk7fclCWHtcWpXJPp2/gUUsoc6ZuJhHbLkNBfSzBVl+ReszcnLQLGDgUEYV5pm3LbWO HyW20pAc1nZV3Z5/B3/NZr+CK/VizjKeuZhxevnbpK6nlirBF8Ow7DC59o9CW3c5N7Tn BMDMiKhHHD0SgDBRkGT7iUFLgtcjFufkpgrlq3GvBy+SiipxCiGsOu98UDytqiLcC54+ tBiw== X-Gm-Message-State: ANhLgQ2wetqT5AkT0JXNkUhUjEgj0ZStZ3mof2gtUhRr6k12xCPbsV5a PpCjmFp/obdNgjKE27M2MGocAM6V X-Google-Smtp-Source: ADFU+vuteUQ9ierZJmPuHz7gfybL7VnD8zoO6XhpFRIoC+jycHdJ4BkL6dPES0cQkjQSaqPpL7KxTw== X-Received: by 2002:a5d:69cb:: with SMTP id s11mr10193971wrw.47.1583420039472; Thu, 05 Mar 2020 06:53:59 -0800 (PST) Received: from [192.168.0.155] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id c14sm31010299wro.36.2020.03.05.06.53.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2020 06:53:58 -0800 (PST) References: <288610218.111246.1578330546916@office.mailbox.org> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> <2c5f6c44-7ca3-f1c9-d18d-3bf0d65548b9@yandex.ru> <62da5d4c-2db8-864e-0d08-ed751ff82c0b@yandex.ru> <658de140-d00b-2a4f-baa5-f261a135410e@yandex.ru> From: Dmitry Gutov Message-ID: Date: Thu, 5 Mar 2020 16:53:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) On 05.03.2020 16:26, João Távora wrote: > On Thu, Mar 5, 2020 at 2:17 PM Dmitry Gutov wrote: >> Seems to work fine in this situation. Starting with 'emacs -Q', no extra >> config on my part except 'M-x fido-mode'. > > This must have changed recently because I > > emacs -Q > M-x fido-mode > C-x C-f > M-x ---> error message It's... weird. M-x doesn't work inside 'C-x C-f', but it does work inside 'C-h f', for example. That seems like a bug, one way or another. > On GNU Emacs 27.0.60 (build 2, x86_64-pc-linux-gnu, X toolkit, Xaw3d > scroll bars) of 2020-02-01 > >> Or to feel that I can't rely on REQUIRE-MATCH when calling >> completing-read in a program. > > Well, a sufficient level of paranoia will always give you that > feeling :-) , given that you yourself reported that that M-x thing > works. My advice is: move along, it's OK, Emacs's users aren't > (all) doofuses. :-) Emacs allows us to redefine basically everything. But there's a meaningful difference between forcing the user to call a magic command to enter the "dragon land", and having that command by default in the keymap. > And thanks for the patches. I expect to be using much more > RET now (which is a good thing), fallback to M-j if it doesn't work > and fallback to C-u M-j if I'm reaaally in a tight spot. Cheers! From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 15:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158342034121999 (code B ref 38992); Thu, 05 Mar 2020 15:00:01 +0000 Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 14:59:01 +0000 Received: from localhost ([127.0.0.1]:43507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9rxl-0005ig-LU for submit@debbugs.gnu.org; Thu, 05 Mar 2020 09:59:01 -0500 Received: from mail-il1-f172.google.com ([209.85.166.172]:46884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9rxj-0005iF-LU for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 09:58:59 -0500 Received: by mail-il1-f172.google.com with SMTP id e8so5246508ilc.13 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 06:58:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2OJYSqvLriOtZVTyqoIYI5C+BHzTIWAM3KBj/f/iNt4=; b=VPn5xuQSdlIpXpj6h3dipo60Fl+C78I6R/RE6L6arseoBbe8WK9ESlQ5lUkrfRCf/c SIB2wmfDmrcRWq+/85BPK/4/MuDZbEsBFpparXojZBb3RHa/wkSQ5so9diM6iE+aCV4F 58vhVyWmeofu1dEm7PRzeaLdyX/aPXP8LhomNJkymTOW/Jw+dRWwxY72hpsI4NA6neyg RPhEpORQsIeWyW2YEYmgx42CMJGsEv3zlIX8fMsqGrudFPIs6UTHYUQYILyOtAkRosKk FHICcZtGWbRf2qEDiUCW6fapSzb5dwgsA7gJfBFRAnIeSt6ooc7B0QbopnKyVlmD7Z9/ fLdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2OJYSqvLriOtZVTyqoIYI5C+BHzTIWAM3KBj/f/iNt4=; b=KC+N1iVjXfzNy4fuasGxFKffDperjJikghqxH1bUGLbEkWYPg7b5SxeuAkftL+gYdx 2VLTrvpp1OWuLZGERqF1QZDK/aiF+f7Q1u+AFA9rEME2gFfk5/V27tOKzQEfvKVbPBV4 GpgltiPT0L7QmWuFwuwKQhqunRCrltA8rkCZXm4FZ7TIaUs3T8CZ8tV10FdisyButalL 1+cXqUc1YDKST2Pt8cKT8u6GX4of4PHBzTSRDnM5Jn2U7RSZGA1nC2QPm5IbupvZz8si kzKAj90PgigTDzNHplOfPE6xcUNt5/bKItipr45GghI0MCjnVG4kYUhXbQ/Wicbf8t+E 8l0A== X-Gm-Message-State: ANhLgQ0extRjuCcBb5KE81Peal/HjcOmdHcqktMbcR0VHr/iovsjzrJj abTjsAwi0I1HqfLJ5/SyfrDhB4dK6+Nf+cehUug= X-Google-Smtp-Source: ADFU+vsn0ijjWpyzSeiaggWkgH2qjQ4G0Q2I1q9cEgWB1O8rg4L6YVyzN4l7nHoaz/7aXkO13LYT+vAmR8m6C/RmL9E= X-Received: by 2002:a92:884e:: with SMTP id h75mr8445872ild.199.1583420333979; Thu, 05 Mar 2020 06:58:53 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> <2c5f6c44-7ca3-f1c9-d18d-3bf0d65548b9@yandex.ru> <62da5d4c-2db8-864e-0d08-ed751ff82c0b@yandex.ru> <658de140-d00b-2a4f-baa5-f261a135410e@yandex.ru> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 5 Mar 2020 14:58:41 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) On Thu, Mar 5, 2020 at 2:53 PM Dmitry Gutov wrote: > Emacs allows us to redefine basically everything. But there's a > meaningful difference between forcing the user to call a magic command > to enter the "dragon land", and having that command by default in the > keymap. I guess my experience is that we were never in Kansas, anyway, toto ;-) --=20 Jo=C3=A3o T=C3=A1vora From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Mar 2020 14:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , 38992-done@debbugs.gnu.org Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io, Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158359024314471 (code B ref 38992); Sat, 07 Mar 2020 14:11:02 +0000 Received: (at 38992) by debbugs.gnu.org; 7 Mar 2020 14:10:43 +0000 Received: from localhost ([127.0.0.1]:46445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAaA6-0003lG-Fs for submit@debbugs.gnu.org; Sat, 07 Mar 2020 09:10:42 -0500 Received: from mail-il1-f180.google.com ([209.85.166.180]:35421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAaA4-0003kx-38; Sat, 07 Mar 2020 09:10:40 -0500 Received: by mail-il1-f180.google.com with SMTP id g126so4708673ilh.2; Sat, 07 Mar 2020 06:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7E5biPJ1mtf8VZJqqTcfJGuqmUNH11eMOMU/LQfsR2o=; b=bjh6ZN4nBhYfZNEzKdwtZF86UeTqoPtV9S5QxCNO4t5fYDxmg7/ZSyBovkaWfh9iMd 02ru27/URdutAqiDCdJm/Kc3uPziBrJ/sU9jlJiL+bwBmUTA5fN8maP7K0QlQ1X0F0VM E9A3EjPa7NODt85puhawOhXdBPLUMNYWptAzF3/R182zUhxJF8vBBUeX/IPzYgCNl3dB D77171XWwqbGlJ+w4LVsF5UWYduPxIsRR2CoxvXWe+rJvWn+LY+LBBmHskHVL6hvz0d+ AtG4fz1JECroh7kRuPXXUnDjYhoaNczHfnAf/p8RlBTTjibN03tGi6VH4A7zK6QNIZph 428A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7E5biPJ1mtf8VZJqqTcfJGuqmUNH11eMOMU/LQfsR2o=; b=e3cw5Fr1FHWG7h/GFNPWCGVnDNele3F4+drcs0sDzw7dPGw5XrLieTford15fJM//I WXyesuE3D5YJuz6QrmbcvfexgS4f69Pn3CfH5ZeF+au59e1+nD7EZYDTpxRQ8x3vxuPD 1+Aj2vPbYv1eFAQkvsdTdm7VF2Q2cHXVggLfQHiPHgyumDH8XHCjbSn9RmwrFYzXaWzv ekS2BNdHCuCJX1kGuF5Z333hdm6gG4aSJrVk48nFUh/0urFF3WzFGWy8VRLNnebjH2nV uuSiKo3p+3lNNwY9tE0BjKf4n4wK0G7isPEchmgLlPbMFRyd/jacjbJ39cJEk9Zotonc qa4g== X-Gm-Message-State: ANhLgQ0gnQVgnCWa2SVCfg7xD8cXJE8IKWhs9lC0M4xQTPdjTIxtw4WW 3oifZwvanenB5t/Y5RL+g5WUPcA/doMEv3bY99I= X-Google-Smtp-Source: ADFU+vs83kl9nm2BW2j4DXTOzVKY75puW8UlpKLZ7Wscbst8jK3c1dUflaC7O0axhuLFZjc8sdBqHd/jQDmWmCqMFWo= X-Received: by 2002:a92:8f91:: with SMTP id r17mr7083310ilk.97.1583590234295; Sat, 07 Mar 2020 06:10:34 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <834kv3wcyd.fsf@gnu.org> In-Reply-To: <834kv3wcyd.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sat, 7 Mar 2020 14:10:22 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) After a few days of successful testing, I've taken the liberty of pushing Dmitry's fixes to emacs-27. Dmitry's fix is fully backward-compatible (doesn't remove any variables or change their meanings), and merely fixes a pre-existing bug in lisp/minibuffer.el by introducing a new internal, user-invisible variable, which we can later remove/rework in master. I'm also marking this bug done (not sure if it wasn't already), Jo=C3=A3o On Thu, Mar 5, 2020 at 6:09 AM Eli Zaretskii wrote: > > > Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, monnier@iro.umontreal.= ca, > > waah@yellowfrog.io > > From: Dmitry Gutov > > Date: Thu, 5 Mar 2020 02:15:21 +0200 > > > > > diff --git a/lisp/icomplete.el b/lisp/icomplete.el > > > index a1a67e2330..52429fdf37 100644 > > > --- a/lisp/icomplete.el > > > +++ b/lisp/icomplete.el > > > @@ -541,7 +541,7 @@ icomplete-exhibit > > > (icomplete--completion-table) > > > (icomplete--completion-predicate) > > > (if (window-minibuffer-p) > > > - (not minibuffer-completion-confirm)= )))) > > > + (eq minibuffer-completion-confirm t= ))))) > > > (buffer-undo-list t) > > > deactivate-mark) > > > ;; Do nothing if while-no-input was aborted. > > > > The above is a simple bugfix of "why the hell not" variety: I don't > > think that code worked well before that patch, i.e. it treated the > > values of nil and t of REQUIRE-MATCH the same. Good thing that only > > affected the choice of parens to print in the minibuffer. > > > > > IOW, some code which just assumes that anything non-nil and > > > non-confirm must be confirm-after-completion, or the other way > > > around. It's an incompatible change. > > > > I'm not arguing that is isn't. But looking at the actual uses out there= , > > the chief popular alternatives to completing-read-default don't seem to > > be affected. And this variable is bound inside completing-read-default, > > so only particular kind of code could really use it. Breakage is > > possible, of course, but I'm fairly sure the affected audience would be > > minimal. > > > > Anyway, see the alternative patches in the branch 'fido-mode-fix' I jus= t > > pushed. > > > > > Is the problem this attempts to fix really serious? Or is it just a > > > minor inconvenience? It isn't the original one that started the bug > > > report, right? > > > > The patches fix both an inconvenience (one that started this bug report= , > > I'd say it is serious enough to make users stumped) and a bug. See my > > previous message in this bug report for details. > > Thanks for the explanations. > > Stefan, any thoughts on whether this is safe for emacs-27? --=20 Jo=C3=A3o T=C3=A1vora From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Mar 2020 14:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992-done@debbugs.gnu.org, 38992@debbugs.gnu.org, monnier@iro.umontreal.ca, waah@yellowfrog.io, dgutov@yandex.ru Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158359242317640 (code B ref 38992); Sat, 07 Mar 2020 14:48:01 +0000 Received: (at 38992) by debbugs.gnu.org; 7 Mar 2020 14:47:03 +0000 Received: from localhost ([127.0.0.1]:46452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAajH-0004aR-J5 for submit@debbugs.gnu.org; Sat, 07 Mar 2020 09:47:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAajF-0004Zu-Pw; Sat, 07 Mar 2020 09:47:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jAaj9-0004Bq-OZ; Sat, 07 Mar 2020 09:46:55 -0500 Received: from [176.228.60.248] (port=4406 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jAaj9-00017M-3Y; Sat, 07 Mar 2020 09:46:55 -0500 Date: Sat, 07 Mar 2020 16:46:53 +0200 Message-Id: <83imjg9q8y.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Sat, 7 Mar 2020 14:10:22 +0000) References: <288610218.111246.1578330546916@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <834kv3wcyd.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: João Távora > Date: Sat, 7 Mar 2020 14:10:22 +0000 > Cc: Dmitry Gutov , Stefan Monnier , 38992@debbugs.gnu.org, > waah@yellowfrog.io > > After a few days of successful testing, I've taken the liberty of pushing > Dmitry's fixes to emacs-27. Disregarding the fact that I wasn't sure this is OK for emacs-27, and asked Stefan for his opinion? Why?? From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Mar 2020 16:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38992-done@debbugs.gnu.org, 38992@debbugs.gnu.org, monnier@iro.umontreal.ca, waah@yellowfrog.io, Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15835993414409 (code B ref 38992); Sat, 07 Mar 2020 16:43:02 +0000 Received: (at 38992) by debbugs.gnu.org; 7 Mar 2020 16:42:21 +0000 Received: from localhost ([127.0.0.1]:47456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAcWr-00018x-GV for submit@debbugs.gnu.org; Sat, 07 Mar 2020 11:42:21 -0500 Received: from mail-il1-f169.google.com ([209.85.166.169]:42919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAcWo-00018e-2C; Sat, 07 Mar 2020 11:42:18 -0500 Received: by mail-il1-f169.google.com with SMTP id x2so4906938ila.9; Sat, 07 Mar 2020 08:42:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tpUDC5ZQ7BmwE5Unvhr95WF2gvdMKXFZRWY844gFb4Y=; b=Hqp9yXJqluKI/CKi4FrARG2dzUq+c5nYJ2mRhiPZ1XffnFp/ZKk1zjiXhmp9Iqn3M9 XcEPjus6MPB5K1BuziWpBviOqfuq2qSbYY8YEPksILnkpnobDHoN/3+QEXnYIaq84HsN iQ0wUgOtMrI7atc20+y96S0dWw47ZwzPVQICIXIjvCgV4IYtmpd0iwtKHkma0lYBKkpU jlzAmRnxourNmBAC84UzGIR6e7oddnVJFYmgWgCZ4eZG6usZmvTvyjUYcKwXUmGxttDm Dqmx1K6VCvS4nTjI6vCNwfxKGbU6V7BnjEqCdQw8c11QFtSm8MU3GMgXsSZ5OX1DgGV5 6TKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tpUDC5ZQ7BmwE5Unvhr95WF2gvdMKXFZRWY844gFb4Y=; b=ssQi5YPyKjgjOnwy7GyE/oHrWC18gGUDi6B4nFaKVkibgdRCK14DioN1QxSTUzf6lD ayLOGdJa0io/OvrKXx43CzftZxS2PbE6lsJJztYagPYt9mGuf14UtjOmRe+ZCTfMMVFd 3HH5ZFzYYVmB+/NtYUeMtVi/Jq9oFm+RnB95OS6dA4SXXNrLaXsOLaMOm7TVjGTqlO5m oYFluu9PQ+tOkh58/it31VhR/xa+oHXdHZrViy/UQN+ZIZrVvfejG7ETe2sDII3pdkaa pI8OYDBMP9LV0Jdmj/WcJrZVBu15dlpsX8ca3Urj1gImLXKaFy2X14tdCWLG9SAN9PGt gTLw== X-Gm-Message-State: ANhLgQ2wx+3dMdprPSaQXzTW6FruEsHZBfDCGtAhvtJxqijpfQNL3Mz1 NfwqG/l3VdQh9pMxmRPF27geZs48JPsWlbBxDPQ= X-Google-Smtp-Source: ADFU+vtV4BeoE8hPhXmALxq2M+aYsAqyYX72c8DO8iErX2IprXo7y+SPQasOyjzt1i+FTFJTrEjCILbfJss36TOwjP8= X-Received: by 2002:a92:8f91:: with SMTP id r17mr7558945ilk.97.1583599332398; Sat, 07 Mar 2020 08:42:12 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <834kv3wcyd.fsf@gnu.org> <83imjg9q8y.fsf@gnu.org> In-Reply-To: <83imjg9q8y.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sat, 7 Mar 2020 16:42:00 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000ac9c8b05a04673a6" X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) --000000000000ac9c8b05a04673a6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Mar 7, 2020, 14:46 Eli Zaretskii wrote: > From: Jo=C3=A3o T=C3=A1vora > Date: Sat, 7 Mar 2020 14:10:22 +0000 > Cc: Dmitry Gutov , Stefan Monnier < monnier@iro.umontreal.ca>, 38992@debbugs.gnu.org, > waah@yellowfrog.io > > After a few days of successful testing, I've taken the liberty of pushing > Dmitry's fixes to emacs-27. Disregarding the fact that I wasn't sure this is OK for emacs-27, and asked Stefan for his opinion? Why?? Because: - I was and am 99% positive that Stefan will agree with me - both the thread and Dmitry's patch evolved in a way that took the safety of such a push in consideration. - I had no other good window to do so in the near future. Also, I didn't "disregard" it, the proof is that I gave a heads up here. I merely took a liberty and understand if you consider that abusive. Anyway, if you believe these reasons to be insufficient, you can revert the commits. I don't think there will be any conflicts to that. Jo=C3=A3o --000000000000ac9c8b05a04673a6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat,= Mar 7, 2020, 14:46 Eli Zaretskii <eliz@= gnu.org> wrote:
> From: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com>
> Date: Sat, 7 Mar 2020 14:10:= 22 +0000
> Cc: Dmitry Gutov <d= gutov@yandex.ru>, Stefan Monnier <monnier@iro.umontreal.ca>,=C2=A038992@debbugs.gnu.org,=C2=A0
>=C2=A0 =C2=A0 =C2= =A0 =C2=A0waah@yellowfrog.io
&= gt;=C2=A0
> After a few days of successful testing, I've taken th= e liberty of pushing
> Dmitry's fixes to emacs-27.

Disrega= rding the fact that I wasn't sure this is OK for emacs-27, and
asked= Stefan for his opinion?=C2=A0 Why??

Because:

- I was and am 99% positive that Stefan will agree with me
- both the thread and Dmitry's patch evolved in a way that = took the safety of such a push in consideration.=C2=A0
- I had no other good window to do so in the near future.

Also, I didn't "disregard&qu= ot; it, the proof is that I gave a heads up here. I merely took a liberty a= nd understand if you consider that abusive.

Anyway, if you believe these reasons to be insufficient= , you can revert the commits. I don't think there will be any conflicts= to that.

Jo=C3=A3o
--000000000000ac9c8b05a04673a6-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Mar 2020 16:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Eli Zaretskii Cc: 38992-done@debbugs.gnu.org, monnier@iro.umontreal.ca, waah@yellowfrog.io, Dmitry Gutov Received: via spool by 38992-done@debbugs.gnu.org id=D38992.15835996484897 (code D ref 38992); Sat, 07 Mar 2020 16:48:02 +0000 Received: (at 38992-done) by debbugs.gnu.org; 7 Mar 2020 16:47:28 +0000 Received: from localhost ([127.0.0.1]:47465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAcbo-0001Gv-8O for submit@debbugs.gnu.org; Sat, 07 Mar 2020 11:47:28 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:58464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAcbl-0001Gi-Hf for 38992-done@debbugs.gnu.org; Sat, 07 Mar 2020 11:47:26 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 027GipvW072452; Sat, 7 Mar 2020 16:47:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=/wqUWhL4TMjgxkYgLCH7ri3vBJedIFoYlYZeFuRQmFY=; b=WIgDq3Y2yaPQX0k/j2fgbUnrZTem2IOThrqEj3i9kPnvJxTz2PwYBRWDScE1/YEXavc8 phqiATW/dc9jTLlv/wro6P38amdFC3KCd66j7kEX3UPB6TafawNB/dCSgy3zaHNJz3NN V64HQuNKpy558Tov27hAzZOXeCvrIE7wTlJv3IJjKaQEP93Yny+7uJzGxjsF5Sxj00Dv EW9GzYTLannjFyej4TEhc8Oi5+4mCqVAQqOqhqJRjMmxA3EZKTFFY7laV+ZtjeGZuDRV zBMEzW018mTTp5zyohs2m0NuXaSyiZMbH9el0KZEdZvqH0LopUGVyPg5DbrA5ZGkTxtC 4A== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2ym31u1bp0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 07 Mar 2020 16:47:18 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 027Gh41j170777; Sat, 7 Mar 2020 16:47:18 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2ym0qw71w0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 07 Mar 2020 16:47:18 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 027GlBJZ014535; Sat, 7 Mar 2020 16:47:12 GMT MIME-Version: 1.0 Message-ID: <5434e3cc-b81f-4d9e-8fec-7183c8d4aab2@default> Date: Sat, 7 Mar 2020 08:47:11 -0800 (PST) From: Drew Adams References: <288610218.111246.1578330546916@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <834kv3wcyd.fsf@gnu.org> <83imjg9q8y.fsf@gnu.org> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4966.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9553 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 suspectscore=18 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=799 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003070123 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9553 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 suspectscore=18 phishscore=0 mlxlogscore=860 mlxscore=0 malwarescore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003070123 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Please don't send the same message to both 38992@debbugs.gnu.org and 38992-= done@debbugs.gnu.org. Choose one. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Mar 2020 17:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 38992@debbugs.gnu.org, monnier@iro.umontreal.ca, waah@yellowfrog.io, dgutov@yandex.ru Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15836029539836 (code B ref 38992); Sat, 07 Mar 2020 17:43:02 +0000 Received: (at 38992) by debbugs.gnu.org; 7 Mar 2020 17:42:33 +0000 Received: from localhost ([127.0.0.1]:47502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAdT6-0002Ya-W1 for submit@debbugs.gnu.org; Sat, 07 Mar 2020 12:42:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAdT5-0002YG-HN for 38992@debbugs.gnu.org; Sat, 07 Mar 2020 12:42:31 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jAdSz-00069j-Ev; Sat, 07 Mar 2020 12:42:25 -0500 Received: from [176.228.60.248] (port=1255 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jAdSy-0000uN-4o; Sat, 07 Mar 2020 12:42:24 -0500 Date: Sat, 07 Mar 2020 19:42:20 +0200 Message-Id: <837dzw9i4j.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Sat, 7 Mar 2020 16:42:00 +0000) References: <288610218.111246.1578330546916@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <834kv3wcyd.fsf@gnu.org> <83imjg9q8y.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: João Távora > Date: Sat, 7 Mar 2020 16:42:00 +0000 > Cc: 38992-done@debbugs.gnu.org, Dmitry Gutov , monnier@iro.umontreal.ca, > 38992@debbugs.gnu.org, waah@yellowfrog.io > > Disregarding the fact that I wasn't sure this is OK for emacs-27, and > asked Stefan for his opinion? Why?? > > Because: > > - I was and am 99% positive that Stefan will agree with me > - both the thread and Dmitry's patch evolved in a way that took the safety of such a push in consideration. > - I had no other good window to do so in the near future. Please don't do that in the future, we discuss things here because they matter. > Anyway, if you believe these reasons to be insufficient, you can revert the commits. I don't think there will be > any conflicts to that. Let's wait and see what Stefan thinks about this. From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Mar 2020 19:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io, Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158360932327065 (code B ref 38992); Sat, 07 Mar 2020 19:29:01 +0000 Received: (at 38992) by debbugs.gnu.org; 7 Mar 2020 19:28:43 +0000 Received: from localhost ([127.0.0.1]:47583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAf7q-00072T-UA for submit@debbugs.gnu.org; Sat, 07 Mar 2020 14:28:43 -0500 Received: from mail-il1-f169.google.com ([209.85.166.169]:37135) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAf7o-00072F-KJ for 38992@debbugs.gnu.org; Sat, 07 Mar 2020 14:28:41 -0500 Received: by mail-il1-f169.google.com with SMTP id a6so5166335ilc.4 for <38992@debbugs.gnu.org>; Sat, 07 Mar 2020 11:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jWn02BaRqNcTitQQdX0OWC/Z4lAxmCkE9iNCJ79TPFY=; b=HUC8qhflkoYcvRs8+7xnxKQM9eM9JuFRlJ/6fznavvI+yJbBo9KZDm6GFbaHONqKyh 9KS3rpFDuxhwt7vntckwfSMemTbndT4lghsQD+nNQjnqk67mahAWTqUrLWVhVAwS6hGU ByOuHu+pVpwpVPB6AexV0kAgijg12Yatk+hcerO/6bIX7uQkJVvunpKztqmGcOUiyAGg aJJT7MWK92zc6htVRFuwRIedBFKJhHpOj67GlpzRWl0ldTQ5YGBlvIlZ3G7Ty6eyQ/bZ pI1WX6A3CGDKJ9coW9gWgbOxi4kOjLXyNKmcdcoPidTs/hGzxHgaxxnZ9U+bCDDb+G+4 OiqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jWn02BaRqNcTitQQdX0OWC/Z4lAxmCkE9iNCJ79TPFY=; b=Vs5dzOi4R/2oN1LS3spwVo1W+o+PHZ5AkqQSzFPRYde8mR2ygITzj0FXoxjEsvSedO nVAnCJQzooNGf7yWg4VrhCQQiQ0SMQARIWu8TifOd3P+mkq+42qPEU+7BQ1I0Z38F0cv LdttWiGgMPzK6E1gAqJojnpSTMabtdq/oHxdONBRxRa0oyGYt6NptpT+kCl7cBF/hkdL ZsqW15Rp70l3hbqhOYTOZa5gCS7J8zcfz4wmgjQza8MwdmlueO6jVsy82t1vxjp4EQVf R6jB1JpxNz57ZtjfatsHZl9oI9w54lbemCXfhUpPttNbSybL4obaN0X6194QgHvAmgaq m6qA== X-Gm-Message-State: ANhLgQ3XKIMB28RajxikEhMNpwHX0CR0D4U2Jo9OaJWUIre1fRzh10FP l1TIZKNESbJnQeEupfcPJtQ/GfRcFmXHHB68iUw= X-Google-Smtp-Source: ADFU+vtaJHvjuj0U+rKawhObhzG0/np26Jyi2ZIoR+NJ5+dG+CsxBwFc3K7zPg4+x5jq2rFIN5xKinHy5WMBowwCOdM= X-Received: by 2002:a05:6e02:10c6:: with SMTP id s6mr2746111ilj.9.1583609314968; Sat, 07 Mar 2020 11:28:34 -0800 (PST) MIME-Version: 1.0 References: <288610218.111246.1578330546916@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <834kv3wcyd.fsf@gnu.org> <83imjg9q8y.fsf@gnu.org> <837dzw9i4j.fsf@gnu.org> In-Reply-To: <837dzw9i4j.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sat, 7 Mar 2020 19:28:21 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000ae8ae205a048c6a9" X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) --000000000000ae8ae205a048c6a9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ok, sounds good. In the future, I will refrain from doing this. Again, I just did it cause I have very little time on my hands right now, and wanted to solve this simple matter in a rare window of opportunity. In hindsight, I should have placed these commits in a branch ready to merge, but I feared they might be forgotten. Jo=C3=A3o On Sat, Mar 7, 2020, 17:42 Eli Zaretskii wrote: > > From: Jo=C3=A3o T=C3=A1vora > > Date: Sat, 7 Mar 2020 16:42:00 +0000 > > Cc: 38992-done@debbugs.gnu.org, Dmitry Gutov , > monnier@iro.umontreal.ca, > > 38992@debbugs.gnu.org, waah@yellowfrog.io > > > > Disregarding the fact that I wasn't sure this is OK for emacs-27, and > > asked Stefan for his opinion? Why?? > > > > Because: > > > > - I was and am 99% positive that Stefan will agree with me > > - both the thread and Dmitry's patch evolved in a way that took the > safety of such a push in consideration. > > - I had no other good window to do so in the near future. > > Please don't do that in the future, we discuss things here because > they matter. > > > Anyway, if you believe these reasons to be insufficient, you can revert > the commits. I don't think there will be > > any conflicts to that. > > Let's wait and see what Stefan thinks about this. > --000000000000ae8ae205a048c6a9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok, sounds good.=C2=A0

In the future, I will refrain from doing this.
Again, I just did it cause I have very little time on my hands right = now, and wanted to solve this simple matter in a rare window of opportunity= .

In hindsight, I should= have placed these commits in a branch ready to merge, but I feared they mi= ght be forgotten.

Jo=C3= =A3o

On Sat, Mar 7, 2020, 17:42 Eli Zaretskii <eliz@gnu.org> wrote= :
> From: Jo=C3=A3o T=C3=A1vora = <joaotavora@gmail.com>
> Date: Sat, 7 Mar 2020 16:42:00 +0000
> Cc: 38992-done@debbugs.gnu.org, Dmitry Gutov &l= t;dgutov@yandex.ru>, monnier@iro.umontrea= l.ca,
>=C2=A0 =C2=A0 =C2=A0 =C2=A038992@debbugs.gnu.org, waah@yellowfrog.io
>
>=C2=A0 Disregarding the fact that I wasn't sure this is OK for emac= s-27, and
>=C2=A0 asked Stefan for his opinion?=C2=A0 Why??
>
> Because:
>
> - I was and am 99% positive that Stefan will agree with me
> - both the thread and Dmitry's patch evolved in a way that took th= e safety of such a push in consideration.
> - I had no other good window to do so in the near future.

Please don't do that in the future, we discuss things here because
they matter.

> Anyway, if you believe these reasons to be insufficient, you can rever= t the commits. I don't think there will be
> any conflicts to that.

Let's wait and see what Stefan thinks about this.
--000000000000ae8ae205a048c6a9-- From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Mar 2020 16:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158368458827338 (code B ref 38992); Sun, 08 Mar 2020 16:24:01 +0000 Received: (at 38992) by debbugs.gnu.org; 8 Mar 2020 16:23:08 +0000 Received: from localhost ([127.0.0.1]:49196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAyhn-00076s-Se for submit@debbugs.gnu.org; Sun, 08 Mar 2020 12:23:08 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAyhm-000767-C5 for 38992@debbugs.gnu.org; Sun, 08 Mar 2020 12:23:06 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C5A1F100EB3; Sun, 8 Mar 2020 12:23:00 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CB795100E8F; Sun, 8 Mar 2020 12:22:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1583684578; bh=EBCLrxiMV2fw7amQP0gtHBW3/66E/Haa4PxAzpsKc9I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VRFW6lbHmkXKqHfn5eB28jeiG9zBakaaUgB6GuF8ZWqI0L/zBl+kY1qsTNfsqdSDe xICR14eIo+ryoRDP3OV/UDiRlLsmc3zM96djO4cPiRMF2BbyxR/Fgb3SHyK61KVD7C Tk+8eErAgr8l5xluZp7k3FSuoK5eRlvQmGoNpAJWKBYOmkj6/5ZHqrI0cdms4vDBnz 6+AJbXPTUlrA4cj6p0j2yzxJ0TcE5mDUA+T1qgo2rcJxRtQjAuhOgm10+LxwllIT3o aCbn0I+hNcF3spnSnR9A1Vp1rc7GVS0SXqh5aEsj+LAx37JILW+vLaNH//reLrLFdW zsrc/ufAEMSkQ== Received: from pastel (unknown [216.154.50.221]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 87F52120046; Sun, 8 Mar 2020 12:22:58 -0400 (EDT) From: Stefan Monnier Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> Date: Sun, 08 Mar 2020 12:22:47 -0400 In-Reply-To: <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> (Dmitry Gutov's message of "Thu, 5 Mar 2020 11:59:53 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/x-markdown; coding=UTF-8; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Also, I think, for safety, that we still should have in the >> fido-mode-keymap >> sth bound to the "atomic" give-me-whatever-is-in-minibuffer >> command, maybe C-M-j or something like that.=A0 Even if it >> _does_ break the required-match semantics somewhere else, >> it just seems like a good idea. > But why? I can see reasons why it could be useful in odd corner cases. What I can't see is why it would be more useful/necessary in fido-mode than in icomplete-mode or the plain old default mode. Stefan From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Mar 2020 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, waah@yellowfrog.io, Dmitry Gutov Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158368491327823 (code B ref 38992); Sun, 08 Mar 2020 16:29:02 +0000 Received: (at 38992) by debbugs.gnu.org; 8 Mar 2020 16:28:33 +0000 Received: from localhost ([127.0.0.1]:49202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAyn2-0007Eg-HO for submit@debbugs.gnu.org; Sun, 08 Mar 2020 12:28:33 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAyn0-0007ES-JF for 38992@debbugs.gnu.org; Sun, 08 Mar 2020 12:28:30 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 48AB781148; Sun, 8 Mar 2020 12:28:25 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 703CE81133; Sun, 8 Mar 2020 12:28:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1583684903; bh=xLG4OOXn6rOCk66eeJLy8bHTmcMnF1ECpbWOfmOF2FE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Dhv7SKFEZWcht+NNybM2CCht9ntQAQ6QKaXWwtlfeRo/V2tdR6O4gNigzWhRqsWVB OEaw8Sh764AkyJuEMKZSorPi6Hp2ysNsRoDEGNwY8hgE4iOK1Ek9xqggBX/aTxKPrG ckJPFjOhpk5ka2acXxbslyRo3T4Jse+zzLJSRlmppX8fUdIiqIHfGAygbiA+QfBwjQ mgNGVFbV5iD4IRXhwYlEGtqu3c/5Tzg5RZ6Nua2jiTJOcIpS6I/q+LLrFPGAr61aWi Pk+GOY7IDrtzk/TS8ZZmgcYu+RX2yvO85Roe4lzRk+eCCbL98FJ29j6qplw08dhP/u I89SvrW1zFBDw== Received: from pastel (unknown [216.154.50.221]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AABD0120506; Sun, 8 Mar 2020 12:28:22 -0400 (EDT) From: Stefan Monnier Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <834kv3wcyd.fsf@gnu.org> Date: Sun, 08 Mar 2020 12:28:21 -0400 In-Reply-To: <834kv3wcyd.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Mar 2020 08:08:42 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/x-markdown; coding=UTF-8 X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Stefan, any thoughts on whether this is safe for emacs-27? Yes, it seems perfectly harmless (and slightly more correct). Stefan From unknown Sat Jun 21 10:44:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Mar 2020 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, waah@yellowfrog.io, dgutov@yandex.ru Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158368678830724 (code B ref 38992); Sun, 08 Mar 2020 17:00:02 +0000 Received: (at 38992) by debbugs.gnu.org; 8 Mar 2020 16:59:48 +0000 Received: from localhost ([127.0.0.1]:49226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAzHI-0007zU-7u for submit@debbugs.gnu.org; Sun, 08 Mar 2020 12:59:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAzHG-0007zD-QI for 38992@debbugs.gnu.org; Sun, 08 Mar 2020 12:59:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jAzHA-0006RC-KT; Sun, 08 Mar 2020 12:59:40 -0400 Received: from [176.228.60.248] (port=3707 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jAzH9-0004Dk-OC; Sun, 08 Mar 2020 12:59:40 -0400 Date: Sun, 08 Mar 2020 18:59:39 +0200 Message-Id: <83pndmbx50.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Monnier on Sun, 08 Mar 2020 12:28:21 -0400) References: <288610218.111246.1578330546916@office.mailbox.org> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <834kv3wcyd.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Stefan Monnier > Cc: Dmitry Gutov , 38992@debbugs.gnu.org, > joaotavora@gmail.com, waah@yellowfrog.io > Date: Sun, 08 Mar 2020 12:28:21 -0400 > > > Stefan, any thoughts on whether this is safe for emacs-27? > > Yes, it seems perfectly harmless (and slightly more correct). Thanks.