From unknown Thu Jun 19 14:22:14 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3898: 23.1.50; nxml-extend-after-change-region should not return t Reply-To: Lennart Borgman , 3898@debbugs.gnu.org Resent-From: Lennart Borgman Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 21 Jul 2009 18:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 3898 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124820001113662 (code B ref -1); Tue, 21 Jul 2009 18:20:03 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 21 Jul 2009 18:13:31 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.9 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6LIDPIC013651 for ; Tue, 21 Jul 2009 11:13:26 -0700 Received: from mail.gnu.org ([199.232.76.166]:43503 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MTJq8-0005qd-UL for emacs-pretest-bug@gnu.org; Tue, 21 Jul 2009 14:13:25 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MTJq8-0000ev-3U for emacs-pretest-bug@gnu.org; Tue, 21 Jul 2009 14:13:24 -0400 Received: from mail-yx0-f172.google.com ([209.85.210.172]:57949) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MTJq7-0000em-SP for emacs-pretest-bug@gnu.org; Tue, 21 Jul 2009 14:13:23 -0400 Received: by yxe2 with SMTP id 2so5788344yxe.14 for ; Tue, 21 Jul 2009 11:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=2/RyDBSTawp6N54k19+i3bZtz4CIi9WrMpx9MdzzO0o=; b=QULXMEjP3P87Q2SA2iVyBimBRac1rxZM3H+6Mdl5ch/TuLBP6pA/1w9fWskrL5ALqD zSjC5AlVqsjEQ1tGP9N4FXdUjXLnDrZrkhlgp5gi85yyPI4z6QrtkaDG7LQlsSD/rZHY EGzqqBR+tAy0l1jLX28Rao2ith0JLqYLH9s3w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=sJ55gcxIQHghICjEFrdrIueTozNtW3y7v8HGscAGRP+i/KQGpWKLD0qMy2TH1+CfAF kHOhQYYkXXvgSC1A9m0M+oGM8Mx4lq1K53MSVGbRhgUicDE+NJ1hphN7xoPpB9puCNlz lm4OTPE8poOXeNQLWHzljH5y+tbZlDxnxVZ8Q= MIME-Version: 1.0 Received: by 10.101.66.15 with SMTP id t15mr8256145ank.194.1248200003344; Tue, 21 Jul 2009 11:13:23 -0700 (PDT) Date: Tue, 21 Jul 2009 20:13:23 +0200 Message-ID: From: Lennart Borgman To: emacs-pretest-bug@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) When an error occurs in nxml-extend-after-change-region it returns t which makes font-lock-extend-jit-lock-region-after-change to fail since it expects a cons with two numbers or nil. The patch below make the return value nil instead. Index: nxml-mode.el =================================================================== RCS file: /sources/emacs/emacs/lisp/nxml/nxml-mode.el,v retrieving revision 1.18 diff -u -b -r1.18 nxml-mode.el --- nxml-mode.el 5 Jan 2009 03:22:51 -0000 1.18 +++ nxml-mode.el 21 Jul 2009 18:07:03 -0000 @@ -883,7 +883,8 @@ (unless nxml-degraded (setq nxml-last-fontify-end nil) - (nxml-with-degradation-on-error 'nxml-extend-after-change-region + (let ((ret (nxml-with-degradation-on-error + 'nxml-extend-after-change-region (save-excursion (save-restriction (widen) @@ -892,6 +893,7 @@ (nxml-with-unmodifying-text-property-changes (nxml-extend-after-change-region1 start end pre-change-length))))))))) + (when (listp ret) ret)))) (defun nxml-extend-after-change-region1 (start end pre-change-length) (let* ((region (nxml-after-change1 start end pre-change-length)) In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600) of 2009-06-30 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' From unknown Thu Jun 19 14:22:14 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#3898: 23.1.50; nxml-extend-after-change-region should not return t References: In-Reply-To: Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jan 2010 22:25:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 3898 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3898-submit@debbugs.gnu.org id=B3898.126368069918116 (code B ref 3898); Sat, 16 Jan 2010 22:25:02 +0000 Received: (at 3898) by debbugs.gnu.org; 16 Jan 2010 22:24:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWH4k-0004i8-SI for submit@debbugs.gnu.org; Sat, 16 Jan 2010 17:24:59 -0500 Received: from pantheon-po19.its.yale.edu ([130.132.50.75]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWH4j-0004i1-NC for 3898@debbugs.gnu.org; Sat, 16 Jan 2010 17:24:57 -0500 Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po19.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0GMOrtg000914 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 16 Jan 2010 17:24:53 -0500 Received: by furry (Postfix, from userid 1000) id B3B5CC05D; Sat, 16 Jan 2010 15:24:53 -0700 (MST) From: Chong Yidong To: Lennart Borgman Date: Sat, 16 Jan 2010 17:24:53 -0500 Message-ID: <87ljfx662y.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -5.3 (-----) Cc: 3898@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.3 (-----) > When an error occurs in nxml-extend-after-change-region it returns t > which makes font-lock-extend-jit-lock-region-after-change to fail > since it expects a cons with two numbers or nil. > > The patch below make the return value nil instead. Thanks; applied. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 16 17:25:25 2010 Received: (at control) by debbugs.gnu.org; 16 Jan 2010 22:25:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWH5B-0004iq-2S for submit@debbugs.gnu.org; Sat, 16 Jan 2010 17:25:25 -0500 Received: from pantheon-po39.its.yale.edu ([130.132.50.100]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWH4x-0004ic-S1 for control@debbugs.gnu.org; Sat, 16 Jan 2010 17:25:24 -0500 Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po39.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0GMP7RZ003257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sat, 16 Jan 2010 17:25:07 -0500 Received: by furry (Postfix, from userid 1000) id E06CEC05D; Sat, 16 Jan 2010 15:25:07 -0700 (MST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 3898 Date: Sat, 16 Jan 2010 17:25:07 -0500 Message-ID: <87iqb1662k.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) close 3898 thanks