GNU bug report logs - #38934
[PATCH] vc-dwim: die if no one-line summary.

Previous Next

Full log

Message #8 received at 38934 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Karl Berry <karl <at> freefriends.org>
Cc: 38934 <at> debbugs.gnu.org
Subject: Re: [Bug-vc-dwim] bug#38934: [PATCH] vc-dwim: die if no one-line
 summary.
Date: Sat, 4 Jan 2020 21:56:00 -0800

[Message part 1 (text/plain, inline)]

On Sat, Jan 4, 2020 at 6:00 PM Karl Berry <karl <at> freefriends.org> wrote:
> Jim, for your consideration: die if no one-line summary is found and
> --commit is specified, instead of committing unparsable/bogus data.
>
> FWIW, I found it quite painful to recover from the commit when vcd
> couldn't parse my entry and I accidentally committed anyway. -k

Thanks for the suggestion.
I like it enough that I've adjusted the many resultant test failures
to accommodate (see the attached). If no one objects, I'll merge those
test changes into your commit and push everything tomorrow.

[vc-require-summary-tests.diff (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.