GNU bug report logs - #38934
[PATCH] vc-dwim: die if no one-line summary.

Previous Next

Package: vc-dwim;

Reported by: Karl Berry <karl <at> freefriends.org>

Date: Sun, 5 Jan 2020 02:00:02 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 38934 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Karl Berry <karl <at> freefriends.org>
Cc: 38934 <at> debbugs.gnu.org
Subject: Re: [Bug-vc-dwim] bug#38934: [PATCH] vc-dwim: die if no one-line
 summary.
Date: Sun, 5 Jan 2020 10:53:18 -0800
[Message part 1 (text/plain, inline)]
On Sat, Jan 4, 2020 at 9:56 PM Jim Meyering <jim <at> meyering.net> wrote:
>
> On Sat, Jan 4, 2020 at 6:00 PM Karl Berry <karl <at> freefriends.org> wrote:
> > Jim, for your consideration: die if no one-line summary is found and
> > --commit is specified, instead of committing unparsable/bogus data.
> >
> > FWIW, I found it quite painful to recover from the commit when vcd
> > couldn't parse my entry and I accidentally committed anyway. -k
>
> Thanks for the suggestion.
> I like it enough that I've adjusted the many resultant test failures
> to accommodate (see the attached). If no one objects, I'll merge those
> test changes into your commit and push everything tomorrow.

Here's the merged commit I want to push later today.
Also adjusted NEWS.
[vc-require-summary.diff (application/octet-stream, attachment)]

This bug report was last modified 5 years and 138 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.