From unknown Fri Jun 13 10:47:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38928: bad docstrings for image-dired rotate commands Resent-From: Christophe Deleuze Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2020 22:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 38928@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.157817586610312 (code B ref -1); Sat, 04 Jan 2020 22:12:01 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jan 2020 22:11:06 +0000 Received: from localhost ([127.0.0.1]:43472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inrdS-0002gG-CP for submit@debbugs.gnu.org; Sat, 04 Jan 2020 17:11:06 -0500 Received: from lists.gnu.org ([209.51.188.17]:54077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inrdP-0002g5-IH for submit@debbugs.gnu.org; Sat, 04 Jan 2020 17:11:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57217) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inrdO-0002Dr-8a for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2020 17:11:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.5 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HEXHASH_WORD,RCVD_IN_DNSWL_MED,SPOOFED_FREEMAIL autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inrdM-0008T2-UB for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2020 17:11:02 -0500 Received: from mx1.esisar.grenoble-inp.fr ([195.220.36.33]:60278) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1inrdM-0008Da-JD for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2020 17:11:00 -0500 Received: from localhost (localhost [127.0.0.1]) by mx1.esisar.grenoble-inp.fr (Postfix) with ESMTP id 7730DEC0B1E for ; Sat, 4 Jan 2020 23:10:57 +0100 (CET) Received: from mx1.esisar.grenoble-inp.fr ([127.0.0.1]) by localhost (mx1.esisar.grenoble-inp.fr [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id eI0h1r8ARQYx for ; Sat, 4 Jan 2020 23:10:57 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mx1.esisar.grenoble-inp.fr (Postfix) with ESMTP id 2BE04EC0B1F for ; Sat, 4 Jan 2020 23:10:57 +0100 (CET) X-Virus-Scanned: amavisd-new at mx1.esisar.grenoble-inp.fr Received: from mx1.esisar.grenoble-inp.fr ([127.0.0.1]) by localhost (mx1.esisar.grenoble-inp.fr [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ol5QWmoJKCaf for ; Sat, 4 Jan 2020 23:10:57 +0100 (CET) Received: from srv-zimbra.esisar.grenoble-inp.fr (unknown [172.21.100.139]) by mx1.esisar.grenoble-inp.fr (Postfix) with ESMTPS id 12726EC0B1E for ; Sat, 4 Jan 2020 23:10:57 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by srv-zimbra.esisar.grenoble-inp.fr (Postfix) with ESMTP id 045801B41754 for ; Sat, 4 Jan 2020 23:10:57 +0100 (CET) Received: from srv-zimbra.esisar.grenoble-inp.fr ([127.0.0.1]) by localhost (srv-zimbra.esisar.grenoble-inp.fr [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 3-phyWYQNBv0 for ; Sat, 4 Jan 2020 23:10:56 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by srv-zimbra.esisar.grenoble-inp.fr (Postfix) with ESMTP id 923821B41884 for ; Sat, 4 Jan 2020 23:10:56 +0100 (CET) X-Virus-Scanned: amavisd-new at srv-zimbra.esisar.grenoble-inp.fr Received: from srv-zimbra.esisar.grenoble-inp.fr ([127.0.0.1]) by localhost (srv-zimbra.esisar.grenoble-inp.fr [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 03LbYph0FobF for ; Sat, 4 Jan 2020 23:10:56 +0100 (CET) Received: from christophe (unknown [88.120.161.23]) by srv-zimbra.esisar.grenoble-inp.fr (Postfix) with ESMTPSA id 6A5211B41754 for ; Sat, 4 Jan 2020 23:10:56 +0100 (CET) Received: by christophe (Postfix, from userid 1001) id AF1F75AE073; Sat, 4 Jan 2020 23:10:55 +0100 (CET) Received: from LC1333 (localhost [127.0.0.1]) by christophe (Postfix) with ESMTP id A71195AE070 for ; Sat, 4 Jan 2020 23:10:55 +0100 (CET) From: Christophe Deleuze X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 26.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2688.1578175855.1@LC1333> Date: Sat, 04 Jan 2020 23:10:55 +0100 Message-ID: <2689.1578175855@LC1333> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.220.36.33 X-Spam-Score: -0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * bug description The docstrings for commands image-dired-rotate-thumbnail-left and image-dired-rotate-thumbnail-right say that: "The result of the rotation is displayed in the image display area and a confirmation is needed before the original image files is overwritten. This confirmation can be turned off using `image-dired-rotate-original-ask-before-overwrite'." This is not the case, thumbnail rotation is performed immediately (and rightly so, as the thumbnail has been generated by image-dired and does not need such caution). On the contrary, such a display of rotation result and ask of confirmation is performed by commands image-dired-rotate-original-left and image-dired-rotate-original-right that rotate the *original* pictures. But this is not mentionned in their docstrings. * fix description The above mentionned text should be moved from the docstrings of image-dired-rotate-thumbnail-left/right to those of image-dired-rotate-original-left/right. This is a very simple modification, affecting only the docstrings. * changelog Fix docstrings for image-dired rotate commands * patch Here's a patch generated from commit 9bbf17539826a040eda45e88aabd358ed44fabf7 by git format-patch. ------- >From 8f1ccbe6039affb1ee404cb71c6a8646a99fab5b Mon Sep 17 00:00:00 2001 From: Christophe Deleuze Date: Sat, 4 Jan 2020 22:38:53 +0100 Subject: [PATCH] Fix docstrings for image-dired rotate commands --- lisp/image-dired.el | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lisp/image-dired.el b/lisp/image-dired.el index 7774b82d51..768e941490 100644 --- a/lisp/image-dired.el +++ b/lisp/image-dired.el @@ -1980,20 +1980,12 @@ image-dired-rotate-thumbnail (clear-image-cache thumb)))) (defun image-dired-rotate-thumbnail-left () - "Rotate thumbnail left (counter clockwise) 90 degrees. -The result of the rotation is displayed in the image display area -and a confirmation is needed before the original image files is -overwritten. This confirmation can be turned off using -`image-dired-rotate-original-ask-before-overwrite'." + "Rotate thumbnail left (counter clockwise) 90 degrees." (interactive) (image-dired-rotate-thumbnail "270")) (defun image-dired-rotate-thumbnail-right () - "Rotate thumbnail counter right (clockwise) 90 degrees. -The result of the rotation is displayed in the image display area -and a confirmation is needed before the original image files is -overwritten. This confirmation can be turned off using -`image-dired-rotate-original-ask-before-overwrite'." + "Rotate thumbnail counter right (clockwise) 90 degrees." (interactive) (image-dired-rotate-thumbnail "90")) @@ -2035,12 +2027,20 @@ image-dired-rotate-original (image-dired-display-image file)))))) (defun image-dired-rotate-original-left () - "Rotate original image left (counter clockwise) 90 degrees." + "Rotate original image left (counter clockwise) 90 degrees. +The result of the rotation is displayed in the image display area +and a confirmation is needed before the original image files is +overwritten. This confirmation can be turned off using +`image-dired-rotate-original-ask-before-overwrite'." (interactive) (image-dired-rotate-original "270")) (defun image-dired-rotate-original-right () - "Rotate original image right (clockwise) 90 degrees." + "Rotate original image right (clockwise) 90 degrees. +The result of the rotation is displayed in the image display area +and a confirmation is needed before the original image files is +overwritten. This confirmation can be turned off using +`image-dired-rotate-original-ask-before-overwrite'." (interactive) (image-dired-rotate-original "90")) -- 2.20.1 From unknown Fri Jun 13 10:47:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38928: bad docstrings for image-dired rotate commands Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jan 2020 16:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Christophe Deleuze Cc: 38928@debbugs.gnu.org Received: via spool by 38928-submit@debbugs.gnu.org id=B38928.15797091519964 (code B ref 38928); Wed, 22 Jan 2020 16:06:01 +0000 Received: (at 38928) by debbugs.gnu.org; 22 Jan 2020 16:05:51 +0000 Received: from localhost ([127.0.0.1]:51169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuIVr-0002ae-6h for submit@debbugs.gnu.org; Wed, 22 Jan 2020 11:05:51 -0500 Received: from quimby.gnus.org ([95.216.78.240]:34076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuIVp-0002aR-TT for 38928@debbugs.gnu.org; Wed, 22 Jan 2020 11:05:50 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iuIVh-0005f9-Ej; Wed, 22 Jan 2020 17:05:43 +0100 From: Lars Ingebrigtsen References: <2689.1578175855@LC1333> Date: Wed, 22 Jan 2020 17:05:40 +0100 In-Reply-To: <2689.1578175855@LC1333> (Christophe Deleuze's message of "Sat, 04 Jan 2020 23:10:55 +0100") Message-ID: <875zh3tr1n.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Christophe Deleuze writes: > On the contrary, such a display of rotation result and ask of > confirmation is performed by commands image-dired-rotate-original-left > and image-dired-rotate-original-right that rotate the *origin [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Christophe Deleuze writes: > On the contrary, such a display of rotation result and ask of > confirmation is performed by commands image-dired-rotate-original-left > and image-dired-rotate-original-right that rotate the *original* > pictures. But this is not mentionned in their docstrings. Thanks; patch applied to Emacs 27. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 22 11:07:33 2020 Received: (at control) by debbugs.gnu.org; 22 Jan 2020 16:07:33 +0000 Received: from localhost ([127.0.0.1]:51179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuIXU-0002dm-TU for submit@debbugs.gnu.org; Wed, 22 Jan 2020 11:07:33 -0500 Received: from quimby.gnus.org ([95.216.78.240]:34110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuIXT-0002da-67 for control@debbugs.gnu.org; Wed, 22 Jan 2020 11:07:31 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iuIXL-0005g9-Nd for control@debbugs.gnu.org; Wed, 22 Jan 2020 17:07:25 +0100 Date: Wed, 22 Jan 2020 17:07:23 +0100 Message-Id: <87zhefscec.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #38928 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 38928 fixed close 38928 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 38928 fixed close 38928 28.1 quit