Subject: Re: bug#38912: 27.0.60; PDumper meets segmentation fault when evil is loaded

From: [email-masked]
Date: Mon, 06 Jan 2020 19:34:06 -0800

On Jan 6, 2020 6:38 PM, Paul Eggert <[email-masked]> wrote:

On 1/6/20 9:13 AM, Pip Cet wrote:
> we can fix things properly (by fixing
> sxhash to hash byte code objects) on master.

It's not just bytecode objects; it's also markers and some other stuff.
The worst case is window configurations, where there's a nontrivial
function compare_window_configurations that Fequal delegates to.

Does anyone know offhand why we don't simply use eq to compare window
configurations? Might save me some work in patching this in master.

I think changing the equal behavior of these objects would be a compatibility change. Maybe we need a single callback based approach for doing both equality comparison and hashing of composite objects.