GNU bug report logs - #38904
gnu: Add gnome-color-manager.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38904 in the body.
You can then email your comments to 38904 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnu: Add gnome-color-manager.
Date: Fri, 03 Jan 2020 14:12:51 -0500

[Message part 1 (text/plain, inline)]

Hello Guix!

Please find the attached patch to add gnome-color-manager.

Regards,
RG.

[gnome-color-manager.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 38904 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 38904 <at> debbugs.gnu.org
Subject: Re: [bug#38904] gnu: Add gnome-color-manager.
Date: Sun, 5 Jan 2020 11:19:29 +0100

[Message part 1 (text/plain, inline)]

Hi RG,

>+    `(#:tests? #f)) ;;gcm-self-test fails due to no active display server

Trailing comments should have only one semicolon.

But better yet, since Guix packages build in a container, just start a display
server yourself.

For examples, search for "Xvfb" in the Guix source code.

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 38904 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 38904 <at> debbugs.gnu.org
Subject: Re: [bug#38904] gnu: Add gnome-color-manager.
Date: Mon, 06 Jan 2020 00:53:56 -0500

[Message part 1 (text/plain, inline)]

Hello Danny!

> Trailing comments should have only one semicolon.
> 
> But better yet, since Guix packages build in a container, just start
> a display
> server yourself.
> 
> For examples, search for "Xvfb" in the Guix source code.

Thanks for the tip. Please find the revised patch attached with this
email.

Regards,
RG.

[gnome-color-manager.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 38904 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 38904 <at> debbugs.gnu.org
Subject: v3
Date: Wed, 08 Jan 2020 09:50:44 -0500

[Message part 1 (text/plain, inline)]

v3

[gnome-color-manager.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 38904 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 38904 <at> debbugs.gnu.org
Subject: Re: [bug#38904] gnu: Add gnome-color-manager.
Date: Thu, 9 Jan 2020 16:03:13 +0100

[Message part 1 (text/plain, inline)]

Hi Raghav,

Some questions:

* Why is adwaita-icon-theme an input?

Some comments:

* xorg-server-for-tests should definitely be a native-input if it is used.
* desktop-file-utils should definitely be a native-input if it is used.
* itstool should definitely be a native-input if it is used.

[Message part 2 (application/pgp-signature, inline)]

Message #20 received at 38904 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 38904 <at> debbugs.gnu.org
Subject: Re: [bug#38904] gnu: Add gnome-color-manager.
Date: Thu, 09 Jan 2020 10:26:31 -0500

[Message part 1 (text/plain, inline)]

Hi Danny!

> Some questions:
> 
> * Why is adwaita-icon-theme an input?

I believe this application retrives some information about graphical
properties of a-i-t from a-i-t package.

> Some comments:
> 
> * xorg-server-for-tests should definitely be a native-input if it is
> used.
> * desktop-file-utils should definitely be a native-input if it is
> used.
> * itstool should definitely be a native-input if it is used.

Yes, even I believe so. Would it be okay if I leave things as it is for
now? Because soon I will revising+testing all gnome packages one-by-
one, so I will be moving any unnessessary inputs to native-inputs. :-)

Regards,
RG.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 38904-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 38904-done <at> debbugs.gnu.org
Subject: Re: [bug#38904] gnu: Add gnome-color-manager.
Date: Thu, 9 Jan 2020 18:02:36 +0100

[Message part 1 (text/plain, inline)]

Hi Raghav,

On Thu, 09 Jan 2020 10:26:31 -0500
Raghav Gururajan <raghavgururajan <at> disroot.org> wrote:

> I believe this application retrives some information about graphical
> properties of a-i-t from a-i-t package.

To find out, I've removed it from the inputs and it built just fine and
gcm-viewer also started up fine.  What was the reason that you added it?

> Would it be okay if I leave things as it is for now?

You are free to leave it as is on your computer.  When merging it to
guix master there have to be some standards--otherwise master would be
perpetually broken.

In this specific case, some other packages in (gnu packages gnome) also have
adwaita-icon-theme as input.  Even when there is that input that is unused it
will not cause problems (however, it will also not do what you wanted
it to do--whatever that is).  Also, nothing depends on gnome-color-manager.
Therefore, applied to guix master as commit
29ae18db0578bbdbc0119703f7412fe91927e80e.

But really, having one specific theme (which is by definition a user-selectable
thing) as an input is weird.  Let's fix that everywhere eventually.

[Message part 2 (application/pgp-signature, inline)]

Message #28 received at 38904-done <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 38904-done <at> debbugs.gnu.org
Subject: Re: [bug#38904] gnu: Add gnome-color-manager.
Date: Thu, 09 Jan 2020 12:31:40 -0500

[Message part 1 (text/plain, inline)]

Hi Danny!

> To find out, I've removed it from the inputs and it built just fine
> and
> gcm-viewer also started up fine.  What was the reason that you added
> it?

The upstream mentioned it as a required dependency. Please view 
https://gitlab.gnome.org/GNOME/gnome-build-meta/blob/master/elements/core/gnome-color-manager.bst
.

> > Would it be okay if I leave things as it is for now?
> 
> You are free to leave it as is on your computer.  When merging it to
> guix master there have to be some standards--otherwise master would
> be
> perpetually broken.

I understand :-)

> In this specific case, some other packages in (gnu packages gnome)
> also have
> adwaita-icon-theme as input.  Even when there is that input that is
> unused it
> will not cause problems (however, it will also not do what you wanted
> it to do--whatever that is).  Also, nothing depends on gnome-color-
> manager.
> Therefore, applied to guix master as commit
> 29ae18db0578bbdbc0119703f7412fe91927e80e.

Thank you!

> But really, having one specific theme (which is by definition a user-
> selectable
> thing) as an input is weird.  Let's fix that everywhere eventually.

IIRC, gnome uses adwaita icon theme as default. I'll try look into what
can be done.

Regards,
RG.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.