GNU bug report logs - #3889
23.1.50; [PATCH] Increase blink-matching-paren-distance

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3889 in the body.
You can then email your comments to 3889 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Ian Eure <ian <at> digg.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.1.50; [PATCH] Increase blink-matching-paren-distance
Date: Mon, 20 Jul 2009 13:49:46 -0700

[Message part 1 (text/plain, inline)]

A user came into #emacs today complaining that his paren matching was  
not working with a large file, and that font-locking broke as a result.

I found that this is controlled by blink-matching-paren-distance,  
which was increased to 25kb around 1997.

Attached is a patch which doubles this to 50kb, as this should be fine  
for modern machines. I think that we should seriously consider setting  
the default to nil, but this seems like a more conservative approach  
to the matter.

[blink-matching-paren.patch (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

Message #10 received at 3889 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Ian Eure <ian <at> digg.com>, 3889 <at> debbugs.gnu.org
Subject: Re: bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance
Date: Tue, 21 Jul 2009 11:39:10 +0200

> A user came into #emacs today complaining that his paren matching was
> not working with a large file, and that font-locking broke as a result.
>
> I found that this is controlled by blink-matching-paren-distance, which
> was increased to 25kb around 1997.

How can `blink-matching-paren-distance' affect font-locking?  If I
understand correctly all `blink-matching-open' can do is slow down
typing.

martin

Message #15 received at 3889 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Ian Eure <ian <at> digg.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 3889 <at> debbugs.gnu.org
Subject: Re: bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance
Date: Tue, 21 Jul 2009 09:17:27 -0700

On Jul 21, 2009, at 2:39 AM, martin rudalics wrote:

> > A user came into #emacs today complaining that his paren matching  
> was
> > not working with a large file, and that font-locking broke as a  
> result.
> >
> > I found that this is controlled by blink-matching-paren-distance,  
> which
> > was increased to 25kb around 1997.
>
> How can `blink-matching-paren-distance' affect font-locking?  If I
> understand correctly all `blink-matching-open' can do is slow down
> typing.
>
I don't know, as I couldn't reproduce that aspect of the issue.  
Perhaps their `show-paren-style' was set to 'expression.

The paren matching definitely breaks, though. You get a message saying  
that you have mismatched parens, and they're highlighted incorrectly.

 - Ian

Message #20 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Ian Eure <ian <at> digg.com>
Cc: 3889 <at> debbugs.gnu.org, emacs-pretest-bug <at> gnu.org
Subject: Re: bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance
Date: Tue, 21 Jul 2009 12:22:20 -0400

> Attached is a patch which doubles this to 50kb, as this should be fine for
> modern machines.

100kB should be fine, indeed.

> I think that we should seriously consider setting the default to nil,
> but this seems like a more conservative approach to the matter.

Maybe when you're browsing a 200MB log file, you'll find it painful, so
a lower limit would still seem to make sense.  100kB is probably very
conservative (even when running on my poor cell-phone, it should be fast
enough).


        Stefan

Message #30 received at 3889 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Ian Eure <ian <at> digg.com>
Cc: 3889 <at> debbugs.gnu.org
Subject: Re: bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance
Date: Tue, 21 Jul 2009 19:23:39 +0200

> I don't know, as I couldn't reproduce that aspect of the issue. Perhaps
> their `show-paren-style' was set to 'expression.

Could you try to get back to them?  Font-locking should never be
affected by this.

> The paren matching definitely breaks, though. You get a message saying
> that you have mismatched parens, and they're highlighted incorrectly.

That's normal.

martin

Message #35 received at 3889-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 3889-done <at> debbugs.gnu.org
Subject: Re: bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance
Date: Tue, 21 Jul 2009 22:35:50 -0400

Stefan Monnier wrote:

>> Attached is a patch which doubles this to 50kb, as this should be fine for
>> modern machines.
>
> 100kB should be fine, indeed.

So increased.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.