GNU bug report logs - #38882
[PATCH] Add SameBoy

Previous Next

Full log

Message #13 received at 38882-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: 38882-done <at> debbugs.gnu.org
Subject: Re: [bug#38882] [PATCH] Add SameBoy
Date: Fri, 03 Jan 2020 10:01:54 +0100

Hello,

Jakub Kądziołka <kuba <at> kadziolka.net> writes:

> Understandable. I thought about whether to leave this "v" here, but when
> I grepped for 'version "v' and took a quick look at the results, I
> deduced that this must be acceptable.

Other occurrences may be mistakes. In any case, the official version
number for Sameboy, per its homepage, is 0.12.3, not v0.12.3.

> I didn't even realize that, but it would make sense that there is quite
> a few buzzwords, since I copied this description verbatim from the
> homepage.

True, but some homepages are more humble than others. :)

I applied your patches with the following changes:

1. I removed "free" from the description of rgbds, since everything is
   free in GNU Guix.
2. I added a copyright header line with your name in each modified file.

Thank you!

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.