GNU bug report logs - #38882
[PATCH] Add SameBoy

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Subject: bug#38882: closed (Re: [bug#38882] [PATCH] Add SameBoy)
Date: Fri, 03 Jan 2020 09:02:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#38882: [PATCH] Add SameBoy

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 38882 <at> debbugs.gnu.org.

-- 
38882: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38882
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: 38882-done <at> debbugs.gnu.org
Subject: Re: [bug#38882] [PATCH] Add SameBoy
Date: Fri, 03 Jan 2020 10:01:54 +0100

Hello,

Jakub Kądziołka <kuba <at> kadziolka.net> writes:

> Understandable. I thought about whether to leave this "v" here, but when
> I grepped for 'version "v' and took a quick look at the results, I
> deduced that this must be acceptable.

Other occurrences may be mistakes. In any case, the official version
number for Sameboy, per its homepage, is 0.12.3, not v0.12.3.

> I didn't even realize that, but it would make sense that there is quite
> a few buzzwords, since I copied this description verbatim from the
> homepage.

True, but some homepages are more humble than others. :)

I applied your patches with the following changes:

1. I removed "free" from the description of rgbds, since everything is
   free in GNU Guix.
2. I added a copyright header line with your name in each modified file.

Thank you!

Regards,

-- 
Nicolas Goaziou

[Message part 3 (message/rfc822, inline)]

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add SameBoy
Date: Fri, 3 Jan 2020 01:32:02 +0100

[Message part 4 (text/plain, inline)]

Hello Guix,

please find attached a patchset that adds SameBoy and RGBDS to the
available packages. The latter is a dependency of the former, but is
also quite useful on its own.

Regards,
Jakub Kądziołka

[0001-gnu-Add-rgbds.patch (text/x-diff, attachment)]

[0002-gnu-Add-sameboy.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.