From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 19:32:21 2020 Received: (at submit) by debbugs.gnu.org; 3 Jan 2020 00:32:21 +0000 Received: from localhost ([127.0.0.1]:40216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inAt3-0006gW-1Y for submit@debbugs.gnu.org; Thu, 02 Jan 2020 19:32:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:40879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inAt1-0006gO-Au for submit@debbugs.gnu.org; Thu, 02 Jan 2020 19:32:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57142) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inAsw-00041Q-68 for guix-patches@gnu.org; Thu, 02 Jan 2020 19:32:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inAsu-0006dc-Hb for guix-patches@gnu.org; Thu, 02 Jan 2020 19:32:14 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:49936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inAsu-0006C1-48 for guix-patches@gnu.org; Thu, 02 Jan 2020 19:32:12 -0500 Received: (qmail 29404 invoked by uid 1009); 3 Jan 2020 01:32:03 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25681. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.046271 secs); 03 Jan 2020 00:32:03 -0000 Received: from unknown (HELO zdrowyportier.kadziolka.net) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 3 Jan 2020 01:32:03 +0100 Date: Fri, 3 Jan 2020 01:32:02 +0100 From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= To: guix-patches@gnu.org Subject: [PATCH] Add SameBoy Message-ID: <20200103003202.wy6in2mc4sbtj4h2@zdrowyportier.kadziolka.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="2sb5m4ot27codnht" Content-Disposition: inline Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 37.59.186.212 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --2sb5m4ot27codnht Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hello Guix, please find attached a patchset that adds SameBoy and RGBDS to the available packages. The latter is a dependency of the former, but is also quite useful on its own. Regards, Jakub Kądziołka --2sb5m4ot27codnht Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-gnu-Add-rgbds.patch" >From 9ec4034fb340d18498f080294af428f9edbbe3af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= Date: Fri, 3 Jan 2020 00:13:56 +0100 Subject: [PATCH 1/2] gnu: Add rgbds. * gnu/packages/assembly.scm (rgbds): New variable. --- gnu/packages/assembly.scm | 49 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/gnu/packages/assembly.scm b/gnu/packages/assembly.scm index fac3d478a5..f0755cfdcb 100644 --- a/gnu/packages/assembly.scm +++ b/gnu/packages/assembly.scm @@ -36,6 +36,8 @@ #:use-module (gnu packages compression) #:use-module (gnu packages flex) #:use-module (gnu packages gettext) + #:use-module (gnu packages image) + #:use-module (gnu packages linux) #:use-module (gnu packages man) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) @@ -249,3 +251,50 @@ assembler, a C compiler and a linker. The assembler uses Intel syntax functionality independent of any particular bytecode, language, or runtime") (license license:lgpl2.1+)))) + +(define-public rgbds + (package + (name "rgbds") + (version "v0.3.9") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/rednex/rgbds.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0pzd9ig3ahpgq7jbj82grllxx1v01d620insr2m8h0c6jj25n5hv")))) + (build-system gnu-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (delete 'configure) + (replace 'check + (lambda _ + (with-directory-excursion "test/asm" + (invoke "./test.sh")) + (with-directory-excursion "test/link" + (invoke "./test.sh"))))) + #:make-flags `("CC=gcc" + ,(string-append "PREFIX=" + (assoc-ref %outputs "out"))))) + (native-inputs + `(("bison" ,bison) + ("flex" ,flex) + ("pkg-config" ,pkg-config) + ("util-linux" ,util-linux))) + (inputs + `(("libpng" ,libpng))) + (home-page "https://github.com/rednex/rgbds") + (synopsis "Rednex Game Boy Development System") + (description + "RGBDS (Rednex Game Boy Development System) is a free assembler/linker +package for the Game Boy and Game Boy Color. It consists of: +@itemize @bullet +@item rgbasm (assembler) +@item rgblink (linker) +@item rgbfix (checksum/header fixer) +@item rgbgfx (PNG-to-Game Boy graphics converter) +@end itemize") + (license license:expat))) -- 2.24.1 --2sb5m4ot27codnht Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0002-gnu-Add-sameboy.patch" >From d2900a92b271c5e81093bd9704aa82dbb6b0f523 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= Date: Fri, 3 Jan 2020 01:29:04 +0100 Subject: [PATCH 2/2] gnu: Add sameboy. * gnu/packages/emulators.scm (sameboy): New variable. --- gnu/packages/emulators.scm | 48 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm index 63c1332c2f..fbfb1cf712 100644 --- a/gnu/packages/emulators.scm +++ b/gnu/packages/emulators.scm @@ -457,6 +457,54 @@ and Game Boy Color games.") ;; BSD-3. (license (list license:mpl2.0 license:lgpl2.1+ license:bsd-3)))) +(define-public sameboy + (package + (name "sameboy") + (version "v0.12.3") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/LIJI32/SameBoy.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0m5rv2x8qck1kr43xq186pp4kaiay7gd1x775n9qrljcd7z4x6fs")))) + (build-system gnu-build-system) + (native-inputs + `(("rgbds" ,rgbds) + ("gcc" ,gcc-9) + ("pkg-config" ,pkg-config))) + (inputs + `(("sdl2" ,sdl2))) + (arguments + `(#:tests? #f ; There are no tests + #:make-flags `("CC=gcc" "CONF=release" + ,(string-append "DATA_DIR=" + (assoc-ref %outputs "out") + "/share/sameboy/")) + #:phases + (modify-phases %standard-phases + (delete 'configure) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin")) + (data (string-append out "/share/sameboy/"))) + (with-directory-excursion "build/bin/SDL" + (install-file "sameboy" bin) + (delete-file "sameboy") + (copy-recursively "." data)))))))) + (home-page "https://sameboy.github.io/") + (synopsis "Extremely accurate Game Boy, Game Boy Color and Super Game Boy emulator") + (description "SameBoy is a user friendly Game Boy, Game Boy Color +and Super Game Boy emulator. SameBoy is extremely accurate and includes a wide +range of powerful debugging features, making it ideal for both casual players +and developers. In addition to accuracy and developer capabilities, SameBoy +has all the features one would expect from an emulator---from save states to +scaling filters.") + (license license:expat))) + (define-public mupen64plus-core (package (name "mupen64plus-core") -- 2.24.1 --2sb5m4ot27codnht-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 19:56:41 2020 Received: (at 38882) by debbugs.gnu.org; 3 Jan 2020 00:56:41 +0000 Received: from localhost ([127.0.0.1]:40236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inBGb-0007Gl-5o for submit@debbugs.gnu.org; Thu, 02 Jan 2020 19:56:41 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:43431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inBGZ-0007Gb-EL for 38882@debbugs.gnu.org; Thu, 02 Jan 2020 19:56:40 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 4DA33E0004; Fri, 3 Jan 2020 00:56:37 +0000 (UTC) From: Nicolas Goaziou To: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= Subject: Re: [bug#38882] [PATCH] Add SameBoy References: <20200103003202.wy6in2mc4sbtj4h2@zdrowyportier.kadziolka.net> Date: Fri, 03 Jan 2020 01:56:36 +0100 In-Reply-To: <20200103003202.wy6in2mc4sbtj4h2@zdrowyportier.kadziolka.net> ("Jakub =?utf-8?B?S8SFZHppb8WCa2EiJ3M=?= message of "Fri, 3 Jan 2020 01:32:02 +0100") Message-ID: <87k169we63.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38882 Cc: 38882@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Jakub K=C4=85dzio=C5=82ka writes: > please find attached a patchset that adds SameBoy and RGBDS to the > available packages. The latter is a dependency of the former, but is > also quite useful on its own. Thank you. > +(define-public rgbds > + (package > + (name "rgbds") > + (version "v0.3.9") This should be "0.3.9". > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/rednex/rgbds.git") > + (commit version))) You can add the missing "v" above : (commit (string-append "v" version)) > +(define-public sameboy > + (package > + (name "sameboy") > + (version "v0.12.3") See above. > + (description "SameBoy is a user friendly Game Boy, Game Boy Color > +and Super Game Boy emulator. SameBoy is extremely accurate and includes= a wide > +range of powerful debugging features, making it ideal for both casual pl= ayers > +and developers. In addition to accuracy and developer capabilities, Sam= eBoy > +has all the features one would expect from an emulator---from save state= s to > +scaling filters.") I think there are a lot of buzzwords in this description: "extremely accurate", "powerful debugging features", "making it ideal"... What about something like the following boring description: (description "SameBoy is a user friendly Game Boy, Game Boy Color and Super Game Boy emulator. SameBoy is accurate and includes a wide range of debugging features. It has all the features one would expect from an emulator---from save states to scaling filters.") Otherwise, LGTM. Could you send an updated patch? Regards, --=20 Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 04:02:00 2020 Received: (at 38882-done) by debbugs.gnu.org; 3 Jan 2020 09:02:00 +0000 Received: from localhost ([127.0.0.1]:40387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inIqG-0002B3-3b for submit@debbugs.gnu.org; Fri, 03 Jan 2020 04:02:00 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:32781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inIqD-0002Ap-B4 for 38882-done@debbugs.gnu.org; Fri, 03 Jan 2020 04:01:58 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 62CDBE0002; Fri, 3 Jan 2020 09:01:55 +0000 (UTC) From: Nicolas Goaziou To: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= Subject: Re: [bug#38882] [PATCH] Add SameBoy References: <20200103003202.wy6in2mc4sbtj4h2@zdrowyportier.kadziolka.net> <87k169we63.fsf@nicolasgoaziou.fr> <20200103013602.sbikh6vogxaco32i@zdrowyportier.kadziolka.net> Date: Fri, 03 Jan 2020 10:01:54 +0100 In-Reply-To: <20200103013602.sbikh6vogxaco32i@zdrowyportier.kadziolka.net> ("Jakub =?utf-8?B?S8SFZHppb8WCa2EiJ3M=?= message of "Fri, 3 Jan 2020 02:36:02 +0100") Message-ID: <875zhsx69p.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38882-done Cc: 38882-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Jakub K=C4=85dzio=C5=82ka writes: > Understandable. I thought about whether to leave this "v" here, but when > I grepped for 'version "v' and took a quick look at the results, I > deduced that this must be acceptable. Other occurrences may be mistakes. In any case, the official version number for Sameboy, per its homepage, is 0.12.3, not v0.12.3. > I didn't even realize that, but it would make sense that there is quite > a few buzzwords, since I copied this description verbatim from the > homepage. True, but some homepages are more humble than others. :) I applied your patches with the following changes: 1. I removed "free" from the description of rgbds, since everything is free in GNU Guix. 2. I added a copyright header line with your name in each modified file. Thank you! Regards, --=20 Nicolas Goaziou From unknown Sat Jun 14 03:56:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 31 Jan 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator