Subject: Re: [bug#38877] [PATCH] gnu: Add xcur2png.

From: Brett Gilio <[email-masked]>
Date: Fri, 03 Jan 2020 22:32:31 -0600

Leo Prikler <[email-masked]> writes:

> * gnu/packages/xorg.scm (xcur2png): New variable.
> ---
>  gnu/packages/xorg.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
> index fda61aff67..1c21a1cf86 100644
> --- a/gnu/packages/xorg.scm
> +++ b/gnu/packages/xorg.scm
> @@ -6425,3 +6425,29 @@ Thai).")
>      ;; by simple permissive licenses.  See the 'COPYRIGHT' file.
>      (license (list license:gpl2+
>                     license:expat))))
> +
> +(define-public xcur2png
> +  (package
> +    (name "xcur2png")
> +    (version "0.7.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/eworm-de/xcur2png.git")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "0858wn2p14bxpv9lvaz2bz1rk6zk0g8zgxf8iy595m8fqv4q2fya"))))
> +    (build-system gnu-build-system)
> +    (synopsis "Decode X cursors")
> +    (description
> +     "xcur2png is a program decomposes an X cursor into a set of PNG images and
> +a configuration file reusable by xcursorgen.")
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("libpng" ,libpng)
> +       ("libxcursor" ,libxcursor)))
> +    (home-page "https://github.com/eworm-de/xcur2png")
> +    (license license:gpl3+)))

Hey Leo! It doesn't really matter all that much, but I am curious about
the ordering of the package declaration. Why did you put the inputs
/after/ the synopsis and description? It's a fine looking package otherwise!

-- 
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
<[email-masked]> <[email-masked]>