GNU bug report logs - #38867
27.0.60; fileloop-initialize-replace misses occurrences to be replaced

Previous Next

Full log

Message #11 received at 38867 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: etimmons <at> mit.edu, 38867 <at> debbugs.gnu.org
Subject: Re: bug#38867: 27.0.60;
 fileloop-initialize-replace misses occurrences to be replaced
Date: Tue, 24 Mar 2020 16:08:28 +0200

> From: Noam Postavsky <npostavs <at> gmail.com>
> Date: Tue, 24 Mar 2020 06:00:05 -0400
> Cc: 38867 <at> debbugs.gnu.org
> 
> > Fix by telling `perform-replace' to operate over the entire
> > buffer. Could potentially be further be optimized by saving the point
> > in the scan-function and using it as the start point in the
> > operate-function.
> 
> Since the current code is trying to save the point in the scan function,
> it's better to keep that optimization.  See patch below.  Should this go
> to emacs-27 or master?  The assumption that point would be preserved
> seems to be long-standing, but I guess the change in the default of
> switch-to-buffer-preserve-window-point is what surfaces the bug and
> makes it more recent...

I think this can wait for Emacs 28, but if you disagree, please tell
why.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.