From unknown Sun Jun 22 03:48:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#38867 <38867@debbugs.gnu.org> To: bug#38867 <38867@debbugs.gnu.org> Subject: Status: 27.0.60; fileloop-initialize-replace misses occurrences to be replaced Reply-To: bug#38867 <38867@debbugs.gnu.org> Date: Sun, 22 Jun 2025 10:48:22 +0000 retitle 38867 27.0.60; fileloop-initialize-replace misses occurrences to be= replaced reassign 38867 emacs submitter 38867 Eric Michael Timmons severity 38867 normal tag 38867 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 00:34:37 2020 Received: (at submit) by debbugs.gnu.org; 2 Jan 2020 05:34:37 +0000 Received: from localhost ([127.0.0.1]:38000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imt81-0006CK-7c for submit@debbugs.gnu.org; Thu, 02 Jan 2020 00:34:37 -0500 Received: from lists.gnu.org ([209.51.188.17]:40576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imsik-0005ZV-Vd for submit@debbugs.gnu.org; Thu, 02 Jan 2020 00:08:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43893) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imsij-0000ui-Dj for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 00:08:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1imsih-0002EQ-Vq for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 00:08:29 -0500 Received: from outgoing-exchange-3.mit.edu ([18.9.28.13]:56196) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1imsih-0002Cc-R2 for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2020 00:08:27 -0500 Received: from w92exedge3.exchange.mit.edu (W92EXEDGE3.EXCHANGE.MIT.EDU [18.7.73.15]) by outgoing-exchange-3.mit.edu (8.14.7/8.12.4) with ESMTP id 00258Dxj019452 for ; Thu, 2 Jan 2020 00:08:13 -0500 Received: from w92expo10.exchange.mit.edu (18.7.74.64) by w92exedge3.exchange.mit.edu (18.7.73.15) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Thu, 2 Jan 2020 00:07:15 -0500 Received: from oc11expo10.exchange.mit.edu (18.9.4.15) by w92expo10.exchange.mit.edu (18.7.74.64) with Microsoft SMTP Server (TLS) id 15.0.1365.1; Thu, 2 Jan 2020 00:08:25 -0500 Received: from oc11expo10.exchange.mit.edu ([18.9.4.15]) by oc11expo10.exchange.mit.edu ([18.9.4.15]) with mapi id 15.00.1365.000; Thu, 2 Jan 2020 00:08:25 -0500 From: Eric Michael Timmons To: "bug-gnu-emacs@gnu.org" Subject: 27.0.60; fileloop-initialize-replace misses occurrences to be replaced Thread-Topic: 27.0.60; fileloop-initialize-replace misses occurrences to be replaced Thread-Index: AQHVwSp4jQoTG+J9zEungTeX7PZewQ== Date: Thu, 2 Jan 2020 05:08:25 +0000 Message-ID: <1577941704945.15167@mit.edu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [184.19.53.43] Content-Type: multipart/mixed; boundary="_002_157794170494515167mitedu_" MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 18.9.28.13 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 02 Jan 2020 00:34:36 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --_002_157794170494515167mitedu_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Severity: normal=0A= Tags: patch=0A= =0A= When using fileloop-initialize-replace on files that already have open=0A= buffers and points in arbitrary locations, occurrences of the regex to=0A= replace can be missed. This appears to happen on my setup when=0A= switch-to-buffer-preserve-window-point is non-nil. The call to=0A= switch-buffer between the invocation of the scan- and operate-functions=0A= can then cause the point to change to a different location than the=0A= scan-function left it.=0A= =0A= This can manifest itself by either missing occurrences of the regex in=0A= the open files where point is beyond some occurrences or it can=0A= completely miss files if some file early on in the iteration has its=0A= point beyond all occurrences of the regex, causing the operate-function=0A= to return nil, aborting the rest of the operation.=0A= =0A= In GNU Emacs 27.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.13, c= airo version 1.16.0)=0A= of 2019-12-27 built on rocinante=0A= Repository revision: 8224ed7d406e8654a163b05c0c647a5d44c090ed=0A= Repository branch: emacs-27=0A= Windowing system distributor 'The X.Org Foundation', version 11.0.12006000= =0A= System Description: Gentoo/Linux=0A= =0A= --_002_157794170494515167mitedu_ Content-Type: text/x-patch; name="0001-Fix-fileloop-initialize-replace-with-buffers-that-ar.patch" Content-Description: 0001-Fix-fileloop-initialize-replace-with-buffers-that-ar.patch Content-Disposition: attachment; filename="0001-Fix-fileloop-initialize-replace-with-buffers-that-ar.patch"; size=1810; creation-date="Thu, 02 Jan 2020 05:04:37 GMT"; modification-date="Thu, 02 Jan 2020 05:04:37 GMT" Content-Transfer-Encoding: base64 RnJvbSA3NGVjMjg2N2FhMjFiMzEyOGUyNjAwMDQ4Zjk4ZjNlNzc4MmZlMGFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFcmljIFRpbW1vbnMgPGV0aW1tb25zQG1pdC5lZHU+CkRhdGU6 IFdlZCwgMSBKYW4gMjAyMCAyMjozMzo0NyAtMDYwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBmaWxl bG9vcC1pbml0aWFsaXplLXJlcGxhY2Ugd2l0aCBidWZmZXJzIHRoYXQgYXJlIGFscmVhZHkKIG9w ZW4KClRoZSBvcGVyYXRlLWZ1bmN0aW9uIHVzZWQgaW4gZmlsZWxvb3AtaW5pdGlhbGl6ZS1yZXBs YWNlIGFzc3VtZWQgdGhhdAp0aGUgcG9pbnQgZG9lcyBub3QgY2hhbmdlIGJldHdlZW4gdGhlIGlu dm9jYXRpb24gb2YgdGhlIHNjYW4tZnVuY3Rpb24KYW5kIG9wZXJhdGUtZnVuY3Rpb24uIFRoaXMg YXNzdW1wdGlvbiBpcyB2aW9sYXRlZCwgaG93ZXZlciwgaWYgdGhlCmZpbGUgYmVpbmcgb3BlcmF0 ZWQgb24gaGFzIGFscmVhZHkgYmVlbiBvcGVuZWQgaW4gYSB3aW5kb3cgYW5kCmBzd2l0Y2gtdG8t YnVmZmVyLXByZXNlcnZlLXdpbmRvdy1wb2ludCcgaXMgbm9uLW5pbC4KCkZpeCBieSB0ZWxsaW5n IGBwZXJmb3JtLXJlcGxhY2UnIHRvIG9wZXJhdGUgb3ZlciB0aGUgZW50aXJlCmJ1ZmZlci4gQ291 bGQgcG90ZW50aWFsbHkgYmUgZnVydGhlciBiZSBvcHRpbWl6ZWQgYnkgc2F2aW5nIHRoZSBwb2lu dAppbiB0aGUgc2Nhbi1mdW5jdGlvbiBhbmQgdXNpbmcgaXQgYXMgdGhlIHN0YXJ0IHBvaW50IGlu IHRoZQpvcGVyYXRlLWZ1bmN0aW9uLgotLS0KIGxpc3AvZmlsZWxvb3AuZWwgfCAxMCArKysrLS0t LS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL2xpc3AvZmlsZWxvb3AuZWwgYi9saXNwL2ZpbGVsb29wLmVsCmluZGV4IDU0Mzk2 M2ZlYWYuLjBjOGVjNWI4ZTAgMTAwNjQ0Ci0tLSBhL2xpc3AvZmlsZWxvb3AuZWwKKysrIGIvbGlz cC9maWxlbG9vcC5lbApAQCAtMjA1LDEzICsyMDUsMTEgQEAgREVMSU1JVEVEIGlmIG5vbi1uaWwg bWVhbnMgcmVwbGFjZSBvbmx5IHdvcmQtZGVsaW1pdGVkIG1hdGNoZXMuIgogICAgKGxhbWJkYSAo KQogICAgICAobGV0ICgoY2FzZS1mb2xkLXNlYXJjaAogICAgICAgICAgICAgKGlmIChtZW1xbCBj YXNlLWZvbGQgJyhuaWwgdCkpIGNhc2UtZm9sZCBjYXNlLWZvbGQtc2VhcmNoKSkpCi0gICAgICAg KGlmIChyZS1zZWFyY2gtZm9yd2FyZCBmcm9tIG5pbCB0KQotCSAgIDs7IFdoZW4gd2UgZmluZCBh IG1hdGNoLCBtb3ZlIGJhY2sKLQkgICA7OyB0byB0aGUgYmVnaW5uaW5nIG9mIGl0IHNvIHBlcmZv cm0tcmVwbGFjZQotCSAgIDs7IHdpbGwgc2VlIGl0LgotCSAgIChnb3RvLWNoYXIgKG1hdGNoLWJl Z2lubmluZyAwKSkpKSkKKyAgICAgICAocmUtc2VhcmNoLWZvcndhcmQgZnJvbSBuaWwgdCkpKQog ICAgKGxhbWJkYSAoKQotICAgICAocGVyZm9ybS1yZXBsYWNlIGZyb20gdG8gdCB0IGRlbGltaXRl ZCBuaWwgbXVsdGktcXVlcnktcmVwbGFjZS1tYXApKSkpCisgICAgIDs7IFdlIHByb3ZpZGUgU1RB UlQgYW5kIEVORCBiZWNhdXNlIHRoZSBidWZmZXIgaXMgbm90IGd1YXJhbnRlZWQKKyAgICAgOzsg dG8gYmUgYXQgYW55IHBhcnRpY3VsYXIgcG9pbnQgd2hlbiB0aGlzIGlzIGNhbGxlZC4KKyAgICAg KHBlcmZvcm0tcmVwbGFjZSBmcm9tIHRvIHQgdCBkZWxpbWl0ZWQgbmlsIG11bHRpLXF1ZXJ5LXJl cGxhY2UtbWFwIChwb2ludC1taW4pIChwb2ludC1tYXgpKSkpKQogCiAocHJvdmlkZSAnZmlsZWxv b3ApCiA7OzsgZmlsZWxvb3AuZWwgZW5kcyBoZXJlCi0tIAoyLjI0LjEKCg== --_002_157794170494515167mitedu_-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 24 06:00:16 2020 Received: (at 38867) by debbugs.gnu.org; 24 Mar 2020 10:00:16 +0000 Received: from localhost ([127.0.0.1]:53909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGgM3-0002H8-PP for submit@debbugs.gnu.org; Tue, 24 Mar 2020 06:00:16 -0400 Received: from mail-qt1-f171.google.com ([209.85.160.171]:45541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGgM1-0002Gs-Ev for 38867@debbugs.gnu.org; Tue, 24 Mar 2020 06:00:14 -0400 Received: by mail-qt1-f171.google.com with SMTP id t17so4269123qtn.12 for <38867@debbugs.gnu.org>; Tue, 24 Mar 2020 03:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3nbH65eQf4nlxpKdkoUGr6jUDRbsATtXUouTQyxTHSQ=; b=AyZEKWMOOGwP1KLEaVkvDrG/ufLMp3z0HHeuzSpPtjiAzhMGnF52hihdunvGrvA4On O/mqfhqTW2kmXbPTjJqVO9f2s0dLG7yakOWlMpe0QBJfzA/0FTiiEDYa2dMMoU5+XQTh HBgPAqGxj95OoLxVqWuCmwPSrdlk3+HDKF8SMFZj0hsIEMn7vo5TmfnYnp4lF3Bm+GJh /a/d6aeg+6OA4PUuP9R59z1QNaU9b+0xSNiOFOKll6pqRQ8mvzR8xV0m+2W/TIYl9kwx rTyYO0D0IAYjIzF3vS1+LOpU6SLIRngmiEoPA0R0cCxUpiiJDjlc5ieMOLnV+Ha8k8My 92Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=3nbH65eQf4nlxpKdkoUGr6jUDRbsATtXUouTQyxTHSQ=; b=jC5L+8f4neezZbbf9jHZUnyttgFcv/pdqrut+mR2lZ/FSd48BhZAJhwYUnq8WftNta VYV96FWLRSfiGXore4aVYiMqnpSGQ4UEpSO6ZlDRF6hO/Fyozk0br4dfYdQyxxFNFGhW K4oJB2nLoq4AVg6ojCxPlns/ynpPtvSdF5RGu3A+XzdHR9itO0c58CwXz0nXxIX1K/fY 5V7k+w9o3hD6CuiYNiXGueOKG8a2/dWnz+GdHAgTq2r2Y43DJLSu+HRkAQnrYL3Snkll eXrABBEtemgAD/li/pQRNCzNeBJARdh8uuIGLMFNVCwkEcuWuqwFG5m6tHsob+Pj0t2+ kpjQ== X-Gm-Message-State: ANhLgQ0gsEi3zh9rEPDFhQCcPplIKXgFFBiJBCSpvRIKENK0N2jStLHq If4926NIsdQWYgcB7W53e6DtjLPD X-Google-Smtp-Source: ADFU+vvwq1ay//aCCAHBSAbQUSIh6MAk+hGTgRmbaQJfQ5qPwJ/ovIMSz8iukz0phBjv9bL2n/nw4w== X-Received: by 2002:ac8:6697:: with SMTP id d23mr16344108qtp.8.1585044007648; Tue, 24 Mar 2020 03:00:07 -0700 (PDT) Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id p191sm13076909qke.6.2020.03.24.03.00.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Mar 2020 03:00:06 -0700 (PDT) From: Noam Postavsky To: Eric Michael Timmons Subject: Re: bug#38867: 27.0.60; fileloop-initialize-replace misses occurrences to be replaced References: <1577941704945.15167@mit.edu> Date: Tue, 24 Mar 2020 06:00:05 -0400 In-Reply-To: <1577941704945.15167@mit.edu> (Eric Michael Timmons's message of "Thu, 2 Jan 2020 05:08:25 +0000") Message-ID: <87a746jcnu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38867 Cc: 38867@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eric Michael Timmons writes: > Fix by telling `perform-replace' to operate over the entire > buffer. Could potentially be further be optimized by saving the point > in the scan-function and using it as the start point in the > operate-function. Since the current code is trying to save the point in the scan function, it's better to keep that optimization. See patch below. Should this go to emacs-27 or master? The assumption that point would be preserved seems to be long-standing, but I guess the change in the default of switch-to-buffer-preserve-window-point is what surfaces the bug and makes it more recent... --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Don-t-lose-point-during-fileloop-replace-Bug-38867.patch Content-Description: patch >From 033564127065e213868f034f08b32d14ad3d1c74 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Tue, 24 Mar 2020 05:39:03 -0400 Subject: [PATCH] Don't lose point during fileloop replace (Bug#38867) Suggested by Eric Michael Timmons . * lisp/fileloop.el (fileloop-initialize-replace): Save the match-beginning position in a variable instead of the buffer's point. The point may be changed by the time perform-replace is called, e.g., due to switch-to-buffer-preserve-window-point. --- lisp/fileloop.el | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/lisp/fileloop.el b/lisp/fileloop.el index 543963feaf..8f4911638e 100644 --- a/lisp/fileloop.el +++ b/lisp/fileloop.el @@ -200,18 +200,22 @@ fileloop-initialize-replace DELIMITED if non-nil means replace only word-delimited matches." ;; FIXME: Not sure how the delimited-flag interacts with the regexp-flag in ;; `perform-replace', so I just try to mimic the old code. - (fileloop-initialize - files - (lambda () - (let ((case-fold-search - (if (memql case-fold '(nil t)) case-fold case-fold-search))) - (if (re-search-forward from nil t) - ;; When we find a match, move back - ;; to the beginning of it so perform-replace - ;; will see it. - (goto-char (match-beginning 0))))) - (lambda () - (perform-replace from to t t delimited nil multi-query-replace-map)))) + (let ((mstart (make-hash-table :test 'eq))) + (fileloop-initialize + files + (lambda () + (let ((case-fold-search + (if (memql case-fold '(nil t)) case-fold case-fold-search))) + (when (re-search-forward from nil t) + ;; When we find a match, save its beginning for + ;; `perform-replace' (we used to just set point, but this + ;; is unreliable in the face of + ;; `switch-to-buffer-preserve-window-point'). + (puthash (current-buffer) (match-beginning 0) mstart)))) + (lambda () + (perform-replace from to t t delimited nil multi-query-replace-map + (gethash (current-buffer) mstart (point-min)) + (point-max)))))) (provide 'fileloop) ;;; fileloop.el ends here -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 24 10:08:31 2020 Received: (at 38867) by debbugs.gnu.org; 24 Mar 2020 14:08:31 +0000 Received: from localhost ([127.0.0.1]:55395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGkEI-0004xx-Ng for submit@debbugs.gnu.org; Tue, 24 Mar 2020 10:08:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGkEH-0004xh-9w for 38867@debbugs.gnu.org; Tue, 24 Mar 2020 10:08:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jGkEC-0006K4-2K; Tue, 24 Mar 2020 10:08:24 -0400 Received: from [176.228.60.248] (port=3815 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jGkE8-0001E4-GC; Tue, 24 Mar 2020 10:08:23 -0400 Date: Tue, 24 Mar 2020 16:08:28 +0200 Message-Id: <835zetc0bn.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-Reply-To: <87a746jcnu.fsf@gmail.com> (message from Noam Postavsky on Tue, 24 Mar 2020 06:00:05 -0400) Subject: Re: bug#38867: 27.0.60; fileloop-initialize-replace misses occurrences to be replaced References: <1577941704945.15167@mit.edu> <87a746jcnu.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38867 Cc: etimmons@mit.edu, 38867@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Noam Postavsky > Date: Tue, 24 Mar 2020 06:00:05 -0400 > Cc: 38867@debbugs.gnu.org > > > Fix by telling `perform-replace' to operate over the entire > > buffer. Could potentially be further be optimized by saving the point > > in the scan-function and using it as the start point in the > > operate-function. > > Since the current code is trying to save the point in the scan function, > it's better to keep that optimization. See patch below. Should this go > to emacs-27 or master? The assumption that point would be preserved > seems to be long-standing, but I guess the change in the default of > switch-to-buffer-preserve-window-point is what surfaces the bug and > makes it more recent... I think this can wait for Emacs 28, but if you disagree, please tell why. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 31 18:24:03 2020 Received: (at 38867) by debbugs.gnu.org; 31 Mar 2020 22:24:04 +0000 Received: from localhost ([127.0.0.1]:37157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJPIh-0007cM-I2 for submit@debbugs.gnu.org; Tue, 31 Mar 2020 18:24:03 -0400 Received: from mail-qv1-f53.google.com ([209.85.219.53]:43870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJPIf-0007bo-VH; Tue, 31 Mar 2020 18:24:02 -0400 Received: by mail-qv1-f53.google.com with SMTP id c28so11789018qvb.10; Tue, 31 Mar 2020 15:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=E5/4loqscnhy2+mC5T8vV/CEHtWuJki6/t2FZcdzXso=; b=nU0J0sfP0DC2GK5zhtsQQf32zoidkvCHDHatVA/ujZrHTQuvJziGW1s1d3Hpt7dJS8 irAo8kKhKxr3Ck8VZxhXyOttMGK0okBFWkk4dyfSbZjrGkA7HQrTpk6YkZnHGnXMZ9ET o6sWUG9fF9ufUW71+T29/dbyb4CLfo3ZXFGxBMky8+Mst7EEAv2385pTp0T3HyXgPWC7 +3FBfbzY7u64jhMWb4miDONbj1UFCExhd6r0Jbo5KLx6uQxtdcIsy9SZdfnFdbVUz7cO BtNWVHN9dBW9nTQRwN2n34zeouP6zEWF3LkE15XIPYYGKg7W9wgF6s2RQDiRNPTR3+Hq FENQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=E5/4loqscnhy2+mC5T8vV/CEHtWuJki6/t2FZcdzXso=; b=UZtWjrgAyK588aGoaTGLd3ieoBn5CcOrHwrTPp2ktc9YHrTgk43GnkMdjZ4QV7cD2s V3LBySWS0NQKFH+tOoicTN5lvastoOpUUFkw+t0a/imMHhsjzvho92sjDjdy8h9TxCqq vaGWBm8KOVV0pKU256XxSRzUreBr2hBRlS9KNOEQrhLze68DeGsloe07pk4fo+cLFKtA CyFNGL1Lj3LTqGqmZTZtAwrHM+ScG22Kb8V/oYlkiXqHSc1Tp2+VtNhL1Kaaoaj8rPJw 0U1blqtdO8Btwd9oa72IWZ1iXFaKtU6y4t58p7yU0ETAgCU9PoYTElFzWb2fEkcMSJen AMdg== X-Gm-Message-State: ANhLgQ2N/xGtzP0mx4Lnr0P6rFpcguK0Hkw5uMb4b/XU7VU5nReB8xSi KlQWe9ICukJO8mqfo0OiIYLeFrzv X-Google-Smtp-Source: ADFU+vu7Kbgt629Zo5LN7XSLRYS5JIYOAZ1oDGpx9nfEOR+IOqQc6GL+eYF7bRJ2QlBExXKENuQmMg== X-Received: by 2002:a0c:e810:: with SMTP id y16mr18879588qvn.198.1585693436230; Tue, 31 Mar 2020 15:23:56 -0700 (PDT) Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id p65sm218837qke.42.2020.03.31.15.23.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Mar 2020 15:23:55 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#38867: 27.0.60; fileloop-initialize-replace misses occurrences to be replaced References: <1577941704945.15167@mit.edu> <87a746jcnu.fsf@gmail.com> <835zetc0bn.fsf@gnu.org> Date: Tue, 31 Mar 2020 18:23:54 -0400 In-Reply-To: <835zetc0bn.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 Mar 2020 16:08:28 +0200") Message-ID: <87imiki2o5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38867 Cc: etimmons@mit.edu, 38867@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 38867 fixed close 38867 28.1 quit Eli Zaretskii writes: >> Should this go to emacs-27 or master? The assumption that point >> would be preserved seems to be long-standing, but I guess the change >> in the default of switch-to-buffer-preserve-window-point is what >> surfaces the bug and makes it more recent... > > I think this can wait for Emacs 28, but if you disagree, please tell > why. I don't really feel strongly about it, so I've pushed to master. [1: a477a7b86b]: 2020-03-31 18:17:53 -0400 Don't lose point during fileloop replace (Bug#38867) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=a477a7b86ba7c59a90b18283cc86769c27de6c7c From unknown Sun Jun 22 03:48:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 29 Apr 2020 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator