GNU bug report logs - #38849
Fix IBus-Rime

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#38849: closed (Fix IBus-Rime)
Date: Mon, 06 Jan 2020 14:28:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 06 Jan 2020 15:26:54 +0100
with message-id <87y2ukbqz5.fsf <at> gnu.org>
and subject line Re: [bug#38849] Fix IBus-Rime
has caused the debbugs.gnu.org bug report #38849,
regarding Fix IBus-Rime
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
38849: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38849
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: kanichos <at> yandex.ru
To: guix-patches <at> gnu.org
Subject: Fix IBus-Rime
Date: Wed, 01 Jan 2020 13:28:28 +0300

IBus uses the component file rime.xml to start the Rime engine. It must be patched with appropriate paths.

---
 gnu/packages/ibus.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/ibus.scm b/gnu/packages/ibus.scm
index 42a8d5db32..7daefde021 100644
--- a/gnu/packages/ibus.scm
+++ b/gnu/packages/ibus.scm
@@ -668,6 +668,10 @@ Method Engine.")
                                (assoc-ref inputs "rime-data")
                                "/share/rime-data\"\n")))
              #t))
+         (add-after 'unpack 'fix-paths
+           (lambda* (#:key outputs #:allow-other-keys)
+             (substitute* "rime.xml"
+               (("/usr") (assoc-ref outputs "out"))) #t))
          (delete 'configure))))
     (inputs
      `(("gdk-pixbuf" ,gdk-pixbuf)
-- 
2.23.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: kanichos <at> yandex.ru
Cc: 38849-done <at> debbugs.gnu.org
Subject: Re: [bug#38849] Fix IBus-Rime
Date: Mon, 06 Jan 2020 15:26:54 +0100

Hello,

kanichos <at> yandex.ru skribis:

> IBus uses the component file rime.xml to start the Rime engine. It must be patched with appropriate paths.
>
> ---
>  gnu/packages/ibus.scm | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/gnu/packages/ibus.scm b/gnu/packages/ibus.scm
> index 42a8d5db32..7daefde021 100644
> --- a/gnu/packages/ibus.scm
> +++ b/gnu/packages/ibus.scm
> @@ -668,6 +668,10 @@ Method Engine.")
>                                 (assoc-ref inputs "rime-data")
>                                 "/share/rime-data\"\n")))
>               #t))
> +         (add-after 'unpack 'fix-paths
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (substitute* "rime.xml"
> +               (("/usr") (assoc-ref outputs "out"))) #t))

I made the following changes:

  1. Move the explanation as a comment in the code.

  2. Write “file name” instead of “path”, for consistency.

  3. Write a commit log that follows the project’s conventions.

Committed now, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.