GNU bug report logs - #38848
Fix path substitution in IBus

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#38848: closed (Fix path substitution in IBus)
Date: Wed, 01 Jan 2020 22:57:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 01 Jan 2020 23:56:26 +0100
with message-id <87lfqqn5ut.fsf <at> elephly.net>
and subject line Re: [bug#38848] Fix path substitution in IBus
has caused the debbugs.gnu.org bug report #38848,
regarding Fix path substitution in IBus
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
38848: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38848
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: kanichos <at> yandex.ru
To: guix-patches <at> gnu.org
Subject: Fix path substitution in IBus
Date: Wed, 01 Jan 2020 13:15:49 +0300

The IBus package has been broken since forever because it substitutes paths to setxkbmap and xmodmap binaries with package directories.

---
gnu/packages/ibus.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/ibus.scm b/gnu/packages/ibus.scm
index 5057927174..42a8d5db32 100644
--- a/gnu/packages/ibus.scm
+++ b/gnu/packages/ibus.scm
@@ -116,7 +116,7 @@
                               "/share/X11/locale")))
             (substitute* "ui/gtk3/xkblayout.vala"
               (("\"(setxkbmap|xmodmap)\"" _ prog)
-                (string-append "\"" (assoc-ref inputs prog) "\"")))
+                (string-append "\"" (assoc-ref inputs prog) "/bin/" prog "\"")))
             #t))
         (add-after 'wrap-program 'wrap-with-additional-paths
           (lambda* (#:key outputs #:allow-other-keys)
--
2.23.0

[Message part 3 (message/rfc822, inline)]

From: Ricardo Wurmus <rekado <at> elephly.net>
To: kanichos <at> yandex.ru
Cc: 38848-done <at> debbugs.gnu.org
Subject: Re: [bug#38848] Fix path substitution in IBus
Date: Wed, 01 Jan 2020 23:56:26 +0100

kanichos <at> yandex.ru writes:

> The IBus package has been broken since forever because it substitutes
> paths to setxkbmap and xmodmap binaries with package directories.

Oh, good catch!  Thanks!
(I’ve only ever been using libpinyin, so I never noticed…)

Pushed to the master branch with commit 92d7f5b45d.

--
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.