GNU bug report logs - #38846
[PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access

Previous Next

Full log

Message #74 received at 38846 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: guix-maintainers <at> gnu.org, 38846 <at> debbugs.gnu.org
Subject: Re: [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access.
Date: Tue, 07 Jan 2020 00:29:12 +0100

[Message part 1 (text/plain, inline)]

Ludo',

Thank you for this series.

Ludovic Courtès 写道：
> +@item
> +Send @email{guix-maintainers@@gnu.org} a signed message stating 
> your
> +intent, listing the three committers who support your 
> application, and
> +giving the fingerprint of the OpenPGP key you will use to sign 
> commits
> +(see below).
> +
> +@item
> +Once you've been given access, please send a message to
  ^^^^

Probably just me, but this glosses over maintainer approval just a 
bit too deftly, and that even with 3 signed referrals commit 
access isn't guaranteed, just extremely likely.

Unless that will actually change, I think we should briefly 
mention it as well.  People react worse to ‘let's try again later’ 
when they think they've already passed.  Understandably so.

> +@email{guix-devel@@gnu.org} to say so, again signed with the 
> OpenPGP key
> +you will use to sign commits.  That way, everyone can notice 
> and ensure
> +you control that OpenPGP key.

Best to add an explicit ‘before pushing your first commit’ here, 
if that is the intent.

> +When you get commit access, please make sure to follow
  ^^^^

‘If’?  Same point as the first @items above.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.