From unknown Mon Jun 23 20:16:34 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#38846 <38846@debbugs.gnu.org> To: bug#38846 <38846@debbugs.gnu.org> Subject: Status: [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access Reply-To: bug#38846 <38846@debbugs.gnu.org> Date: Tue, 24 Jun 2025 03:16:34 +0000 retitle 38846 [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for = commit access reassign 38846 guix-patches submitter 38846 Ludovic Court=C3=A8s severity 38846 normal tag 38846 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 11:30:03 2020 Received: (at submit) by debbugs.gnu.org; 1 Jan 2020 16:30:04 +0000 Received: from localhost ([127.0.0.1]:37461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgsl-000219-Jt for submit@debbugs.gnu.org; Wed, 01 Jan 2020 11:30:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:58102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgsj-00020Z-R9 for submit@debbugs.gnu.org; Wed, 01 Jan 2020 11:30:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54493) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imgsi-0007qe-LB for guix-patches@gnu.org; Wed, 01 Jan 2020 11:30:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=ALL_TRUSTED,BAYES_50 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imgsi-0008Sb-Gz; Wed, 01 Jan 2020 11:30:00 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47364 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imgsh-0007kO-Rp; Wed, 01 Jan 2020 11:30:00 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access Date: Wed, 1 Jan 2020 17:29:45 +0100 Message-Id: <20200101162945.4946-1-ludo@gnu.org> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: guix-maintainers@gnu.org Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Guix! Happy new year, merry 12 nivôse, or whatever celebration is appropriate for you! :-) These patches do three things: 1. Move text from ‘HACKING’ to ‘doc/contributing.texi’. 2. Encourage patch review for committers. 3. Add a tentative policy for granting commit access (the last patch of this series). I expect #1 and #2 to be uncontroversial, but I’d like feedback on #3! So far, we’ve been giving commit access in a very ad-hoc fashion. Often it was Ricardo or myself who ended up taking care of that, even though other people have admin rights on Savannah to add/remove members. We briefly discussed it among maintainers after the maintainer collective expanded, and it seems to me that perhaps now is a good time to formalize things a bit—to clarify what contributors may expect and to increase transparency. Hence this proposal of a simple co-optation policy. As you know, Chris Baines has been working towards automated testing of submitted patches. One of the goals is to allow part of the QA to be automated, such that, eventually, approved merges could be automated. In that spirit, we would have an incentive to not add more committers (probably also a good thing security-wise). That’s why I added a note on this topic. What do people think? Thanks, Ludo’. Ludovic Courtès (4): doc: Add "Tracking Bugs and Patches" section. doc: Move "Commit Access" section from 'HACKING' to the manual. doc: Encourage patch review. DRAFT doc: Add a cooption policy for commit access. HACKING | 58 +------------- doc/contributing.texi | 171 ++++++++++++++++++++++++++++++++++++++++-- doc/guix.texi | 2 +- 3 files changed, 168 insertions(+), 63 deletions(-) -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 11:35:03 2020 Received: (at 38846) by debbugs.gnu.org; 1 Jan 2020 16:35:04 +0000 Received: from localhost ([127.0.0.1]:37474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgxY-0002BK-GQ for submit@debbugs.gnu.org; Wed, 01 Jan 2020 11:35:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgxW-0002Az-BI for 38846@debbugs.gnu.org; Wed, 01 Jan 2020 11:34:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imgxR-0003To-5n; Wed, 01 Jan 2020 11:34:53 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47372 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imgxQ-00045M-Ol; Wed, 01 Jan 2020 11:34:52 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 38846@debbugs.gnu.org Subject: [PATCH 1/4] doc: Add "Tracking Bugs and Patches" section. Date: Wed, 1 Jan 2020 17:34:43 +0100 Message-Id: <20200101163446.5132-1-ludo@gnu.org> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= , guix-maintainers@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * doc/contributing.texi (Tracking Bugs and Patches): New section. (Submitting Patches): Refer to it. * doc/guix.texi: Update copyright line. * HACKING (Using emacs-debbugs): Remove. --- HACKING | 11 +------- doc/contributing.texi | 62 ++++++++++++++++++++++++++++++++++++++----- doc/guix.texi | 2 +- 3 files changed, 58 insertions(+), 17 deletions(-) diff --git a/HACKING b/HACKING index 2f0f93f896..eeea2f6311 100644 --- a/HACKING +++ b/HACKING @@ -2,7 +2,7 @@ #+TITLE: Hacking GNU Guix and Its Incredible Distro -Copyright © 2012, 2013, 2014, 2016, 2017, 2019 Ludovic Courtès +Copyright © 2012, 2013, 2014, 2016, 2017, 2019, 2020 Ludovic Courtès Copyright © 2015, 2017 Mathieu Lirzin Copyright © 2017 Leo Famulari Copyright © 2017 Arun Isaac @@ -63,12 +63,3 @@ after two weeks, and if you’re confident, it’s OK to commit. That last part is subject to being adjusted, allowing individuals to commit directly on non-controversial changes on parts they’re familiar with. - -* Using emacs-debbugs - -Bug reports and patches are tracked using debbugs. If you are on emacs, you -can use emacs-debbugs. - -List all open bug reports on guix-patches with - -C-u M-x debbugs-gnu guix-patches n y diff --git a/doc/contributing.texi b/doc/contributing.texi index e656676c0f..fd27f037e9 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -26,6 +26,7 @@ choice. * Packaging Guidelines:: Growing the distribution. * Coding Style:: Hygiene of the contributor. * Submitting Patches:: Share your work. +* Tracking Bugs and Patches:: Using Debbugs. @end menu @node Building from Git @@ -827,12 +828,12 @@ Thus, access to the repository is not strictly necessary. We welcome contributions in the form of patches as produced by @code{git format-patch} sent to the @email{guix-patches@@gnu.org} mailing list. -This mailing list is backed by a Debbugs instance accessible at -@uref{https://bugs.gnu.org/guix-patches}, which allows us to keep track -of submissions. Each message sent to that mailing list gets a new -tracking number assigned; people can then follow up on the submission by -sending email to @code{@var{NNN}@@debbugs.gnu.org}, where @var{NNN} is -the tracking number (@pxref{Sending a Patch Series}). +This mailing list is backed by a Debbugs instance, which allows us to +keep track of submissions (@pxref{Tracking Bugs and Patches}). Each +message sent to that mailing list gets a new tracking number assigned; +people can then follow up on the submission by sending email to +@code{@var{NNN}@@debbugs.gnu.org}, where @var{NNN} is the tracking +number (@pxref{Sending a Patch Series}). Please write commit logs in the ChangeLog format (@pxref{Change Logs,,, standards, GNU Coding Standards}); you can check the commit history for @@ -1040,3 +1041,52 @@ they are kept together. See for more information. You can install @command{git send-email} with @command{guix install git:send-email}. @c Debbugs bug: https://debbugs.gnu.org/db/15/15361.html + +@node Tracking Bugs and Patches +@section Tracking Bugs and Patches + +@cindex bug reports, tracking +@cindex patch submissions, tracking +@cindex issue tracking +@cindex Debbugs, issue tracking system +Bug reports and patch submissions are currently tracked using the +Debbugs instance at @uref{https://bugs.gnu.org}. Bug reports are filed +against the @code{guix} ``package'' (in Debbugs parlance), by sending +email to @email{bug-guix@@gnu.org}, while patch submissions are filed +against the @code{guix-patches} package by sending email to +@email{guix-patches@@gnu.org} (@pxref{Submitting Patches}). + +A web interface (actually @emph{two} web interfaces!) are available to +browse issues: + +@itemize +@item +@url{https://bugs.gnu.org/guix} lists bug reports; +@item +@url{https://bugs.gnu.org/guix-patches} lists patch submissions. +@end itemize + +You can also access both of these @i{via} the (nicer) +@url{https://issues.guix.gnu.org} interface@footnote{The web interface +at @url{https://issues.guix.gnu.org} is powered by Mumi, a nice piece of +software written in Guile, and you can help! See +@url{https://git.elephly.net/gitweb.cgi?p=software/mumi.git}.}. To view +discussions related to issue number @var{n}, go to +@indicateurl{https://issues.guix.gnu.org/issue/@var{n}} or +@indicateurl{https://bugs.gnu.org/@var{n}}. + +If you use Emacs, you may find it more convenient to interact with +issues using @file{debbugs.el}, which you can install with: + +@example +guix install emacs-debbugs +@end example + +For example, to list all open issues on @code{guix-patches}, hit: + +@example +@kbd{C-u} @kbd{M-x} debbugs-gnu @kbd{RET} @kbd{RET} guix-patches @kbd{RET} n y +@end example + +@xref{Top,,, debbugs-ug, Debbugs User Guide}, for more information on +this nifty tool! diff --git a/doc/guix.texi b/doc/guix.texi index 70e3dfea6a..999b7c9421 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -21,7 +21,7 @@ @set SUBSTITUTE-URL https://@value{SUBSTITUTE-SERVER} @copying -Copyright @copyright{} 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès@* +Copyright @copyright{} 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020 Ludovic Courtès@* Copyright @copyright{} 2013, 2014, 2016 Andreas Enge@* Copyright @copyright{} 2013 Nikita Karetnikov@* Copyright @copyright{} 2014, 2015, 2016 Alex Kost@* -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 11:35:04 2020 Received: (at 38846) by debbugs.gnu.org; 1 Jan 2020 16:35:04 +0000 Received: from localhost ([127.0.0.1]:37477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgxb-0002Bu-Uv for submit@debbugs.gnu.org; Wed, 01 Jan 2020 11:35:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgxX-0002B1-Am for 38846@debbugs.gnu.org; Wed, 01 Jan 2020 11:34:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imgxS-0003XN-5C; Wed, 01 Jan 2020 11:34:54 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47372 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imgxR-00045M-Ju; Wed, 01 Jan 2020 11:34:53 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 38846@debbugs.gnu.org Subject: [PATCH 2/4] doc: Move "Commit Access" section from 'HACKING' to the manual. Date: Wed, 1 Jan 2020 17:34:44 +0100 Message-Id: <20200101163446.5132-2-ludo@gnu.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200101163446.5132-1-ludo@gnu.org> References: <20200101163446.5132-1-ludo@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= , guix-maintainers@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * HACKING (Commit Access): Remove. (Contributing): Update URL of the manual. * doc/contributing.texi (Commit Access): New section. (Submitting Patches): Add cross reference. --- HACKING | 47 +--------------------------------- doc/contributing.texi | 59 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+), 46 deletions(-) diff --git a/HACKING b/HACKING index eeea2f6311..36373278f9 100644 --- a/HACKING +++ b/HACKING @@ -17,49 +17,4 @@ See the manual for useful hacking informations, either by running info -f doc/guix.info "Contributing" -or by checking the [[http://www.gnu.org/software/guix/manual/guix.html#Contributing][web copy of the manual]]. - -* Commit Access - -For frequent contributors, having write access to the repository is -convenient. When you deem it necessary, feel free to ask for it on the -mailing list. When you get commit access, please make sure to follow the -policy below (discussions of the policy can take place on guix-devel@gnu.org.) - -Non-trivial patches should always be posted to guix-patches@gnu.org (trivial -patches include fixing typos, etc.). This mailing list fills the -patch-tracking database at [[https://bugs.gnu.org/guix-patches]]; see -"Contributing" in the manual for details. - -For patches that just add a new package, and a simple one, it’s OK to commit, -if you’re confident (which means you successfully built it in a chroot setup, -and have done a reasonable copyright and license auditing.) Likewise for -package upgrades, except upgrades that trigger a lot of rebuilds (for example, -upgrading GnuTLS or GLib.) We have a mailing list for commit notifications -(guix-commits@gnu.org), so people can notice. Before pushing your changes, -make sure to run ‘git pull --rebase’. - -All commits that are pushed to the central repository on Savannah must be -signed with an OpenPGP key, and the public key should be uploaded to your user -account on Savannah and to public key servers, such as -‘keys.openpgp.org’. To configure Git to automatically sign commits, -run: - - git config commit.gpgsign true - git config user.signingkey CABBA6EA1DC0FF33 - -You can prevent yourself from accidentally pushing unsigned commits to -Savannah by using the pre-push Git hook called located at ‘etc/git/pre-push’: - - cp etc/git/pre-push .git/hooks/pre-push - -When pushing a commit on behalf of somebody else, please add a Signed-off-by -line at the end of the commit log message (e.g. with ‘git am --signoff’). -This improves tracking of who did what. - -For anything else, please post to guix-patches@gnu.org and leave time for a -review, without committing anything. If you didn’t receive any reply -after two weeks, and if you’re confident, it’s OK to commit. - -That last part is subject to being adjusted, allowing individuals to commit -directly on non-controversial changes on parts they’re familiar with. +or by checking the [[https://guix.gnu.org/manual/devel/en/html_node/Contributing.html][web copy of the manual]]. diff --git a/doc/contributing.texi b/doc/contributing.texi index fd27f037e9..e6e6ab36c2 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -27,6 +27,7 @@ choice. * Coding Style:: Hygiene of the contributor. * Submitting Patches:: Share your work. * Tracking Bugs and Patches:: Using Debbugs. +* Commit Access:: Pushing to the official repository. @end menu @node Building from Git @@ -827,6 +828,8 @@ Development is done using the Git distributed version control system. Thus, access to the repository is not strictly necessary. We welcome contributions in the form of patches as produced by @code{git format-patch} sent to the @email{guix-patches@@gnu.org} mailing list. +Seasoned Guix developers may also want to look at the section on commit +access (@pxref{Commit Access}). This mailing list is backed by a Debbugs instance, which allows us to keep track of submissions (@pxref{Tracking Bugs and Patches}). Each @@ -1090,3 +1093,59 @@ For example, to list all open issues on @code{guix-patches}, hit: @xref{Top,,, debbugs-ug, Debbugs User Guide}, for more information on this nifty tool! + +@node Commit Access +@section Commit Access + +@cindex commit access, for developers +For frequent contributors, having write access to the repository is +convenient. When you deem it necessary, feel free to ask for it on the +mailing list. When you get commit access, please make sure to follow +the policy below (discussions of the policy can take place on +@email{guix-devel@@gnu.org}). + +Non-trivial patches should always be posted to +@email{guix-patches@@gnu.org} (trivial patches include fixing typos, +etc.). This mailing list fills the patch-tracking database +(@pxref{Tracking Bugs and Patches}). + +For patches that just add a new package, and a simple one, it's OK to +commit, if you're confident (which means you successfully built it in a +chroot setup, and have done a reasonable copyright and license +auditing). Likewise for package upgrades, except upgrades that trigger +a lot of rebuilds (for example, upgrading GnuTLS or GLib). We have a +mailing list for commit notifications (@email{guix-commits@@gnu.org}), +so people can notice. Before pushing your changes, make sure to run +@code{git pull --rebase}. + +All commits that are pushed to the central repository on Savannah must +be signed with an OpenPGP key, and the public key should be uploaded to +your user account on Savannah and to public key servers, such as +@code{keys.openpgp.org}. To configure Git to automatically sign +commits, run: + +@example +git config commit.gpgsign true +git config user.signingkey CABBA6EA1DC0FF33 +@end example + +You can prevent yourself from accidentally pushing unsigned commits to +Savannah by using the pre-push Git hook called located at +@file{etc/git/pre-push}: + +@example +cp etc/git/pre-push .git/hooks/pre-push +@end example + +When pushing a commit on behalf of somebody else, please add a +@code{Signed-off-by} line at the end of the commit log message---e.g., +with @command{git am --signoff}. This improves tracking of who did +what. + +For anything else, please post to @email{guix-patches@@gnu.org} and +leave time for a review, without committing anything (@pxref{Submitting +Patches}). If you didn’t receive any reply after two weeks, and if +you're confident, it's OK to commit. + +That last part is subject to being adjusted, allowing individuals to commit +directly on non-controversial changes on parts they’re familiar with. -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 11:35:05 2020 Received: (at 38846) by debbugs.gnu.org; 1 Jan 2020 16:35:05 +0000 Received: from localhost ([127.0.0.1]:37479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgxd-0002C2-Fl for submit@debbugs.gnu.org; Wed, 01 Jan 2020 11:35:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgxY-0002B3-9o for 38846@debbugs.gnu.org; Wed, 01 Jan 2020 11:35:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imgxT-0003Yu-4i; Wed, 01 Jan 2020 11:34:55 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47372 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imgxS-00045M-Jp; Wed, 01 Jan 2020 11:34:54 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 38846@debbugs.gnu.org Subject: [PATCH 3/4] doc: Encourage patch review. Date: Wed, 1 Jan 2020 17:34:45 +0100 Message-Id: <20200101163446.5132-3-ludo@gnu.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200101163446.5132-1-ludo@gnu.org> References: <20200101163446.5132-1-ludo@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= , guix-maintainers@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * doc/contributing.texi (Commit Access): Add note about patch review. --- doc/contributing.texi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/contributing.texi b/doc/contributing.texi index e6e6ab36c2..74b4718eb3 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -1149,3 +1149,9 @@ you're confident, it's OK to commit. That last part is subject to being adjusted, allowing individuals to commit directly on non-controversial changes on parts they’re familiar with. + +One last thing: the project keeps moving forward because committers not +only push their own awesome changes, but also offer some of their time +@emph{reviewing} and pushing other people's changes. As a committer, +you're welcome to use your expertise and commit rights to help other +contributors, too! -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 11:35:06 2020 Received: (at 38846) by debbugs.gnu.org; 1 Jan 2020 16:35:06 +0000 Received: from localhost ([127.0.0.1]:37481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgxd-0002CA-Ov for submit@debbugs.gnu.org; Wed, 01 Jan 2020 11:35:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgxZ-0002B5-Js for 38846@debbugs.gnu.org; Wed, 01 Jan 2020 11:35:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imgxU-0003cC-EV; Wed, 01 Jan 2020 11:34:56 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47372 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imgxT-00045M-JQ; Wed, 01 Jan 2020 11:34:56 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 38846@debbugs.gnu.org Subject: [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. Date: Wed, 1 Jan 2020 17:34:46 +0100 Message-Id: <20200101163446.5132-4-ludo@gnu.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200101163446.5132-1-ludo@gnu.org> References: <20200101163446.5132-1-ludo@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= , guix-maintainers@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) DRAFT: Subject to discussion! * doc/contributing.texi (Commit Access): Draft a cooptation policy. --- doc/contributing.texi | 48 +++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index 74b4718eb3..6e2cc1a369 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -1099,8 +1099,52 @@ this nifty tool! @cindex commit access, for developers For frequent contributors, having write access to the repository is -convenient. When you deem it necessary, feel free to ask for it on the -mailing list. When you get commit access, please make sure to follow +convenient. When you deem it necessary, consider applying for commit +access by following these steps: + +@enumerate +@item +Find three committers who would vouch for you, emailing a signed +statement to @email{guix-maintainers@@gnu.org} (a private alias for the +collective of maintainers). You can view the list of committers at +@url{https://savannah.gnu.org/project/memberlist.php?group=guix}. + +Committers are expected to have had some interactions with you as a +contributor and to be able to judge whether you are sufficiently +familiar with the project's practices. It is @emph{not} a judgment on +the quality of your work, so a refusal should rather be interpreted as +``let's try again later''. + +@item +Send @email{guix-maintainers@@gnu.org} a signed message stating your +intent, listing the three committers who support your application, and +giving the fingerprint of the OpenPGP key you will use to sign commits +(see below). + +@item +Once you've been given access, please send a message to +@email{guix-devel@@gnu.org} to say so, again signed with the OpenPGP key +you will use to sign commits. That way, everyone can notice and ensure +you control that OpenPGP key. + +@c TODO: Add note about adding the fingerprint to the list of authorized +@c keys once that has stabilized. + +@item +Make sure to read the rest of this section and... profit! +@end enumerate + +@quotation Note +Maintainers are happy to give commit access to people who have been +contributing for some time and have a track record---don't be shy and +don't underestimate your work! + +However, note that the project is working towards a more automated patch +review and merging system, which, as a consequence, may lead us to have +fewer people with commit access to the main repository. Stay tuned! +@end quotation + +When you get commit access, please make sure to follow the policy below (discussions of the policy can take place on @email{guix-devel@@gnu.org}). -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 13:08:12 2020 Received: (at 38846) by debbugs.gnu.org; 1 Jan 2020 18:08:12 +0000 Received: from localhost ([127.0.0.1]:37538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imiPk-00055Q-7n for submit@debbugs.gnu.org; Wed, 01 Jan 2020 13:08:12 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imiPh-00055I-OA for 38846@debbugs.gnu.org; Wed, 01 Jan 2020 13:08:10 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1577902086; cv=none; d=zohomail.com; s=zohoarc; b=HKYJS6pNQmewmv/td7yLVG23xrTILafB4sOQ9RbxWW5Cdi8uJJl9G1OcwAkMizrQyfl4XLmfJVVfBa7WtxkPy+udf4KxZzyKRrCt3M+IuxdjpKSxnOPFrgW12RnH6cAOL5O+KynKU+DYEFjNOekhN8dD4eXvc41LmoIyEQY3YXk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577902086; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=mvVSwdqOaaNnRwZxSCHjmi28Zt5pDZYicPluIxU1LXw=; b=Z0X77nAYvBYdoY5k/Jiu56uNcU/VguNtX+vugFv4NcnOkrQNz4jtpeiGl0/ztDMtA/4VKD0uRm6yuxQLpJsHr0KWqEkBkJLBRHsg/8brIFJ5W6HfesbGarLs4SOYYR6kFprXd0gvD3zcpSAszvvgjbI9swUq3eE0lqHuisfrYec= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1577902086; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=mvVSwdqOaaNnRwZxSCHjmi28Zt5pDZYicPluIxU1LXw=; b=P+kyaRYClLBs5FoH92JXSXODVH5/UK31raHO+MkA6PnasgbKiIgCPXv1jZhjnYxf 1dPuaZ3TyyKAUyUz86cBWf6x30joQtfooVYhhecPNhBOtHyF2ZJ7JwNzoChUwThKqtX SJ9BsPANEU12DvIv5ekglKoR7dmyOMFtK9BOKxjo= Received: from localhost (p54AD4FC9.dip0.t-ipconnect.de [84.173.79.201]) by mx.zohomail.com with SMTPS id 1577902082322370.85793141179556; Wed, 1 Jan 2020 10:08:02 -0800 (PST) References: <20200101163446.5132-1-ludo@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Ricardo Wurmus To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH 1/4] doc: Add "Tracking Bugs and Patches" section. In-reply-to: <20200101163446.5132-1-ludo@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Wed, 01 Jan 2020 19:07:58 +0100 Message-ID: <87zhf7m4n5.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: guix-maintainers@gnu.org, 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: > * doc/contributing.texi (Tracking Bugs and Patches): New section. > (Submitting Patches): Refer to it. > * doc/guix.texi: Update copyright line. > * HACKING (Using emacs-debbugs): Remove. Looks good to me, thank you! --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 13:09:00 2020 Received: (at 38846) by debbugs.gnu.org; 1 Jan 2020 18:09:00 +0000 Received: from localhost ([127.0.0.1]:37541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imiQW-00056R-GQ for submit@debbugs.gnu.org; Wed, 01 Jan 2020 13:09:00 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imiQU-00056G-88 for 38846@debbugs.gnu.org; Wed, 01 Jan 2020 13:08:58 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1577902136; cv=none; d=zohomail.com; s=zohoarc; b=ZwU7c1hyiC5SnNSS0WGC9B4y4Fa19PPk8GrTf309pyLKleVz+K0N6Z1IunO17sbAcZMfu+ESDrGvfAOYrO839SvGFGtCRRhutkhlJwhHGj4Dog/WZMcBneFmZG3a9OgN6x5QDELviEEQpNpEk11MrK46movVukU1f+Lry1Us7vE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577902136; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=vhwzmcvZEogA0pW6G5hbaMVlWJsw3ECI7SErBdjGWa4=; b=RLZbwMp6tfiIhuFwCtbZUkdFoKiJIGnhaBaYRop+nvl7WaHtqlGVf1+5ikhATQdcmZnoUvtVaGETPFRqxyfvYq93rsVzWwUM2+Y0lKDNcqUgLgTEN1kmQpOyv7u3MWGTbtaA7d3eXx7OP/xyN4Wzt6JGCJQhwvg9ShibQd1OVaQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1577902136; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=vhwzmcvZEogA0pW6G5hbaMVlWJsw3ECI7SErBdjGWa4=; b=g7Zk4NGwVrBVzaIl48BkSWjVM6oyC8sfrfCmVGhBhM3DB6oAnEBi+tYsZMMM15Gq nd0yUI68MrbmKbxefmja1H/gZd1fHTtXDS6gSc2givj3F2HWTNpzmRfuaqYH+UncYwe 8/rJzSF5FfDnHcfX55Vf73sbzpwD+HOIYf56Sdo8= Received: from localhost (p54AD4FC9.dip0.t-ipconnect.de [84.173.79.201]) by mx.zohomail.com with SMTPS id 1577902132636667.6073451292851; Wed, 1 Jan 2020 10:08:52 -0800 (PST) References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-2-ludo@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Ricardo Wurmus To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH 2/4] doc: Move "Commit Access" section from 'HACKING' to the manual. In-reply-to: <20200101163446.5132-2-ludo@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Wed, 01 Jan 2020 19:08:49 +0100 Message-ID: <87y2urm4lq.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: guix-maintainers@gnu.org, 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: > * HACKING (Commit Access): Remove. > (Contributing): Update URL of the manual. > * doc/contributing.texi (Commit Access): New section. > (Submitting Patches): Add cross reference. LGTM! --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 13:09:32 2020 Received: (at 38846) by debbugs.gnu.org; 1 Jan 2020 18:09:32 +0000 Received: from localhost ([127.0.0.1]:37546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imiR1-00057g-Qn for submit@debbugs.gnu.org; Wed, 01 Jan 2020 13:09:32 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imiR0-00057X-Cb for 38846@debbugs.gnu.org; Wed, 01 Jan 2020 13:09:30 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1577902168; cv=none; d=zohomail.com; s=zohoarc; b=Y+f5bAgypk5CH9nCLmGtWCgcU5mBXkmck9dn9F3voGAq1jzCkXLQFCXm5ZThM9StQgm1Lw4ePuiZt3XQLdBGRZaLFU/SbYn8mXW2w8BHRHxsDQarciVCxgI2ibE7ESQkQGAz5qgHHAoUX76veRe3Zg/vt8IIRCaNduQ0sK1z0TA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577902168; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=KQm0wRNxcod82rJYsStKffr2uDfV+RHkg8YHHav1410=; b=PblgCHYC9hwI/xOLK0ozdyMbXnLnQiF7z47IC1hwZhOoSBqn6hwXHaKTgclCVaE+zLhvhcER56afNfter9xvILj1n33Xf0Agnfw98y/AAHrCakPVklr+5M9RzrD0dgFUXVBeK+L5rl2ADr8By5rY7X2fCy1qEmukIW4rpH6mN4I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1577902168; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=KQm0wRNxcod82rJYsStKffr2uDfV+RHkg8YHHav1410=; b=EMdIqv1ZUzvNy2+uXy7AK3Pj7yvii+HiL7JvKX2UVEBK93e4KnrkzHZJ23RQzaQR tPBBIQ6QhwBbKXTNM25mGvldVsXgOcqkRYC4aeyMJn99Eo1ytaTHQ07Ks9XzPX48KsC U8Two2Yx22fSItMqCRsNMnkm/mow5RTHS9nAkB1s= Received: from localhost (p54AD4FC9.dip0.t-ipconnect.de [84.173.79.201]) by mx.zohomail.com with SMTPS id 1577902164985650.871898869934; Wed, 1 Jan 2020 10:09:24 -0800 (PST) References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-3-ludo@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Ricardo Wurmus To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH 3/4] doc: Encourage patch review. In-reply-to: <20200101163446.5132-3-ludo@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Wed, 01 Jan 2020 19:09:21 +0100 Message-ID: <87woabm4ku.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: guix-maintainers@gnu.org, 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: > * doc/contributing.texi (Commit Access): Add note about patch review. > --- > doc/contributing.texi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/contributing.texi b/doc/contributing.texi > index e6e6ab36c2..74b4718eb3 100644 > --- a/doc/contributing.texi > +++ b/doc/contributing.texi > @@ -1149,3 +1149,9 @@ you're confident, it's OK to commit. >=20=20 > That last part is subject to being adjusted, allowing individuals to com= mit > directly on non-controversial changes on parts they=E2=80=99re familiar = with. > + > +One last thing: the project keeps moving forward because committers not > +only push their own awesome changes, but also offer some of their time > +@emph{reviewing} and pushing other people's changes. As a committer, > +you're welcome to use your expertise and commit rights to help other > +contributors, too! Perfect! --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 13:16:01 2020 Received: (at 38846) by debbugs.gnu.org; 1 Jan 2020 18:16:02 +0000 Received: from localhost ([127.0.0.1]:37551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imiXJ-0005HJ-H2 for submit@debbugs.gnu.org; Wed, 01 Jan 2020 13:16:01 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imiXH-0005H7-Ro for 38846@debbugs.gnu.org; Wed, 01 Jan 2020 13:16:00 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1577902555; cv=none; d=zohomail.com; s=zohoarc; b=QsYmM4cJOE4x+/BmPTzt/wvsS3v0dd1cPbmRw4usXSMrn1bum7EZN+/2w58RqYkVds+wzTtdSNdVFeyaPbfg4ZzEsCY5VPqxP2vtqXPnaZlXEvxsD6uNRbkkscQCZFyIBu0vk7IG9lIsls5GfoLqusYKXgDOXEPqzAwgVu8D1nA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577902555; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=sqz015KE6+Jh5alNMJjvJMUesYJ6KQr4ext6tG5wxDI=; b=liYlErzMoFBk1CDHq5c69DYgei0muNWukCgD+k208gfo1Lu9SaD9Vio2bgjVjOwP2rDuyTcLqbQxOpiANgoEK3QpXvMifcm8NXt7x1MmXMKOKg3ZF/A300XR4FOLdM73ICldYf/vWWy+9yVuq8xgCn9tq1FRoLrxf7gHEosNiGA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1577902555; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=sqz015KE6+Jh5alNMJjvJMUesYJ6KQr4ext6tG5wxDI=; b=M3HvK5+MVoZ2dZ2eBgtoBsFFnSmrwrUGk0Ie0/HHTzjzceGJSxm5atkRaNjpGXe2 IjSNwq88r6Km23hZxGz4HHotRZco9MOzEe3t1RItnduKyZ9plQprazN+73jPDV9k3oR iaJOyYKCJ9Qhk8etKLpaS6qp2WjzY7Bd2dyhPkUk= Received: from localhost (p54AD4FC9.dip0.t-ipconnect.de [84.173.79.201]) by mx.zohomail.com with SMTPS id 1577902551469245.2578239650138; Wed, 1 Jan 2020 10:15:51 -0800 (PST) References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Ricardo Wurmus To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. In-reply-to: <20200101163446.5132-4-ludo@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Wed, 01 Jan 2020 19:15:48 +0100 Message-ID: <87v9pvm4a3.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: guix-maintainers@gnu.org, 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: > DRAFT: Subject to discussion! > > * doc/contributing.texi (Commit Access): Draft a cooptation policy. I like this! > +Find three committers who would vouch for you, emailing a signed > +statement to @email{guix-maintainers@@gnu.org} (a private alias for the > +collective of maintainers). You can view the list of committers at > +@url{https://savannah.gnu.org/project/memberlist.php?group=3Dguix}. I misinterpreted this to mean that the three committers would need to sign their endorsement=E2=80=A6 > + > +@item > +Send @email{guix-maintainers@@gnu.org} a signed message stating your > +intent, listing the three committers who support your application, and > +giving the fingerprint of the OpenPGP key you will use to sign commits > +(see below). I think it may be necessary to state that =E2=80=9Csigned=E2=80=9D means th= e use of a cryptographic signature here and not just =E2=80=9C~~ Rekado=E2=80=9D (as i= t would be done on the Wikipedia for example). Perhaps we could link to the email self defense guide of the FSF? https://emailselfdefense.fsf.org/en/ Thank you for the draft! -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 13:18:59 2020 Received: (at 38846) by debbugs.gnu.org; 1 Jan 2020 18:18:59 +0000 Received: from localhost ([127.0.0.1]:37555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imiaB-0005MM-45 for submit@debbugs.gnu.org; Wed, 01 Jan 2020 13:18:59 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:46239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imia9-0005M7-Hc for 38846@debbugs.gnu.org; Wed, 01 Jan 2020 13:18:57 -0500 Received: by mail-qk1-f194.google.com with SMTP id r14so29997768qke.13 for <38846@debbugs.gnu.org>; Wed, 01 Jan 2020 10:18:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=gPN4tunbI0pR557o8TgibmJW9IpjkRckb/Qyy6HZr0s=; b=BoTMsyRkvXV/UOMuF3GvKrGuYg2oGOx4Gk72nMQZeHpa//jXWmVAxLix1rLlh34Vre rBBAxryuIMYn2BgQR+hF2hQJM1Zph2TqfVGKWpH3HVBx1IgG8woYbxtW5+TA5xM9OMQZ zT66MYkoh1RCsXGV1vyK3Q2mosSfmyfTx6p1MzX5pjAKUjVXJahZ/Xn2VKk1n/GOkwqR oQN6JrdhuvekecRcD4/YX99+2JevH2BVRO8hKFPQGQSdxQP8Aw2wB46WX4zEY4BNeWAs IURcOziB4eualA4oEQvIwV/e/YrEiBZgFpDUkBbx3Cs+xKDmFP+jAA5ItA8Arhn5FIha KDBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gPN4tunbI0pR557o8TgibmJW9IpjkRckb/Qyy6HZr0s=; b=G5N30+FxpqnTRsNt0Xl4MwUhTbl5Mgu4Und3gDZVUYrexFlVa5nzoidTwto2fj91W+ z0SFB1CdQcDZ6DuoFX7GILoSKwB53JstE6HBVP2tlqZIpIkZAHZCiaoOuMpHhDeM6B9S MCHKCpXCV6zHXstbL7w+d2DIjmsng4cWrKNPppJhGs5/UPKjsSpAKnqcPHYN0ajevPum ShqO55gObPbIz7kzxpE27jhqe+ymd02uo5f6wewb3hosUy7+oBsZ3frsxlGAhXp+eKPQ 6D5DdIi8jHqNha/EP6R6nDRWb0w44WmYThzsAEWS68Vp7I4OjMyDyf+td33vdjFqkMmp meNg== X-Gm-Message-State: APjAAAUYpAbmq4GaHOXHFdy6aVIOqRnWQ8M1FyJWaLbWLO57UuB+IiTa RVPGMeFXsyC5clgeUK+RgCB0dvEEMJr8NN+udAY= X-Google-Smtp-Source: APXvYqx9HV1gDxqF5AAumSHeYhm5GrXfPV/aB60TUS0RTyEKua/AxT9OUwOmPloNolUWaICbEvoPNqweC6fZ8Ubq9AU= X-Received: by 2002:a37:63c7:: with SMTP id x190mr62879880qkb.232.1577902732042; Wed, 01 Jan 2020 10:18:52 -0800 (PST) MIME-Version: 1.0 References: <20200101162945.4946-1-ludo@gnu.org> <20200101163446.5132-1-ludo@gnu.org> In-Reply-To: <20200101163446.5132-1-ludo@gnu.org> From: zimoun Date: Wed, 1 Jan 2020 19:18:38 +0100 Message-ID: Subject: Re: [bug#38846] [PATCH 1/4] doc: Add "Tracking Bugs and Patches" section. To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo, On Wed, 1 Jan 2020 at 17:36, Ludovic Court=C3=A8s wrote: > > * doc/contributing.texi (Tracking Bugs and Patches): New section. > (Submitting Patches): Refer to it. > * doc/guix.texi: Update copyright line. > * HACKING (Using emacs-debbugs): Remove. > --- > HACKING | 11 +------- > doc/contributing.texi | 62 ++++++++++++++++++++++++++++++++++++++----- > doc/guix.texi | 2 +- > 3 files changed, 58 insertions(+), 17 deletions(-) > > diff --git a/HACKING b/HACKING > index 2f0f93f896..eeea2f6311 100644 > --- a/HACKING > +++ b/HACKING > @@ -2,7 +2,7 @@ > > #+TITLE: Hacking GNU Guix and Its Incredible Distro > > -Copyright =C2=A9 2012, 2013, 2014, 2016, 2017, 2019 Ludovic Court=C3=A8s= > +Copyright =C2=A9 2012, 2013, 2014, 2016, 2017, 2019, 2020 Ludovic Court= =C3=A8s > Copyright =C2=A9 2015, 2017 Mathieu Lirzin > Copyright =C2=A9 2017 Leo Famulari > Copyright =C2=A9 2017 Arun Isaac > @@ -63,12 +63,3 @@ after two weeks, and if you=E2=80=99re confident, it= =E2=80=99s OK to commit. > > That last part is subject to being adjusted, allowing individuals to com= mit > directly on non-controversial changes on parts they=E2=80=99re familiar = with. > - > -* Using emacs-debbugs > - > -Bug reports and patches are tracked using debbugs. If you are on emacs, = you > -can use emacs-debbugs. > - > -List all open bug reports on guix-patches with > - > -C-u M-x debbugs-gnu guix-patches n y I thought the policy about copyright was when adding/changing lines, not when removing them. https://lists.gnu.org/archive/html/guix-devel/2019-10/msg00473.html Maybe I miss something. Just to notice. Otherwise, nice! Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 13:37:33 2020 Received: (at 38846) by debbugs.gnu.org; 1 Jan 2020 18:37:33 +0000 Received: from localhost ([127.0.0.1]:37566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imis9-0005ny-2w for submit@debbugs.gnu.org; Wed, 01 Jan 2020 13:37:33 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imis8-0005nr-6S for 38846@debbugs.gnu.org; Wed, 01 Jan 2020 13:37:32 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1577903847; cv=none; d=zohomail.com; s=zohoarc; b=XC6/ukmaJ3zShPSB4O+9ZCqMOsITgwCPdmvTjeTTUaX7STelK3XKmg8rONlhh86m8/DF57vPeb4kDW4NTQ+oZi9ktIH96tHn8QYMn6PmFgl2HkT5goDPZvRhtptKpbmoZl3PlDvoYs/3F0BKBZOHtCtG0GEymXYDDu6MNQXMr1s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577903847; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Sp9c40ah0WE4dm6ImUbwaHBeadVUbN4admV1+orN86E=; b=UYV7aK7nm0qOs7NJo8U0MOymziEwzc0MiGQiZl688SOqQXJ9V9JKB6eUi2Ws7H1URaMqAlbHN4GwFdBdPkV1X2oObLYAo8crVondoCDwzbKeUxzQE39VqRjcFKrm08eWj/pLXIjltVuI3PlaSJMQkz7IHaK6mTg8Vbzw+YYdZE0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1577903847; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=Sp9c40ah0WE4dm6ImUbwaHBeadVUbN4admV1+orN86E=; b=KG0JjkV6DEzI2n0lqhGoD/n2TDwEwhcvW0rXVJuUSFkeax5h9ozneRhIK9Dtp+E6 fgeUZ1OZYwaQg1ABNI1RcZFIMYYk/ms1IBOqjSfFLWzSrpsCMf5vzC8tzvLZ1kYLf6y CYfOV6+YRqy2CKkN4P3ADi1xYzLQaIPc9CnL6a+0= Received: from localhost (p54AD4FC9.dip0.t-ipconnect.de [84.173.79.201]) by mx.zohomail.com with SMTPS id 1577903842715177.0640425661942; Wed, 1 Jan 2020 10:37:22 -0800 (PST) References: <20200101162945.4946-1-ludo@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Ricardo Wurmus To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#38846] [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access In-reply-to: <20200101162945.4946-1-ludo@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Wed, 01 Jan 2020 19:37:19 +0100 Message-ID: <87tv5fm3a8.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: guix-maintainers@gnu.org, 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: > As you know, Chris Baines has been working towards automated testing > of submitted patches. One of the goals is to allow part of the > QA to be automated, such that, eventually, approved merges could be > automated. In that spirit, we would have an incentive to not add more > committers (probably also a good thing security-wise). That=E2=80=99s wh= y I > added a note on this topic. I=E2=80=99m looking forward to this. Ultimately, it is a good thing to lim= it the number of people who can write to the repository. --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 13:52:11 2020 Received: (at 38846) by debbugs.gnu.org; 1 Jan 2020 18:52:11 +0000 Received: from localhost ([127.0.0.1]:37575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imj6I-000698-Ok for submit@debbugs.gnu.org; Wed, 01 Jan 2020 13:52:10 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:43874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imj6G-00068v-QW for 38846@debbugs.gnu.org; Wed, 01 Jan 2020 13:52:09 -0500 Received: by mail-qt1-f196.google.com with SMTP id d18so30737337qtj.10 for <38846@debbugs.gnu.org>; Wed, 01 Jan 2020 10:52:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Uf02thNPeRKu7HtMOG2HWQCTqi1u+CMzNLTP19RksWs=; b=cLLDlI1Aerl3o3T6kbpg/CN6JqSHmzEjHl82+46jngnZgRK2COGeJahyqSnzLburJ7 A1BPQ/wCt4QmQ0JJDnJuksS2NHlNDN7weBlJZKYoSNDDS/sM48XAM3ODnGC2iEosta/u snW03MeX0tU3y4dLKf3Q+jAvX2J3vR3JyhT+Ewt/vZusbIM3TK8zbvmh2ylrvzpcgnRP rSvJuCzdmfD60j2rPVlshpw8loDTLJKoUXPZfR441AN8iT1C6RTsrVLFPvceMbs/yGmQ WKBuegmcsHBb/GM6BcoBf5UtvWlvxI6Lb4zJQqp2aWPGX8wNzGK6rCgzVw/nbq+hQZHK JwnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Uf02thNPeRKu7HtMOG2HWQCTqi1u+CMzNLTP19RksWs=; b=FLB4PQsVv7VYThUfvwPItqZu3bZsrVxQ9ph5j0dIE2QWpDWEDcGkelKw1v1RPMU8mx IvWnojj1EDWY9Gn8mlXU+ljAd6iGkdvnvyS/ixApARbbVDZ6Y84JVzcDAfqChZZu2zp1 ou+Ij4O4H1CyU+7iDw8yIxuRw1jFyP8OYSN0x6mOa8PwPKcGK86M/BBxV9O+yrHWmecN /CDBbAsHvNSgP0/Jvg3QH6mzxk0LKMElp0MnUjq0TzYWTAr95KKORKucUpcYE0TKFBF9 qEz61DDr+cJ/627I+arM/G4JMuHXc4nW4pRSxdJyHhq+irOv8JEM/O88Rzhi9oqlUPMT nDrQ== X-Gm-Message-State: APjAAAUh6jyKvOVBHYXF604/V6TUHP1Oh98ANM8dUFpoJzlDCS9wWnHw VYSOmIOh4cADqnhHPb6iVbqZFC4nZsPrHylPk7ykt4f4 X-Google-Smtp-Source: APXvYqz21hDDLTuwfCPgWMd1PWd51RMQBiiHEgpNhcaO/pbk1QY5xm7oi4GLc2UlIBBD/CvSITDnMCMSdwZmdvFjzM8= X-Received: by 2002:aed:2050:: with SMTP id 74mr39281204qta.217.1577904723232; Wed, 01 Jan 2020 10:52:03 -0800 (PST) MIME-Version: 1.0 References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> In-Reply-To: <20200101163446.5132-4-ludo@gnu.org> From: zimoun Date: Wed, 1 Jan 2020 19:51:50 +0100 Message-ID: Subject: Re: [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Nice proposal! On Wed, 1 Jan 2020 at 17:36, Ludovic Court=C3=A8s wrote: > +Committers are expected to have had some interactions with you as a > +contributor and to be able to judge whether you are sufficiently > +familiar with the project's practices. It is @emph{not} a judgment on > +the quality of your work, so a refusal should rather be interpreted as > +``let's try again later''. Cutting the hairs: on one hand "be able to judge" on practices and on the other hand "not a judgment on the quality". Even if I understand the idea behind (I guess), I do not find it well worded, if I might. I mean, I bet that "the quality of work" is a strong part when motivating the acceptance or the refusal, so yes it is "a judgment on the quality of your work" (but not only). Quality implies standards and practices; quality can be measured (more or less). From my understanding. Instead of 'quality', I propose 'value' which is more subjective. Well, my English is not very good... > +However, note that the project is working towards a more automated patch > +review and merging system, which, as a consequence, may lead us to have > +fewer people with commit access to the main repository. Stay tuned! > +@end quotation I find inappropriate the "Stay tuned!" in the manual. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 23:09:54 2020 Received: (at 38846) by debbugs.gnu.org; 2 Jan 2020 04:09:54 +0000 Received: from localhost ([127.0.0.1]:37937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imro2-0002DD-9F for submit@debbugs.gnu.org; Wed, 01 Jan 2020 23:09:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imro1-0002D2-Bk for 38846@debbugs.gnu.org; Wed, 01 Jan 2020 23:09:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imrnv-00016s-BJ; Wed, 01 Jan 2020 23:09:47 -0500 Received: from [2605:6000:1a0d:4c95::3d] (port=41960 helo=oryx) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imrnu-00017L-U2; Wed, 01 Jan 2020 23:09:47 -0500 From: Brett Gilio To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> Date: Wed, 01 Jan 2020 22:09:47 -0600 In-Reply-To: <20200101163446.5132-4-ludo@gnu.org> ("Ludovic \=\?utf-8\?Q\?Cour\?\= \=\?utf-8\?Q\?t\=C3\=A8s\=22's\?\= message of "Wed, 1 Jan 2020 17:34:46 +0100") Message-ID: <87blrmjy7o.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: guix-maintainers@gnu.org, 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s writes: > +Find three committers who would vouch for you, emailing a signed > +statement to @email{guix-maintainers@@gnu.org} (a private alias for the > +collective of maintainers). You can view the list of committers at > +@url{https://savannah.gnu.org/project/memberlist.php?group=3Dguix}. > + > +Committers are expected to have had some interactions with you as a > +contributor and to be able to judge whether you are sufficiently > +familiar with the project's practices. It is @emph{not} a judgment on > +the quality of your work, so a refusal should rather be interpreted as > +``let's try again later''. Maybe it is superfluous, because maintainers have the final say anyways. But I think getting vouching approval by three committers and one maintainer would be a fine idea. Wdyt? --=20 Brett M. Gilio GNU Guix, Contributor | GNU Project, Webmaster [DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE] From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 06:15:51 2020 Received: (at 38846) by debbugs.gnu.org; 2 Jan 2020 11:15:51 +0000 Received: from localhost ([127.0.0.1]:38297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imySE-0007xk-V9 for submit@debbugs.gnu.org; Thu, 02 Jan 2020 06:15:51 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imySD-0007xd-JW for 38846@debbugs.gnu.org; Thu, 02 Jan 2020 06:15:50 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1577963745; cv=none; d=zohomail.com; s=zohoarc; b=dRGT4MtgrkFgZjpB6Lu5EWVeAI/4Zcq4aTspsrQdOuuBTx2Hpn+5oAq17R43daJ/UjWZuhS/pywwTLrFr7+rhWGZgtWNkY3ErQti9F3t9e3O9lC6arDUVv6aRClbcvGvm981D/jqyuUgb0lp+cG12Iv49J1urZ51aUVqc2kZMco= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577963745; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=qmroKUcQHeDUhDR0iTuenqWq1Skopz+yU6JWSwIX18g=; b=JNZK9ldsJikr3C1MhV4/nhq+HNNlJR/yUzzL+4yVs6wj00TENpTUq4YEZCXfRmi+VtuFiD+jH9Wz+liZpsxTtvFs2RtrCHGKxAk3tpLp4Ij9EV7DgIIuF/WkH/X5xl6pFapmfsFfpFQDLXsWseHWl0LSjH0Rr+VlBcBNsfW+mvU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1577963745; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=qmroKUcQHeDUhDR0iTuenqWq1Skopz+yU6JWSwIX18g=; b=X6Jsnxz/7qlvj3Bl4MjO9DWgYEO6f5i2l3WExE+5MAvqyxEvJoVvVAcsiG5kLLw/ FSLZHuux6MU6t78pnjFL2wyol5WWX2CoaULIzQxagbv9dYwBx8OsV5wFfq2uwf76Ok3 EveHnO7T8bGNZy9OWVEftvjWe0B+zU46gP+U3pZA= Received: from localhost (p54AD4E05.dip0.t-ipconnect.de [84.173.78.5]) by mx.zohomail.com with SMTPS id 1577963742093141.4401892607625; Thu, 2 Jan 2020 03:15:42 -0800 (PST) References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> <87blrmjy7o.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Ricardo Wurmus To: Brett Gilio Subject: Re: [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. In-reply-to: <87blrmjy7o.fsf@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 02 Jan 2020 12:15:38 +0100 Message-ID: <874kxe3y91.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , guix-maintainers@gnu.org, 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Brett Gilio writes: > Ludovic Court=C3=A8s writes: > >> +Find three committers who would vouch for you, emailing a signed >> +statement to @email{guix-maintainers@@gnu.org} (a private alias for the >> +collective of maintainers). You can view the list of committers at >> +@url{https://savannah.gnu.org/project/memberlist.php?group=3Dguix}. >> + >> +Committers are expected to have had some interactions with you as a >> +contributor and to be able to judge whether you are sufficiently >> +familiar with the project's practices. It is @emph{not} a judgment on >> +the quality of your work, so a refusal should rather be interpreted as >> +``let's try again later''. > > Maybe it is superfluous, because maintainers have the final say > anyways. But I think getting vouching approval by three committers and > one maintainer would be a fine idea. One long term goal is to reduce the dictatorial powers of maintainers and shift more towards finding consensus or seeking consent. Maintainers can=E2=80=99t know every new contributor, but they probably know the committers who vouch for the new contributor. -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 06:20:40 2020 Received: (at 38846) by debbugs.gnu.org; 2 Jan 2020 11:20:40 +0000 Received: from localhost ([127.0.0.1]:38301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imyWt-00084n-Jv for submit@debbugs.gnu.org; Thu, 02 Jan 2020 06:20:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imyWq-00084Y-Q7 for 38846@debbugs.gnu.org; Thu, 02 Jan 2020 06:20:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imyWl-0004oP-JL; Thu, 02 Jan 2020 06:20:31 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=49592 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imyWj-0001OY-1P; Thu, 02 Jan 2020 06:20:31 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Ricardo Wurmus Subject: Re: [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> <87v9pvm4a3.fsf@elephly.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 =?utf-8?Q?Niv=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 02 Jan 2020 12:20:27 +0100 In-Reply-To: <87v9pvm4a3.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 01 Jan 2020 19:15:48 +0100") Message-ID: <87o8vmw1dw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: guix-maintainers@gnu.org, 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! Ricardo Wurmus skribis: > Ludovic Court=C3=A8s writes: > >> DRAFT: Subject to discussion! >> >> * doc/contributing.texi (Commit Access): Draft a cooptation policy. > > I like this! > >> +Find three committers who would vouch for you, emailing a signed >> +statement to @email{guix-maintainers@@gnu.org} (a private alias for the >> +collective of maintainers). You can view the list of committers at >> +@url{https://savannah.gnu.org/project/memberlist.php?group=3Dguix}. > > I misinterpreted this to mean that the three committers would need to > sign their endorsement=E2=80=A6 That=E2=80=99s actually what I meant, but perhaps this is ambiguous? >> + >> +@item >> +Send @email{guix-maintainers@@gnu.org} a signed message stating your >> +intent, listing the three committers who support your application, and >> +giving the fingerprint of the OpenPGP key you will use to sign commits >> +(see below). > > I think it may be necessary to state that =E2=80=9Csigned=E2=80=9D means = the use of a > cryptographic signature here and not just =E2=80=9C~~ Rekado=E2=80=9D (as= it would be > done on the Wikipedia for example). Perhaps we could link to the email > self defense guide of the FSF? > > https://emailselfdefense.fsf.org/en/ Good points. Taking these comments into accounts, I get: --8<---------------cut here---------------start------------->8--- @enumerate @item Find three committers who would vouch for you. You can view the list of committers at @url{https://savannah.gnu.org/project/memberlist.php?group=3Dguix}. Each of them should email a statement to @email{guix-maintainers@@gnu.org} (a private alias for the collective of maintainers), signed with their OpenPGP key. Committers are expected to have had some interactions with you as a contributor and to be able to judge whether you are sufficiently familiar with the project's practices. It is @emph{not} a judgment on the quality of your work, so a refusal should rather be interpreted as ``let's try again later''. @item Send @email{guix-maintainers@@gnu.org} a message stating your intent, listing the three committers who support your application, signed with the OpenPGP key you will use to sign commits, and giving its fingerprint (see below). See @uref{https://emailselfdefense.fsf.org/en/}, for an introduction to public-key cryptography with GnuPG. @item Once you've been given access, please send a message to @email{guix-devel@@gnu.org} to say so, again signed with the OpenPGP key you will use to sign commits. That way, everyone can notice and ensure you control that OpenPGP key. @c TODO: Add note about adding the fingerprint to the list of authorized @c keys once that has stabilized. @item Make sure to read the rest of this section and... profit! @end enumerate --8<---------------cut here---------------end--------------->8--- Thanks for your feedback! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 06:51:22 2020 Received: (at 38846) by debbugs.gnu.org; 2 Jan 2020 11:51:22 +0000 Received: from localhost ([127.0.0.1]:38334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imz0b-0000TP-OY for submit@debbugs.gnu.org; Thu, 02 Jan 2020 06:51:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imz0a-0000TC-9U for 38846@debbugs.gnu.org; Thu, 02 Jan 2020 06:51:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imz0U-0005tf-3H; Thu, 02 Jan 2020 06:51:14 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=49622 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imz0R-0006KX-Gn; Thu, 02 Jan 2020 06:51:13 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: [bug#38846] [PATCH 1/4] doc: Add "Tracking Bugs and Patches" section. References: <20200101162945.4946-1-ludo@gnu.org> <20200101163446.5132-1-ludo@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 =?utf-8?Q?Niv=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 02 Jan 2020 12:51:10 +0100 In-Reply-To: (zimoun's message of "Wed, 1 Jan 2020 19:18:38 +0100") Message-ID: <8736cyvzyp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Simon, zimoun skribis: > On Wed, 1 Jan 2020 at 17:36, Ludovic Court=C3=A8s wrote: >> >> * doc/contributing.texi (Tracking Bugs and Patches): New section. >> (Submitting Patches): Refer to it. >> * doc/guix.texi: Update copyright line. >> * HACKING (Using emacs-debbugs): Remove. >> --- >> HACKING | 11 +------- >> doc/contributing.texi | 62 ++++++++++++++++++++++++++++++++++++++----- >> doc/guix.texi | 2 +- >> 3 files changed, 58 insertions(+), 17 deletions(-) >> >> diff --git a/HACKING b/HACKING >> index 2f0f93f896..eeea2f6311 100644 >> --- a/HACKING >> +++ b/HACKING >> @@ -2,7 +2,7 @@ >> >> #+TITLE: Hacking GNU Guix and Its Incredible Distro >> >> -Copyright =C2=A9 2012, 2013, 2014, 2016, 2017, 2019 Ludovic Court=C3=A8= s >> +Copyright =C2=A9 2012, 2013, 2014, 2016, 2017, 2019, 2020 Ludovic Court= =C3=A8s >> Copyright =C2=A9 2015, 2017 Mathieu Lirzin >> Copyright =C2=A9 2017 Leo Famulari >> Copyright =C2=A9 2017 Arun Isaac >> @@ -63,12 +63,3 @@ after two weeks, and if you=E2=80=99re confident, it= =E2=80=99s OK to commit. >> >> That last part is subject to being adjusted, allowing individuals to co= mmit >> directly on non-controversial changes on parts they=E2=80=99re familiar= with. >> - >> -* Using emacs-debbugs >> - >> -Bug reports and patches are tracked using debbugs. If you are on emacs,= you >> -can use emacs-debbugs. >> - >> -List all open bug reports on guix-patches with >> - >> -C-u M-x debbugs-gnu guix-patches n y > > I thought the policy about copyright was when adding/changing lines, > not when removing them. > > https://lists.gnu.org/archive/html/guix-devel/2019-10/msg00473.html > > Maybe I miss something. > Just to notice. Ah well, I have (add-hook 'write-file-functions 'copyright-update), which took care of it. :-) Some projects (such as Gnulib) automatically update copyright years each 1st of January, so there are different practices. But anyway, you=E2=80=99= re right that it=E2=80=99s a bit odd to add a new year here, I=E2=80=99ll remo= ve it. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 06:54:05 2020 Received: (at 38846) by debbugs.gnu.org; 2 Jan 2020 11:54:05 +0000 Received: from localhost ([127.0.0.1]:38338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imz3F-0000XJ-7P for submit@debbugs.gnu.org; Thu, 02 Jan 2020 06:54:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imz3D-0000Wp-OG for 38846@debbugs.gnu.org; Thu, 02 Jan 2020 06:54:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imz38-00014U-Hm; Thu, 02 Jan 2020 06:53:58 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=49624 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imz37-0006Q2-U8; Thu, 02 Jan 2020 06:53:58 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 =?utf-8?Q?Niv=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 02 Jan 2020 12:53:56 +0100 In-Reply-To: (zimoun's message of "Wed, 1 Jan 2020 19:51:50 +0100") Message-ID: <87y2uqul9n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! zimoun skribis: > On Wed, 1 Jan 2020 at 17:36, Ludovic Court=C3=A8s wrote: > >> +Committers are expected to have had some interactions with you as a >> +contributor and to be able to judge whether you are sufficiently >> +familiar with the project's practices. It is @emph{not} a judgment on >> +the quality of your work, so a refusal should rather be interpreted as >> +``let's try again later''. > > Cutting the hairs: on one hand "be able to judge" on practices and on > the other hand "not a judgment on the quality". > Even if I understand the idea behind (I guess), I do not find it well > worded, if I might. > I mean, I bet that "the quality of work" is a strong part when > motivating the acceptance or the refusal, so yes it is "a judgment on > the quality of your work" (but not only). > Quality implies standards and practices; quality can be measured (more > or less). From my understanding. > > Instead of 'quality', I propose 'value' which is more subjective. I agree that =E2=80=9Cvalue=E2=80=9D sounds more appropriate here. Fixed! >> +However, note that the project is working towards a more automated patch >> +review and merging system, which, as a consequence, may lead us to have >> +fewer people with commit access to the main repository. Stay tuned! >> +@end quotation > > I find inappropriate the "Stay tuned!" in the manual. Because it=E2=80=99s too informal, or because it=E2=80=99s confusing? (The= former is fine with me.) Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 06:59:35 2020 Received: (at 38846) by debbugs.gnu.org; 2 Jan 2020 11:59:35 +0000 Received: from localhost ([127.0.0.1]:38342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imz8Y-0000ef-UJ for submit@debbugs.gnu.org; Thu, 02 Jan 2020 06:59:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imz8X-0000eT-L4 for 38846@debbugs.gnu.org; Thu, 02 Jan 2020 06:59:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imz8R-0001WW-Na; Thu, 02 Jan 2020 06:59:27 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=49626 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imz8P-0006zc-20; Thu, 02 Jan 2020 06:59:26 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Brett Gilio Subject: Re: [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> <87blrmjy7o.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 =?utf-8?Q?Niv=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 02 Jan 2020 12:59:22 +0100 In-Reply-To: <87blrmjy7o.fsf@gnu.org> (Brett Gilio's message of "Wed, 01 Jan 2020 22:09:47 -0600") Message-ID: <87png2ul0l.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: guix-maintainers@gnu.org, 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Brett, Brett Gilio skribis: > Ludovic Court=C3=A8s writes: > >> +Find three committers who would vouch for you, emailing a signed >> +statement to @email{guix-maintainers@@gnu.org} (a private alias for the >> +collective of maintainers). You can view the list of committers at >> +@url{https://savannah.gnu.org/project/memberlist.php?group=3Dguix}. >> + >> +Committers are expected to have had some interactions with you as a >> +contributor and to be able to judge whether you are sufficiently >> +familiar with the project's practices. It is @emph{not} a judgment on >> +the quality of your work, so a refusal should rather be interpreted as >> +``let's try again later''. > > Maybe it is superfluous, because maintainers have the final say > anyways. But I think getting vouching approval by three committers and > one maintainer would be a fine idea. The way I see it, it=E2=80=99s more about notifying maintainers than it=E2= =80=99s about asking them for approval; they could refuse someone, but the idea is they=E2=80=99d usually do what other people agreed on. Cooptation may allow us to scale better: it=E2=80=99s easy for maintainers = to simply lose track of who has been working on what and who should be given commit access. Thanks for your feedback, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 13:35:44 2020 Received: (at 38846) by debbugs.gnu.org; 2 Jan 2020 18:35:44 +0000 Received: from localhost ([127.0.0.1]:40008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1in5Jw-0004bx-9h for submit@debbugs.gnu.org; Thu, 02 Jan 2020 13:35:44 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:35527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1in5Jv-0004bk-5B for 38846@debbugs.gnu.org; Thu, 02 Jan 2020 13:35:43 -0500 Received: by mail-qt1-f196.google.com with SMTP id e12so35301823qto.2 for <38846@debbugs.gnu.org>; Thu, 02 Jan 2020 10:35:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=IwyFoROUC2Ug8WnT9Jy9ep4/OJcLh8y1y8Yy3YmqwG0=; b=kptcdpsTDU9r0mbXBDkiHJqYphtkyxXWyJYdteRxlOrEn4yLUhziDgR6xBvgByD6XV J0uEg0RlExtZDy5O3YKxarVM2RRUuFfCd8/xEPIaupgz/45z4XLkvIyCmowk+AZ6vHSG HJaGS0zeKlmeBiHLMcvWt10b0gBh6KR71EeVh9eSsWF1tf2HbV5JPTK3Hgf4yorBhcGp J+JV+HjFbaPkNBG+T8WIqOkOHVfk9LYur2E8lO2Qp1k1EXt+ymfFn7hzafa4K1iVzhO3 FKvCV17uQXmon3cpPT8SzNRZ6WaRsjLLd1AQZJph8NFAYLuQDSwrATEdpcF2Tvw2Dp5G YDqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=IwyFoROUC2Ug8WnT9Jy9ep4/OJcLh8y1y8Yy3YmqwG0=; b=o1xgFRKXYkdNBR+qbl4lUJnTnS8X/6L6pBBXk//CQwPZ2JmXiG3+VcMBw/KmstoUCQ Ho6YiiSxQlt87+UEhCV+KMWBIkqrP+pmad/SAocQIIdThfF/eFzM/FAWxzKvzt5oOSiO pNzZQFtZ+/Bud1DtUTougBN/1oSJjxakjsuu9TzEhkTNEuLj0tBHyUtcDAjVLK+g4KXX 0UfT7tYizHepE4uPYgxKJ5BUT/eySkwx9OXd7U6Om5HNPh3Abb7a2aFmLK3I+U7+dQ41 51t+rC2fkSk3z5KTzqd3k2F5WUqmVHzqGyaaluI0T4NN2DJ8HSNjiIFAkCPafbNzN6Ag PHMw== X-Gm-Message-State: APjAAAVAXX0bHxOvzOKHWKTc9GzMVS/xliqM6aP/gN87SmLFOg4+O0kt NwmPBGlgblZpE8GuieNwA7HF2O/zy65sWvX7B4c= X-Google-Smtp-Source: APXvYqyx0h+57Ui94SSTdehG1GBUG47iwrUMxbME3w2G10Qx1FMvu3Fi//2C8lhDrc61TCNFpBKG+TzBrNK6PlkDteI= X-Received: by 2002:aed:36e5:: with SMTP id f92mr3041253qtb.354.1577990137734; Thu, 02 Jan 2020 10:35:37 -0800 (PST) MIME-Version: 1.0 References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> <87y2uqul9n.fsf@gnu.org> In-Reply-To: <87y2uqul9n.fsf@gnu.org> From: zimoun Date: Thu, 2 Jan 2020 19:35:26 +0100 Message-ID: Subject: Re: [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo, On Thu, 2 Jan 2020 at 12:53, Ludovic Court=C3=A8s wrote: > zimoun skribis: > > I find inappropriate the "Stay tuned!" in the manual. > > Because it=E2=80=99s too informal, or because it=E2=80=99s confusing? (T= he former is > fine with me.) Maybe a bit of both. :-) It is an analogy, but I feel the same than if I read a manual of maths with "stay tuned" after a theorem as the proof. I feel in the same time not enough formal for a manual and I am confused: is it already proved and not written down yet or is it not proven yet? Well, it is my feedback when I read it. :-) And I feel cutting the hair in small pieces... French bias. ;-) Thank you for the initiative. Cool! All the best, simon From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 13:40:29 2020 Received: (at 38846) by debbugs.gnu.org; 2 Jan 2020 18:40:29 +0000 Received: from localhost ([127.0.0.1]:40016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1in5OX-0004io-2B for submit@debbugs.gnu.org; Thu, 02 Jan 2020 13:40:29 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:34892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1in5OV-0004ib-R3 for 38846@debbugs.gnu.org; Thu, 02 Jan 2020 13:40:28 -0500 Received: by mail-qt1-f196.google.com with SMTP id e12so35310698qto.2 for <38846@debbugs.gnu.org>; Thu, 02 Jan 2020 10:40:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=l5C/gQOYCECn7AkMV4hG6ipKj1iVWSmfcPcXj3IxWfk=; b=ZQnkqzKc2nx2AoCvfW69psZg8AZqOd1uLHPW3hQ++sKfVH8t/uqv3nC+jG12ntS5+9 0Y89RB5hzYY0YNBiOdp3U4yDi7y7nGMibk1v+rS2Xx0HkEtu8L1KBlu3Z/3qaAUpHsA8 Wgu4SDapTNrTH5Bslgny5Fu+rA7feQCWDkSdwXTgu8LQZr5cxThBnEiY9Bq9qd2uSU2i dcn0H9szaHh5BwzjB1xX02nAEjd4Hhh9Q6kPCdJB8X0WiQKmIE3SOjPXoH/NEssNoKfc obbbtjhDf37oTIMExVVuJx526ppYi2O6Z1WkE9nxuq24iG3vYbZBsKN470EI2n9JiD+C 6LNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=l5C/gQOYCECn7AkMV4hG6ipKj1iVWSmfcPcXj3IxWfk=; b=Bq2r0ODW1o/Rx53mUSf/ZJ24vWsLFfd/dynCmDk8+R6XsOVBDunp+Apw7fdeYD+vbP wXky8heuMj3WiUhlzagYKMR0Qg/DU8Lljc/xhvsNjl2a6GVvTuvQgK5Ut+g/f39GuaYr bOBE89qDF2rB/9c4phSbKq0qyvnBStxrMWACvzfIS17BVwwbqb7/Zka5n/iwCPJ45aEK IqQ0UxJaidMHNACvGuD267V0lmOXnn4ReF7i36UIJINkwildhokeCN1CMOjMwFGy0wlD N/VEuMwv2+1o965Y0TvHBLdfuZJhEMf8DZebWJYcHs66LtomXT8s0ChM4enJUBk7wYUb w2iA== X-Gm-Message-State: APjAAAXonkle0rNncqqv697g2Bb+DfBLDMMVKSG4TRQtB+ouFOpmQqbX +E4MsPxG7tlceA5iYRLgyNjStDQtPdhjuGmxhzo= X-Google-Smtp-Source: APXvYqw7hnCSQNOBVQ5dEQrEkv1FXXNRQ8jolOw+Tk61Ya2Yn8lAH37tw6eobaOI1p2LydwjJRVp03jw+xQRgrLaPBs= X-Received: by 2002:aed:2fa1:: with SMTP id m30mr48294985qtd.211.1577990422559; Thu, 02 Jan 2020 10:40:22 -0800 (PST) MIME-Version: 1.0 References: <20200101162945.4946-1-ludo@gnu.org> <20200101163446.5132-1-ludo@gnu.org> <8736cyvzyp.fsf@gnu.org> In-Reply-To: <8736cyvzyp.fsf@gnu.org> From: zimoun Date: Thu, 2 Jan 2020 19:40:10 +0100 Message-ID: Subject: Re: [bug#38846] [PATCH 1/4] doc: Add "Tracking Bugs and Patches" section. To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo, On Thu, 2 Jan 2020 at 12:51, Ludovic Court=C3=A8s wrote: > Ah well, I have (add-hook 'write-file-functions 'copyright-update), > which took care of it. :-) Ah cool! I did not know this neat function. :-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 04:30:31 2020 Received: (at 38846) by debbugs.gnu.org; 6 Jan 2020 09:30:31 +0000 Received: from localhost ([127.0.0.1]:45029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioOiU-0004ae-SS for submit@debbugs.gnu.org; Mon, 06 Jan 2020 04:30:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioOiS-0004aQ-Ln for 38846@debbugs.gnu.org; Mon, 06 Jan 2020 04:30:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ioOiK-0008CB-Jf; Mon, 06 Jan 2020 04:30:21 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=57544 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ioOiB-0007Zt-01; Mon, 06 Jan 2020 04:30:18 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> <87y2uqul9n.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 =?utf-8?Q?Niv=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 06 Jan 2020 10:30:08 +0100 In-Reply-To: (zimoun's message of "Thu, 2 Jan 2020 19:35:26 +0100") Message-ID: <87sgktdja7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! zimoun skribis: > On Thu, 2 Jan 2020 at 12:53, Ludovic Court=C3=A8s wrote: > >> zimoun skribis: > >> > I find inappropriate the "Stay tuned!" in the manual. >> >> Because it=E2=80=99s too informal, or because it=E2=80=99s confusing? (= The former is >> fine with me.) > > Maybe a bit of both. :-) > > It is an analogy, but I feel the same than if I read a manual of maths > with "stay tuned" after a theorem as the proof. I feel in the same > time not enough formal for a manual and I am confused: is it already > proved and not written down yet or is it not proven yet? Heh. Well I guess it doesn=E2=80=99t bring much anyway, we can remove it. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 08:13:17 2020 Received: (at 38846) by debbugs.gnu.org; 6 Jan 2020 13:13:17 +0000 Received: from localhost ([127.0.0.1]:45311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioSC4-0003xs-RS for submit@debbugs.gnu.org; Mon, 06 Jan 2020 08:13:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioSC3-0003xd-1J for 38846@debbugs.gnu.org; Mon, 06 Jan 2020 08:13:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ioSBu-0001Y7-Dc; Mon, 06 Jan 2020 08:13:06 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=58324 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ioSBt-0002Zx-At; Mon, 06 Jan 2020 08:13:05 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: guix-maintainers@gnu.org Subject: Re: [bug#38846] [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access References: <20200101162945.4946-1-ludo@gnu.org> Date: Mon, 06 Jan 2020 14:13:03 +0100 In-Reply-To: <20200101162945.4946-1-ludo@gnu.org> ("Ludovic \=\?utf-8\?Q\?Cour\?\= \=\?utf-8\?Q\?t\=C3\=A8s\=22's\?\= message of "Wed, 1 Jan 2020 17:29:45 +0100") Message-ID: <875zhod8yo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! Just a heads-up for fellow maintainers (Tobias, Marius, Maxim): could you send a =E2=80=9C+1=E2=80=9D or whatever you deem appropriate :-) to thi= s discussion? I=E2=80=99d like to make sure we=E2=80=99re on the same page. https://issues.guix.gnu.org/issue/38846 Ludo=E2=80=99. Ludovic Court=C3=A8s skribis: > Hello Guix! > > Happy new year, merry 12 niv=C3=B4se, or whatever celebration is > appropriate for you! :-) > > These patches do three things: > > 1. Move text from =E2=80=98HACKING=E2=80=99 to =E2=80=98doc/contributin= g.texi=E2=80=99. > > 2. Encourage patch review for committers. > > 3. Add a tentative policy for granting commit access (the last > patch of this series). > > I expect #1 and #2 to be uncontroversial, but I=E2=80=99d like feedback o= n #3! > > So far, we=E2=80=99ve been giving commit access in a very ad-hoc fashion. > Often it was Ricardo or myself who ended up taking care of that, > even though other people have admin rights on Savannah to add/remove > members. > > We briefly discussed it among maintainers after the maintainer > collective expanded, and it seems to me that perhaps now is a good time > to formalize things a bit=E2=80=94to clarify what contributors may expect= and > to increase transparency. Hence this proposal of a simple co-optation > policy. > > As you know, Chris Baines has been working towards automated testing > of submitted patches. One of the goals is to allow part of the > QA to be automated, such that, eventually, approved merges could be > automated. In that spirit, we would have an incentive to not add more > committers (probably also a good thing security-wise). That=E2=80=99s wh= y I > added a note on this topic. > > What do people think? > > Thanks, > Ludo=E2=80=99. > > Ludovic Court=C3=A8s (4): > doc: Add "Tracking Bugs and Patches" section. > doc: Move "Commit Access" section from 'HACKING' to the manual. > doc: Encourage patch review. > DRAFT doc: Add a cooption policy for commit access. > > HACKING | 58 +------------- > doc/contributing.texi | 171 ++++++++++++++++++++++++++++++++++++++++-- > doc/guix.texi | 2 +- > 3 files changed, 168 insertions(+), 63 deletions(-) From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 16:44:58 2020 Received: (at 38846) by debbugs.gnu.org; 6 Jan 2020 21:44:58 +0000 Received: from localhost ([127.0.0.1]:46920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioaBF-0002kR-Sl for submit@debbugs.gnu.org; Mon, 06 Jan 2020 16:44:58 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:33105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioaBD-0002kD-Dp for 38846@debbugs.gnu.org; Mon, 06 Jan 2020 16:44:56 -0500 Received: by mail-qt1-f194.google.com with SMTP id d5so43709063qto.0 for <38846@debbugs.gnu.org>; Mon, 06 Jan 2020 13:44:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=EA5i+zORXpR1vc/Bg1VzO5sxSVwX3zSqmbyEd/RcdqQ=; b=udwqBdORY3y3DMmaadzN5PUX3NkANhn60C77jhTJlCKD1C8NSbft0NalLwGxZSb392 ArkT5LWyCthho4ADODlEJzyhQ30r3Z7TCJBxlAsXKOO92NZMaKiykPaDRPg7T8b6tYzS R/88mepl2h4stV98OUpzKLGySL6s0//WRgG1e3XFXYquX0usTmtsr6BBFOqoQvw9cs7a uRpYjbPEw1ctgpDB9tyYbcA/pfIdlz71VxkoBSpv97/ImsF30Lraqqh5f43YGdLebFxp wXnLvnf3D5NsjUzde/FHTp5uem5Sl0hyjfsoASbMuV9c8cYiWAslp0F9/kLyo9/dphs6 BHGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EA5i+zORXpR1vc/Bg1VzO5sxSVwX3zSqmbyEd/RcdqQ=; b=P/KtNtsPDY2iT7QX9V7WRKPyghRLPDuXvRnUFIpexJucPI0q3ancImwqjDHSMWVCrQ sd3ZcheFYW8BYOE6w/OI919WubrdkK+HIw7/PjK/AhGYyn7tPWjz3lk9Kaf5CcO4aT4g nV6I5NppGn5pi0LfPwZiHtDygkhr67R/pfNMuSPfeGBGijuc1A/+iZryzQgOz3I97yTR xWwY5jYzoTDEUUgvKbGf9Ro+ZlMWH9yQXr5VkD1/tj0ti+Msiw6kvGjfedoDf7mxviSO bhPdR6wl4hEXKjo/9X5g7TUdpgV0KFBl/ITfNPhXJ3zSbqF9WLFvJO1ig6LAk0yE9ufo 44+Q== X-Gm-Message-State: APjAAAXVg4e+/BBPyst36IlRugKo4RVr/3uapBoNDbZYtqkKoObeXVv6 uU6xpEVYvOJOOg/uK0UZM7cIg7PE7nsh58V4Txw= X-Google-Smtp-Source: APXvYqyv14HV0tU7tGiJAiBp3WGdvLrd+p+YJH73NTXENfMDrjvETJozFFOFAMvwMRk0qJgFPgiCpbBQUYGy6yHzszw= X-Received: by 2002:aed:36e5:: with SMTP id f92mr19003908qtb.354.1578347089721; Mon, 06 Jan 2020 13:44:49 -0800 (PST) MIME-Version: 1.0 References: <20200101162945.4946-1-ludo@gnu.org> In-Reply-To: <20200101162945.4946-1-ludo@gnu.org> From: zimoun Date: Mon, 6 Jan 2020 22:44:38 +0100 Message-ID: Subject: Re: [bug#38846] [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: GNU Guix maintainers , 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Wed, 1 Jan 2020 at 17:31, Ludovic Court=C3=A8s wrote: > 1. Move text from =E2=80=98HACKING=E2=80=99 to =E2=80=98doc/contributin= g.texi=E2=80=99. > > 2. Encourage patch review for committers. > > 3. Add a tentative policy for granting commit access (the last > patch of this series). > > I expect #1 and #2 to be uncontroversial, but I=E2=80=99d like feedback o= n #3! > > So far, we=E2=80=99ve been giving commit access in a very ad-hoc fashion. > Often it was Ricardo or myself who ended up taking care of that, > even though other people have admin rights on Savannah to add/remove > members. > > We briefly discussed it among maintainers after the maintainer > collective expanded, and it seems to me that perhaps now is a good time > to formalize things a bit=E2=80=94to clarify what contributors may expect= and > to increase transparency. Hence this proposal of a simple co-optation > policy. > > As you know, Chris Baines has been working towards automated testing > of submitted patches. One of the goals is to allow part of the > QA to be automated, such that, eventually, approved merges could be > automated. In that spirit, we would have an incentive to not add more > committers (probably also a good thing security-wise). That=E2=80=99s wh= y I > added a note on this topic. > > What do people think? Personally, I find this proposal nice. As I already said when commenting on each patch. :-) However, let point 2 minor weak points for further discussions: a- if the number of committers with access is more or less fixed, then access could be transferred (less active, less time, less motivation, etc.); and b- the bottleneck is the patch review (even if it should be improved in the future with the Guix Data Service). Well, a- is more about human relationship, hard to fix. However, we should work on b- but how? What does it mean "encourage patch review"? Candy or beer at Guix Days? ;-) For example, this patch [1] has fallen in the crack. Or this one [2] or this other one [3]. [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31973 [2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33041 [3] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33318 >From the v1.0.1 to now, the repartition of committers which are not the aut= hors: 361 78 65 61 59 54 52 47 44 43 37 21 (x2) 11 9 8 7 (x2) 6 5 (x3) 4 (x2) 3 2 (x3) 1 (x3) which should be compared to the number of commits per author also committer (first 10): 1463 1162 886 670 618 335 204 166 161 150 --8<---------------cut here---------------start------------->8--- # committer and not the author git log v1.0.1..origin/HEAD --pretty=3Dformat:"%an~%cn" \ | awk -F '~' '{if ($1 !=3D $2) {++cnt; print "#"$2};}' \ | sort \ | uniq -c \ | sort -nr \ | cut -f1 -d'#' --8<---------------cut here---------------end--------------->8--- --8<---------------cut here---------------start------------->8--- # committer and the author git log v1.0.1..origin/HEAD --pretty=3Dformat:"%an~%cn" \ | awk -F '~' '{if ($1 =3D=3D $2) {++cnt; print "#"$2};}' \ | sort \ | uniq -c \ | sort -nr \ | cut -f1 -d'#' | head -n10 --8<---------------cut here---------------end--------------->8--- It is easy to produce more stats, for the example the author time versus the committer time, or the number of newcomers (first commit), or the hour when committing. Do not take me wrong, it is not about blaming but it is about health and how it could be improved. All these numbers show how Guix is healthy. :-) Well, all this comment is about "2. Encourage patch review for committers.". Patch review is about trust, so what could be done to reduce the workload of "committers"? and smooth everything? Team and/or delegate? Formalize "maintainer per field" (R, Lisp, Python, OCaml, maths, etc.)? Obviously without adding too formal stuff. :-) All the best, simon From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 18:29:18 2020 Received: (at 38846) by debbugs.gnu.org; 6 Jan 2020 23:29:18 +0000 Received: from localhost ([127.0.0.1]:46982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioboE-0005Kg-Da for submit@debbugs.gnu.org; Mon, 06 Jan 2020 18:29:18 -0500 Received: from tobias.gr ([80.241.217.52]:34716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioboC-0005KV-E0 for 38846@debbugs.gnu.org; Mon, 06 Jan 2020 18:29:17 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id bf78497e; Mon, 6 Jan 2020 23:29:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=O5jcFjfh1CggvZiDq1UZp8 J51pQLAIwSNpxzZZl3hpo=; b=MCTFc30lH0dst5T51yQyubzUcucKB1qqoMR1Tc 0C9i5AUuYy6ZsCe0KKUFjiA5l86AM8OElhPRFyw3ueNV7rxe0k3XR1o77QSy4MLL 0gYSZejBvIxzHHEM00IlrGrvKkMXfFVxFqZsww7/anTyYOq0ME+gFf2bTsbjXjmS AfuwMJv80AAPMVZioqYQhxFtq2qusTYwQ9S/tSvSNu7pyh4H1/X0AVJQCXfKkjWj /MozVGZRJlBBBge9hbjclINO4zolwmFmP8eBdPUss+Y3JohazdivCy8Nl+7OBuXf FapR//YBj6OlMSImj+srzov04nh8Hq06DXUSWARKhwTnE4vA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 4c0cd64d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 6 Jan 2020 23:29:13 +0000 (UTC) From: Tobias Geerinckx-Rice To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> In-reply-to: <20200101163446.5132-4-ludo@gnu.org> Date: Tue, 07 Jan 2020 00:29:12 +0100 Message-ID: <87a770dv07.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: guix-maintainers@gnu.org, 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Ludo', Thank you for this series. Ludovic Court=C3=A8s =E5=86=99=E9=81=93=EF=BC=9A > +@item > +Send @email{guix-maintainers@@gnu.org} a signed message stating=20 > your > +intent, listing the three committers who support your=20 > application, and > +giving the fingerprint of the OpenPGP key you will use to sign=20 > commits > +(see below). > + > +@item > +Once you've been given access, please send a message to ^^^^ Probably just me, but this glosses over maintainer approval just a=20 bit too deftly, and that even with 3 signed referrals commit=20 access isn't guaranteed, just extremely likely. Unless that will actually change, I think we should briefly=20 mention it as well. People react worse to =E2=80=98let's try again later= =E2=80=99=20 when they think they've already passed. Understandably so. > +@email{guix-devel@@gnu.org} to say so, again signed with the=20 > OpenPGP key > +you will use to sign commits. That way, everyone can notice=20 > and ensure > +you control that OpenPGP key. Best to add an explicit =E2=80=98before pushing your first commit=E2=80=99 = here,=20 if that is the intent. > +When you get commit access, please make sure to follow ^^^^ =E2=80=98If=E2=80=99? Same point as the first @items above. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl4TwsgACgkQ2Imw8BjF STwFkhAAs11P+3coXRXkGGXzqaoGaZD3G2z8Dl67T82+/oDbHf7XZLJkoR7bHoHw 1blv0Q4zeKzy0NjLVfjXdHianaHdwrG0cTZMEHZhdxsponFxmRraqeqOCP8psITD BKq5EmNWvh+nCPtqxa2BK72J/PU7bD1F/Zq/WDurPEUdAdPxLuV54Sw6Qd8y28A8 PX2WPsMIsCs70l3naR27qvxBxol59xbRkbM72eSBAEXsB4J0r30qKwyHPd/05i1x 5iUcsO2lxfPXzb3rSLc6BRI/y227xCXrsfUkLNmtekpw/eZ9piPXU3l7b2PTTBdQ i/t94P4n6tIbvjh3RxqH4HFr2uQlS/PbxVxVeZGpA72HzC/+9bJ6XNza/jsZB8Nu ft9N4srCcFuBDcpVgyanNbnS83lqI9l79q3L81fkMEeLDoEzOOuhu3lS3nai3JfV e7G4jWotfrK9n6ejR8GlALyuVEdWeNefzvlrnBXhd1jv55habr4XZoNnuHh+8P3G bmW7Y0/3btjaAhi9k5TAgmteI0CYJvBvdKuaKCQQELuM/IyIXhCcMyGpdNMGyUKL bKcgEqqZ9NYM0jEXwpAA8qmwGFz+o8pVlDmvhtoYI1gult7N3hU2mVMqJooANOeS kct7UqGGk1pH9U/fWiryR/JAqbJS9mrdwQ74A7ASYtNLB4b6SSQ= =3/e/ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 18:34:57 2020 Received: (at 38846) by debbugs.gnu.org; 6 Jan 2020 23:34:57 +0000 Received: from localhost ([127.0.0.1]:46987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iobth-0005WV-33 for submit@debbugs.gnu.org; Mon, 06 Jan 2020 18:34:57 -0500 Received: from tobias.gr ([80.241.217.52]:35022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iobtf-0005WM-Fw for 38846@debbugs.gnu.org; Mon, 06 Jan 2020 18:34:55 -0500 Received: by tobias.gr (OpenSMTPD) with ESMTP id 9dcaa5db; Mon, 6 Jan 2020 23:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=0l7CJ8Nn5YmUoE4oLBwPFQ khbfEapS5VwGJajQcC2HE=; b=VPx4Cf5X2R2EP/wGnNJqxsAcgVnxw3dMYeslgv bcd7VWWzDVZg+/l0iPgttI581VMaBl4lWKqKwTWH6tK+Lk7gLd/sV14xYLsa4evT fAHDZgH4FC2xzLT28ITFAcLF3IhjzwxFe2A3PN080LatJyFI5Kfxkt7UtSzN4pp0 8aA2EyKQ6wa50SsFjtKEoDa68OljikNoM7EYk6hFi+r+oilRl5fCaOGqED1oUTdr ApR6uO/2PSotex+DfyRfkQNiBE1xT/s+recBxzchFTce2SEzrKLv6KvlmkxMiGUT xuND8dPuXn3hS8Nx8Q7MUcYk1jjmyXmk6tESy9Az6GqSpg2w== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 6f411d6c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 6 Jan 2020 23:34:53 +0000 (UTC) From: Tobias Geerinckx-Rice To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> <87a770dv07.fsf@nckx> In-reply-to: <87a770dv07.fsf@nckx> Date: Tue, 07 Jan 2020 00:34:52 +0100 Message-ID: <878smkduqr.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: guix-maintainers@gnu.org, 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice =E5=86=99=E9=81=93=EF=BC=9A > Ludo', > > Thank you for this series. Speaking of being explicit: LGTM! Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl4TxBwACgkQ2Imw8BjF STzdJA/+NqWlxInMex+1vMFMuGDJOHq9egfP7UQWfCRudnVnJ/fVXX1Qy1Sot7vC kQI3AZHeM8yneAa9gBYUOJNpAjcI5miisM2p/L2gWD/GIljwoi/puoyhKFUV8U/G /ROMK3wJ7Xz2G+2f9/+qZVcAfrngdgjCoPEFr4jEynyvAPIOOZZTMQNXyHcFQwcF Bj8hOLGM9NyLBNMi3xecQRUzSNqB7GkdptZyCbe28YMCZCpIOnjT42Nq/PziAsUX ILjRXU+DAZFIUfF0hxDTuYFq+ooORYXJdu4HOYa5p+N6eovYHEsYrR+Q8PZF9fmm 6magQ/5EV1LOo7uZBAndRSCUW7QBXQ1EHoZrEBVSfBd5MbWXoYU1jarJhwNxPB2h JX5KCAOoSKJVI4VCT3GKFBqi0ogXD306Ws5Rp0P3qS3Av5UE975vIrI2PKs33OG5 EqpOsVjddiZRGbMx51nIivHFH/sDDnqBE20+8qlqp8V8OZMj+d2G1j8/gQKbVw2O b0TdEtPt/ilN+kTDeoVrMJ2xxPKuJ/avWJ2+541ugoJ3n3FVSIa9m4s8ePvUdVPF K/j9l/kMPYm4YdsZVqwK+iix/hkNnQd83fU/5OCJg8jrudgF6Wacy84FYBClx6I5 FXY1uUK01zUmIvM8wQqWr5rALnX9F2rAPwCd9YjDepyjM390OSI= =Hfo3 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 19:18:58 2020 Received: (at submit) by debbugs.gnu.org; 7 Jan 2020 00:18:58 +0000 Received: from localhost ([127.0.0.1]:47039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iocaI-0006uW-3L for submit@debbugs.gnu.org; Mon, 06 Jan 2020 19:18:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:36859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iocaF-0006uN-Oj for submit@debbugs.gnu.org; Mon, 06 Jan 2020 19:18:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40346) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iocaD-00085k-FR for guix-patches@gnu.org; Mon, 06 Jan 2020 19:18:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=ALL_TRUSTED,BAYES_05, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iocaC-0002ek-Rt; Mon, 06 Jan 2020 19:18:52 -0500 Received: from [2605:6000:1a0d:4c95::3d] (port=49576 helo=oryx) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iocaC-0008Kg-FC; Mon, 06 Jan 2020 19:18:52 -0500 From: Brett Gilio To: Tobias Geerinckx-Rice via Guix-patches via Subject: Re: [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> <87a770dv07.fsf@nckx> Date: Mon, 06 Jan 2020 18:19:01 -0600 In-Reply-To: <87a770dv07.fsf@nckx> (Tobias Geerinckx-Rice via Guix-patches via's message of "Tue, 07 Jan 2020 00:29:12 +0100") Message-ID: <87woa486fe.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , guix-maintainers@gnu.org, 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Tobias Geerinckx-Rice via Guix-patches via writes: > Probably just me, but this glosses over maintainer approval just a bit > too deftly, and that even with 3 signed referrals commit access isn't > guaranteed, just extremely likely. > > Unless that will actually change, I think we should briefly mention it > as well. People react worse to =E2=80=98let's try again later=E2=80=99 w= hen they > think they've already passed. Understandably so. Hi Tobias, This is definitely not just you. I felt similarly, as per a previous email on the matter where I suggested that it be 3 commiters and 1 maintainer. But that process turned out to be redundant, if not completely superfluous by Ricardo's mention of how the process is likely to change in the future with a different integration model. Regardless, I hear your point. I also think that getting refused after achieving three referrals is a hard point. I think it should be documented clearly that the mainters have the final say. Additionally, and this is just a point for my part, depending on what kind of merit we are taking for credence in a committer making a referral, should we only consider committers who have worked closely with the person requesting commit access, or is somebody who has reviewed and seen their patches in passing also a viable subject? For example, I have been asked a few times by people to push patches for them over IRC, but their patches were unrelated to software I use / would use / know how to approach (examples being GNOME). So, I kindly refused to push their patch citing that I do not feel comfortable in knowledge to understand the ramifications of their patches. Hypothetically, if such a person approached me in the future and asked for a commit access referral, since I had not worked closely with them what kind of weight would be referral hold? I hope this makes sense. Maybe I am being overly nitpicky, I just really like clarity. :) --=20 Brett M. Gilio GNU Guix, Contributor | GNU Project, Webmaster [DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE] From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 06:17:41 2020 Received: (at 38846) by debbugs.gnu.org; 7 Jan 2020 11:17:41 +0000 Received: from localhost ([127.0.0.1]:47387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iomrl-0007fe-7P for submit@debbugs.gnu.org; Tue, 07 Jan 2020 06:17:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iomri-0007fP-Vg for 38846@debbugs.gnu.org; Tue, 07 Jan 2020 06:17:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iomrd-0002KJ-Pi; Tue, 07 Jan 2020 06:17:33 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=49192 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iomrd-00026w-5s; Tue, 07 Jan 2020 06:17:33 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: [bug#38846] [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access References: <20200101162945.4946-1-ludo@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 18 =?utf-8?Q?Niv=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 07 Jan 2020 12:17:31 +0100 In-Reply-To: (zimoun's message of "Mon, 6 Jan 2020 22:44:38 +0100") Message-ID: <87h817jz1w.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: GNU Guix maintainers , 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! zimoun skribis: > However, let point 2 minor weak points for further discussions: > > a- if the number of committers with access is more or less fixed, > then access could be transferred (less active, less time, less > motivation, etc.); Sure, we should (and do) remove people who =E2=80=9Cdisappeared=E2=80=9D or= retired, and of course welcome new people willing to participate. > and b- the bottleneck is the patch review (even if it should be > improved in the future with the Guix Data Service). > Well, a- is more about human relationship, hard to fix. However, we > should work on b- but how? What does it mean "encourage patch review"? > Candy or beer at Guix Days? ;-) Heh. :-) This is the hard part for all free software projects. As you noticed, there=E2=80=99s no shortage of patches that have fallen through the cracks, unfortunately. The =E2=80=9Cencourage patch review=E2=80=9D bit in this series, in my view= , is to tell newcomers that the deal is not just that they can push their own stuff more quickly, but also that they can help others get their stuff in in return. It may sound obvious to some, but it=E2=80=99s probably better if explicitly stated. Also, perhaps we=E2=80=99ve had the problem where commi= tters did not feel =E2=80=9Centitled=E2=80=9D to review and push other people=E2= =80=99s patches; this paragraph is also a way to tell them that yes, they _are_ entitled to that. It won=E2=80=99t solve the problem overnight; offering a beverage at the Gu= ix Days won=E2=80=99t solve it either but it=E2=80=99s a good idea anyway. :-) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 06:28:17 2020 Received: (at 38846) by debbugs.gnu.org; 7 Jan 2020 11:28:18 +0000 Received: from localhost ([127.0.0.1]:47400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ion21-000805-Ja for submit@debbugs.gnu.org; Tue, 07 Jan 2020 06:28:17 -0500 Received: from mail-qv1-f66.google.com ([209.85.219.66]:43926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ion1z-0007zs-L4 for 38846@debbugs.gnu.org; Tue, 07 Jan 2020 06:28:16 -0500 Received: by mail-qv1-f66.google.com with SMTP id p2so20333724qvo.10 for <38846@debbugs.gnu.org>; Tue, 07 Jan 2020 03:28:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=u1YfVIMNgd7X2GJ4qMr9MBp/Vb7dxajtDgDhrtxHtn8=; b=AXkBjWSlG+x3wZ8MyBLsyVN6c3t+2dHV7zfmGoVXbqZLDXVs7FIrL0KOp2SXvNDjcB +fnv/h0pTVdT+vDkqluYlHXbGkCj3C73Kp4nD7y/mHPj5488HMEwIaQR3UI8BR6UUuEm ONb0cIHHvDjLVUxebQpyNIorWCE1FV2P887X2OLbOxLKkcMHjSWRtLniMcwKydLRlzme MQhKmoLzo3hLg5VKeE7ANjY1kBgKLKm+fOK8Osn523B8muSUjh3q2G4wJ0nSKGtZ9ZJY /Bwzuh+Jw3s1y+gkT905SoPjfLKeCtxDzta17rq9BDcnc3mvYDxYV5LZbkhfH6Aa+aeK YFJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=u1YfVIMNgd7X2GJ4qMr9MBp/Vb7dxajtDgDhrtxHtn8=; b=q3fDs2CgXpW2eKBvUUIa1RdA8HpNtdULGdDNKXSzYbMDFDbZ8T/QUh2l09EuB+SJ4E NvbVqEBgmAayKM72oLtueM48SD0H0c3ou+ImL/XAo4ectYdS6tp5xny3MQ73D84CZJp0 yQEM4Yoc+XL1hkyVzwSlWOIxq97JGMpNy2eC+ED2DbeNrZSyGPbMwULsBDUPsuUUqunK r1KUl/qZu/Qw28sUCrhxhFzd4NLTTKop1LwDASs+qWk9MQpqC6/t+Z2bhQHkdK/ajc1X 3bphmj/kU0FrmLYQN1Ss2B6n/jSuuW4SelIPEzfIB+Y6ZwNwSbqJS+T1ebaE0xC05jG2 8lbQ== X-Gm-Message-State: APjAAAXheyPBQV50Je+otj3Fe/0mF7c2Uclz9tnPzQmaMnBaq73DOHiO 3Qa8pnJtNHmEnbx4FrcLT4Ryuoo08fT0EWS8sJbxzfKr X-Google-Smtp-Source: APXvYqzw7d59HhJOzyE0PgZ0X7PR/r0VTnc712OTLoJ+lSzNogV/MRxKJYANlG+Boa21M7fHvkziB1uSc1Dz3w871oc= X-Received: by 2002:a05:6214:3a1:: with SMTP id m1mr80547029qvy.77.1578396489949; Tue, 07 Jan 2020 03:28:09 -0800 (PST) MIME-Version: 1.0 References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> <87a770dv07.fsf@nckx> <87woa486fe.fsf@gnu.org> In-Reply-To: <87woa486fe.fsf@gnu.org> From: zimoun Date: Tue, 7 Jan 2020 12:27:58 +0100 Message-ID: Subject: Re: [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. To: Brett Gilio Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , Tobias Geerinckx-Rice , GNU Guix maintainers , 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, My end-user opinion does not matter. But the transparency is good. :-) On Tue, 7 Jan 2020 at 01:19, Brett Gilio wrote: > > Tobias Geerinckx-Rice via Guix-patches via > writes: > > > Probably just me, but this glosses over maintainer approval just a bit > > too deftly, and that even with 3 signed referrals commit access isn't > > guaranteed, just extremely likely. > > > > Unless that will actually change, I think we should briefly mention it > > as well. People react worse to =E2=80=98let's try again later=E2=80=99= when they > > think they've already passed. Understandably so. [...] > This is definitely not just you. I felt similarly, as per a previous > email on the matter where I suggested that it be 3 commiters and 1 > maintainer. But that process turned out to be redundant, if not > completely superfluous by Ricardo's mention of how the process is likely > to change in the future with a different integration model. I am not native English speaker so maybe I misread. From my understanding, the proposal clarifies how the access is granted. Currently, only the maintainers grant; from what I have observed, it is more because of historical reasons than an explicit model. The new integration model proposes to enforce the trust and goes to reduce/distribute the "power" of maintainers -- which is good IMHO. Therefore, the maintainers trust the current committers, and if 3 committers approve, why should 1 maintainer reject the applicant? It is a chain of trust. > Regardless, I hear your point. I also think that getting refused after > achieving three referrals is a hard point. I think it should be > documented clearly that the mainters have the final say. I do not see why. If 3 referrals vouch an applicant and 1 maintainer refuses, then there is an issue elsewhere. The chain of trust is broken and it means that the project is not healthy. > Additionally, and this is just a point for my part, depending on what > kind of merit we are taking for credence in a committer making a > referral, should we only consider committers who have worked closely > with the person requesting commit access, or is somebody who has > reviewed and seen their patches in passing also a viable subject? As an end-user, I do not want to pull "bad" code; which means not GNU compliant. And a rule of thumb usually is: when you (committer) are annoyed to review patches because you know that you would not do better yourself; concretely, significant contributions with no final tweaks. > For example, I have been asked a few times by people to push patches for > them over IRC, but their patches were unrelated to software I use / > would use / know how to approach (examples being GNOME). So, I kindly > refused to push their patch citing that I do not feel comfortable in > knowledge to understand the ramifications of their > patches. Hypothetically, if such a person approached me in the future > and asked for a commit access referral, since I had not worked closely > with them what kind of weight would be referral hold? The bottleneck is the review. Well, I have tried to point out this here [1]= . Sometime ago, "maintainer" of submodule had been discussed. For example, one could imagine that the commit access comes with the "responsibility" to take care of a submodule; with great power comes great responsibility. ;-) [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D38846#71 > I hope this makes sense. Maybe I am being overly nitpicky, I just really > like clarity. :) Me too, :-) All the best, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 17:36:30 2020 Received: (at 38846) by debbugs.gnu.org; 7 Jan 2020 22:36:30 +0000 Received: from localhost ([127.0.0.1]:49519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioxSf-0000BJ-NK for submit@debbugs.gnu.org; Tue, 07 Jan 2020 17:36:29 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:40992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioxSe-0000B6-CH for 38846@debbugs.gnu.org; Tue, 07 Jan 2020 17:36:28 -0500 Received: by mail-qt1-f193.google.com with SMTP id k40so1159205qtk.8 for <38846@debbugs.gnu.org>; Tue, 07 Jan 2020 14:36:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=G4F6NgtgIY6cZmahJqkr85qWmjGSRizWOjUM3S/GY8s=; b=cYQZI27IJ99trJlwEol9B+bbIre77YnXRwLswsUrZlk/wQrrQNp8vj/zaSuQggrg4y sLHUQmeLkryDLds+anxhZ/bHMV66sZOdxCY2OpTl+Ka1wELso0QHhYGksNyNNzJWHGNF UH6dquIBno2r/Mw2uEA1XmByDPT00HNBdZaFzBe/xx8GOkWCdq+PWhGoZQqhFOm2Sokd GXUBupW9YslpO3LFk6Cyq1ybggmZRTgZIGkS1vKl+dXyUQL5rCqAB/d2Xfu5nejFL/be ImAqV28E9TNjHocSOAm8C8XrZPnKcmccp48oNMmplPq3MfhwTHLGFTBnI6GMYiw76L3k ATVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=G4F6NgtgIY6cZmahJqkr85qWmjGSRizWOjUM3S/GY8s=; b=DaQT+NgsEJh3pKV2roHwYKLQajytVMsdvVg45q12vIvVne/6/aDJS8w6L4JXl4MObA WSfs+h370yJQ8MgnBAmYAkf4zBPcy+Tj4ujbC1lnypXP1nvu6S9c6JVJAuCG6+l8mNRz pJ8b2wtydZ2W6TLxxfAqc60jeTfKMyekYOCI/+yjzXU8BK62S4jE9aYy/tdf2/7s5U8G agS/ADRNHXe2F5ReI4B2V4ipd3m3Ge+i5mq4BkdJhTBC3svzcM3n1w7SamcJ+1gTBdL1 WpwS/7zIoGNevVzJIIJtVTvZzOtaW6Ykw9N6tfOZR9xzrm7AW3LJfDLBl+5yaRlCNx9J R2ug== X-Gm-Message-State: APjAAAXhpUhWcnvMRMhQfpca0oMtD32UMpnIu1cycGcmz1OJ6KaUnpN0 MsgzoB2h0W1jJNWlmLCXVh4= X-Google-Smtp-Source: APXvYqzwtnO8KPG5GSjTovXXM05mIbILfxioGWh4SC5KEUoGZgJo3FQZZPmTBkV+HLejb3yVzLIvSw== X-Received: by 2002:ac8:4509:: with SMTP id q9mr1104857qtn.353.1578436582826; Tue, 07 Jan 2020 14:36:22 -0800 (PST) Received: from apteryx (dsl-205-233-125-130.b2b2c.ca. [205.233.125.130]) by smtp.gmail.com with ESMTPSA id c16sm507610qka.18.2020.01.07.14.36.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 14:36:22 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> <87v9pvm4a3.fsf@elephly.net> <87o8vmw1dw.fsf@gnu.org> Date: Tue, 07 Jan 2020 17:36:13 -0500 In-Reply-To: <87o8vmw1dw.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 02 Jan 2020 12:20:27 +0100") Message-ID: <87r20avqqq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: Ricardo Wurmus , guix-maintainers@gnu.org, 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, Thank you for taking the time to draft this new policy. Ludovic Court=C3=A8s writes: [...] > Taking these comments into accounts, I get: > > @enumerate > @item > Find three committers who would vouch for you. You can view the list of > committers at > @url{https://savannah.gnu.org/project/memberlist.php?group=3Dguix}. Each > of them should email a statement to @email{guix-maintainers@@gnu.org} (a > private alias for the collective of maintainers), signed with their > OpenPGP key. > > Committers are expected to have had some interactions with you as a > contributor and to be able to judge whether you are sufficiently > familiar with the project's practices. It is @emph{not} a judgment on > the quality of your work, so a refusal should rather be interpreted as > ``let's try again later''. > > @item > Send @email{guix-maintainers@@gnu.org} a message stating your intent, > listing the three committers who support your application, signed with > the OpenPGP key you will use to sign commits, and giving its fingerprint > (see below). See @uref{https://emailselfdefense.fsf.org/en/}, for an > introduction to public-key cryptography with GnuPG. Note that Email Self-Defense focuses on the use of Thunderbird + the Enigmail plugin, both of which are missing from our collection of packages. I don't have a better resource to suggest, though. > @item > Once you've been given access, please send a message to > @email{guix-devel@@gnu.org} to say so, again signed with the OpenPGP key > you will use to sign commits. That way, everyone can notice and ensure > you control that OpenPGP key. > > @c TODO: Add note about adding the fingerprint to the list of authorized > @c keys once that has stabilized. > > @item > Make sure to read the rest of this section and... profit! > @end enumerate > > Thanks for your feedback! > > Ludo=E2=80=99. I like the proposal drafted so far. I agree with others that it is important to say that the maintainers reserve the final say in whether or not a contributor is granted push rights to the Guix repository, for transparency. LGTM :-) Maxim --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJ9WGpPiQCFQyn/CfEmDkZILmNWIFAl4VB94ACgkQEmDkZILm NWIm+w//U+RZ94THlO9ACHm0K6w5epPdtM6RG/Dc6OYqnNDT1JOaUrMdGv7kha1G r+C2iArBPoOgl9j6ZLIzvRDIoh1FOJvWnEoI37faY5uVkZ82DQHnEMOtmzDPa6cd WdLkxlJxYJwtUlHCDw+Vax09jakBscH55OBqhgQmQ/fS81iEqaCpF0cw9tMVSp6d UxREYQV2JPv0p27r5fFK1G1ZKkVRYnvn85QaqYTZmStj1w2wGDM9bdwVHYvbScH+ RTnvUoEdrLM5vrx8f4WZSYwPNo4n0R4gR2PF5eJ4Oip8vTpKX7OWndefNYyJt21R rnO1D6sOJ0tCzimdlKeU/dlWzkUYCG2tgmCwLnRjwm7KMWags9yeyKJ3dc1SWpmI wGjqi7DlC4Fzy5U0R0UqLT7pTLA+TgHkSAtfykIH9VSkRZZ9ZDegqR1SkoGedeNq 87aSA+ujcagqiNzzhbkXUd4l8RnKFThbvc4ZXrlUOeO6KTAx6FZTZJueLfpEnUxD uGx8siLDR9MAxi0sR/ec7V89l63MmogdKaygS7XMon2Fkd6KRSpa12m8YwZ04Idv dmUflEUbPOBHH7oj+lOm2lRIf+fF3gyfvYJ9mFMUGvvdmU0Xkxpj6chu0JCxTvGH VhiFS3Wyz54L3H7yMBfOSgmEE5g8wf9e/ETOySQlST6rjhFWH8U= =/fJv -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 17:51:01 2020 Received: (at 38846) by debbugs.gnu.org; 7 Jan 2020 22:51:01 +0000 Received: from localhost ([127.0.0.1]:49532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioxgj-0000Zj-Iw for submit@debbugs.gnu.org; Tue, 07 Jan 2020 17:51:01 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:50827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioxgi-0000ZO-7k for 38846@debbugs.gnu.org; Tue, 07 Jan 2020 17:51:00 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 5AC68676; Tue, 7 Jan 2020 17:50:54 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 07 Jan 2020 17:50:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=8JqzlMY4fg5gHkrjqUAHroHTSy nx48Xwr8OYg7whNTU=; b=WEXsl9iW7HMhJe8MugYJ+2pEeOROHxxsaknIDMg+Hm slTge6W043OEHSvRM8rk96lfYVi1YjI7ImqDK8V1Q2UuMlmLS9hmwQb4qnGTPt8a AOyRT6tXfLNRyFqcTJSxT6f60U68EnTMQ2dcvkcq4o6jvxYWIUouS+801KQqE44N hds8rNV0AQ/YuwaCwzS9P0omRrSKlP4OJfviKE5FqEEKY4TMlTfg6QFvHWTE49ng rVk68R83Eh6HAT45kuFQvNB+0s/GHhJyNNVYnpvkIx8/mqV6183m2kwGyDCpk2Ut aQPs2gNCJiJwb4nQ9EndME1CyyQqGFUQguB9VPCQ6fVQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=8JqzlM Y4fg5gHkrjqUAHroHTSynx48Xwr8OYg7whNTU=; b=HjUiu5LpFdyD4aUgu33iWP yMGc6d6fEIGOLaPfOmnVQleo9eIh1QI3UlUrUwbE3d4+sdS0IgdsHypLvxYPm3XJ erVfXWUWgmJutLbZ04f+Kx+q5P2fyoABPZceNwcgsdJ7maMj3NQ2YMpVKf649CWd zv/VkWUEB3BfyaxhYYD6B78FRyUz4KSYQA04UvyldEqf/AdrqLQmpPsNrWvBGNBI z8irWqwQpOZyAiLcdHBq2lYW8GVSCQlFdiqgMcCHu+IbfR4iyr1IkS8lky+I64h1 DT6T/ddhpfbTvpAVICqIFbYQkYoBQjQLLq3J2HCnvBkAuV9UAdwF8a0wduk1NvOQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdehjedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehgtderredtreejnecuhfhrohhmpeforghrihhu shcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhmqeenucffohhmrg hinhepghhnuhdrohhrghenucfkphepkeegrdehvddrvddviedruddtvdenucfrrghrrghm pehmrghilhhfrhhomhepmhgsrghkkhgvsehfrghsthhmrghilhdrtghomhenucevlhhush htvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (84-52-226.102.3p.ntebredband.no [84.52.226.102]) by mail.messagingengine.com (Postfix) with ESMTPA id 7F49C3060741; Tue, 7 Jan 2020 17:50:53 -0500 (EST) From: Marius Bakke To: Ludovic =?utf-8?Q?Court=C3=A8s?= , guix-maintainers@gnu.org Subject: Re: [bug#38846] [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access In-Reply-To: <875zhod8yo.fsf@gnu.org> References: <20200101162945.4946-1-ludo@gnu.org> <875zhod8yo.fsf@gnu.org> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Tue, 07 Jan 2020 23:50:51 +0100 Message-ID: <871rsa3mpg.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38846 Cc: 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hello! > > Just a heads-up for fellow maintainers (Tobias, Marius, Maxim): could > you send a =E2=80=9C+1=E2=80=9D or whatever you deem appropriate :-) to t= his discussion? > I=E2=80=99d like to make sure we=E2=80=99re on the same page. > > https://issues.guix.gnu.org/issue/38846 I've read through the changes and all LGTM. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl4VC0sACgkQoqBt8qM6 VPq57Qf/Rte6mRfaFaa8CD3IltcH3KIKsXY2k5WATHsT9Jym3mAbZfMOJiZSv2fv s7pbbSenxZ4gEWgY4U3EPXaT0otCrMgzLFydQ3aOtAeWgKvmXTh6Gl204ZJZtERC EOYOaGVzm8t4+bgKinTff+IpPT9o25OkSJdRrbFcItF8b0fgXOmozUgfCzdeJ2GG lqyrr0jtj+uYvMFzpf3Y2pkJiTfBPfQYIaxbWel/oTEOLBjR0utBu3/YrIMQzkb5 nYGWL7jEkBLyJKrUbrccQnv2/2Gzct8jWwKhgDBXjivuA+sRECiZfa4cd9Dr+NwJ bWV3NX5xGVTR2S7szW+fkWgB9jfyLA== =fr9s -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 09 17:05:49 2020 Received: (at 38846) by debbugs.gnu.org; 9 Jan 2020 22:05:50 +0000 Received: from localhost ([127.0.0.1]:53205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipfw5-00062W-JA for submit@debbugs.gnu.org; Thu, 09 Jan 2020 17:05:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipfw3-00062E-ES for 38846@debbugs.gnu.org; Thu, 09 Jan 2020 17:05:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ipfvv-0000yf-E0; Thu, 09 Jan 2020 17:05:40 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58932 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ipfvt-0005Z3-JK; Thu, 09 Jan 2020 17:05:38 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: [bug#38846] [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access References: <20200101162945.4946-1-ludo@gnu.org> Date: Thu, 09 Jan 2020 23:05:35 +0100 In-Reply-To: (zimoun's message of "Mon, 6 Jan 2020 22:44:38 +0100") Message-ID: <87h814s2ts.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: GNU Guix maintainers , 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello! zimoun skribis: >>>From the v1.0.1 to now, the repartition of committers which are not the a= uthors: > > 361 > 78 > 65 > 61 > 59 > 54 > 52 > 47 > 44 > 43 > 37 > 21 (x2) > 11 > 9 > 8 > 7 (x2) > 6 > 5 (x3) > 4 (x2) > 3 > 2 (x3) > 1 (x3) > > which should be compared to the number of commits per author also > committer (first 10): > > 1463 > 1162 > 886 > 670 > 618 > 335 > 204 > 166 > 161 > 150 I had overlooked that; interesting, though I=E2=80=99m not sure what conclu= sion(s) to draw. Perhaps we should look at how these numbers evolve over time? Related to that, attached is a script I wrote a while back to view the number of reviews per committer (ah ha!), like so: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> (define r (reviewers repo)) scheme@(guile-user)> ,pp (sort (map car r) <) $3 =3D (0 ;; long tail omitted=E2=80=A6 1 1 1 1 2 2 2 2 2 4 5 5 6 9 9 9 10 11 13 13 17 18 19 30 37 37 38 40 40 45 48 51 59 63 72 84 85 88 99 181 186 264 287 506 526 1620) --8<---------------cut here---------------end--------------->8--- This is for all-time commits, so not all that representative, but could be used as a starting point for the statistician in you. :-) Ludo=E2=80=99. --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=reviewers.scm Content-Description: the code (use-modules (git) (git repository) (git reference) (git oid) (git tag) (git commit) (git structs) ;signature-email, etc. (srfi srfi-1) (srfi srfi-26) (ice-9 match) (ice-9 vlist)) (define commit-author* (compose signature-name commit-author)) (define commit-committer* (compose signature-name commit-committer)) (define-syntax-rule (false-if-git-error exp) (catch 'git-error (lambda () exp) (const #f))) (define* (fold-commits proc seed repo #:key (start (reference-target (repository-head repo))) end) "Call PROC on each commit of REPO, starting at START (an OID), and until END if specified." (let loop ((commit (commit-lookup repo start)) (result seed)) (let ((parent (false-if-git-error (commit-parent commit)))) (if parent (if (and end (oid=? (commit-id parent) end)) (proc parent result) (loop parent (proc parent result))) result)))) (define (reviewers repo) "Return a list of review count/committer pairs." (define vhash (fold-commits (lambda (commit result) (if (string=? (commit-author* commit) (commit-committer* commit)) result (vhash-cons (commit-committer* commit) #t result))) vlist-null repo)) (define committers (delete-duplicates (fold-commits (lambda (commit result) (cons (commit-committer* commit) result)) '() repo))) (map (lambda (committer) (cons (vhash-fold* (lambda (_ count) (+ 1 count)) 0 committer vhash) committer)) committers)) (define (reviewer< r1 r2) (match r1 ((count1 . name1) (match r2 ((count2 . name2) (< count1 count2)))))) (libgit2-init!) (define repo (repository-open ".")) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 09 17:39:32 2020 Received: (at 38846-done) by debbugs.gnu.org; 9 Jan 2020 22:39:32 +0000 Received: from localhost ([127.0.0.1]:53274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipgSi-00072e-0g for submit@debbugs.gnu.org; Thu, 09 Jan 2020 17:39:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipgSg-00072M-B6 for 38846-done@debbugs.gnu.org; Thu, 09 Jan 2020 17:39:30 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ipgSa-00031s-BD; Thu, 09 Jan 2020 17:39:24 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59200 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ipgSW-0002mM-93; Thu, 09 Jan 2020 17:39:24 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tobias Geerinckx-Rice Subject: Re: [bug#38846] [PATCH 4/4] DRAFT doc: Add a cooption policy for commit access. References: <20200101163446.5132-1-ludo@gnu.org> <20200101163446.5132-4-ludo@gnu.org> <87a770dv07.fsf@nckx> Date: Thu, 09 Jan 2020 23:39:16 +0100 In-Reply-To: <87a770dv07.fsf@nckx> (Tobias Geerinckx-Rice's message of "Tue, 07 Jan 2020 00:29:12 +0100") Message-ID: <87y2ugqmp7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846-done Cc: guix-maintainers@gnu.org, 38846-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Tobias Geerinckx-Rice skribis: > Ludovic Court=C3=A8s =E5=86=99=E9=81=93=EF=BC=9A >> +@item >> +Send @email{guix-maintainers@@gnu.org} a signed message stating >> your >> +intent, listing the three committers who support your application, >> and >> +giving the fingerprint of the OpenPGP key you will use to sign >> commits >> +(see below). >> + >> +@item >> +Once you've been given access, please send a message to > ^^^^ > > Probably just me, but this glosses over maintainer approval just a bit > too deftly, and that even with 3 signed referrals commit access isn't > guaranteed, just extremely likely. > > Unless that will actually change, I think we should briefly mention it > as well. People react worse to =E2=80=98let's try again later=E2=80=99 w= hen they > think they've already passed. Understandably so. Good points (from Maxim, too). >> +@email{guix-devel@@gnu.org} to say so, again signed with the >> OpenPGP key >> +you will use to sign commits. That way, everyone can notice and >> ensure >> +you control that OpenPGP key. > > Best to add an explicit =E2=80=98before pushing your first commit=E2=80= =99 here, if > that is the intent. Indeed. >> +When you get commit access, please make sure to follow > ^^^^ > > =E2=80=98If=E2=80=99? Same point as the first @items above. Yes. I=E2=80=99ve now pushed the whole series: ef09cb866c doc: Add a cooptation policy for commit access. 98ebcf1c1b doc: Encourage patch review. 2d315cd428 doc: Move "Commit Access" section from 'HACKING' to the manual. a7bde77d24 doc: Add "Tracking Bugs and Patches" section. I believe I=E2=80=99ve taken into account all the changes that were propose= d. If you think anything still needs to be adjusted, let=E2=80=99s do that. Thanks everyone! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 10 10:49:41 2020 Received: (at 38846) by debbugs.gnu.org; 10 Jan 2020 15:49:41 +0000 Received: from localhost ([127.0.0.1]:54859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipwXd-0001bK-6o for submit@debbugs.gnu.org; Fri, 10 Jan 2020 10:49:41 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:36640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipwXb-0001b7-0T for 38846@debbugs.gnu.org; Fri, 10 Jan 2020 10:49:40 -0500 Received: by mail-qk1-f193.google.com with SMTP id a203so2250037qkc.3 for <38846@debbugs.gnu.org>; Fri, 10 Jan 2020 07:49:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=U9oquzRyPnmgwfz3aCbxBSP0H6dMgOtY+WwYj0EcM2c=; b=HnZqkCHqx3A3CkxiPpVY6fNvF907wZZUlXbSFx4rFPC9nx5aNnLvQg7KrYWbkhc/T0 v1fioBWhvZcIpVwxljU18QjvPszOklECj5ZrJZprpGxAIfy6OaZ4E1L0GCbVyhWZAcZn 5snHc6af1BLUGSVgOC4nnnRSoaqKrpAwVwgO0F7q5jdVZXP9bCwC5BkXXd1E5ILgLqjk VQum5ZVS0gMgnwUK5U70dB/G8Tixoe6kAQYHIvVoym+4Oh3yHtYKOCpTMSrVEmrEu1/Q l1Ha5f6BGL9zu/8CYLF7amg4H/goRZ0sYNmt1SO/epeJc54h6sMNVM56zC9kf8QwDeFM 8mQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=U9oquzRyPnmgwfz3aCbxBSP0H6dMgOtY+WwYj0EcM2c=; b=QLYDtRzGGRnCT9zluSLyIVOvY3M7aqX4mke36pyO7bgeqo54UK5f0b6uk/iQvrpLDl dMclnJ5NRhZygVh9532oGDKW9mI76ceKVPOcXDMfzzbIhn1WPOYCudhKFy/xzp6p7BiA AWjH434UKBIWB1tZaA6Tqp57Acref3kjzm23hcOBvLkwcqjrPDgFZfbczdcxg6GbkAIB Tvpdmd8Oe47PaES3/fsfPOD8I1oxt3J23BDimUzGZJWJmxC2NTPMFbS7ir8VvbTz1KEe 5mLEup435ar0goO9cDD6wHri0jJGJisDiLpaxlAoCHzSGjy++oliPUaXKz78kWBqjEbA KZwA== X-Gm-Message-State: APjAAAUSttpbttlSzrdHmY0SfA80AagSFodAKU3n8j8PTprM7oxWxqv8 4HSyg6kk4j9xJTCOmOo4PSUzf0sccj4Sg+VWFps= X-Google-Smtp-Source: APXvYqwqHlAfLvcv0vdvCMv0UJwjoVqjof4sP6/nrWoZp1zBwbjWIBekUJL/wFCu6SCoDRUJvLnT4kwnKGMxZv8Qw5U= X-Received: by 2002:a37:63c7:: with SMTP id x190mr3800099qkb.232.1578671373257; Fri, 10 Jan 2020 07:49:33 -0800 (PST) MIME-Version: 1.0 References: <20200101162945.4946-1-ludo@gnu.org> <87h814s2ts.fsf@gnu.org> In-Reply-To: <87h814s2ts.fsf@gnu.org> From: zimoun Date: Fri, 10 Jan 2020 16:49:21 +0100 Message-ID: Subject: Re: [bug#38846] [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38846 Cc: GNU Guix maintainers , 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo, On Thu, 9 Jan 2020 at 23:05, Ludovic Court=C3=A8s wrote: > >>From the v1.0.1 to now, the repartition of committers which are not the= authors: > > > > 361 > > 78 > > 65 > > 61 > > 59 > > 54 > > 52 > > 47 > > 44 > > 43 > > 37 > > 21 (x2) > > 11 > > 9 > > 8 > > 7 (x2) > > 6 > > 5 (x3) > > 4 (x2) > > 3 > > 2 (x3) > > 1 (x3) > > > > which should be compared to the number of commits per author also > > committer (first 10): > > > > 1463 > > 1162 > > 886 > > 670 > > 618 > > 335 > > 204 > > 166 > > 161 > > 150 > > I had overlooked that; interesting, though I=E2=80=99m not sure what conc= lusion(s) > to draw. Perhaps we should look at how these numbers evolve over time? If one re-associates the number of commits as committers to the number of commits as authors, and computes the ratio (in percent and sorted), the result is: 248.00 128.26 105.00 100.00 100.00 67.16 53.61 45.49 42.86 41.60 40.00 28.28 28.13 23.12 23.08 19.40 14.45 10.23 8.57 7.00 6.60 6.25 5.88 5.75 5.75 5.19 3.21 2.63 1.84 1.47 1.31 .73 To be clear, the person with the score of 53.61% "reviews" half as many commits they authors. And the mean is almost 37%. Cool, no? Well, it is not possible to draw an strong conclusion, just a weak one: Guix is healthy. ;-) (For example, the number of commits should be weighted with the number of lines changed.) And yes, it should be interesting to see how evolves the commits rate (as authors, as committers) over the time. > Related to that, attached is a script I wrote a while back to view the > number of reviews per committer (ah ha!), like so: Cool! Maybe this kind of metrics could be reported to the Guix Data Service. Well, let start by play with your script. ;-) > This is for all-time commits, so not all that representative, but could > be used as a starting point for the statistician in you. :-) H=C3=A9h=C3=A9! You got me. ;-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 13 05:02:15 2020 Received: (at 38846) by debbugs.gnu.org; 13 Jan 2020 10:02:15 +0000 Received: from localhost ([127.0.0.1]:58689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqwY3-0005Py-H8 for submit@debbugs.gnu.org; Mon, 13 Jan 2020 05:02:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqwY2-0005Pm-3M for 38846@debbugs.gnu.org; Mon, 13 Jan 2020 05:02:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iqwXv-00022J-TD; Mon, 13 Jan 2020 05:02:07 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=38476 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iqwXq-0000Ci-8A; Mon, 13 Jan 2020 05:02:04 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: [bug#38846] [PATCH 0/4] Move 'HACKING' to the manual, and a proposal for commit access References: <20200101162945.4946-1-ludo@gnu.org> <87h814s2ts.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 =?utf-8?Q?Niv=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 13 Jan 2020 11:01:59 +0100 In-Reply-To: (zimoun's message of "Fri, 10 Jan 2020 16:49:21 +0100") Message-ID: <87eew3r7xk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38846 Cc: GNU Guix maintainers , 38846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, zimoun skribis: > To be clear, the person with the score of 53.61% "reviews" half as > many commits they authors. > > And the mean is almost 37%. Cool, no? > > > Well, it is not possible to draw an strong conclusion, just a weak > one: Guix is healthy. ;-) Oh yes, that=E2=80=99s an interesting (and nice!) conclusion. Thanks, Ludo=E2=80=99. From unknown Mon Jun 23 20:16:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 10 Feb 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator