GNU bug report logs - #38841
Enhancement request: Make show_help a bool

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#38841: closed (Enhancement request: Make show_help a bool)
Date: Wed, 01 Jan 2020 07:19:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 31 Dec 2019 23:17:52 -0800
with message-id <c34bdc33-2482-e2a1-721b-13a8b14abde7 <at> cs.ucla.edu>
and subject line Re: bug#38841: Enhancement request: Make show_help a bool
has caused the debbugs.gnu.org bug report #38841,
regarding Enhancement request: Make show_help a bool
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
38841: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38841
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Emil Engler <me <at> emilengler.com>
To: bug-grep <at> gnu.org
Subject: Enhancement request: Make show_help a bool
Date: Wed, 1 Jan 2020 02:52:14 +0100

Hi, why is "static int show_help on line65 in src/grep.c a int?
It's value is only set once in "src/grep.c:2704" to a 1.
Wouldn't it be better to make it a bool?

As this my first mail to a GNU project ever I don't know how to properly 
contribute code, are there methods like Pull Requests or do I need to 
submit a patch the traditional way through a diff on a mailing list?

Greetings and Happy New Year,
Emil Engler

[Message part 3 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Emil Engler <me <at> emilengler.com>
Cc: 38841-done <at> debbugs.gnu.org
Subject: Re: bug#38841: Enhancement request: Make show_help a bool
Date: Tue, 31 Dec 2019 23:17:52 -0800

On 12/31/19 5:52 PM, Emil Engler wrote:
> Hi, why is "static int show_help on line65 in src/grep.c a int?

Its address is taken in a long_options initializer, where the context requires
an int *. You could have found that out by changing it to bool and trying to
compile.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.