Subject: bug#38841: closed (Re: bug#38841: Enhancement request: Make show_help a bool)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 01 Jan 2020 07:19:01 +0000

Your bug report

#38841: Enhancement request: Make show_help a bool

which was filed against the grep package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
38841: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38841
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#38841: Enhancement request: Make show_help a bool
From: Paul Eggert <[email-masked]>
To: Emil Engler <[email-masked]>
Cc: [email-masked]
Date: Tue, 31 Dec 2019 23:17:52 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

On 12/31/19 5:52 PM, Emil Engler wrote:
> Hi, why is "static int show_help on line65 in src/grep.c a int?

Its address is taken in a long_options initializer, where the context requires
an int *. You could have found that out by changing it to bool and trying to
compile.

Subject: Enhancement request: Make show_help a bool
From: Emil Engler <[email-masked]>
To: [email-masked]
Date: Wed, 1 Jan 2020 02:52:14 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi, why is "static int show_help on line65 in src/grep.c a int?
It's value is only set once in "src/grep.c:2704" to a 1.
Wouldn't it be better to make it a bool?

As this my first mail to a GNU project ever I don't know how to properly 
contribute code, are there methods like Pull Requests or do I need to 
submit a patch the traditional way through a diff on a mailing list?

Greetings and Happy New Year,
Emil Engler