From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 31 21:03:20 2019 Received: (at submit) by debbugs.gnu.org; 1 Jan 2020 02:03:20 +0000 Received: from localhost ([127.0.0.1]:35356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imTLz-0003wM-TQ for submit@debbugs.gnu.org; Tue, 31 Dec 2019 21:03:20 -0500 Received: from lists.gnu.org ([209.51.188.17]:48155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imTBL-0003gJ-QG for submit@debbugs.gnu.org; Tue, 31 Dec 2019 20:52:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33426) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imTBK-0008Bq-Gf for bug-grep@gnu.org; Tue, 31 Dec 2019 20:52:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1imTBJ-0002RY-Id for bug-grep@gnu.org; Tue, 31 Dec 2019 20:52:18 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:45402) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1imTBJ-0002Lq-BL for bug-grep@gnu.org; Tue, 31 Dec 2019 20:52:17 -0500 Received: by mail-wr1-f53.google.com with SMTP id j42so36225369wrj.12 for ; Tue, 31 Dec 2019 17:52:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=sWEocvh5UEkmXPb7QRsT7nnzrWrSaW7G3P7nKMAJiz8=; b=XKwWq7JyZs1/MLIKeMwt/Kdv+M+bAk2dnsC3LtsyUBGQT5UBxE1CIDN7lRi6dKuXug Y5LalE4ix1i2G4v8HVkXnQKcLIWPgsX1DZlwZspRlg21QHfoDMw8Z6gSx6iruwnepZgr i8aH6xRrQgiZvjkdFZ2zxg7Ox0TCnQuMWHco81MaVXiMY4ojD/E00so26c+fUMlnr4Ml ebKqQcVE9XXwLffNE4QYM1Piq+oBvLAimu2ZjhQ6nvUqoyL90KdHHGG6FjpfB5yuiawp mIvazKYtPryov7Cl01jg0aSRkxh8LzaVqCiefYHFZWOGglBAcuBxTX35fDicJTSX3LAN Ucpg== X-Gm-Message-State: APjAAAV13FAp9WqsmlhHq0xhLRsanfr/bS4eVTA+O2WZaa6rZ3jSGryn JVPD4UfgVMT6Dk+NZDzM8rjTpHDT X-Google-Smtp-Source: APXvYqxhNPt3D2NrqEAbPytMbaqy21CFazVO76L7JZ2qOXIbgliBSw53BmPB9ai96NfM1129LQnQeA== X-Received: by 2002:a05:6000:11c6:: with SMTP id i6mr76241193wrx.178.1577843535449; Tue, 31 Dec 2019 17:52:15 -0800 (PST) Received: from ?IPv6:2a02:8108:8200:1c80:ccfd:1bb:91fc:466d? ([2a02:8108:8200:1c80:ccfd:1bb:91fc:466d]) by smtp.gmail.com with ESMTPSA id g2sm50491060wrw.76.2019.12.31.17.52.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Dec 2019 17:52:15 -0800 (PST) To: bug-grep@gnu.org From: Emil Engler Subject: Enhancement request: Make show_help a bool Message-ID: <4416a1e6-7e40-348b-570d-f0e2b2ad8568@emilengler.com> Date: Wed, 1 Jan 2020 02:52:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.53 X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, why is "static int show_help on line65 in src/grep.c a int? It's value is only set once in "src/grep.c:2704" to a 1. Wouldn't it be better to make it a bool? As this my first mail to a GNU project ever I don't know how to properly contribute code, are there methods like Pull Requests or do I need to submit a patch the traditional way through a diff on a ma [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (realemilengler[at]gmail.com) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 31 Dec 2019 21:03:19 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) Hi, why is "static int show_help on line65 in src/grep.c a int? It's value is only set once in "src/grep.c:2704" to a 1. Wouldn't it be better to make it a bool? As this my first mail to a GNU project ever I don't know how to properly contribute code, are there methods like Pull Requests or do I need to submit a patch the traditional way through a diff on a mailing list? Greetings and Happy New Year, Emil Engler From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 02:18:02 2020 Received: (at 38841-done) by debbugs.gnu.org; 1 Jan 2020 07:18:02 +0000 Received: from localhost ([127.0.0.1]:35528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imYGY-0003nw-8e for submit@debbugs.gnu.org; Wed, 01 Jan 2020 02:18:02 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:47158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imYGW-0003nR-1R for 38841-done@debbugs.gnu.org; Wed, 01 Jan 2020 02:18:01 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id DEC4016008F; Tue, 31 Dec 2019 23:17:53 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6yqkNviwKD6W; Tue, 31 Dec 2019 23:17:53 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 45F3416022A; Tue, 31 Dec 2019 23:17:53 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CA0LL-3C-Ysr; Tue, 31 Dec 2019 23:17:53 -0800 (PST) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 1AB0C16008F; Tue, 31 Dec 2019 23:17:53 -0800 (PST) Subject: Re: bug#38841: Enhancement request: Make show_help a bool To: Emil Engler References: <4416a1e6-7e40-348b-570d-f0e2b2ad8568@emilengler.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Tue, 31 Dec 2019 23:17:52 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <4416a1e6-7e40-348b-570d-f0e2b2ad8568@emilengler.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38841-done Cc: 38841-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 12/31/19 5:52 PM, Emil Engler wrote: > Hi, why is "static int show_help on line65 in src/grep.c a int? Its address is taken in a long_options initializer, where the context requires an int *. You could have found that out by changing it to bool and trying to compile. From unknown Sun Jun 22 17:12:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 29 Jan 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator