From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 31 04:58:05 2019 Received: (at submit) by debbugs.gnu.org; 31 Dec 2019 09:58:05 +0000 Received: from localhost ([127.0.0.1]:33738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imEHt-0007yp-HE for submit@debbugs.gnu.org; Tue, 31 Dec 2019 04:58:05 -0500 Received: from lists.gnu.org ([209.51.188.17]:34631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imEHr-0007yh-Rs for submit@debbugs.gnu.org; Tue, 31 Dec 2019 04:58:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44964) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imEHp-00006D-Dk for bug-gnu-emacs@gnu.org; Tue, 31 Dec 2019 04:58:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPOOFED_FREEMAIL autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1imEHo-0007n6-5x for bug-gnu-emacs@gnu.org; Tue, 31 Dec 2019 04:58:01 -0500 Received: from mout.gmx.net ([212.227.15.15]:57933) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1imEHn-0007ZR-K6 for bug-gnu-emacs@gnu.org; Tue, 31 Dec 2019 04:58:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1577786276; bh=dBJTM7VCFGZcUHYbC6nIIzDo6Rkej1ZTKb2Sc9KkFRg=; h=X-UI-Sender-Class:To:From:Subject:Date; b=K/Gs3bRWXuCefxtYfutAEQ6xX+u1a6W6NTZ8mQCLrDiddhEUVViz60Las4gdKgkOA VBDwvRgTKydKYtrD0JZC2Zebff5qoxsXegkWfi3ocuZQfwDbhRo0xDxdJJbC+HbYjF qr2tG6Dx5fR2OleVRREn1KNc/x4gvMEGxtgfpFWw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([46.125.249.3]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M3lc9-1ilOwJ1AzT-000vKb for ; Tue, 31 Dec 2019 10:57:56 +0100 To: Bug-Gnu-Emacs From: martin rudalics Subject: 26.3; Customized mode line breaks height of vertical scroll bar Message-ID: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> Date: Tue, 31 Dec 2019 10:57:55 +0100 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------5C6380152A0F34016567C86C" Content-Language: de-AT X-Provags-ID: V03:K1:zCalzZ1sEwSwr3UbHqA0CBUh/bAsvZQFF5X9+2FrSIw7AfUIj2u l7EsCmnChfWOUvEhg5kElYlXfJFx6rKDdXQnOKpKdYNh7U+o+r3NQRhdAYgF9eX9HfJIl7j msAXP1SBUDmdF65FQCZbmMl9NgBIlowCX9rHI2bx+1c8wC3dgEPaHa5u+dlfgwPPMIgk9C9 9IqtLKqHF690qXjODwLhg== X-UI-Out-Filterresults: notjunk:1;V03:K0:GODxjBso0PA=:qSOiZsvxaUmDYcMBoBWpIT xPqDqTlMLK+QvlyZNy0aYzq206pnOfCfkQkkdS81D3YdwiQumxBTirhYP491dJHgaH4HaNuZR 2+5lI5UTFAXGy5XRHZ5aEn/GEav7wT/tdy7k0KvRwzdJlXsqCaywNm+sCIGhgyEaiy5Ybt9p4 euRUe9tEPlBkf9TuhsarTDlm9yoO9ajgwZe097w3KqyeLHhmIx/roFb90d5rtJFUSXGPNUZuI SDBQBcXe8egV//L0Q0+42xIg7h2lJnKS7hjxqLZhW+tXQIHOwsKMqEoarOpJBmOQpuIdkgDZe 9w3hw9k2GF1a7j5QwSk2Yod+RBta/4a7Pg/mu2a2bL83bkWLPvMUx96oDeTAtYKHRKenCDatD BeGLbsgbbuU+/zClV30oWZ1lwVjcUSzZrfBwaRtvffNJaMnSB0PmjgNEFuthfDETUYktrGOGm W+dvZfWtMGtdPW6CfsacFF87CZrN1le3BrBQGSCua9m13z8jbxxXDsaX0bgkwTU0Md2atWdjY sZ6lybQ7gp5IquDe6AepY++MSHziSUMhwcv16Mxumi7yfY1nn/W0kN0mX4r0r6IyJ+0ggw47K HpsQoi+n/vjNWXA3Sga+5Ivsra3/7DIXjcE+DQzXA/d3BHuHMaQ6ZqDJCvU2kgk7GlVKqydpc RYA9v9SwBxvncHeyQmw/w6nXcDmCalWEiSlpQwX2MGELohdRE84st13IWHOyF1CpgMTkd+zqm HBwREhu7ckjWR1t3FOEA6kXK31N/+jM4/mq4bTK3OEmr4W8V5b2OU0aBT0Z17LH4IrBn9yE/n j4eW5Q8IXd/fKxKap6UACcCFqWLvv7yVLpGMdaSGsNyihu7oYsLGSariPMnfH5onuUpvahsSc ZHClotnV5EEwLDbA0Lmwl0LUdqHDI1MaJog+NqMsSLh1ekuR+Br2XDNs3OPUwSRDgu6nlqcFz mEoh24jWJNsWrXHXvYsx+LtId4xYRLpT3IHiAMF8/lYUxiIke/XHpWcZT1PZmvqxQbWJkngB2 QYOP33UbjIxkOphp59Jrlq39Uuf0dy3C6N+AezfccxOlfb6EOvQIagJpLBhDKBUYBczc8vYh6 Px+W8+Gea/KCzryscgtw5AkwFiDOkbnMIU8kXglz4GtardK3/AqjDfEXDgD9QAqK5UNhBCtOc lOQmJZowtw/SQ54SZPP5omjuzAsFFtjrHcpXDkmR+Ba5AjsuUUuYlavpPqu2abGeIFeovscwC t9grTMfef4rElCysmrGWIXLPo1LsvDjhKgmVjDQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.15 X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This is a multi-part message in MIME format. --------------5C6380152A0F34016567C86C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit This bug can be reproduced here with Emacs 26 and current master. The mode line customization was provided by Jonas Bernoulli in Bug#38181. With emacs -Q load the attached test-mode-line.el and hit F1. This should show the *scratch* window with an expanded mode line and a normal scroll bar and a two line echo area showing "test-mode-line". Now hit any other key. This sould shrink the echo area and redisplay the *scratch* window as before but "extends" the vertical scroll bar into the mode line. The reason for this behavior is that the vertical scroll bar height in the first case is calculated from a window_box_height call where ml_row->mode_line_p is set and thus ml_row->height is used. In the second case ml_row->mode_line_p is not set and the value is taken via estimate_mode_line_height which, given the specification from 'test-mode-line', doesn't estimate the height well. martin --------------5C6380152A0F34016567C86C Content-Type: text/plain; charset=UTF-8; name="test-mode-line.el" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="test-mode-line.el" KGRlZnVuIHRlc3QtbW9kZS1saW5lICgpCiAgKGludGVyYWN0aXZlKQogIChzZXRxCiAgIG1v ZGUtbGluZS1mb3JtYXQKICAgKGNvbnMgKHByb3BlcnRpemUgIiAiICdkaXNwbGF5CiAgICAg ICAgICAgICAgICAgICAgIChjcmVhdGUtaW1hZ2UgIi8qIFhQTSAqLyBzdGF0aWMgY2hhciAq IGltYWdlW10gPSB7ClwiMyA2MCAxIDFcIiwKXCIwIGMgIzAwYWFmZlwiLApcIjAwMFwiLFxu XCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLFxuXCIwMDBcIiwKXCIwMDBcIixcblwiMDAw XCIsXG5cIjAwMFwiLFxuXCIwMDBcIixcblwiMDAwXCIsClwiMDAwXCIsXG5cIjAwMFwiLFxu XCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLApcIjAwMFwiLFxuXCIwMDBcIixcblwiMDAw XCIsXG5cIjAwMFwiLFxuXCIwMDBcIiwKXCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLFxu XCIwMDBcIixcblwiMDAwXCIsClwiMDAwXCIsXG5cIjAwMFwiLFxuXCIwMDBcIixcblwiMDAw XCIsXG5cIjAwMFwiLApcIjAwMFwiLFxuXCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLFxu XCIwMDBcIiwKXCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLFxuXCIwMDBcIixcblwiMDAw XCIsClwiMDAwXCIsXG5cIjAwMFwiLFxuXCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLApc IjAwMFwiLFxuXCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLFxuXCIwMDBcIiwKXCIwMDBc IixcblwiMDAwXCIsXG5cIjAwMFwiLFxuXCIwMDBcIixcblwiMDAwXCIsClwiMDAwXCIsXG5c IjAwMFwiLFxuXCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiCn07IiAneHBtIHQgOmFzY2Vu dCAnY2VudGVyKSkKCSBtb2RlLWxpbmUtZm9ybWF0KSkKICAobWVzc2FnZSAiXG50ZXN0LW1v ZGUtbGluZSIpKQoKKGdsb2JhbC1zZXQta2V5IFtmMV0gJ3Rlc3QtbW9kZS1saW5lKQo= --------------5C6380152A0F34016567C86C-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 31 11:05:56 2019 Received: (at 38828) by debbugs.gnu.org; 31 Dec 2019 16:05:56 +0000 Received: from localhost ([127.0.0.1]:35005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imK1s-0002wE-H4 for submit@debbugs.gnu.org; Tue, 31 Dec 2019 11:05:56 -0500 Received: from mout.gmx.net ([212.227.17.22]:58307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imK1r-0002w0-1p for 38828@debbugs.gnu.org; Tue, 31 Dec 2019 11:05:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1577808347; bh=hMMYM9XpsfBjJ7VcqzGmh5gpcnT77miXR1a+hs9Z9iI=; h=X-UI-Sender-Class:Subject:From:To:References:Date:In-Reply-To; b=D0ufoqDUQIOwV+6stpP3FCboGpagdzzNSUHeA8a5pgi7lVRzZhG/ygpjSa93Gtfio FD4jb+HVTu2+qi18+73MeoXDwSRHq+A5D+kd939/bBUQpgmVBPtUU2T9JnLNn7U+9Q TmuhVmSr/Zqnjm1hxGmTKUr0G0MavYPbOZoUPK9E= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.134]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MplXp-1jXRQ63Mxp-00qC9b for <38828@debbugs.gnu.org>; Tue, 31 Dec 2019 17:05:47 +0100 Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar From: martin rudalics To: 38828@debbugs.gnu.org References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> Message-ID: <62df41f8-e73a-458b-0a08-92e7a0ec4b32@gmx.at> Date: Tue, 31 Dec 2019 17:05:48 +0100 MIME-Version: 1.0 In-Reply-To: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:+Sz4HRyt/fho7rIu/8fLcX36gMvcQq9jYcVDwSAIC9Du9R0bYz5 vjPqcad3Co5BlgRRFM/vZ08zHYpqS82YLI+/YMb7nHv9cht/HURzqfxTjNekS6mJXOyERLB TyzoDMFURc95mskhNBCTEW3maOiMEWNo+LyVG2khK7gKq346TVsKVf6yTPMHG44inoJOkqG 1HEHEvU4nsWfdeDXqsW7Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:3/7vbF1I7GM=:S80gh63h2w3V27sosjBbfW MZRuXhE4JRVolnvESjBoNu7+U8LjQhEKi5bbE+9EUjDVkYYzwu5kOv5IXaq5Q42MNKiI00Grj GpG9oYhTKTDlS9jlpQXflZ0xM3RLhNgpQqlr1CAV2uMm4CiseZeG7DPiTD72AVlV1mf2YcBpE wtqr9eI15p0lALi1CRRLdpke5k2Lyr07ecwMgGHQUu5RDGJw00qnXAn97yGTIIqRKFPJX5JFB BuOh3K0TXuRfDm7fqUuiZCukypsWpqNGbKW7fgVKzisAvAdlW7bnE/lOnbDoBXpoYPwHVAD+3 3FVw+FNKILgZF2PzMaEs9b+lJGRJdSlhTBZd2Kt2u0c59SI0vV2rZcVk2E1+LAjADdhtoUrlI /iHSacSu4C8Au8kQUTqQ1+M7QJqLprRyGgIXaNC3BXIKadFQ6U7yGuF4IYKCXVsMmQ6lVZ1yp a5zLqGX2IB3k3fPUmqzb5RWugcP5PPrmn+yL9s6SUdY3zFwKW10W2EfErGGa2iIDtn6+i8kpI 6EWOyiGAV3Yi4U4LJpZk6hjoogX7ijocTuId2NaCKwhh/Q+lRcqyo7GG69wN/jpejWXJQnRpr jdtOiRGxBEr2VytMi8giBulaThlWSgKNhHB+GDaXP8D6Idf+BFw77llJATzD/L+6CBByL4VyP pXOEwO8X2UZyIyKxdZNoUeKd+WqtEzfKd2ItPtD3gmyjcr54yPJQBwip4oVjTVKBmlo64sDDV PUJ8EfDdR8zyqKXuTj574QPVR2caFh4gdo03oX5eZfuf8XKS+v1jBhmsT7IuDkEDCjH+S17rq clPCkXXfLrg+643iDrmSx2p6sVpQF93kcLM5LM8EQUcyqKvD+uvYvqArYIxw0xC+k+rRr9cb8 Y/dpDWq4YETbgwckHe+I1m+7yDhil4NX9NxrGRh+RnWoM6nAKBGYs28wX38Y4yRFSSZbqE8bz 2wSq3IMWfRj3dqmQdVxkCsejgb9M8/vJsSjRuvAAkxzY19/M4R4kxyaeaqo7OHunj/SCA9eMv fypQMY+0z3AXJoZXbVZgaMtFY6/raSgdozJjlEYq3JJ5d/R0/6Yc5kMI5R3tYV1XoU3P/Nysn qWnZ8ld9I9tS1k8yJcgXuSBN4m6n7kD3erEhdGmMgrNLROhp1p9CUaiiOm+hGQvOlNXOFbhMi 2LBtuN51p7Vb/JG6m9mHbs+pUQCnL42MUO80dQGz66h0wcMWiuATriuKGxGknV/qQxS6IElMc 1kasbNo7MyhrNc8rstGFa1bSITGzakXc1GjMyYQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38828 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) For the record: Rewriting 'window_box_height' as int window_box_height (struct window *w) { return WINDOW_BOX_TEXT_HEIGHT (w); } fixes the problem here. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 11:10:45 2020 Received: (at 38828) by debbugs.gnu.org; 1 Jan 2020 16:10:45 +0000 Received: from localhost ([127.0.0.1]:37423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imga5-0001SA-6h for submit@debbugs.gnu.org; Wed, 01 Jan 2020 11:10:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imga4-0001Ry-1T for 38828@debbugs.gnu.org; Wed, 01 Jan 2020 11:10:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imgZy-0003PG-Gg; Wed, 01 Jan 2020 11:10:38 -0500 Received: from [176.228.60.248] (port=3656 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imgZs-0007y6-6R; Wed, 01 Jan 2020 11:10:37 -0500 Date: Wed, 01 Jan 2020 18:10:44 +0200 Message-Id: <83tv5fjgxn.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> (message from martin rudalics on Tue, 31 Dec 2019 10:57:55 +0100) Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: martin rudalics > Date: Tue, 31 Dec 2019 10:57:55 +0100 > > Now hit any other key. This sould shrink the echo area and redisplay > the *scratch* window as before but "extends" the vertical scroll bar > into the mode line. > > The reason for this behavior is that the vertical scroll bar height in > the first case is calculated from a window_box_height call where > ml_row->mode_line_p is set and thus ml_row->height is used. > > In the second case ml_row->mode_line_p is not set and the value is > taken via estimate_mode_line_height which, given the specification > from 'test-mode-line', doesn't estimate the height well. AFAICT, when the ml_row->mode_line_p flag is reset, ml_row->height is also zero, so disregarding the flag would not have helped us in this case. > For the record: Rewriting 'window_box_height' as > > int > window_box_height (struct window *w) > { > return WINDOW_BOX_TEXT_HEIGHT (w); > } > > fixes the problem here. Thanks, but that's not an idea I would like entertaining. As much as window_box_text_height and WINDOW_BOX_TEXT_HEIGHT look similar, there's a subtle difference between them. The latter is supposed not to be called during redisplay, because window's mode_line_height field is not guaranteed to be accurate then, and the fallback is the same estimate_mode_line_height which doesn't support non-character display elements. It is generally okay to use WINDOW_BOX_TEXT_HEIGHT in window.c, because that code runs outside of redisplay, and the window object should be up-to-date. But window_box_text_height is called _a_lot_ from within redisplay itself. And here we get to another subtlety: window_box_text_height uses the window's current_matrix, which might not be up-to-date yet, depending on where it is called, because we only update it in update_frame, and set_vertical_scroll_bar is called long before that. When a window is resized, as happens in this scenario when the echo-area message is cleared, the mode-line row changes to a different one (because it is always the last row of the window), and the new row didn't yet get updated. We have the correct data in the desired_matrix, but not in the current_matrix. I considered using the desired_matrix in this case, but that is also somewhat scary: the desired matrix could be very sparse under some redisplay optimizations, so we'd need some logic to verify the data is valid before using it. Eventually, a simpler solution is just to fall back to the window's mode_line_height field, before falling back to estimate_mode_line_height, because when the mode-line height changes, we schedule an immediate thorough redisplay of the window, and invalidate that window's mode_line_height field, to be recomputed by the rescheduled redisplay. See the proposed patch below. diff --git a/src/xdisp.c b/src/xdisp.c index 6b677b63ae..fab95076fe 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -1105,6 +1105,8 @@ window_box_height (struct window *w) : 0); if (ml_row && ml_row->mode_line_p) height -= ml_row->height; + else if (w->mode_line_height >= 0) + height -= w->mode_line_height; else height -= estimate_mode_line_height (f, CURRENT_MODE_LINE_FACE_ID (w)); } @@ -1117,6 +1119,8 @@ window_box_height (struct window *w) : 0); if (tl_row && tl_row->mode_line_p) height -= tl_row->height; + else if (w->tab_line_height >= 0) + height -= w->tab_line_height; else height -= estimate_mode_line_height (f, TAB_LINE_FACE_ID); } @@ -1129,6 +1133,8 @@ window_box_height (struct window *w) : 0); if (hl_row && hl_row->mode_line_p) height -= hl_row->height; + else if (w->header_line_height >= 0) + height -= w->header_line_height; else height -= estimate_mode_line_height (f, HEADER_LINE_FACE_ID); } From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 12:49:40 2020 Received: (at 38828) by debbugs.gnu.org; 1 Jan 2020 17:49:40 +0000 Received: from localhost ([127.0.0.1]:37524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imi7o-0004Y3-1S for submit@debbugs.gnu.org; Wed, 01 Jan 2020 12:49:40 -0500 Received: from mout.gmx.net ([212.227.15.18]:55245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imi7m-0004XZ-0y for 38828@debbugs.gnu.org; Wed, 01 Jan 2020 12:49:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1577900971; bh=N3akdgV71GpbFYgFZvysk36QRytzbBRyn4P05Xfi22A=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=K0s4Is+cOzWSfOg170IdqYO3XwRa1ckmxWL9N96fNNP3t068sJWPAOjJvmIL7XU0O +COqpwlaE55O3OqyEF/dgU49XwhnMpek4eI8YYwkAPSLvPd9IuaInImrgp7ACGxLAf IPQCB3TuSCaomLDos0A98fq3CFN0NBlKo9ogg3g8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.74]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N5VDE-1jor9l0exG-016vFp; Wed, 01 Jan 2020 18:49:31 +0100 Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar To: Eli Zaretskii References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> From: martin rudalics Message-ID: Date: Wed, 1 Jan 2020 18:49:30 +0100 MIME-Version: 1.0 In-Reply-To: <83tv5fjgxn.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------C0249E9C16D5493647A6148F" Content-Language: de-AT X-Provags-ID: V03:K1:parOrPpKV9OIS11BCm9sRS6WjGFmKN4AMZLvLvwBDI2IQGpb+tt JqStmtVN4G9Gb12o9dkfK7NUNNePuyNgbz8B1uuMxHZ1Le4PJ9O3DjgCBl41rHUyNcSLmIM 003oROeYnp+22bdNApkdwRDf4dVFz3E/4AwU99ME5upA4FNZqwjZ07Hva/UgXNo0LatmyIo bu9vZWkdb8eiXb7yycFnw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:yj8sgx4r7zw=:BS/lVEV6xhx23aDZL3A1Gb N65QsOXJdWqDZ51GGAsYxui3YRK7Dt1pGMsLfuSEEcmWRlbCqV3733euqJ5qznyHV3McCau+U 7U6TvT4GPRldzvmaO0c00x2ttEnOQaK0uMWXvUsVImJro7hPgygQO0Uk0/wsdycZQZ05m4duL A0d89gEImuGxxoHeCQ9b1dpFwMVG58hkyGRWdq6+3nnWScF6ngl/mtl2j2ebvhTEM/DFpU0IL AjTqvb9DU65Ql8D2qqxhyxPHfi4s6oeE9GDsESRgIjAApci2hODObZkn85hnPtHGRsMVpwQEV 1ry2L/0m49owAC5Kf2d0Z/xxSRHftUUAB15dmbwz/YzhkgQRwaV49MzE7wTuOlREZmMyN+75a 8Tjl8lVbv+i1bd77psF2PvX+beap6DOQ/CyF/mWV/ShYfPDj2z/xlwybLXDaBQCgKnfwPDZMn 5PLbRnIQhuLPH0rCy2kazkAvCNhYICK7KZM15xs51DvcfK1AYZ7mrGvbfCESkQAUJmngoKbhg D9sfOwf0YcfJb/h2i4eUw1eaRp3B1bIVcS/ymiD97BIT9PjvXK3xFdo5qIk5K/XCbBZX+xHZF aZrHzZk1FOdn7gVDNCDr4Ayjv5yWnkLsCoiD6zhg4gc4qIVHV+8JcVFKvhEL3eSoTgjJtxE2A Bl1NR+6Eo5zEx+3JtOVfj5EanAN6iMatLrWO/He1pMFjkA/eqkfY3dK5tBHmQW7H45KZGOz4m Sk900P/NKu/CBwt9Jkefp7gEuuBXsQdfO2wZFn53Esl3Y4gRRl56/0xdVYmJVsYgHstioqlXN daMYbAdd5oFwr2tQAHSRC6IuwzBT2HM/Mjxm7xljdcqu3RsxhexVxh+Q78xk4W4I5uoPW965P CEhnhIfQSl9f38/WA6l5Ao+0srMKIfumY0xGYLxohHgiwniXgsgOufRs8EvKw3SflrVtWZ+1G v+/QAybJzZctl8JdsjB2wXyiNZx0VfqwjTgwwU11G9U+P19wY4b3BMyrBmIpv971beWVZJnqV 3mAjRMKgiRi8fVe1XgPo0B9aFNhDN7Phmvu6iIGXozXRlFgnOqTp+8WcIq1XdeE2twYZr53Ow MvH82z5/d8h7ESmOL0Hpln7bD+8YATi2H08jOPWHvPLf7wJDji838llSfVC+GApN0l3k6wKDd irGXYJ1pLEKTSeYUf5eHXB3EddgsbM9HrsJENX7AN34/q483KEye9nvf0I6OylV+xmTwClxvF yXcNgmC/9omklORxuNknXA3Jw+2dOzQ5hTDH/yA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------C0249E9C16D5493647A6148F Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > AFAICT, when the ml_row->mode_line_p flag is reset, ml_row->height is > also zero, so disregarding the flag would not have helped us in this > case. Right, I've been there initially. >> For the record: Rewriting 'window_box_height' as >> >> int >> window_box_height (struct window *w) >> { >> return WINDOW_BOX_TEXT_HEIGHT (w); >> } >> >> fixes the problem here. > > Thanks, but that's not an idea I would like entertaining. Neither do I. > As much as > window_box_text_height "window_box_height" presumably, also everywhere below. > and WINDOW_BOX_TEXT_HEIGHT look similar, > there's a subtle difference between them. The latter is supposed not > to be called during redisplay, because window's mode_line_height field > is not guaranteed to be accurate then, Your patch does use it though. > and the fallback is the same > estimate_mode_line_height which doesn't support non-character display > elements. It is generally okay to use WINDOW_BOX_TEXT_HEIGHT in > window.c, window.c doesn't use it. It's used in xdisp.c only. And I'm sure it can return negative values, sometimes. So I presume we can do away with it then? > because that code runs outside of redisplay, and the window > object should be up-to-date. But window_box_text_height is called > _a_lot_ from within redisplay itself. And here we get to another > subtlety: window_box_text_height uses the window's current_matrix, > which might not be up-to-date yet, depending on where it is called, > because we only update it in update_frame, and set_vertical_scroll_bar > is called long before that. > > When a window is resized, as happens in this scenario when the > echo-area message is cleared, the mode-line row changes to a different > one (because it is always the last row of the window), and the new row > didn't yet get updated. We have the correct data in the > desired_matrix, but not in the current_matrix. I considered using the > desired_matrix in this case, but that is also somewhat scary: the > desired matrix could be very sparse under some redisplay > optimizations, so we'd need some logic to verify the data is valid > before using it. I've tried via w->mode_line_height = MATRIX_MODE_LINE_ROW (w->current_matrix)->height = DESIRED_MODE_LINE_HEIGHT (w); after displaying the mode lines without great success (likely because window_box_height didn't go for it then). > Eventually, a simpler solution is just to fall back > to the window's mode_line_height field, before falling back to > estimate_mode_line_height, because when the mode-line height changes, > we schedule an immediate thorough redisplay of the window, and > invalidate that window's mode_line_height field, to be recomputed by > the rescheduled redisplay. See the proposed patch below. This fails here when loading the attached test-popup-2.el and typing, for example, F2 F3 F2 . martin --------------C0249E9C16D5493647A6148F Content-Type: text/plain; charset=UTF-8; name="test-popup-2.el" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="test-popup-2.el" KGRlZnZhciBvbGQtbW9kZS1saW5lLWZvcm1hdCBtb2RlLWxpbmUtZm9ybWF0KQ0KDQooZGVm dW4gZm9vLW1lc3NhZ2UgKCZvcHRpb25hbCBuZXdsaW5lKQ0KICAobWVzc2FnZQ0KICAgKGNv bmNhdCAoaWYgbmV3bGluZSAiXG4iICIiKQ0KCSAgICJ0b3RhbDogJXMsIGJvZHk6ICVzLCBt b2RlOiAlcyIpDQogICAod2luZG93LXBpeGVsLWhlaWdodCkgKHdpbmRvdy1ib2R5LWhlaWdo dCBuaWwgdCkNCiAgICh3aW5kb3ctbW9kZS1saW5lLWhlaWdodCkpKQ0KDQooZGVmdW4gZm9v ICgpDQogIChpbnRlcmFjdGl2ZSkNCiAgKGZvby1tZXNzYWdlKSkNCg0KKGdsb2JhbC1zZXQt a2V5IFtmMV0gJ2ZvbykNCg0KKGRlZnVuIHRlc3QtcG9wdXAgKCkNCiAgKGludGVyYWN0aXZl KQ0KOzsgICAoc2V0LWZhY2UtYXR0cmlidXRlICdtb2RlLWxpbmUgbmlsIDpoZWlnaHQgMjAw KQ0KOzsgICAoc2V0LWZhY2UtYXR0cmlidXRlICdtb2RlLWxpbmUtaW5hY3RpdmUgbmlsIDpo ZWlnaHQgMjAwKQ0KICAoc2V0cQ0KICAgbW9kZS1saW5lLWZvcm1hdA0KICAgKGNvbnMgKHBy b3BlcnRpemUgIiAiICdkaXNwbGF5DQogICAgICAgICAgICAgICAgICAgICAoY3JlYXRlLWlt YWdlICIvKiBYUE0gKi8gc3RhdGljIGNoYXIgKiBpbWFnZVtdID0gew0KXCIzIDYwIDEgMVwi LA0KXCIwIGMgIzAwYWFmZlwiLA0KXCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLFxuXCIw MDBcIixcblwiMDAwXCIsDQpcIjAwMFwiLFxuXCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwi LFxuXCIwMDBcIiwNClwiMDAwXCIsXG5cIjAwMFwiLFxuXCIwMDBcIixcblwiMDAwXCIsXG5c IjAwMFwiLA0KXCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLFxuXCIwMDBcIixcblwiMDAw XCIsDQpcIjAwMFwiLFxuXCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLFxuXCIwMDBcIiwN ClwiMDAwXCIsXG5cIjAwMFwiLFxuXCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLA0KXCIw MDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLFxuXCIwMDBcIixcblwiMDAwXCIsDQpcIjAwMFwi LFxuXCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLFxuXCIwMDBcIiwNClwiMDAwXCIsXG5c IjAwMFwiLFxuXCIwMDBcIixcblwiMDAwXCIsXG5cIjAwMFwiLA0KXCIwMDBcIixcblwiMDAw XCIsXG5cIjAwMFwiLFxuXCIwMDBcIixcblwiMDAwXCIsDQpcIjAwMFwiLFxuXCIwMDBcIixc blwiMDAwXCIsXG5cIjAwMFwiLFxuXCIwMDBcIiwNClwiMDAwXCIsXG5cIjAwMFwiLFxuXCIw MDBcIixcblwiMDAwXCIsXG5cIjAwMFwiDQp9OyIgJ3hwbSB0IDphc2NlbnQgJ2NlbnRlcikp DQoJIG1vZGUtbGluZS1mb3JtYXQpKQ0KICAoZm9vLW1lc3NhZ2UgdCkpDQoNCihnbG9iYWwt c2V0LWtleSBbZjJdICd0ZXN0LXBvcHVwKQ0KDQooZGVmdW4gYmFyICgpDQogIChpbnRlcmFj dGl2ZSkNCiAgKHNldHEgbW9kZS1saW5lLWZvcm1hdCBvbGQtbW9kZS1saW5lLWZvcm1hdCkp DQoNCihnbG9iYWwtc2V0LWtleSBbZjNdICdiYXIpDQo= --------------C0249E9C16D5493647A6148F-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 09:15:06 2020 Received: (at 38828) by debbugs.gnu.org; 2 Jan 2020 14:15:06 +0000 Received: from localhost ([127.0.0.1]:38391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1in1Fh-0005w4-EW for submit@debbugs.gnu.org; Thu, 02 Jan 2020 09:15:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1in1Ff-0005vH-Pc for 38828@debbugs.gnu.org; Thu, 02 Jan 2020 09:15:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1in1Fa-0008Q9-AX; Thu, 02 Jan 2020 09:14:58 -0500 Received: from [176.228.60.248] (port=4656 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1in1FZ-0003Iy-OM; Thu, 02 Jan 2020 09:14:58 -0500 Date: Thu, 02 Jan 2020 16:15:13 +0200 Message-Id: <8336cyj66m.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: (message from martin rudalics on Wed, 1 Jan 2020 18:49:30 +0100) Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 38828@debbugs.gnu.org > From: martin rudalics > Date: Wed, 1 Jan 2020 18:49:30 +0100 > > > and the fallback is the same > > estimate_mode_line_height which doesn't support non-character display > > elements. It is generally okay to use WINDOW_BOX_TEXT_HEIGHT in > > window.c, > > window.c doesn't use it. It's used in xdisp.c only. And I'm sure it > can return negative values, sometimes. So I presume we can do away > with it then? I think we could. But I'd rather not do that on the emacs-27 branch, not unless we find situations where it actually causes bugs. > > Eventually, a simpler solution is just to fall back > > to the window's mode_line_height field, before falling back to > > estimate_mode_line_height, because when the mode-line height changes, > > we schedule an immediate thorough redisplay of the window, and > > invalidate that window's mode_line_height field, to be recomputed by > > the rescheduled redisplay. See the proposed patch below. > > This fails here when loading the attached test-popup-2.el and typing, > for example, F2 F3 F2 . There's more than one problem here (didn't you wonder why pressing F3 doesn't immediately redraw the mode line?). A more thorough patch is below. The dispnew.c part is semi-cleanup: it isn't strictly needed after the changes in window_box_height, although originally that flag not being reset upon window resizing was exactly the root cause for the problem after "F2 up". But I don't like the idea of this flag remaining set, even if no one should be looking at it. Hmm... maybe I should reset the flag even if we did reallocate current_matrix... diff --git a/lisp/frame.el b/lisp/frame.el index c533e5a23f..16ee7580f8 100644 --- a/lisp/frame.el +++ b/lisp/frame.el @@ -2725,6 +2725,9 @@ 'automatic-hscrolling line-prefix wrap-prefix truncate-lines + mode-line-format + header-line-format + tab-line-format display-line-numbers display-line-numbers-width display-line-numbers-current-absolute diff --git a/src/dispnew.c b/src/dispnew.c index b2a257090c..8fe72df7ed 100644 --- a/src/dispnew.c +++ b/src/dispnew.c @@ -534,6 +534,13 @@ adjust_glyph_matrix (struct window *w, struct glyph_matrix *matrix, int x, int y eassert (left >= 0 && right >= 0); matrix->left_margin_glyphs = left; matrix->right_margin_glyphs = right; + + /* If we are resizing a window without allocating new rows, make + sure the previous mode-line row of the window's current + matrix is no longer marked as such. */ + if (w && matrix == w->current_matrix + && dim.height != matrix->nrows && !new_rows) + MATRIX_MODE_LINE_ROW (matrix)->mode_line_p = false; } /* Number of rows to be used by MATRIX. */ diff --git a/src/xdisp.c b/src/xdisp.c index 6b677b63ae..4856a7b13b 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -1093,44 +1093,59 @@ window_box_height (struct window *w) /* Note: the code below that determines the mode-line/header-line/tab-line height is essentially the same as that contained in the macro - CURRENT_{MODE,HEADER}_LINE_HEIGHT, except that it checks whether - the appropriate glyph row has its `mode_line_p' flag set, - and if it doesn't, uses estimate_mode_line_height instead. */ + CURRENT_{MODE,HEADER,TAB}_LINE_HEIGHT, except that it checks whether + the appropriate glyph row has its `mode_line_p' flag set, and if + it doesn't, uses estimate_mode_line_height instead. */ if (window_wants_mode_line (w)) { - struct glyph_row *ml_row - = (w->current_matrix && w->current_matrix->rows - ? MATRIX_MODE_LINE_ROW (w->current_matrix) - : 0); - if (ml_row && ml_row->mode_line_p) - height -= ml_row->height; + if (w->mode_line_height >= 0) + height -= w->mode_line_height; else - height -= estimate_mode_line_height (f, CURRENT_MODE_LINE_FACE_ID (w)); + { + struct glyph_row *ml_row + = (w->current_matrix && w->current_matrix->rows + ? MATRIX_MODE_LINE_ROW (w->current_matrix) + : 0); + if (ml_row && ml_row->mode_line_p) + height -= ml_row->height; + else + height -= estimate_mode_line_height (f, + CURRENT_MODE_LINE_FACE_ID (w)); + } } if (window_wants_tab_line (w)) { - struct glyph_row *tl_row - = (w->current_matrix && w->current_matrix->rows - ? MATRIX_TAB_LINE_ROW (w->current_matrix) - : 0); - if (tl_row && tl_row->mode_line_p) - height -= tl_row->height; + if (w->tab_line_height >= 0) + height -= w->tab_line_height; else - height -= estimate_mode_line_height (f, TAB_LINE_FACE_ID); + { + struct glyph_row *tl_row + = (w->current_matrix && w->current_matrix->rows + ? MATRIX_TAB_LINE_ROW (w->current_matrix) + : 0); + if (tl_row && tl_row->mode_line_p) + height -= tl_row->height; + else + height -= estimate_mode_line_height (f, TAB_LINE_FACE_ID); + } } if (window_wants_header_line (w)) { - struct glyph_row *hl_row - = (w->current_matrix && w->current_matrix->rows - ? MATRIX_HEADER_LINE_ROW (w->current_matrix) - : 0); - if (hl_row && hl_row->mode_line_p) - height -= hl_row->height; - else - height -= estimate_mode_line_height (f, HEADER_LINE_FACE_ID); + if (w->header_line_height >= 0) + height -= w->header_line_height; + { + struct glyph_row *hl_row + = (w->current_matrix && w->current_matrix->rows + ? MATRIX_HEADER_LINE_ROW (w->current_matrix) + : 0); + if (hl_row && hl_row->mode_line_p) + height -= hl_row->height; + else + height -= estimate_mode_line_height (f, HEADER_LINE_FACE_ID); + } } /* With a very small font and a mode-line that's taller than From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 14:19:14 2020 Received: (at 38828) by debbugs.gnu.org; 2 Jan 2020 19:19:14 +0000 Received: from localhost ([127.0.0.1]:40040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1in602-0005dw-CF for submit@debbugs.gnu.org; Thu, 02 Jan 2020 14:19:14 -0500 Received: from mout.gmx.net ([212.227.17.22]:40757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1in5zz-0005dh-Lx for 38828@debbugs.gnu.org; Thu, 02 Jan 2020 14:19:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1577992745; bh=2j9TnogS+TfrJZNN4v7YgqjEpwe0R2WFJ7OU44pLZdc=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=ldWvR5C4jVlpN+9pBoPtbbO+XminBvUmW4U3p70YRWyfbxYNw+e5/+qCYwOyJsRH2 ncjaZdMbAhiMzDUI4U1YH0pQ1YeHvB7p41bzM2sGTIv/RaFop+Q+Zt3eLuptW8+29g 0Chs+xnVa2nHvWsLZhhzD6qQ2GkzYBsQfEXQzY4E= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.247]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N0oG5-1jhYjt3vfR-00wn6F; Thu, 02 Jan 2020 20:19:05 +0100 Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar To: Eli Zaretskii References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> From: martin rudalics Message-ID: Date: Thu, 2 Jan 2020 20:19:05 +0100 MIME-Version: 1.0 In-Reply-To: <8336cyj66m.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:ijpZKtO1gJf8oSuOB50xd4Ss/IXVVhYGOefWynCkJCbKfBDMaUW 5ak3H/fB6jCD9nNQSqo37tLh4XT1KJgk+hvnEU4Rl/CLVD7vm9eOOKOr8y48fPoFOYIOzvn u1HxbkESJWeBovY8DLjC4vUBxpbCdiHJBA6VOGcHZ+6iQeQLrG1gAWxgcYEcMeiYuQ4gooY sitcg7Jz4LaW+EKk3k44A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ereR9hmAyQU=:h5o9AF6km9LrTRO8+eeqKt 41i8ByrZgzg9PRICHrGYllvmwfkDqlfG/VjDVfoUoHq+GMDVP0hvmVRIRbgpBbTAzsytzwdif ypQJ/aGueof5P4HT6+DLsmCDa8mXpcsW2CXA/zCATMTDRC/LnR4qK41k97SBSn+ypV1w9SstK 2+16WR+mPFsveFnWm50qst3VG6dLfB6tT/KSmzZ5f/5TA3qHX0mbWxj2XwU1fc5ko3L/ye0ui uXdO5rmjBgkIIIbKPeriRtXVW5a6P1NcHPsIRXoPvhMqBwKAZUyWtKv3GSAjdnZxeGE7LNDJS DeF38ygCNCfbB2MoSbx4GO60/xI4mq5ebVDsFajZT2K5++twWLrCbIS1S7Mgx3VpVo1dkfpAs LPU5DLWg2e9SBKJoiHQDWnmlHUY4Qkw3/wbEU0KMwCWEnRJwvkjK1uAFnDjoM2JhWwbRxPi6r AMpzMv8EMpfEOo5kee7u3YHvQDoylxjB5ycmYx402/gUAWpwV1AD3jdiIx71+CkrCuKaCeHXM aw3rHg+uImVtKj2U2fIhi8Jdt+OTV5CFQZjOzu6Ybk6Sh6uyQ/N0A/FylmGpVtXcanGrFPQbc R0mzckY/Ng7g7zOdQgrATS89Z9UHi2cAjNjO4UTcmpyddZyw6Xv6uzTs0+hfTMV9dFM6K0pTM uK1u56+flrvBVFpt3sGaxs1YAgvpJAm4VPefVmsuO4riuRa9o6WJ6gOoeJz5i132XWebff5/Y FwFZVwIp5WZBA7nuT5iHYq91rZVMnEjTfVDUBMg5JuoKRnNPWbBZSzbT19cMnuP9WUOUUPp0Q Xesr+27sEEQ+MzY+mp/ITWpLa3FtdnpfXN6P7Xhwp1YRJW0x3mi8Isa2APN2NX83m7d8Q8ZoU DNuNRIHQM9mf/VC+VPqVUgIhp39cGNz6BRrf0N1x8VztHkWTG5KbJqXfzwjXoArmOY8efD+YC HMq5tNQJEkSdooWWcKRV0I0g+OE3le1+A8v/CGF5IeUDd65bJz8DfqLo+uXJMH3YX5BKrCcPZ itYW9SaTSlyyvHqz4qRglR3hrKUe+B0XUk8t3YcyxtEh0GJdV2okX2CgLcLabqFfuZbPc0N2p bjwp9rs/JnkVBZqJF1nGu5ki7oUDQCsFyMwhBL3yBu4JJwTj+AghzZiMnn9YKOWZZds6o7/TH XiUWFDUOm8WJjLVvz4Cc7kTrNorXO0R5Fl4FUE1/5svVLxiTT+pBw6sY5sCxaqRdr0jJzTMn5 r6MUvp2vxaL03qeCAbrLuejkYdTXsPTqop/Dr9A== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> window.c doesn't use it. It's used in xdisp.c only. And I'm sure it >> can return negative values, sometimes. So I presume we can do away >> with it then? > > I think we could. But I'd rather not do that on the emacs-27 branch, > not unless we find situations where it actually causes bugs. Agreed. I'd be more interested anyway in (1) getting the ml_row && ml_row->mode_line_p check into CURRENT_MODE_LINE_HEIGHT (if that makes sense) so we could use CURRENT_MODE_LINE_HEIGHT everywhere (maybe without its embedded assignment) and (2) improve and (remove from there) the && WINDOW_PIXEL_HEIGHT (w) > WINDOW_FRAME_LINE_HEIGHT (w)); check from window_wants_mode_line to use the latest calculated mode line height instead. I'd like to reserve one bit for each window's scroll bars, margins, fringes, mode lines whether they would fit into the window and suppress their display if they don't. This would mean that one can easily shrink a window to some bare minimum, maybe even to zero height/width. > There's more than one problem here (didn't you wonder why pressing F3 > doesn't immediately redraw the mode line?). It never did that unless I changed the size of some window too, so why should I have wondered? > A more thorough patch is > below. It's a pleasant experience now. How expensive is watching a variable? So far I was convinced this would be used for debugging purposes only. > The dispnew.c part is semi-cleanup: it isn't strictly needed > after the changes in window_box_height, although originally that flag > not being reset upon window resizing was exactly the root cause for > the problem after "F2 up". But I don't like the idea of this flag > remaining set, even if no one should be looking at it. Hmm... maybe I > should reset the flag even if we did reallocate current_matrix... What does "resizing a window without allocating new rows" encompass? Is this only shrinking the window height ('shrink-/split-window') or also making a special line like the mode line taller (eating away some of the remaining matrix lines, naively spoken)? martin From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 14:59:03 2020 Received: (at 38828) by debbugs.gnu.org; 2 Jan 2020 19:59:03 +0000 Received: from localhost ([127.0.0.1]:40072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1in6cY-0006ZW-FW for submit@debbugs.gnu.org; Thu, 02 Jan 2020 14:59:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1in6cW-0006Yq-1r for 38828@debbugs.gnu.org; Thu, 02 Jan 2020 14:59:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1in6cQ-0007CS-JK; Thu, 02 Jan 2020 14:58:54 -0500 Received: from [176.228.60.248] (port=2011 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1in6cP-0005S7-AJ; Thu, 02 Jan 2020 14:58:54 -0500 Date: Thu, 02 Jan 2020 21:58:49 +0200 Message-Id: <83v9ptiq9y.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: (message from martin rudalics on Thu, 2 Jan 2020 20:19:05 +0100) Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 38828@debbugs.gnu.org > From: martin rudalics > Date: Thu, 2 Jan 2020 20:19:05 +0100 > > > There's more than one problem here (didn't you wonder why pressing F3 > > doesn't immediately redraw the mode line?). > > It never did that unless I changed the size of some window too, so why > should I have wondered? Well, because if you don't do anything after F3, the mode line stays without update forever. > How expensive is watching a variable? Just an extra 'if' in a few places where we set the variable, to check if it's being watched. Grep the sources for SYMBOL_TRAPPED_WRITE. > So far I was convinced this would be used for debugging purposes only. You can see at the end of frame.el we have a list of variables we watch that have nothing to do with debugging. > What does "resizing a window without allocating new rows" encompass? > Is this only shrinking the window height ('shrink-/split-window') or > also making a special line like the mode line taller (eating away some > of the remaining matrix lines, naively spoken)? Glyph matrices don't care about the pixel size of the window, they only care about the maximum number of glyph rows they can accommodate. So increasing the size of a mode line has the effect of making the window's glyph matrices use fewer rows (assuming the window's pixel size doesn't change). In addition, a GUI window usually has a matrix allocated for more rows than it actually uses, which is why each matrix has both 'nrows' and 'rows_allocated' members, and the former is likely to be smaller than the latter. When a window's resize needs less rows that 'rows_allocated', there's no reallocation, just a change in the 'nrows' field. But I now think that we need to reset the mode_line_p flag even if we reallocate, because the rows which existed before reallocation are copied to the enlarged matrix, so that flag is kept. So I think I will install the patch with that small change. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 02:31:46 2020 Received: (at 38828-done) by debbugs.gnu.org; 3 Jan 2020 07:31:46 +0000 Received: from localhost ([127.0.0.1]:40360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inHQw-00008V-Ha for submit@debbugs.gnu.org; Fri, 03 Jan 2020 02:31:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inHQu-00008H-KN for 38828-done@debbugs.gnu.org; Fri, 03 Jan 2020 02:31:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inHQp-0003HN-1F; Fri, 03 Jan 2020 02:31:39 -0500 Received: from [176.228.60.248] (port=4176 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inHQl-0000YJ-V0; Fri, 03 Jan 2020 02:31:36 -0500 Date: Fri, 03 Jan 2020 09:31:33 +0200 Message-Id: <83mub5hu7e.fsf@gnu.org> From: Eli Zaretskii To: Eli Zaretskii In-reply-to: <83v9ptiq9y.fsf@gnu.org> (message from Eli Zaretskii on Thu, 02 Jan 2020 21:58:49 +0200) Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38828-done Cc: rudalics@gmx.at, 38828-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 02 Jan 2020 21:58:49 +0200 > From: Eli Zaretskii > Cc: 38828@debbugs.gnu.org > > But I now think that we need to reset the mode_line_p flag even if we > reallocate, because the rows which existed before reallocation are > copied to the enlarged matrix, so that flag is kept. So I think I > will install the patch with that small change. Done, and closing the bug. Thanks for the test cases and the feedback. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 04:38:54 2020 Received: (at 38828) by debbugs.gnu.org; 3 Jan 2020 09:38:54 +0000 Received: from localhost ([127.0.0.1]:40403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inJPy-00031j-KH for submit@debbugs.gnu.org; Fri, 03 Jan 2020 04:38:54 -0500 Received: from mout.gmx.net ([212.227.15.18]:59443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inJPw-00031W-PH for 38828@debbugs.gnu.org; Fri, 03 Jan 2020 04:38:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1578044326; bh=x1fZw3uoM7FeKT1BMfipjG/CbcONrRgON/ktUOjZrBM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=QXoS6wTm2nrLP73sCHlBUWN3djHEXxr0MLla86BD9db4qR5o96I+HGD531W5X95mS BgkAM1HitYndce1tqyjFaf8f/Tc8b/WmDjXEDnAIwQHr94V973kIxfnNG5npgkshji xyIGFQS4RLyPflCW76PtLkttgjdvpwnOCUauSYRQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([46.125.249.56]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MHXFr-1j0HqB0tQ9-00Daji; Fri, 03 Jan 2020 10:38:46 +0100 Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar To: Eli Zaretskii References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> From: martin rudalics Message-ID: <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> Date: Fri, 3 Jan 2020 10:38:46 +0100 MIME-Version: 1.0 In-Reply-To: <83v9ptiq9y.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:bA8qo+XfhQNoDBo5wv9rqbny1NlTmGL+LFBM4qqbp5UrzTkyZoL IFwPOuQMFmcSJS5+NVlTb4OZeOCTyMuIPqr6zsUYcE61FMIwzGfNYKN4hC2dbjlCQiv9crv qTF/Rw3+fdZsD8e3DZRcfg0T2x88xQXZkUUoIeGx6qtBGim/08nr9JUmojFSXGynvk7X6F8 wEuy97JPRRymVmri46BVQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:FE0GXMF4pBk=:Uaz3tORglOTZahJ6/uHhsl u5gtaALG1lvYZtL1zBLTJFEgQF9Eqp7hYnO2oTn3/RmGVJpgdPzScLbJmaASKtLKrj9DA2g3d omm0lOByqCuLCZLGJkha6kYnbxwzTk3B+hNmQi/kJdUQGCOONncGaDNAEbexBw3qA4fwkX3bs Q5XgCT+9MdJssn1r6OmtyoEZhLVPbGOM8ZTPYBj22f8yAUCdHqBBLu3CakOqMraOty+X5CAC9 EgmOJHOPYJEL8HE2pkfVmSfF3R/nrT4gMVL1wnyFgt4XfOnDiERMjQFB7Bm9ckSNjbqEGoonN S2j7UbzIy5MCE624fU7Mry/zo7EeZ8tPNRtKpZocKr6jQiQGLNYRQPsTCDRDUmBAz8Gvv2ANe X5xQgXuxw2uBNz4rTuSVAL2i0vB/x4uB3d7QXwq6h/vF0d0aGg3szHXErvRtmOKAwUdLJgZep sexvprHBl0v45SW1Dsjc0hRLCIPC3rG0RpL55Cy5koeB8pS3Oi7gqbk6D/zJJ1ioDqULnkc9h BkOOEGWrGXemkcFICYHMQAci8//pbNGvd6g+Z960eri67FkwiYXMI5YuQAuqtDKdLH3lUujtD bjEiCkRsUPLBptDhqWGjQf+Zbwdi1Q/sluxmjyPFlNJFvNLhwmUyogaYPc1mEUYuPxaa8Aum+ 9AFo93BID6HHsOxGvtTT0V8rP0A+U3PvTOJ3dcqnb/znFIjeN76P2MGfAmmm8AYHG74jv3cZK F0H0l9xqyU6dpK9xqyXVM8GVLUE7JR5Q48TM3kIPoXqr7cx1LJEAwHE21DG7mMg8RC7tRML5B EI7nTtS63qqnpiXSy4cd+zy2HYHHbxv17XjBl9Czp02kEXPRZqhj3rOw2p+Z7nSOaTlg5VnC5 OhL7/KaETWT6mxywKV64+2DlzBb+MVA/CjZC0xz+ewKnjdj44XGUNqdK2/NmGhvlaQEExcvBa 5w0wLrO+SR+gnI/IYJoHdXOpyIBHw4UwlEnBKAslr/5xv+fD4j3uPX+nIqAEbstUSndA9Zd0u HG9Ai1bmn91yxpERxtR8gXGuc+K+/1WFxC7yaE+4UgRn9NjUsyMiAMvJBrisdFTisjxXZ2q5Y xetLYio94kpATWLZ60wnuLzxQeJVa1M1rBJa4F6nZCFEYuWK6aeH/umZlpiwRlj3SPmTZFWIR 4sHlyS4V595I9ySJCm4LvSvIl8/3KWmZO8o0PEBKMgpP6N7WYhiPotOMgqErdTGPoZjspO9Hi 8hpdwkD/penhhRKIzDXwFdM4W1Py0wIje/BUJTdKYAh4uUYVPcUrho8cKEO8= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > You can see at the end of frame.el we have a list of variables we > watch that have nothing to do with debugging. I noticed that in the meantime. So we could easily add, for example, 'scroll-bar-width' to that list and simplify text like the following If you do not specify a window=E2=80=99s scroll bar settings via =E2=80=98set-window-scroll-bars=E2=80=99, the buffer-local variables =E2=80=98vertical-scroll-bar=E2=80=99, =E2=80=98horizontal-scroll-bar=E2= =80=99, =E2=80=98scroll-bar-width=E2=80=99 and =E2=80=98scroll-bar-height=E2=80=99 in the buffer being displayed cont= rol the window=E2=80=99s scroll bars. The function =E2=80=98set-window-buffer=E2=80=99 examine= s these variables. If you change them in a buffer that is already visible in a window, yo= u can make the window take note of the new values by calling =E2=80=98set-window-buffer=E2=80=99 specifying the same buffer that is= already displayed. in the Elisp manual? I wonder why Fset_buffer_redisplay apparently doesn't have to call bset_redisplay to redisplay_other_windows. What am I missing here? > Glyph matrices don't care about the pixel size of the window, =2E.. but when the pixel height grows we may have to allocate new glyph rows too, I suppose ... > they > only care about the maximum number of glyph rows they can > accommodate. So increasing the size of a mode line has the effect of > making the window's glyph matrices use fewer rows (assuming the > window's pixel size doesn't change). In addition, a GUI window > usually has a matrix allocated for more rows than it actually uses, > which is why each matrix has both 'nrows' and 'rows_allocated' > members, and the former is likely to be smaller than the latter. When= > a window's resize =2E.. where a "resize" includes changes of its buffer's default face font, line spacing, the mode line height ... > needs less rows that 'rows_allocated', there's no > reallocation, just a change in the 'nrows' field. > > But I now think that we need to reset the mode_line_p flag even if we > reallocate, because the rows which existed before reallocation are > copied to the enlarged matrix, so that flag is kept. So I think I > will install the patch with that small change. Works fine now. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 05:19:52 2020 Received: (at 38828) by debbugs.gnu.org; 3 Jan 2020 10:19:52 +0000 Received: from localhost ([127.0.0.1]:40423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inK3c-0003xy-DT for submit@debbugs.gnu.org; Fri, 03 Jan 2020 05:19:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inK3b-0003xo-Nj for 38828@debbugs.gnu.org; Fri, 03 Jan 2020 05:19:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46394) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inK3V-0006zf-TB; Fri, 03 Jan 2020 05:19:45 -0500 Received: from [176.228.60.248] (port=3005 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inK3V-0006C8-3G; Fri, 03 Jan 2020 05:19:45 -0500 Date: Fri, 03 Jan 2020 12:19:42 +0200 Message-Id: <83a774j0zl.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> (message from martin rudalics on Fri, 3 Jan 2020 10:38:46 +0100) Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 38828@debbugs.gnu.org > From: martin rudalics > Date: Fri, 3 Jan 2020 10:38:46 +0100 > > > You can see at the end of frame.el we have a list of variables we > > watch that have nothing to do with debugging. > > I noticed that in the meantime. So we could easily add, for example, > 'scroll-bar-width' to that list and simplify text like the following > > If you do not specify a window’s scroll bar settings via > ‘set-window-scroll-bars’, the buffer-local variables > ‘vertical-scroll-bar’, ‘horizontal-scroll-bar’, ‘scroll-bar-width’ and > ‘scroll-bar-height’ in the buffer being displayed control the window’s > scroll bars. The function ‘set-window-buffer’ examines these variables. > If you change them in a buffer that is already visible in a window, you > can make the window take note of the new values by calling > ‘set-window-buffer’ specifying the same buffer that is already > displayed. > > in the Elisp manual? Yes, I think so. You can easily try that yourself, though. > I wonder why Fset_buffer_redisplay apparently doesn't have to call > bset_redisplay to redisplay_other_windows. What am I missing here? Probably the fact that prevent_redisplay_optimizations_p is stronger than windows_or_buffers_changed? > > Glyph matrices don't care about the pixel size of the window, > > ... but when the pixel height grows we may have to allocate new glyph > rows too, I suppose ... Yes. > > they > > only care about the maximum number of glyph rows they can > > accommodate. So increasing the size of a mode line has the effect of > > making the window's glyph matrices use fewer rows (assuming the > > window's pixel size doesn't change). In addition, a GUI window > > usually has a matrix allocated for more rows than it actually uses, > > which is why each matrix has both 'nrows' and 'rows_allocated' > > members, and the former is likely to be smaller than the latter. When > > a window's resize > > ... where a "resize" includes changes of its buffer's default face > font, line spacing, the mode line height ... Right. > > But I now think that we need to reset the mode_line_p flag even if we > > reallocate, because the rows which existed before reallocation are > > copied to the enlarged matrix, so that flag is kept. So I think I > > will install the patch with that small change. > > Works fine now. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 05:43:23 2020 Received: (at 38828) by debbugs.gnu.org; 3 Jan 2020 10:43:23 +0000 Received: from localhost ([127.0.0.1]:40428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inKQN-0004Vx-Dv for submit@debbugs.gnu.org; Fri, 03 Jan 2020 05:43:23 -0500 Received: from mout.gmx.net ([212.227.15.15]:43331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inKQL-0004Vi-9d for 38828@debbugs.gnu.org; Fri, 03 Jan 2020 05:43:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1578048194; bh=EjuYj+YYjv9sNSfA9A4FBZdqg/M5lHpcbBCAVEPDn4Q=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=BtECp2qe94Pv2f99i0BBbqrpyw/wC+sDGIKapEgaaIPb80aNaFN68WH6oI1YlbJtx /Ewc07U/IzchbuK22NLGvIJFi+IuTPsbBC7PPO5kxGGeapTb53E5kjpXAFBzPFOfp0 P4XGlF2whXqtapKXAGqMUQ6YnO6nj3Kf4RDBOPEc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([46.125.249.56]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N2V0H-1jj2Bp1rjz-013rSC; Fri, 03 Jan 2020 11:43:14 +0100 Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar To: Eli Zaretskii References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> <83a774j0zl.fsf@gnu.org> From: martin rudalics Message-ID: Date: Fri, 3 Jan 2020 11:43:15 +0100 MIME-Version: 1.0 In-Reply-To: <83a774j0zl.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:trPFtfNJNsKKtgbjGoAZ87XPrFEqkCG9LwJ1pyNOwjWhNUz/zLC lxHnCIEwWyo4LE1Hl1mmN7t45pwuXSgR+g68wP6aj7q3Yy/YjAdzVFh3EbM3RfKM2dvtmCB enS95tya8Z4kO/U/vTr34OmhgrEi0/0pnOnVVnG2VJO22r4g0Eq/zEJHQisEZIQm4uSzjDS 9+vgYXlBlKK7mL6FqVRfQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:OQZ7sHbNQVs=:QVzVhTQ4QOOQ+UwB3fc+9P u6TKgbO6/bzmEgvylOXDGKbP/Oeqh7YbJNMYN1UaATw9XbBqyvQm0Ry/o7gGW5E4acjCUa0QE RKBRHID9b6Jz92149eorE6r3Qs0/GU6rlQvPxXEo+iDGPKlHDiZkI6UkH1FsCkRwdRVRKFGQr yWoePFbjsTE3Gb2K/Ykgmpdz356KGpQ5SlHCdisZmTxoT0dpQ+w2GH/ioDxC/4cfb9y2fqZJ+ /K5By7kmJ6yRdAL+y2wMJWOfmcjG+ZBQ4XTydraZ7/c9dokUa/Nk/uDj9W/i5SxdYezQm22f3 IGOYgnLLi8LAtOosW1xFPX4B0qT45ZPyn1UJEt0UTKFiNZPi1W2wIrjLSlXyzQryKqHv5ZPOk 9puR8eHE7CuIVMNt29tO4kvLcm+MFx79khyNRfZKZ6uhf2nAbixif0/1XN4emEcZh1n4DyeGz q2uw3zbqtHC7QsoLTpv0GMemSMmDAsdZxq9L1WVNveWzJxT+/zfV77XA6VP6nzw9GPOqmPcIl zcpu+MuWzJRkOzf9zeCoNMyyoA1SNlcqFN/voK4gvFF1hMwt8Ye4AKCiUP1IKqh/z8yJULvA4 p8QqE0+7PqCUqQN+vG8IdZbhKw1EqqdZ2lL0R1MPZbsw59Ah6SnYZJhXneIQZicup8rKOfWHi CADAul8jKVEv+Q9zYVkZFFaMMgY+mekWjhNmcfksiIGMakAc57Cs4mKoV9FqWBqMKzMv4LmwI 49mjahceOQcYRwf1J068rXkqDoxzGlOE4vnVNRaa0hCld9+KjfAGqRyFX4ZAWrD5PG7aV9eAX nEAFWQ2PmiZfrXPbSPrpJkH9XXiNtG7gTivoq7DjBCAJb4ZQB1yVeQM9M2y2sLn92mKQdtKd0 AL+474GDeUrC3ZSfgMOmqpdfnoGXjhvX571FvAbhHMht0Rx96YE+gorTfNVyn5qtDKsJXc70A wxg/8LelCv8rjkKRIhp74KGUb5W63Fh+SEAnE5O1OgaMpAy8Zdck5z+dMWR7x5jVD4bbzyx54 2lBYBGb3pgBrHWWDXXQqB4LKtAhH8m8gqOfH4sYpoccK3YyJZYlh02+RwD71fbgiU+aahB1Kz Malo/6fy+zMbIHLUN1TvxfXVMLu818CwDwzOdAg6jNO4MYEbl1Yi8gB3G8i0yb8wrUBFfuxPd 58iFwuU0T1+hz6c4EGmHtC3bzZ++N3GdSaNr71Z0s7HzhmOdhzsFNo8Ybdnv4U7ajLBVSohdZ P8k7mfDWIqIx0oMewoEHn90CISU+YJP1UkSggig== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Yes, I think so. You can easily try that yourself, though. Will do. On master though and as soon as I can build again (Paul's last commit broke that on Windows here). martin From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 08:08:12 2020 Received: (at 38828) by debbugs.gnu.org; 3 Jan 2020 13:08:12 +0000 Received: from localhost ([127.0.0.1]:40484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inMgW-0001Yx-2V for submit@debbugs.gnu.org; Fri, 03 Jan 2020 08:08:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inMgU-0001Yk-5G for 38828@debbugs.gnu.org; Fri, 03 Jan 2020 08:08:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inMgM-0003Tk-9d; Fri, 03 Jan 2020 08:08:04 -0500 Received: from [176.228.60.248] (port=1303 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inMgL-0002v9-GR; Fri, 03 Jan 2020 08:08:02 -0500 Date: Fri, 03 Jan 2020 15:07:59 +0200 Message-Id: <838smoit74.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: (message from martin rudalics on Fri, 3 Jan 2020 11:43:15 +0100) Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> <83a774j0zl.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 38828@debbugs.gnu.org > From: martin rudalics > Date: Fri, 3 Jan 2020 11:43:15 +0100 > > > Yes, I think so. You can easily try that yourself, though. > > Paul's last commit broke that on Windows here It did? what are the signs of the breakage? (It does build for me.) From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 10:57:20 2020 Received: (at 38828) by debbugs.gnu.org; 3 Jan 2020 15:57:20 +0000 Received: from localhost ([127.0.0.1]:41301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inPKC-0005nk-13 for submit@debbugs.gnu.org; Fri, 03 Jan 2020 10:57:20 -0500 Received: from mout.gmx.net ([212.227.15.18]:43543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inPKA-0005nV-JQ for 38828@debbugs.gnu.org; Fri, 03 Jan 2020 10:57:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1578067031; bh=DpSpmES7uMt6JuV3avMp+Acfh4DwsP5ciLi7LtEpj+s=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=IxLgu1wjguD1bD5pXR9spq1N/smVsf6FWTxoMBhEO88tx6YrkuQdphzUBaXsHzIZ9 HqF/zmV+oNOQTN3WTtOi90h7ll9CxMjijUwXbMgM4tnGjLUeIlWhNE1JLmaMZ+JHoQ Ygjm6i0ourP2SWcu+83sPg07kalGubJ26kVTwaWU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.35]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MfpOd-1jOh942cKv-00gKbl; Fri, 03 Jan 2020 16:57:11 +0100 Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar To: Eli Zaretskii References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> <83a774j0zl.fsf@gnu.org> <838smoit74.fsf@gnu.org> From: martin rudalics Message-ID: <817f86da-0b80-1f67-0761-d04046f6c93d@gmx.at> Date: Fri, 3 Jan 2020 16:57:12 +0100 MIME-Version: 1.0 In-Reply-To: <838smoit74.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:B4U/qVCGoiOkeyCiOWjEroFvk4WJe9Gu8DIvw/V5QHyX8N44ZVW 8bWTuzKSauNbsScnqHMQjKkzsP70/L2yKWRrCVzWL40Pb9ZeyNh/7leXZ8FBYjb1VHV9Xmk cPjU5o1aZ4Mz921ogIAhIPo5YNTgwS8U7BdeN1cxncvWIhgmwRShOSQTB6oMombaDEnIw/O GBBx1Oc782/zu1e7t0ggw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:SKU4TfT/fFw=:kkPM87j1pxRmRwB2devWne o+E1NmzbCZiXOULmp85PgEZv7RBDFGYiYDlhqeVhB0gTB5StsUCSah+c2rIvi3U0cyO5f6B0X NbSavIEli/OEPVm2PP20hFFldhakcjAhZYtVxbZseNISUZSbpFOkdgykMRCoxasbeb4HII+ep o4qpn9lZMLHtxkzeXkjEmrzrcn4W4X+RriF+ECuevcDrnuWpBEpOITCDByQOXhJMU53v7qRpv dHCDSR8wvQoG9RsY0xODWYZCRYhovvbhAq55dmh0WIwvApfdw9YiHZztcakKbAT5YPHll53Iy QYoHG3w9FILRmPFtynG0cCKEu4AQ+eKlRm35hXYqM5uC3YxL/L1wTGNMLdi9fkhJtpvo8Syzr RrAofdxTWRYhIIetUzYE3t7vv9ue+GzEwJHcqYHbS+idkN/CkskmrCZEvwEXWIZFxMy64H0eV ZdulSRKOeQ2nO/Q2kCeLLsm/kR+2B0jt311MKJRBfYWniIMr2//ZZiCJhQjbdi0oGvHjE1DtK +89TbtHl9IE1Fw1FEUxjMz0Lz5JB7lml+FwS7c/ZB3USWzLhGgDXN2zdxEDOhlEhdhEHoCicf mBrVfH+7mGNxBwlTbZMLOPcTdtHx+SLu0I2UzBucYtw8V4Sjxm1xGmq5XGLlS3ll0doWvahnL tjBaaaMVj5mbsdv6ud7JgxdnuHAsQ8SwNDaXDNUh58upvmR0mBKuvZgLJb0JzTFOKTTJ9tGNr WHXZkIJ3sgk6cJzirkSeJGCMMpOJ0rjMBJeQDsZLgRMJ+ObkI5r1AzMYy/qVYJ6s25Fu+zQvb 7QJyB+VqYeE89AIluXhUo/SVC+suTGe5wMfMhUGK64e6uC1boTPW06PdchXdCECvRE/YLhks4 0drVChn+F0upJ6dkEc7KtaUx/BLuoMuOikDCZp+wTzLfNu0fcdImZEJ6U5iIZ2zg9x4qhX+oD 1+C3yFz6jS2BGVF+3ZyTL1T8ypvjB9woxW5atwhEDLCOn8HM5jP74vLZbFqos9L4wQWRoAMVL H+KsRhlhW9C40bVkA+RJAIQv7cPazzVvVw9HYJ6FN5/M7r1hrZu1v6YBy5KJ7AoRxM0nc3vRu M89Jd/lluYb+xMk27RiEdvWovFdQdSF56rc3pemPTj07tYe908Q09zNm8ccdowef5fhs392Bs d3dqm6rkStT57aRBUscbTJuctusHmZhQyr/ja4xiqcCZolSDAOAQzhqXYDe2Bgt00ze175PGZ UmI/ON8LfyVUil7YtOuKxzmQC47q8MJzqPOI9skuaTA08/sxCXtd3gmSWR6g= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > It did? what are the signs of the breakage? (It does build for me.) It crashes thusly: CC lastfile.o CCLD temacs.exe /usr/bin/mkdir -p ../etc make -C ../lisp update-subdirs make[2]: Verzeichnis =E2=80=9E/c/emacs/trunk/non-32/lisp=E2=80=9C wird be= treten make[2]: Verzeichnis =E2=80=9E/c/emacs/trunk/non-32/lisp=E2=80=9C wird ve= rlassen cp -f temacs.exe bootstrap-emacs.exe rm -f bootstrap-emacs.pdmp =2E/temacs --batch -l loadup --temacs=3Dpbootstrap make[1]: *** [Makefile:817: bootstrap-emacs.pdmp] Fehler 255 make[1]: Verzeichnis =E2=80=9E/c/emacs/trunk/non-32/src=E2=80=9C wird ver= lassen make: *** [Makefile:424: src] Fehler 2 Building HEAD detached at d36adb544d proceeds normally. I'll wait a couple of days and do a bootstrap then. Maybe someone sees the same problem before that. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 11:08:38 2020 Received: (at 38828) by debbugs.gnu.org; 3 Jan 2020 16:08:38 +0000 Received: from localhost ([127.0.0.1]:41311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inPV8-00066Q-9Y for submit@debbugs.gnu.org; Fri, 03 Jan 2020 11:08:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inPV6-00066E-S5 for 38828@debbugs.gnu.org; Fri, 03 Jan 2020 11:08:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inPV1-0007X2-4C; Fri, 03 Jan 2020 11:08:31 -0500 Received: from [176.228.60.248] (port=4656 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inPV0-0004CP-4B; Fri, 03 Jan 2020 11:08:30 -0500 Date: Fri, 03 Jan 2020 18:08:30 +0200 Message-Id: <83zhf4h69t.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <817f86da-0b80-1f67-0761-d04046f6c93d@gmx.at> (message from martin rudalics on Fri, 3 Jan 2020 16:57:12 +0100) Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> <83a774j0zl.fsf@gnu.org> <838smoit74.fsf@gnu.org> <817f86da-0b80-1f67-0761-d04046f6c93d@gmx.at> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 38828@debbugs.gnu.org > From: martin rudalics > Date: Fri, 3 Jan 2020 16:57:12 +0100 > > It crashes thusly: > > CC lastfile.o > CCLD temacs.exe > /usr/bin/mkdir -p ../etc > make -C ../lisp update-subdirs > make[2]: Verzeichnis „/c/emacs/trunk/non-32/lisp“ wird betreten > make[2]: Verzeichnis „/c/emacs/trunk/non-32/lisp“ wird verlassen > cp -f temacs.exe bootstrap-emacs.exe > rm -f bootstrap-emacs.pdmp > ./temacs --batch -l loadup --temacs=pbootstrap > make[1]: *** [Makefile:817: bootstrap-emacs.pdmp] Fehler 255 If you run the crashing command under GDB, what does it show at the point of the crash? From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 11:30:50 2020 Received: (at 38828) by debbugs.gnu.org; 3 Jan 2020 16:30:50 +0000 Received: from localhost ([127.0.0.1]:41335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inPqb-0006g2-Sr for submit@debbugs.gnu.org; Fri, 03 Jan 2020 11:30:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inPqa-0006fn-FW for 38828@debbugs.gnu.org; Fri, 03 Jan 2020 11:30:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inPqV-00051i-0Z; Fri, 03 Jan 2020 11:30:43 -0500 Received: from [176.228.60.248] (port=2136 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inPqT-0000G1-3q; Fri, 03 Jan 2020 11:30:41 -0500 Date: Fri, 03 Jan 2020 18:30:40 +0200 Message-Id: <83y2uoh58v.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <817f86da-0b80-1f67-0761-d04046f6c93d@gmx.at> (message from martin rudalics on Fri, 3 Jan 2020 16:57:12 +0100) Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> <83a774j0zl.fsf@gnu.org> <838smoit74.fsf@gnu.org> <817f86da-0b80-1f67-0761-d04046f6c93d@gmx.at> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 38828@debbugs.gnu.org > From: martin rudalics > Date: Fri, 3 Jan 2020 16:57:12 +0100 > > CC lastfile.o > CCLD temacs.exe > /usr/bin/mkdir -p ../etc > make -C ../lisp update-subdirs > make[2]: Verzeichnis „/c/emacs/trunk/non-32/lisp“ wird betreten > make[2]: Verzeichnis „/c/emacs/trunk/non-32/lisp“ wird verlassen > cp -f temacs.exe bootstrap-emacs.exe > rm -f bootstrap-emacs.pdmp > ./temacs --batch -l loadup --temacs=pbootstrap > make[1]: *** [Makefile:817: bootstrap-emacs.pdmp] Fehler 255 I see the problem: Paul changed Emacs to use calloc, and we didn't have its implementation consistent with our malloc in w32heap.c. Now I wonder why it didn't crash for me. Please try the latest master. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 11:34:43 2020 Received: (at 38828) by debbugs.gnu.org; 3 Jan 2020 16:34:44 +0000 Received: from localhost ([127.0.0.1]:41344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inPuN-0006m1-NB for submit@debbugs.gnu.org; Fri, 03 Jan 2020 11:34:43 -0500 Received: from mout.gmx.net ([212.227.17.22]:43553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inPuK-0006ln-Tj for 38828@debbugs.gnu.org; Fri, 03 Jan 2020 11:34:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1578069274; bh=pV4NeBsQCxYira7nX9mOkUq/Y+oGFDzdxfWmHPq7tMs=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=YGSFsLASg60iW+rZZ4CDRutbPbFwVII7JJp9wsR8rNy4Q8/H9FtJ6XlB9Ujy8TBcI fBqKtEwnZgFEnn6Dq2w0ZWdiA+JymMVR6SYS1e4BvGxgdWqXewWGgxdfje2KbvWfmJ DlmcZMvWcz01FCUs27DDuSs3aCWlc3sfJlxjGF6M= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.35]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MBm1U-1isrxe0RFU-00CAn0; Fri, 03 Jan 2020 17:34:34 +0100 Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar To: Eli Zaretskii References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> <83a774j0zl.fsf@gnu.org> <838smoit74.fsf@gnu.org> <817f86da-0b80-1f67-0761-d04046f6c93d@gmx.at> <83zhf4h69t.fsf@gnu.org> From: martin rudalics Message-ID: Date: Fri, 3 Jan 2020 17:34:34 +0100 MIME-Version: 1.0 In-Reply-To: <83zhf4h69t.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:RcZHpTHhazoF9WdLvvdl98/ITsN53ULcXI8aETF/V7hhBxsvFC2 7AIu+ZX0Hf5zGbfsOgGC48weWwIjMxC4Y+mSXa94b3iAQ9kQQU6/ZbwoYnbZfMchklbmfVt 5/XEBYxuBN5VeMeEeW58f0oNpNf08hkemPhxfRJJ81Qlq2P6JRJPT43DJ0cxPlMW4QQoOSq GX5VvuEehuQFYgGMsyQ2g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:BFXPchJHs08=:s5QRyADMU6k5Xt+KkmPRHI Bj6/tUC3JWwCKyxrcqeB6Jih4OV26SlEQTj2OV2Kb3NhmjYF12cg4amru+eb9qU7nZ/5Szg6T lpslZEkOmPGd5051aNTD9KLSHzNGBlTbEnCFkXKvqiw2wNwyx5LtVxm4tC7UGvaUo53R5L1gg DRgC1pW7WRpZtedq4iotzxP9epIlQQwCSQaFFKUs9uDcHdFDaBx6929IZnenfi6LcdkXzQzEd REjgMe4C1QTjPhEZM4n+U/ozd7qAGX+NY9KbZUv87rF6Ot76Ey3+v6UNlkT0+LZdO/P72m5ZD ELYap7JwjoybSoSWZYQ0uCmttWJxAwwwcJSHn5sYUvK/ypgTvdY0dfLWTkTpMeWhrXHN/xNTI 95sv5W68bXKoKNkSksnAaGCzZ3/2gw+phbzEduSEoROmHRaRODQDQqQEpyY7IMEGQNttOywBU w0aXLs68ZZVVwyNHPZZRDNt21fuE/GkXfgeAy6Ryad4z1fzmths8XoOD6U56R+iUIrkyItuAc jpIXJBesBQhZhWmFamj2b05GiOTXVFo5/Kl86hqPmWJJPCE95OsAFUNx0fc7f9UIwgR/KaZqZ QDk51+mJ1XX1v4E+15UZHktCPUnp6YWODu06/ueqM9Xo17saicVMY11VCPn8wAUi06h95lVPc 4eWnDBlXmZmzHPHcYT/kot8tU9ANbNVmnTQf62z2I4Ix4plI6mCWKRRvJZ88gfD7XY2ymgbnF yF33TfT772A7H8tUM8F/DBzCti0a2icfhKKkmnz4s7g7Kk6LKstvDxMyfTu3AKlY4/GGHGtoX t1R4ZDqOutXgWGV92jrcS8n2JeUWPPmgVuNnVwUg8ITpVwXIRfmUENdrOLF9kurErIPonlWPF YXjaX5dbW/7MCkydy99j1M4oxXAdXO2gFF/AiDNkXpRl9cDUfxKQGXncBiz/FFUZBl6AfWRdB MPIqiYbtSkTKZBMGbqZytQoE1sj7hyprgUAWj3CAtyK8LSiUqDmGM83JEcB0jPiGqJeNpf0ma aPaK6mueU8JfhFoSPHWB06hv057YUmeNbZhrxLbQKcKYBMhtX+T8UhbFsPBjf7V489Qhek3hl 3iZN4D/NsKRJbTUjhVLAU5lRaIILAalUviC5MkePGjkPCudDg0U1j45HAe7Gb/2U3Gd/wOcLA t7dpeklN7EnPpQ9DE4bDeEISqX515Xp+qRSMnI/vKwdNqfWpUkh7Q67LIcitiphNMJ6jGwVXl TO1qH1ihPhsdIn1soGpblsQcissBh8utZOXHHctyPC0GrwQLwAVFfbWoCObw= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > If you run the crashing command under GDB, what does it show at the > point of the crash? If you told me how to do that (note, I'm building out of the tree in spearate directories) I'll give it a try. So far I was only able to crash gdb. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 12:11:38 2020 Received: (at 38828) by debbugs.gnu.org; 3 Jan 2020 17:11:38 +0000 Received: from localhost ([127.0.0.1]:41364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inQU6-0007dZ-8T for submit@debbugs.gnu.org; Fri, 03 Jan 2020 12:11:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inQU4-0007dM-CV for 38828@debbugs.gnu.org; Fri, 03 Jan 2020 12:11:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inQTz-0005ln-1u; Fri, 03 Jan 2020 12:11:31 -0500 Received: from [176.228.60.248] (port=4600 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inQTy-0004Wp-9Y; Fri, 03 Jan 2020 12:11:30 -0500 Date: Fri, 03 Jan 2020 19:11:28 +0200 Message-Id: <83woa8h3cv.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: (message from martin rudalics on Fri, 3 Jan 2020 17:34:34 +0100) Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> <83a774j0zl.fsf@gnu.org> <838smoit74.fsf@gnu.org> <817f86da-0b80-1f67-0761-d04046f6c93d@gmx.at> <83zhf4h69t.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 38828@debbugs.gnu.org > From: martin rudalics > Date: Fri, 3 Jan 2020 17:34:34 +0100 > > > If you run the crashing command under GDB, what does it show at the > > point of the crash? > > If you told me how to do that (note, I'm building out of the tree in > spearate directories) I'll give it a try. So far I was only able to > crash gdb. Shouldn't be necessary anymore for this problem (I hope), but for the future: $ cd ../src $ gdb ../build/src/temacs.exe (gdb) cd ../build/src (gdb) r --batch -l loadup --temacs=pbootstrap (This assumes you build in build/, which is a sub-directory of the top-level Emacs directory, a sibling of src/, lisp/, etc.) From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 12:17:02 2020 Received: (at 38828) by debbugs.gnu.org; 3 Jan 2020 17:17:02 +0000 Received: from localhost ([127.0.0.1]:41368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inQZJ-0007le-Tc for submit@debbugs.gnu.org; Fri, 03 Jan 2020 12:17:02 -0500 Received: from mout.gmx.net ([212.227.17.21]:35645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inQZH-0007lJ-UN for 38828@debbugs.gnu.org; Fri, 03 Jan 2020 12:17:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1578071813; bh=tALko85QrHBzo1isekSy6Y8o0MbCKw4XyUgIwWPRXO0=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Sx7GYXRCn8LHfakGcP0cSP6qxSuoLh8Izo+Z+p5loniVU2nprrsZxsksvc+H9ktV9 JQP1kpshn5MgfEhoop//ynX6tXWC6uhQ6ouGgt+dnOsnDN2wi+WC5sUaFol7Q2VWdx MLHXCN6BsEYDHxoZVWXnyENyZgQ1lBEfNB+VfIPM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.35]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MAfYm-1iu09V1wwy-00B4O5; Fri, 03 Jan 2020 18:16:53 +0100 Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar To: Eli Zaretskii References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> <83a774j0zl.fsf@gnu.org> <838smoit74.fsf@gnu.org> <817f86da-0b80-1f67-0761-d04046f6c93d@gmx.at> <83y2uoh58v.fsf@gnu.org> From: martin rudalics Message-ID: <32bc8c8e-4b81-7e2b-4b1d-7ac61ae11115@gmx.at> Date: Fri, 3 Jan 2020 18:16:54 +0100 MIME-Version: 1.0 In-Reply-To: <83y2uoh58v.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:9XGTDDp/Iwg3GzMEL13LMw/t/hqo/Rj9TnlFESXw1VYvv0ZOD5T Au55esD0yHCqTQ7s3oOwPDT99WsOSOyM7kBlXXBE3TvfyVr3WGlQZ1Cm7P//bPap9p8lK6W x3aCfFIC3MFP5hrenKuF68F9CsIkyU8I1yuYUfiwAjfa38wRxIUVmrsSuiNXj/9uzu0isWe Zi/nj3CXwy+IDu8OKiKLA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:W72NOz702ko=:lIAvggyCoQwSIAG9V5Bh4r dNsHdS3jZAzUF/L09UfQ7eOTcZpQ5vGXTk0B/qXNo4PkiM7+MaDTPG9qkZp2Nqvb8IHxiWBCx VgD0PDNnKK7YtmnDp0InutzRjdhV7HkVy73Hh0yCKdqdctCK+kP2++GWs6gr9V5PSsrDk/zTS MqnQacmAwRFLUA0l64ZLK4g/LsOFrQ6tCUZNl0sHfwDykNbKjKYPSu8fqMUhiGP447Qa/pq1Y 40cwo61AjxGeCQenDoMY1vRSkeMaGJKTkPAjgwLYj+M59HDNrqDVZRYFKGoVG2fGuAkvTDech y2ACE2U7LZpiXqYV8B5lX+zhY2FFQdefghXMTdL37d7bulJ+XgBTR+VPiIS7CqSzkmv5CRDM3 iE9ujz1J6Gr4xHiHNW27dzvFojzirlAx7qP+mYV1yUDWMxHjIgDTw3Ox/RZWuBvoJjAWbdeft xMsq75lMuVPBgAAfqNyc3a5A6liFl2lpsKz3rXSv8INfkQFJ7CRurtlfeuzwHBoRR/BTdZS46 Q9b6wVD8DwmVqU8klfwetAGnxD9RfYpH9HbWk+rG7gstKgNa/cs0AfIL3P+63hVsN6P6dswaB L4IXReArrzbMVY8wZTF8McQgGFbk9FYuxL6h6d1RGxqu2TOCFQVP5URvMoUmULHO0GIOJDaK7 JY48PTQnwcBDQ02TQ2peQe8HyjjN27m33MZgaJ6Iw7zUcMYDz133l9gVRoOiyPkvlDvcrX6BD fpkMJ3LSl/ZMBT9EwTbm6IS+dReOq1Rde4mPPNX6lVPMh5Jt7ZQKYR7mEDu0XZ4mL1xTV5BNF WX1x4E3WyQgaKhMOj0xhXNDmPRTnV5hzEarrsYZ2+WFcw0XjHIpr9kYM5fhK9bbBoFMUFsCGu rHi6+3sCMuz414B9TfFEVY/IVVjkWtOK9h+PVho/brrdw2nwjaqICo1n2vBPdPbWiIPZznurE VgHFPEPpkjuep5WmV0J9lMHb7FGVij1oKQ2k01HExu7heKiMawGa2mUiC9sDYzbA9GbuiZimt axy/QFcXVge7JQTyjcO2Ey15GYNuZWbHJpk5ihW5Xx5v5S3E0ZDeqXSAHlBDyILuuygmGGc+w ttwmo101hs1gaRfZg6xNsf3t3vbQzPeZQE5DkfN1xPSl99h4/YCiuhJ5XIv2L6cQZB743BoD5 s1iCCMA2dYpnhXywXxgbQL2QklUf9c02eHFXNk49iIA2ol2/zBggbEF+D/ocPPB9y3NxwFlay BOwdga4YQzEbwzCnbkubEos9r7xZrmCoenShI+2ewPnPejglCPBYk7QaLKzY= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38828 Cc: 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I see the problem: Paul changed Emacs to use calloc, and we didn't > have its implementation consistent with our malloc in w32heap.c. Now > I wonder why it didn't crash for me. > > Please try the latest master. Builds without any problems now. Many thanks for the fix, martin From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 14:36:14 2020 Received: (at 38828) by debbugs.gnu.org; 4 Jan 2020 19:36:14 +0000 Received: from localhost ([127.0.0.1]:43405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inpDZ-0003Ng-Pt for submit@debbugs.gnu.org; Sat, 04 Jan 2020 14:36:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inpDV-0003NQ-Bl for 38828@debbugs.gnu.org; Sat, 04 Jan 2020 14:36:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inpDP-0002aA-T4; Sat, 04 Jan 2020 14:36:03 -0500 Received: from [2607:fea8:3b80:1ea:a5e0:ab44:2250:8546] (port=51680 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inpDP-0001Bg-5g; Sat, 04 Jan 2020 14:36:03 -0500 From: Amin Bandali To: Eli Zaretskii Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> <83a774j0zl.fsf@gnu.org> <838smoit74.fsf@gnu.org> <817f86da-0b80-1f67-0761-d04046f6c93d@gmx.at> <83y2uoh58v.fsf@gnu.org> Date: Sat, 04 Jan 2020 14:36:01 -0500 In-Reply-To: <83y2uoh58v.fsf@gnu.org> Message-ID: <87r20fovz2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38828 Cc: martin rudalics , 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Eli, [ Sorry if this isn=E2=80=99t the best place to report this ] With 37f9182b68c62ee1912cf28d4ea0c30b4f8d59e0 (which cites this bug report), I=E2=80=99ve noticed some weird display issues in a few different modes: =2D In `erc-mode' (the main ERC mode, used for for IRC channel buffers), if I press M-v to scroll to an earlier point in buffer and then scroll down line by line[1], the line previously at the bottom of the screen starts getting repeated, rather than the actual buffer content. One way to get rid of this is to jump to the end of the buffer with M->. Also, I noticed that parts of the buffer that react to mouse hover (e.g. buttonized links) get =E2=80=9Cfixed=E2=80=9D (the correct text app= ears) once the mouse cursor passes over them. =2D In `magit-revision-mode' (displays the details of a commit), parts of the diff (IIRC the last line visible) has a different background than its surrounding lines. In both of the above cases, the issue appears to be like some kind of =E2=80=98update=E2=80=99 not taking place anymore. In both cases, the =E2= =80=98artifacts=E2=80=99 are gone if the frame is resized or toggled full-screen. It=E2=80=99s quite li= kely that the issue will happen with other modes as well, but the above two are ones I=E2=80=99ve noticed and reliably reproduced so far. Sorry if this isn=E2=80=99t too helpful of a report, as I=E2=80=99m not at = all familiar Emacs=E2=80=99s display code. But I=E2=80=99ll be happy to try and help pi= n point the issue if you could tell me how. :-) Thanks, amin Footnotes: [1] I have the following scroll-related settings in my init file: (setq scroll-step 1 scroll-conservatively 10 scroll-preserve-screen-position 1) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEEObM8jZRIDS3cwqSYi0Sgzce5VvIFAl4Q6SEQHGJhbmRhbGlA Z251Lm9yZwAKCRCLRKDNx7lW8g48D/9PXeeNJMfwkUQSS+guOUnHCVH4l9HUUOxm KxjBWJeYcL5zxHxEKlKEHDVgPFDRl2xOqeT9uom3Xg5/NN5sduzv6mHEyjKD/JRu ffC2uOsWeu1rjJu3tbCHLX2UlBeFjs+VOssg1nbJkqNhWdI+EO34TNi7mWxiPW78 KKzfI38rXkf449SEFmGZCK12oPZFzqtEHwNY5QqmXTvMItL28rxGbpTADv4kdQHp R0JwYRkJbWSBmOMeGd0uIvLymeUqG0jVZ5stz9lCh0u35YsO9llconAAho/AJSRH 3DHl+Ie0md1Dus2VzIyccPnaSxwoKu84V82sSpH1OQo6trIGI7AM9qZwh0zeiwQ2 JTid3t3kZsgBUsxVMk1GEuvImJVVQ8MsnHv7/gQYDBdiHQWHe+3z4mps3qgBSQEQ 3DRAgIV2Qn8hiZdTAfiNEhM0qvu9xPDvj0BLFUDltBkIzxSmQiuPz9S0uYUabsdF MVHFxCFsI1FnIGEvT+H8oj0Fk6i99dFC1wM23Ta4xWlrNPIqsJvWYo/26u3wykLz nCp3XtjhF1DWeJouAFGlo+aqfPClbJ1NUSI+ZX/s8AdgvFGfJJL1bPFd0NR4AEWn WbOc3sfBNEY7TPjTGSWTqbLJQUVv30FYQiqJNEk9tLD6tCu2sJXuqaDWFkN4z2po rQrA51VDRw== =aPul -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 14:43:44 2020 Received: (at 38828) by debbugs.gnu.org; 4 Jan 2020 19:43:44 +0000 Received: from localhost ([127.0.0.1]:43409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inpKq-0003ZU-JX for submit@debbugs.gnu.org; Sat, 04 Jan 2020 14:43:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inpKp-0003ZD-9s for 38828@debbugs.gnu.org; Sat, 04 Jan 2020 14:43:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inpKk-0002w0-4x; Sat, 04 Jan 2020 14:43:38 -0500 Received: from [176.228.60.248] (port=2190 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inpKi-0001aw-VR; Sat, 04 Jan 2020 14:43:37 -0500 Date: Sat, 04 Jan 2020 21:43:38 +0200 Message-Id: <83zhf3f1n9.fsf@gnu.org> From: Eli Zaretskii To: Amin Bandali In-reply-to: <87r20fovz2.fsf@gnu.org> (message from Amin Bandali on Sat, 04 Jan 2020 14:36:01 -0500) Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> <83a774j0zl.fsf@gnu.org> <838smoit74.fsf@gnu.org> <817f86da-0b80-1f67-0761-d04046f6c93d@gmx.at> <83y2uoh58v.fsf@gnu.org> <87r20fovz2.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38828 Cc: rudalics@gmx.at, 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Amin Bandali > Cc: martin rudalics , 38828@debbugs.gnu.org > Date: Sat, 04 Jan 2020 14:36:01 -0500 > > With 37f9182b68c62ee1912cf28d4ea0c30b4f8d59e0 (which cites this bug > report), I’ve noticed some weird display issues in a few different > modes: There was a stupid typo in that commit, which was meanwhile fixed by Martin. Are still seeing these problems with the latest emacs-27 branch? From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 15:25:52 2020 Received: (at 38828) by debbugs.gnu.org; 4 Jan 2020 20:25:52 +0000 Received: from localhost ([127.0.0.1]:43445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inpzb-00006v-Rk for submit@debbugs.gnu.org; Sat, 04 Jan 2020 15:25:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inpza-00006i-NH for 38828@debbugs.gnu.org; Sat, 04 Jan 2020 15:25:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inpzV-0006nS-DH; Sat, 04 Jan 2020 15:25:45 -0500 Received: from [2607:fea8:3b80:1ea:a5e0:ab44:2250:8546] (port=51852 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inpzS-00079J-UJ; Sat, 04 Jan 2020 15:25:44 -0500 From: Amin Bandali To: Eli Zaretskii Subject: Re: bug#38828: 26.3; Customized mode line breaks height of vertical scroll bar References: <840ae56c-467b-21f2-7109-bb744897e71b@gmx.at> <83tv5fjgxn.fsf@gnu.org> <8336cyj66m.fsf@gnu.org> <83v9ptiq9y.fsf@gnu.org> <8a08a776-3ac5-b1ae-21f6-9d51ab1bb1bf@gmx.at> <83a774j0zl.fsf@gnu.org> <838smoit74.fsf@gnu.org> <817f86da-0b80-1f67-0761-d04046f6c93d@gmx.at> <83y2uoh58v.fsf@gnu.org> <87r20fovz2.fsf@gnu.org> <83zhf3f1n9.fsf@gnu.org> Date: Sat, 04 Jan 2020 15:25:30 -0500 In-Reply-To: <83zhf3f1n9.fsf@gnu.org> Message-ID: <87r20fotol.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38828 Cc: rudalics@gmx.at, 38828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: Amin Bandali >> Cc: martin rudalics , 38828@debbugs.gnu.org >> Date: Sat, 04 Jan 2020 14:36:01 -0500 >>=20 >> With 37f9182b68c62ee1912cf28d4ea0c30b4f8d59e0 (which cites this bug >> report), I=E2=80=99ve noticed some weird display issues in a few differe= nt >> modes: > > There was a stupid typo in that commit, which was meanwhile fixed by > Martin. Are still seeing these problems with the latest emacs-27 > branch? > Ah, yes! Confirming that cherry-picking Martin=E2=80=99s commit from emacs= -27 to master seems to fix those issues. Sorry for the noise. I somehow missed that commit when glancing at recent logs, and since it isn=E2=80=99t= yet merged into master these issues still occur there. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEEObM8jZRIDS3cwqSYi0Sgzce5VvIFAl4Q9LoQHGJhbmRhbGlA Z251Lm9yZwAKCRCLRKDNx7lW8pLKD/95kjsHU/g5T94FSy1FD66mIgUWtLnB8Jz6 ojLr8eyeV2MHdYdGPfn6J3BZ+MTTC2g3KhmlnrfJsMWDkXBc+JvLV0j9MbLKASJO FAmPkzDVqKETAOs6WOm/O/lDVxKc4wtlBCMmZ+/Q6eplWZk5A1AH9N/r5DDs8bwZ aLcZ9XNjJlrr2UvuP4NOoxA6HA0/GPAyjCpnOrNaEtsQEFNci23pf65NZCkwLFwb 26nwCJuuDx9EK3uzlX5ntiq8lsH8iouvre6jJq4mDe+VEeVKVw16GAI3JBAIXBcQ 7x67Kaacf4s9+we0DRgGEPMs6GLENOkZ/Kgg1O5Plnmi1NR0Da6J3SMHR4Nc+Wic dQj6bfeC0/BmFdjv1TiMoAtQtBw+AbbkrgOKL7mBxLr6XO1cfKI5rkB7Y8NK5HF7 2qfUIfhjX6d3v37HDIZBWFC+z+YVRGdAsPf0dF4tGGG4KiuKSTngQEMDkDk7Hcp3 AGWX6h4rdK28KflaJ6INmMtpcMLMwoHO4SCRhOXK3RcdpR6zYaM0uMRyjVRk26f2 Msvn/tqg3zGUXAfds+keQtQVpZBGL6Rlwzg01es1nJQ2nsVTeLZN6fw0N/0EuLDG HVwDhn8WtChVLJ+1/+bt8HxpZz26r1iixgVas2ZlJE+gC7sHuKXVfUccCk6y1+5W NtQZmuZQ+w== =B2NA -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Aug 18 15:38:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Feb 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator