GNU bug report logs - #38827
[PATCH] gnu: Add gitlab-runner.

Previous Next

To reply to this bug, email your comments to 38827 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Reza Alizadeh Majd <r.majd <at> pantherx.org>
To: guix-patches <at> gnu.org
Cc: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Subject: [PATCH] gnu: Add gitlab-runner.
Date: Tue, 31 Dec 2019 12:47:57 +0330

* gnu/packages/ci.scm (gitlab-runner): New variable.
---
 gnu/packages/ci.scm | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/ci.scm b/gnu/packages/ci.scm
index b49ac0f7c1..c9679c9674 100644
--- a/gnu/packages/ci.scm
+++ b/gnu/packages/ci.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2017 Mathieu Othacehe <m.othacehe <at> gmail.com>
 ;;; Copyright © 2017, 2019 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2018 Clément Lassieur <clement <at> lassieur.org>
+;;; Copyright © 2020 Reza Alizadeh Majd <r.majd <at> pantherx.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -25,6 +26,7 @@
   #:use-module ((guix licenses) #:prefix l:)
   #:use-module (gnu packages)
   #:use-module (guix packages)
+  #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
@@ -44,7 +46,8 @@
   #:use-module (gnu packages version-control)
   #:use-module (gnu packages web)
   #:use-module (gnu packages xml)
-  #:use-module (guix build-system gnu))
+  #:use-module (guix build-system gnu)
+  #:use-module (guix build-system go))
 
 (define-public cuirass
   (let ((commit "e20ff86d97f7dd92dad140b5919e3cbdf2fb1ce6")
@@ -152,3 +155,21 @@
 intended as a replacement for Hydra.")
       (home-page "https://www.gnu.org/software/guix/")
       (license l:gpl3+))))
+
+(define-public gitlab-runner
+  (package
+    (name "gitlab-runner")
+    (version "12.6.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "https://gitlab.com/gitlab-org/gitlab-runner/-/archive/v"
+                            version "/gitlab-runner-v" version ".tar.gz"))
+        (sha256 (base32 "1gb3mflz57niyyn4kj5l4m1g2sa2w4cn8gig5dfr04ns9w9kj8jr"))))
+    (build-system go-build-system)
+    (arguments '(#:import-path "gitlab.com/gitlab-org/gitlab-runner"))
+    (home-page "https://docs.gitlab.com/runner/")
+    (synopsis "GitLab Runner")
+    (description "GitLab Runner is the open source project that is used
+to run your jobs and send the results back to GitLab.")
+    (license l:expat)))
-- 
2.23.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 38827 <at> debbugs.gnu.org, Reza Alizadeh Majd <r.majd <at> pantherx.org>
Subject: Re: [bug#38827] [PATCH] gnu: Add gitlab-runner.
Date: Tue, 31 Dec 2019 12:06:36 +0100

Hello!

> +;;; Copyright © 2020 Reza Alizadeh Majd <r.majd <at> pantherx.org>

You are a bit early :)

> +(define-public gitlab-runner
> +  (package
> +    (name "gitlab-runner")
> +    (version "12.6.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://gitlab.com/gitlab-org/gitlab-runner/-/archive/v"
> +                            version "/gitlab-runner-v" version ".tar.gz"))
> +        (sha256 (base32 "1gb3mflz57niyyn4kj5l4m1g2sa2w4cn8gig5dfr04ns9w9kj8jr"))))

Those lines are above the column limit.

> +    (build-system go-build-system)
> +    (arguments '(#:import-path "gitlab.com/gitlab-org/gitlab-runner"))
> +    (home-page "https://docs.gitlab.com/runner/")
> +    (synopsis "GitLab Runner")
> +    (description "GitLab Runner is the open source project that is used
> +to run your jobs and send the results back to GitLab.")

No need to mention it is open source, otherwise, it wouldn't be
here. You could also elaborate a bit.

Could you send an updated version ?

Thanks,

Mathieu

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: "Mathieu Othacehe" <m.othacehe <at> gmail.com>, guix-patches <at> gnu.org
Cc: 38827 <at> debbugs.gnu.org
Subject: Re: [bug#38827] [PATCH] gnu: Add gitlab-runner.
Date: Tue, 31 Dec 2019 13:21:06 +0000

Hi, 

> 
> Those lines are above the column limit.
> 

I checked the package using `guix lint ...` but didn't receive any
warning about the column limit. 

> 
> No need to mention it is open source, otherwise, it wouldn't be
> here. You could also elaborate a bit.
> 

I use projects default document to fill the description field: 
https://docs.gitlab.com/runner/

do I need to update description to a custom one?

-- 
Regards
Reza Alizadeh Majd
PantherX Team

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Cc: 38827 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#38827] [PATCH] gnu: Add gitlab-runner.
Date: Tue, 31 Dec 2019 14:42:41 +0100

> I checked the package using `guix lint ...` but didn't receive any
> warning about the column limit.

Yup, we would need to improve the linter :) This column limit rule  is
mentionned here[1].

> I use projects default document to fill the description field:
> https://docs.gitlab.com/runner/
>
> do I need to update description to a custom one?

Yes, sometimes the upstream description is too short, uses superlatives
or so. You'll find some guidelines here[2].

Thanks,

Mathieu

[1]: https://guix.gnu.org/manual/en/html_node/Formatting-Code.html#Formatting-Code
[2]: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html#Synopses-and-Descriptions

Message #26 received at 38827 <at> debbugs.gnu.org (full text, mbox):

From: "Reza Alizadeh Majd" <r.majd <at> pantherx.org>
To: "Mathieu Othacehe" <m.othacehe <at> gmail.com>
Cc: 38827 <at> debbugs.gnu.org
Subject: Re: [bug#38827] [PATCH] gnu: Add gitlab-runner.
Date: Tue, 31 Dec 2019 15:48:59 +0000

[Message part 1 (text/plain, inline)]

Hi,
 
> [1]: 
> https://guix.gnu.org/manual/en/html_node/Formatting-Code.html#Formatting-Code
> [2]: 
> https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html#Synopses-and-Descriptions

I update the package definition following the above guidelines.
could you please check if this updated patch is acceptable?

-- 
Regards
Reza Alizadeh Majd
PantherX Team

[0001-gnu-Add-gitlab-runner.patch (text/x-patch, attachment)]

Message #29 received at 38827 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Cc: 38827 <at> debbugs.gnu.org
Subject: Re: [bug#38827] [PATCH] gnu: Add gitlab-runner.
Date: Tue, 31 Dec 2019 17:09:34 +0100

> I update the package definition following the above guidelines.
> could you please check if this updated patch is acceptable?

I fixed the indentation, added one space between the two description
sentences and pushed.

Thanks for your contribution,

Mathieu

Message #34 received at 38827-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Reza Alizadeh Majd <r.majd <at> pantherx.org>
Cc: 38827-done <at> debbugs.gnu.org
Subject: Re: [bug#38827] [PATCH] gnu: Add gitlab-runner.
Date: Tue, 31 Dec 2019 17:09:55 +0100

and closing!

Mathieu

Message #41 received at 38827 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 38827 <at> debbugs.gnu.org, Reza Alizadeh Majd <r.majd <at> pantherx.org>
Subject: Re: [bug#38827] [PATCH] gnu: Add gitlab-runner.
Date: Wed, 01 Jan 2020 00:54:37 +0100

Hello!

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

>> I update the package definition following the above guidelines.
>> could you please check if this updated patch is acceptable?
>
> I fixed the indentation, added one space between the two description
> sentences and pushed.

The ‘vendor’ directory contains a large number of bundled dependencies,
including various bits of Docker and Kubernetes.  I’m not comfortable
keeping this package as is.

Reza, could you look into unbundling these, or at least a significant
part of these?

There’s a Go importer at
<https://lists.gnu.org/archive/html/guix-devel/2018-04/msg00301.html>,
but it’s for ‘Gopkg.toml’ files, which seem to be out of fashion, so I’m
not sure it’d be useful.

In the meantime, I’d be in favor of reverting the patch.  WDYT?

Thanks,
Ludo’.

Message #44 received at 38827 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38827 <at> debbugs.gnu.org, Mathieu Othacehe <m.othacehe <at> gmail.com>,
 Reza Alizadeh Majd <r.majd <at> pantherx.org>
Subject: Re: [bug#38827] [PATCH] gnu: Add gitlab-runner.
Date: Wed, 1 Jan 2020 14:20:17 +0200

[Message part 1 (text/plain, inline)]

On Wed, Jan 01, 2020 at 12:54:37AM +0100, Ludovic Courtès wrote:
> Hello!
> 
> Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:
> 
> >> I update the package definition following the above guidelines.
> >> could you please check if this updated patch is acceptable?
> >
> > I fixed the indentation, added one space between the two description
> > sentences and pushed.
> 
> The ‘vendor’ directory contains a large number of bundled dependencies,
> including various bits of Docker and Kubernetes.  I’m not comfortable
> keeping this package as is.
> 
> Reza, could you look into unbundling these, or at least a significant
> part of these?
> 
> There’s a Go importer at
> <https://lists.gnu.org/archive/html/guix-devel/2018-04/msg00301.html>,
> but it’s for ‘Gopkg.toml’ files, which seem to be out of fashion, so I’m
> not sure it’d be useful.
> 
> In the meantime, I’d be in favor of reverting the patch.  WDYT?
> 

Unfortunately I'm in agreement. I personally would keep in in a channel
until it's been de-vendored.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #47 received at 38827 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38827 <at> debbugs.gnu.org, Reza Alizadeh Majd <r.majd <at> pantherx.org>
Subject: Re: [bug#38827] [PATCH] gnu: Add gitlab-runner.
Date: Wed, 01 Jan 2020 19:58:00 +0100

Hey,

> The ‘vendor’ directory contains a large number of bundled dependencies,
> including various bits of Docker and Kubernetes.  I’m not comfortable
> keeping this package as is.

Oops, that's indeed quite problematic. Sorry for not noticing, reverted
until we can find a better way.

Mathieu

Message #50 received at 38827 <at> debbugs.gnu.org (full text, mbox):

From: r.majd <at> pantherx.org
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38827 <at> debbugs.gnu.org, Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: Re: [bug#38827] [PATCH] gnu: Add gitlab-runner.
Date: Thu, 02 Jan 2020 02:52:32 +0330

[Message part 1 (text/html, inline)]

Message #53 received at 38827 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 38827 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add gitlab-runner.
Date: Thu, 2 Jan 2025 02:02:24 +0000

[Message part 1 (text/plain, inline)]

Hi,

I've started adding each missing dependencies on go-team branch.
They are about 600 to cover the full tree.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.