GNU bug report logs - #38813
Make comint-tests more robust

Previous Next

Full log

View this message in rfc822 format

From: Mattias Engdegård <mattiase <at> acm.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: "Michael R. Mauger" <michael <at> mauger.com>, 38813 <at> debbugs.gnu.org
Subject: bug#38813: Make comint-tests more robust
Date: Mon, 30 Dec 2019 17:19:08 +0100

30 dec. 2019 kl. 16.20 skrev Michael Albinus <michael.albinus <at> gmx.de>:

> The usual pattern is (while (accept-process-output proc 0 nil t))
> That's what I do in tramp-tests.el

Thank you, but that only works if inside another loop, and then it is a busy-wait, right?
We don't really have a predicate to tell us when we need to stop waiting, unless we use the test condition for that.
We could do

 (while (accept-process-output proc 0.1 nil t))

which isn't strictly necessary since the test logic guarantees that only two accept-process-output calls should be needed, but it doesn't hurt (much).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.