GNU bug report logs - #38813
Make comint-tests more robust

Previous Next

Package: emacs;

Reported by: Mattias Engdegård <mattiase <at> acm.org>

Date: Mon, 30 Dec 2019 14:14:02 UTC

Severity: normal

Tags: patch

Done: Mattias Engdegård <mattiase <at> acm.org>

Bug is archived. No further changes may be made.

Full log

Message #10 received at 38813 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: "Michael R. Mauger" <michael <at> mauger.com>, 38813 <at> debbugs.gnu.org
Subject: Re: bug#38813: Make comint-tests more robust
Date: Mon, 30 Dec 2019 16:20:30 +0100

Mattias Engdegård <mattiase <at> acm.org> writes:

> There seem to be races in the new comint-tests; they frequently hang
> and/or fail when run (make check) on macOS.
> This patch should improve matters. OK for emacs-27?

> -            (accept-process-output proc 0 1 t)
> +            (accept-process-output proc 0 100 t)
> +            (accept-process-output proc 0 100 t)

The usual pattern is (while (accept-process-output proc 0 nil t))
That's what I do in tramp-tests.el

Best regards, Michael.
This bug report was last modified 5 years and 202 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.