From unknown Sat Aug 16 22:47:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38813: Make comint-tests more robust Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Dec 2019 14:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38813 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 38813@debbugs.gnu.org Cc: "Michael R. Mauger" X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.157771523428646 (code B ref -1); Mon, 30 Dec 2019 14:14:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Dec 2019 14:13:54 +0000 Received: from localhost ([127.0.0.1]:60610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilvnt-0007Rx-PK for submit@debbugs.gnu.org; Mon, 30 Dec 2019 09:13:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:50355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilvns-0007Rq-M5 for submit@debbugs.gnu.org; Mon, 30 Dec 2019 09:13:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34452) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilvnr-0007qB-CY for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 09:13:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ilvnq-00077y-4c for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 09:13:51 -0500 Received: from mail1476c50.megamailservers.eu ([91.136.14.76]:37960 helo=mail118c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ilvnp-00076N-E1 for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 09:13:50 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1577714228; bh=rtpzz93Os4r4EakCFy3F89A2ZFO10PHyID2k9Fs5Ppw=; h=From:Subject:Date:Cc:To:From; b=q5bmDRvcHsFcDnDaOldABbikoQ7z3d9pqaNmEC2XKD+qSscr8JSrlzcyDPdIzlZIn o/rNVpb7ESMg2xkahAevR4NqD9gYqq29vjZ9PtXBBAJ7wnc0WCZaBHcS1rAF89BMfA mrak+fYrf7WDu3+xKM5zjKP3vBMjEsru9osDB2BI= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id xBUDv3Dm015086; Mon, 30 Dec 2019 13:57:07 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_F2F7A240-4ABD-4078-AFE9-F4E855249284" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Message-Id: Date: Mon, 30 Dec 2019 14:57:03 +0100 X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020E.5E0A0234.0021, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=dLXYZ9Rb c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=M51BFTxLslgA:10 a=pu5n-WsVCKfFfce_PloA:9 a=CjuIK1q_8ugA:10 a=_c9xi3AsYpMI6zpX3OgA:9 a=B2y7HmGcmWMA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.136.14.76 X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --Apple-Mail=_F2F7A240-4ABD-4078-AFE9-F4E855249284 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii There seem to be races in the new comint-tests; they frequently hang = and/or fail when run (make check) on macOS. This patch should improve matters. OK for emacs-27? --Apple-Mail=_F2F7A240-4ABD-4078-AFE9-F4E855249284 Content-Disposition: attachment; filename=0001-Make-comint-tests-more-robust.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Make-comint-tests-more-robust.patch" Content-Transfer-Encoding: quoted-printable =46rom=20b5ec344dc37408bc97385476767df953a47d0061=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Mon,=2030=20Dec=202019=2014:10:02=20+0100=0A= Subject:=20[PATCH]=20Make=20comint-tests=20more=20robust=0A=0A*=20= test/lisp/comint-tests.el=20(comint-test-no-password-function)=0A= (comint-test-password-function-with-value)=0A= (comint-test-password-function-with-nil):=0ACall=20accept-process-output=20= twice,=20with=20a=20slightly=20more=20generous=0Atimeout=20(100=20ms),=20= after=20sending=20the=20Password:=20prompt=20to=20the=0Aprocess,=20since=20= there=20must=20be=20time=20for=20some=20back-and-forth=0Acommunication.=20= =20Also=20clear=20the=20process-query-on-exit=20flag,=20since=0Ait=20= doesn't=20go=20well=20with=20noninteractive=20tests.=0A---=0A=20= test/lisp/comint-tests.el=20|=2015=20+++++++++------=0A=201=20file=20= changed,=209=20insertions(+),=206=20deletions(-)=0A=0Adiff=20--git=20= a/test/lisp/comint-tests.el=20b/test/lisp/comint-tests.el=0Aindex=20= c04134599f..9960f5e65d=20100644=0A---=20a/test/lisp/comint-tests.el=0A= +++=20b/test/lisp/comint-tests.el=0A@@=20-64,10=20+64,11=20@@=20= comint-test-no-password-function=0A=20=20=20=20=20=20=20=20=20= (with-temp-buffer=0A=20=20=20=20=20=20=20=20=20=20=20= (make-comint-in-buffer=20"test-comint-password"=20(current-buffer)=20= cat)=0A=20=20=20=20=20=20=20=20=20=20=20(let=20((proc=20= (get-buffer-process=20(current-buffer))))=0A+=20=20=20=20=20=20=20=20=20=20= =20=20(set-process-query-on-exit-flag=20proc=20nil)=0A=20=20=20=20=20=20=20= =20=20=20=20=20=20(comint-send-string=20proc=20"Password:=20")=0A-=20=20=20= =20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=201=20t)=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20(comint-send-eof)=0A-=20=20=20=20=20=20= =20=20=20=20=20=20(accept-process-output=20proc=200=201=20t)=0A+=20=20=20= =20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=20100=20t)=0A= +=20=20=20=20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=20= 100=20t)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(should=20= (string-equal=20(buffer-substring-no-properties=20(point-min)=20= (point-max))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20"Password:=20= PaSsWoRd123\n"))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20= (process-live-p=20proc)=0A@@=20-87,10=20+88,11=20@@=20= comint-test-password-function-with-value=0A=20=20=20=20=20=20=20=20=20= (with-temp-buffer=0A=20=20=20=20=20=20=20=20=20=20=20= (make-comint-in-buffer=20"test-comint-password"=20(current-buffer)=20= cat)=0A=20=20=20=20=20=20=20=20=20=20=20(let=20((proc=20= (get-buffer-process=20(current-buffer))))=0A+=20=20=20=20=20=20=20=20=20=20= =20=20(set-process-query-on-exit-flag=20proc=20nil)=0A=20=20=20=20=20=20=20= =20=20=20=20=20=20(comint-send-string=20proc=20"Password:=20")=0A-=20=20=20= =20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=201=20t)=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20(comint-send-eof)=0A-=20=20=20=20=20=20= =20=20=20=20=20=20(accept-process-output=20proc=200=201=20t)=0A+=20=20=20= =20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=20100=20t)=0A= +=20=20=20=20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=20= 100=20t)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(should=20= (string-equal=20(buffer-substring-no-properties=20(point-min)=20= (point-max))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20"Password:=20= MaGiC-PaSsWoRd789\n"))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20= (process-live-p=20proc)=0A@@=20-110,10=20+112,11=20@@=20= comint-test-password-function-with-nil=0A=20=20=20=20=20=20=20=20=20= (with-temp-buffer=0A=20=20=20=20=20=20=20=20=20=20=20= (make-comint-in-buffer=20"test-comint-password"=20(current-buffer)=20= cat)=0A=20=20=20=20=20=20=20=20=20=20=20(let=20((proc=20= (get-buffer-process=20(current-buffer))))=0A+=20=20=20=20=20=20=20=20=20=20= =20=20(set-process-query-on-exit-flag=20proc=20nil)=0A=20=20=20=20=20=20=20= =20=20=20=20=20=20(comint-send-string=20proc=20"Password:=20")=0A-=20=20=20= =20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=201=20t)=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20(comint-send-eof)=0A-=20=20=20=20=20=20= =20=20=20=20=20=20(accept-process-output=20proc=200=201=20t)=0A+=20=20=20= =20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=20100=20t)=0A= +=20=20=20=20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=20= 100=20t)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(should=20= (string-equal=20(buffer-substring-no-properties=20(point-min)=20= (point-max))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20"Password:=20= PaSsWoRd456\n"))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20= (process-live-p=20proc)=0A--=20=0A2.21.0=20(Apple=20Git-122.2)=0A=0A= --Apple-Mail=_F2F7A240-4ABD-4078-AFE9-F4E855249284-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 30 09:15:57 2019 Received: (at control) by debbugs.gnu.org; 30 Dec 2019 14:15:57 +0000 Received: from localhost ([127.0.0.1]:60616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilvpt-0007W4-5X for submit@debbugs.gnu.org; Mon, 30 Dec 2019 09:15:57 -0500 Received: from mail152c50.megamailservers.eu ([91.136.10.162]:51040 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilvpq-0007Vv-Lf for control@debbugs.gnu.org; Mon, 30 Dec 2019 09:15:55 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1577715353; bh=vuz/nH2Nk/M3twq9hqIKdxTsLn22PxGopbfMJ7WYMRw=; h=From:Subject:Date:To:From; b=TLpixhXSqfUcbWAjXrGteLcygt0Jsw+p+w2E9w0yBnUSZ7Cj8YhIRQMA49ts2eIi2 IIUqdxNs78iUVr3N8JdtnCZBpU7cpP9irYwkjHQiG5e9BmM5Bs+pQB+wVOyc9vaEMI LrphKzItX2cP19AHsIFZMouPz2obhLyH2eva1SQc= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id xBUEFpuE031325 for ; Mon, 30 Dec 2019 14:15:52 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Message-Id: <7CDCB80C-8F67-4865-8253-4773E59621BA@acm.org> Date: Mon, 30 Dec 2019 15:15:50 +0100 To: control@debbugs.gnu.org X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0203.5E0A0699.000C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=N4FX6F1B c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=rP_EvJsj-ambl6YXFGgA:9 a=CjuIK1q_8ugA:10 X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 38813 patch Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: megamailservers.eu] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [91.136.10.162 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 38813 patch Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: megamailservers.eu] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [91.136.10.162 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 2.0 BLANK_SUBJECT Subject is present but empty tags 38813 patch From unknown Sat Aug 16 22:47:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38813: Make comint-tests more robust Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Dec 2019 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38813 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: "Michael R. Mauger" , 38813@debbugs.gnu.org Received: via spool by 38813-submit@debbugs.gnu.org id=B38813.157771924710853 (code B ref 38813); Mon, 30 Dec 2019 15:21:02 +0000 Received: (at 38813) by debbugs.gnu.org; 30 Dec 2019 15:20:47 +0000 Received: from localhost ([127.0.0.1]:33195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilwqd-0002oy-EJ for submit@debbugs.gnu.org; Mon, 30 Dec 2019 10:20:47 -0500 Received: from mout.gmx.net ([212.227.17.21]:59581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilwqa-0002oi-K9 for 38813@debbugs.gnu.org; Mon, 30 Dec 2019 10:20:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1577719232; bh=mA5eJqH7X2XpMdthUCwsF6+K7PRJYFNfx0gR2znFMCo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=IX8R79+1R+UsnePdZP8pxE4sbfk84Q3RGgPn6Sv5kWANk25fWO+K+sRwfK7MgW1L5 C0WM98rPaRM5t68l0rAnk5uGpPcQ3J2ePKtqILRccfHHetserPw582cs2xGn0e4arO fEQ0D/yZO6cbtRigLdc+ObvO9ffg9RmvKvlCEVos= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.59.161]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MkHQX-1jSCQT14m1-00kf7F; Mon, 30 Dec 2019 16:20:32 +0100 From: Michael Albinus References: Date: Mon, 30 Dec 2019 16:20:30 +0100 In-Reply-To: ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Mon, 30 Dec 2019 14:57:03 +0100") Message-ID: <878smtvo01.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ORIQomkwZws67aVlXR8zcWBRAsRwnTofsHloMLZ/PPmB8lsBBmz 8MMv2M2c6td4E/rKm8yAebjLflvn/sV6/U5eqT789i5agzdPZt7dAdL+W1XyCgF5JtMQFv/ qYYhbHaENUU6X4zwXuFMiSevMGfaNGV5leiU0HBmwuLVB9XS7gSM5J2JOT9NKvOqw8DFlP+ z5YYpU1X8EuLgBi0ZEs3Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:vFrYXrXlS8U=:hWxTT+EBpDpMEI78I6upib W6hqQFqDYaltoSh9W7wEtQ23g40bkjgPFgroDo/165WJa/hT2P83BGTfHpeRk9Ik0rg+m0x5+ 9+DmQkXyzuPj6Rbf4yMrwvsMir1pC+u17WW4rvdXucdZ44rIh6ZIqoaULVo0vj8bTRe7+Mfni rcP32dERQu2qGG8lSDjKfphdQFBOkCqbHm66ZweMPETqa2734hf2d0Cnhp89XccMmzSFkE2JY 6mOJh5NEk/LOdFqf8ejAuALU6qiy9fAXV2iPo5f0iNcxvIlEHp/1Anv3SkxGyBdZynz2lMfzO ZdxkpvMRUb2eZS7Ppugn80IBhtzpPyrlu894Ijkxd+0fbySsnSiJzBQSFjIiXFlVFLTv5IHmT MMV8RpcDDwYNjIV1oaytrHltgF255v6gId93njD0LzeJ1kQTTGlK0Zb534vSBO5rGu6yt8/f9 +Kgi8RE6Djf6eibRcH1eFIObNhRWWOP3iqPaPRw8laRgapT4IpXiz4i3svjmWbWq6GHU/lP9e Kj4q0Oty7eMeKFJ9Ew63EXBT8QIyF+AWrRjdK1BeJ6LxbQ8M2hlSpIM26poD4k60OSFeXZLEt K7poo5zXgNAq0xHqvs53ZoXJqk5ijvoCcoTTfbF7vz7m2SwASTU/mQrH1rjc/+bHLFJxn3YDQ I4LJ1L1CORt5KEetanjZ2z/rUI1iaQKZ8PoOOzLsjPhTvnuHu/PNbqKGjZ67u4ONaz1YGtBb+ eBGW9caCOK7vWDqc3cxgyg8Z+r38POe1L8bjTN/OV3mX0PyJJs9yFcF72p1yfyFGpxBTmvlqy g9ET+KZom+40qxFZlbkl97bdPbMO2++wPdfgagDr+tApNM+2r8Nk5PxVA6Hc01U8Zvk1vPzTW CtoGIu0TZF1BcfXUXxIzDMu8MVBWN79qNfMJsrv8+ffURLF9b0PAiMRBhlI+aZVH7hIPZubjn iZ0cXOhHCnkCNCSAqvWNo9ELFh/DxC0KjkPToWm05F8wmspARtVu6YfZx/I5VafbFac+H2Fuy bWHS3PU92rYafxVxPc5GUaLWZRpE3rlOBarrVPVH9Vw8TmmuiNeiwxLNpgPh4LtJa7QX6vbt7 0Cso3vB72mRqI1gOcTXklN0ngrZB5/KtQm3eHOSPcfptiFA4wnMWYuOoKeZzEIas1MFCIuMV6 6ZVIum8DqD/r90PCxc6LEw0wIF1fByY40lfw/OcvGArygVtDuX7tqLe/lNAucha9eOzdNFIu1 xxTkAWQt1SbRqITI2AuRwLR51E6tdGa2v+t/EoOzgTuXHdheGXm2VuwJawNE= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: > There seem to be races in the new comint-tests; they frequently hang > and/or fail when run (make check) on macOS. > This patch should improve matters. OK for emacs-27? > - (accept-process-output proc 0 1 t) > + (accept-process-output proc 0 100 t) > + (accept-process-output proc 0 100 t) The usual pattern is (while (accept-process-output proc 0 nil t)) That's what I do in tramp-tests.el Best regards, Michael. From unknown Sat Aug 16 22:47:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38813: Make comint-tests more robust Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Dec 2019 16:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38813 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: "Michael R. Mauger" , 38813@debbugs.gnu.org Received: via spool by 38813-submit@debbugs.gnu.org id=B38813.157772275516816 (code B ref 38813); Mon, 30 Dec 2019 16:20:02 +0000 Received: (at 38813) by debbugs.gnu.org; 30 Dec 2019 16:19:15 +0000 Received: from localhost ([127.0.0.1]:33276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilxlD-0004NA-G3 for submit@debbugs.gnu.org; Mon, 30 Dec 2019 11:19:15 -0500 Received: from mail152c50.megamailservers.eu ([91.136.10.162]:50538 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilxlA-0004N1-OW for 38813@debbugs.gnu.org; Mon, 30 Dec 2019 11:19:13 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1577722750; bh=HdGRcnV9cljLe94o8kD7/OnOLjpKIHVTMaxJq2cisgc=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=gvHbZ7Ju6Ch00Xwyg2nxlO+dh2/anmd8WX0X6UDbgqt2HIx6deAWPO7KnFLGVS2Xv zuZJF4CSC6no4F+Wn+XEK8Wajcgi3zy4+/vhR5S7wBiSSk4t5mZmvYTZQAnBBLD0xa fKiQ05aP2qKf1LxEG73WYqI9AcAIbCOHLZEXdyDY= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id xBUGJ84O001080; Mon, 30 Dec 2019 16:19:10 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <878smtvo01.fsf@gmx.de> Date: Mon, 30 Dec 2019 17:19:08 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <878smtvo01.fsf@gmx.de> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0207.5E0A237E.0041, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=N4FX6F1B c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=-Q1cAKzlK02ZBEtqcv4A:9 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 30 dec. 2019 kl. 16.20 skrev Michael Albinus : > The usual pattern is (while (accept-process-output proc 0 nil t)) > That's what I do in tramp-tests.el Thank you, but that only works if inside another loop, and then it is a = busy-wait, right? We don't really have a predicate to tell us when we need to stop = waiting, unless we use the test condition for that. We could do (while (accept-process-output proc 0.1 nil t)) which isn't strictly necessary since the test logic guarantees that only = two accept-process-output calls should be needed, but it doesn't hurt = (much). From unknown Sat Aug 16 22:47:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38813: Make comint-tests more robust Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Dec 2019 18:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38813 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: "Michael R. Mauger" , 38813@debbugs.gnu.org Received: via spool by 38813-submit@debbugs.gnu.org id=B38813.157773053229494 (code B ref 38813); Mon, 30 Dec 2019 18:29:01 +0000 Received: (at 38813) by debbugs.gnu.org; 30 Dec 2019 18:28:52 +0000 Received: from localhost ([127.0.0.1]:33373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilzme-0007fe-HH for submit@debbugs.gnu.org; Mon, 30 Dec 2019 13:28:52 -0500 Received: from mout.gmx.net ([212.227.17.21]:33107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilzmc-0007fR-Or for 38813@debbugs.gnu.org; Mon, 30 Dec 2019 13:28:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1577730519; bh=WpPB1HuHw+QFyQLZIuFIYJIzhAAdxPVwjO6WSJ5yFUo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=JD2tecmF8XI6EwiBOjV8SXMILxzcWFTkuoK6T3aXcqxpbKSdFZ3LrzsHyLy+0C5ui sRZ/W0ECIbuqZAzAZ5fwbZFLU91WGlM785OvwutIjHNgXH5pZ2kQta2osShsrl3mtn b9s52I8JsGAPnkUzoBsZe08CVm8VaOOEb2Z6kzSA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from detlef.gmx.de ([212.86.59.161]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mk0JM-1jRyNa3y3M-00kNzL; Mon, 30 Dec 2019 19:28:39 +0100 From: Michael Albinus References: <878smtvo01.fsf@gmx.de> Date: Mon, 30 Dec 2019 19:28:37 +0100 In-Reply-To: ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Mon, 30 Dec 2019 17:19:08 +0100") Message-ID: <87r20lu0q2.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ofdYlYyrglfD7LEkhvwnCquFa3WfuRz2tR1x7zyabww25cIuIDE cxxcKP7Bxem0LUQWa9a7pDYHKGlR1lIiEo7ClagKDtuYrDNnxycP9c/Z0EwLaUhsnfFBQK7 Pd6TRt32Rqo+Ixm4jvcD8u/N/WLHuhNk/dlJ0Jk1lZkvDdc+1tZNVJxdmYBY0WFw7kmcHri zZ8NWPwte4uSvHRNH2WYQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ndQy7U56LFg=:m2AguH44aiqdxkMTVDHexT oI7l3UhgNi8DkNrF0I9GJiEzW7bz2BdM8AMUV4vQw2vwVIIKakhNRUuhDbcnVXgCIz4Up9ebM /LtlTNZ4cG4VKztpQwxAoEbUqFu9uG0QSJ/l9ySMFu95/AuafGRpWlMSGMxxpxs3LKEaPxgvC XCqi7jxS/i6PzZ4uFvpwqX9ZnM+Q4+FdMVZbaLBIpM9UulZp7luGNTKK2Te7l77XAp8GW9XRZ E5NZ+ec1b7g64pitOOeaguFDmmXi1WF56F76GKX3rCNbCf0YPjVEXVjqVb4AtMN0szN2/rHnM Z8SVjzSZVfxY9mic+SArLwRvYsxCmdOOTEPGmqEEPOM4a1+siB/VR2NJjKM4k5hthIXEYzQNY CIif9yQKyFuUAezwMCeMtjBDD8SEjBm0reAQr1E3MT16Kkv2JZvmdGT6INZuH8HXUjSIpD0rf 6E4DwCsZ268AIEvdVQSKRFcgNjVvtJEB60NWm0PTmX2FXnRFxL6TxB/+DGmf5C1KmLrCiovCK iINRiv+huHIA8P9RhRoDJXqEp4LUMP9dDC0yeSa2p6dO/Z06GZKKKho2vkjfFRUuUYHU0qs0m F7h3iUZmHNxxDafe6EHHCRjLJp1zYtnMOSsGz72sVK49lDLiBF2mbH0xcVdd3xHeiZjXKN+Z1 ZeL2eyQx7ZIQIjp3GjVF6RyWt/wsZ9HYg7htDWnWXvehOEZw6cKz7heFmEoazTAYL4hc6HhZd 2SyAlG/wKfMxf+fvhD5xQRIn6BNaoI13NI9Z9epY6h8vx0/e8L+CcwcqZgMazhQHNFe0763vQ 6JiyzQuP6M53uSTWhNlvfvCSRcQACx/ajyWNmYSCjcqMtvvAhePvABCXWJdCpnkttzjjudKQ8 bp50CYaTYd+T4w7w2VQ6CtIm8EoWNmFPz5NaHv/mdUaiWhETwIj/4LELKbn1RF69kvSwRm1BA l5RogdcJNLtkSvPR6oqZnEPT4k8aWe0usdCM6xvQ3lNojsLUjQyDbxSWQ5MqcK7PbwUBZIGWU nsewCkALfsV6q6TXmexUsceO/gERkR8yDnmjaiALYgMyKx9qmn/IE6xRq1xyHsi9WzqkLUaYt XUcvpKbJVed0rj1P4ruWugFiGUTi4DzhoKmao3QA9zupjUijHxquhxdEnRd+CZjp0jDQBKWJs 61AVxzhPugQjlzUn2CuelkTAZPsZh3KnUiusXBp6Jc5PYx1V+cxLufgnp1vAJj4yUD4lwNZ3p cBf0wjRCX3U6EUKDUgEXWq6SmC72Z7foaOdwH1m0JX15ksR4D7ixtykyyDhQ= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: >> The usual pattern is (while (accept-process-output proc 0 nil t)) >> That's what I do in tramp-tests.el > > Thank you, but that only works if inside another loop, and then it is > a busy-wait, right? I'm not sure. Some months (years?) ago there was a discussion about on emacs-devel, and AFAIR this form was proposed by Stefan. If needed, I could check the archives. Best regards, Michael. From unknown Sat Aug 16 22:47:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Subject: bug#38813: closed (Re: bug#38813: Make comint-tests more robust) Message-ID: References: X-Gnu-PR-Message: they-closed 38813 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 38813@debbugs.gnu.org Date: Mon, 30 Dec 2019 20:06:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1577736362-14405-1" This is a multi-part message in MIME format... ------------=_1577736362-14405-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #38813: Make comint-tests more robust which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 38813@debbugs.gnu.org. --=20 38813: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D38813 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1577736362-14405-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 38813-done) by debbugs.gnu.org; 30 Dec 2019 20:05:42 +0000 Received: from localhost ([127.0.0.1]:33465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1im1IM-0003jp-8G for submit@debbugs.gnu.org; Mon, 30 Dec 2019 15:05:42 -0500 Received: from mail1476c50.megamailservers.eu ([91.136.14.76]:46294 helo=mail118c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1im1IK-0003jb-1e for 38813-done@debbugs.gnu.org; Mon, 30 Dec 2019 15:05:41 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1577736332; bh=yr9fLOh/M6B3RAmnCpawBSwaz9sZBIlIXYYxC8IV6uw=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=ZH15VUSMhEQaYQcW+IB3hPPLZU/hhl43LSelYqnnPe7GZz3o3qtYG1yznuYD9WN9W 8TvW1wCAbgrpNhpEdBufpiKX3S/T1VB9RR4gyNd0dl8UbY+shpf37dF00IAgqGLj0M RFT/QhOIJa+Bqj6tGWma8vMG1HdqCGM3Ja4D0x4M= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id xBUK5MWV001954; Mon, 30 Dec 2019 20:05:32 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: bug#38813: Make comint-tests more robust From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87r20lu0q2.fsf@gmx.de> Date: Mon, 30 Dec 2019 21:05:22 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <878smtvo01.fsf@gmx.de> <87r20lu0q2.fsf@gmx.de> To: Michael Albinus X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0204.5E0A588C.0032, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=dLXYZ9Rb c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=6rkvoCdbsJ0okRizGE8A:9 a=CjuIK1q_8ugA:10 a=aMj-4VGTj6kA:10 X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 38813-done Cc: "Michael R. Mauger" , 38813-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 30 dec. 2019 kl. 19.28 skrev Michael Albinus : > I'm not sure. Some months (years?) ago there was a discussion about on > emacs-devel, and AFAIR this form was proposed by Stefan. >=20 > If needed, I could check the archives. Thank you, I don't think that's necessary. The improved patch has been = pushed to emacs-27. ------------=_1577736362-14405-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Dec 2019 14:13:54 +0000 Received: from localhost ([127.0.0.1]:60610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilvnt-0007Rx-PK for submit@debbugs.gnu.org; Mon, 30 Dec 2019 09:13:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:50355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilvns-0007Rq-M5 for submit@debbugs.gnu.org; Mon, 30 Dec 2019 09:13:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34452) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilvnr-0007qB-CY for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 09:13:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ilvnq-00077y-4c for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 09:13:51 -0500 Received: from mail1476c50.megamailservers.eu ([91.136.14.76]:37960 helo=mail118c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ilvnp-00076N-E1 for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2019 09:13:50 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1577714228; bh=rtpzz93Os4r4EakCFy3F89A2ZFO10PHyID2k9Fs5Ppw=; h=From:Subject:Date:Cc:To:From; b=q5bmDRvcHsFcDnDaOldABbikoQ7z3d9pqaNmEC2XKD+qSscr8JSrlzcyDPdIzlZIn o/rNVpb7ESMg2xkahAevR4NqD9gYqq29vjZ9PtXBBAJ7wnc0WCZaBHcS1rAF89BMfA mrak+fYrf7WDu3+xKM5zjKP3vBMjEsru9osDB2BI= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id xBUDv3Dm015086; Mon, 30 Dec 2019 13:57:07 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_F2F7A240-4ABD-4078-AFE9-F4E855249284" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Make comint-tests more robust Message-Id: Date: Mon, 30 Dec 2019 14:57:03 +0100 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020E.5E0A0234.0021, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=dLXYZ9Rb c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=M51BFTxLslgA:10 a=pu5n-WsVCKfFfce_PloA:9 a=CjuIK1q_8ugA:10 a=_c9xi3AsYpMI6zpX3OgA:9 a=B2y7HmGcmWMA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.136.14.76 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: "Michael R. Mauger" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --Apple-Mail=_F2F7A240-4ABD-4078-AFE9-F4E855249284 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii There seem to be races in the new comint-tests; they frequently hang = and/or fail when run (make check) on macOS. This patch should improve matters. OK for emacs-27? --Apple-Mail=_F2F7A240-4ABD-4078-AFE9-F4E855249284 Content-Disposition: attachment; filename=0001-Make-comint-tests-more-robust.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Make-comint-tests-more-robust.patch" Content-Transfer-Encoding: quoted-printable =46rom=20b5ec344dc37408bc97385476767df953a47d0061=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Mon,=2030=20Dec=202019=2014:10:02=20+0100=0A= Subject:=20[PATCH]=20Make=20comint-tests=20more=20robust=0A=0A*=20= test/lisp/comint-tests.el=20(comint-test-no-password-function)=0A= (comint-test-password-function-with-value)=0A= (comint-test-password-function-with-nil):=0ACall=20accept-process-output=20= twice,=20with=20a=20slightly=20more=20generous=0Atimeout=20(100=20ms),=20= after=20sending=20the=20Password:=20prompt=20to=20the=0Aprocess,=20since=20= there=20must=20be=20time=20for=20some=20back-and-forth=0Acommunication.=20= =20Also=20clear=20the=20process-query-on-exit=20flag,=20since=0Ait=20= doesn't=20go=20well=20with=20noninteractive=20tests.=0A---=0A=20= test/lisp/comint-tests.el=20|=2015=20+++++++++------=0A=201=20file=20= changed,=209=20insertions(+),=206=20deletions(-)=0A=0Adiff=20--git=20= a/test/lisp/comint-tests.el=20b/test/lisp/comint-tests.el=0Aindex=20= c04134599f..9960f5e65d=20100644=0A---=20a/test/lisp/comint-tests.el=0A= +++=20b/test/lisp/comint-tests.el=0A@@=20-64,10=20+64,11=20@@=20= comint-test-no-password-function=0A=20=20=20=20=20=20=20=20=20= (with-temp-buffer=0A=20=20=20=20=20=20=20=20=20=20=20= (make-comint-in-buffer=20"test-comint-password"=20(current-buffer)=20= cat)=0A=20=20=20=20=20=20=20=20=20=20=20(let=20((proc=20= (get-buffer-process=20(current-buffer))))=0A+=20=20=20=20=20=20=20=20=20=20= =20=20(set-process-query-on-exit-flag=20proc=20nil)=0A=20=20=20=20=20=20=20= =20=20=20=20=20=20(comint-send-string=20proc=20"Password:=20")=0A-=20=20=20= =20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=201=20t)=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20(comint-send-eof)=0A-=20=20=20=20=20=20= =20=20=20=20=20=20(accept-process-output=20proc=200=201=20t)=0A+=20=20=20= =20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=20100=20t)=0A= +=20=20=20=20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=20= 100=20t)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(should=20= (string-equal=20(buffer-substring-no-properties=20(point-min)=20= (point-max))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20"Password:=20= PaSsWoRd123\n"))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20= (process-live-p=20proc)=0A@@=20-87,10=20+88,11=20@@=20= comint-test-password-function-with-value=0A=20=20=20=20=20=20=20=20=20= (with-temp-buffer=0A=20=20=20=20=20=20=20=20=20=20=20= (make-comint-in-buffer=20"test-comint-password"=20(current-buffer)=20= cat)=0A=20=20=20=20=20=20=20=20=20=20=20(let=20((proc=20= (get-buffer-process=20(current-buffer))))=0A+=20=20=20=20=20=20=20=20=20=20= =20=20(set-process-query-on-exit-flag=20proc=20nil)=0A=20=20=20=20=20=20=20= =20=20=20=20=20=20(comint-send-string=20proc=20"Password:=20")=0A-=20=20=20= =20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=201=20t)=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20(comint-send-eof)=0A-=20=20=20=20=20=20= =20=20=20=20=20=20(accept-process-output=20proc=200=201=20t)=0A+=20=20=20= =20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=20100=20t)=0A= +=20=20=20=20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=20= 100=20t)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(should=20= (string-equal=20(buffer-substring-no-properties=20(point-min)=20= (point-max))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20"Password:=20= MaGiC-PaSsWoRd789\n"))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20= (process-live-p=20proc)=0A@@=20-110,10=20+112,11=20@@=20= comint-test-password-function-with-nil=0A=20=20=20=20=20=20=20=20=20= (with-temp-buffer=0A=20=20=20=20=20=20=20=20=20=20=20= (make-comint-in-buffer=20"test-comint-password"=20(current-buffer)=20= cat)=0A=20=20=20=20=20=20=20=20=20=20=20(let=20((proc=20= (get-buffer-process=20(current-buffer))))=0A+=20=20=20=20=20=20=20=20=20=20= =20=20(set-process-query-on-exit-flag=20proc=20nil)=0A=20=20=20=20=20=20=20= =20=20=20=20=20=20(comint-send-string=20proc=20"Password:=20")=0A-=20=20=20= =20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=201=20t)=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20(comint-send-eof)=0A-=20=20=20=20=20=20= =20=20=20=20=20=20(accept-process-output=20proc=200=201=20t)=0A+=20=20=20= =20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=20100=20t)=0A= +=20=20=20=20=20=20=20=20=20=20=20=20(accept-process-output=20proc=200=20= 100=20t)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(should=20= (string-equal=20(buffer-substring-no-properties=20(point-min)=20= (point-max))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20"Password:=20= PaSsWoRd456\n"))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(when=20= (process-live-p=20proc)=0A--=20=0A2.21.0=20(Apple=20Git-122.2)=0A=0A= --Apple-Mail=_F2F7A240-4ABD-4078-AFE9-F4E855249284-- ------------=_1577736362-14405-1--