GNU bug report logs - #38812
28.0.50; Custom: Problem with reverting some session's customizations

Previous Next

Full log

Message #27 received at 38812-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 38812-done <at> debbugs.gnu.org
Subject: Re: bug#38812: 28.0.50;
 Custom: Problem with reverting some session's customizations
Date: Wed, 01 Jan 2020 19:51:39 +0200

> From: Mauro Aranda <maurooaranda <at> gmail.com>
> Date: Tue, 31 Dec 2019 14:38:02 -0300
> Cc: 38812 <at> debbugs.gnu.org
> 
> > My alternative patch is below.  WDYT?
> >
> > diff --git a/lisp/custom.el b/lisp/custom.el
> > index 26bdaae2c2..7ed85b22e8 100644
> > --- a/lisp/custom.el
> > +++ b/lisp/custom.el
> > @@ -886,7 +886,10 @@ custom-push-theme
> >   (put theme 'theme-settings
> >       (cons (list prop symbol theme value)
> >     (delq res theme-settings)))
> > - (setcar (cdr setting) value)))
> > +        ;; It's tempting to use setcar here, but that could
> > +        ;; inadvertently modify other properties in SYMBOL's proplist,
> > +        ;; if those just happen to share elements with the value of PROP.
> > +        (put symbol prop (cons (list theme value) (delq setting old)))))
> >       ;; Add a new setting:
> >       (t
> >        (when (custom--should-apply-setting theme)
> 
> Looks good, thank you.

Thanks, pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.