GNU bug report logs - #38799
[PATCH] gnu: vim: Update to 8.2.0055.

Previous Next

Full log

Message #16 received at 38799-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 38799-done <at> debbugs.gnu.org, Jakub Kądziołka
 <kuba <at> kadziolka.net>
Subject: Re: [bug#38799] [PATCH v2] gnu: vim: Update to 8.2.0066.
Date: Tue, 31 Dec 2019 23:49:23 +0100

[Message part 1 (text/plain, inline)]

Jakub,

Jakub Kądziołka 写道：
> Vim pushed some new commits that look desirable -- 8.2.0063 
> seems to
> have fixed a crash -- so here's a new patch with a bumped 
> version &
> hash.

Thank you!  I've made only tiny cosmetic changes:

- Added a copyright line for you as discussed on IRC.

- I agree with your source indentation fixes, but they make this 
 patch less clear.  Let's keep them for when we ever switch to 
 URL-FETCH, for example.

- Shortened the MegaComment — it was very clear (thank you!) but 
 longer than is customary.

- The awkward indentation of the tzdata-for-tests comment bothered 
 me. I replaced it with a less detailed but, again, customary 
 variant. It's not like something will be silently missing if 
 anyone tries removing it: the test suite will fail, loudly.

Linted and pushed as 9efcc4948143a845355f7869fe05dbcca0f74a34. 
Happy 2020!

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.