From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 29 13:11:19 2019 Received: (at submit) by debbugs.gnu.org; 29 Dec 2019 18:11:19 +0000 Received: from localhost ([127.0.0.1]:60202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ild26-0006On-TX for submit@debbugs.gnu.org; Sun, 29 Dec 2019 13:11:19 -0500 Received: from lists.gnu.org ([209.51.188.17]:37671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ild25-0006Of-Fo for submit@debbugs.gnu.org; Sun, 29 Dec 2019 13:11:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40694) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ild24-000470-I4 for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 13:11:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ild23-0005Bz-NL for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 13:11:16 -0500 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:34382) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ild23-00056x-Fb for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 13:11:15 -0500 Received: by mail-lj1-x22d.google.com with SMTP id z22so26554809ljg.1 for ; Sun, 29 Dec 2019 10:11:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=LeZjwuttdDWqp59Ihn0tSkAjlpKfbmgJAyE9lYLVG8E=; b=hCjvVRSH7FoKdvO1IijrHCw/i7hA7Btd/Fp+276jEgX4VQYMv0PlWizszne63M9bc0 MxrALoIL7MAq+kfB9HdpDOMSiXTUaj4CMEJbXG/FoBfMX/+1X/Esk63L4THFtQFt3JZS nct0CHzfWiz/dCSkuxmxyvJp3jtwjB7ZP2b5ULO6pEkndssp7RAM+97HSXJ/8eCO46aq NCLHLRDrqJRE2mwiWYFsMgRIJ1KKngihgxU0tI2H3kZMcBd/9+nxoZx9ium+/zGmR/8q yW3ijHINEOFm6DYONBp6NliUrk/jcuu/gsXrkNtTcQznkGdcrc3AvTsrx300zvuRYrN4 +GIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=LeZjwuttdDWqp59Ihn0tSkAjlpKfbmgJAyE9lYLVG8E=; b=AQNNcW8K+SsqBupwJAmK24H7K0o/vuv9q2bQz+EV8je7yFXDl5nI7SkgPRbi6Wd39q rbz2I8SdSgvFWGzL+IYzeNA0LLsgvrpQGFemiWOTyoGsXImluovl7KhZZsjZAopEIRiS UPd92x+jT4o+E5aKA2aEjMVR1vj85zj4FzdpY5jSUi+qNQRJhPUsxXpsTsDfUHh4zrHT vPfhTB45jS9fh1BZONKj02eqJABt4/5sm0abaZMGgtdBkAXRMrDOF7z7LTTx6Y6MHcZW BPVUBdfLR3si78CJQz5JMA+qALjQLizeKIVrcVXiouoKFZciQ6V0F0xWAAIiOg4esCaF G56w== X-Gm-Message-State: APjAAAW1gHGz+SEiNvliwbl/8L3OfmYtCpOUzxXVbrt9iQaMDEY8QPWR mkb2Qg3T22L2JXivyqr09igPAwIMxgdyZuwtkC4k6CYQ X-Google-Smtp-Source: APXvYqyGDtS0pEtwnrT6c0tMVHzwXf1WYroimzBlBfXxL64tbnbUt0T9jNp39ViFJrg73sVin3M3B5/H9pr2Mg4Encs= X-Received: by 2002:a2e:808a:: with SMTP id i10mr33281311ljg.151.1577643073506; Sun, 29 Dec 2019 10:11:13 -0800 (PST) MIME-Version: 1.0 From: yyoncho Date: Sun, 29 Dec 2019 20:11:02 +0200 Message-ID: Subject: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000fa91c1059adba611" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::22d X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000fa91c1059adba611 Content-Type: text/plain; charset="UTF-8" ATM there xref-pop-marker-stack which is equivalent to going backwards but there is no operation for going forward. --000000000000fa91c1059adba611 Content-Type: text/html; charset="UTF-8"
ATM there xref-pop-marker-stack which is equivalent to going backwards
but there is no operation for going forward.
--000000000000fa91c1059adba611-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 09:13:49 2020 Received: (at 38797) by debbugs.gnu.org; 23 Jan 2020 14:13:49 +0000 Received: from localhost ([127.0.0.1]:52013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iudEz-0007fL-EX for submit@debbugs.gnu.org; Thu, 23 Jan 2020 09:13:49 -0500 Received: from mail-lj1-f182.google.com ([209.85.208.182]:35123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iudEx-0007f7-2n for 38797@debbugs.gnu.org; Thu, 23 Jan 2020 09:13:47 -0500 Received: by mail-lj1-f182.google.com with SMTP id j1so3608316lja.2 for <38797@debbugs.gnu.org>; Thu, 23 Jan 2020 06:13:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GPlYOQpykBVS/O0VEV9yalD8hVi5GMKCvqlPWXDwLD0=; b=kASY451Ow5gA3dTIDNpivvI18AAAlPek59wh+wi94NoJCRT6pmrvXpBQzEneK/8d21 JzwDRgJ/e8H7dxGpeJJzLKB/dIhTwHOiTIqXrKT5FNUNbvDybjK+pPTDbPCV1SzCoUi9 CTkstPOwPMvOgG7+NeBTDIwvc1LVbf1Nk5ZHsFR+aD7H8XP1B+PfU7XUk89nJ2C2WyHg sq4EvjcV7Trby+GZ7kDOqDQkCksmpYf/EIe5IL5KcFTrgeeQkghqZsmDu4mrP0WXzSev 2XeY6nNLGFEKdgWmi9Jn5+OythiHKqojJQC+BAirt1zWJQZmJsWyEb39812GrIKtryCo MPhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GPlYOQpykBVS/O0VEV9yalD8hVi5GMKCvqlPWXDwLD0=; b=PIMVCit/dJfRL6VHlByQLWXFGLEY4hb1EmZFbbmBe0L8/eltD6sUbRfIo8dsJL7qqM RBpA74HLkcM05q17zC26ep0Av2wQ3ZIxB8vIkxwMhRKbrLrwKaudj8DFc4R6bstUjcwY 14ABNE+d/fI3Ymf/D5byXizITsLMyAKpD8QqBQTFxGAoXOmwka55iIDNrkK7w7hXqkBm oDgkodPFk52mxRQ9ywUbRIujfwJXFzMczE7HbV9xxRr/f8RPrvskG+ippA5D3YkdFGy4 wkOSKaSjIbnSQqjMDIeTgcYOqC7tCihoSLLcH+sNaX/6lnpL0RdhCCgQRVYLqEWlVNfv DukQ== X-Gm-Message-State: APjAAAVI2x0pp2BX0SRK3Kki5mJQx/WKLRY1sbCTSlF71bmAJ1t+t0Pd eorA3ISBtvPMh2PjlE2hCoUDPougtFw= X-Google-Smtp-Source: APXvYqx6mNAinmoRi1zI2radDAGe1Hrj2Ygx/lQ5AFuROqRTJIqTHIZH5A7LVo+8F6pJrF6tU27nQw== X-Received: by 2002:a05:651c:111a:: with SMTP id d26mr23270670ljo.153.1579788819550; Thu, 23 Jan 2020 06:13:39 -0800 (PST) Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id o19sm1613098lji.54.2020.01.23.06.13.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Jan 2020 06:13:38 -0800 (PST) Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack To: yyoncho , 38797@debbugs.gnu.org References: From: Dmitry Gutov Message-ID: Date: Thu, 23 Jan 2020 17:13:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Ivan, On 29.12.2019 21:11, yyoncho wrote: > ATM there xref-pop-marker-stack which is equivalent to going backwards > but there is no operation for going forward. Do you want to try writing the patch? Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.182 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.182 listed in wl.mailspike.net] 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 38797 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Ivan, On 29.12.2019 21:11, yyoncho wrote: > ATM there xref-pop-marker-stack which is equivalent to going backwards > but there is no operation for going forward. Do you want to try writing the patch? Having written one third-party package for this purpose, and now using another (history), I personally have a whole set of requirements for this feature to be able to use it (e.g. making the rings window-local and having a visualization when moving back and forth). I'm not sure how important those are for an average user, though. So... would you like to submit something you would be happy with personally? From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 20 15:12:41 2021 Received: (at 38797) by debbugs.gnu.org; 20 Oct 2021 19:12:41 +0000 Received: from localhost ([127.0.0.1]:55488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdH0z-0006mG-1v for submit@debbugs.gnu.org; Wed, 20 Oct 2021 15:12:41 -0400 Received: from mail208c50.megamailservers.eu ([91.136.10.218]:43328 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdH0w-0006m5-3R for 38797@debbugs.gnu.org; Wed, 20 Oct 2021 15:12:39 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1634757155; bh=0lhQSRnmVAEtlmMc4z/rlPXwMhLwMrN9Kcw+QagzAFo=; h=From:Subject:Date:Cc:To:From; b=lIQVECehUYdY/iob4dLD0y880lJE4SyjTCHs7lXrondrCXTt5ie+EyTKgcGGhVAu5 jjZyy1fa6deW116lNHTySezIQ5LJE01AePucIrK93xI8Rpd+uCEbLwKCkPsQnn7ob6 4DE0+7AGR+7RwRVHJvGY0H7WiS1ou7rluQmC1qAU= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 19KJCX7B028496; Wed, 20 Oct 2021 19:12:34 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_AB687862-6341-40BE-BDC0-5C2554BBC335" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack Message-Id: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> Date: Wed, 20 Oct 2021 21:12:32 +0200 To: Dmitry Gutov X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F24.61706A23.006B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=WpBIjfTv c=1 sm=1 tr=0 ts=61706a23 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=M51BFTxLslgA:10 a=Nx6CdJeKhclv6lrDXlQA:9 a=CjuIK1q_8ugA:10 a=IjauANIYuRhfNtMKzY0A:9 a=B2y7HmGcmWMA:10 X-Origin-Country: SE X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 38797 Cc: yyoncho , 38797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_AB687862-6341-40BE-BDC0-5C2554BBC335 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii As usual my message was lost. Here's the patch at least. --Apple-Mail=_AB687862-6341-40BE-BDC0-5C2554BBC335 Content-Disposition: attachment; filename=0001-Add-xref-forward-history-bug-38797.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Add-xref-forward-history-bug-38797.patch" Content-Transfer-Encoding: quoted-printable =46rom=209191300d574a1a7d4adc3eb86f0381a6e836c887=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Tue,=2019=20Oct=202021=2013:26:19=20+0200=0A= Subject:=20[PATCH]=20Add=20xref=20forward=20history=20(bug#38797)=0A=0A= Make=20it=20possible=20to=20go=20forward=20as=20well=20as=20back=20in=20= the=20Xref=20history.=0AThe=20new=20`xref-forward-history`=20is=20bound=20= to=20`C-M-,`.=0A=0A*=20lisp/progmodes/etags.el=20= (find-tag-marker-ring-length):=20Update.=0A(tags-location-ring-length):=20= New.=0A(find-tag-marker-ring):=20Remove.=0A(tags-location-ring,=20= tags-reset-tags-tables):=0AUse=20`tags-location-ring-length`=20instead=20= of=20`xref-marker-ring-length`.=0A*=20lisp/progmodes/xref.el=20= (xref-marker-ring-length,=20xref-marker-ring)=0A= (xref-set-marker-ring-length):=0AMake=20obsolete.=0A(xref--history,=20= xref-forward-history):=20New.=0A(xref-push-marker-stack,=20= xref-pop-marker-stack)=0A(xref-clear-marker-stack,=20= xref-marker-stack-empty-p):=0AUse=20`xref--history`.=0A*=20= doc/emacs/maintaining.texi=20(Looking=20Up=20Identifiers):=20Document.=0A= *=20etc/NEWS:=20Announce.=0A---=0A=20doc/emacs/maintaining.texi=20|=2013=20= +++++--=0A=20etc/NEWS=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20|=20=205=20+++=0A=20lisp/progmodes/etags.el=20=20=20=20|=2011=20= +++---=0A=20lisp/progmodes/xref.el=20=20=20=20=20|=2078=20= ++++++++++++++++++++++----------------=0A=204=20files=20changed,=2066=20= insertions(+),=2041=20deletions(-)=0A=0Adiff=20--git=20= a/doc/emacs/maintaining.texi=20b/doc/emacs/maintaining.texi=0Aindex=20= 5b66031b8a..46b4d8181f=20100644=0A---=20a/doc/emacs/maintaining.texi=0A= +++=20b/doc/emacs/maintaining.texi=0A@@=20-2140,6=20+2140,9=20@@=20= Looking=20Up=20Identifiers=0A=20@item=20M-,=0A=20Go=20back=20to=20where=20= you=20previously=20invoked=20@kbd{M-.}=20and=20friends=0A=20= (@code{xref-pop-marker-stack}).=0A+@item=20C-M-,=0A+Go=20forward=20to=20= where=20you=20previously=20invoked=20@kbd{M-,}=0A= +(@code{xref-forward-history}).=0A=20@item=20M-x=20xref-etags-mode=0A=20= Switch=20@code{xref}=20to=20use=20the=20@code{etags}=20backend.=0A=20= @end=20table=0A@@=20-2205,14=20+2208,16=20@@=20Looking=20Up=20= Identifiers=0A=20=0A=20@kindex=20M-,=0A=20@findex=20= xref-pop-marker-stack=0A-@vindex=20xref-marker-ring-length=0A=20=20=20To=20= go=20back=20to=20places=20@emph{from=20where}=20you've=20displayed=20the=20= definition,=0A=20use=20@kbd{M-,}=20(@code{xref-pop-marker-stack}).=20=20= It=20jumps=20back=20to=20the=0A=20point=20of=20the=20last=20invocation=20= of=20@kbd{M-.}.=20=20Thus=20you=20can=20find=20and=0A=20examine=20the=20= definition=20of=20something=20with=20@kbd{M-.}=20and=20then=20return=20= to=0A-where=20you=20were=20with=20@kbd{M-,}.=20=20@kbd{M-,}=20allows=20= you=20to=20retrace=20your=0A-steps=20to=20a=20depth=20determined=20by=20= the=20variable=0A-@code{xref-marker-ring-length},=20which=20defaults=20= to=2016.=0A+where=20you=20were=20with=20@kbd{M-,}.=0A+=0A+@kindex=20= C-M-,=0A+@findex=20xref-forward-history=0A+=20=20Go=20forward=20to=20a=20= place=20from=20where=20you=20previously=20went=20back=20using=20= @kbd{M-,}.=0A+This=20is=20useful=20if=20you=20find=20that=20you=20went=20= back=20too=20far.=0A=20=0A=20@findex=20xref-etags-mode=0A=20=20=20Some=20= major=20modes=20install=20@code{xref}=20support=20facilities=20that=20= might=0Adiff=20--git=20a/etc/NEWS=20b/etc/NEWS=0Aindex=20= 9f0a4ac4ce..21f9a0f75f=20100644=0A---=20a/etc/NEWS=0A+++=20b/etc/NEWS=0A= @@=20-153,6=20+153,11=20@@=20it=20with=20new=20= 'term-{faint,italic,slow-blink,fast-blink}'=20faces.=0A=20***=20= 'project-find-file'=20and=20'project-or-external-find-file'=20now=20= accept=0A=20a=20prefix=20argument=20which=20is=20interpreted=20to=20mean=20= "include=20all=20files".=0A=20=0A++++=0A+***=20New=20command=20= 'xref-forward-history'.=0A+It=20is=20bound=20to=20'C-M-,'=20and=20jumps=20= to=20the=20location=20where=20'xref-pop-marker-stack'=0A+was=20invoked=20= previously.=0A+=0A=20**=20File=20notifications=0A=20=0A=20+++=0Adiff=20= --git=20a/lisp/progmodes/etags.el=20b/lisp/progmodes/etags.el=0Aindex=20= d2ce813daa..518c4ec81b=20100644=0A---=20a/lisp/progmodes/etags.el=0A+++=20= b/lisp/progmodes/etags.el=0A@@=20-145,7=20+145,9=20@@=20= find-tag-default-function=0A=20=20=20:type=20'(choice=20(const=20nil)=20= function))=0A=20=0A=20(define-obsolete-variable-alias=20= 'find-tag-marker-ring-length=0A-=20=20'xref-marker-ring-length=20"25.1")=0A= +=20=20'tags-location-ring-length=20"29.1")=0A+=0A+(defvar=20= tags-location-ring-length=2016)=0A=20=0A=20(defcustom=20tags-tag-face=20= 'default=0A=20=20=20"Face=20for=20tags=20in=20the=20output=20of=20= `tags-apropos'."=0A@@=20-180,7=20+182,6=20@@=20= tags-apropos-additional-actions=0A=20=09=09=20=20=20=20=20=20=20(sexp=20= :tag=20"Tags=20to=20search")))=0A=20=20=20:version=20"21.1")=0A=20=0A= -(defvaralias=20'find-tag-marker-ring=20'xref--marker-ring)=0A=20= (make-obsolete-variable=0A=20=20'find-tag-marker-ring=0A=20=20"use=20= `xref-push-marker-stack'=20or=20`xref-pop-marker-stack'=20instead."=0A@@=20= -191,7=20+192,7=20@@=20default-tags-table-function=0A=20This=20function=20= receives=20no=20arguments=20and=20should=20return=20the=20default=0A=20= tags=20table=20file=20to=20use=20for=20the=20current=20buffer.")=0A=20=0A= -(defvar=20tags-location-ring=20(make-ring=20xref-marker-ring-length)=0A= +(defvar=20tags-location-ring=20(make-ring=20tags-location-ring-length)=0A= =20=20=20"Ring=20of=20markers=20which=20are=20locations=20visited=20by=20= \\[find-tag].=0A=20Pop=20back=20to=20the=20last=20location=20with=20= \\[negative-argument]=20\\[find-tag].")=0A=20=0C=0A@@=20-731,13=20= +732,13=20@@=20tags-reset-tags-tables=0A=20=20=20(interactive)=0A=20=20=20= ;;=20Clear=20out=20the=20markers=20we=20are=20throwing=20away.=0A=20=20=20= (let=20((i=200))=0A-=20=20=20=20(while=20(<=20i=20= xref-marker-ring-length)=0A+=20=20=20=20(while=20(<=20i=20= tags-location-ring-length)=0A=20=20=20=20=20=20=20(if=20(aref=20(cddr=20= tags-location-ring)=20i)=0A=20=09=20=20(set-marker=20(aref=20(cddr=20= tags-location-ring)=20i)=20nil))=0A=20=20=20=20=20=20=20(setq=20i=20(1+=20= i))))=0A=20=20=20(xref-clear-marker-stack)=0A=20=20=20(setq=20= tags-file-name=20nil=0A-=09tags-location-ring=20(make-ring=20= xref-marker-ring-length)=0A+=09tags-location-ring=20(make-ring=20= tags-location-ring-length)=0A=20=09tags-table-list=20nil=0A=20=09= tags-table-computed-list=20nil=0A=20=09tags-table-computed-list-for=20= nil=0Adiff=20--git=20a/lisp/progmodes/xref.el=20b/lisp/progmodes/xref.el=0A= index=2052a4e0c543..502cab022c=20100644=0A---=20a/lisp/progmodes/xref.el=0A= +++=20b/lisp/progmodes/xref.el=0A@@=20-334,15=20+334,7=20@@=20= xref--search-property=0A=20=20=20=20=20=20=20=20=20=20=20(t=20(goto-char=20= start)=20nil))))=0A=20=0A=20=0C=0A-;;;=20Marker=20stack=20=20(M-.=20= pushes,=20M-,=20pops)=0A-=0A-(defcustom=20xref-marker-ring-length=2016=0A= -=20=20"Length=20of=20the=20xref=20marker=20ring.=0A-If=20this=20= variable=20is=20not=20set=20through=20Customize,=20you=20must=20call=0A= -`xref-set-marker-ring-length'=20for=20changes=20to=20take=20effect."=0A= -=20=20:type=20'integer=0A-=20=20:initialize=20= #'custom-initialize-default=0A-=20=20:set=20= #'xref-set-marker-ring-length)=0A+(make-obsolete-variable=20= 'xref-marker-ring-length=20nil=20"29.1")=0A=20=0A=20(defcustom=20= xref-prompt-for-identifier=20'(not=20xref-find-definitions=0A=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= xref-find-definitions-other-window=0A@@=20-413,29=20+405,47=20@@=20= xref-auto-jump-to-first-xref=0A=20=20=20:version=20"28.1"=0A=20=20=20= :package-version=20'(xref=20.=20"1.2.0"))=0A=20=0A-(defvar=20= xref--marker-ring=20(make-ring=20xref-marker-ring-length)=0A-=20=20"Ring=20= of=20markers=20to=20implement=20the=20marker=20stack.")=0A+(defvar=20= xref--history=20(cons=20nil=20nil)=0A+=20=20"(HISTORY-STACK=20.=20= FUTURE-STACK)=20of=20markers=20to=20visited=20Xref=20locations.")=0A+=0A= +(make-obsolete-variable=20'xref-marker-ring=20nil=20"29.1")=0A=20=0A= -(defun=20xref-set-marker-ring-length=20(var=20val)=0A-=20=20"Set=20= `xref-marker-ring-length'.=0A-VAR=20is=20the=20symbol=20= `xref-marker-ring-length'=20and=20VAL=20is=20the=20new=0A-value."=0A-=20=20= (set-default=20var=20val)=0A-=20=20(if=20(ring-p=20xref--marker-ring)=0A= -=20=20=20=20=20=20(ring-resize=20xref--marker-ring=20val)))=0A+(defun=20= xref-set-marker-ring-length=20(_var=20_val)=0A+=20=20(declare=20= (obsolete=20nil=20"29.1"))=0A+=20=20nil)=0A=20=0A=20(defun=20= xref-push-marker-stack=20(&optional=20m)=0A-=20=20"Add=20point=20M=20= (defaults=20to=20`point-marker')=20to=20the=20marker=20stack."=0A-=20=20= (ring-insert=20xref--marker-ring=20(or=20m=20(point-marker))))=0A+=20=20= "Add=20point=20M=20(defaults=20to=20`point-marker')=20to=20the=20marker=20= stack.=0A+The=20future=20stack=20is=20erased."=0A+=20=20(push=20(or=20m=20= (point-marker))=20(car=20xref--history))=0A+=20=20(dolist=20(mk=20(cdr=20= xref--history))=0A+=20=20=20=20(set-marker=20mk=20nil=20nil))=0A+=20=20= (setcdr=20xref--history=20nil))=0A=20=0A=20;;;###autoload=0A=20(defun=20= xref-pop-marker-stack=20()=0A-=20=20"Pop=20back=20to=20where=20= \\[xref-find-definitions]=20was=20last=20invoked."=0A+=20=20"Go=20back=20= to=20the=20previous=20position=20in=20xref=20history.=0A+To=20undo,=20= use=20\\[xref-forward-history]."=0A+=20=20(interactive)=0A+=20=20(if=20= (null=20(car=20xref--history))=0A+=20=20=20=20=20=20(user-error=20"At=20= start=20of=20xref=20history")=0A+=20=20=20=20(let=20((marker=20(pop=20= (car=20xref--history))))=0A+=20=20=20=20=20=20(push=20(point-marker)=20= (cdr=20xref--history))=0A+=20=20=20=20=20=20(switch-to-buffer=20(or=20= (marker-buffer=20marker)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(user-error=20"The=20marked=20= buffer=20has=20been=20deleted")))=0A+=20=20=20=20=20=20(goto-char=20= (marker-position=20marker))=0A+=20=20=20=20=20=20(set-marker=20marker=20= nil=20nil)=0A+=20=20=20=20=20=20(run-hooks=20'xref-after-return-hook))))=0A= +;;=20FIXME:=20rename=20to=20`xref-back-history'.=0A+=0A+;;;###autoload=0A= +(defun=20xref-forward-history=20()=0A+=20=20"Got=20to=20the=20point=20= where=20a=20previous=20\\[xref-pop-marker-stack]=20was=20invoked."=0A=20=20= =20(interactive)=0A-=20=20(let=20((ring=20xref--marker-ring))=0A-=20=20=20= =20(when=20(ring-empty-p=20ring)=0A-=20=20=20=20=20=20(user-error=20= "Marker=20stack=20is=20empty"))=0A-=20=20=20=20(let=20((marker=20= (ring-remove=20ring=200)))=0A+=20=20(if=20(null=20(cdr=20xref--history))=0A= +=20=20=20=20=20=20(user-error=20"At=20end=20of=20xref=20history")=0A+=20= =20=20=20(let=20((marker=20(pop=20(cdr=20xref--history))))=0A+=20=20=20=20= =20=20(push=20(point-marker)=20(car=20xref--history))=0A=20=20=20=20=20=20= =20(switch-to-buffer=20(or=20(marker-buffer=20marker)=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (user-error=20"The=20marked=20buffer=20has=20been=20deleted")))=0A=20=20=20= =20=20=20=20(goto-char=20(marker-position=20marker))=0A@@=20-458,16=20= +468,19=20@@=20xref-pulse-momentarily=0A=20=0A=20;;=20etags.el=20needs=20= this=0A=20(defun=20xref-clear-marker-stack=20()=0A-=20=20"Discard=20all=20= markers=20from=20the=20marker=20stack."=0A-=20=20(let=20((ring=20= xref--marker-ring))=0A-=20=20=20=20(while=20(not=20(ring-empty-p=20= ring))=0A-=20=20=20=20=20=20(let=20((marker=20(ring-remove=20ring)))=0A-=20= =20=20=20=20=20=20=20(set-marker=20marker=20nil=20nil)))))=0A+=20=20= "Discard=20all=20markers=20from=20the=20xref=20history."=0A+=20=20= (dolist=20(l=20(list=20(car=20xref--history)=20(cdr=20xref--history)))=0A= +=20=20=20=20(dolist=20(m=20l)=0A+=20=20=20=20=20=20(set-marker=20m=20= nil=20nil)))=0A+=20=20(setq=20xref--history=20(cons=20nil=20nil))=0A+=20=20= nil)=0A=20=0A=20;;;###autoload=0A=20(defun=20xref-marker-stack-empty-p=20= ()=0A-=20=20"Return=20t=20if=20the=20marker=20stack=20is=20empty;=20nil=20= otherwise."=0A-=20=20(ring-empty-p=20xref--marker-ring))=0A+=20=20= "Whether=20the=20xref=20back-history=20is=20empty."=0A+=20=20(null=20= (car=20xref--history)))=0A+;;=20FIXME:=20rename=20this=20to=20= `xref--back-history-empty-p'=20and=20add=20the=0A+;;=20corresponding=20= forward=20history=20function.=0A=20=0A=20=0C=0A=20=0A@@=20-1487,6=20= +1500,7=20@@=20xref-apropos-regexp=0A=20;;;###autoload=20(define-key=20= esc-map=20","=20#'xref-pop-marker-stack)=0A=20;;;###autoload=20= (define-key=20esc-map=20"?"=20#'xref-find-references)=0A=20= ;;;###autoload=20(define-key=20esc-map=20[?\C-.]=20#'xref-find-apropos)=0A= +;;;###autoload=20(define-key=20esc-map=20[?\C-,]=20= #'xref-forward-history)=0A=20;;;###autoload=20(define-key=20ctl-x-4-map=20= "."=20#'xref-find-definitions-other-window)=0A=20;;;###autoload=20= (define-key=20ctl-x-5-map=20"."=20#'xref-find-definitions-other-frame)=0A= =20=0A--=20=0A2.21.1=20(Apple=20Git-122.3)=0A=0A= --Apple-Mail=_AB687862-6341-40BE-BDC0-5C2554BBC335-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 20 20:38:47 2021 Received: (at control) by debbugs.gnu.org; 21 Oct 2021 00:38:47 +0000 Received: from localhost ([127.0.0.1]:55767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdM6Y-0000Co-SO for submit@debbugs.gnu.org; Wed, 20 Oct 2021 20:38:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdM6X-0000CZ-6A for control@debbugs.gnu.org; Wed, 20 Oct 2021 20:38:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Anw7YZjYVKqPZVe4berSYIJKoryuBTZAt3qkl64BNDs=; b=AJisP6RlDBqcGoBzqMy84HJEbY Gj5v9Oa2jeciVEwNRMjXR+kZtQOOQ3vte0sxYCFMtKGDIhJnvRdyYJcWB66zYQi/53nxAwMUC6zQy We9V6ug+YUYbXkCrpE5NtFgAjO+6QWvHmt6mcUcJfd8ghWmaEEzDYFuNY4fD/BSdd0mg=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdM6O-0004D6-Fi for control@debbugs.gnu.org; Thu, 21 Oct 2021 02:38:38 +0200 Date: Thu, 21 Oct 2021 02:38:35 +0200 Message-Id: <87mtn3ky9g.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #38797 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 38797 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 38797 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 23 21:40:20 2021 Received: (at 38797) by debbugs.gnu.org; 24 Oct 2021 01:40:21 +0000 Received: from localhost ([127.0.0.1]:37622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meSUm-0002JP-LQ for submit@debbugs.gnu.org; Sat, 23 Oct 2021 21:40:20 -0400 Received: from mail-lf1-f51.google.com ([209.85.167.51]:40928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meSUj-0002J7-5J for 38797@debbugs.gnu.org; Sat, 23 Oct 2021 21:40:19 -0400 Received: by mail-lf1-f51.google.com with SMTP id j9so737293lfu.7 for <38797@debbugs.gnu.org>; Sat, 23 Oct 2021 18:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AOfv8zIdyDXShYULjcZ/TyVovo0w58o58xDGpj1muf8=; b=Qrzp1jp5mkkPk/o/ct4AmTuC1tsrMrSDA9Sdh8D50HQA1HFmnyr+mghIaiiByjUcW1 qFakEYzypA+8KCXD6f5+ZXrhGw+bbgOcok5tWA9uzz7xfHHsOOhrtR3d9IaBcG+N0po6 fXaFWs388T28UvTrnod3yWqVLyg4R1oo5+dVBrtJfKOSW4mgfwtQux37CD3f/UnDACgc XWd69uR1/Zl5Yxy4XsCEA4KhcTdIO55a1yY4nZpzd/JkZAfabkQghpVvIHm9WR+9G0/f 2sNOYzeMqzSvHYo9nydPx4wBfcHB5CwtNfyCrXzBNfHjJE6kiH+5LNW0rsMEEl1m+rxX cqlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AOfv8zIdyDXShYULjcZ/TyVovo0w58o58xDGpj1muf8=; b=zQW8+eytx4g1OxGQ2/4oIyQVw/LSOco94tlAl7Z3ncbhIeg0xx900WN/JMWh8RQZ1p utNA5Miu4k0rCkGJQaiGsutB3BXuxIaV9V8pi+ZGYs7B8+/UXg+AtEaGCsgr6yafW05o 1aqM9GOlx0SDm6kLH/y+DMfRf0J1PLeCqCNJjOZBtLFraT9mQhgZRIKzKTkKvnduw9vT iUgPBp9lK0LFnZhhAFf1hQJqFJukAEQAdL7MeHH5xwLdNMAzysGFe8jizZrBFn4XEaeY IXXksiq1MObWrCDhUtjTTv153VF9z4aUhvV3yeqyCWKRcSJk6MoF2j6+L7ngMmYvpsgq rbDw== X-Gm-Message-State: AOAM531DrWHyq6aXfDAOIh8JTAqY0j+BfbtuVxl2Ft3cabIPucnwxAIZ FAm+4Juk6IJEd/Xdwxi2NbgQHF/0yoA= X-Google-Smtp-Source: ABdhPJxSguYomqnDMIBaKKAdnttlpGvRKHG8nm5AhY3OdAKXGiJs2jGVM20GrS8GuBSMcNwGnr185A== X-Received: by 2002:a05:6512:1087:: with SMTP id j7mr8812064lfg.488.1635039610922; Sat, 23 Oct 2021 18:40:10 -0700 (PDT) Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id 25sm663987ljh.50.2021.10.23.18.40.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Oct 2021 18:40:10 -0700 (PDT) Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> From: Dmitry Gutov Message-ID: <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> Date: Sun, 24 Oct 2021 04:40:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 38797 Cc: yyoncho , 38797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 20.10.2021 22:12, Mattias Engdegård wrote: > As usual my message was lost. Here's the patch at least. Thanks, Mattias. Some comments on the latest version of the patch: - The removal of (defvaralias 'find-tag-marker-ring 'xref--marker-ring) and the subsequent initialization of the aliased variable to a new ring will likely break any real code code which is still depending on that variable. Because now it is nil by default, and not a ring. Not sure what's the best solution, perhaps it's just time to remove it. - The call (make-obsolete-variable 'xref-marker-ring-length nil "29.1") is similarly pointless because the variable definition has been deleted. Declaring it obsolete does not help the fact that it is unbound now. It could be made into an alias for the newly introduced tags-location-ring-length, I suppose. Or we hold off on removing it, declare it obsolete (with some explanation), but keep using its alias in etags.el. That would mean dropping all changes in the etags.el part of the patch. But probably adding some 'with-suppressed-warinings' wrappers in there. - Regarding the names of the commands, some alternatives: * xref-rewind-history? It's a play on "fast forward". A bit cryptic, perhaps. * xref-go-back and xref-go-forward? xref--history is fine the name of the variable, but the purpose of the commands seems obvious enough even without "history" in them. No pressure. Just in case you like any of these better. - The slots in the docstring of xref--history (should we call it xref--location-history?) could be called (BACK-STACK . FORWARD-STACK). - xref-set-marker-ring-length's fate is changed accordingly to what we choose to do with xref-marker-ring-length. - The FIXME about proposed xref--back-history-empty-p doesn't make much sense if the introduced function name is going to be private (we don't need private functions that aren't used in the package itself). xref-back-history-empty-p and xref-forward-history-empty-p could work. But we can keep xref-marker-stack-empty-p around, pending feature requests. Maybe add a boolean optional FORWARD argument. Or rename it to xref-history-empty-p, for instance (with the optional FORWARD argument). From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 03:57:50 2021 Received: (at 38797) by debbugs.gnu.org; 24 Oct 2021 07:57:50 +0000 Received: from localhost ([127.0.0.1]:37853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meYO6-00040T-9d for submit@debbugs.gnu.org; Sun, 24 Oct 2021 03:57:50 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:55099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meYO4-00040E-Th for 38797@debbugs.gnu.org; Sun, 24 Oct 2021 03:57:49 -0400 Received: (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 8E7D7100002; Sun, 24 Oct 2021 07:57:40 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack Organization: LINKOV.NET References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> Date: Sun, 24 Oct 2021 10:54:04 +0300 In-Reply-To: <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> (Dmitry Gutov's message of "Sun, 24 Oct 2021 04:40:09 +0300") Message-ID: <87ilxm27wz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38797 Cc: Mattias =?iso-8859-1?Q?Engdeg=E5rd?= , yyoncho , 38797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > - Regarding the names of the commands, some alternatives: > > * xref-rewind-history? It's a play on "fast forward". A bit cryptic, > perhaps. > * xref-go-back and xref-go-forward? xref--history is fine the name of the > variable, but the purpose of the commands seems obvious enough even > without "history" in them. Two different naming conventions are in use already: Info-history-back Info-history-forward help-go-back help-go-forward Choosing any of those would be fine. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 08:40:00 2021 Received: (at 38797) by debbugs.gnu.org; 24 Oct 2021 12:40:00 +0000 Received: from localhost ([127.0.0.1]:38097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mecnA-0001Du-Jq for submit@debbugs.gnu.org; Sun, 24 Oct 2021 08:40:00 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:36812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mecn9-0001Dh-1y for 38797@debbugs.gnu.org; Sun, 24 Oct 2021 08:40:00 -0400 Received: by mail-lf1-f41.google.com with SMTP id g36so5452217lfv.3 for <38797@debbugs.gnu.org>; Sun, 24 Oct 2021 05:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=70xG39DoUFihfBeBmv+tR8yDmueGIYUupjMqh7i7nRg=; b=kQWsX8JxA63f7vEo+zdnIhhqBplZmrOazf45JPUOJ+KzbQdI3DaWpxb3Rs6FxbWFLs 30gNz9tT/ierGrZJZdyyb+nIWZ7wqkJgyxKgZ/RthlepMGkxB1/fbbf18xlDS20ijGFP +rPCtGhOEJXnjfKPHzFKzdjSKrt7QzlimkMSXtAFq9yWrqVjjkyl+H1rln5ICP2w14VM 8S/jbiXoObtENPcO/WLwEEtWa4f5wpuUB2CUMBOwM6EwOeAKlWUPMDQNGx/OKQqTq87d 3+ULawTW/DmrI5/M1+JmAq6UWz5snXW9TrTtEcHCfJtHT9L59XI2GZjEXbEUN+GtlP5I mzmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=70xG39DoUFihfBeBmv+tR8yDmueGIYUupjMqh7i7nRg=; b=KXHJw1UZU1ZrGd9inV5UcWuaaDeUXlNjala7DmlgyyY5VJRaDjGIR1rTIBTpYVQBui HnHW8VqjTxUmzQiBroQ0HTE9UYpb1w8XxUPdjoMtSf6+s++6hci2g7FMllY+NFHMtjkW rv07tkPOuTF2iRM4DZ2daIv+UiREyx0aaWZoX3oTVfTkDVh23Ra+qt45ZZVYeo8oqPrF df2xLEQYu7O03w3LYLEEyKdlj2hajGDnx4JcRTFXI9pkjEIeYwRo6z3P+ijNiEosKY4T DyFw+W4wjGdFXr2oT9PAR2wpGUs0Vnd+tsjZeUyF00zqau7fPQ8yBR+T7A1NYhUaQ2oB u0MA== X-Gm-Message-State: AOAM531DrfOsiP9EW1hqWJrkHvCyaZ60GPqEQs+IGOhXnYkLiIpINmM1 BKkvMr1LGdOJ5EwP1TGoJJcUcbnmKZI= X-Google-Smtp-Source: ABdhPJxOZeP5rDnzeoBgKRASJjadpmzaZjlAUoOIhQ5vNzw3ywTkbmGlBv9iQXXpvEMsfNPeRrU78g== X-Received: by 2002:ac2:4e71:: with SMTP id y17mr10956396lfs.582.1635079192604; Sun, 24 Oct 2021 05:39:52 -0700 (PDT) Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id t12sm1311700lfc.55.2021.10.24.05.39.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Oct 2021 05:39:51 -0700 (PDT) Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack To: Juri Linkov References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <87ilxm27wz.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Sun, 24 Oct 2021 15:39:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87ilxm27wz.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 38797 Cc: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= , yyoncho , 38797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 24.10.2021 10:54, Juri Linkov wrote: >> - Regarding the names of the commands, some alternatives: >> >> * xref-rewind-history? It's a play on "fast forward". A bit cryptic, >> perhaps. >> * xref-go-back and xref-go-forward? xref--history is fine the name of the >> variable, but the purpose of the commands seems obvious enough even >> without "history" in them. > Two different naming conventions are in use already: > > Info-history-back > Info-history-forward > > help-go-back > help-go-forward > > Choosing any of those would be fine. That reminds me of a potential feature: saving the history of searches and going back/forward between them, in the manner of help-go-back and help-go-forward (maybe even with same keybindings). From that perspective, we could choose the names in advance. Either xref-go-back/forward and xref-history-back/forward or, I suppose xref-back-history/forward-history and xref-searches-back/forward ...something like that. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 09:24:39 2021 Received: (at 38797) by debbugs.gnu.org; 24 Oct 2021 13:24:39 +0000 Received: from localhost ([127.0.0.1]:38184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1medUN-0006j1-1E for submit@debbugs.gnu.org; Sun, 24 Oct 2021 09:24:39 -0400 Received: from mail18c50.megamailservers.eu ([91.136.10.28]:39560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1medUK-0006ir-Np for 38797@debbugs.gnu.org; Sun, 24 Oct 2021 09:24:38 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1635081874; bh=AFRe4taSiPZawKAs3oBsDx1KiaofrrJvfkeUPuSEDDI=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=oHDRm6glwuB5Zgjpv+fOSQEb6xcSfaYSM8q54JdLyrkExLuBtv1Z8gWaNq+NUpMVp gqzk3Eu0gL1nYrJ3NJFhNnTSIXA4xYXCHi2fnpZv6z0XpA1vOAQ44MSAyy4YS9E7U8 iFL2dO53fvPD8HeiQlmxD2aiWH8KmJu7tUXm6TtM= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 19ODOVcv024152; Sun, 24 Oct 2021 13:24:33 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_89FB3F1F-AB29-4641-AFF3-70AA67AFFCE5" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack Date: Sun, 24 Oct 2021 15:24:31 +0200 In-Reply-To: <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> To: Dmitry Gutov References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F25.61755E92.0043, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=TLkm93pa c=1 sm=1 tr=0 ts=61755e92 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=M51BFTxLslgA:10 a=vaJtXVxTAAAA:8 a=THkUKpVWQHABbuxhTqYA:9 a=CjuIK1q_8ugA:10 a=U0VzSeGD7hgdPSGEqb4A:9 a=B2y7HmGcmWMA:10 X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 38797 Cc: yyoncho , 38797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_89FB3F1F-AB29-4641-AFF3-70AA67AFFCE5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 24 okt. 2021 kl. 03.40 skrev Dmitry Gutov : > - The removal of >=20 > (defvaralias 'find-tag-marker-ring 'xref--marker-ring) >=20 > and the subsequent initialization of the aliased variable to a new = ring will likely break any real code code which is still depending on = that variable. Because now it is nil by default, and not a ring. Not = sure what's the best solution, perhaps it's just time to remove it. Right; I've resurrected find-tag-marker-ring as a zombie variable. Code = manipulating it will have no effect but at least won't crash, which is = probably a good trade-off. > (make-obsolete-variable 'xref-marker-ring-length nil "29.1") >=20 > is similarly pointless because the variable definition has been = deleted. Declaring it obsolete does not help the fact that it is unbound = now. Correct -- resurrected as a zombie variable here too. > * xref-go-back and xref-go-forward? Good suggestions and now used. (I've still not added xref-go-back as an = alias but that should probably be done.) > - The slots in the docstring of xref--history (should we call it = xref--location-history?) could be called (BACK-STACK . FORWARD-STACK). Yes, done. > - xref-set-marker-ring-length's fate is changed accordingly to what we = choose to do with xref-marker-ring-length. We could make it set the pointless xref-marker-ring-length but I didn't = bother. I doubt anyone is using that function. > - The FIXME about proposed xref--back-history-empty-p doesn't make = much sense if the introduced function name is going to be private Sorry, that wasn't the intention. I've added xref-back-history-empty-p = for use in the new menu entry. (I'll let someone else add it to the context menu because that seemed = much more complicated.) Revised patch attached. --Apple-Mail=_89FB3F1F-AB29-4641-AFF3-70AA67AFFCE5 Content-Disposition: attachment; filename=0001-Add-xref-forward-history-bug-38797.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Add-xref-forward-history-bug-38797.patch" Content-Transfer-Encoding: quoted-printable =46rom=206984b9ed0880a31e70d297f74799e47ee2903d97=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Tue,=2019=20Oct=202021=2013:26:19=20+0200=0A= Subject:=20[PATCH]=20Add=20xref=20forward=20history=20(bug#38797)=0A=0A= Make=20it=20possible=20to=20go=20forward=20as=20well=20as=20back=20in=20= the=20Xref=20history.=0AThe=20new=20`xref-go-forward`=20is=20bound=20to=20= `C-M-,`.=0A=0A*=20lisp/progmodes/etags.el=20= (find-tag-marker-ring-length):=20Update.=0A(tags-location-ring-length):=20= New.=0A(find-tag-marker-ring):=20Keep=20as=20dummy.=0A= (tags-location-ring,=20tags-reset-tags-tables):=0AUse=20= `tags-location-ring-length`=20instead=20of=20`xref-marker-ring-length`.=0A= *=20lisp/progmodes/xref.el=20(xref-marker-ring-length,=20= xref-marker-ring)=0A(xref-set-marker-ring-length):=0AMake=20obsolete.=0A= (xref--history,=20xref-go-forward,=20xref-forward-history-empty-p):=20= New.=0A(xref-push-marker-stack,=20xref-pop-marker-stack)=0A= (xref-clear-marker-stack,=20xref-marker-stack-empty-p):=0AUse=20= `xref--history`.=0A*=20lisp/menu-bar.el=20(menu-bar-goto-menu):=20Add=20= Forward=20entry.=0A*=20doc/emacs/maintaining.texi=20(Looking=20Up=20= Identifiers):=20Document.=0A*=20etc/NEWS:=20Announce.=0A---=0A=20= doc/emacs/maintaining.texi=20|=2013=20++++--=0A=20etc/NEWS=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20|=20=205=20+++=0A=20= lisp/menu-bar.el=20=20=20=20=20=20=20=20=20=20=20|=20=206=20+++=0A=20= lisp/progmodes/etags.el=20=20=20=20|=2013=20+++---=0A=20= lisp/progmodes/xref.el=20=20=20=20=20|=2083=20= +++++++++++++++++++++++---------------=0A=205=20files=20changed,=2079=20= insertions(+),=2041=20deletions(-)=0A=0Adiff=20--git=20= a/doc/emacs/maintaining.texi=20b/doc/emacs/maintaining.texi=0Aindex=20= 5b66031b8a..e28ec5fb43=20100644=0A---=20a/doc/emacs/maintaining.texi=0A= +++=20b/doc/emacs/maintaining.texi=0A@@=20-2140,6=20+2140,9=20@@=20= Looking=20Up=20Identifiers=0A=20@item=20M-,=0A=20Go=20back=20to=20where=20= you=20previously=20invoked=20@kbd{M-.}=20and=20friends=0A=20= (@code{xref-pop-marker-stack}).=0A+@item=20C-M-,=0A+Go=20forward=20to=20= where=20you=20previously=20invoked=20@kbd{M-,}=0A= +(@code{xref-go-forward}).=0A=20@item=20M-x=20xref-etags-mode=0A=20= Switch=20@code{xref}=20to=20use=20the=20@code{etags}=20backend.=0A=20= @end=20table=0A@@=20-2205,14=20+2208,16=20@@=20Looking=20Up=20= Identifiers=0A=20=0A=20@kindex=20M-,=0A=20@findex=20= xref-pop-marker-stack=0A-@vindex=20xref-marker-ring-length=0A=20=20=20To=20= go=20back=20to=20places=20@emph{from=20where}=20you've=20displayed=20the=20= definition,=0A=20use=20@kbd{M-,}=20(@code{xref-pop-marker-stack}).=20=20= It=20jumps=20back=20to=20the=0A=20point=20of=20the=20last=20invocation=20= of=20@kbd{M-.}.=20=20Thus=20you=20can=20find=20and=0A=20examine=20the=20= definition=20of=20something=20with=20@kbd{M-.}=20and=20then=20return=20= to=0A-where=20you=20were=20with=20@kbd{M-,}.=20=20@kbd{M-,}=20allows=20= you=20to=20retrace=20your=0A-steps=20to=20a=20depth=20determined=20by=20= the=20variable=0A-@code{xref-marker-ring-length},=20which=20defaults=20= to=2016.=0A+where=20you=20were=20with=20@kbd{M-,}.=0A+=0A+@kindex=20= C-M-,=0A+@findex=20xref-go-forward=0A+=20=20Go=20forward=20to=20a=20= place=20from=20where=20you=20previously=20went=20back=20using=20= @kbd{M-,}.=0A+This=20is=20useful=20if=20you=20find=20that=20you=20went=20= back=20too=20far.=0A=20=0A=20@findex=20xref-etags-mode=0A=20=20=20Some=20= major=20modes=20install=20@code{xref}=20support=20facilities=20that=20= might=0Adiff=20--git=20a/etc/NEWS=20b/etc/NEWS=0Aindex=20= 294181635e..e0c2aead94=20100644=0A---=20a/etc/NEWS=0A+++=20b/etc/NEWS=0A= @@=20-176,6=20+176,11=20@@=20it=20with=20new=20= 'term-{faint,italic,slow-blink,fast-blink}'=20faces.=0A=20***=20= 'project-find-file'=20and=20'project-or-external-find-file'=20now=20= accept=0A=20a=20prefix=20argument=20which=20is=20interpreted=20to=20mean=20= "include=20all=20files".=0A=20=0A++++=0A+***=20New=20command=20= 'xref-go-forward'.=0A+It=20is=20bound=20to=20'C-M-,'=20and=20jumps=20to=20= the=20location=20where=20'xref-pop-marker-stack'=0A+was=20invoked=20= previously.=0A+=0A=20**=20File=20notifications=0A=20=0A=20+++=0Adiff=20= --git=20a/lisp/menu-bar.el=20b/lisp/menu-bar.el=0Aindex=20= fafc99eb95..d1bb8d9677=20100644=0A---=20a/lisp/menu-bar.el=0A+++=20= b/lisp/menu-bar.el=0A@@=20-419,6=20+419,12=20@@=20menu-bar-goto-menu=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(not=20(xref-marker-stack-empty-p)))=0A=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20:help=20"Back=20to=20the=20= position=20of=20the=20last=20search"))=0A=20=0A+=20=20=20=20= (bindings--define-key=20menu=20[xref-forward]=0A+=20=20=20=20=20=20= '(menu-item=20"Forward"=20xref-go-forward=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20:visible=20(and=20(featurep=20'xref)=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(not=20(xref-forward-history-empty-p)))=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20:help=20"Forward=20to=20the=20= position=20gone=20Back=20from"))=0A+=0A=20=20=20=20=20= (bindings--define-key=20menu=20[xref-apropos]=0A=20=20=20=20=20=20=20= '(menu-item=20"Find=20Apropos..."=20xref-find-apropos=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20:help=20"Find=20= function/variables=20whose=20names=20match=20regexp"))=0Adiff=20--git=20= a/lisp/progmodes/etags.el=20b/lisp/progmodes/etags.el=0Aindex=20= d2ce813daa..318121fbb5=20100644=0A---=20a/lisp/progmodes/etags.el=0A+++=20= b/lisp/progmodes/etags.el=0A@@=20-145,7=20+145,9=20@@=20= find-tag-default-function=0A=20=20=20:type=20'(choice=20(const=20nil)=20= function))=0A=20=0A=20(define-obsolete-variable-alias=20= 'find-tag-marker-ring-length=0A-=20=20'xref-marker-ring-length=20"25.1")=0A= +=20=20'tags-location-ring-length=20"25.1")=0A+=0A+(defvar=20= tags-location-ring-length=2016)=0A=20=0A=20(defcustom=20tags-tag-face=20= 'default=0A=20=20=20"Face=20for=20tags=20in=20the=20output=20of=20= `tags-apropos'."=0A@@=20-180,7=20+182,8=20@@=20= tags-apropos-additional-actions=0A=20=09=09=20=20=20=20=20=20=20(sexp=20= :tag=20"Tags=20to=20search")))=0A=20=20=20:version=20"21.1")=0A=20=0A= -(defvaralias=20'find-tag-marker-ring=20'xref--marker-ring)=0A+;;=20= Obsolete=20variable=20kept=20for=20compatibility.=20We=20don't=20use=20= it=20in=20any=20way.=0A+(defvar=20find-tag-marker-ring=20(make-ring=20= 16))=0A=20(make-obsolete-variable=0A=20=20'find-tag-marker-ring=0A=20=20= "use=20`xref-push-marker-stack'=20or=20`xref-pop-marker-stack'=20= instead."=0A@@=20-191,7=20+194,7=20@@=20default-tags-table-function=0A=20= This=20function=20receives=20no=20arguments=20and=20should=20return=20= the=20default=0A=20tags=20table=20file=20to=20use=20for=20the=20current=20= buffer.")=0A=20=0A-(defvar=20tags-location-ring=20(make-ring=20= xref-marker-ring-length)=0A+(defvar=20tags-location-ring=20(make-ring=20= tags-location-ring-length)=0A=20=20=20"Ring=20of=20markers=20which=20are=20= locations=20visited=20by=20\\[find-tag].=0A=20Pop=20back=20to=20the=20= last=20location=20with=20\\[negative-argument]=20\\[find-tag].")=0A=20=0C= =0A@@=20-731,13=20+734,13=20@@=20tags-reset-tags-tables=0A=20=20=20= (interactive)=0A=20=20=20;;=20Clear=20out=20the=20markers=20we=20are=20= throwing=20away.=0A=20=20=20(let=20((i=200))=0A-=20=20=20=20(while=20(<=20= i=20xref-marker-ring-length)=0A+=20=20=20=20(while=20(<=20i=20= tags-location-ring-length)=0A=20=20=20=20=20=20=20(if=20(aref=20(cddr=20= tags-location-ring)=20i)=0A=20=09=20=20(set-marker=20(aref=20(cddr=20= tags-location-ring)=20i)=20nil))=0A=20=20=20=20=20=20=20(setq=20i=20(1+=20= i))))=0A=20=20=20(xref-clear-marker-stack)=0A=20=20=20(setq=20= tags-file-name=20nil=0A-=09tags-location-ring=20(make-ring=20= xref-marker-ring-length)=0A+=09tags-location-ring=20(make-ring=20= tags-location-ring-length)=0A=20=09tags-table-list=20nil=0A=20=09= tags-table-computed-list=20nil=0A=20=09tags-table-computed-list-for=20= nil=0Adiff=20--git=20a/lisp/progmodes/xref.el=20b/lisp/progmodes/xref.el=0A= index=20a198ae349e..66ac89e72f=20100644=0A---=20a/lisp/progmodes/xref.el=0A= +++=20b/lisp/progmodes/xref.el=0A@@=20-341,15=20+341,9=20@@=20= xref--search-property=0A=20=20=20=20=20=20=20=20=20=20=20(t=20(goto-char=20= start)=20nil))))=0A=20=0A=20=0C=0A-;;;=20Marker=20stack=20=20(M-.=20= pushes,=20M-,=20pops)=0A-=0A-(defcustom=20xref-marker-ring-length=2016=0A= -=20=20"Length=20of=20the=20xref=20marker=20ring.=0A-If=20this=20= variable=20is=20not=20set=20through=20Customize,=20you=20must=20call=0A= -`xref-set-marker-ring-length'=20for=20changes=20to=20take=20effect."=0A= -=20=20:type=20'integer=0A-=20=20:initialize=20= #'custom-initialize-default=0A-=20=20:set=20= #'xref-set-marker-ring-length)=0A+;;=20Dummy=20variable=20retained=20for=20= compatibility.=0A+(defvar=20xref-marker-ring-length=2016)=0A= +(make-obsolete-variable=20'xref-marker-ring-length=20nil=20"29.1")=0A=20= =0A=20(defcustom=20xref-prompt-for-identifier=20'(not=20= xref-find-definitions=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20xref-find-definitions-other-window=0A@@=20-420,29=20+414,47=20= @@=20xref-auto-jump-to-first-xref=0A=20=20=20:version=20"28.1"=0A=20=20=20= :package-version=20'(xref=20.=20"1.2.0"))=0A=20=0A-(defvar=20= xref--marker-ring=20(make-ring=20xref-marker-ring-length)=0A-=20=20"Ring=20= of=20markers=20to=20implement=20the=20marker=20stack.")=0A+(defvar=20= xref--history=20(cons=20nil=20nil)=0A+=20=20"(BACKWARD-STACK=20.=20= FORWARD-STACK)=20of=20markers=20to=20visited=20Xref=20locations.")=0A+=0A= +(make-obsolete-variable=20'xref-marker-ring=20nil=20"29.1")=0A=20=0A= -(defun=20xref-set-marker-ring-length=20(var=20val)=0A-=20=20"Set=20= `xref-marker-ring-length'.=0A-VAR=20is=20the=20symbol=20= `xref-marker-ring-length'=20and=20VAL=20is=20the=20new=0A-value."=0A-=20=20= (set-default=20var=20val)=0A-=20=20(if=20(ring-p=20xref--marker-ring)=0A= -=20=20=20=20=20=20(ring-resize=20xref--marker-ring=20val)))=0A+(defun=20= xref-set-marker-ring-length=20(_var=20_val)=0A+=20=20(declare=20= (obsolete=20nil=20"29.1"))=0A+=20=20nil)=0A=20=0A=20(defun=20= xref-push-marker-stack=20(&optional=20m)=0A-=20=20"Add=20point=20M=20= (defaults=20to=20`point-marker')=20to=20the=20marker=20stack."=0A-=20=20= (ring-insert=20xref--marker-ring=20(or=20m=20(point-marker))))=0A+=20=20= "Add=20point=20M=20(defaults=20to=20`point-marker')=20to=20the=20marker=20= stack.=0A+The=20future=20stack=20is=20erased."=0A+=20=20(push=20(or=20m=20= (point-marker))=20(car=20xref--history))=0A+=20=20(dolist=20(mk=20(cdr=20= xref--history))=0A+=20=20=20=20(set-marker=20mk=20nil=20nil))=0A+=20=20= (setcdr=20xref--history=20nil))=0A=20=0A=20;;;###autoload=0A=20(defun=20= xref-pop-marker-stack=20()=0A-=20=20"Pop=20back=20to=20where=20= \\[xref-find-definitions]=20was=20last=20invoked."=0A+=20=20"Go=20back=20= to=20the=20previous=20position=20in=20xref=20history.=0A+To=20undo,=20= use=20\\[xref-go-forward]."=0A=20=20=20(interactive)=0A-=20=20(let=20= ((ring=20xref--marker-ring))=0A-=20=20=20=20(when=20(ring-empty-p=20= ring)=0A-=20=20=20=20=20=20(user-error=20"Marker=20stack=20is=20empty"))=0A= -=20=20=20=20(let=20((marker=20(ring-remove=20ring=200)))=0A+=20=20(if=20= (null=20(car=20xref--history))=0A+=20=20=20=20=20=20(user-error=20"At=20= start=20of=20xref=20history")=0A+=20=20=20=20(let=20((marker=20(pop=20= (car=20xref--history))))=0A+=20=20=20=20=20=20(push=20(point-marker)=20= (cdr=20xref--history))=0A+=20=20=20=20=20=20(switch-to-buffer=20(or=20= (marker-buffer=20marker)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(user-error=20"The=20marked=20= buffer=20has=20been=20deleted")))=0A+=20=20=20=20=20=20(goto-char=20= (marker-position=20marker))=0A+=20=20=20=20=20=20(set-marker=20marker=20= nil=20nil)=0A+=20=20=20=20=20=20(run-hooks=20'xref-after-return-hook))))=0A= +;;=20FIXME:=20rename=20to=20`xref-go-back'.=0A+=0A+;;;###autoload=0A= +(defun=20xref-go-forward=20()=0A+=20=20"Got=20to=20the=20point=20where=20= a=20previous=20\\[xref-pop-marker-stack]=20was=20invoked."=0A+=20=20= (interactive)=0A+=20=20(if=20(null=20(cdr=20xref--history))=0A+=20=20=20=20= =20=20(user-error=20"At=20end=20of=20xref=20history")=0A+=20=20=20=20= (let=20((marker=20(pop=20(cdr=20xref--history))))=0A+=20=20=20=20=20=20= (push=20(point-marker)=20(car=20xref--history))=0A=20=20=20=20=20=20=20= (switch-to-buffer=20(or=20(marker-buffer=20marker)=0A=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (user-error=20"The=20marked=20buffer=20has=20been=20deleted")))=0A=20=20=20= =20=20=20=20(goto-char=20(marker-position=20marker))=0A@@=20-465,17=20= +477,23=20@@=20xref-pulse-momentarily=0A=20=0A=20;;=20etags.el=20needs=20= this=0A=20(defun=20xref-clear-marker-stack=20()=0A-=20=20"Discard=20all=20= markers=20from=20the=20marker=20stack."=0A-=20=20(let=20((ring=20= xref--marker-ring))=0A-=20=20=20=20(while=20(not=20(ring-empty-p=20= ring))=0A-=20=20=20=20=20=20(let=20((marker=20(ring-remove=20ring)))=0A-=20= =20=20=20=20=20=20=20(set-marker=20marker=20nil=20nil)))))=0A+=20=20= "Discard=20all=20markers=20from=20the=20xref=20history."=0A+=20=20= (dolist=20(l=20(list=20(car=20xref--history)=20(cdr=20xref--history)))=0A= +=20=20=20=20(dolist=20(m=20l)=0A+=20=20=20=20=20=20(set-marker=20m=20= nil=20nil)))=0A+=20=20(setq=20xref--history=20(cons=20nil=20nil))=0A+=20=20= nil)=0A=20=0A=20;;;###autoload=0A=20(defun=20xref-marker-stack-empty-p=20= ()=0A-=20=20"Return=20t=20if=20the=20marker=20stack=20is=20empty;=20nil=20= otherwise."=0A-=20=20(ring-empty-p=20xref--marker-ring))=0A+=20=20= "Whether=20the=20xref=20back-history=20is=20empty."=0A+=20=20(null=20= (car=20xref--history)))=0A+;;=20FIXME:=20rename=20this=20to=20= `xref-back-history-empty-p'.=0A=20=0A+;;;###autoload=0A+(defun=20= xref-forward-history-empty-p=20()=0A+=20=20"Whether=20the=20xref=20= forward-history=20is=20empty."=0A+=20=20(null=20(cdr=20xref--history)))=0A= =20=0C=0A=20=0A=20(defun=20xref--goto-char=20(pos)=0A@@=20-1494,6=20= +1512,7=20@@=20xref-apropos-regexp=0A=20;;;###autoload=20(define-key=20= esc-map=20","=20#'xref-pop-marker-stack)=0A=20;;;###autoload=20= (define-key=20esc-map=20"?"=20#'xref-find-references)=0A=20= ;;;###autoload=20(define-key=20esc-map=20[?\C-.]=20#'xref-find-apropos)=0A= +;;;###autoload=20(define-key=20esc-map=20[?\C-,]=20#'xref-go-forward)=0A= =20;;;###autoload=20(define-key=20ctl-x-4-map=20"."=20= #'xref-find-definitions-other-window)=0A=20;;;###autoload=20(define-key=20= ctl-x-5-map=20"."=20#'xref-find-definitions-other-frame)=0A=20=0A--=20=0A= 2.21.1=20(Apple=20Git-122.3)=0A=0A= --Apple-Mail=_89FB3F1F-AB29-4641-AFF3-70AA67AFFCE5-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 15:18:04 2021 Received: (at 38797) by debbugs.gnu.org; 24 Oct 2021 19:18:04 +0000 Received: from localhost ([127.0.0.1]:40968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mej0N-0008GF-W7 for submit@debbugs.gnu.org; Sun, 24 Oct 2021 15:18:04 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:34057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mej0K-0008F0-HW for 38797@debbugs.gnu.org; Sun, 24 Oct 2021 15:18:01 -0400 Received: (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 13A5F200004; Sun, 24 Oct 2021 19:17:52 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack Organization: LINKOV.NET References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <87ilxm27wz.fsf@mail.linkov.net> Date: Sun, 24 Oct 2021 22:10:27 +0300 In-Reply-To: (Dmitry Gutov's message of "Sun, 24 Oct 2021 15:39:51 +0300") Message-ID: <87sfwqi7dd.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38797 Cc: Mattias =?iso-8859-1?Q?Engdeg=E5rd?= , yyoncho , 38797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > That reminds me of a potential feature: saving the history of searches and > going back/forward between them, in the manner of help-go-back and > help-go-forward (maybe even with same keybindings). > > From that perspective, we could choose the names in advance. Either > > xref-go-back/forward and xref-history-back/forward > > or, I suppose > > xref-back-history/forward-history and xref-searches-back/forward > > ...something like that. I never had such a problem thanks to the customization that creates a new buffer for every search: (add-hook 'xref--xref-buffer-mode-hook 'rename-uniquely) From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 19:22:19 2021 Received: (at 38797) by debbugs.gnu.org; 24 Oct 2021 23:22:19 +0000 Received: from localhost ([127.0.0.1]:41268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1memol-0004Ji-1M for submit@debbugs.gnu.org; Sun, 24 Oct 2021 19:22:19 -0400 Received: from mail-lj1-f172.google.com ([209.85.208.172]:40515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1memog-0004JP-6M for 38797@debbugs.gnu.org; Sun, 24 Oct 2021 19:22:17 -0400 Received: by mail-lj1-f172.google.com with SMTP id w23so4851833lje.7 for <38797@debbugs.gnu.org>; Sun, 24 Oct 2021 16:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VpmxgCDUlG5yUgBUZoeIvVl3NYh6oSfPTrOv4GoiBGc=; b=aZp2OKRLm4f9Pc6PXh5ThsI+P0iN31rtMQ7JKlJ4tw5AFhU7LWqjwbvt2D+/8HmQb9 mqKxb64m3r9O15k4g/Ow/MSZLE1OjITkWG+nKTzvA0Vdy44sTpEAYAveeqGQSPJeNSL/ 6P9Gvp2jSkZYAAvceOe2gXzo5KGh5rU1h9We105YQpZeHQigMdy34FAKUqMLVzuOKP6u b/rsJL6PKsXG8k5mlDy7Pu4EL1O8jUu+t3cxHM2Vo23y69WXtbhVBpK28PN1mqBsDYBj /UkdIU/32YrActlbF2CCeA5hsTeBKWN2D/KuQRyyxgpeQ9HIxuPWqpV23PV+zsHHjJds dusA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VpmxgCDUlG5yUgBUZoeIvVl3NYh6oSfPTrOv4GoiBGc=; b=WHcRebIXQuxF+ggS5jJx43mn8ZDkFNn1ZxPReyZJacni+VyCaXDyOUhnDvdFkMrXBq satTLtMvOqC3xO1FjH7MMZu4uAjVC39b77RyguTOQhmoaBaK+mMjJAQTR3p3485SWghL RQ5n7di78eKA4VprDO0GK/2fMF4vA4D6tM1L9RQQYZQPr4GiNf0sMctuO+lbPPUl/YDA /qWOW54736wzISSUaFP+BpdnGBFnvR4oABwJHIANwIfTOU7W97zbJ3o4sPLwgsli7kRk Vxl94cqGK5QL2Daw75W2YXR3ccNwys7dCTqkgcUvzm/cDTaGWb1mhMwE+otT7inubTOB s9eA== X-Gm-Message-State: AOAM530O4lqifmNgya9eAORf5xvTa0wWVnwBscR5PNBSTSFuKpsR4iPU 2ow8MrwYMi7W0xbC2CC+joKca8IQylA= X-Google-Smtp-Source: ABdhPJxNDFURMjFzm0uUJuP1COpQz2TovDEPlZFHtkJbsePGVFfDCWsodkCgszQ7p7jTYvb+GRkb+Q== X-Received: by 2002:a2e:2f1d:: with SMTP id v29mr14899280ljv.439.1635117728139; Sun, 24 Oct 2021 16:22:08 -0700 (PDT) Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id 79sm1565896ljj.124.2021.10.24.16.22.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Oct 2021 16:22:07 -0700 (PDT) Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack To: Juri Linkov References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <87ilxm27wz.fsf@mail.linkov.net> <87sfwqi7dd.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <4c25c196-ba72-b509-c5d7-f015c37009f8@yandex.ru> Date: Mon, 25 Oct 2021 02:22:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87sfwqi7dd.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 38797 Cc: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= , yyoncho , 38797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 24.10.2021 22:10, Juri Linkov wrote: >> That reminds me of a potential feature: saving the history of searches and >> going back/forward between them, in the manner of help-go-back and >> help-go-forward (maybe even with same keybindings). >> >> From that perspective, we could choose the names in advance. Either >> >> xref-go-back/forward and xref-history-back/forward >> >> or, I suppose >> >> xref-back-history/forward-history and xref-searches-back/forward >> >> ...something like that. > > I never had such a problem thanks to the customization > that creates a new buffer for every search: > > (add-hook 'xref--xref-buffer-mode-hook 'rename-uniquely) It's a nice intermediate solution, but it would also be nice to be able to quickly iterate across previous searches. No? From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 24 22:13:53 2021 Received: (at 38797) by debbugs.gnu.org; 25 Oct 2021 02:13:53 +0000 Received: from localhost ([127.0.0.1]:41326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mepUm-0004Pm-S1 for submit@debbugs.gnu.org; Sun, 24 Oct 2021 22:13:52 -0400 Received: from mail-lj1-f169.google.com ([209.85.208.169]:36605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mepUl-0004PZ-1j for 38797@debbugs.gnu.org; Sun, 24 Oct 2021 22:13:51 -0400 Received: by mail-lj1-f169.google.com with SMTP id q16so6348603ljg.3 for <38797@debbugs.gnu.org>; Sun, 24 Oct 2021 19:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GlY1kacJBHhupiGKRGgA0Y18PrNtCZd5DlS/RNMKpvY=; b=Kq0wsMIUdiyXxI3jRRHdf6qWoa1457DjufSR477VwDliZTJ1w9yaNqQsZKgDEwC2SY 4jbi/Y5WZR9dqg2UNeEwfMloGCPVRmkU12pQtU4KHTg//QhSUR2vM1abxPEmNaRiZTLH O52Fydo9eeMXrVAeY3pPdQNMp3WxLo8D2EmlwohUK7/s5qUV3PaxoA77wgMT0RnJQ1Yp zGmqj9j6E1YXPGvhMKto0AHcGcpzPQGBN7nhp5xcET3EewqVXa0zsSJURxBzL05MKiNM VysbsE3/7Nw+HVFNiMoPu/dK9TTSxIF7sEvH9dyYVkikc+K8+z1IBphvrnJjAxTqha98 wbRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GlY1kacJBHhupiGKRGgA0Y18PrNtCZd5DlS/RNMKpvY=; b=7NcY0k6jSgtqTKNm3ZV20BBCikliXuUBVHB2q5yTSbla6U8mT+1q8IRrtxcqcXAroR 9MJLi3ouPZIuktQlDsFvzvKn4IADBzaOK/pcpiglv1OSfytaITgXcMfdwebbkU5TiFtm PIeLeKO3L1Tz0UUUvqTGks+IEfMDNx04jXTO3GphMWEpoC//UwQOv5l11VQrob79l29I G+8aClwHc+ODk1mfWYuQiBaSy7LWjOMSCzzID+M642mBPXX1yayyKRGCZcEp8NtXWidg tlTbAXN/OIqrB+K+T8ryhvr/d3A6FRpUHLit7kdurSNu1iEdsEGTJBFSlW+7/IBCUnT8 xiDQ== X-Gm-Message-State: AOAM531o1nPgt4FbpLuCaYsaa+BqYD8ojJc1p6NtCxKOyUZG5EHOHh0G jPL2L/5bs3qLSn2N6KaAdL/ZLfWC1as= X-Google-Smtp-Source: ABdhPJyihwAPNpDKONAHaG0J7sJ36GXFcjAb8B2uDgAC1+7PgL37BQHIMNOitqpvu73WULFCK+08LA== X-Received: by 2002:a2e:a54b:: with SMTP id e11mr16807085ljn.192.1635128025057; Sun, 24 Oct 2021 19:13:45 -0700 (PDT) Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id s19sm1582049ljp.115.2021.10.24.19.13.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Oct 2021 19:13:44 -0700 (PDT) Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> From: Dmitry Gutov Message-ID: Date: Mon, 25 Oct 2021 05:13:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 38797 Cc: yyoncho , 38797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 24.10.2021 16:24, Mattias Engdegård wrote: > Revised patch attached. LGTM, please install. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 25 03:55:29 2021 Received: (at 38797) by debbugs.gnu.org; 25 Oct 2021 07:55:30 +0000 Received: from localhost ([127.0.0.1]:41564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meupN-0004d3-Na for submit@debbugs.gnu.org; Mon, 25 Oct 2021 03:55:29 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:49427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meupM-0004cp-CH for 38797@debbugs.gnu.org; Mon, 25 Oct 2021 03:55:28 -0400 Received: (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 5C7DE20012; Mon, 25 Oct 2021 07:55:19 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack Organization: LINKOV.NET References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <87ilxm27wz.fsf@mail.linkov.net> <87sfwqi7dd.fsf@mail.linkov.net> <4c25c196-ba72-b509-c5d7-f015c37009f8@yandex.ru> Date: Mon, 25 Oct 2021 10:44:01 +0300 In-Reply-To: <4c25c196-ba72-b509-c5d7-f015c37009f8@yandex.ru> (Dmitry Gutov's message of "Mon, 25 Oct 2021 02:22:06 +0300") Message-ID: <877de1lfb2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38797 Cc: Mattias =?iso-8859-1?Q?Engdeg=E5rd?= , yyoncho , 38797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> That reminds me of a potential feature: saving the history of searches and >>> going back/forward between them, in the manner of help-go-back and >>> help-go-forward (maybe even with same keybindings). >>> >>> From that perspective, we could choose the names in advance. Either >>> >>> xref-go-back/forward and xref-history-back/forward >>> >>> or, I suppose >>> >>> xref-back-history/forward-history and xref-searches-back/forward >>> >>> ...something like that. >> I never had such a problem thanks to the customization >> that creates a new buffer for every search: >> (add-hook 'xref--xref-buffer-mode-hook 'rename-uniquely) > > It's a nice intermediate solution, but it would also be nice to be able to > quickly iterate across previous searches. No? This means adding another layer of complexity. Remember a mess of deciding how to switch next-error navigations from different searches? Switching multiple xref searches will have the same level of confusion. BTW, shouldn't xref-go-back/forward support next-error-function? ;-) From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 25 11:18:26 2021 Received: (at 38797) by debbugs.gnu.org; 25 Oct 2021 15:18:26 +0000 Received: from localhost ([127.0.0.1]:44004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf1ju-0003tE-Hn for submit@debbugs.gnu.org; Mon, 25 Oct 2021 11:18:26 -0400 Received: from mail-lj1-f176.google.com ([209.85.208.176]:44703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf1jt-0003sx-0M for 38797@debbugs.gnu.org; Mon, 25 Oct 2021 11:18:17 -0400 Received: by mail-lj1-f176.google.com with SMTP id s19so9886320ljj.11 for <38797@debbugs.gnu.org>; Mon, 25 Oct 2021 08:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ETuV59L8f34XxZXYb0dquxx83WbjJzEoMUw1bnJ//PY=; b=QnfJGz4ywnvfMmiRhP/GXsCgoRfbJz4hymhr/p+GpiFZoefjzaEU4rB1RrPqrC20gv br1dH1txWuDB20+3s/or3NnguDKFpn+skkWZXH66T7URRHTdYdQZ5SQrOf4JgTrl5awu ki6zawYhJnGSh33m++mWDI8AhUNObdkm+V0sQPC4YAG4nMFJwvqaqoaIpo8MaoPEe32h HyB1O+n6/FAxFcxyJEW0Chftal1qcd/MdCGGYqUrn5WI2UhaL+t7ktMS9UE7+2oxNFzj Q1RfwPoCuTXxP2bMkZxgg88C+iCI8D0F1CRLlIcFFPDC9zEh/vwSnE241ufNwGwOueGg x+/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ETuV59L8f34XxZXYb0dquxx83WbjJzEoMUw1bnJ//PY=; b=gBbXPJw7oIY4OjE2lGMIuqsBsX2EjUktCMREH5/OyHH4wHVRfTTEjgx3hSZ/QGMyb1 HRFoRGslM/AZxscfPvQqNiukj5PQy3hvCaXxPJn2I8QvL1nAjPIXch3Dt0WyXqAlKfI1 +qxK1lffZ8TmAf0J85y1HhRDrfGIATZXo+vMwN5bIZhBmjOsP/+G6q36o9p3Ys9qw0jS QsWElpji3wpKvsdYL6DwVTreYpgpX9B3Fzn9lBMeQ+5mQ5dhS7AOs0eUKrsRIwbsuDtq uFXyQbnSDgWtJXxd7shMvfQSl0A95CJhftyzaScIyVYx6aGduEo7OuMlRA2V0zo7+H8I OH8w== X-Gm-Message-State: AOAM532d24hRlE4xNwnhQkbr/HCSnpJ3ygJkgrjbuLm/c7M3CK5Jjnhm Ytj+xy5Jr+s0wI5VF7bXe4NuRfF/mDI= X-Google-Smtp-Source: ABdhPJybT8s506/l0NebAQ/i6WEUlPsbhp8nDHLclf9pT6XghMI5fSmCqrGdNMee0qj7i7pB4wSHoQ== X-Received: by 2002:a2e:8e8a:: with SMTP id z10mr19339861ljk.243.1635175091062; Mon, 25 Oct 2021 08:18:11 -0700 (PDT) Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id a16sm1669074lfu.274.2021.10.25.08.18.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 08:18:10 -0700 (PDT) Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack To: Juri Linkov References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <87ilxm27wz.fsf@mail.linkov.net> <87sfwqi7dd.fsf@mail.linkov.net> <4c25c196-ba72-b509-c5d7-f015c37009f8@yandex.ru> <877de1lfb2.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Mon, 25 Oct 2021 18:18:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <877de1lfb2.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 38797 Cc: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= , yyoncho , 38797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 25.10.2021 10:44, Juri Linkov wrote: >> It's a nice intermediate solution, but it would also be nice to be able to >> quickly iterate across previous searches. No? > > This means adding another layer of complexity. Remember a mess > of deciding how to switch next-error navigations from different searches? > Switching multiple xref searches will have the same level of confusion. Unless we do want to be able to switch next-error navigation sources this way? Alternatively, we could uniquify the Xref buffers in a more predictable way (e.g. by using the caller command and the input string, somehow), and then have commands xref-searches-back and xref-searches-format switch between the resulting buffers. > BTW, shouldn't xref-go-back/forward support next-error-function? ;-) What kind of support? Not sure I understand, sorry. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 25 11:50:07 2021 Received: (at 38797) by debbugs.gnu.org; 25 Oct 2021 15:50:07 +0000 Received: from localhost ([127.0.0.1]:44064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf2Eh-0000j6-AF for submit@debbugs.gnu.org; Mon, 25 Oct 2021 11:50:07 -0400 Received: from mail1469c50.megamailservers.eu ([91.136.14.69]:34856 helo=mail102c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf2Ec-0000iP-Hq for 38797@debbugs.gnu.org; Mon, 25 Oct 2021 11:50:06 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1635176995; bh=B/3YgrZx/6W8uEtYCEhL5r8M6G283Cg0Qx2GgmnJZqA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Rjq2g55o9cpPdWjbtuMtccTMfr+OJowCtX4jLhcWAeZVx7GltwbREroqwGS0QD/IC 1BUJBvVPcE35d3DHSDyD4bI8DrbtW6432ltd3Az29OpWiUnmoefdZsx0aYBagVgEmJ XNWWnMxkQhCXqt/YuAOP7A/D0OGP+UW4Y7UFBC9s= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail102c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 19PFnqFb013016; Mon, 25 Oct 2021 15:49:54 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Mon, 25 Oct 2021 17:49:52 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> To: Dmitry Gutov X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F15.6176D223.0018, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=e55l9Yl/ c=1 sm=1 tr=0 ts=6176d223 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=vaJtXVxTAAAA:8 a=28XYMY5DmFKE8dOnYUQA:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 38797 Cc: Juri Linkov , yyoncho , 38797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 25 okt. 2021 kl. 04.13 skrev Dmitry Gutov : > LGTM, please install. Thank you Dmitry, now pushed to master. Juri, would you help out with adding (or not) `xref-go-forward` to the = context menu? I wasn't sure if we had agreed on good names for this and = the go-back entries. The current "Back Definition" is a bit nonsensical = in English. I favour (lightly) "Go Back" / "Go Forward" because they make sense in = context with the other Xref operations in that separator-delimited group = of entries in the menu, and because it's a wording often used for these = operations elsewhere such as in web browsers and IDEs (though often it's = just "Back" and "Forward"). "Xref {Back,Forward}" or "{Back,Forward} Xref" would also do and = displays the link to Xref up front, but the English is decidedly less = natural. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 25 13:08:23 2021 Received: (at 38797) by debbugs.gnu.org; 25 Oct 2021 17:08:23 +0000 Received: from localhost ([127.0.0.1]:44159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf3SR-0002p7-Bv for submit@debbugs.gnu.org; Mon, 25 Oct 2021 13:08:23 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:51981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf3SN-0002oi-1t for 38797@debbugs.gnu.org; Mon, 25 Oct 2021 13:08:20 -0400 Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id EEEC0240008; Mon, 25 Oct 2021 17:08:10 +0000 (UTC) From: Juri Linkov To: Mattias =?iso-8859-1?Q?Engdeg=E5rd?= Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack Organization: LINKOV.NET References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> Date: Mon, 25 Oct 2021 20:05:33 +0300 In-Reply-To: ("Mattias =?iso-8859-1?Q?Engdeg=E5rd=22's?= message of "Mon, 25 Oct 2021 17:49:52 +0200") Message-ID: <87h7d5xcf6.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38797 Cc: 38797@debbugs.gnu.org, yyoncho , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> LGTM, please install. > > Thank you Dmitry, now pushed to master. I took a look at your change, and noticed an asymmetry between the names xref-pop-marker-stack and xref-go-forward. Shouldn't the name xref-pop-marker-stack be obsoleted, and replaced with a new name xref-go-back? (I see now that you added FIXME for this.) Another question is that in the menu bar currently the order is "Forward" and "Back". But more natural order would be "Back" and "Forward". > Juri, would you help out with adding (or not) `xref-go-forward` to the > context menu? I wasn't sure if we had agreed on good names for this and the > go-back entries. The current "Back Definition" is a bit nonsensical in > English. I completely agree that the current title is inappropriate. > I favour (lightly) "Go Back" / "Go Forward" because they make sense in > context with the other Xref operations in that separator-delimited group of > entries in the menu, and because it's a wording often used for these > operations elsewhere such as in web browsers and IDEs (though often it's > just "Back" and "Forward"). > > "Xref {Back,Forward}" or "{Back,Forward} Xref" would also do and displays > the link to Xref up front, but the English is decidedly less natural. With such a test case: 0. emacs -Q 1. click mouse-3 on any word in *scratch*, and select from the context menu "Find Definition". It should fail with the error "No definitions found for: This". This is correct. 2. now click mouse-3 at the end of *scratch*, not on a word. The menu contains the item "Back Definition". (BTW, why if the search failed?) This menu item is too ambiguous. Renaming it to "Go Back" or "Go Forward" doesn't make the menu item clearer. Only adding a word "Xref" somewhere will disambiguate it. Maybe then "Go Back in Xref" or "Go Back with Xref"? We need more opinions. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 25 13:08:27 2021 Received: (at 38797) by debbugs.gnu.org; 25 Oct 2021 17:08:27 +0000 Received: from localhost ([127.0.0.1]:44161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf3SU-0002pS-TT for submit@debbugs.gnu.org; Mon, 25 Oct 2021 13:08:27 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:55837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf3SQ-0002on-UK for 38797@debbugs.gnu.org; Mon, 25 Oct 2021 13:08:23 -0400 Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 32C03E0003; Mon, 25 Oct 2021 17:08:14 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack Organization: LINKOV.NET References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <87ilxm27wz.fsf@mail.linkov.net> <87sfwqi7dd.fsf@mail.linkov.net> <4c25c196-ba72-b509-c5d7-f015c37009f8@yandex.ru> <877de1lfb2.fsf@mail.linkov.net> Date: Mon, 25 Oct 2021 20:07:52 +0300 In-Reply-To: (Dmitry Gutov's message of "Mon, 25 Oct 2021 18:18:09 +0300") Message-ID: <87a6ix2i4v.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38797 Cc: Mattias =?iso-8859-1?Q?Engdeg=E5rd?= , yyoncho , 38797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> It's a nice intermediate solution, but it would also be nice to be able to >>> quickly iterate across previous searches. No? >> This means adding another layer of complexity. Remember a mess >> of deciding how to switch next-error navigations from different searches? >> Switching multiple xref searches will have the same level of confusion. > > Unless we do want to be able to switch next-error navigation sources this > way? Maybe. > Alternatively, we could uniquify the Xref buffers in a more predictable way > (e.g. by using the caller command and the input string, somehow), and then > have commands xref-searches-back and xref-searches-format switch between > the resulting buffers. > >> BTW, shouldn't xref-go-back/forward support next-error-function? ;-) > > What kind of support? Not sure I understand, sorry. Using unique Xref buffers will allow switching to a unique Xref buffer and typing 'M-x next-error-select-buffer'. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 25 14:54:08 2021 Received: (at 38797) by debbugs.gnu.org; 25 Oct 2021 18:54:08 +0000 Received: from localhost ([127.0.0.1]:44287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf56l-0007dX-QR for submit@debbugs.gnu.org; Mon, 25 Oct 2021 14:54:08 -0400 Received: from mail72c50.megamailservers.eu ([91.136.10.82]:43146 helo=mail92c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf56j-0007dM-2P for 38797@debbugs.gnu.org; Mon, 25 Oct 2021 14:54:06 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1635188042; bh=JwTprQP0ruiHt7USVoczspQYEqzfIyZihrgLOWlm9IY=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Cx8EDDbWz0309EphzSO9GvgTDlEPrphfm2GGLMiokvtRblUJz7v6NO79M2XNTtVkt buRW6DcDrE2WV8GeKrceAToUyafrbD3LhRktRiFs0MqLGmSnf9Hyzau7xA7ngjneny lQwpR/9UkuS3+gc06ToH62sENG2zuZNiLWLrHq18= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 19PIrxTH014321; Mon, 25 Oct 2021 18:54:01 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87h7d5xcf6.fsf@mail.linkov.net> Date: Mon, 25 Oct 2021 20:53:59 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <50BA01F3-495E-4332-8941-78EF4CC47B9C@acm.org> References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> <87h7d5xcf6.fsf@mail.linkov.net> To: Juri Linkov X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F15.6176FD4A.000C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=ScmUytdu c=1 sm=1 tr=0 ts=6176fd4a a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=ucMQw-l_AAAA:8 a=3_pKvzvUnmgE8Z2J7q8A:9 a=CjuIK1q_8ugA:10 a=xkTruGkd22MpkFU079mG:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 25 okt. 2021 kl. 19.05 skrev Juri Linkov : > I took a look at your change, and noticed an asymmetry > between the names xref-pop-marker-stack and xref-go-forward. > Shouldn't the name xref-pop-marker-stack be obsoleted, > and replaced with a n [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 38797 Cc: 38797@debbugs.gnu.org, yyoncho , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 25 okt. 2021 kl. 19.05 skrev Juri Linkov : > I took a look at your change, and noticed an asymmetry > between the names xref-pop-marker-stack and xref-go-forward. > Shouldn't the name xref-pop-marker-stack be obsoleted, > and replaced with a new name xref-go-back? Yes, this was the intention. I have now done that; thanks for reminding = me! > Another question is that in the menu bar currently the order is > "Forward" and "Back". But more natural order would be > "Back" and "Forward". Oh, I didn't realise they had to be given in reverse order. Fixed, thank = you. > The menu contains the item "Back Definition". (BTW, why if the search = failed?) That appears to be a known imperfection in Xref -- I agree it shouldn't = be added if the search failed. > This menu item is too ambiguous. Renaming it to "Go Back" or "Go = Forward" > doesn't make the menu item clearer. Only adding a word "Xref" = somewhere > will disambiguate it. Maybe then "Go Back in Xref" or "Go Back with = Xref"? Maybe, but if we embrace the idea that there really only should be a = single back button in the application (which is what other IDEs = typically have), then there is no ambiguity. Until then we may need to = add "Xref" somehow, but where is the confusion, exactly? > We need more opinions. Only if they are well-reasoned! From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 25 15:38:30 2021 Received: (at 38797) by debbugs.gnu.org; 25 Oct 2021 19:38:31 +0000 Received: from localhost ([127.0.0.1]:44346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf5ni-0000KL-Md for submit@debbugs.gnu.org; Mon, 25 Oct 2021 15:38:30 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:42947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf5ng-0000K5-Kx for 38797@debbugs.gnu.org; Mon, 25 Oct 2021 15:38:28 -0400 Received: by mail-lf1-f41.google.com with SMTP id bi35so7290447lfb.9 for <38797@debbugs.gnu.org>; Mon, 25 Oct 2021 12:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Oxg4rApKjVnKRMkf4/3EIqqZlimuQKRN0z9qa8WeIjE=; b=CtKgmVYGxm0rfMSd/spPyoA6e0tV/xRZw4+J9o2jE5xw5EdZNTjJ/MpUjXra8qSQHv KjqRYy+nx66cgt6FU2ZZABLzJS0JNqLy9K06yaYdZ18hmHEF9NQLE1FoCbLtCTuJeZ+D WTdmlCJulvzw9TeqVO7/G1nb+UHkpos/ePuTNB0IgDVSl43IHaEfvC96B4bo0+t6BnUc yWcEGFavDq9lIQ8Q9n2V4+3XsHs+c2KIH93+OxfPF+QsMowrE5Qltd+D2Lpugh8EVh5B g4w0z5stZucvVgncYF1W3pdp2NeS8wnEAZAgpTI8G3COKE4ImO6FDNyuFzjnoS0dec1v A9Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Oxg4rApKjVnKRMkf4/3EIqqZlimuQKRN0z9qa8WeIjE=; b=oqO1USsjXyThFOk9yPfeSAsTdRR8w5p0Huu/+lQxzQgsZoneLHzD5Qd47Ir/Hd8B0D 1xULrQpVAUli97/nMI5tVyO85pi510rT04jYRZuLHbuxz4BtsA2+VFqyxGTWOkxjjwkv C2A96W9cRiF9rja/SFojex7C8UuCBF57W/gJh/s7eiuU65IQhEtb33MC39+w10BfFwyj XDhF13UnVPcRH0BMnMupHu+WzT+SXtDBGBEAfy4xg6ulCmjtCP2fzEm5dED5dMbkR02N oe5yU6giRx7zt4mjvxkSksnEwEuqgQHvi6/niN/fnmZfYUu8SMak8//RZjxeIKV7DkyO rinQ== X-Gm-Message-State: AOAM5324qONUzvTKM2FnGkEga3iw6OVASZeTOlPRpMmz39f3cgGEUMKG HYHHpFR1XSavFCyBzQia9mCcrsb3olg= X-Google-Smtp-Source: ABdhPJzj37hgS5miv1qvScHDB31xNmdT4veJ9hGn1JyB9xn/FFX9eEpNVds7hKOsJpdYY1oukZ5nng== X-Received: by 2002:a05:6512:443:: with SMTP id y3mr1425275lfk.112.1635190702396; Mon, 25 Oct 2021 12:38:22 -0700 (PDT) Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id g10sm1724264lfu.103.2021.10.25.12.38.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 12:38:21 -0700 (PDT) Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack To: Juri Linkov , =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> <87h7d5xcf6.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <53ebfec5-377f-24df-0acb-847b3891dc72@yandex.ru> Date: Mon, 25 Oct 2021 22:38:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87h7d5xcf6.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 38797 Cc: yyoncho , 38797@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 25.10.2021 20:05, Juri Linkov wrote: >> I favour (lightly) "Go Back" / "Go Forward" because they make sense in >> context with the other Xref operations in that separator-delimited group of >> entries in the menu, and because it's a wording often used for these >> operations elsewhere such as in web browsers and IDEs (though often it's >> just "Back" and "Forward"). >> >> "Xref {Back,Forward}" or "{Back,Forward} Xref" would also do and displays >> the link to Xref up front, but the English is decidedly less natural. > > With such a test case: > > 0. emacs -Q Seems like step 0.5 is missing: enable context-menu-mode. > 1. click mouse-3 on any word in *scratch*, and select from the context menu > "Find Definition". It should fail with the error > "No definitions found for: This". This is correct. > 2. now click mouse-3 at the end of *scratch*, not on a word. > > The menu contains the item "Back Definition". (BTW, why if the search failed?) > > This menu item is too ambiguous. Renaming it to "Go Back" or "Go Forward" > doesn't make the menu item clearer. Only adding a word "Xref" somewhere > will disambiguate it. Maybe then "Go Back in Xref" or "Go Back with Xref"? > We need more opinions. Go Back and Go Forward look okay to me. Not sure whether adding "Xref " would be an improvement: the Xref locations stack is an intended replacement for find-tag-marker-ring, which is supposedly used by all kinds of code. So the location to which we "Go Back" might as well have been tagged by a command which otherwise has to relation to Xref From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 25 17:29:12 2021 Received: (at 38797) by debbugs.gnu.org; 25 Oct 2021 21:29:12 +0000 Received: from localhost ([127.0.0.1]:44493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf7Wq-0003Tx-1x for submit@debbugs.gnu.org; Mon, 25 Oct 2021 17:29:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf7Wn-0003Tj-Tq for 38797@debbugs.gnu.org; Mon, 25 Oct 2021 17:29:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57568) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mf7Wh-0007LX-PE; Mon, 25 Oct 2021 17:29:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=0vBOmqZKGHMDlCFI+Es5avJnR30hv90dKT15/fGTACg=; b=EMnGyUFFozfghA1Ni8zj bws4/l1RYWG8jNUkRWaQVvrRfG8l46LgGYADQdo6gwgj2C7EtohkChFE3/dm4EoHRApwK9YcvYqf7 3Jks6weZzZwsxFmmoRd1JLZQpyffft5CFSfO/rIz22v90h8YwKHjUyxoV5I1R6ofz1zJcAfOrICG1 jhwx+OCcf4ft2yMW88w4Z9cP9U3JCMYlOhz4OLSJUgtO/kZ7n8ZCWecelJn1Mq2pc5rA9VZxfS9H8 d1bot/tqejDQeeAoSx1c4GiEqrhqYyV0t5cpn+64gTy0+obMV0BncOLMSpehxXg1+ESz6TnAoMGry ekHuKZygQZqgzw==; Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1mf7Wf-0000VP-J9; Mon, 25 Oct 2021 17:29:01 -0400 From: Glenn Morris To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> X-Spook: CISE War on Terrorism ARPA Geraldton BOP Department of X-Ran: 9N!5wb.o.=Q~MG*$>Jewctlez=U#"sB/pZ?wE;*w2TcO,"E`D[J9uRxsU?*x4Q/@+,yyUQ X-Hue: brightgreen X-Attribution: GM Date: Mon, 25 Oct 2021 17:29:01 -0400 In-Reply-To: ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Mon, 25 Oct 2021 17:49:52 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38797 Cc: Juri Linkov , 38797@debbugs.gnu.org, yyoncho , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Causes xref-elisp-test-find-defs-defvar-el to fail; ref eg https://hydra.nixos.org/build/156713513 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 26 04:06:55 2021 Received: (at 38797) by debbugs.gnu.org; 26 Oct 2021 08:06:55 +0000 Received: from localhost ([127.0.0.1]:45020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfHTz-0002sq-2Y for submit@debbugs.gnu.org; Tue, 26 Oct 2021 04:06:55 -0400 Received: from mail1443c50.megamailservers.eu ([91.136.14.43]:36530 helo=mail264c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfHTw-0002sc-Vu for 38797@debbugs.gnu.org; Tue, 26 Oct 2021 04:06:54 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1635235606; bh=++GOS6CwqYIBbd8Orxgvhn0AGvmmd/MCOJsfT7aqOZM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=WmQVJ96PTjvQt5KcyzYjIK0gnNvUBMlpDnrFKCJW/wj0k7L0qHFUFing2WG5nudwG V+jHll3/4kNUC9TjhiD/kicYmMYiW+zzlD3ws0lNm6Lm250Xw59BjWK86g6PKHkJD5 KlVK+Hxl8CHcRpAbPxeC2SID6or+GQ3P5aUOvfgo= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 19Q86hmi019900; Tue, 26 Oct 2021 08:06:45 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Tue, 26 Oct 2021 10:06:43 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> To: Glenn Morris X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F15.6177B716.002E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=bfII7MDB c=1 sm=1 tr=0 ts=6177b716 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=u8_WLvqW-Ow6M5rVt5sA:9 a=CjuIK1q_8ugA:10 a=nAHpo24mHLcA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 25 okt. 2021 kl. 23.29 skrev Glenn Morris : > Causes xref-elisp-test-find-defs-defvar-el to fail Fixed, thank you! Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 38797 Cc: Juri Linkov , 38797@debbugs.gnu.org, yyoncho , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 25 okt. 2021 kl. 23.29 skrev Glenn Morris : > Causes xref-elisp-test-find-defs-defvar-el to fail Fixed, thank you! From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 08 13:28:05 2021 Received: (at 38797) by debbugs.gnu.org; 8 Nov 2021 18:28:05 +0000 Received: from localhost ([127.0.0.1]:59439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mk9NF-0001qh-A8 for submit@debbugs.gnu.org; Mon, 08 Nov 2021 13:28:05 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:46281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mk9NC-0001qB-UN for 38797@debbugs.gnu.org; Mon, 08 Nov 2021 13:28:03 -0500 Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 9BB50240006; Mon, 8 Nov 2021 18:27:54 +0000 (UTC) From: Juri Linkov To: Mattias =?iso-8859-1?Q?Engdeg=E5rd?= Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack Organization: LINKOV.NET References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> Date: Mon, 08 Nov 2021 20:23:06 +0200 In-Reply-To: ("Mattias =?iso-8859-1?Q?Engdeg=E5rd=22's?= message of "Mon, 25 Oct 2021 17:49:52 +0200") Message-ID: <86fss6y0ad.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38797 Cc: 38797@debbugs.gnu.org, yyoncho , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain > I favour (lightly) "Go Back" / "Go Forward" because they make sense in > context with the other Xref operations in that separator-delimited group of > entries in the menu, and because it's a wording often used for these > operations elsewhere such as in web browsers and IDEs (though often it's > just "Back" and "Forward"). There are more votes for "Go Back" / "Go Forward", so I'll push two patches - one for emacs-28 (not to be merged to master), and another for master: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=go-back-emacs-28.patch diff --git a/lisp/progmodes/prog-mode.el b/lisp/progmodes/prog-mode.el index 3e1a915e32..4997c2746f 100644 --- a/lisp/progmodes/prog-mode.el +++ b/lisp/progmodes/prog-mode.el @@ -51,7 +51,7 @@ prog-context-menu (unless (xref-marker-stack-empty-p) (define-key-after menu [xref-pop] - '(menu-item "Back Definition" xref-pop-marker-stack + '(menu-item "Go Back" xref-pop-marker-stack :help "Back to the position of the last search") 'prog-separator)) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=go-back-master.patch diff --git a/lisp/progmodes/prog-mode.el b/lisp/progmodes/prog-mode.el index db350a5f70..30b6edf0d9 100644 --- a/lisp/progmodes/prog-mode.el +++ b/lisp/progmodes/prog-mode.el @@ -49,9 +49,15 @@ prog-context-menu (define-key-after menu [prog-separator] menu-bar-separator 'middle-separator) + (unless (xref-forward-history-empty-p) + (define-key-after menu [xref-forward] + '(menu-item "Go Forward" xref-go-forward + :help "Forward to the position gone Back from") + 'prog-separator)) + (unless (xref-marker-stack-empty-p) (define-key-after menu [xref-pop] - '(menu-item "Back Definition" xref-go-back + '(menu-item "Go Back" xref-go-back :help "Back to the position of the last search") 'prog-separator)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 09 03:30:53 2021 Received: (at 38797) by debbugs.gnu.org; 9 Nov 2021 08:30:53 +0000 Received: from localhost ([127.0.0.1]:60741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkMWr-0003vi-BY for submit@debbugs.gnu.org; Tue, 09 Nov 2021 03:30:53 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:43181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkMWp-0003vQ-Tx for 38797@debbugs.gnu.org; Tue, 09 Nov 2021 03:30:52 -0500 Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id C5B9B1BF213; Tue, 9 Nov 2021 08:30:43 +0000 (UTC) From: Juri Linkov To: Mattias =?iso-8859-1?Q?Engdeg=E5rd?= Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack Organization: LINKOV.NET References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> <86fss6y0ad.fsf@mail.linkov.net> Date: Tue, 09 Nov 2021 10:30:23 +0200 In-Reply-To: <86fss6y0ad.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 08 Nov 2021 20:23:06 +0200") Message-ID: <867ddhhgtc.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38797 Cc: 38797@debbugs.gnu.org, yyoncho , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> I favour (lightly) "Go Back" / "Go Forward" because they make sense in >> context with the other Xref operations in that separator-delimited group of >> entries in the menu, and because it's a wording often used for these >> operations elsewhere such as in web browsers and IDEs (though often it's >> just "Back" and "Forward"). > > There are more votes for "Go Back" / "Go Forward", so I'll push > two patches - one for emacs-28 (not to be merged to master), and > another for master: Now pushed both. Is this feature request is ready for closing? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 09 08:08:54 2021 Received: (at 38797) by debbugs.gnu.org; 9 Nov 2021 13:08:54 +0000 Received: from localhost ([127.0.0.1]:32915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkQru-0007eA-5y for submit@debbugs.gnu.org; Tue, 09 Nov 2021 08:08:54 -0500 Received: from mail1437c50.megamailservers.eu ([91.136.14.37]:39144 helo=mail263c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkQro-0007dp-Ic for 38797@debbugs.gnu.org; Tue, 09 Nov 2021 08:08:53 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1636463320; bh=ZfmTJhQYZ19qrZMT6Po+B0Jnqj/mNVMcaGxdzxC/3gU=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=oehjyoTSrvB7edCH4oLMIqUhuXH/wrICPpAI78YFerDqUypcTfYAT+OYB/n5A9h/Y IwFFMYIeq43lI1vzz7VdguQ9pphOk11TOjQi4RWw0F2bQwFWfoDzq7iTK3juwL3ySG XhJomEa1kpU85eBLS3D60FFJ6t/gYEDCJrRYNLzk= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail263c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 1A9D8bS5031323; Tue, 9 Nov 2021 13:08:39 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <867ddhhgtc.fsf@mail.linkov.net> Date: Tue, 9 Nov 2021 14:08:37 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <42C265B5-9B21-4657-AA8A-D92C9D2F2944@acm.org> References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> <86fss6y0ad.fsf@mail.linkov.net> <867ddhhgtc.fsf@mail.linkov.net> To: Juri Linkov X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F2A.618A72D8.000E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=TJom93pa c=1 sm=1 tr=0 ts=618a72d8 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=ucMQw-l_AAAA:8 a=2IHFWpg8GKORFRcNw4YA:9 a=CjuIK1q_8ugA:10 a=L42WZ21l2ekA:10 a=xkTruGkd22MpkFU079mG:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 9 nov. 2021 kl. 09.30 skrev Juri Linkov : > Now pushed both. Is this feature request is ready for closing? Thank you and yes, as far as I'm concerned. An unbounded number of improvements that can be made but we don't need to keep the bug open for that, do we? Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 38797 Cc: 38797@debbugs.gnu.org, yyoncho , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 9 nov. 2021 kl. 09.30 skrev Juri Linkov : > Now pushed both. Is this feature request is ready for closing? Thank you and yes, as far as I'm concerned. An unbounded number of = improvements that can be made but we don't need to keep the bug open for = that, do we? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 09 08:10:07 2021 Received: (at 38797-done) by debbugs.gnu.org; 9 Nov 2021 13:10:07 +0000 Received: from localhost ([127.0.0.1]:32919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkQt4-0007gU-Fg for submit@debbugs.gnu.org; Tue, 09 Nov 2021 08:10:07 -0500 Received: from mail-lj1-f182.google.com ([209.85.208.182]:37840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkQsv-0007fo-IB for 38797-done@debbugs.gnu.org; Tue, 09 Nov 2021 08:10:05 -0500 Received: by mail-lj1-f182.google.com with SMTP id m5so17872725ljp.4 for <38797-done@debbugs.gnu.org>; Tue, 09 Nov 2021 05:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MIFoB4CrKjEW/WLV0IwZyVmDBoIzNI2v4csTi3YX+zI=; b=LLRpbjEZ5ngn5Zym2eO9IbKmkQIM+on900h3rXsi0dC2563LdgclHA7Ziz7AeBzG0K xeOmjct/GoG9/QQUx+8KZDi1tM1rdxwv9ZJc/jJznb3+G/PkChf2ZB8rtPAnHxO5ej7j Q368UMcKEyv5K2HgUH/Hq+ZIXra6qqiFLQyNpebimITnAUJxOw1aS+nkDJ256IlW7Ozj 299nJjZWPubWn+fd2Tr2TpFfP3ZjRK9JRa6O7k45gt4RNjJhbqpP7Bn26vu5QgvHdRMa 8bu4FaddgpqIuMTbH/zrRY7tdWFyblw0cxHnxhfz5Wc6f4FPPpsg5T/DBYxgy/Mlu903 OqQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MIFoB4CrKjEW/WLV0IwZyVmDBoIzNI2v4csTi3YX+zI=; b=iCY8w/E7ewFXYrMYgVeQor//ECxOAMitBFo1UipeTthN4lKj2nDwkBUFqkkWNX3Gc9 a8XXg1Fboc/P0/4Do+9PEEOE+gRSWC8sPUibrIsi7fVJd7Gv8/KWacZbWBHRFr252Hib 2A9lBYV2+Y/1iW4bWJO1kGDTu4haTBobkJ1PWOUxirpjngUGZDDwrXVEQL+8476UpwhJ 9lATBRakgeqovGUeDFIGfwph+nwnZoofoTpSbfHbwv/vxmUPljsIeVwIEWPnO0M0VHUW 5B7k8uCOfAE1OVPajbcD+uJ9kLiKQnB8RitRGzVeCVWcYCbmCBsmZaz0mU/uGE6GUZNt eDcQ== X-Gm-Message-State: AOAM530YyBiTnotWAbuJSk9SGkzVAtpXgvJGyYabphZPchSYeEk/988E Tx6fByzQdVXt23ljUoFhX8cFqsU53VcvFQ== X-Google-Smtp-Source: ABdhPJxIm/wuAXNS+hlv/ITlosbkq1NmbUju+ogxcwnIXBpXEFI6LoTY1HFKlncoEMEaUDW5i3P9VQ== X-Received: by 2002:a05:651c:1583:: with SMTP id h3mr7543947ljq.98.1636463391616; Tue, 09 Nov 2021 05:09:51 -0800 (PST) Received: from [192.168.0.103] ([5.18.235.131]) by smtp.googlemail.com with ESMTPSA id y19sm2135728lfa.123.2021.11.09.05.09.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Nov 2021 05:09:50 -0800 (PST) Subject: Re: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= , Juri Linkov References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> <86fss6y0ad.fsf@mail.linkov.net> <867ddhhgtc.fsf@mail.linkov.net> <42C265B5-9B21-4657-AA8A-D92C9D2F2944@acm.org> From: Dmitry Gutov Message-ID: <84a38c32-3686-248f-64a4-7cd8ef3a8559@yandex.ru> Date: Tue, 9 Nov 2021 16:09:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <42C265B5-9B21-4657-AA8A-D92C9D2F2944@acm.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 38797-done Cc: 38797-done@debbugs.gnu.org, yyoncho X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 09.11.2021 16:08, Mattias EngdegÃ¥rd wrote: > 9 nov. 2021 kl. 09.30 skrev Juri Linkov: > >> Now pushed both. Is this feature request is ready for closing? > Thank you and yes, as far as I'm concerned. An unbounded number of improvements that can be made but we don't need to keep the bug open for that, do we? > > Looks good to me as well. Thank you both. Closing the bug. From unknown Fri Jun 13 10:55:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 08 Dec 2021 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator