From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 29 09:27:16 2019 Received: (at submit) by debbugs.gnu.org; 29 Dec 2019 14:27:16 +0000 Received: from localhost ([127.0.0.1]:59402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilZXH-0005DU-RJ for submit@debbugs.gnu.org; Sun, 29 Dec 2019 09:27:16 -0500 Received: from lists.gnu.org ([209.51.188.17]:52836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilZXG-0005DN-Je for submit@debbugs.gnu.org; Sun, 29 Dec 2019 09:27:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43777) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilZXF-0005ZR-6w for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 09:27:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=ALL_TRUSTED,BAYES_50 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ilZXE-0004kc-Sy; Sun, 29 Dec 2019 09:27:12 -0500 Received: from [176.228.60.248] (port=4452 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ilZXE-0008AD-AG; Sun, 29 Dec 2019 09:27:12 -0500 Date: Sun, 29 Dec 2019 16:27:15 +0200 Message-Id: <838smvnr5o.fsf@gnu.org> From: Eli Zaretskii To: bug-gnu-emacs@gnu.org, martin rudalics Subject: 27.0.60; Multiline mini-window fails to resize after clearing message X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) To reproduce from "emacs -Q": . Turn off global-eldoc-mode, which triggers redisplay and can hide this bug: M-x global-eldoc-mode RET . Set resize-mini-windows to t. . Type into *scratch*: (message "a\nb\nc") and press "C-x C-e" to evaluate the call to 'message'. This will show a 3-line message in the echo area, and the mini-window will resize to show all the 3 lines. . Press any key, for example C-b. This clears the echo area, but the mini-window is not resized back to a single line, although the value of resize-mini-windows is t. This is a regression, because in Emacs 26 this works as expected. The patch to fix this is below. It reverts a small part of commit 8e0ebb9, which inadvertently changed the logic in grow_mini_window. The problem in this case was that old_height + delta evaluated to zero, but instead of limiting the result to the equivalent of 1 line, the code did nothing. diff --git a/src/window.c b/src/window.c index c52a8ca285..1962e07f8d 100644 --- a/src/window.c +++ b/src/window.c @@ -5229,10 +5229,15 @@ grow_mini_window (struct window *w, int delta) { struct frame *f = XFRAME (w->frame); int old_height = window_body_height (w, true); + int min_height = FRAME_LINE_HEIGHT (f); eassert (MINI_WINDOW_P (w)); - if ((delta != 0) && (old_height + delta >= FRAME_LINE_HEIGHT (f))) + /* Never shrink mini-window to less than its minimum height. */ + if (old_height + delta < min_height) + delta = old_height > min_height ? min_height - old_height : 0; + + if (delta != 0) { Lisp_Object root = FRAME_ROOT_WINDOW (f); struct window *r = XWINDOW (root); In GNU Emacs 27.0.60 (build 15, i686-pc-mingw32) of 2019-12-29 built on HOME-C4E4A596F7 Repository revision: aa0c679f484347d20ab6f7c0f75f32f5e360cb89 Repository branch: emacs-27 Windowing system distributor 'Microsoft Corp.', version 5.1.2600 System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600) Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure -C --prefix=/d/usr --with-wide-int --with-modules --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3'' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2 HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP Important settings: value of $LANG: ENU locale-coding-system: cp1255 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 50621 11136) (symbols 48 7172 1) (strings 16 18826 2216) (string-bytes 1 531767) (vectors 16 9418) (vector-slots 8 126838 7876) (floats 8 21 333) (intervals 40 258 20) (buffers 888 11)) From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 29 13:33:57 2019 Received: (at submit) by debbugs.gnu.org; 29 Dec 2019 18:33:57 +0000 Received: from localhost ([127.0.0.1]:60215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ildO1-00070F-CE for submit@debbugs.gnu.org; Sun, 29 Dec 2019 13:33:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:39155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ildO0-000709-SK for submit@debbugs.gnu.org; Sun, 29 Dec 2019 13:33:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49155) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ildNz-0000Tv-Mn for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 13:33:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ildNy-0004BA-LB for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 13:33:55 -0500 Received: from mout.gmx.net ([212.227.17.21]:49251) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ildNy-00042M-AG; Sun, 29 Dec 2019 13:33:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1577644432; bh=fpMvQtpYA34Fb+CntFdZD8fAt2bKkx2ttSAqNKbS+vc=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=edZH8rTnOwWXlJSMZKPgbIRKqDgoCZWuEI5etGVyyy5zZ2erw+LtiEczhNAF+VcWA EgFGcdmi4J4c0AA/JIAacftlt+QIxizZ3ep9SSIvWOPcNBd/3HY4Esddcym0ctvXmM /IQvdX7Y8+XmmX47QUyDs5hIpaBIFw/jkrddw+Bw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([46.125.249.43]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MOiDX-1j7Hnr1ar1-00QB39; Sun, 29 Dec 2019 19:33:52 +0100 Subject: Re: 27.0.60; Multiline mini-window fails to resize after clearing message To: Eli Zaretskii , bug-gnu-emacs@gnu.org References: <838smvnr5o.fsf@gnu.org> From: martin rudalics Message-ID: Date: Sun, 29 Dec 2019 19:33:52 +0100 MIME-Version: 1.0 In-Reply-To: <838smvnr5o.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:hu6lih8ZvnU0kUZQFKaJ2URw4CkC+1WmGob2p1Up+yu6Y3bMuiP /YQjhzZyPdZKLn9vESmZTg5lazfzdFGDZYvybl4966B6WhQTJ545Jhv/untz2TMIErUlta5 7UvxfqjTI4V56BrNyW6p8KbXoWTLW/TptjEoC9zTNpZe2LA3TwM/Iku6ahQre8Nr6EU9mzW R03N0WO8sIw02F3T1Lgqw== X-UI-Out-Filterresults: notjunk:1;V03:K0:U6hRh1w2ytI=:XWpls4Avc0q8vMuC/4xx2O FZFqBfnMpGw5wHO8CPvwHO4DD26ATvCIemnGE5zFmY8k2nqRzpC80t2bZB9ANqQWfbMHCj7gS hYHgv+48Ypt8H4YLSEbkkg32T0yTFM/lz+objJHsE/g0aC3KyIQy6NFT3OG6rs0VDkcQ6Focg PqQqiiIK8UUYlOOrc2jT//FjleL9tihJh0y+lfl1OOi97DmBsatM4/KcOIDpx+0+JSSRrAd5U WvVvodEraollHOwRd0DgauTLAqeXFX+wOiv/exeWMunrakURBHsZ0YObrvPa4WtxtFOLNoDRi lf50Ysn7SnoqaZHYWgPAvgK9muBa/vBLhDUl4KoddrUZ8I2L44i6vTNO9meZ+ykJlQXolbHYZ bblpHQtSvaWEyqo0pdYqdByv+PnePZyBtQ/44jr/YqfaGd6JYAeY+f+52S/IqLvgqkjWcN2y7 DkMXDK+WloJHmxdDPS/qbLQxCHYHoQnQG1p8airVmu99ucxkarpzDqsKlSyiPec9mgAYKwHkG 4qDl19ZeaH1KHP+5SZo0ZMFr7FL0IxcJxT+u+J8gQO0AIDG0KheYGBYhMViDAPfuNdkNPswVP f1JdQuifDh8mOQO2hTMHab01VmCN6UJIpdiwVxHKhP0JjeEN9COx0fOBj0TjN/hS1ZmWKTQSw eS4eGwdzDFAxlBD820lpwBOaLfLSjsDaTkRLAMuj9h6TwknwJc6lbsEQ9EFBFjqXtaE0JXaIV I/Vws7ZoS0YIv8jWHQEGg3w1pM3AIh8b5B8//Le/EehTpASqsayoyJuTchXIknU1hXAeHj39w pJnCEqCTjOr8c1KXT952lP5D4ZdjA7eQq6NJnfuiNz2Zp9EVdZg8XkLTN2CvmZs/IuKE7pqDk KmKqYvDWe2hk9joEkzWnztJWtaR4AKqpc1fxfQtQ4qD3Zx99t/cNL/zS1LpTQzxIJESIRkl4/ dHs3zlI8SEuPuO2AKFNISIZe2YemUXwcWpLUqQtzpv7YJey9WXfYF0dpKk+gN/k29G6eiUVhj N7XLugpzqHcBt7W0MAK+GUCScODh7kBWoZXNxSuUv0kEwlX/mAOILurR7F1xn83slReRUKTuq 8AUKJEE0Eor9kKZTifcChsB9AR7ma1vNetex3040SonOTeWtCfF7qLFJgEQceA8FRzEJBNhlr Lu1q0PejQv9/nqv/ZXVKH4l+WfFgMPMywrizSYEQNnGn0DGPvewplWTojaQLGUaawP1qUUZAp i3VDnOV8XaBMm1TDaUI9lPhTAOvs2I1aMeJzrdUbNJp6f3eu723CrX35YO5Y= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.21 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) > This is a regression, because in Emacs 26 this works as expected. > > The patch to fix this is below. It reverts a small part of commit > 8e0ebb9, which inadvertently changed the logic in grow_mini_window. > The problem in this case was that old_height + delta evaluated to > zero, but instead of limiting the result to the equivalent of 1 line, > the code did nothing. It apparently never entered my mind that WINDOW_BOX_TEXT_HEIGHT might mean something different from the height of that window's buffer text. Shameful. Thanks for the fix, martin From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 30 10:56:09 2019 Received: (at 38791-done) by debbugs.gnu.org; 30 Dec 2019 15:56:09 +0000 Received: from localhost ([127.0.0.1]:33257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilxOq-0003jo-Rv for submit@debbugs.gnu.org; Mon, 30 Dec 2019 10:56:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilxOo-0003jN-W2 for 38791-done@debbugs.gnu.org; Mon, 30 Dec 2019 10:56:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ilxOj-0002Hd-Gp; Mon, 30 Dec 2019 10:56:01 -0500 Received: from [176.228.60.248] (port=2017 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ilxOh-0007zh-Tp; Mon, 30 Dec 2019 10:56:01 -0500 Date: Mon, 30 Dec 2019 17:56:07 +0200 Message-Id: <83blrpn6y0.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: (message from martin rudalics on Sun, 29 Dec 2019 19:33:52 +0100) Subject: Re: 27.0.60; Multiline mini-window fails to resize after clearing message References: <838smvnr5o.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38791-done Cc: 38791-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: martin rudalics > Date: Sun, 29 Dec 2019 19:33:52 +0100 > > > This is a regression, because in Emacs 26 this works as expected. > > > > The patch to fix this is below. It reverts a small part of commit > > 8e0ebb9, which inadvertently changed the logic in grow_mini_window. > > The problem in this case was that old_height + delta evaluated to > > zero, but instead of limiting the result to the equivalent of 1 line, > > the code did nothing. > > It apparently never entered my mind that WINDOW_BOX_TEXT_HEIGHT might > mean something different from the height of that window's buffer text. > Shameful. Well, the name is ambiguous. I installed the fix, and I'm closing the bug report. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 30 12:54:24 2019 Received: (at 38791-done) by debbugs.gnu.org; 30 Dec 2019 17:54:24 +0000 Received: from localhost ([127.0.0.1]:33334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilzFI-0006po-7v for submit@debbugs.gnu.org; Mon, 30 Dec 2019 12:54:24 -0500 Received: from mout.gmx.net ([212.227.17.22]:38005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilzFG-0006pb-1N for 38791-done@debbugs.gnu.org; Mon, 30 Dec 2019 12:54:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1577728456; bh=1JmK88FwMLLkPBS5NCIDbfkQZY/A66hnFY64M7u9cWs=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=VzY9xXaxNWOxprxR6N6p9utSK50jmVztdZs1Q4h2hCxrs8zCApOx88OKnkYNpK4ih ky7pwG5WhAVfjdK2umZbW70Ey8hEYDQRr8akB9goiDyRCDyUMhHv0DH/ImQHPg5Ud9 lTJ4NiCRfPWXYwpWyPm7VXBu1RtQWNCytQ0hhup8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([46.125.249.24]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N2V0B-1jkNMt0BiR-013rSH; Mon, 30 Dec 2019 18:54:16 +0100 Subject: Re: 27.0.60; Multiline mini-window fails to resize after clearing message To: Eli Zaretskii References: <838smvnr5o.fsf@gnu.org> <83blrpn6y0.fsf@gnu.org> From: martin rudalics Message-ID: Date: Mon, 30 Dec 2019 18:54:14 +0100 MIME-Version: 1.0 In-Reply-To: <83blrpn6y0.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:/yDYvPbsCA33vYYjGXp0KZCBW9B+CqRuYJWUAeOvg4waTfW9uhh VdQTB1KiYoJ6chBkU49h5NIS4WGudJRgyYIYn0nFXsebzwuhLuEcrGlKmFSgUWcYXeYXe0u OMoV1WafVDIiCmlxs72URth/vhl6Jl1imZ7kEf8QHkx3XuPFt9DRqJSznusKyVhvzv/tLjW 8LnErC9kgALeeEbHB1PLA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:IROsSHqLYyQ=:Jk68hBHD+RsKlW0048dK6X DQI4WI2i7OiTrg40B/D2OzQ2sbcoe6C6OZbQI/5aVWGTcgpAivzAdSxCNwVNNqUwc1lefT5DN J+wOZ6U3FETSVRSMGktVHfRME56T/8MbCIiSmIIlMrMCGCp56fbUM9VQsrPhXsnQ1toHJoXDH YxoFjzuE9I1XQRuet90/Xyj5GsZJcdIR+dXFisw4rf1B2Q40x3dgg3Z95DlgEqwGfIbjw4T8P gCegaiD78P7kLqJahR49j1tIsOIJ9RW6tNfBoCoMJAIEXskDB+rZ3m9brGYezUS4fHpPs0oYC TPdiC647gKQeefe8iokUm4IC+JZg6WUjib0P3lC2LyVnYgZYjW2WUlAgdxJ1vndlu9a6G+/kv wyldfCLcxISfLegtZ2T7Cj//vke/LkiQBno6Y1hkj+4xmnqy1Dzs9jRX9G/d0uYqJq5UHs2Qe WGuJHSRvuKnOAGBGpf9C2KTWMM8qFAFWTutvtyp+I6FNZrDTolr8sDY+/MHG2ZPfJ33YoGQHL oLKQkxZYTb5+/6gqhX4VRhzZBUldbUASobAX2g47OUcjZfM+jTFE3gW2oVzBgQMs2MyIli2R6 IgWwvzaS0J5umFDaQIjAexl3ju7uxDEgWLs4pjXjmqYpy4veC6V+Bb/6t35v6cJkmR1CN9URu tzS7AvGr2EATHvaWxcUYk7wmBzo8hNu5ZPYdZvkvdxEOOIPY6wMGAuoTzzyERPY0qrnmdiZP8 J8zO3cpwLvrmxPJ9AmkWEEm8j38LLRfev1jWEF8NQYaYYaelcVEzPvbemkHZ4r+LzAukrETMh ABiRzGEJnYjGhAf73KWX/2uU/qS6KYIf5b/b00tPwywneYk7xJCILtWQSWMCsifg0bMnmUJZa ilZBiBj2w0ti+SKj52EjdVprETGRxsqbumfClkqK4X05MDf7HXYbglqHvdnZtUBVkBuQBQe3W bzjX2cIFvYRHg1WUyDcIX/POyMMIMDCvQ8dqgTB6F/fCVPijo9XAo7u6LxHyGkEHqXjm8zQ10 WcjZL6+oo9mtDuu2kLl3yKoAvPlh+Zh0h4BBtlztZv2o/B3/LLyV93RHbDD6iIdQa6AtISIjK cRc05yhaKBZrFeI1azg8ivk/mb73cprSAjBIRnn/NmRMW8wnW11QdLRuq9+NbMCiiKQhrCA8c kLEnDtoO9FPIZVEFMR1AZM4PyXYVvUNCKF6Dt1pyI3rVzpOSy0+qH3Xvt9d9gGIbt2RnFkDxf mFhqeDG/Cj1vBmR4xibTABbMSTKSVOe83eZTugg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38791-done Cc: 38791-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> It apparently never entered my mind that WINDOW_BOX_TEXT_HEIGHT might >> mean something different from the height of that window's buffer text. >> Shameful. > > Well, the name is ambiguous. I'd eventually want to keep only one function among WINDOW_BOX_TEXT_HEIGHT, window_box_height and window_body_height. But before that we'd have to sort out which one to keep among CURRENT_{MODE,HEADER,TAB}_LINE_HEIGHT, WINDOW_{MODE,HEADER,TAB}_LINE_HEIGHT and the calculations done in window_box_height. Together with window_wants_{mode,header,tab}_line I'm afraid that we have some circular definition here which is also confirmed by the fact that using CURRENT_{MODE,HEADER,TAB}_LINE_HEIGHT within other macros is usually frowned upon by gcc complaining about missing sequence points due to the ((W)->{mode,header,tab}_line_height assignments. Parts of that dilemma also show up in miscalculating the heights of the vertical scroll bar window as sketched in the thread on Bug#38181. In either case the bug you fixed here was all mine when I started to squeeze the earlier shrink/grow call sequence into a single grow call. > I installed the fix, and I'm closing the bug report. Thanks again, martin From unknown Tue Jun 17 01:50:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 28 Jan 2020 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator