From unknown Sat Jun 21 03:13:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#38767 <38767@debbugs.gnu.org> To: bug#38767 <38767@debbugs.gnu.org> Subject: Status: [PATCH] Add Xournal++ Reply-To: bug#38767 <38767@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:13:52 +0000 retitle 38767 [PATCH] Add Xournal++ reassign 38767 guix-patches submitter 38767 Nicolas Goaziou severity 38767 normal tag 38767 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 27 18:27:52 2019 Received: (at submit) by debbugs.gnu.org; 27 Dec 2019 23:27:52 +0000 Received: from localhost ([127.0.0.1]:57869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikz1M-0007VL-1V for submit@debbugs.gnu.org; Fri, 27 Dec 2019 18:27:52 -0500 Received: from lists.gnu.org ([209.51.188.17]:60973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikz1K-0007VE-Vn for submit@debbugs.gnu.org; Fri, 27 Dec 2019 18:27:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34798) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikz1J-0000ru-CC for guix-patches@gnu.org; Fri, 27 Dec 2019 18:27:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ikz1H-0001hX-Ew for guix-patches@gnu.org; Fri, 27 Dec 2019 18:27:48 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:49203) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ikz1H-0001gr-4Z for guix-patches@gnu.org; Fri, 27 Dec 2019 18:27:47 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id AB66AC0006 for ; Fri, 27 Dec 2019 23:27:44 +0000 (UTC) From: Nicolas Goaziou To: guix-patches@gnu.org Subject: [PATCH] Add Xournal++ Date: Sat, 28 Dec 2019 00:27:43 +0100 Message-ID: <87woah1h8w.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.198 X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Hello, The following patch add Xournal++. There are a few caveats: - it requires applying my patch at bug#38765; - it cannot find Lua even though "lua" is included in the inputs. I left a "fixme" about it; - it crashes when trying to insert an image. Feedback welcome. Regards, -- Nicolas Goaziou --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-Add-xournalpp.patch Content-Transfer-Encoding: quoted-printable Content-Description: Add Xournal++ >From 83ff0917427a13739ec2c65add1f1361c8406ff4 Mon Sep 17 00:00:00 2001 From: Nicolas Goaziou Date: Fri, 27 Dec 2019 22:43:25 +0100 Subject: [PATCH] gnu: Add xournalpp. * gnu/packages/pdf.scm (xournalpp): New variable. --- gnu/packages/pdf.scm | 83 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 83 insertions(+) diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm index ebe0168ff2..799e977a36 100644 --- a/gnu/packages/pdf.scm +++ b/gnu/packages/pdf.scm @@ -17,6 +17,7 @@ ;;; Copyright =C2=A9 2019 Alex Griffin ;;; Copyright =C2=A9 2019 Ben Sturmfels ;;; Copyright =C2=A9 2019 Hartmut Goebel +;;; Copyright =C2=A9 2019 Nicolas Goaziou ;;; ;;; This file is part of GNU Guix. ;;; @@ -45,6 +46,7 @@ #:use-module (guix build-system python) #:use-module (guix build-system trivial) #:use-module (gnu packages) + #:use-module (gnu packages audio) #:use-module (gnu packages autotools) #:use-module (gnu packages backup) #:use-module (gnu packages base) @@ -55,6 +57,7 @@ #:use-module (gnu packages djvu) #:use-module (gnu packages fontutils) #:use-module (gnu packages game-development) + #:use-module (gnu packages gcc) #:use-module (gnu packages gettext) #:use-module (gnu packages ghostscript) #:use-module (gnu packages gl) @@ -74,6 +77,7 @@ #:use-module (gnu packages perl) #:use-module (gnu packages photo) #:use-module (gnu packages pkg-config) + #:use-module (gnu packages pulseaudio) #:use-module (gnu packages python) #:use-module (gnu packages python-check) #:use-module (gnu packages python-web) @@ -82,8 +86,10 @@ #:use-module (gnu packages sdl) #:use-module (gnu packages sphinx) #:use-module (gnu packages sqlite) + #:use-module (gnu packages tex) #:use-module (gnu packages tls) #:use-module (gnu packages xdisorg) + #:use-module (gnu packages xml) #:use-module (gnu packages xorg) #:use-module (srfi srfi-1)) =20 @@ -752,6 +758,83 @@ program capable of converting PDF into other formats.") using a stylus.") (license license:gpl2+))) =20 +(define-public xournalpp + (package + (name "xournalpp") + (version "1.0.16") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/xournalpp/xournalpp.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1bdmxxkcqpjvkckizmrz2839b4yspw4xv69bqkrrgkcyvxsr804w")))) + (build-system cmake-build-system) + (arguments + `(#:configure-flags (list "-DENABLE_CPPUNIT=3DON") ;enable tests + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'fix-permissions-on-po-files + ;; Make sure 'msgmerge' can modify the PO files. + (lambda _ + (for-each (lambda (po) (chmod po #o666)) + (find-files "." "\\.po$")) + #t))))) + (native-inputs + `(("cppunit" ,cppunit) + ("gcc" ,gcc-8) ;requires gcc 8+ + ("gettext" ,gettext-minimal) + ("pkg-config" ,pkg-config))) + (inputs + `(("alsa-lib" ,alsa-lib) + ("glib" ,glib) + ("gtk+" ,gtk+) + ("libsndfile" ,libsndfile) + ("libxml2" ,libxml2) + ("libzip" ,libzip) + ;; FIXME: It cannot find the Lua library. + ("lua" ,lua) + ("poppler" ,poppler) + ("portaudio" ,portaudio) + ("texlive-bin" ,texlive-bin))) + (home-page "https://github.com/xournalpp/xournalpp") + (synopsis "handwriting notetaking software with PDF annotation support= ") + (description "Xournal++ is a hand note taking software written in +C++ with the target of flexibility, functionality and speed. Stroke +recognizer and other parts are based on Xournal code. + +Xournal++ features: + +@itemize +@item Support for Pen pressure, e.g., Wacom Tablet +@item Support for annotating PDFs +@item Fill shape functionality +@item PDF Export (with and without paper style) +@item PNG Export (with and without transparent background) +@item Allow to map different tools / colors etc. to stylus buttons / +mouse buttons +@item Sidebar with Page Previews with advanced page sorting, PDF +Bookmarks and Layers (can be individually hidden, editing layer can be +selected) +@item enhanced support for image insertion +@item Eraser with multiple configurations +@item LaTeX support +@item bug reporting, autosave, and auto backup tools +@item Customizeable toolbar, with multiple configurations, e.g., to +optimize toolbar for portrait / landscape +@item Page Template definitions +@item Shape drawing (line, arrow, circle, rectangle) +@item Shape resizing and rotation +@item Rotation snapping every 45 degrees +@item Rect snapping to grid +@item Audio recording and playback alongside with handwritten notes +@item Multi Language Support, Like English, German, Italian... +@item Plugins using LUA Scripting +@end itemize") + (license license:gpl2+))) + (define-public python-reportlab (package (name "python-reportlab") --=20 2.24.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 14:59:50 2020 Received: (at 38767) by debbugs.gnu.org; 8 Feb 2020 19:59:50 +0000 Received: from localhost ([127.0.0.1]:51860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0WGb-0005V8-QK for submit@debbugs.gnu.org; Sat, 08 Feb 2020 14:59:50 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:38723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0WGZ-0005Uy-4Y for 38767@debbugs.gnu.org; Sat, 08 Feb 2020 14:59:48 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 3C10EC0004 for <38767@debbugs.gnu.org>; Sat, 8 Feb 2020 19:59:44 +0000 (UTC) From: Nicolas Goaziou To: 38767@debbugs.gnu.org Subject: Re: [bug#38767] [PATCH] Add Xournal++ References: <87woah1h8w.fsf@nicolasgoaziou.fr> Date: Sat, 08 Feb 2020 20:59:33 +0100 In-Reply-To: <87woah1h8w.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Sat, 28 Dec 2019 00:27:43 +0100") Message-ID: <8736bkzw7u.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38767 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Nicolas Goaziou writes: > The following patch add Xournal++. There are a few caveats: > > - it requires applying my patch at bug#38765; > > - it cannot find Lua even though "lua" is included in the inputs. > I left a "fixme" about it; > > - it crashes when trying to insert an image. I fixed the crash and updated xournalpp to 1.0.17. The Lua part is still open. I attach the new patch for further feedback. Thank you. --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-Add-xournalpp.patch Content-Transfer-Encoding: quoted-printable >From 2bf2def9d291492e393512bf463b9f3cd4bf20e4 Mon Sep 17 00:00:00 2001 From: Nicolas Goaziou Date: Fri, 27 Dec 2019 22:43:25 +0100 Subject: [PATCH] gnu: Add xournalpp. * gnu/packages/pdf.scm (xournalpp): New variable. --- gnu/packages/pdf.scm | 94 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 94 insertions(+) diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm index 368b2ce69e..6bb0402a59 100644 --- a/gnu/packages/pdf.scm +++ b/gnu/packages/pdf.scm @@ -17,6 +17,7 @@ ;;; Copyright =C2=A9 2019 Alex Griffin ;;; Copyright =C2=A9 2019 Ben Sturmfels ;;; Copyright =C2=A9 2019 Hartmut Goebel +;;; Copyright =C2=A9 2020 Nicolas Goaziou ;;; ;;; This file is part of GNU Guix. ;;; @@ -45,6 +46,7 @@ #:use-module (guix build-system python) #:use-module (guix build-system trivial) #:use-module (gnu packages) + #:use-module (gnu packages audio) #:use-module (gnu packages autotools) #:use-module (gnu packages backup) #:use-module (gnu packages base) @@ -55,6 +57,7 @@ #:use-module (gnu packages djvu) #:use-module (gnu packages fontutils) #:use-module (gnu packages game-development) + #:use-module (gnu packages gcc) #:use-module (gnu packages gettext) #:use-module (gnu packages ghostscript) #:use-module (gnu packages gl) @@ -74,6 +77,7 @@ #:use-module (gnu packages perl) #:use-module (gnu packages photo) #:use-module (gnu packages pkg-config) + #:use-module (gnu packages pulseaudio) #:use-module (gnu packages python) #:use-module (gnu packages python-check) #:use-module (gnu packages python-web) @@ -82,8 +86,10 @@ #:use-module (gnu packages sdl) #:use-module (gnu packages sphinx) #:use-module (gnu packages sqlite) + #:use-module (gnu packages tex) #:use-module (gnu packages tls) #:use-module (gnu packages xdisorg) + #:use-module (gnu packages xml) #:use-module (gnu packages xorg) #:use-module (srfi srfi-1)) =20 @@ -752,6 +758,94 @@ program capable of converting PDF into other formats.") using a stylus.") (license license:gpl2+))) =20 +(define-public xournalpp + (package + (name "xournalpp") + (version "1.0.17") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/xournalpp/xournalpp.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0xw2mcgnm4sa9hrhfgp669lfypw97drxjmz5w8i5whaprpvmkxzw")))) + (build-system cmake-build-system) + (arguments + `(#:configure-flags (list "-DENABLE_CPPUNIT=3DON") ;enable tests + #:imported-modules ((guix build glib-or-gtk-build-system) + ,@%cmake-build-system-modules) + #:modules (((guix build glib-or-gtk-build-system) #:prefix glib-or-= gtk:) + (guix build cmake-build-system) + (guix build utils)) + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'fix-permissions-on-po-files + (lambda _ + ;; Always generate translations. A recent upstream patch + ;; disabled it. + (substitute* "po/CMakeLists.txt" + (("gettext_create_translations \\(\"\\$\\{potfile\\}\"\\)") + "gettext_create_translations (\"${potfile}\" ALL)")) + ;; Make sure 'msgmerge' can modify the PO files. + (for-each (lambda (po) (chmod po #o666)) + (find-files "." "\\.po$")) + #t)) + (add-after 'install 'glib-or-gtk-wrap + (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))))) + (native-inputs + `(("cppunit" ,cppunit) + ("gcc" ,gcc-8) ;requires gcc 8+ + ("gettext" ,gettext-minimal) + ("pkg-config" ,pkg-config))) + (inputs + `(("alsa-lib" ,alsa-lib) + ("glib" ,glib) + ("gtk+" ,gtk+) + ("libsndfile" ,libsndfile) + ("libxml2" ,libxml2) + ("libzip" ,libzip) + ("lua" ,lua) ;FIXME: It cannot find the Lua libr= ary. + ("poppler" ,poppler) + ("portaudio" ,portaudio) + ("texlive-bin" ,texlive-bin))) + (home-page "https://github.com/xournalpp/xournalpp") + (synopsis "handwriting notetaking software with PDF annotation support= ") + (description "Xournal++ is a hand note taking software written in +C++ with the target of flexibility, functionality and speed. Stroke +recognizer and other parts are based on Xournal code. + +Xournal++ features: + +@itemize +@item Support for Pen pressure, e.g., Wacom Tablet +@item Support for annotating PDFs +@item Fill shape functionality +@item PDF Export (with and without paper style) +@item PNG Export (with and without transparent background) +@item Allow to map different tools / colors etc. to stylus buttons / +mouse buttons +@item Sidebar with Page Previews with advanced page sorting, PDF +Bookmarks and Layers (can be individually hidden, editing layer can be +selected) +@item enhanced support for image insertion +@item Eraser with multiple configurations +@item LaTeX support +@item bug reporting, autosave, and auto backup tools +@item Customizeable toolbar, with multiple configurations, e.g., to +optimize toolbar for portrait / landscape +@item Page Template definitions +@item Shape drawing (line, arrow, circle, rectangle) +@item Shape resizing and rotation +@item Rotation snapping every 45 degrees +@item Rect snapping to grid +@item Audio recording and playback alongside with handwritten notes +@item Multi Language Support, Like English, German, Italian... +@item Plugins using LUA Scripting +@end itemize") + (license license:gpl2+))) + (define-public python-reportlab (package (name "python-reportlab") --=20 2.25.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 09 04:52:36 2020 Received: (at 38767) by debbugs.gnu.org; 9 Feb 2020 09:52:36 +0000 Received: from localhost ([127.0.0.1]:52080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0jGW-0001vO-Je for submit@debbugs.gnu.org; Sun, 09 Feb 2020 04:52:36 -0500 Received: from mira.cbaines.net ([212.71.252.8]:48814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0jGU-0001vG-PR for 38767@debbugs.gnu.org; Sun, 09 Feb 2020 04:52:35 -0500 Received: from localhost (unknown [46.237.162.119]) by mira.cbaines.net (Postfix) with ESMTPSA id ADE3416700; Sun, 9 Feb 2020 09:52:33 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 6dba76b6; Sun, 9 Feb 2020 09:52:30 +0000 (UTC) References: <87woah1h8w.fsf@nicolasgoaziou.fr> <8736bkzw7u.fsf@nicolasgoaziou.fr> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: mail@nicolasgoaziou.fr Subject: Re: [bug#38767] [PATCH] Add Xournal++ In-reply-to: <8736bkzw7u.fsf@nicolasgoaziou.fr> Date: Sun, 09 Feb 2020 09:52:28 +0000 Message-ID: <87ftfk140z.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38767 Cc: 38767@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Nicolas Goaziou writes: > Nicolas Goaziou writes: > >> The following patch add Xournal++. There are a few caveats: >> >> - it requires applying my patch at bug#38765; >> >> - it cannot find Lua even though "lua" is included in the inputs. >> I left a "fixme" about it; >> >> - it crashes when trying to insert an image. > > I fixed the crash and updated xournalpp to 1.0.17. The Lua part is still > open. > > I attach the new patch for further feedback. Maybe start the synopsis with a capital letter (so "Handwriting notetaking ..."), but apart from that this looks good to me :) Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4/1lxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfzXw//TzdRIY7chUDZ88y9HyDfXycyHZt0T4R5MV0UYB8eJ0Kw/ERXfW2aqnOJ du1ON+Fmg/cw+wabj17vzoyYjxvnREDeBISTpfDjQlj3w/Zl/3VEKkUTrC+X6ubI m2G2b62vsYySPN6ie8roNZwwiWOmOXBs6FKoP+LSXGxMJChFnKY7J2Mx3dqZJDjV To2rg++dyP1CVGYtSK/Lnf+vLEo2nNfgWR+qXGoE7iDkC25CKFCyg9t6PaFss9Yt xbCnQ5HS1i5mhxUrs1plbwfTFqp5mCiV9KNQgTEWlOcA/JupjxUlWwev81+JDmD0 rJJCIjqzniIV5CGKva8wnsaQMhXJ+X27kofBM9YuhQpIRmSiT3InP9CB6zR7qtS1 Q0Z2oB/S5jhryozvlM3wv+/V6sMa3AdrxiI7ZWfUr/fLNS/fQIgk0E/xINaLaFlh 5qgsMrL7EXurvXlQz3NEMT8MV19G3Uae/NppIAB9E1n2vVncl3KMuJBy6eGuq51b GhKp7YaZEEWCFgsWUpAQTFcgs3niolFIkd1p+XiXTd2GN3M8cgnrIUs36JkdYUBW 1qaOr7nTfC0xTfJHg3KuWWS6uym9oVxkAINa1frBHCxTsridD8xZADYUSFUfh7WL qsbizR7PKUUOWC28GISprYgwDoqtCDc/D4sURbQti6Dmm7jVxRE= =Yo/a -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 09 11:37:45 2020 Received: (at 38767-done) by debbugs.gnu.org; 9 Feb 2020 16:37:45 +0000 Received: from localhost ([127.0.0.1]:53137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0pab-0007OO-Aj for submit@debbugs.gnu.org; Sun, 09 Feb 2020 11:37:45 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:1539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0paZ-0007OE-PY for 38767-done@debbugs.gnu.org; Sun, 09 Feb 2020 11:37:44 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id E85D0240004; Sun, 9 Feb 2020 16:37:41 +0000 (UTC) From: Nicolas Goaziou To: Christopher Baines Subject: Re: [bug#38767] [PATCH] Add Xournal++ References: <87woah1h8w.fsf@nicolasgoaziou.fr> <8736bkzw7u.fsf@nicolasgoaziou.fr> <87ftfk140z.fsf@cbaines.net> Date: Sun, 09 Feb 2020 17:37:41 +0100 In-Reply-To: <87ftfk140z.fsf@cbaines.net> (Christopher Baines's message of "Sun, 09 Feb 2020 09:52:28 +0000") Message-ID: <87lfpb1zu2.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38767-done Cc: 38767-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Christopher Baines writes: > Maybe start the synopsis with a capital letter (so "Handwriting > notetaking ..."), but apart from that this looks good to me :) Indeed, fixed. Applied as ebbd30ff399e1194dafbf7f1c58dd07272f18624. Thank you for the feedback. Regards, -- Nicolas Goaziou From unknown Sat Jun 21 03:13:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 09 Mar 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator