Subject: Re: bug#38755: icecat retains reference on clang

From: Efraim Flashner <[email-masked]>
Date: Sun, 29 Dec 2019 09:16:50 +0200

On Sun, Dec 29, 2019 at 12:05:28AM +0100, Julien Lepiller wrote:
> Le 28 décembre 2019 20:47:40 GMT+01:00, Efraim Flashner <[email-masked]> a écrit :
> >On Sat, Dec 28, 2019 at 01:25:50AM +0100, Ludovic Courtès wrote:
> >> Hi,
> >> 
> >> Ricardo Wurmus <[email-masked]> skribis:
> >> 
> >> > This should do the trick:
> >> >
> >> > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> >> > index d5d9839e1a..e9458037a5 100644
> >> > --- a/gnu/packages/gnuzilla.scm
> >> > +++ b/gnu/packages/gnuzilla.scm
> >> > @@ -1023,7 +1023,11 @@ from forcing GEXP-PROMISE."
> >> >                 (format #t "configure flags: ~s~%" flags)
> >> >                 (apply invoke bash
> >> >                        (string-append srcdir "/configure")
> >> > -                      flags))))
> >> > +                      flags)
> >> > +               ;; Remove references to store items
> >> > +               (substitute* "toolkit/content/buildconfig.html"
> >> > +                 (("/gnu/store") ""))
> >> 
> >> This should not be a literal “/gnu/store”, though.  Perhaps we should
> >> just use ‘remove-store-references’ instead of ‘substitute*’?
> >> 
> >
> >This way we still get a listing of exactly which store items were used
> >without needing to refer to them exactly.
> 
> It shouldn't be literaly /gnu/store, because one could use a different store path. Can we access the store path from a phase code?

Good point. Perhaps 'remove-store-references' would just be best.

-- 
Efraim Flashner   <[email-masked]>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted