GNU bug report logs - #38754
[PATCH 0/2] Speed up the derivation linter.

Previous Next

Package: guix-patches;

Reported by: Christopher Baines <mail <at> cbaines.net>

Date: Thu, 26 Dec 2019 17:34:01 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#38754: closed ([PATCH 0/2] Speed up the derivation linter.)
Date: Tue, 24 Mar 2020 19:51:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 24 Mar 2020 19:50:07 +0000
with message-id <87eeth5y8g.fsf <at> cbaines.net>
and subject line Re: [bug#38754] [PATCH 2/2] scripts: lint: Set the %link-checker-store-connection parameter.
has caused the debbugs.gnu.org bug report #38754,
regarding [PATCH 0/2] Speed up the derivation linter.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
38754: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38754
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Speed up the derivation linter.
Date: Thu, 26 Dec 2019 17:33:07 +0000
[Message part 3 (text/plain, inline)]
These patches speed up the derivation linter by reducing the number of
times a connection to the guix-daemon is established. In testing on my
computer, the time to lint all guix packages with the derivation linter
drops from around 6 minutes to around 3 minutes.


Christopher Baines (2):
  guix: lint: Add an optional parameter for a store connection.
  scripts: lint: Set the %link-checker-store-connection parameter.

 guix/lint.scm         | 42 ++++++++++++++++++++++++++----------------
 guix/scripts/lint.scm | 22 +++++++++++++---------
 2 files changed, 39 insertions(+), 25 deletions(-)
[signature.asc (application/pgp-signature, inline)]
[Message part 5 (message/rfc822, inline)]
From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38754-done <at> debbugs.gnu.org
Subject: Re: [bug#38754] [PATCH 2/2] scripts: lint: Set the
 %link-checker-store-connection parameter.
Date: Tue, 24 Mar 2020 19:50:07 +0000
[Message part 6 (text/plain, inline)]
Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> I've finally got around to looking at this again. I've sent some new
>> patches which add a field to the <lint-checker> record, and adjust the
>> running of lint checkers as well as the derivation checker to use a
>> single store connection.
>>
>> Let me know what you think?
>
> LGTM, thank you!

Great, I've pushed this to master now as
57e12aad6dfc2d12567164144dd15161e66f32d5.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 5 years and 53 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.