From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 23 10:11:10 2019 Received: (at submit) by debbugs.gnu.org; 23 Dec 2019 15:11:10 +0000 Received: from localhost ([127.0.0.1]:51571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijPMS-00024J-R2 for submit@debbugs.gnu.org; Mon, 23 Dec 2019 10:11:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:51969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijJRV-0005hq-4e for submit@debbugs.gnu.org; Mon, 23 Dec 2019 03:51:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47431) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijJRT-0003L0-CO for guix-patches@gnu.org; Mon, 23 Dec 2019 03:51:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ijJRQ-0005VF-Qu for guix-patches@gnu.org; Mon, 23 Dec 2019 03:51:55 -0500 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:53151) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ijJRQ-0005Po-HC for guix-patches@gnu.org; Mon, 23 Dec 2019 03:51:52 -0500 Received: by mail-wm1-x344.google.com with SMTP id p9so15111540wmc.2 for ; Mon, 23 Dec 2019 00:51:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZvDwRwj/5UKJaxSVQfwYSTryJdbwglNRhaYAO9+a+Mw=; b=Qp48TqM8vTplKk2/+Gs1LH/ZRkRFDQ6EXBoczb6ZJ7fYW7GhoMU91DfK6KX9vff/7M vTT6t8xZzkN5hN4/Lz5Bhh5wCpgvqFSuWdl1HMglUZQpVc9TI5YtYT/v/8MN+9+ptkGM YbmuDy9DUG7KAP4Uo23XLwcKdHo+UZM6cUkOfYKlJ6SuYDbWJbhVHe51Sf0GrWDFwLTO cHKPTUUx297L+B3066MW4/EEkIwGdzFIAoh5ttoWzyLflokyZxk7/hedfIEJfKAWqS8n 8c3anWPMmaUSl5ui6NgqBvjQ7Xaf7AJ8vcNUcTDNhHjH82024OEYdwAjGeUHQrJtmuGg AQyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZvDwRwj/5UKJaxSVQfwYSTryJdbwglNRhaYAO9+a+Mw=; b=B/qvFHVxluwsBoLDH+ViQXPMpN58LHkOhT71tQ/Orp3zstCj0l0Yw/jxYipi4Q+WRd hsjB3ZRYQsvh5UpwRMuD0kGYx7b6tY7QY85e0Zh/rPZ84V5BUd2oGH+GbS1DdES7WTea /pegmPsFrobP6Xc/Vj/HcZo7tSzMnG4PEoWbi/R7OU5m4iDNl4462lYXpDz3ro+8mcvE UvgHItGHTMb6jMICC21QkqsH+O+ZdFFx3oar+QFIkP1CWUVWIaw8/F6AgLprFqqPpFgA VFAAePaf/v7z3RSG5Zqw/moMb/+PI3Wio+cMik0JhlPgrByfeEDfjIH2KaRJ3WNhEkNb dfng== X-Gm-Message-State: APjAAAXiLgY5U0xSqRrb2VLKJHmx0BwW4GMkHCaW2t5PbTvQMd1t8U/g ZmyI2l5YLHPAjwaEyMjoMki+rY3+/cqhaQ== X-Google-Smtp-Source: APXvYqykDKtAsA6OGiVQts8QDNT1hsO8SrcELzUcpKLECDyxW0y3ebfM36B/bRHlDLhQJOnSF5+Cvw== X-Received: by 2002:a05:600c:2c7:: with SMTP id 7mr28784450wmn.87.1577091110780; Mon, 23 Dec 2019 00:51:50 -0800 (PST) Received: from localhost.localdomain ([86.107.75.45]) by smtp.gmail.com with ESMTPSA id g2sm19171292wrw.76.2019.12.23.00.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Dec 2019 00:51:50 -0800 (PST) From: Alexandru-Sergiu Marton X-Google-Original-From: Alexandru-Sergiu Marton To: guix-patches@gnu.org Subject: [PATCH] gnu: Add i3-gaps Date: Mon, 23 Dec 2019 10:51:57 +0200 Message-Id: <20191223085157.26468-1-brown121407@member.fsf.org> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 X-Spam-Score: 3.5 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/wm.scm (i3-gaps): New variable. --- gnu/packages/wm.scm | 75 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm index 6c1919be56..904e2a3975 100644 --- a/gnu/packages/wm.scm +++ b/gnu/packages/wm.scm @@ -30,6 +30,7 @@ ;;; Copyright © 2019 Evan Straw ;;; [...] Content analysis details: (3.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: chiru.no] 2.6 RCVD_IN_SBL RBL: Received via a relay in Spamhaus SBL [86.107.75.45 listed in zen.spamhaus.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (brown121407[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (brown121407[at]gmail.com) -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 23 Dec 2019 10:11:07 -0500 Cc: Alexandru-Sergiu Marton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) * gnu/packages/wm.scm (i3-gaps): New variable. --- gnu/packages/wm.scm | 75 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm index 6c1919be56..904e2a3975 100644 --- a/gnu/packages/wm.scm +++ b/gnu/packages/wm.scm @@ -30,6 +30,7 @@ ;;; Copyright © 2019 Evan Straw ;;; Copyright © 2019 Brett Gilio ;;; Copyright © 2019 Noodles! +;;; Copyright © 2019 Alexandru-Sergiu Marton ;;; ;;; This file is part of GNU Guix. ;;; @@ -327,6 +328,80 @@ i3 primarily targets advanced users. Windows are managed manually and organised inside containers, which can be split vertically or horizontally, and optionally resized. +i3 uses a plain-text configuration file, and can be extended and controlled from +many programming languages.") + (license license:bsd-3))) + +(define-public i3-gaps + (package + (name "i3-gaps") + (version "4.17.1") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/Airblader/i3/releases/download/" + version "/i3-" version ".tar.bz2")) + (sha256 + (base32 + "0gqcr6s53dk3f2y9h6cna00rnwnh4yymk96li7lbym3d84cxjzrs")))) + (build-system gnu-build-system) + (arguments + `(#:configure-flags + ;; The build system tries to build in a separate directory, but that + ;; seems to be unnecessary. + (list "--disable-builddir") + + ;; The test suite requires the unpackaged Xephyr X server. + #:tests? #f + #:phases + (modify-phases %standard-phases + (add-after 'install 'patch-session-file + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (i3 (string-append out "/bin/i3")) + (i3-with-shmlog (string-append out "/bin/i3-with-shmlog"))) + (substitute* (string-append out "/share/xsessions/i3.desktop") + (("Exec=i3") (string-append "Exec=" i3))) + (substitute* (string-append out "/share/xsessions/i3-with-shmlog.desktop") + (("Exec=i3-with-shmlog") (string-append "Exec=" i3-with-shmlog))) + #t)))))) + (inputs + `(("libxcb" ,libxcb) + ("xcb-util" ,xcb-util) + ("xcb-util-cursor" ,xcb-util-cursor) + ("xcb-util-keysyms" ,xcb-util-keysyms) + ("xcb-util-wm" ,xcb-util-wm) + ("xcb-util-xrm" ,xcb-util-xrm) + ("libxkbcommon" ,libxkbcommon) + ("libev" ,libev) + ("libyajl" ,libyajl) + ("asciidoc" ,asciidoc) + ("xmlto" ,xmlto) + ("perl-pod-simple" ,perl-pod-simple) + ("libx11" ,libx11) + ("pcre" ,pcre) + ("startup-notification" ,startup-notification) + ("pango" ,pango) + ("cairo" ,cairo))) + (native-inputs + `(("which" ,which) + ("perl" ,perl) + ("pkg-config" ,pkg-config) + ;; For building the documentation. + ("libxml2" ,libxml2) + ("docbook-xsl" ,docbook-xsl))) + (home-page "https://github.com/Airblader/i3") + (synopsis "Tiling window manager with gaps") + (description "i3-gaps is a fork of i3wm, a tiling window manager for X11. +It is kept up to date with upstream, adding a few additional features such +as gaps between windows. + +i3 is a tiling X11 window manager that dynamically manages +tiled, stacked, and tabbed window layouts. + +i3 primarily targets advanced users. Windows are managed manually and organised +inside containers, which can be split vertically or horizontally, and optionally +resized. + i3 uses a plain-text configuration file, and can be extended and controlled from many programming languages.") (license license:bsd-3))) -- 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 23 21:19:39 2019 Received: (at 38721-done) by debbugs.gnu.org; 24 Dec 2019 02:19:39 +0000 Received: from localhost ([127.0.0.1]:51872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijZnO-0003FV-QS for submit@debbugs.gnu.org; Mon, 23 Dec 2019 21:19:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijZnM-0003FI-CA for 38721-done@debbugs.gnu.org; Mon, 23 Dec 2019 21:19:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ijZnH-0006hC-4m; Mon, 23 Dec 2019 21:19:31 -0500 Received: from [2605:6000:1a0d:6320::6a8] (port=36944 helo=oryx) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ijZnD-0002RP-Op; Mon, 23 Dec 2019 21:19:30 -0500 From: Brett Gilio To: Alexandru-Sergiu Marton Subject: Re: [bug#38721] [PATCH] gnu: Add i3-gaps References: <20191223085157.26468-1-brown121407@member.fsf.org> Date: Mon, 23 Dec 2019 20:19:33 -0600 In-Reply-To: <20191223085157.26468-1-brown121407@member.fsf.org> (Alexandru-Sergiu Marton's message of "Mon, 23 Dec 2019 10:51:57 +0200") Message-ID: <875zi6jwi2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38721-done Cc: Alexandru-Sergiu Marton , 38721-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Alexandru-Sergiu Marton writes: > * gnu/packages/wm.scm (i3-gaps): New variable. > --- > gnu/packages/wm.scm | 75 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 75 insertions(+) > > diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm > index 6c1919be56..904e2a3975 100644 > --- a/gnu/packages/wm.scm > +++ b/gnu/packages/wm.scm > @@ -30,6 +30,7 @@ > ;;; Copyright =C2=A9 2019 Evan Straw > ;;; Copyright =C2=A9 2019 Brett Gilio > ;;; Copyright =C2=A9 2019 Noodles! > +;;; Copyright =C2=A9 2019 Alexandru-Sergiu Marton > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -327,6 +328,80 @@ i3 primarily targets advanced users. Windows are ma= naged manually and organised > inside containers, which can be split vertically or horizontally, and op= tionally > resized. >=20=20 > +i3 uses a plain-text configuration file, and can be extended and control= led from > +many programming languages.") > + (license license:bsd-3))) > + > +(define-public i3-gaps > + (package > + (name "i3-gaps") > + (version "4.17.1") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/Airblader/i3/relea= ses/download/" > + version "/i3-" version ".tar.bz2")) > + (sha256 > + (base32 > + "0gqcr6s53dk3f2y9h6cna00rnwnh4yymk96li7lbym3d84cxjzrs"))= )) > + (build-system gnu-build-system) > + (arguments > + `(#:configure-flags > + ;; The build system tries to build in a separate directory, but t= hat > + ;; seems to be unnecessary. > + (list "--disable-builddir") > + > + ;; The test suite requires the unpackaged Xephyr X server. > + #:tests? #f > + #:phases > + (modify-phases %standard-phases > + (add-after 'install 'patch-session-file > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (i3 (string-append out "/bin/i3")) > + (i3-with-shmlog (string-append out "/bin/i3-with-shm= log"))) > + (substitute* (string-append out "/share/xsessions/i3.desk= top") > + (("Exec=3Di3") (string-append "Exec=3D" i3))) > + (substitute* (string-append out "/share/xsessions/i3-with= -shmlog.desktop") > + (("Exec=3Di3-with-shmlog") (string-append "Exec=3D" i3-= with-shmlog))) > + #t)))))) > + (inputs > + `(("libxcb" ,libxcb) > + ("xcb-util" ,xcb-util) > + ("xcb-util-cursor" ,xcb-util-cursor) > + ("xcb-util-keysyms" ,xcb-util-keysyms) > + ("xcb-util-wm" ,xcb-util-wm) > + ("xcb-util-xrm" ,xcb-util-xrm) > + ("libxkbcommon" ,libxkbcommon) > + ("libev" ,libev) > + ("libyajl" ,libyajl) > + ("asciidoc" ,asciidoc) > + ("xmlto" ,xmlto) > + ("perl-pod-simple" ,perl-pod-simple) > + ("libx11" ,libx11) > + ("pcre" ,pcre) > + ("startup-notification" ,startup-notification) > + ("pango" ,pango) > + ("cairo" ,cairo))) > + (native-inputs > + `(("which" ,which) > + ("perl" ,perl) > + ("pkg-config" ,pkg-config) > + ;; For building the documentation. > + ("libxml2" ,libxml2) > + ("docbook-xsl" ,docbook-xsl))) > + (home-page "https://github.com/Airblader/i3") > + (synopsis "Tiling window manager with gaps") > + (description "i3-gaps is a fork of i3wm, a tiling window manager for= X11. > +It is kept up to date with upstream, adding a few additional features su= ch > +as gaps between windows. > + > +i3 is a tiling X11 window manager that dynamically manages > +tiled, stacked, and tabbed window layouts. > + > +i3 primarily targets advanced users. Windows are managed manually and o= rganised > +inside containers, which can be split vertically or horizontally, and op= tionally > +resized. > + > i3 uses a plain-text configuration file, and can be extended and control= led from > many programming languages.") > (license license:bsd-3))) Hi, Alexandru-Sergiu Marton. Thank you for your patch. By the looks of it, this is your first patch submission to GNU Guix! Thank you. I want to offer you some kind advice. You may not be familiar with our inheritance mechanism. Since i3-gaps is really just a derivative form of core i3, we can actually just inherit the package parameters, arguments, inputs, etc. modifying only what we need to. In other-words, your definition can be /massively/ reduced as follows: --8<---------------cut here---------------start------------->8--- (define-public i3-gaps (package (inherit i3-wm) (name "i3-gaps") (version "4.17.1") (source (origin (method url-fetch) (uri (string-append "https://github.com/Airblader/i3/releases/downlo= ad/" version "/i3-" version ".tar.bz2")) (sha256 (base32 "0iazv2i2rgmakzh95pgj6iapyzn7bdpcbcd35a79mhlml4ry33q= y")))) (build-system gnu-build-system) (home-page "https://github.com/Airblader/i3") (synopsis "Tiling window manager with gaps") (description "i3-gaps is a fork of i3wm, a tiling window manager for X11. It is kept up to date with upstream, adding a few additional features such as gaps between windows. i3 is a tiling X11 window manager that dynamically manages tiled, stacked, and tabbed window layouts. i3 primarily targets advanced users. Windows are managed manually and organised inside containers, which can be split vertically or horizontally, and optionally resized. i3 uses a plain-text configuration file, and can be extended and controlled from many programming languages.") (license license:bsd-3))) --8<---------------cut here---------------end--------------->8--- I went ahead and pushed this to master with you as the author, and me as a co-author. I used your email address for the git config. Again, welcome! We are happy to have you around. 88c9408070280db51d1a0e604b9ec77f1611ab3c. Closing. --=20 Brett M. Gilio GNU Guix, Contributor | GNU Project, Webmaster [DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE] From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 03:15:32 2019 Received: (at 38721) by debbugs.gnu.org; 25 Dec 2019 08:15:32 +0000 Received: from localhost ([127.0.0.1]:53256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik1pL-0006SL-SM for submit@debbugs.gnu.org; Wed, 25 Dec 2019 03:15:32 -0500 Received: from mail-vk1-f194.google.com ([209.85.221.194]:41190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik1pK-0006S2-5I for 38721@debbugs.gnu.org; Wed, 25 Dec 2019 03:15:30 -0500 Received: by mail-vk1-f194.google.com with SMTP id p191so5550934vkf.8 for <38721@debbugs.gnu.org>; Wed, 25 Dec 2019 00:15:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=9qEscjqccUdE/KiOm5iRMnRx96VtuyF2M5t0i5X0vrM=; b=KEemxPvRukYyqUFxkCqLnzY8mUPqu/GI78BsIf8hqmfA2b9jSyRHJkIpXPitQsUml8 qRspNF7ws3AE75SALHI1rCbW9Sxa3F1/SeOEDrYe/Ag1suiip3lN0kEK7mxSj6qr+KJN YLrVsy2NXimCrEGKLM9M6582+s1mWtfLVRBufkm4Legnzi+1Daw18TlB7Jh8571QAd8H yZAXPbfuOI51Bo+MFiGbSU3Py1obuBhUCTsEAIvEvDOBdmyDHnkTJhKMn0Erf51T87Cs bXrnwGSnxSMvVopENXnwEx6tU0fovXAF1pqiHkLf9UAFhWuLCE4ewFFIfqmMAjo6CvaN RD8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=9qEscjqccUdE/KiOm5iRMnRx96VtuyF2M5t0i5X0vrM=; b=iwWeZhRfR3i8Tr9OMhh2764Lh2pRtGV2zihimjDg3K3paEhBX1+OwxojTAwaRubauP uAOKBwns+ULzKytlEWeyoFP9j1+a4Z54qmh9cZhx4ac5nIoiN/72AW3BBc1mQrlxBFV9 psPYw50TKJ9roCK798hesPsZAc3z103OeiEDNNq5O+gdTICdJa+ku4CYE58eF+UCBuLa vKKKm3mb1b9G9dla2V3XCq0ji+CN1PrNk7brF8tZPRYcrAAPAXvvsYsfoJmJ1sxaUF1k 2PBkR1hZc+k+neomPgz+xmpwLG9FnJkBIVHQsF5HlR0cHAl3S2nj3NAjPmhmjmM/+eBR Uvmw== X-Gm-Message-State: APjAAAXf3xNF7RO17/jUApGcRwvVI0Ze2ZGNjfJtul84FqhCFpTzsi7+ qLvQRcrX2fxw4XqxQ7jSuqAGKG0ZECpMtlnKrt77KC0G X-Google-Smtp-Source: APXvYqwoUWy2YHz3pByBcJ3dHscro2KYhW6ZY0jj6krXu0oR33mQMYijGfCOsxVKpRaYUupmXSVnuCBJK19hJ0fKRH0= X-Received: by 2002:ac5:c844:: with SMTP id g4mr24200710vkm.25.1577261723770; Wed, 25 Dec 2019 00:15:23 -0800 (PST) MIME-Version: 1.0 From: Sergiu Marton Date: Wed, 25 Dec 2019 08:15:32 +0000 Message-ID: Subject: Re: [bug#38721] [PATCH] gnu: Add i3-gaps To: 38721@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 38721 Cc: brettg@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) After it got merged into master with the inheritance modification, I installed it over the one I had installed from my original script and it seemed to work fine. But I think that's just because I didn't reboot to reload the i3 executable. Now that I shutdown and opened my machine again, i3-gaps specific commands don't work. To test this, write `i3-msg gaps` in a shell. If it does NOT work, it will output something like: brown@121407 ~$ i3-msg gaps ERROR: Your command: gaps ERROR: ^^^^ ERROR: Expected one of these tokens: However, it seems that gaps work if I remove the package, install it from the original package definition (without Brett's (inherit i3-wm)) and reboot. The following output means that i3-gaps has been correctly installed: brown@121407 ~$ i3-msg gaps ERROR: Your command: gaps ERROR: ERROR: Expected one of these tokens: 'inner', 'outer', 'horizontal', 'vertical', 'top', 'right', 'bottom', 'left' This is strange. I still don't know enough about the packaging API to troubleshoot this all just by having a quick look at i3-gaps' definition. I'll try to investigate this issue but I encourage someone more knowledgeable than me too look into this too. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 03:26:53 2019 Received: (at 38721) by debbugs.gnu.org; 25 Dec 2019 08:26:53 +0000 Received: from localhost ([127.0.0.1]:53260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik20J-0006jh-VH for submit@debbugs.gnu.org; Wed, 25 Dec 2019 03:26:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik20I-0006jS-4b for 38721@debbugs.gnu.org; Wed, 25 Dec 2019 03:26:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ik20C-0002XE-WB; Wed, 25 Dec 2019 03:26:45 -0500 Received: from [2605:6000:1a0d:6320:5c19:147:5a43:e823] (port=40714 helo=email.faircode.eu) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ik20B-0007BP-VV; Wed, 25 Dec 2019 03:26:44 -0500 Date: Wed, 25 Dec 2019 08:26:39 +0000 (UTC) From: Brett Gilio To: Sergiu Marton Message-ID: <75440f2b-aeae-4ee3-b2f6-35529af83124@localhost> In-Reply-To: References: <20191223085157.26468-1-brown121407@member.fsf.org> Subject: Re: [bug#38721] [PATCH] gnu: Add i3-gaps MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Correlation-ID: <75440f2b-aeae-4ee3-b2f6-35529af83124@localhost> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38721 Cc: 38721@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dec 25, 2019 2:16:09 AM Sergiu Marton : > After it got merged into master with the inheritance modification, I > installed it over the one I had installed from my original script and > it seemed to work fine. But I think that's just because I didn't > reboot to reload the i3 executable. > > Now that I shutdown and opened my machine again, i3-gaps specific > commands don't work. To test this, write `i3-msg gaps` in a shell. If > it does NOT work, it will output something like: > > brown@121407 ~$ i3-msg gaps > ERROR: Your command: gaps > ERROR: ^^^^ > ERROR: Expected one of these tokens: > represent valid commands> > > However, it seems that gaps work if I remove the package, install it > from the original package definition (without Brett's (inherit i3-wm)) > and reboot. The following output means that i3-gaps has been correctly > installed: > > brown@121407 ~$ i3-msg gaps > ERROR: Your command: gaps > ERROR: > ERROR: Expected one of these tokens: 'inner', 'outer', 'horizontal', > 'vertical', 'top', 'right', 'bottom', 'left' > > This is strange. I still don't know enough about the packaging API to > troubleshoot this all just by having a quick look at i3-gaps' > definition. I'll try to investigate this issue but I encourage someone > more knowledgeable than me too look into this too. > Hi Sergiu. Since this is closed and an issue for adding a new package, and your issue is about the new package will you open a new bug report at bug-guix@gnu.org? You can basically reuse your statement and link to this closed issue . Thanks! -- Brett M. Gilio GNU Guix, Contributor | GNU Project, Webmaster [DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE] < brettg@gnu.org [mailto:brettg@gnu.org] > < brettg@posteo.net [mailto:brettg@posteo.net] > From unknown Wed Jun 25 00:27:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Jan 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator