From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 22 16:40:15 2019 Received: (at submit) by debbugs.gnu.org; 22 Dec 2019 21:40:16 +0000 Received: from localhost ([127.0.0.1]:50331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ij8xT-0003xm-KG for submit@debbugs.gnu.org; Sun, 22 Dec 2019 16:40:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:57277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ij8xR-0003xe-EI for submit@debbugs.gnu.org; Sun, 22 Dec 2019 16:40:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46312) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ij8xQ-0002gJ-0g for guix-patches@gnu.org; Sun, 22 Dec 2019 16:40:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ij8xO-0003uu-NE for guix-patches@gnu.org; Sun, 22 Dec 2019 16:40:11 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:45094) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ij8xO-0003eb-GF; Sun, 22 Dec 2019 16:40:10 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 47gwr724vCz1qqkQ; Sun, 22 Dec 2019 22:40:07 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 47gwr718h6z1yH07; Sun, 22 Dec 2019 22:40:07 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id p_3jqWleuNlQ; Sun, 22 Dec 2019 22:40:06 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-188-174-48-16.dynamic.mnet-online.de [188.174.48.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Sun, 22 Dec 2019 22:40:06 +0100 (CET) Received: from thisbe.fritz.box (unknown [192.168.110.24]) by hermia.goebel-consult.de (Postfix) with ESMTP id 908D26017A; Sun, 22 Dec 2019 22:41:22 +0100 (CET) From: Hartmut Goebel To: guix-patches@gnu.org Subject: [PATCH] build-system: qt: Actually use qt-build-system, not cmake-build-system. Date: Sun, 22 Dec 2019 22:40:03 +0100 Message-Id: <20191222214003.7352-1-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.18.0.9 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: ludo@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) When the qt-build-system was created, based on the cmake-build-system, some references to cmake have been missed to be changed. * guix/build-system/qt.scm (qt-build, qt-cross-build)[modules]: Use qt-build-system, not cmake-build-system. [builder]: Call qt-build, not cmake-build. --- guix/build-system/qt.scm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/guix/build-system/qt.scm b/guix/build-system/qt.scm index b776845377..67fdfa1230 100644 --- a/guix/build-system/qt.scm +++ b/guix/build-system/qt.scm @@ -126,14 +126,14 @@ (qt-wrap-excluded-outputs ''()) (system (%current-system)) (imported-modules %qt-build-system-modules) - (modules '((guix build cmake-build-system) + (modules '((guix build qt-build-system) (guix build utils)))) "Build SOURCE using CMAKE, and with INPUTS. This assumes that SOURCE provides a 'CMakeLists.txt' file as its build system." (define builder `(begin (use-modules ,@modules) - (cmake-build #:source ,(match (assoc-ref inputs "source") + (qt-build #:source ,(match (assoc-ref inputs "source") (((? derivation? source)) (derivation->output-path source)) ((source) @@ -208,7 +208,7 @@ provides a 'CMakeLists.txt' file as its build system.= " (system (%current-system)) (build (nix-system->gnu-triplet system)) (imported-modules %qt-build-system-modules) - (modules '((guix build cmake-build-system) + (modules '((guix build qt-build-system) (guix build utils)))) "Cross-build NAME using CMAKE for TARGET, where TARGET is a GNU triple= t and with INPUTS. This assumes that SOURCE provides a 'CMakeLists.txt' file = as its @@ -237,7 +237,7 @@ build system." `(,name . ,path))) target-drvs)) =20 - (cmake-build #:source ,(match (assoc-ref native-drvs "source") + (qt-build #:source ,(match (assoc-ref native-drvs "source") (((? derivation? source)) (derivation->output-path source)) ((source) --=20 2.21.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 23 08:31:12 2019 Received: (at 38711) by debbugs.gnu.org; 23 Dec 2019 13:31:12 +0000 Received: from localhost ([127.0.0.1]:50640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijNnk-00060i-E8 for submit@debbugs.gnu.org; Mon, 23 Dec 2019 08:31:12 -0500 Received: from flashner.co.il ([178.62.234.194]:55262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijNni-00060W-AQ for 38711@debbugs.gnu.org; Mon, 23 Dec 2019 08:31:11 -0500 Received: from localhost (unknown [141.226.13.108]) by flashner.co.il (Postfix) with ESMTPSA id 73B2C4018C; Mon, 23 Dec 2019 13:31:04 +0000 (UTC) Date: Mon, 23 Dec 2019 15:30:33 +0200 From: Efraim Flashner To: Hartmut Goebel Subject: Re: [bug#38711] [PATCH] build-system: qt: Actually use qt-build-system, not cmake-build-system. Message-ID: <20191223133033.GQ1115@E5400> References: <20191222214003.7352-1-h.goebel@crazy-compilers.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZgGN478A9hzzvyZc" Content-Disposition: inline In-Reply-To: <20191222214003.7352-1-h.goebel@crazy-compilers.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38711 Cc: 38711@debbugs.gnu.org, ludo@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --ZgGN478A9hzzvyZc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 22, 2019 at 10:40:03PM +0100, Hartmut Goebel wrote: > When the qt-build-system was created, based on the cmake-build-system, > some references to cmake have been missed to be changed. This would explain some of the problems we've run into with, say, mumble. If applying this means we can reverse a7a91c01c98499c8a1e44fadea1b8f70e91fc16f and still have the binaries wrapped then I say go for it. >=20 > * guix/build-system/qt.scm (qt-build, qt-cross-build)[modules]: > Use qt-build-system, not cmake-build-system. [builder]: Call qt-build, > not cmake-build. > --- > guix/build-system/qt.scm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/guix/build-system/qt.scm b/guix/build-system/qt.scm > index b776845377..67fdfa1230 100644 > --- a/guix/build-system/qt.scm > +++ b/guix/build-system/qt.scm > @@ -126,14 +126,14 @@ > (qt-wrap-excluded-outputs ''()) > (system (%current-system)) > (imported-modules %qt-build-system-modules) > - (modules '((guix build cmake-build-system) > + (modules '((guix build qt-build-system) > (guix build utils)))) > "Build SOURCE using CMAKE, and with INPUTS. This assumes that SOURCE > provides a 'CMakeLists.txt' file as its build system." > (define builder > `(begin > (use-modules ,@modules) > - (cmake-build #:source ,(match (assoc-ref inputs "source") > + (qt-build #:source ,(match (assoc-ref inputs "source") Don't forget to re-indent the following lines > (((? derivation? source)) > (derivation->output-path source)) > ((source) > @@ -208,7 +208,7 @@ provides a 'CMakeLists.txt' file as its build system." > (system (%current-system)) > (build (nix-system->gnu-triplet system)) > (imported-modules %qt-build-system-modules) > - (modules '((guix build cmake-build-system) > + (modules '((guix build qt-build-system) > (guix build utils)))) > "Cross-build NAME using CMAKE for TARGET, where TARGET is a GNU triple= t and > with INPUTS. This assumes that SOURCE provides a 'CMakeLists.txt' file = as its > @@ -237,7 +237,7 @@ build system." > `(,name . ,path))) > target-drvs)) > =20 > - (cmake-build #:source ,(match (assoc-ref native-drvs "source") > + (qt-build #:source ,(match (assoc-ref native-drvs "source") And here too. > (((? derivation? source)) > (derivation->output-path source)) > ((source) > --=20 > 2.21.1 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --ZgGN478A9hzzvyZc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl4AwXYACgkQQarn3Mo9 g1F9SA//YqCIhZhPRjVvku1AtiEOIKbxU29gz4/DrLqgJV8xxGFGuWbZyX7cy6e3 8IJiNINV11QiG0nyQzy4dNN3efSjp9HZzYjmY7WeKyEN11/6UmkpPSejdgnaGKpP u1Lc3sPTdt8DtxDBPZ9WuNaL95cFanL7TFHglSdXfZ0BVvNjJw8o48dPFtSDqhpU dwenUCMZN+gTEgwSmjgR6P+JROc/Bi5of2Y6sT1qwX3+OqxW7hGHK986u0kk0uqp LlZZvgLHYygwb5MZS5eJWuXJWUxkt6b+E2nZtshGrqJghT7mgQy1kP2fhj8bUa/K dxOBinqEVrpqV4/rFLtPJiiBoF7rF4Sf1w45C+3PsXIgVSFnIT4jlqSY7Rp25Qmn PrdsxEoLE3B/1G3cpG1/jmCfWQDfE2L1uIId/rVn+lpZzCpBAn4YzxtaZhgbnM/I xBrTc9lk4kG7ahnssgb/sw2IlZkGBZGFlcMtBgujRFzKwOQ6kIuRS+us246LAPGZ ObqjmqqWLv1q5aYkfghIqAxbVEURDI6+7/zIPdRMWKcae4MfGxJwS5NDr3RKnPDH fOQ8KFM/mYLL9YgNCU5A+jqFC85a+pkHX4Pz4i3x+0pcKy0coQgQvqCWay+BrCkU XOgQ6MHcve/luLofbEhJAgVQzPBmz7LcSj1CQHQIdeCvG8Edyqg= =vBfn -----END PGP SIGNATURE----- --ZgGN478A9hzzvyZc-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 23 11:51:09 2019 Received: (at 38711-close) by debbugs.gnu.org; 23 Dec 2019 16:51:09 +0000 Received: from localhost ([127.0.0.1]:51611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijQvC-0004To-2b for submit@debbugs.gnu.org; Mon, 23 Dec 2019 11:51:09 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:33962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijQv7-0004TI-QH for 38711-close@debbugs.gnu.org; Mon, 23 Dec 2019 11:51:05 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 47hQN445yHz1qql2; Mon, 23 Dec 2019 17:51:00 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 47hQN42NSXz1qqkW; Mon, 23 Dec 2019 17:51:00 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ujeXQFk32un1; Mon, 23 Dec 2019 17:50:59 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-188-174-62-171.dynamic.mnet-online.de [188.174.62.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Mon, 23 Dec 2019 17:50:59 +0100 (CET) Received: from [192.168.110.31] (lenashee.fritz.box [192.168.110.31]) by hermia.goebel-consult.de (Postfix) with ESMTP id DFB9760089; Mon, 23 Dec 2019 17:52:16 +0100 (CET) To: Efraim Flashner References: <20191222214003.7352-1-h.goebel@crazy-compilers.com> <20191223133033.GQ1115@E5400> From: Hartmut Goebel Autocrypt: addr=h.goebel@crazy-compilers.com; prefer-encrypt=mutual; keydata= mQINBFJQM3oBEACiUXmMppc3+A7JpF3lPz8O/mRhfz1U6F4EOTlacTrCcm7Xg5U2JsPPNapV r5+vHnKBK+xbaX3s/A/G+SwrUZhi1X1HRnSNY1CqL8CT7rZmOtfjg4ExnOuCjie2bKhb9JKm lJ7MrNimIbNQoX1mRcQ4VMEflhyWfaPGbT73siuMkbr020ExhzW8T18JIC01SgWMULYMBXOB oGY21am/vaTFCK8bym1P4HVN8i64uOWL0agkAMHbju6SZtG2fYJ68eS3P/97bXRg1pveEdpa FgaFZhquecw4WdedwLwt1xNcjAg/p6tN73W3asEZTgMHa+iNzbJgcyhWpci09wQZfZ1uL0Hd M+ohng38ccgu9hJx6YzCN7Fe14JooKbPukG/WfClAgAzZSHRKpS4zGdGlg6D6EWayyWWoLR3 KoMA4LIIlaQbqaOhfe85b4mNgB1hqd0uRTHOah/6T+FUoSQ1IAeKLIDqj6rW7X4ISRn1CXGS LGDn2QKqR3KtU3cLf8hAeDeO7Qe1jTvLrG1Mfca8lEmC7/yN1gI7L4/cs6lhmXUgMaevuxss BxO2kkh0OS8HVFf+QQ7LZ5vt91yQVT9HVvOuVob0YtG+3rvkpMaHQilKloNoEkmMiHpwypBa IfAC6NP9smgionvvmQ5RWSEaH5/pfSUAYbqzWbqDxtqEF/mPOwARAQABtC1IYXJ0bXV0IEdv ZWJlbCA8aC5nb2ViZWxAY3JhenktY29tcGlsZXJzLmNvbT6JAj0EEwEKACcCGwMCHgECF4AF CwkIBwMFFQoJCAsFFgIDAQAFAluyK5QFCQ0kXxEACgkQe3UoEb93O2XMlw//Z2/aXbZO3lJv uvfDBU3fJBKxp87EButnuwudFyaNupKxO13R7rBKB/Oti/rNP7IlK56WwU10ldK6C1PYnqru 5L1VCjWRi2Jd/XlvgXlc1jqstbM7NfU7pGOzctJGYpKh+7b1EdSM4V1KnDKcbKicLKC7zS+d HUdsch5w5XJj+pZRE4R0KEA/vEBB4ba+m+b59WqzaLin2pOqyo4Ff9o5uVgxlNrLIJQsg74T MTQP8khyDLfmyiN42VVkOBOIPMLA8ljEA1I7I4WwW3bT3mxOXHUExey/YsOdpqYX+kh7u/tj 7kbjKQbdCwdwUqSOPLmW9/9Wxyf2/xi+3lCvxzwPPElnK62yKlxLhVMt+Ah3J2QeLmrVGG5X PQzplrmQ6ptpEC9evrK3ALBJ+UGGxyyLp7sPb0SbDq70tZLRtbcE6QnpQA2IQIPTTy40lGVy 3a3iXiDM7hzbljWS0XSaEHoZ/WdgKLV+OzVZ9vrhP+7HrK7hEzdYqCvNfcW6bk2KrMN0RxBB OAbiRne8E0iTffh9uTyW7sAE0UDA9J3KtD3fpkld9cQrhwUVsjuPfbCqnhCk0B7ro1OR0DHB bgMVEylEsACnHEU4XWvo+U+0MgJtDQjzIy+XZfXDCs1VOy+murgcs0YIFqesyYOaaF1eP1S0 Yr18n/pfAPCFfg0rhMQUyoK5Ag0EUlAzegEQAL3lOz+uhHudEvovJVdExl+MTHLpYcajA0QL zDXe0jiAYdB+Jpvm7CAKani61/eo1SnHyRORELjxl/fL3ytjg3yRvVAM2I+xg7lIB4qXL5rR 5K8iF4px/jYV2CBIiwOKQ6gVEVk2hpl/tPqP3QdOKXdLu3sOM1Ygg3PN5fc+I7B6luchx6Bu 7NAR7nWKn6D1NdOI1UZL6Dr6Me/6hNVJBGvDF3Fm2x0CoIHujFksfOxZtwoZMXn13N18ZDyQ OMA89eHNQlFri9i5xG3laMAW2M0bozf+FwTBXomIWkT2Tkj3omW8ZIcfags2SpRkQl45pE65 nLKK36eRNoNbBovqKalMyhKstFTpIjjTZRMI5EZ87j7gYX/ghCss2LZz4X0WfvH6lYt8Yvjv I9Stl4ENvNukQZSZgIpaaAgZceXyuLaj+FY1cVXK3AoTh+lordfXr3TSBxlb1z7cNHqsI9vd RwsfC+Ng+yRrNGnNw008fgDq9fhaZus1krtPQzTyJzMw9xnLKuHhHFbkHDaW1Gb9dnECBF8a T0kjffgENEa5K6bfyAGGZ5zikBuK9EZdIQ0KgLP55hdnY7PigXazSsvYxVB62+B0kRYxjyM7 UAX55+QeD7pkPhBmRozeNYZzQxu9cyeD83e1Yf7ddnBkkLXVyTzKIutGh2R2BkcmkbBKTv27 ABEBAAGJAjwEGAEKACYCGwwWIQTUrYucFnt1fE8I6Hd7dSgRv3c7ZQUCW7IswAUJDSRgPgAK CRB7dSgRv3c7ZbFUD/97iHXgPYSZWyZ9r8pgpRuyoIK2TKmClUxck1a0WUkTMjzi0gW4kOIj 2wNOUnsRqioxOVXAg0R9ix1l6+LBC8+m/VFoR37BYQsC5WrzkmeaFChrBPs+YlND0V7TWNq0 elBvsNuApVxSOzaJuxCnH9WLe3s4fIveymScNAZOm31DHgmkDcb1/NXg97nohqSeW+k3eQbh borMRT3kMaXrPTI8qal9TsYf6KhfPi61fbnGW6bNJ0LnWQj2b7nb6nIR99cr0sNymqOsC6Gq 0yHhTceRl2/DRBe+QCxoiFKs1s6f7Af+U9r/JkHfdOLCRxjmAyl22zlhmBeNlGSvDbJqy5AE 7fKo1/mVQ2CNskF0BcOhrrntVf4A1gy3OlIXnCV//HH6w7qRBpw0inpD5c9Ny20aNdo8mS3y szcGZLczkdx8qzYEXBCO8zSDiRllrf6e8H5AaQdtHInxQ2Ywdqz/Ho81irbcPaHwI7P9/qvm zYnPZ3ULNlrI/+mq0oYkCB8oB9HW0C/YGZ/nIYY0vxDoy6n6EhEzntdAjF6Pav+QHB216fBs LMLs8X4+PXOc+MaAmQQTyTF9C8vfQk86E4eRmQErYw0aYVR7bUqyYfX8e2c5geqeSm6O+Brv 6LQtDbOJIcmJW1NS8XVmDG9JmkbtYqhnRDQMT+YFJircfDYmUvL4Ww== Organization: crazy-compilers.com Subject: Re: [bug#38711] [PATCH] build-system: qt: Actually use qt-build-system, not cmake-build-system. Message-ID: <1eaa5897-b0e8-e7dc-1b4a-a4ef57784be6@crazy-compilers.com> Date: Mon, 23 Dec 2019 17:50:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20191223133033.GQ1115@E5400> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F0WiuIZdujmvM6yJSuMULxH30iWB3XU2Y" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38711-close Cc: 38711-close@debbugs.gnu.org, ludo@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --F0WiuIZdujmvM6yJSuMULxH30iWB3XU2Y Content-Type: multipart/mixed; boundary="P3K2qNp5UvuIgexX6ZE10AR31P38N59hq"; protected-headers="v1" From: Hartmut Goebel To: Efraim Flashner Cc: 38711-close@debbugs.gnu.org, ludo@gnu.org Message-ID: <1eaa5897-b0e8-e7dc-1b4a-a4ef57784be6@crazy-compilers.com> Subject: Re: [bug#38711] [PATCH] build-system: qt: Actually use qt-build-system, not cmake-build-system. References: <20191222214003.7352-1-h.goebel@crazy-compilers.com> <20191223133033.GQ1115@E5400> In-Reply-To: <20191223133033.GQ1115@E5400> --P3K2qNp5UvuIgexX6ZE10AR31P38N59hq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US Hi Efraim, thanks for the review. Am 23.12.19 um 14:30 schrieb Efraim Flashner: > This would explain some of the problems we've run into with, say, > mumble. If applying this means we can reverse > a7a91c01c98499c8a1e44fadea1b8f70e91fc16f and still have the binaries > wrapped then I say go for it. Yes, this patch allows to revert a7a91c01c98499c8a1e44fadea1b8f70e91fc16f. See also . I already reverted a7a91c01c and changed the other packages which used the same pattern ((sddm, ktouch, kdeconnect, kdevelop)) > Don't forget to re-indent the following lines=20 ACK. I did this in a separate commit to make the actual change more obvio= us. Pushed as fce8ec9e151..50bdf0043. --=20 Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --P3K2qNp5UvuIgexX6ZE10AR31P38N59hq-- --F0WiuIZdujmvM6yJSuMULxH30iWB3XU2Y Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE1K2LnBZ7dXxPCOh3e3UoEb93O2UFAl4A8HAACgkQe3UoEb93 O2XF1A//Ym3YtexU0Qwgv0kP3a5NQg09FU8mPyOwcbrl1i7JgKW9yplqRPGKpbY3 uvkv0NkQdbUexijY93jox1KUxTvTMa7CkBgj0UuXOdregqYpLSbt5DM/ucs+VllA D1kDeADn78x9j7WFNKebmPMZQyR2lRVGMjBKAR5p6A8anDv++6fo/fs9/Npi3p/Q wfta/GCqeGskeA4+7oj0xDskuadGv2gbKrQdBMOBhGdDnAEmQuSVtOzDpWuvcEAW As8KeAa8p/ERkRGZUgkcNjDny/oYzeyusmTemNTh2FcjAusIO8GtQlLrd3ci48xH 4p5iuLVhoKiKCCTUEU0zOmXKDEAyh/4gM13A9HR5to/xh3qgg0gjyN6KJyw01mMD jFIJc7Vy9uRbqN7fKSXz01EPP88lZeEJEHl/IOh1zQgo2S42Z/TW4F8jPE8g0Xua NtYoGQpy3pKU9kP6tVQ4lqWBxdpTQ3rwHhj0laNtKq2dDcHsK235D9+aIuxptD29 iXojIqFDR2dcwkQSK8uGjradIEfH9PRd/zM2Dh5kLN5e4oe/GdEGOWlu1OmNZxb5 4S+gs/iNCCcp3R4b+PQWV+vT9Z4ErQvT3LCIpVsZlV38xbuLI7qubKjny+b6q2No 2eebFYxuZJhO4UX53j6QafeiKB8rZJrnHCdjQCer56KLO8+Pl/Q= =/V9P -----END PGP SIGNATURE----- --F0WiuIZdujmvM6yJSuMULxH30iWB3XU2Y-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 23 11:54:26 2019 Received: (at 38711) by debbugs.gnu.org; 23 Dec 2019 16:54:26 +0000 Received: from localhost ([127.0.0.1]:51618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijQyP-0004Yj-V2 for submit@debbugs.gnu.org; Mon, 23 Dec 2019 11:54:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijQyO-0004YW-A6 for 38711@debbugs.gnu.org; Mon, 23 Dec 2019 11:54:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ijQyI-00035U-TB; Mon, 23 Dec 2019 11:54:18 -0500 Received: from lns-bzn-56-82-255-208-147.adsl.proxad.net ([82.255.208.147]:34774 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ijQyI-0000R5-D5; Mon, 23 Dec 2019 11:54:18 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Efraim Flashner Subject: Re: [bug#38711] [PATCH] build-system: qt: Actually use qt-build-system, not cmake-build-system. References: <20191222214003.7352-1-h.goebel@crazy-compilers.com> <20191223133033.GQ1115@E5400> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 3 =?utf-8?Q?Niv=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 23 Dec 2019 17:54:16 +0100 In-Reply-To: <20191223133033.GQ1115@E5400> (Efraim Flashner's message of "Mon, 23 Dec 2019 15:30:33 +0200") Message-ID: <87k16nj83r.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38711 Cc: Hartmut Goebel , 38711@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Efraim Flashner skribis: > On Sun, Dec 22, 2019 at 10:40:03PM +0100, Hartmut Goebel wrote: >> When the qt-build-system was created, based on the cmake-build-system, >> some references to cmake have been missed to be changed. Oh, I see. > This would explain some of the problems we've run into with, say, > mumble. If applying this means we can reverse > a7a91c01c98499c8a1e44fadea1b8f70e91fc16f and still have the binaries > wrapped then I say go for it. Agreed! Ludo=E2=80=99. From unknown Sun Jun 22 04:31:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 21 Jan 2020 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator