From unknown Sun Aug 17 22:02:37 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#38687 <38687@debbugs.gnu.org> To: bug#38687 <38687@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add libtcod. Reply-To: bug#38687 <38687@debbugs.gnu.org> Date: Mon, 18 Aug 2025 05:02:37 +0000 retitle 38687 [PATCH] gnu: Add libtcod. reassign 38687 guix-patches submitter 38687 Giacomo Leidi severity 38687 normal tag 38687 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 07:38:53 2019 Received: (at submit) by debbugs.gnu.org; 20 Dec 2019 12:38:53 +0000 Received: from localhost ([127.0.0.1]:45996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiHYS-0003rG-Os for submit@debbugs.gnu.org; Fri, 20 Dec 2019 07:38:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:48109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiHYR-0003r8-Ck for submit@debbugs.gnu.org; Fri, 20 Dec 2019 07:38:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35992) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiHYP-0005qc-Iv for guix-patches@gnu.org; Fri, 20 Dec 2019 07:38:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iiHYN-000149-Nu for guix-patches@gnu.org; Fri, 20 Dec 2019 07:38:49 -0500 Received: from devianza.investici.org ([198.167.222.108]:34729) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iiHYN-0000pW-46 for guix-patches@gnu.org; Fri, 20 Dec 2019 07:38:47 -0500 Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id BD93AE0559; Fri, 20 Dec 2019 12:38:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1576845521; bh=5DBkj/RoHVstC+Kyn8rw4+2phly0s1cYX/feFHgZjc8=; h=From:To:Cc:Subject:Date:From; b=MiM41+5dHAUic6NdaqjqWNY2oJzfjo8Obr0Do0rnQRHQ2XFmK3HWNrFAnwnVdIpN9 k1lOFaiSB6zeU0V6TWG/DtAFVGH1KwUkamhbhW5GQQN3kcm2ofu+qd0q/vwLyfbVPP FFFj6MPRYkRIk8MyvQRpEDKNBuWRjDz69Y3rqBEQ= Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: goodoldpaul@autistici.org) by localhost (Postfix) with ESMTPSA id 97657E0556; Fri, 20 Dec 2019 12:38:40 +0000 (UTC) From: Giacomo Leidi To: guix-patches@gnu.org Subject: [PATCH] gnu: Add libtcod. Date: Fri, 20 Dec 2019 13:37:39 +0100 Message-Id: <20191220123739.18081-1-goodoldpaul@autistici.org> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 198.167.222.108 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Giacomo Leidi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/game-development.scm (libtcod): New variable. --- gnu/packages/game-development.scm | 39 +++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-develo= pment.scm index febe15fa57..b5c4ff9ca7 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -17,6 +17,7 @@ ;;; Copyright =C2=A9 2019 Pierre Neidhardt ;;; Copyright =C2=A9 2019 Leo Prikler ;;; Copyright =C2=A9 2019 Jethro Cao +;;; Copyright =C2=A9 2019 Giacomo Leidi ;;; ;;; This file is part of GNU Guix. ;;; @@ -1904,3 +1905,41 @@ projects.") hardware from multiple vendors without requiring that applications have specific knowledge of the hardware they are targeting.") (license license:bsd-3))) + +(define-public libtcod + (package + (name "libtcod") + (version "1.15.1") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/libtcod/libtcod.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0pzr8ajmbqvh43ldjajx962xirj3rf8ayh344p6mqlrmb8gxrfr5"))= )) + (build-system gnu-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'change-to-build-dir + (lambda _ + (chdir "buildsys/autotools") + (patch-shebang "get_version.py") + #t))))) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("libtool" ,libtool) + ("python" ,python) + ("pkg-config" ,pkg-config) + ("sdl2" ,sdl2) + ("zlib" ,zlib))) + (home-page "https://github.com/libtcod/libtcod") + (synopsis "Library specifically designed for writing roguelikes") + (description + "libtcod is a free, fast, portable and uncomplicated API for roguel= ike +developers providing an advanced true color console, input, and lots of = other +utilities frequently used in roguelikes.") + (license license:bsd-3))) --=20 2.24.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 23 13:37:30 2019 Received: (at 38687) by debbugs.gnu.org; 23 Dec 2019 18:37:30 +0000 Received: from localhost ([127.0.0.1]:51669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijSaA-00070h-4V for submit@debbugs.gnu.org; Mon, 23 Dec 2019 13:37:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijSa8-00070S-00 for 38687@debbugs.gnu.org; Mon, 23 Dec 2019 13:37:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ijSa2-00009i-9E; Mon, 23 Dec 2019 13:37:22 -0500 Received: from lns-bzn-56-82-255-208-147.adsl.proxad.net ([82.255.208.147]:35342 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ijSa1-0000nk-NT; Mon, 23 Dec 2019 13:37:22 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Giacomo Leidi Subject: Re: [bug#38687] [PATCH] gnu: Add libtcod. References: <20191220123739.18081-1-goodoldpaul@autistici.org> Date: Mon, 23 Dec 2019 19:37:18 +0100 In-Reply-To: <20191220123739.18081-1-goodoldpaul@autistici.org> (Giacomo Leidi's message of "Fri, 20 Dec 2019 13:37:39 +0100") Message-ID: <875zi6j3c1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38687 Cc: 38687@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Giacomo Leidi skribis: > * gnu/packages/game-development.scm (libtcod): New variable. Could you (1) add a =E2=80=98snippet=E2=80=99 that removes zlib and utf8pro= c from src/vendor (assuming it doesn=E2=80=99t break the build system=E2=80=A6), a= nd (2) add utf8proc as an input? That way we=E2=80=99d make sure we don=E2=80=99t end up using bundled copie= s of these packages. Apart from that it LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 22 06:11:40 2020 Received: (at 38687) by debbugs.gnu.org; 22 Jan 2020 11:11:40 +0000 Received: from localhost ([127.0.0.1]:49052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuDv9-00042e-Is for submit@debbugs.gnu.org; Wed, 22 Jan 2020 06:11:39 -0500 Received: from devianza.investici.org ([198.167.222.108]:54097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuDv7-00042W-6b for 38687@debbugs.gnu.org; Wed, 22 Jan 2020 06:11:38 -0500 Received: from 1.mail-backend.investici.org (unknown [10.0.0.11]) by devianza.investici.org (Postfix) with ESMTP id AD510E0630; Wed, 22 Jan 2020 11:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1579691495; bh=xHGvW0fxAdBobtazGl3XHfOAIBFDZM7SmP6F2bkZP+c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bMrsGie29p27OHLa9Y5m0u+SkJdunIAwDC/PoVk7gKprOxlEY9z0mT7iQRU4EN+H1 TneuOrbh2A96gCZgvfoOoDTY0N7MlDSBFQyunj5aURYrvmC2DhmAW2OTYihdWy7J80 Kl/PNJ2C5p4W9+b/McEF3ogJ8vl0C5QbwcKpyXeQ= Received: from 1.webmail.investici.org (localhost [127.0.0.1]) (Authenticated sender: goodoldpaul@autistici.org) by 1.mail-backend.investici.org (Postfix) with ESMTPA id 9685ABEE32; Wed, 22 Jan 2020 11:11:34 +0000 (UTC) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_7703b87ad1ab6afaa375a47d19d3a148" Content-Transfer-Encoding: 8bit Date: Wed, 22 Jan 2020 11:11:34 +0000 From: goodoldpaul@autistici.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: [bug#38687] [PATCH] gnu: Add libtcod. In-Reply-To: <875zi6j3c1.fsf@gnu.org> References: <20191220123739.18081-1-goodoldpaul@autistici.org> <875zi6j3c1.fsf@gnu.org> User-Agent: Roundcube Webmail Message-ID: <891e12c54b84a6f4caad6b4c72f1ecba@autistici.org> X-Sender: goodoldpaul@autistici.org X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38687 Cc: 38687@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=_7703b87ad1ab6afaa375a47d19d3a148 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8; format=flowed On 2019-12-23 18:37, Ludovic Courtès wrote: > Hi, > > Giacomo Leidi skribis: > >> * gnu/packages/game-development.scm (libtcod): New variable. > > Could you (1) add a ‘snippet’ that removes zlib and utf8proc from > src/vendor (assuming it doesn’t break the build system…), and (2) add > utf8proc as an input? > > That way we’d make sure we don’t end up using bundled copies of these > packages > > Apart from that it LGTM, thanks! > > Ludo’. Hi Ludo', Sorry for the delay. I checked and it seems that a lot of vendor library paths are hardcoded in the C headers. I made a new patch with a snippet that deletes zlib sources, but I'm unsure about how to approach the hardcoded paths. grepping for 'vendor' inside the source returns src/libtcod/sys_sdl_img_png.cpp 41:#include "../vendor/lodepng.h" src/libtcod/console/printing.cpp 54:#include "../../vendor/utf8proc/utf8proc.h" src/libtcod/sdl2/gl2_ext_.h 36:#include "../../vendor/glad.h" src/libtcod/color/canvas.cpp 39:#include "../../vendor/lodepng.h" src/libtcod/tileset/truetype.cpp 43:#include "../../vendor/stb_truetype.h" src/libtcod/tileset/tilesheet.cpp 34:#include "../../vendor/lodepng.h" As far as I understood (I'm no C wizard) lodepng, glad and stb are libraries which are designed to be dropped inside a source tree and statically built in binaries. Right now I think those are secondary problems and the main deal is how to effectively replace the included utf8proc. I'm not sure if replacing every "#include ../../vendor/something.h" with "#include " ( by including a .patch file or with substitute* ? Food for thought :D) and then placing something.h inside a path known by the C linker is enough but it's the I'm not really sure where to go from here. Any advice is very welcome, thanks. Giacomo --=_7703b87ad1ab6afaa375a47d19d3a148 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-Add-libtcod.patch Content-Disposition: attachment; filename=0001-gnu-Add-libtcod.patch; size=2959 RnJvbSAwMTg3N2Y1ZjdhN2JlZWQyZDUyNzI5YzRjYTU1NzdjY2NjNDk1YTg4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHaWFjb21vIExlaWRpIDxnb29kb2xkcGF1bEBhdXRpc3RpY2ku b3JnPgpEYXRlOiBTdW4sIDE5IEphbiAyMDIwIDE2OjU5OjU3ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gZ251OiBBZGQgbGlidGNvZC4KCiogZ251L3BhY2thZ2VzL2dhbWUtZGV2ZWxvcG1lbnQuc2Nt IChsaWJ0Y29kKTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9nYW1lLWRldmVsb3Bt ZW50LnNjbSB8IDQ1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFu Z2VkLCA0NSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2dhbWUtZGV2 ZWxvcG1lbnQuc2NtIGIvZ251L3BhY2thZ2VzL2dhbWUtZGV2ZWxvcG1lbnQuc2NtCmluZGV4IGVl OGRlYTIzYjUuLmYwMzMyMTI4MWUgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9nYW1lLWRldmVs b3BtZW50LnNjbQorKysgYi9nbnUvcGFja2FnZXMvZ2FtZS1kZXZlbG9wbWVudC5zY20KQEAgLTE4 LDYgKzE4LDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAxOSwgMjAyMCBMZW8gUHJpa2xlciA8bGVv LnByaWtsZXJAc3R1ZGVudC50dWdyYXouYXQ+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTkgSmV0aHJv IENhbyA8amV0aHJvY2FvQGdtYWlsLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAyMCBOaWNvbGFz IEdvYXppb3UgPG1haWxAbmljb2xhc2dvYXppb3UuZnI+Cis7OzsgQ29weXJpZ2h0IMKpIDIwMjAg R2lhY29tbyBMZWlkaSA8Z29vZG9sZHBhdWxAYXV0aXN0aWNpLm9yZz4KIDs7OwogOzs7IFRoaXMg ZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7CkBAIC04Niw2ICs4Nyw3IEBACiAgICM6dXNl LW1vZHVsZSAoZ251IHBhY2thZ2VzIHNwaGlueCkKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgc3RiKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyB0ZXhpbmZvKQorICAjOnVzZS1t b2R1bGUgKGdudSBwYWNrYWdlcyB0ZXh0dXRpbHMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIHRscykKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgdmlkZW8pCiAgICM6dXNlLW1v ZHVsZSAoZ251IHBhY2thZ2VzIHhkaXNvcmcpCkBAIC0yMDQ5LDMgKzIwNTEsNDYgQEAgY29tcHV0 ZXIgZ2FtZXMsIDNEIGF1dGhvcmluZyB0b29scyBhbmQgc2ltdWxhdGlvbiB0b29scy4iKQogICAg IChkZXNjcmlwdGlvbiAiQ2hpcG11bmsgaXMgYSBzaW1wbGUsIGxpZ2h0d2VpZ2h0LCBmYXN0IGFu ZCBwb3J0YWJsZSAyRAogcmlnaWQgYm9keSBwaHlzaWNzIGxpYnJhcnkgd3JpdHRlbiBpbiBDLiIp CiAgICAgKGxpY2Vuc2UgbGljZW5zZTpleHBhdCkpKQorCisoZGVmaW5lLXB1YmxpYyBsaWJ0Y29k CisgIChwYWNrYWdlCisgICAgKG5hbWUgImxpYnRjb2QiKQorICAgICh2ZXJzaW9uICIxLjE1LjEi KQorICAgIChzb3VyY2UgKG9yaWdpbgorICAgICAgICAgICAgICAobWV0aG9kIGdpdC1mZXRjaCkK KyAgICAgICAgICAgICAgKHVyaSAoZ2l0LXJlZmVyZW5jZQorICAgICAgICAgICAgICAgICAgICAo dXJsICJodHRwczovL2dpdGh1Yi5jb20vbGlidGNvZC9saWJ0Y29kLmdpdCIpCisgICAgICAgICAg ICAgICAgICAgIChjb21taXQgdmVyc2lvbikpKQorICAgICAgICAgICAgICAoZmlsZS1uYW1lIChn aXQtZmlsZS1uYW1lIG5hbWUgdmVyc2lvbikpCisgICAgICAgICAgICAgIChzaGEyNTYKKyAgICAg ICAgICAgICAgIChiYXNlMzIKKyAgICAgICAgICAgICAgICAiMHB6cjhham1icXZoNDNsZGphang5 NjJ4aXJqM3JmOGF5aDM0NHA2bXFscm1iOGd4cmZyNSIpKQorICAgICAgICAgICAgICAobW9kdWxl cyAnKChndWl4IGJ1aWxkIHV0aWxzKSkpCisgICAgICAgICAgICAgIChzbmlwcGV0ICcoYmVnaW4K KyAgICAgICAgICAgICAgICAgICAgICAgICAgKGRlbGV0ZS1maWxlLXJlY3Vyc2l2ZWx5ICJzcmMv dmVuZG9yL3psaWIiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAjdCkpKSkKKyAgICAoYnVp bGQtc3lzdGVtIGdudS1idWlsZC1zeXN0ZW0pCisgICAgKGFyZ3VtZW50cworICAgICBgKCM6cGhh c2VzCisgICAgICAgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgKGFk ZC1hZnRlciAndW5wYWNrICdjaGFuZ2UtdG8tYnVpbGQtZGlyCisgICAgICAgICAgIChsYW1iZGEg XworICAgICAgICAgICAgIChjaGRpciAiYnVpbGRzeXMvYXV0b3Rvb2xzIikKKyAgICAgICAgICAg ICAocGF0Y2gtc2hlYmFuZyAiZ2V0X3ZlcnNpb24ucHkiKQorICAgICAgICAgICAgICN0KSkpKSkK KyAgICAobmF0aXZlLWlucHV0cworICAgICBgKCgiYXV0b2NvbmYiICxhdXRvY29uZikKKyAgICAg ICAoImF1dG9tYWtlIiAsYXV0b21ha2UpCisgICAgICAgKCJsaWJ0b29sIiAsbGlidG9vbCkKKyAg ICAgICAoInB5dGhvbiIgLHB5dGhvbikKKyAgICAgICAoInBrZy1jb25maWciICxwa2ctY29uZmln KQorICAgICAgICgic2RsMiIgLHNkbDIpKSkKKyAgICAoaW5wdXRzCisgICAgIGAoKCJ6bGliIiAs emxpYikpKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHViLmNvbS9saWJ0Y29kL2xpYnRj b2QiKQorICAgIChzeW5vcHNpcyAiTGlicmFyeSBzcGVjaWZpY2FsbHkgZGVzaWduZWQgZm9yIHdy aXRpbmcgcm9ndWVsaWtlcyIpCisgICAgKGRlc2NyaXB0aW9uCisgICAgICJsaWJ0Y29kIGlzIGEg ZnJlZSwgZmFzdCwgcG9ydGFibGUgYW5kIHVuY29tcGxpY2F0ZWQgQVBJIGZvciByb2d1ZWxpa2UK K2RldmVsb3BlcnMgcHJvdmlkaW5nIGFuIGFkdmFuY2VkIHRydWUgY29sb3IgY29uc29sZSwgaW5w dXQsIGFuZCBsb3RzIG9mIG90aGVyCit1dGlsaXRpZXMgZnJlcXVlbnRseSB1c2VkIGluIHJvZ3Vl bGlrZXMuIikKKyAgICAobGljZW5zZSBsaWNlbnNlOmJzZC0zKSkpCi0tIAoyLjI1LjAKCg== --=_7703b87ad1ab6afaa375a47d19d3a148-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 22 13:57:56 2020 Received: (at 38687) by debbugs.gnu.org; 22 Jan 2020 18:57:56 +0000 Received: from localhost ([127.0.0.1]:51325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuLCO-0004rD-8U for submit@debbugs.gnu.org; Wed, 22 Jan 2020 13:57:56 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:52185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuLCM-0004r0-Gn for 38687@debbugs.gnu.org; Wed, 22 Jan 2020 13:57:55 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id AC1064BB; Wed, 22 Jan 2020 13:57:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 22 Jan 2020 13:57:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=i5RAX1javPQoEFQldX6sW7uL2v PwxSmCod3Ty39u1XE=; b=N8JxiFlizI9lDAsxPv5N+0t3X8fq0ltcVFyCoFfGrb 8mk4HEY9r8MCYbcrPoJgZemE/U2gIw7dmafucQ5Z3w7eOT/UIgOv4YFYygOLEnyY VHcGxr46rYAgZ4LG90gBR8fIKc8ooz+AQIuLeZiUVdYoFDHyYKV8FToU55Ahsc7n M5cPLzL/SjcfrXWBSmMUaTQblzHcrqaJdKRsIv0qpkYepfFihk/NzGvT6vT6ACb1 NkYrNo1jWkQbN818d7AraTZ47sRN47NpD1BhA5Wd52JOAJZyUzh4HM3jaQkFBm2k dcIhM05BVA3ju8BtqnAmeoEntmez2GhRaMGaFg0IcQ1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=i5RAX1 javPQoEFQldX6sW7uL2vPwxSmCod3Ty39u1XE=; b=HzSmdnbAGNK0MlNPRhSlWL +2vEODZtn4zzfIoAg7QFsILF/rRTfDR3dO91z5YG/IJzQnLE44g3/siylHpzJaAW C+i8noiqFhDYvcm73JHGsrteRGzJIvBGSWwjNMejhXHEzp0pgvEvPr9RUSltsWcl 5eKYhOXkaOSes6IZBPLPG8jAGGWF8k8zfFaLwh7VPkUDrFMdLoBgtluUJMd6RkX2 nFDm/6BZ/14f+qc7tGY9km8qD94wytTyKi1S0RvlCQ7OMBOsly909OJ8mQVEhTFK dwX1gZNdq6ij1pq3DmOLcZeEcZkv2QiTvGHq1pkRhF+cVzOlSYM81obls0vqV/Yw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrvddtgdduudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehgtderredtredtnecuhfhrohhmpeforghrihhu shcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhmqeenucfkphepke egrddvtddvrdeiledrvdehfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-3035.bb.online.no [84.202.69.253]) by mail.messagingengine.com (Postfix) with ESMTPA id BEE4130602DE; Wed, 22 Jan 2020 13:57:47 -0500 (EST) From: Marius Bakke To: goodoldpaul@autistici.org, Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#38687] [PATCH] gnu: Add libtcod. In-Reply-To: <891e12c54b84a6f4caad6b4c72f1ecba@autistici.org> References: <20191220123739.18081-1-goodoldpaul@autistici.org> <875zi6j3c1.fsf@gnu.org> <891e12c54b84a6f4caad6b4c72f1ecba@autistici.org> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Wed, 22 Jan 2020 19:57:45 +0100 Message-ID: <87muaftj2u.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38687 Cc: 38687@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable goodoldpaul@autistici.org writes: > As far as I understood (I'm no C wizard) lodepng, glad and stb are=20 > libraries which are designed to be dropped inside a source tree and=20 > statically built in binaries. Right now I think those are secondary=20 > problems and the main deal is how to effectively replace the included=20 > utf8proc. > > I'm not sure if replacing every "#include ../../vendor/something.h" with= =20 > "#include " ( by including a .patch file or with=20 > substitute* ? Food for thought :D) and then placing something.h inside a= =20 > path known by the C linker is enough but it's the I'm not really sure=20 > where to go from here. Something like (substitute* (find-files "src/libtcod" "\\.(h|cpp)$") (("\\.\\./\\.\\./vendor/") "")) Would make all the header paths relative, i.e. looked up in the compiler search path. In practice you might need to narrow down the substitution so that e.g. vendor/utf8proc is preserved, if it turns out to be difficult to unbundle. There is currently no stb-truetype package, but it should be trivial to add it (see gnu/packages/stb.scm). Lodepng looks fairly easy too. :-) Good luck! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl4omykACgkQoqBt8qM6 VPpmjwf8CG7TILIwqCgkbyo6OP5l3zsvhDgivK7tXR6aRrnS1RRG9+ABuAXAW7sS gxVbyZFeWmSb8fy44A5CwsPnJOFd1ZKkaxUc9vG3DbQlwOu2XJnRenrlI+83imvU 4vD95uHW0TQtnp+kn3krmxPuAoHe0CoA4g7guAXUrs7STP3oGiM1Ah9BcbRUEK+v fkeze3ikUQmlK9m6nMprBmCBYUaYcQpgSdFiG/gixdUh6iuGIV/G37s1SO/AeDHp HwXJupCuZH5MtHyjdyTMpoE60qUuL1/RhhpstyKS4sz5CHhKR8eK8uaRpWuLyKj+ rDozaAJS8ZbfxGIU1u8NlsRr0HHkWw== =I0Yf -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 06 15:17:04 2020 Received: (at 38687) by debbugs.gnu.org; 6 Feb 2020 20:17:04 +0000 Received: from localhost ([127.0.0.1]:48528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iznaB-0003He-U6 for submit@debbugs.gnu.org; Thu, 06 Feb 2020 15:17:04 -0500 Received: from confino.investici.org ([212.103.72.250]:24361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izna9-0003Gk-65 for 38687@debbugs.gnu.org; Thu, 06 Feb 2020 15:17:02 -0500 Received: from 1.mail-backend.investici.org (unknown [10.0.0.11]) by confino.investici.org (Postfix) with ESMTP id D5DA920F78; Thu, 6 Feb 2020 20:16:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1581020219; bh=UEC2Fe5sRI3eS7WT9iqhi4DLNr1ZB8xkD/Jv59NIccY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lF4+v7Za2qzswY+dM2v6rInA/mud6gzs9le96ecHHUV+2BfCdhhRk0fi2s7VHjAko TGUpFfn5VVzGCOOykY3+taGkGyQZzYys1xjthob/kWIf/CIbvfO2hLjqtmrH+47AU4 A9b8ngnPDP9lutdXd0Dqp+1Ya0ob3QCQ9QeLecGg= Received: from 1.webmail.investici.org (localhost [127.0.0.1]) (Authenticated sender: goodoldpaul@autistici.org) by 1.mail-backend.investici.org (Postfix) with ESMTPA id A78FFBEE32; Thu, 6 Feb 2020 20:16:57 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 06 Feb 2020 20:16:57 +0000 From: goodoldpaul@autistici.org To: Marius Bakke Subject: Re: [bug#38687] [PATCH] gnu: Add libtcod. In-Reply-To: <87muaftj2u.fsf@devup.no> References: <20191220123739.18081-1-goodoldpaul@autistici.org> <875zi6j3c1.fsf@gnu.org> <891e12c54b84a6f4caad6b4c72f1ecba@autistici.org> <87muaftj2u.fsf@devup.no> User-Agent: Roundcube Webmail Message-ID: X-Sender: goodoldpaul@autistici.org X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38687 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 38687@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Marius and Ludo, I managed to remove all vendored libraries except for glad.h which seems to be some kind of generated glue code for loading OpenGL (https://github.com/Dav1dde/glad). In the next two patches I'm adding libtcod and it's dependency lodepng. Guix lint is warning me that lodepng could be affected by CVE-2019-17178, but taking a look at https://nvd.nist.gov/vuln/detail/CVE-2019-17178 and https://nvd.nist.gov/vuln/search/results?adv_search=true&cpe_version=cpe%3a%2fa%3alodev%3alodepng%3a2019-09-28 seems to indicate that lodepng should be *not* vulnerable since 28/09/2019, did I understand correctly? Please don't hesitate and tell me if anything should done w.r.t. the CVE. Thanks for your patience reviewing this, Giacomo From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 06 15:17:48 2020 Received: (at 38687) by debbugs.gnu.org; 6 Feb 2020 20:17:48 +0000 Received: from localhost ([127.0.0.1]:48532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iznap-0003Ib-71 for submit@debbugs.gnu.org; Thu, 06 Feb 2020 15:17:47 -0500 Received: from latitanza.investici.org ([82.94.249.234]:49269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iznan-0003IQ-9D for 38687@debbugs.gnu.org; Thu, 06 Feb 2020 15:17:42 -0500 Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id B594412021F; Thu, 6 Feb 2020 20:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1581020259; bh=IuWHfxWiOC2+E4V8G103NUyE7AnarjxCNAGUBF5KwJg=; h=From:To:Cc:Subject:Date:From; b=B6tYgQUxP4wGmr0ONqDnbu9GKYngEurGDAbt4/c1rWQgTZxVlb0KXCLANuJsFtqgk N/oD6gqNu4HXZLrLsL38t+uZ5aWjxYM3Se6ziROrIYDO+sEqBk3LnGJSkgO0hgsNGn qd2o5bCe1/71kjSeszq64eY/rtC/4jB1wlJ0Ku5s= Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: goodoldpaul@autistici.org) by localhost (Postfix) with ESMTPSA id 5EF7212021D; Thu, 6 Feb 2020 20:17:38 +0000 (UTC) From: Giacomo Leidi To: 38687@debbugs.gnu.org Subject: [PATCH 1/2] gnu: Add lodepng. Date: Thu, 6 Feb 2020 21:17:12 +0100 Message-Id: <20200206201713.8535-1-goodoldpaul@autistici.org> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38687 Cc: Giacomo Leidi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/image.scm (lodepng): New variable. --- gnu/packages/image.scm | 58 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm index 45055858b4..18a51a8773 100644 --- a/gnu/packages/image.scm +++ b/gnu/packages/image.scm @@ -23,6 +23,7 @@ ;;; Copyright © 2018 Pierre-Antoine Rouby ;;; Copyright © 2018 Alex Vong ;;; Copyright © 2018 Rutger Helling +;;; Copyright © 2020 Giacomo Leidi ;;; ;;; This file is part of GNU Guix. ;;; @@ -1841,3 +1842,60 @@ using only text tools. SNG is implemented by a compiler/decompiler called sng that losslessly translates between SNG and PNG.") (license license:zlib))) + +(define-public lodepng + ;; The project doesn't seem to use any + ;; kind of meaningful versioning scheme. + (let ((commit "5a0dba103893e6b8084be13945a826663917d00a") + (revision "1") + (version "0.0.0")) + (package + (name "lodepng") + (version (git-version version revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/lvandeve/lodepng") + (commit commit))) + (sha256 + (base32 + "0nvlba82mf4n7xfc3rz2g9wwgnrxpjw64p5dsjmj2r06g5m4l38a")) + (file-name (git-file-name name version)))) + (build-system gnu-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (delete 'configure) + (replace 'build + (lambda _ + (setenv "CXXFLAGS" "-fPIC") + (invoke "make" "lodepng.o") + (invoke "make" "lodepng_util.o") + (invoke "ar" "rv" "liblodepng.a" "lodepng.o" "lodepng_util.o") + (invoke "g++" "-fPIC" "-O3" + "-o" "liblodepng.so" + "-shared" "lodepng.o" "lodepng_util.o") + #t)) + (replace 'check + (lambda _ + (invoke "make" "unittest") + (invoke "./unittest") + #t)) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (doc (string-append out "/share/doc")) + (lib (string-append out "/lib")) + (include (string-append out "/include"))) + (install-file "lodepng.h" include) + (install-file "lodepng_util.h" include) + (install-file "liblodepng.a" lib) + (install-file "liblodepng.so" lib) + (install-file "README.md" doc) + #t)))))) + (home-page "https://lodev.org/lodepng/") + (synopsis "PNG encoder and decoder in C and C++, without dependencies") + (description "LodePNG is a PNG image decoder and encoder, all in one, +no dependency or linkage required. It's made for C (ISO C90), and has a C++ +wrapper with a more convenient interface on top.") + (license license:zlib)))) -- 2.25.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 06 15:17:48 2020 Received: (at 38687) by debbugs.gnu.org; 6 Feb 2020 20:17:48 +0000 Received: from localhost ([127.0.0.1]:48534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iznau-0003Im-1L for submit@debbugs.gnu.org; Thu, 06 Feb 2020 15:17:48 -0500 Received: from latitanza.investici.org ([82.94.249.234]:24595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iznao-0003IY-Iu for 38687@debbugs.gnu.org; Thu, 06 Feb 2020 15:17:43 -0500 Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 15C55120220; Thu, 6 Feb 2020 20:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1581020262; bh=JXJlC9x3jqzLjNMliW9PoUtvykVlMDC0AUGxdiQTp1I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ADRN2gAU5ZKtFs11B/Fl2/R1Ac3ZuoqOC48/BJ/1D1nNabHCUrvTDuP3Zr1/FsxUN t+tT/atLGGD55kgIdo1Mazq8dyVPkYarrfh0mxfT4NRYOdrQDtcRpD5/ZEcOs9ONF8 Cd5UdE/UrUkwx+PYLR3pxjr2j/x7a5AzCsLpxmkE= Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: goodoldpaul@autistici.org) by localhost (Postfix) with ESMTPSA id D25E012021D; Thu, 6 Feb 2020 20:17:39 +0000 (UTC) From: Giacomo Leidi To: 38687@debbugs.gnu.org Subject: [PATCH 2/2] gnu: Add libtcod. Date: Thu, 6 Feb 2020 21:17:13 +0100 Message-Id: <20200206201713.8535-2-goodoldpaul@autistici.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200206201713.8535-1-goodoldpaul@autistici.org> References: <20200206201713.8535-1-goodoldpaul@autistici.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38687 Cc: Giacomo Leidi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/game-development.scm (libtcod): New variable. --- gnu/packages/game-development.scm | 76 +++++++++++++++++++++++++++++++ 1 file changed, 76 insertions(+) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 6fa4fed74f..ce25620773 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -19,6 +19,7 @@ ;;; Copyright © 2019 Jethro Cao ;;; Copyright © 2020 Nicolas Goaziou ;;; Copyright © 2020 Timotej Lazar +;;; Copyright © 2020 Giacomo Leidi ;;; ;;; This file is part of GNU Guix. ;;; @@ -88,6 +89,7 @@ #:use-module (gnu packages sphinx) #:use-module (gnu packages stb) #:use-module (gnu packages texinfo) + #:use-module (gnu packages textutils) #:use-module (gnu packages tls) #:use-module (gnu packages video) #:use-module (gnu packages web) @@ -2086,3 +2088,77 @@ computer games, 3D authoring tools and simulation tools.") (description "Chipmunk is a simple, lightweight, fast and portable 2D rigid body physics library written in C.") (license license:expat))) + +(define-public libtcod + (package + (name "libtcod") + (version "1.15.1") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/libtcod/libtcod.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0pzr8ajmbqvh43ldjajx962xirj3rf8ayh344p6mqlrmb8gxrfr5")) + (modules '((guix build utils))) + (snippet '(begin + (delete-file-recursively "src/vendor/utf8proc") + (delete-file-recursively "src/vendor/zlib") + (delete-file "src/vendor/stb_truetype.h") + (delete-file "src/vendor/stb_sprintf.h") + (delete-file "src/vendor/lodepng.cpp") + (delete-file "src/vendor/lodepng.h") + #t)))) + (build-system gnu-build-system) + (arguments + `(#:configure-flags '("--with-gnu-ld" + "LIBS=-lutf8proc -llodepng") + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'change-to-build-dir + (lambda _ + (chdir "buildsys/autotools") + (patch-shebang "get_version.py") + #t)) + (add-before 'bootstrap 'remove-hardcoded-vendor-paths + (lambda _ + (substitute* "sources.am" + (("\\.\\./\\.\\./src/vendor/lodepng\\.cpp \\\\\n") "") + (("\\.\\./\\.\\./src/vendor/stb\\.c \\\\") + "../../src/vendor/stb.c") + (("\\.\\./\\.\\./src/vendor/utf8proc/utf8proc\\.c") "")) + + (substitute* "../../src/libtcod/sys_sdl_img_png.cpp" + (("\\.\\./vendor/") "")) + + (substitute* '("../../src/libtcod/color/canvas.cpp" + "../../src/libtcod/sys_sdl_img_png.cpp" + "../../src/libtcod/tileset/truetype.cpp" + "../../src/libtcod/tileset/tilesheet.cpp") + (("\\.\\./\\.\\./vendor/") "")) + + (substitute* "../../src/libtcod/console/printing.cpp" + (("\\.\\./\\.\\./vendor/utf8proc/") "")) + #t))))) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("libtool" ,libtool) + ("lodepng" ,lodepng) + ("python" ,python) + ("pkg-config" ,pkg-config) + ("sdl2" ,sdl2) + ("stb-sprintf" ,stb-sprintf) + ("stb-truetype" ,stb-truetype))) + (inputs + `(("utf8proc" ,utf8proc) + ("zlib" ,zlib))) + (home-page "https://github.com/libtcod/libtcod") + (synopsis "Library specifically designed for writing roguelikes") + (description + "libtcod is a free, fast, portable and uncomplicated API for roguelike +developers providing an advanced true color console, input, and lots of other +utilities frequently used in roguelikes.") + (license license:bsd-3))) -- 2.25.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 10 16:10:57 2020 Received: (at 38687) by debbugs.gnu.org; 10 Feb 2020 21:10:57 +0000 Received: from localhost ([127.0.0.1]:55601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1GKW-0004Br-Us for submit@debbugs.gnu.org; Mon, 10 Feb 2020 16:10:57 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:38917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1GKV-0004Bf-7M for 38687@debbugs.gnu.org; Mon, 10 Feb 2020 16:10:55 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 74BA3686; Mon, 10 Feb 2020 16:10:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 10 Feb 2020 16:10:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=sdlgWCX+1Daxwe8t/VMwyWGh66 62qprerjMJQhYur6g=; b=Y56qz+cfhACiw8DfuErwi8epXzxiCw6FcCwIeEDbB0 dQ1+AQwJdRmjlkg4XOV4fp9AdwUPZOxMH2I4+WP/pVm/MemO2uZMvc2l4FAPA0A+ qNtkqoXmBka/LJc2awkSt8ubJ6xQcW1Cxzeu58xCQTim0r/6pkFDP3PLpr6AA3X3 jYb/VZLHM6VTTK8UqFTG863IrKe3m/XTo98iTyup7c6nRq+nA2L71znFvEsaFXDw 8x5TasZWcYqzf4QG8Z+2SX0hNHQKUvsQI7l3c0+yt0O/FgT+ecYSx1+4bCYxblzd Cq7iteyS0gye/0AIngJ+/qkMNNeKQ2KuI0/oGHnIOi5A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=sdlgWC X+1Daxwe8t/VMwyWGh6662qprerjMJQhYur6g=; b=hVKE7xU+QVwtu/rxpra+QY vFbn6UX75RBWphrUG71w1aG0QGnUiw3iUL7jcpG8dn7rSc5MuG4eyyFDNa+0eZAA zrWhy7bqnsA2NbDITrq2meLe5+RKCT//jwyNpfPa80ImjNNCS0XNrfjY4ADrk8iH ox2CcskOCtqb7rE60cP9ICzDf1qH6CooA6gEq9UWhyjqlUF8Ut6Gvpr5EKfH3qVN 8V0PuwYtAOtsPNptg9Dmwaih8r4sycGKqj5W5WqrunWsk9A5TzpXf/5+/JDxa3sm F/96ksmfQW5MJRuDlOo80LXyHacve9+7DQuKpKE0FvtwQj9oWWboYl2ige9Skv2w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedriedugddufeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlqdehmdenucfjughrpefhvffujghffgffkfggtgesghdtreertder tdenucfhrhhomhepofgrrhhiuhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrg hilhdrtghomheqnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpnhhishhtrdhgohhv necukfhppeekgedrvddtvddrieekrdejheenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 65F7730600DC; Mon, 10 Feb 2020 16:10:48 -0500 (EST) From: Marius Bakke To: goodoldpaul@autistici.org Subject: Re: [bug#38687] [PATCH] gnu: Add libtcod. In-Reply-To: References: <20191220123739.18081-1-goodoldpaul@autistici.org> <875zi6j3c1.fsf@gnu.org> <891e12c54b84a6f4caad6b4c72f1ecba@autistici.org> <87muaftj2u.fsf@devup.no> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Mon, 10 Feb 2020 22:10:46 +0100 Message-ID: <87mu9q2lnt.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38687 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 38687@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable goodoldpaul@autistici.org writes: > Hi Marius and Ludo, > I managed to remove all vendored libraries except for glad.h which seems= =20 > to be some kind of generated glue code for loading OpenGL=20 > (https://github.com/Dav1dde/glad). In the next two patches I'm adding=20 > libtcod and it's dependency lodepng. Excellent, thanks for taking the time to get rid of the bundled dependencies. > Guix lint is warning me that lodepng could be affected by=20 > CVE-2019-17178, but taking a look at=20 > https://nvd.nist.gov/vuln/detail/CVE-2019-17178 and=20 > https://nvd.nist.gov/vuln/search/results?adv_search=3Dtrue&cpe_version=3D= cpe%3a%2fa%3alodev%3alodepng%3a2019-09-28=20 > seems to indicate that lodepng should be *not* vulnerable since=20 > 28/09/2019, did I understand correctly? > > Please don't hesitate and tell me if anything should done w.r.t. the=20 > CVE. The CVE entry points to this commit: https://github.com/FreeRDP/FreeRDP/commit/9fee4ae076b1ec97b97efb79ece08d1da= b4df29a Which changes something in FreeRDP's bundled version of LodePNG. The changes in question do not seem to be in upstream LodePNG: https://github.com/lvandeve/lodepng/blob/master/lodepng.cpp#L1079 It's not clear to me whether this is a problem with LodePNG, or just improper use of its API. It looks like the latter: tree->lengths is checked just below the changed line, so FreeRDP must be catching the 83 return code and keep going to get the memory leak described in the CVE entry. We can either ignore it using the 'lint-hidden-cve' property, and add a comment that this version of LodePNG should not be used with FreeRDP; or take the patch from FreeRDP, as it looks innocent enough. I don't really have a strong opinion here, nor sufficient expertise, so I'd be happy if others could chime in. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl5BxtYACgkQoqBt8qM6 VPrY0AgA1WuzKGgN/K23b4yO5eT/gq78BTD+QvZ/YTdxAhdwatfilxDE6vNm5xmT y5FPNnEbfMwlqi8+/LxMZNfCNczzkmXKy8pMt1GW61J+sQzPludhNvAU43SOMdZL 0aKcEXvFh3rKR6/9yk55eENoqfEuI9gYnt335C60qbmBPa0uOXPOEC+k/4E32KR4 O/laJ/YfXFDv/cMWso2M7tA85mN2qrMhKWnJ/mKuxZuOJmxbZpHLAHozNi7KbzUz +tauaBC/rApfUpovgUNFKkJI2PgPigen5MLUl48o4yJU/RvWEqnef9JYtRpCTvia ZgnEujkaBxC7njlCPpfFQfGFKKQguw== =CwEa -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 10 16:14:59 2020 Received: (at 38687) by debbugs.gnu.org; 10 Feb 2020 21:14:59 +0000 Received: from localhost ([127.0.0.1]:55610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1GOQ-0004Hf-L2 for submit@debbugs.gnu.org; Mon, 10 Feb 2020 16:14:58 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:48485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1GOP-0004HS-26 for 38687@debbugs.gnu.org; Mon, 10 Feb 2020 16:14:57 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 22EB0680; Mon, 10 Feb 2020 16:14:51 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 10 Feb 2020 16:14:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=dC/w3h5kFdgjNe9Ta3mlT3W8qr lM8NkwbAQkFbR+vpE=; b=KQ75KVDm9kY3OzLM5NnCtWY7/IWGX5i56gEVFhL1FX odubDGfTe3pRMuVkLTnoxG0Y0PXxWk0p5iyj3Hvduy0jbO/vIk8EHh7NvmDLToN6 Vit1UlkyWheNed4f5x+/dhAecUnR91PE3xq6ngzcye7NS94TxKr4nm/z3I66WoeE rQhjT7Ubmqs37AKq19B7Q3AuUq1PxLl1WRC/bc1XvjTdqBI8FZyEaEq1//rdpJ/S 8RhyEXADdnGgn/bpVXlOU1OmgfTfa4e/1Dhv61xKT9cfy24XbmuCABDtJm40cb2h 9NV6rBKGUIpEyjVIBcJjP71gnsqyAQl24Wpb/WG31Ntg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=dC/w3h 5kFdgjNe9Ta3mlT3W8qrlM8NkwbAQkFbR+vpE=; b=uBWCwDZJpmv2qhG4qs+IOe qV9hZVAL8f57SwYJJe9oLCvdEoeW/7srPCUhFYdMxYOxQfjR0TaIZBAUcp6m10eG 0FcsSGytdS06YM+sLqkztq+4nmEevyGyFF0eFzxZud2VSm1cqiPw9pMgn/5ZguXN 5JoAQ2OhlTiL69xlcjM7sWEzTcHNcnGf/EcKRJP/HsCkK0FTwRlsmcs1nMTypSWS f8ktM5IGyEybAiBgrZpFwXfd0lfi+uekpqk6hXiYnkb3/rjywIkc8ve7n2rKqPYR 1/gjrvYLh/WHIko9LxfMs1kPjCHAH1B4tQHWy/zdFHd/Q/+gH54YjiW+dqUAd+uw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedriedugddufeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffgffkfggtgesghdtre ertdertdenucfhrhhomhepofgrrhhiuhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghs thhmrghilhdrtghomheqnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepke egrddvtddvrdeikedrjeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepmhgsrghkkhgvsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 3ED1B3060272; Mon, 10 Feb 2020 16:14:50 -0500 (EST) From: Marius Bakke To: Giacomo Leidi , 38687@debbugs.gnu.org Subject: Re: [bug#38687] [PATCH 1/2] gnu: Add lodepng. In-Reply-To: <20200206201713.8535-1-goodoldpaul@autistici.org> References: <20191220123739.18081-1-goodoldpaul@autistici.org> <20200206201713.8535-1-goodoldpaul@autistici.org> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Mon, 10 Feb 2020 22:14:48 +0100 Message-ID: <87k14u2lh3.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38687 Cc: Giacomo Leidi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Giacomo Leidi writes: > * gnu/packages/image.scm (lodepng): New variable. [...] > +(define-public lodepng > + ;; The project doesn't seem to use any > + ;; kind of meaningful versioning scheme. > + (let ((commit "5a0dba103893e6b8084be13945a826663917d00a") > + (revision "1") > + (version "0.0.0")) There is a LODEPNG_VERSION_STRING in lodepng.cpp, can you set the "version" variable here to that? > + (package > + (name "lodepng") > + (version (git-version version revision commit)) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/lvandeve/lodepng") > + (commit commit))) > + (sha256 > + (base32 > + "0nvlba82mf4n7xfc3rz2g9wwgnrxpjw64p5dsjmj2r06g5m4l38a")) > + (file-name (git-file-name name version)))) > + (build-system gnu-build-system) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (replace 'build > + (lambda _ > + (setenv "CXXFLAGS" "-fPIC") > + (invoke "make" "lodepng.o") > + (invoke "make" "lodepng_util.o") > + (invoke "ar" "rv" "liblodepng.a" "lodepng.o" "lodepng_util.o") > + (invoke "g++" "-fPIC" "-O3" > + "-o" "liblodepng.so" > + "-shared" "lodepng.o" "lodepng_util.o") > + #t)) > + (replace 'check > + (lambda _ > + (invoke "make" "unittest") > + (invoke "./unittest") > + #t)) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (doc (string-append out "/share/doc")) > + (lib (string-append out "/lib")) > + (include (string-append out "/include"))) > + (install-file "lodepng.h" include) > + (install-file "lodepng_util.h" include) > + (install-file "liblodepng.a" lib) We try to avoid static libraries in Guix, so no need to install this file. Otherwise LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl5Bx8gACgkQoqBt8qM6 VPrCFAf+N2wYO+ZVQN8zb4THvPsVkIDyece9cITwV22YeQbeZUdbSzSBBNZ3imi0 RxZ5rSBkR57ilPxIIXUUPnFDWr0Ini5d2p/KUVKL05QCyySxOpsc7O6+YVe/jT3e FxAxeB0My5GgKGtIe3CacrLGkRfnrB/+xT2B1vRnLROT9CDtLQ6qBZ8dunR+1DhN 2Xm3UvVyV86ppqlBBpgaU7nFz44ENS7qibthbI+RNfR9MrPhVa+TMWvx8dlkzVdJ ZRT6WMq1tHKBMHEa5xYpUougxO7gqVE1EZ2gD6TI7bC/4RVdZiwS7SBl82OXc6V3 2FZ3mPr0hw88I0QnRRM2uRi9Y54Jag== =+GmG -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 10 16:19:52 2020 Received: (at 38687) by debbugs.gnu.org; 10 Feb 2020 21:19:53 +0000 Received: from localhost ([127.0.0.1]:55621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1GTA-0004PC-It for submit@debbugs.gnu.org; Mon, 10 Feb 2020 16:19:52 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:56617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1GT8-0004Oz-N3 for 38687@debbugs.gnu.org; Mon, 10 Feb 2020 16:19:51 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id D9DC569A; Mon, 10 Feb 2020 16:19:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 10 Feb 2020 16:19:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=sUw90//uI2Bq9PPNUmkWLKgs62 xIBGh7yLCGgWW5IMo=; b=hYp9RPosu+SSdvf5y16ZvtVfLmQUxeMReRDzcheQFF nWv32KNFhdvt/dLDXpNl8YDIURom7addhi0m2Cg4B/oJwAKUEBS3zmCJCcqr0kx8 /xjpPmlPSpKghudVUH8fiMMoEBqlgbQyLf7EHPP7kLuh/vP6tYQ1yEvtjxLQHxZN mZUbqxF9MiBPdvux3Nt/l+e/qvS4k8NXljgsTxmOwa6DKoE5EMaiPLmFGThX6avL bReUKGs1crv3DlCLJ1cAkEAHXu9nwUwhMYKkovGUFj/nEekKL4kErXr8XeGoVzsr Rc2GO1OBHzcTKLaYI1mHRuWxvqicqSBpTE9yMwMR6Emw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=sUw90/ /uI2Bq9PPNUmkWLKgs62xIBGh7yLCGgWW5IMo=; b=E967tMgmdmJ7d4oK665ZQF /KzskvoQMJh+arTld0ZAkaoweRI03ldB3V3VwtJupBIeIIF6TtImj+I2wEUQg3ar EhhW8Xv7BbYSE2/24OqCGCE303yX5/gucQO49wYvBDSp4X7RM9H2VZT/s1nVNtRt 0/tfhmPLgXRLjWCLRjTVz9VhhD+3tPscdkqA+SG6JdAo+dPl/I6MOGiUH790UkE0 16feyqI5r4CIGcvbmxycpt1QQ7qJHrT82SC94qj3zBryzbHrEo7arxnysfhFxOCX BPanBSBY0gCU3CMY2WUknc97P0iJup1vi8CIcdFbCNvK85THHFeJyYJhgZumxDcQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedriedugddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffgffkfggtgesghdtre ertdertdenucfhrhhomhepofgrrhhiuhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghs thhmrghilhdrtghomheqnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepke egrddvtddvrdeikedrjeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepmhgsrghkkhgvsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 0108D328005A; Mon, 10 Feb 2020 16:19:43 -0500 (EST) From: Marius Bakke To: Giacomo Leidi , 38687@debbugs.gnu.org Subject: Re: [bug#38687] [PATCH 2/2] gnu: Add libtcod. In-Reply-To: <20200206201713.8535-2-goodoldpaul@autistici.org> References: <20200206201713.8535-1-goodoldpaul@autistici.org> <20200206201713.8535-2-goodoldpaul@autistici.org> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Mon, 10 Feb 2020 22:19:41 +0100 Message-ID: <87h7zy2l8y.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38687 Cc: Giacomo Leidi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Giacomo Leidi writes: > * gnu/packages/game-development.scm (libtcod): New variable. [...] > + (add-before 'bootstrap 'remove-hardcoded-vendor-paths > + (lambda _ > + (substitute* "sources.am" > + (("\\.\\./\\.\\./src/vendor/lodepng\\.cpp \\\\\n") "") > + (("\\.\\./\\.\\./src/vendor/stb\\.c \\\\") > + "../../src/vendor/stb.c") > + (("\\.\\./\\.\\./src/vendor/utf8proc/utf8proc\\.c") "")) > + > + (substitute* "../../src/libtcod/sys_sdl_img_png.cpp" > + (("\\.\\./vendor/") "")) > + > + (substitute* '("../../src/libtcod/color/canvas.cpp" > + "../../src/libtcod/sys_sdl_img_png.cpp" > + "../../src/libtcod/tileset/truetype.cpp" > + "../../src/libtcod/tileset/tilesheet.cpp") > + (("\\.\\./\\.\\./vendor/") "")) > + > + (substitute* "../../src/libtcod/console/printing.cpp" > + (("\\.\\./\\.\\./vendor/utf8proc/") "")) > + #t))))) Can you move the contents of this phase to the 'snippet' instead? Since they are related to the unbundling, and makes 'guix build --source libtcod' easier to work with. > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("libtool" ,libtool) > + ("lodepng" ,lodepng) > + ("python" ,python) > + ("pkg-config" ,pkg-config) > + ("sdl2" ,sdl2) sdl2 and lodepng should probably be regular inputs. > + ("stb-sprintf" ,stb-sprintf) > + ("stb-truetype" ,stb-truetype))) > + (inputs > + `(("utf8proc" ,utf8proc) > + ("zlib" ,zlib))) > + (home-page "https://github.com/libtcod/libtcod") > + (synopsis "Library specifically designed for writing roguelikes") > + (description > + "libtcod is a free, fast, portable and uncomplicated API for roguelike s/free// (everything in Guix is free software) Otherwise LGTM! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl5ByO0ACgkQoqBt8qM6 VPrq6wgAhw8IgoV/qMxlyST/nAOq6bHk9T8Qv9Fq8baIYTbTJr1pGE663xfd/PT6 fUSYrUxrWrMSG+fP7uE+MvbtAS0ke4xbHAOJK6XgjD4V8KsVjfscMyOfjpZrJHt5 CL0RryvywgKZIDi/FEghKVNLow/9MogqrQWt/3wsD0E07HyprvkIQszWZh38kZ2l LH92EyPhO+4znPSlN0L8/TqSJRJZytOMjR7rAgd7xTQ62+5T0F+syY+hLY0st5ST 9ei6jvB7iRggvLSd9zJWNseltK1obFe1EyGfWBlwELpj8p6O8U0n55ynrc5q2XVj U3gn3X6rP57XzMdx6+AzzoMZMVlu9g== =5WDq -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 16 16:53:19 2020 Received: (at 38687) by debbugs.gnu.org; 16 Feb 2020 21:53:19 +0000 Received: from localhost ([127.0.0.1]:37821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3Rqg-0000HH-Ee for submit@debbugs.gnu.org; Sun, 16 Feb 2020 16:53:19 -0500 Received: from latitanza.investici.org ([82.94.249.234]:29643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3Rqe-0000H9-Ai for 38687@debbugs.gnu.org; Sun, 16 Feb 2020 16:53:09 -0500 Received: from 1.mail-backend.investici.org (unknown [10.0.0.11]) by latitanza.investici.org (Postfix) with ESMTP id C9954120157; Sun, 16 Feb 2020 21:53:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1581889986; bh=DWRnfu7Bu6dfITg0j2Se5RSkZHX+gHWrF0G6vSN+hQA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GJ2gDY0qUyEqRdpqLEAXU/zYd92fw5ZTlNWJ7DAw8IxIVq8CaVLBWxO4YvjJQ6Ur3 9crGcCwACpd+GDN3OZtcUmslRoHzrWlFy6ZHPVkQDROyInwntLWf+foU6vv+F13+qC orLFw64bu2PgleegLITBsrop/mP1eaHj5lQXvK2g= Received: from 1.webmail.investici.org (localhost [127.0.0.1]) (Authenticated sender: goodoldpaul@autistici.org) by 1.mail-backend.investici.org (Postfix) with ESMTPA id 9B786BEE32; Sun, 16 Feb 2020 21:53:05 +0000 (UTC) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_864d310a3d7924efef72792c70d3f435" Content-Transfer-Encoding: 7bit Date: Sun, 16 Feb 2020 21:53:05 +0000 From: goodoldpaul@autistici.org To: Marius Bakke Subject: Re: [bug#38687] gnu: Add libtcod. In-Reply-To: <87h7zy2l8y.fsf@devup.no> References: <20200206201713.8535-1-goodoldpaul@autistici.org> <20200206201713.8535-2-goodoldpaul@autistici.org> <87h7zy2l8y.fsf@devup.no> User-Agent: Roundcube Webmail Message-ID: X-Sender: goodoldpaul@autistici.org X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38687 Cc: 38687@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=_864d310a3d7924efef72792c70d3f435 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi Marius, I updated the patches and upgrading lodepng led the warning from guix lint disappear so I guess it should be safe now. I'm sending an updated version. Thank you again for your patience, Giacomo --=_864d310a3d7924efef72792c70d3f435 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-Add-lodepng.patch Content-Disposition: attachment; filename=0001-gnu-Add-lodepng.patch; size=3247 RnJvbSA0YWRlYjI5M2RlZjg3ZDRjMTk5ODViNTdiNTZjZDNlMzljY2IzODU5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHaWFjb21vIExlaWRpIDxnb29kb2xkcGF1bEBhdXRpc3RpY2ku b3JnPgpEYXRlOiBTdW4sIDE2IEZlYiAyMDIwIDIyOjIxOjMyICswMTAwClN1YmplY3Q6IFtQQVRD SCAxLzJdIGdudTogQWRkIGxvZGVwbmcuCgoqIGdudS9wYWNrYWdlcy9pbWFnZS5zY20gKGxvZGVw bmcpOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2ltYWdlLnNjbSB8IDU0ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDU0 IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvaW1hZ2Uuc2NtIGIvZ251 L3BhY2thZ2VzL2ltYWdlLnNjbQppbmRleCBmOWRhMWU5ZTg5Li5lMTRkNTYwN2ZjIDEwMDY0NAot LS0gYS9nbnUvcGFja2FnZXMvaW1hZ2Uuc2NtCisrKyBiL2dudS9wYWNrYWdlcy9pbWFnZS5zY20K QEAgLTIzLDYgKzIzLDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAxOCBQaWVycmUtQW50b2luZSBS b3VieSA8Y29udGFjdEBwYXJvdWJ5LmZyPgogOzs7IENvcHlyaWdodCDCqSAyMDE4IEFsZXggVm9u ZyA8YWxleHZvbmcxOTk1QGdtYWlsLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxOCBSdXRnZXIg SGVsbGluZyA8cmhlbGxpbmdAbXlrb2xhYi5jb20+Cis7OzsgQ29weXJpZ2h0IMKpIDIwMjAgR2lh Y29tbyBMZWlkaSA8Z29vZG9sZHBhdWxAYXV0aXN0aWNpLm9yZz4KIDs7OwogOzs7IFRoaXMgZmls ZSBpcyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7CkBAIC0xODQ0LDMgKzE4NDUsNTYgQEAgdXNpbmcg b25seSB0ZXh0IHRvb2xzLgogU05HIGlzIGltcGxlbWVudGVkIGJ5IGEgY29tcGlsZXIvZGVjb21w aWxlciBjYWxsZWQgc25nIHRoYXQKIGxvc3NsZXNzbHkgdHJhbnNsYXRlcyBiZXR3ZWVuIFNORyBh bmQgUE5HLiIpCiAgICAgKGxpY2Vuc2UgbGljZW5zZTp6bGliKSkpCisKKyhkZWZpbmUtcHVibGlj IGxvZGVwbmcKKyAgKGxldCAoKGNvbW1pdCAiNDhlNTM2NGVmNDhlYzI0MDhmNDRjNzI3NjU3YWMx YjY3MDMxODVmOCIpCisgICAgICAgIChyZXZpc2lvbiAiMSIpCisgICAgICAgICh2ZXJzaW9uICIy MDIwMDIxNSIpKQorICAgIChwYWNrYWdlCisgICAgICAobmFtZSAibG9kZXBuZyIpCisgICAgICAo dmVyc2lvbiAoZ2l0LXZlcnNpb24gdmVyc2lvbiByZXZpc2lvbiBjb21taXQpKQorICAgICAgKHNv dXJjZSAob3JpZ2luCisgICAgICAgICAgICAgICAgKG1ldGhvZCBnaXQtZmV0Y2gpCisgICAgICAg ICAgICAgICAgKHVyaSAoZ2l0LXJlZmVyZW5jZQorICAgICAgICAgICAgICAgICAgICAgICh1cmwg Imh0dHBzOi8vZ2l0aHViLmNvbS9sdmFuZGV2ZS9sb2RlcG5nIikKKyAgICAgICAgICAgICAgICAg ICAgICAoY29tbWl0IGNvbW1pdCkpKQorICAgICAgICAgICAgICAgIChzaGEyNTYKKyAgICAgICAg ICAgICAgICAgKGJhc2UzMgorICAgICAgICAgICAgICAgICAgIjFhMXg4YWcyc2NhbnpiMjA2Nmpt OWhnMnk5a2FhM3dtcGdtejEwbDF4OWJrcGlrNjEybHciKSkKKyAgICAgICAgICAgICAgICAoZmls ZS1uYW1lIChnaXQtZmlsZS1uYW1lIG5hbWUgdmVyc2lvbikpKSkKKyAgICAgIChidWlsZC1zeXN0 ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAgIChhcmd1bWVudHMKKyAgICAgICAnKCM6cGhhc2Vz CisgICAgICAgICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAgIChk ZWxldGUgJ2NvbmZpZ3VyZSkKKyAgICAgICAgICAgKHJlcGxhY2UgJ2J1aWxkCisgICAgICAgICAg ICAgKGxhbWJkYSBfCisgICAgICAgICAgICAgICAoc2V0ZW52ICJDWFhGTEFHUyIgIi1mUElDIikK KyAgICAgICAgICAgICAgIChpbnZva2UgIm1ha2UiICJsb2RlcG5nLm8iKQorICAgICAgICAgICAg ICAgKGludm9rZSAibWFrZSIgImxvZGVwbmdfdXRpbC5vIikKKyAgICAgICAgICAgICAgIChpbnZv a2UgImcrKyIgIi1mUElDIiAiLU8zIgorICAgICAgICAgICAgICAgICAgICAgICAiLW8iICJsaWJs b2RlcG5nLnNvIgorICAgICAgICAgICAgICAgICAgICAgICAiLXNoYXJlZCIgImxvZGVwbmcubyIg ImxvZGVwbmdfdXRpbC5vIikKKyAgICAgICAgICAgICAgICN0KSkKKyAgICAgICAgICAgKHJlcGxh Y2UgJ2NoZWNrCisgICAgICAgICAgICAgKGxhbWJkYSBfCisgICAgICAgICAgICAgICAoaW52b2tl ICJtYWtlIiAidW5pdHRlc3QiKQorICAgICAgICAgICAgICAgKGludm9rZSAiLi91bml0dGVzdCIp CisgICAgICAgICAgICAgICAjdCkpCisgICAgICAgICAgIChyZXBsYWNlICdpbnN0YWxsCisgICAg ICAgICAgICAgKGxhbWJkYSogKCM6a2V5IG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAg ICAgICAgICAgICAgKGxldCogKChvdXQgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSkKKyAgICAg ICAgICAgICAgICAgICAgICAoZG9jIChzdHJpbmctYXBwZW5kIG91dCAiL3NoYXJlL2RvYyIpKQor ICAgICAgICAgICAgICAgICAgICAgIChsaWIgKHN0cmluZy1hcHBlbmQgb3V0ICIvbGliIikpCisg ICAgICAgICAgICAgICAgICAgICAgKGluY2x1ZGUgKHN0cmluZy1hcHBlbmQgb3V0ICIvaW5jbHVk ZSIpKSkKKyAgICAgICAgICAgICAgICAgKGluc3RhbGwtZmlsZSAibG9kZXBuZy5oIiBpbmNsdWRl KQorICAgICAgICAgICAgICAgICAoaW5zdGFsbC1maWxlICJsb2RlcG5nX3V0aWwuaCIgaW5jbHVk ZSkKKyAgICAgICAgICAgICAgICAgKGluc3RhbGwtZmlsZSAibGlibG9kZXBuZy5zbyIgbGliKQor ICAgICAgICAgICAgICAgICAoaW5zdGFsbC1maWxlICJSRUFETUUubWQiIGRvYykKKyAgICAgICAg ICAgICAgICAgI3QpKSkpKSkKKyAgICAgIChob21lLXBhZ2UgImh0dHBzOi8vbG9kZXYub3JnL2xv ZGVwbmcvIikKKyAgICAgIChzeW5vcHNpcyAiUE5HIGVuY29kZXIgYW5kIGRlY29kZXIgaW4gQyBh bmQgQysrLCB3aXRob3V0IGRlcGVuZGVuY2llcyIpCisgICAgICAoZGVzY3JpcHRpb24gIkxvZGVQ TkcgaXMgYSBQTkcgaW1hZ2UgZGVjb2RlciBhbmQgZW5jb2RlciwgYWxsIGluIG9uZSwKK25vIGRl cGVuZGVuY3kgb3IgbGlua2FnZSByZXF1aXJlZC4gIEl0J3MgbWFkZSBmb3IgQyAoSVNPIEM5MCks IGFuZCBoYXMgYSBDKysKK3dyYXBwZXIgd2l0aCBhIG1vcmUgY29udmVuaWVudCBpbnRlcmZhY2Ug b24gdG9wLiIpCisgICAgICAobGljZW5zZSBsaWNlbnNlOnpsaWIpKSkpCi0tIAoyLjI1LjAKCg== --=_864d310a3d7924efef72792c70d3f435 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0002-gnu-Add-libtcod.patch Content-Disposition: attachment; filename=0002-gnu-Add-libtcod.patch; size=4539 RnJvbSBjODhhMGMxMjg1NWMyZWM4MmI1NjUzZWJlODEzN2JjMTI0NWFhMzY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHaWFjb21vIExlaWRpIDxnb29kb2xkcGF1bEBhdXRpc3RpY2ku b3JnPgpEYXRlOiBTdW4sIDE2IEZlYiAyMDIwIDIyOjQyOjQyICswMTAwClN1YmplY3Q6IFtQQVRD SCAyLzJdIGdudTogQWRkIGxpYnRjb2QuCgoqIGdudS9wYWNrYWdlcy9nYW1lLWRldmVsb3BtZW50 LnNjbSAobGlidGNvZCk6IE5ldyB2YXJpYWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvZ2FtZS1kZXZl bG9wbWVudC5zY20gfCA3NCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUg Y2hhbmdlZCwgNzQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9nYW1l LWRldmVsb3BtZW50LnNjbSBiL2dudS9wYWNrYWdlcy9nYW1lLWRldmVsb3BtZW50LnNjbQppbmRl eCA2ZmE0ZmVkNzRmLi43MjQxYzBmOGM3IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvZ2FtZS1k ZXZlbG9wbWVudC5zY20KKysrIGIvZ251L3BhY2thZ2VzL2dhbWUtZGV2ZWxvcG1lbnQuc2NtCkBA IC0xOSw2ICsxOSw3IEBACiA7OzsgQ29weXJpZ2h0IMKpIDIwMTkgSmV0aHJvIENhbyA8amV0aHJv Y2FvQGdtYWlsLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAyMCBOaWNvbGFzIEdvYXppb3UgPG1h aWxAbmljb2xhc2dvYXppb3UuZnI+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMjAgVGltb3RlaiBMYXph ciA8dGltb3Rlai5sYXphckBhcmFuZW8uc2k+Cis7OzsgQ29weXJpZ2h0IMKpIDIwMjAgR2lhY29t byBMZWlkaSA8Z29vZG9sZHBhdWxAYXV0aXN0aWNpLm9yZz4KIDs7OwogOzs7IFRoaXMgZmlsZSBp cyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7CkBAIC04OCw2ICs4OSw3IEBACiAgICM6dXNlLW1vZHVs ZSAoZ251IHBhY2thZ2VzIHNwaGlueCkKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgc3Ri KQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyB0ZXhpbmZvKQorICAjOnVzZS1tb2R1bGUg KGdudSBwYWNrYWdlcyB0ZXh0dXRpbHMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHRs cykKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgdmlkZW8pCiAgICM6dXNlLW1vZHVsZSAo Z251IHBhY2thZ2VzIHdlYikKQEAgLTIwODYsMyArMjA4OCw3NSBAQCBjb21wdXRlciBnYW1lcywg M0QgYXV0aG9yaW5nIHRvb2xzIGFuZCBzaW11bGF0aW9uIHRvb2xzLiIpCiAgICAgKGRlc2NyaXB0 aW9uICJDaGlwbXVuayBpcyBhIHNpbXBsZSwgbGlnaHR3ZWlnaHQsIGZhc3QgYW5kIHBvcnRhYmxl IDJECiByaWdpZCBib2R5IHBoeXNpY3MgbGlicmFyeSB3cml0dGVuIGluIEMuIikKICAgICAobGlj ZW5zZSBsaWNlbnNlOmV4cGF0KSkpCisKKyhkZWZpbmUtcHVibGljIGxpYnRjb2QKKyAgKHBhY2th Z2UKKyAgICAobmFtZSAibGlidGNvZCIpCisgICAgKHZlcnNpb24gIjEuMTUuMSIpCisgICAgKHNv dXJjZSAob3JpZ2luCisgICAgICAgICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQorICAgICAgICAg ICAgICAodXJpIChnaXQtcmVmZXJlbmNlCisgICAgICAgICAgICAgICAgICAgICh1cmwgImh0dHBz Oi8vZ2l0aHViLmNvbS9saWJ0Y29kL2xpYnRjb2QuZ2l0IikKKyAgICAgICAgICAgICAgICAgICAg KGNvbW1pdCB2ZXJzaW9uKSkpCisgICAgICAgICAgICAgIChmaWxlLW5hbWUgKGdpdC1maWxlLW5h bWUgbmFtZSB2ZXJzaW9uKSkKKyAgICAgICAgICAgICAgKHNoYTI1NgorICAgICAgICAgICAgICAg KGJhc2UzMgorICAgICAgICAgICAgICAgICIwcHpyOGFqbWJxdmg0M2xkamFqeDk2MnhpcmozcmY4 YXloMzQ0cDZtcWxybWI4Z3hyZnI1IikpCisgICAgICAgICAgICAgIChtb2R1bGVzICcoKGd1aXgg YnVpbGQgdXRpbHMpKSkKKyAgICAgICAgICAgICAgKHNuaXBwZXQgJyhiZWdpbgorICAgICAgICAg ICAgICAgICAgICAgICAgICAoZGVsZXRlLWZpbGUtcmVjdXJzaXZlbHkgInNyYy92ZW5kb3IvdXRm OHByb2MiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAoZGVsZXRlLWZpbGUtcmVjdXJzaXZl bHkgInNyYy92ZW5kb3IvemxpYiIpCisgICAgICAgICAgICAgICAgICAgICAgICAgIChkZWxldGUt ZmlsZSAic3JjL3ZlbmRvci9zdGJfdHJ1ZXR5cGUuaCIpCisgICAgICAgICAgICAgICAgICAgICAg ICAgIChkZWxldGUtZmlsZSAic3JjL3ZlbmRvci9zdGJfc3ByaW50Zi5oIikKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgKGRlbGV0ZS1maWxlICJzcmMvdmVuZG9yL2xvZGVwbmcuY3BwIikKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgKGRlbGV0ZS1maWxlICJzcmMvdmVuZG9yL2xvZGVwbmcu aCIpCisKKyAgICAgICAgICAgICAgICAgICAgICAgICAgKHN1YnN0aXR1dGUqICJidWlsZHN5cy9h dXRvdG9vbHMvc291cmNlcy5hbSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAoKCJcXC5c XC4vXFwuXFwuL3NyYy92ZW5kb3IvbG9kZXBuZ1xcLmNwcCBcXFxcXG4iKSAiIikKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAoKCJcXC5cXC4vXFwuXFwuL3NyYy92ZW5kb3Ivc3RiXFwuYyBc XFxcIikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIi4uLy4uL3NyYy92ZW5kb3Ivc3Ri LmMiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICgoIlxcLlxcLi9cXC5cXC4vc3JjL3Zl bmRvci91dGY4cHJvYy91dGY4cHJvY1xcLmMiKSAiIikpCisKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgKHN1YnN0aXR1dGUqICJzcmMvbGlidGNvZC9zeXNfc2RsX2ltZ19wbmcuY3BwIgorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICgoIlxcLlxcLi92ZW5kb3IvIikgIiIpKQorCisgICAg ICAgICAgICAgICAgICAgICAgICAgIChzdWJzdGl0dXRlKiAnKCJzcmMvbGlidGNvZC9jb2xvci9j YW52YXMuY3BwIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAic3Jj L2xpYnRjb2Qvc3lzX3NkbF9pbWdfcG5nLmNwcCIKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgInNyYy9saWJ0Y29kL3RpbGVzZXQvdHJ1ZXR5cGUuY3BwIgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAic3JjL2xpYnRjb2QvdGlsZXNldC90 aWxlc2hlZXQuY3BwIikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAoKCJcXC5cXC4vXFwu XFwuL3ZlbmRvci8iKSAiIikpCisKKyAgICAgICAgICAgICAgICAgICAgICAgICAgKHN1YnN0aXR1 dGUqICJzcmMvbGlidGNvZC9jb25zb2xlL3ByaW50aW5nLmNwcCIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoKCJcXC5cXC4vXFwuXFwuL3ZlbmRvci91dGY4cHJvYy8iKSAiIikpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICN0KSkpKQorICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxk LXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAgIGAoIzpjb25maWd1cmUtZmxhZ3MgJygiLS13 aXRoLWdudS1sZCIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICJMSUJTPS1sdXRmOHByb2Mg LWxsb2RlcG5nIikKKyAgICAgICAjOnBoYXNlcworICAgICAgIChtb2RpZnktcGhhc2VzICVzdGFu ZGFyZC1waGFzZXMKKyAgICAgICAgIChhZGQtYWZ0ZXIgJ3VucGFjayAnY2hhbmdlLXRvLWJ1aWxk LWRpcgorICAgICAgICAgICAobGFtYmRhIF8KKyAgICAgICAgICAgICAoY2hkaXIgImJ1aWxkc3lz L2F1dG90b29scyIpCisgICAgICAgICAgICAgKHBhdGNoLXNoZWJhbmcgImdldF92ZXJzaW9uLnB5 IikKKyAgICAgICAgICAgICAjdCkpKSkpCisgICAgKG5hdGl2ZS1pbnB1dHMKKyAgICAgYCgoImF1 dG9jb25mIiAsYXV0b2NvbmYpCisgICAgICAgKCJhdXRvbWFrZSIgLGF1dG9tYWtlKQorICAgICAg ICgibGlidG9vbCIgLGxpYnRvb2wpCisgICAgICAgKCJweXRob24iICxweXRob24pCisgICAgICAg KCJwa2ctY29uZmlnIiAscGtnLWNvbmZpZykKKyAgICAgICAoInN0Yi1zcHJpbnRmIiAsc3RiLXNw cmludGYpCisgICAgICAgKCJzdGItdHJ1ZXR5cGUiICxzdGItdHJ1ZXR5cGUpKSkKKyAgICAoaW5w dXRzCisgICAgIGAoKCJsb2RlcG5nIiAsbG9kZXBuZykKKyAgICAgICAoInNkbDIiICxzZGwyKQor ICAgICAgICgidXRmOHByb2MiICx1dGY4cHJvYykKKyAgICAgICAoInpsaWIiICx6bGliKSkpCisg ICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9naXRodWIuY29tL2xpYnRjb2QvbGlidGNvZCIpCisgICAg KHN5bm9wc2lzICJMaWJyYXJ5IHNwZWNpZmljYWxseSBkZXNpZ25lZCBmb3Igd3JpdGluZyByb2d1 ZWxpa2VzIikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAgImxpYnRjb2QgaXMgYSBmYXN0LCBwb3J0 YWJsZSBhbmQgdW5jb21wbGljYXRlZCBBUEkgZm9yIHJvZ3VlbGlrZQorZGV2ZWxvcGVycyBwcm92 aWRpbmcgYW4gYWR2YW5jZWQgdHJ1ZSBjb2xvciBjb25zb2xlLCBpbnB1dCwgYW5kIGxvdHMgb2Yg b3RoZXIKK3V0aWxpdGllcyBmcmVxdWVudGx5IHVzZWQgaW4gcm9ndWVsaWtlcy4iKQorICAgIChs aWNlbnNlIGxpY2Vuc2U6YnNkLTMpKSkKLS0gCjIuMjUuMAoK --=_864d310a3d7924efef72792c70d3f435-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 24 15:56:42 2020 Received: (at 38687-done) by debbugs.gnu.org; 24 Feb 2020 20:56:42 +0000 Received: from localhost ([127.0.0.1]:54171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j6KmQ-00054C-IV for submit@debbugs.gnu.org; Mon, 24 Feb 2020 15:56:42 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:41985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j6KmO-00053z-KZ for 38687-done@debbugs.gnu.org; Mon, 24 Feb 2020 15:56:41 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 628D421A97; Mon, 24 Feb 2020 15:56:35 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 24 Feb 2020 15:56:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=+VbpCd1csY7lFemauVzx8SS8mP QztosEc+oym3sFy4w=; b=NSgBM7MxTLrysmjOYQFErStVBmqOUoUNDrwPVvKRHc MX9H1uXsjqHsEQXOfL7qOeQm0AP89Rag1v6JbyeykQYQ4aNs6PLMoRBlDmCLbQEp l7u04aYCsd+Sdq4W4Gb+DKQjkNwq8sZvIsYpiHgVKNP/9VkI62P568fSD+TKdJDs DrLNIMyfcyEq8CoL2cXCOkoTAMlfkhPktKbYTwM1UZr+rQja5KA2E42Z9jGyU/O7 ykPTs5mrkck+abiIJeLl6bm0y6B+pTk5eADW5TeJzcH/evP+IbbUOapTONQ6UUyA sAHr5te7HXYh7teS6O2wSppycVnsOxuI+NBzV7WUWVQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+VbpCd 1csY7lFemauVzx8SS8mPQztosEc+oym3sFy4w=; b=e+LHCo0KN7MEq1REUvlzfE kLhG1bnWZgxQM3tciOaFELwUZ6xFoeiYsT+ofmHv/rNlSCAqFXJJSyO92JEwROB5 pn+j4lB/nTg0uqMPaSjSKRImhl9j/W5czSD1B75IKloiI2DFpQMHD21IvRSelJzu waZda/2UPgYp3/dAlMkMMAfwb+YDkmgHIQH6ib7o/LMs0bVe0jDfOGPP4eZndgX1 XzJgwtc97k8PctIqg45BvSZ7njLK92yy6oEzVBKk2e4amm+foezp+exuHPpxtKwa OFDEMWB7il1yedjMppX5FeoO7OMXS3c19zLrt3mQX+urCE+oL/+MM60O5wcQq7SA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrledtgddugeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffgffkfggtgesghdtre ertdertdenucfhrhhomhepofgrrhhiuhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghs thhmrghilhdrtghomheqnecukfhppeekgedrvddtvddrieekrdejheenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id A5BAD3280063; Mon, 24 Feb 2020 15:56:34 -0500 (EST) From: Marius Bakke To: goodoldpaul@autistici.org Subject: Re: [bug#38687] gnu: Add libtcod. In-Reply-To: References: <20200206201713.8535-1-goodoldpaul@autistici.org> <20200206201713.8535-2-goodoldpaul@autistici.org> <87h7zy2l8y.fsf@devup.no> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Mon, 24 Feb 2020 21:56:32 +0100 Message-ID: <87ftez4scf.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38687-done Cc: 38687-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable goodoldpaul@autistici.org writes: > Hi Marius, > I updated the patches and upgrading lodepng led the warning from guix=20 > lint disappear so I guess it should be safe now. I'm sending an updated=20 > version. Thanks! I applied both patches, and added a comment about the lodepng version number for our future selves. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl5UOIAACgkQoqBt8qM6 VPpaoAf/Soqh9NwCrEucBQheYyScdMCPe8f7FlWbnBfb/VwrBKsH7oajTyhLYy2T 28HUYhMM0dizKvza/VZ3dV9jcoZXiW5h86cu1zoanDLqUsp7ha1fCXxaY41M2u0n kDiR7zdNtObixcbp1rVltO7aSKjcfczI8Y5HM62DwBm/S+tPfzzc3kN8ZSB9IYLf XmZ1oLlMxmvRxd7cmNauphdvInYaepmW0EsllOkMlBImcdITClRiTJvV0LwyBKHe yijUKWSiNqXVibi+dUs2TeNH2kULuPntNBkpOIuoWGOFmLC0y1XAUlbLEIr70czy UTDxrmM7S8uyvSEYWFJByoG/DHjWUw== =MH48 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 17 22:02:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 24 Mar 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator