Subject: bug#38686: closed (Re: [bug#38686] [PATCH] gnu: Add mpv-mpris.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 23 Dec 2019 20:34:02 +0000

Your bug report

#38686: [PATCH] gnu: Add mpv-mpris.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
38686: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38686
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#38686] [PATCH] gnu: Add mpv-mpris.
From: Efraim Flashner <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked]
Date: Mon, 23 Dec 2019 22:33:21 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

On Mon, Dec 23, 2019 at 07:31:02PM +0100, Ludovic Courtès wrote:
> Hello!
> 
> Efraim Flashner <[email-masked]> skribis:
> 
> > * gnu/packages/video.scm (mpv-mpris): New variable.
> 
> [...]
> 
> > +    (home-page "https://github.com/hoyon/mpv-mpris")
> > +    (synopsis "MPRIS plugin for mpv")
> > +    (description "MPRIS plugin for mpv written in C.  Implements
> > +@code{org.mpris.MediaPlayer2} and @code{org.mpris.MediaPlayer2.Player} D-Bus
> > +interfaces.
> 
> Please write full sentences and provide some context, like:
> 
>   This package provides a plugin for the mpv media player, adding
>   support for the Mblah… System (MPRIS).  It implements the …

Sounds good

> 
> > +To load this plugin, specify the following option when starting mpv:
> > +@code{--script $GUIX_PROFILE/lib/mpris.so} or link it into
> > +$HOME/.config/mpv/scripts")
>   ^
> @file

Ok

> 
> Otherwise LGTM!  :-)
> 
> Ludo’, who doesn’t know what MPRIS is.

It's the magic that lets you control media playback from your phone
after connecting with kdeconnect. I'm sure it also has other things it
can do.

-- 
Efraim Flashner   <[email-masked]>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Subject: [PATCH] gnu: Add mpv-mpris.
From: Efraim Flashner <[email-masked]>
To: [email-masked]
Cc: Efraim Flashner <[email-masked]>
Date: Fri, 20 Dec 2019 11:04:03 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/video.scm (mpv-mpris): New variable.
---
 gnu/packages/video.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index ef60767236..fb62fc62a2 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1436,6 +1436,48 @@ projects while introducing many more.")
 (define-public gnome-mpv
   (deprecated-package "gnome-mpv" celluloid))
 
+(define-public mpv-mpris
+  (package
+    (name "mpv-mpris")
+    (version "0.2")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/hoyon/mpv-mpris")
+               (commit version)))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32
+          "06hq3j1jjlaaz9ss5l7illxz8vm5bng86jl24kawglwkqayhdnjx"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:tests? #f ; no tests
+       #:make-flags '("CC=gcc")
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure) ; no configure script
+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (install-file "mpris.so" (string-append out "/lib")))
+             #t)))))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("glib" ,glib)
+       ("mpv" ,mpv)))
+    (home-page "https://github.com/hoyon/mpv-mpris")
+    (synopsis "MPRIS plugin for mpv")
+    (description "MPRIS plugin for mpv written in C.  Implements
+@code{org.mpris.MediaPlayer2} and @code{org.mpris.MediaPlayer2.Player} D-Bus
+interfaces.
+
+To load this plugin, specify the following option when starting mpv:
+@code{--script $GUIX_PROFILE/lib/mpris.so} or link it into
+$HOME/.config/mpv/scripts")
+    (license license:expat)))
+
 (define-public libvpx
   (package
     (name "libvpx")
-- 
2.24.1